February 2001 - Wine-Devel - list.winehq.org

The printer setup dialog
by Duane Clark Feb. 4, 2001

Feb. 4, 2001

Howdy, Since I see there has been a fair amount of activity on the printer stuff lately, I thought I would try submitting this patch to hopefully fix some things in the printer setup dialog box. I have been using this patch unchanged for about six months, on a couple of different applications under wine. The patch contains two chunks. The first chunk attempts to fix these problems in the Paper Size and Source combo boxes: 1) Every time the printer setup dialog is opened, the settings are set back to garbage settings. 2) If the paper size or source is changed, and then the printer is changed, the new printer does not get the new size and source settings even though it appears to from the dialog. The second chunk simply attempts to make the Landscape/Portrait buttons do something. They were there and could be clicked on, and all the supporting code for actually printing in a landscape orientation was there, but the actual code for making the buttons invoke something was for some mysterious reason missing. Duane Index: dlls/commdlg/printdlg.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/printdlg.c,v retrieving revision 1.34 diff -u -r1.34 printdlg.c --- dlls/commdlg/printdlg.c 2001/01/22 02:13:58 1.34 +++ dlls/commdlg/printdlg.c 2001/02/05 00:13:50 @@ -373,8 +373,30 @@ /* query the dialog box for the current selected value */ Sel = SendDlgItemMessageA(hDlg, nIDComboBox, CB_GETCURSEL, 0, 0); if(Sel != CB_ERR) { - oldWord = SendDlgItemMessageA(hDlg, nIDComboBox, CB_GETITEMDATA, Sel, - 0); + /* we enter here only if a different printer is selected after + * the Print Setup dialog is opened. The current settings are + * stored into the newly selected printer. + */ + oldWord = SendDlgItemMessageA(hDlg, nIDComboBox, CB_GETITEMDATA, + Sel, 0); + if (dm) { + if (nIDComboBox == cmb2) + dm->u1.s1.dmPaperSize = oldWord; + else + dm->dmDefaultSource = oldWord; + } + } + else { + /* we enter here only when the Print setup dialog is initially + * opened. In this case the settings are restored from when + * the dialog was last closed. + */ + if (dm) { + if (nIDComboBox == cmb2) + oldWord = dm->u1.s1.dmPaperSize; + else + oldWord = dm->dmDefaultSource; + } } if (nIDComboBox == cmb2) { @@ -873,6 +895,16 @@ break; } + case rad1: /* Paperorientation */ + if (lppd->Flags & PD_PRINTSETUP) + lpdm->u1.s1.dmOrientation = DMORIENT_PORTRAIT; + break; + + case rad2: /* Paperorientation */ + if (lppd->Flags & PD_PRINTSETUP) + lpdm->u1.s1.dmOrientation = DMORIENT_LANDSCAPE; + break; + case cmb1: case cmb4: /* Printer combobox */ if (HIWORD(wParam)==CBN_SELCHANGE) {

1 0

Re: PATCH: "Manual" trays for ppd
by Huw D M Davies Feb. 4, 2001

Feb. 4, 2001

On Sat, Feb 03, 2001 at 07:21:54PM +0100, Marcus Meissner wrote: > Hi, > > The ppd also has Tray1,Tray2,Tray3 ... Now where should those map to? I think these should go to DMBIN_USER, DMBIN_USER+1, etc. So if the lookup of the standard names fails, we just start allocating bin numbers from DMBIN_USER. Huw. -- Dr. Huw D M Davies | Clarendon Laboratory h.davies1(a)physics.ox.ac.uk | Parks Road Tel: +44 1865 272390 | Oxford OX1 3PU Fax: +44 1865 272400 | UK

1 0

Re: debugger fix
by Ulrich Weigand Feb. 4, 2001

Feb. 4, 2001

Eric Pouech wrote: > > Could you send me the libwinspool.drv.so file that objcopy > > is choking on? I'd like to look whether there's something > > strange with that. > here it is... (I've used libpsapi.so instead, because it's smaller, but > effects are the same) Well, one difference I see is that yours has a .rel.stabs section, while mine doesn't. Now I don't quite understand why stabs need to be relocated, but I guess this could be a source of confusion. In any case, after I strip the stabs data using objcopy --strip-debug, I can subsequently use objcopy -N without problems. The problem might be caused by the objcopy -L step not correctly updating the debug info. Could you try adding a --debugging argument to objcopy in both localize_imports and strip_imports? Bye, Ulrich -- Dr. Ulrich Weigand weigand(a)informatik.uni-erlangen.de

1 0

Re: psdrv: map Courier New to Courier
by gerard patel Feb. 3, 2001

Feb. 3, 2001

At 05:40 PM 3/2/01 +0600, you wrote: <snip> >I cannot get this patch to apply. I've tried it with a CVS pull from >earlier today and one from 1/29. With both, I get: > >patching file include/winspool.h >Hunk #1 FAILED at 957. >1 out of 1 hunk FAILED -- saving rejects to file include/winspool.h.rej <snip> This file is supposed to display where the problem is. If it's not obvious, the problem is with tab expansion - it happens with cut & paste from Netscape. Try with patch -l Gerard

2 1

Re: debugger fix
by Eric Pouech Feb. 3, 2001

Feb. 3, 2001

Ulrich Weigand wrote: > > Eric Pouech wrote: > > > thanks for taking a look at it. unfortunately, I couldn't really test > > your patches. when run, roughly 4/5 of the .so files did would generate > > this type of error > > ../../tools/strip_imports libwinspool.drv.so > > objcopy: styEor1D: File truncated > > Strange. Could you try using 'strip' instead of 'objcopy' in > strip_imports? (Only there, in localize_imports it must be objcopy.) tested with binutils 2.9.1 and 2.10.1 and I get the same error... even when changing objcopy by strip did some strace on the operation, and it seems that there's some mixup in the section reading / writing > > From a pure conceptual point of view, the build process definitively > > grows more and more complex (I'm not sure Alexandre would accept another > > tool or an extension to winebuild for it). However, if I got what you intend > > correctly, it means that an import symbol would be defined as: > > - no trace in stabs > > - listed in .dynamic section, as a local symbol. > > No, I mean no trace in stabs *and* no dynamic symbol either. [long explanation deleted] thanks, that what I thought at first, but got abused by the first outputs made out of the patch... > However, my method has admittedly also a serious disadvantage: > it makes heavy use of GNU-specifc tools (and apparently even > there are version problems ...). :-( I'm not sure it's a version issue. looks more I have something broken somewhere... still have to figure out where :-( however, it would be great if someone else could try Ulrich's patch to see if I'm the only one with BAAAAAAAAD results... A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

2 1

Re: debugger fix
by gerard patel Feb. 3, 2001

Feb. 3, 2001

At 06:24 PM 3/2/01 +0000, you wrote: <snip> >however, it would be great if someone else could try Ulrich's patch to see >if I'm the only one with BAAAAAAAAD results... I tested Ulrich's patch on current Cvs on a vanilla Suse 7.0 (gcc 2.95.2, binutils 2.9.5) The patch applied all right, built fine (I had to chmod +x strip_import though). I can run ForteFreeAgent with the patched Wine; the debugger starts all right and I can go to a breakpoint using the <dll name in uppercase>.<api> trick. Gerard

2 1

Re: PATCH: afm loader
by Joerg Mayer Feb. 3, 2001

Feb. 3, 2001

Moin Marcus, you codeed some thing like this in a few places: > + char afmfn[256]; > + strcpy(afmfn,afmdir); directories and filenames may be longer than 256 charaters. If you use such a value you should at least use strncpy or use FILENAME_MAX from stdio.h (if that's the right one). Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

1 0

ReadFile() and WriteFile() choke on non-zero lpOverlapped.
by Eric Kohl Feb. 3, 2001

Feb. 3, 2001

Hello! I'm currently debugging a database-application that uses the M$ Jet Engine 3.5. This db-engine does not behave very well. It opens an exisisting database-file (FILE_FLAG_OVERLAPPED is *not* set) and reads or writes using calls to ReadFile() and WriteFile() with non-zero lpOverlapped pointers. In this case calls to ReadFile() or WriteFile() return FALSE. IMO ReadFile() and WriteFile() should check whether FILE_FLAG_OVERLAPPED is set. Unfortunately there is no method to retrieve the full file attributes from wineserver. Is a new server call required? Best regards, Eric Kohl

2 1

Microsoft Wine????
by Owen Rudge Feb. 3, 2001

Feb. 3, 2001

Hi, This is what happens when you use the native Windows SHELL32.DLL and choose About Wine from the System menu...... <see http://www16.brinkster.com/orudge/mswine.gif for screenshot> Hmmmm..... has Microsoft taken over Wine too...... :-) The app I was running, BTW, is something I've made called Notebook, and seems to run fine. Owen Rudge http://www.osplus.co.uk/ http://www.owenrudge.com/ http://www.owenrudge.co.uk/ http://www.transporttycoon.uk.tt/ http://www.savedgamemanager.uk.tt/

1 0

ReadFile() and WriteFile() choke on non-zero lpOverlapped.
by Eric Kohl Feb. 3, 2001

Feb. 3, 2001

Hello! I'm currently debugging a database-application that uses the M$ Jet Engine 3.5. This db-engine does not behave very well. It opens an exisisting database-file (FILE_FLAG_OVERLAPPED is *not* set) and reads or writes using calls to ReadFile() and WriteFile() with non-zero lpOverlapped pointers. In this case calls to ReadFile() or WriteFile() return FALSE. IMO ReadFile() and WriteFile() should check whether FILE_FLAG_OVERLAPPED is set. Unfortunately there is no method to retrieve the full file attributes from wineserver. Is a new server call required? Best regards, Eric Kohl

1 0