July 2001 - Wine-Devel - list.winehq.org

CoGetClassObject
by Daniel Walker Aug. 7, 2001

Aug. 7, 2001

I was thinking of ways to get the CLSCTX_LOCAL_SERVER option working in wine. The only program that uses it , that I know of, is installshield v6 .. I pretty sure some other people are working on this, but I don't know that status. (Anyone care to update me?) There is another problem. It's with the TypeLib information in the IKernel.exe that comes with InstallShield v6. The TypeLib information is encoded somehow, any ideas? I was able to get around that problem because installshield also looks for type information in "ikernel.tlb" . So I was able to create a .tlb that worked. I also used the reaktivate typelib patch so the typelib info gets put into the registry. So the way I understand it is that when CoGetClassObject is called Wine is suppose to , in this case, execute IKernel.exe . Then IKernel.exe will CoRegisterClassObject on all needed objects .. One problem is that the registered class object list isn't shared between the two processes, so we would need to move that list into the wine server (Right?) .. Then we would also need to send an instance of the class object to the Wine server (Yeah??) .. Following that road seems to lead to some messy address translations for DLL's and whatever else.. Since we have complete control over how IKernel.exe is run, how would we get the two processes to share memory? Maybe have IKernel.exe execute in a thread? IKernel.exe doesn't do anything but register it's class objects .. Would it be possible to treat IKernel.exe as a DLL then run CoRegisterClassObject for it? Daniel Walker

8 13

Re: (no subject)
by Alexandre Julliard Aug. 5, 2001

Aug. 5, 2001

Ladislav Sladecek <lsla(a)post.cz> writes: > If you run the binary in the Windows, you will see two properly sized > red rectangles on a white background. If you run the same binary in > Wine, you will see only one large red child but no white parent > background. If either the CS_PARENTDC or WS_CLIPSIBLINGS gets removed > from my example, both Windows and Wine give identical results. Yes, there were a number of problems with the flags handling in GetDCEx. I think the behavior with the current CVS should now be correct in all cases; please give it a try. -- Alexandre Julliard julliard(a)winehq.com

3 3

Dose wine people hate Solaris?
by EriK W Aug. 3, 2001

Aug. 3, 2001

I have posted my question for compiling Wine in solaris x86 for 2 weeks, seems no anybody even has a bit interest. Do you guys hate solaris? :) I checked almost all the documents and faq, except it mentioned wine works with Solaris, there almost have no other info for it at all. Does anybody has even a suggestion for me? pls don't tell me nuke my solaris. :)

5 8

Re: Prevent excessive clipping in SysListView32
by Uwe Bonnes Aug. 2, 2001

Aug. 2, 2001

>>>>> "Medland," == Medland, Bill <Bill.Medland(a)accpac.com> writes: Medland,> I am not very comfortable with this one but strange as it may Medland,> seem it solves the problem. I'd love to know why. Medland,> <<diff13.txt>> Bill Medland (medbi01(a)accpac.com) Prevents Medland,> excessive clipping in SysListView32. Medland,> Medland,>-static inline int perfect_graphics(void) Medland,>+static int perfect_graphics(void) Medland,> { Medland,> static int perfect = -1; Medland,> if (perfect == -1) Medland,> Some C-Expert is requested here, but I suspect that in the old function the variable "perfect" was created in every instantiation of the "perfect_graphics" inlined function. Could you perhaps try to declare the "perfect" outside the inlined function, like static int perfect = -1; static inline int perfect_graphics(void) Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

6 9

Documenting functions
by Bill Medland Aug. 1, 2001

Aug. 1, 2001

Getting back to what we are and are not allowed to do.. Suppose I am looking at a low-level function that I believe is only 75%-complete (the most important 75% of course and no disrespect meant to those who have got it that far). One of the problems with it is it is not totally clear EXACTLY what the function should do in some of its more esoteric modes. To me the first task is to define what it should do and that should be part of the documentation of the function. The particular function currently does not have any true documentation within the code; the best documentation of what it does is the code itself, and the best documentation of what it should do is the MSDN description of the function. 1. Should the function be completely defined in its header in the source code (which will probably make the header twice as large as the function) or should the details be put somewhere else. 2. Are we walking into copyright danger if the Wine documentation of the function is clearly based on the MSDN documentation, even if we acknowledge that. 3. Are we interested in that level of documentation? Bill

4 3

Re: Patch to fix the Linux 2.2 joysitck interface
by Alexandre Julliard July 31, 2001

July 31, 2001

David Hagood <wowbagger(a)sktc.net> writes: > To be done: the file descriptor is never closed under normal > circumstances - this might be a problem if a Wine app is opened and > accesses the stick, as the file descriptor will be open until that > process terminates. If this is viewed as a problem, it would be a simple > matter to add a device close function to the Wine driver to close the FD. Shouldn't this be done in the driver DRV_OPEN/DRV_CLOSE calls then? Any joystick experts out there? (BTW please use diff -u to generate patches, the default diff format is unreadable). -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: RFC: Patch for making GrabPointer work
by Alexandre Julliard July 31, 2001

July 31, 2001

Jukka Heinonen <jhei(a)iki.fi> writes: > Storing old windows procedure in struct x11drv_win_data > would remove the worst race, but unless window > procedure update is atomic, it would not remove > all races. Since you have the window locked when changing the wnd proc the update will be atomic. The only problem I see is that your wnd proc might get called to process some other message, but you can solve this by having it chain to the previous wnd proc for all messages except the special one. -- Alexandre Julliard julliard(a)winehq.com

2 1

Relocatoion and ExceptionFilter problem?
by EriK W July 30, 2001

July 30, 2001

Now I finally made a wine , :) But I can't get any program to excute so far, mostly It is like bash-2.03# wine --winver win95 sol.exe err:seh:UnhandledExceptionFilter Couldn't start debugger (debugger/winedbg 134639312 24) (2) Read the Wine Developers Guide on how to set up winedbg or another debugger or bash-2.03# wine --winver win98 icq2000b.exe err:win32:do_relocations Standard load address for a Win32 program not available - patched kernel ? err:win32:do_relocations FATAL: Need to relocate F:\export\home\ericw\system\icq2000b.exe, but no relocation records present (stripped during link). Try to run that file directly ! wine: can't exec 'icq2000b.exe': error=21 This wine seems taste not good, :) Francois Gouget wrote: > On Thu, 26 Jul 2001, EriK W wrote: > > > > What does not work? Do you have unicode/libwine_unicode.so or not? > > > Does the following command run or does it say it cannot find > > > libwine_unicode.so? > > > > > I does have the libwine_unicode.so > > but it just don't go to ~unicode directory to search for it, it always > > report " can't find it in /usr/local/lib" I don't know why, I am using bash, > > so I just simply copied libwine_unicode.so over to make it happy. > > I was wondering if it was the shell not exporting the environment > variable or something. Since you're using bash it should be all fine. > So you have to figure out why setting LD_LIBRARY_PATH does not work. > It's supposed to work. I'm 99.9% sure I did use it on Sparc Solaris so I > really don't see why it would not work on Solaris x86. Plus > LD_LIBRARY_PATH is such an important thing that it would be very > surprising if it really did not work and nothing else was broken in your > system. > > Did you try specifying an absolute path like: > LD_LIBRARY_PATH=/export/home/system/wine-20010629/unicode ./tools/winebuild/winebuild > > What does 'echo $LD_LIBRARY_PATH' normally say? Is it empty? > > [...] > > take it out? > > Can I do that by commenting " > > LIBPROGRAMS = \ > > debugger/winedbg" ? > > The following patch should do that nicely: > > --- cut here --- > Index: Makefile.in > =================================================================== > RCS file: /home/wine/wine/debugger/Makefile.in,v > retrieving revision 1.24 > diff -u -r1.24 Makefile.in > --- Makefile.in 2000/12/29 05:38:00 1.24 > +++ Makefile.in 2001/07/27 01:39:15 > @@ -3,7 +3,7 @@ > TOPOBJDIR = .. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > -MODULE = winedbg > +MODULE = #winedbg > > C_SRCS = \ > break.c \ > --- Makefile.orig Thu Jul 26 19:03:36 2001 > +++ Makefile Thu Jul 26 19:00:53 2001 > @@ -3,7 +3,7 @@ > TOPSRCDIR = .. > TOPOBJDIR = .. > SRCDIR = . > -MODULE = winedbg > +MODULE = #winedbg > > C_SRCS = \ > break.c \ > --- cut here --- > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > Broadcast message : fin du monde dans cinq minutes, repentez vous !

2 2

RE: Small OpenGL patch
by Patrik Stridvall July 30, 2001

July 30, 2001

> It also puts the 'make_opengl' script in line with the latest > modification > to the spec file. It also changes the OPENGL32.@ to OPENGL.@ > as per Patrik's > modifications in 'make_opengl'. Arrgghhh! I just saw that I didn't do the same change in the script as in the .c files (I didn't run the script, since it worked badly last time I tried with my OpenGL files). Braino. :-( It should of course be OPENGL32.@ not OPENGL.(a). The .c files was correct as they were. Sorry to cause you problems but can you fix the script and rerun on your OpenGL files and resubmit. > PS: god I hate Perl... I may well rewrite 'make_opengl' in > Python one of > these days :-) Whats wrong with Perl? I write applications sometimes in Perl and sometimes in Python, and I like them both and a dislike somethings about each language as well. Of course Perl is a little more difficult to learn but still. PS. You will se one of the advantages of Perl if you add use strict; at the top of the script. Of course after that you will have to declare all variable to it keeps the number of bugs down.

1 0

RE: winapi update
by Patrik Stridvall July 30, 2001

July 30, 2001

> > In short, please apply it, they facillitates using the > > winapi tools alot and might make more people actually > > use them. They don't hurt anything. > > The problem is if we make it part of the default make install all Wine > distributions will include these non-functional (from the user POV) > scripts, and I don't think this is a good idea. That is true. > So I have applied it > but it doesn't run by default; developers who want it should run make > install in the tools/winapi directory. Ah, of course. Good idea. Thanks. This brings to mind the fact that three different kinds of "users": 1. Ordinary users 2. Wine/Winelib developers 3. Winelib application developers that need different kinds of tools installed. Not that I have any good solution to the problem. And not something that really is a problem either. Is was just something that occured to me. Oh well. Never mind.

1 0

Re: winapi update
by Alexandre Julliard July 30, 2001

July 30, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > A full install is largely meaningless since the winapi tools are made > for work on a Wine source tree, so making them independant of such > a tree is largely meaningless. Agreed. > In short, please apply it, they facillitates using the > winapi tools alot and might make more people actually > use them. They don't hurt anything. The problem is if we make it part of the default make install all Wine distributions will include these non-functional (from the user POV) scripts, and I don't think this is a good idea. So I have applied it but it doesn't run by default; developers who want it should run make install in the tools/winapi directory. -- Alexandre Julliard julliard(a)winehq.com

1 0

broken misc/version.c (patch 1.43 -> 1.44) WIN95 value in version16
by Ladislav Sladecek July 30, 2001

July 30, 2001

Two days ago a 16 bit application, which I use, started to complain about unknown windows version. After I rgressed to 1.43 of misc/version.c, everything was OK. I found the problem in the GetVersionInfo value that you changed at line 75 of the file. My windows 95 returns 0xC0000004 in WIN32 and 0x07005F03 in WIN16. You changed the 16bit value from 0x7005F03 to 0x7000304. Can you please check this? Do you have some docs? I think that we that we are both right; the value probably depends on longitude, altitude, and Windows language version. Mine iWindows 95 is Czech Edition, SR2. Regards Ladislav Sladecek

1 0

RE: winapi update
by Patrik Stridvall July 30, 2001

July 30, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > I have resent winapi_install patch. > > > > While it probably that you didn't apply > > it because of lack of time I resend > > for your convinience. If not please > > explain. > > Correct me if I'm wrong, but it seems you are not actually installing > anything, only a script that needs the Wine source tree to work. That is a correct conclusion. > I don't really see the point. The point is that when you are in some sub directory of a wine tree, you can just write winapi_check or make_filter and whatever and it will call the correct version of the tool. Instead of having to type, if you are in dlls/winsock. ../../tools/winapi_check Sure you can currently do make winapi_check or make filter and adding winapi_{extract,fixup} is trivial but giving arguments through make is a little awkward. That why I wrote a few script to fix this and now when I have a tool (make_filter) that could possibly enjoy a wider use I decided to make a formalized "install" for them. > If you want to install something it should > be a complete installation that works without external files (not that > I suggest doing that for winapi_check, at least not by default). A full install is largely meaningless since the winapi tools are made for work on a Wine source tree, so making them independant of such a tree is largely meaningless. Well they actually are indendent of the specific tree they where install from. They do not reference to it at all. They use the current directory to find the real winapi tools in that tree. They will work equally well with any tree (of a later date than your hopefull application of the patch that is). They are as they are by design, not by mistake, and complete installation of them is almost completly meaningless. Sure there might be future winapi tools worthy of a complete install, a future tool for automatical generation of .spec files from any Winelib application, that we talked about some time ago, comes to mind, but I'm not there quite yet. I have begun to implement simple typedef parsing but it doesn't work 100% yet. In short, please apply it, they facillitates using the winapi tools alot and might make more people actually use them. They don't hurt anything.

1 0

Re: winapi update
by Alexandre Julliard July 30, 2001

July 30, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > I have resent winapi_install patch. > > While it probably that you didn't apply > it because of lack of time I resend > for your convinience. If not please > explain. Correct me if I'm wrong, but it seems you are not actually installing anything, only a script that needs the Wine source tree to work. I don't really see the point. If you want to install something it should be a complete installation that works without external files (not that I suggest doing that for winapi_check, at least not by default). -- Alexandre Julliard julliard(a)winehq.com

1 0

Possible printer driver bug
by Jukka Heinonen July 30, 2001

July 30, 2001

Wine compiled from CVS crashes since file "wine/dlls/gdi/driver.c" passes a NULL pointer to function CreateICA. The following patch stops crashing, but since I have no idea how Wine printer drivers work, this patch might be plain wrong. After this patch, Wine no longer crashes, but I haven't been able to test whether printing works or not. Index: wine/dlls/gdi/driver.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/driver.c,v retrieving revision 1.2 diff -u -r1.2 driver.c --- wine/dlls/gdi/driver.c 2001/07/28 00:18:02 1.2 +++ wine/dlls/gdi/driver.c 2001/07/29 14:10:18 @@ -376,7 +376,7 @@ if(!DRIVER_GetDriverName( lpszDevice, buf, sizeof(buf) )) return -1; - if (!(hdc = CreateICA( buf, NULL, lpszPort, NULL ))) return -1; + if (!(hdc = CreateICA( buf, lpszDevice, lpszPort, NULL ))) return -1; if ((dc = DC_GetDCPtr( hdc ))) { -- Jukka Heinonen <http://www.iki.fi/jhei/>

2 1

Hi There
by Robert Laverick July 30, 2001

July 30, 2001

Hi, I'm new to wine and while I've been messing about with it I've not acctualy done anything significant. I'm mostly into Java but picked up some C recently doing some parallel comutational stuff as part of my Final year project as part of my degree. Now I'm officaly Unemployed as apposed to a Student I can give of my time freely. I'd love to get into this, if someone could give me a point at something that needs a good looking at then I'll start there. My biggest motivation is to get to understand this whole thing better and (if I'm luck) get Diablo II running so I don't have to reboot out of linux each time my Girlfriend comes round and demmands to kick my ass. :-) Well thanks in advance and I hope I can prove usefull. Rob PS anyone who want's to be nice enough to offer me a job DO IT NOW PLEASE I'M SKINT!

1 0

Wine Unreal and a strange old problem
by FT Rathore July 29, 2001

July 29, 2001

Hi I have been using wine to play Unreal for a long time, but it would always crash in the start when I play as root or when I have my /dos filsystem mounted rw. It would always blow my mind, but I would fail to catch it. (been happenning for years too). I copied the whole Unreal tree to my ext2 filesystem and tried with different file permissions. I came to reallize that wine will allways crash if the file Unreal.log in Unreal/System is writeable. If I make that file read only, wine works flawlessly and I can do everything including save/load games. I tried to debug it, but the clues were very strange. There is only one message I see before the crash: err:seh:EXC_DefaultHandling Exception frame is not in stack limits => unable to dispatch exception. Besides that there is not much different between the good and the bad traces. I am attaching last 2000 lines of "-debugmsg +all" with this message. Someone might be able to get some sense from the trace. Anything else I sould do? FT

1 0

Re: wnd lock tracing
by Alexandre Julliard July 29, 2001

July 29, 2001

Andreas Mohr <a.mohr(a)mailto.de> writes: > Add a #define DBG_WNDLOCK in order to have reasonable wndlock debugging Please don't add #ifdefs. You should use a debug channel. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: -DSTRICT warning fixes
by Patrik Stridvall July 29, 2001

July 29, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Sure Win64 should use 64-bit pointers as handles that is > > without questions, but forcing it on Win32 on 64-bit > > is totally unnessary > > This may be the root of your misunderstanding: there is no such thing > as Win32 on 64-bit platforms. Wine (and Winelib) implement Win32 on > 32-bit platforms, and Win64 on a 64-bit platform. Well, actually Win32 does exist (or rather existed, it has been discontinue by Microsoft) on Alpha. But, never mind, it doesn't matter. The point is somebody has souce code for a Windows application and wishes that it will run on Alpha. He or she doesn't care whether Win32 on 64-bit exists or not he wished to port his application with as little effort as possible. He or she doesn't care what magic Winelib does as long as it works and he has to change the source as little as possible. > If you want to > compile your apps as Win32, you need a 32-bit compiler. Sure thats an idea, but doing that is a little awkard, no 32-bit compiler currently exists for 64-bit platforms AFAIK. While this might work, at least in theory, if you only call the Win32 API, how do you suggest calls to 64-bit Unix libraries should be handled? > Then you use > the same compiler to build Wine as a Win32 library, and everything > works fine. If you use a 64-bit compiler, some types (including > handles) become 64-bit, and you have to deal with it. Since you refuse to make it easier for the porter, sure he or she will have to deal with it, that is pretty obvious isn't it? The question is what can we do to make it easier for the porters. We can almost always say "We don't care, its your problem", so that is not an argument by itself. Sure we can't do the impossible, and some things takes to much effort, but still. > The only possible exception would be running existing Win32 binaries > on ia64. And I'm not even convinced it needs an exception, it's > probably easier to simply build a version of Wine with the 32-bit gcc > than to try to come up with a translation layer. Well, that is a future problem. I don't know exactly how to handle it either, but as you pointed out earlier since we need to convert 32-bit pointers to 64-bit pointers we might as well convert 32-bit handlers to 64-bit handlers the same way. Of course that doesn't mean that being able to compile Winelib with handle as 32-bit integers won't help, but I really can't say whether or not right now.

1 0

Re: -DSTRICT warning fixes
by Alexandre Julliard July 29, 2001

July 29, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > Sure Win64 should use 64-bit pointers as handles that is > without questions, but forcing it on Win32 on 64-bit > is totally unnessary This may be the root of your misunderstanding: there is no such thing as Win32 on 64-bit platforms. Wine (and Winelib) implement Win32 on 32-bit platforms, and Win64 on a 64-bit platform. If you want to compile your apps as Win32, you need a 32-bit compiler. Then you use the same compiler to build Wine as a Win32 library, and everything works fine. If you use a 64-bit compiler, some types (including handles) become 64-bit, and you have to deal with it. The only possible exception would be running existing Win32 binaries on ia64. And I'm not even convinced it needs an exception, it's probably easier to simply build a version of Wine with the 32-bit gcc than to try to come up with a translation layer. -- Alexandre Julliard julliard(a)winehq.com

1 0

toolbar fix
by nog July 29, 2001

July 29, 2001

Hi all, Changelog: Nog <nog(a)sdf.lonestar.org> Don't enable the 'hot' state of a toolbar button when it's not enabled. --- dlls/comctl32/toolbar.c Sun Jul 29 09:08:56 2001 +++ dlls/comctl32/toolbar.c Sun Jul 29 11:41:50 2001 @@ -4123,13 +4123,13 @@ if (nHit >= 0) { btnPtr = &infoPtr->buttons[nHit]; - btnPtr->bHot = TRUE; infoPtr->nHotItem = nHit; /* only enabled buttons show hot effect */ if(infoPtr->buttons[nHit].fsState & TBSTATE_ENABLED) { + btnPtr->bHot = TRUE; InvalidateRect(hwnd, &btnPtr->rect, TOOLBAR_HasText(infoPtr, btnPtr)); }

1 0

RFC: Patch for making GrabPointer work
by Jukka Heinonen July 29, 2001

July 29, 2001

After the following patch DXGrab works again. However, this patch has quite a few potential races, so I am not going to submit this to wine-patches. Storing old windows procedure in struct x11drv_win_data would remove the worst race, but unless window procedure update is atomic, it would not remove all races. I'm starting to think that QueueUserAPC used together with OpenThread (which does exist in Windows 2000/Me, but not yet in Wine) is the correct way to fix DXGrab. Index: wine/dlls/x11drv/x11ddraw.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/x11ddraw.c,v retrieving revision 1.9 diff -u -r1.9 x11ddraw.c --- wine/dlls/x11drv/x11ddraw.c 2001/06/04 21:55:17 1.9 +++ wine/dlls/x11drv/x11ddraw.c 2001/07/29 13:41:52 @@ -45,20 +45,64 @@ } } -static void GrabPointer(HWND hWnd) -{ +static LRESULT WINAPI GrabWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) +{ Display *display = thread_display(); - if (hWnd) { - /* find the X11 window that ddraw uses */ - Window win = X11DRV_get_whole_window(hWnd); - TRACE("WND: %x win: %ld\n", hWnd, win); - if (!win) { - TRACE("host off desktop\n"); - win = root_window; - } - TSXGrabPointer(display, win, True, 0, GrabModeAsync, GrabModeAsync, win, None, CurrentTime); + + if(message != 0x7777) { + ERR("Unrecognized message %d, expect trouble!\n", message); + return 0; } - else TSXUngrabPointer(display, CurrentTime); + + TRACE("hwnd=%d, grab=%d\n", hWnd, wParam); + + if (wParam) + { + /* find the X11 window that ddraw uses */ + Window win = X11DRV_get_whole_window(hWnd); + TRACE("X11 window: %ld\n", win); + if (!win) { + TRACE("host off desktop\n"); + win = root_window; + } + + TSXGrabPointer(display, win, True, 0, GrabModeAsync, GrabModeAsync, win, None, CurrentTime); + TSXSetInputFocus(display, win, RevertToParent, CurrentTime); + } + else + { + TSXUngrabPointer(display, CurrentTime); + } + + return 0; +} + +static void GrabPointer(HWND hWnd, BOOL grab) +{ + WND* pWnd; + WNDPROC pOldProcedure; + + pWnd = WIN_FindWndPtr(hWnd); + if(!pWnd) + return; + + pOldProcedure = pWnd->winproc; + pWnd->winproc = GrabWndProc; + + WIN_ReleaseWndPtr(pWnd); + + SendMessageA(hWnd, 0x7777, grab ? 1 : 0, 0); + + pWnd = WIN_FindWndPtr(hWnd); + if(!pWnd) + return; + + if(pWnd->winproc != GrabWndProc) + ERR("Window procedure has been changed!\n"); + else + pWnd->winproc = pOldProcedure; + + WIN_ReleaseWndPtr(pWnd); } static DWORD PASCAL X11DRV_DDHAL_DestroyDriver(LPDDHAL_DESTROYDRIVERDATA data) @@ -75,7 +119,7 @@ X11DRV_DD_PrimaryGbl = X11DRV_DD_Primary->lpGbl; SetPrimaryDIB(GET_LPDDRAWSURFACE_GBL_MORE(X11DRV_DD_PrimaryGbl)->hKernelSurface); X11DRV_DD_UserClass = GlobalFindAtomA("WINE_DDRAW"); - if (dxgrab) GrabPointer(X11DRV_DD_PrimaryWnd); + if (dxgrab) GrabPointer(X11DRV_DD_PrimaryWnd, TRUE); } data->ddRVal = DD_OK; return DDHAL_DRIVER_NOTHANDLED; @@ -108,12 +152,12 @@ static DWORD PASCAL X11DRV_DDHAL_DestroySurface(LPDDHAL_DESTROYSURFACEDATA data) { if (data->lpDDSurface == X11DRV_DD_Primary) { + if (dxgrab) GrabPointer(X11DRV_DD_PrimaryWnd, FALSE); X11DRV_DD_Primary = NULL; X11DRV_DD_PrimaryWnd = 0; X11DRV_DD_PrimaryGbl = NULL; SetPrimaryDIB(0); X11DRV_DD_UserClass = 0; - if (dxgrab) GrabPointer(0); } data->ddRVal = DD_OK; return DDHAL_DRIVER_HANDLED; -- Jukka Heinonen <http://www.iki.fi/jhei/>

1 0

RE: -DSTRICT warning fixes
by Patrik Stridvall July 29, 2001

July 29, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Does the Windows API really define exactly what a handle is? > > typedef void* HANDLE seems pretty clear to me. I was refering some documentation that said that application should always expect a handle to be a pointer. But never mind. Documentation and reality is often different things. > > However your suggestion that any Winelib application that > cares whether > > they are 32-bit or 64-bit are broken is a far too strict > IMHO and I see > > no reason to require porters to fix such things. > > An application that assumes that everything is 32-bit is broken, yes. > I don't see why handles are any different than other types; if > anything they should be less of a problem since they are supposed to > be opaque, so their size should not matter for the application. > > Of course most handles will fit in 32-bit, so we will still support > apps that do invalid casts and truncate the handles; but this doesn't > mean it is correct behavior, or that apps that do this should be able > to compile without warnings. OK, since you agree we should accept handles truncated to 32-bit, it still leaves the problem. Should API calls truncate the handles themselves ie take 32-bit integers as arguments or should they not ie take 64-bit pointers as arguments. There is no particular reason to not accept both and make the actual definition of handle be dependent on some define and leave the choice on whether they want warnings or not to the Winelib developers, not leave them without a choice. Actually we might also consider giving them the option to accept 64-bit integers. In short, the Winelib developers should decide what their application wants (warning wise), we shouldn't. > > So therefor I suggest that we should do the following > > TRACE("(%p)", (LPVOID) handle); > > You must be joking. No, I'm not. However reality forced me to change the solution somewhat. See below. > I said I didn't want any typecast, and here you > suggest to have one on every single debugging output. Well, we have (or should have) a debugstr_[aw]n? on every single string in the debugging output, because we have to. We might not like it, but we have it because we must. > Let me repeat it > once more just in case: *NO* *TYPECASTS*. I know that you said that and I have said that I support that whenever possible, which it fortunately is in the normal cases. > The whole point of STRICT and pointer handles is to be able to use > compiler type checks, and this is only possible without typecasts. Agreed, but there is no self value in having no exceptions on a rule. Remember no type cast is a means no a goal. Debugging output is hardly a critical piece of code so if we can gain something from it we should consider making an exception. But never mind, it turns out that we we needn't make a exception either. See below. > Not > to mention that your solution will probably still get a warning like > "converting integer to pointer of different size" on a 64-bit > platform. Ah, thats a good point. Practice often stand in the way of a good theory. :-( Unfurtunately I think you are right, it is more than probable that the compiler will generate such a warning, I if not now so sometime in the future. Casting to a 32-bit integer to 64-bit pointer is almost always bogus, so there is no reason for the compiler not give a warning epecially since you can do a double cast (32-bit integer to 64-bit integer to 64-bit pointer) if you really mean it. Fortunately the problem is solvable #ifdef __alpha__ #ifdef STRICT #define HANDLE2POINTER(handle) (handle) #else #define HANDLE2POINTER(handle) ((void *) (unsigned long) (handle)) #endif #ifdef STRICT #define HANDLE2POINTER(handle) (handle) #else #define HANDLE2POINTER(handle) ((void *) (handle)) #endif #endif TRACE("(%p)", HANDLE2POINTER(handle)); This solves your problem (at least for 32-bit developers) < The whole point of STRICT and pointer handles is to be able to use < compiler type checks, and this is only possible without typecasts. Francois problem < * Ignore gcc's warnings saying '%x format, pointer argument'. Fixing the format < at this stage would only introduce tons of warnings for the developpers not < participating in the switch (i.e. compiling with STRICT off). as well as my problem. Of course we might consider making it a debug output only construct instead Like s/HANDLE2POINTER/debugptr_handle/ and define it in debugtools.h. Non-debugging parts of Wine shouldn't need to use it either since as I said earlier just pass them long or must use an explict cast to a non-void pointer. Ah, wait a minute we will have "converting integer to pointer of different size" on 64-bit platforms for the actual cast to an object. Of course easily solved with a similar #ifdef __alpha__ #define HANDLE2OBJECT(type, handle) ((type *) (unsigned long) (handle)) #else #define HANDLE2OBJECT(type, handle) ((type *) (handle)) #endif but perhaps we should have the HANDLE2POINTER (debugptr_handle) in debugtools.h all the same, nobody else is intrested in a void pointer anyway. Of course, nothing forces us to define handles as the same both internally and externally. At least Alpha AFAIK will be binary compatible all the same, so we might not even need this. Oh well having to always using HANDLE2OBJECT is a small price to pay all the same and makes it possible for us to do adjustments on other 64-bit platforms if need be. And yes, I'm serious. My inital solutions wasn't so good, but thanks to your feedback I have managed to refine it to a much better solution, that I think actually works in reality. And yes, I still consider the 64-bit problem a real problem, you just tries to dismiss the problem by simply saying, that is the Winelib developers problem. Sure we could do that but, remember that Winelib is meant to help developers port application not make it more difficult by trying to enforce unnessary restriction on the code. Sure Win64 should use 64-bit pointers as handles that is without questions, but forcing it on Win32 on 64-bit is totally unnessary, especially since I now finally after your feedback managed to find a solution that solve all your stated problems (remember that no type casts is a means not a goal and actually there will be no type casts on 32-bit (-DSTRICT) either). But perhaps you can see any flaws in this refined solution as well?

1 0

Re: -DSTRICT warning fixes
by Alexandre Julliard July 29, 2001

July 29, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > Does the Windows API really define exactly what a handle is? typedef void* HANDLE seems pretty clear to me. > However your suggestion that any Winelib application that cares whether > they are 32-bit or 64-bit are broken is a far too strict IMHO and I see > no reason to require porters to fix such things. An application that assumes that everything is 32-bit is broken, yes. I don't see why handles are any different than other types; if anything they should be less of a problem since they are supposed to be opaque, so their size should not matter for the application. Of course most handles will fit in 32-bit, so we will still support apps that do invalid casts and truncate the handles; but this doesn't mean it is correct behavior, or that apps that do this should be able to compile without warnings. > So therefor I suggest that we should do the following > TRACE("(%p)", (LPVOID) handle); You must be joking. I said I didn't want any typecast, and here you suggest to have one on every single debugging output. Let me repeat it once more just in case: *NO* *TYPECASTS*. The whole point of STRICT and pointer handles is to be able to use compiler type checks, and this is only possible without typecasts. Not to mention that your solution will probably still get a warning like "converting integer to pointer of different size" on a 64-bit platform. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: -DSTRICT warning fixes
by Patrik Stridvall July 28, 2001

July 28, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > However for the debugging output I disagree. I orginally thought > > as Francois (and you it seems) that handles are pointers and should > > be treated as such. But then I realized that when we > implement Win32 on > > 64-bit platforms we can't have handles as pointers even > internally if > > we wan't to support x86 emulation and even exposing a 64-bit > > handle to Winelib application can only cause trouble since they > > might store it is a 32-bit memory location. Sure we will probably be > > able to handle 64-bit pointers truncated to 32-bit by storing all > > objects in the lower 32-bit part of memory, but fear it might > > cause trouble all the same. > > Handles are pointers in the Windows API, and they should be pointers > inside of Wine. On a 64-bit platforms pointers will be 64-bit, and so > will handles. Does the Windows API really define exactly what a handle is? It is just a identifier for an object that can be passed to various APIs but should not be used directly. > If you want to run 32-bit code on such a platform you > need a conversion for pointers anyway, > so you might as well use the > same conversion for handles. > Not to mention that some handles are > actually pointers (like HMODULE). That is an internal Wine/Winelib problem and shouldn't need to concern porters of Winelib applications. > So no, there is absolutely no reason > to force handles to be 32 bits. Handles are some sort of values as for as whether they are integers or pointers any Winelib application that cares are IMHO broken. I guess you agree on that point. However your suggestion that any Winelib application that cares whether they are 32-bit or 64-bit are broken is a far too strict IMHO and I see no reason to require porters to fix such things. Note that it might no be so easy to fix it either. Perhaps the application uses some external lib that provides storage of some user defined 32-bit data and use it to store the handles. Now it will suddenly not work anymore, and fixing it is not trival. Hint you are on a 64-bit platform that requires 64-bit pointers and you have 32-bit storage. The obvious solution an index of an array might not always work so well because of memory management requirements and beside the maintainer of the project might not accept a special patch for the 64-bit version. Anyway, never mind. See below instead. Sure pointer face in some meaning the same problems, but that sort of problems is more obvious and there is no reason to add more to the burden. > > The real reason that we should support compiling Wine with -DSTRICT > > is not because handles becomes pointers but because callbacks gets > > the correct prototype. > > No, it's because handles become pointers; you cannot do the -DSTRICT > typechecking with integers anyway. True, you can't do typechecking with integers but since Wine is primarily compiled 32-bit platform that will use 32-bit pointers, we will get the benefit of typechecking at the platform, which happends the only one Wine currently works on. Sure future developers on 64-bit will not find the errors then they compile, but everybody else compiling for a 32-bit platform will, so I don't see the problem. > Callbacks are a very minor issue; > the real point is to fix all incorrect handle manipulations, like > implicit 16-bit handle conversions or arithmetic on handle values. The ones of the above that can be found automatically will be fixed by the 32-bit developers. So the actual problem is what? Anyway, this discusion is getting a little carried away (mostly my fault). While I do not currenly agree that we really should use 64-bit handles on 64-bit platforms, your objections have made me think some more and made me come to the following conclusions. In order to not "close the door to the future" whether this is Win32 on 64-bit or Win64, the Wine code shouldn't internally not care (give errors or warnings or be semantically wrong) whether the header files: 1. Defines handles as integers or pointers 2. Defines handles as 32-bit or 64-bit (regardless of whether we have 32-bit or 64-bit pointers) This is not so a for the normal (non-debugging) code. OK, we might have to force memory allocation of objects for the lower 32-bit of memory if we have 64-bit pointers but that is probably not so large problem. After all the Winelib application itself can allocate memory on the full 64-bit memory range and Winelib itself are not likely to need more that 4Gb memory for objects. However, I see no really good solution for the debug output. Neither mine nor your previously suggested solution have the above properties. However the solution below have, I think TRACE("(%p)", (LPVOID) handle); eventhough it might display unnessary information on 64-bit platforms, but perhaps we should worry about that in the future, if it indeed is a problem at all. After all it is only a few more bytes in the debug output. So therefor I suggest that we should do the following TRACE("(%p)", (LPVOID) handle); It will fix the problem that Francois speaks of in bug report #90. < * Ignore gcc's warnings saying '%x format, pointer argument'. Fixing the format < at this stage would only introduce tons of warnings for the developpers not < participating in the switch (i.e. compiling with STRICT off). It will allow us to fix the debug output one by one (or at least seperately per type) since it will allow us compile without related warnings even without -DSTRICT as well as to prepare us for a possible future where handles might be 32-bit integers on 64-bit.

1 0

RE: -DSTRICT warning fixes
by Patrik Stridvall July 28, 2001

July 28, 2001

> On Sat, 28 Jul 2001, Patrik Stridvall wrote: > [...] > > The real reason that we should support compiling Wine with -DSTRICT > > is not because handles becomes pointers but because callbacks gets > > the correct prototype. > > > > I case not you haven't realized the obvious, it doesn't matter if > > the handles are 32-bit integer or 32-bit pointers as long as > > all handles are the same. The code either > > No, I think you have missed something: when compiling with -DSTRICT > on all handles are not the same. Note I said same but meant compatible. Wrong choice of words. > For instance you cannot do > hDesk=hAccel. That's because with -DSTRICT on you have: > > typedef struct HDESK__ { int unused; } *HDESK; > typedef struct HACCEL__ { int unused; } *HACCEL; > > Thus HDESK and HACCEL are incompatible pointer types. This > brings us > more type safety which is the whole point of -DSTRICT. Oh sure, but the point is that if code, that are semanticly correct, cares whether you are strict or relax the type, the code it wrong. Perhaps I was I little unclear on that point. Being strict obviously makes it easier to find semantic errors, but that was not the point at all. > About 64bits Windows I don't know yet how we are going to do that. > But you have to check exactly what Windows 64bit does, not just > extrapolate from the way Unix 64bit does things. AFAIK the > approach used > by windows is quite different from that which Unices took. Yes, unfortunately, but I'm primarily worried about Win32 on 64-bit platforms.

1 0

RE: -DSTRICT warning fixes
by Patrik Stridvall July 28, 2001

July 28, 2001

> > If we do that can just do > > s/DECLARE_OLD_HANDLE/DECLARE_HANDLE/ > > on the handle types on by one and fix the warnings. > > That's precisely the plan, and it is just the opposite of what you are > doing with your patch (you are turning DECLARE_HANDLE back into > DECLARE_OLD_HANDLE). The reason I did that was that they can't be fixed as long as HANDLE/HGLOBAL is the wrong types. When they become the right types the warnings will automatically disappear and we can do s/DECLARE_OLD_HANDLE/DECLARE_HANDLE/. But there is no reason to have a lot of warnings that can't be fixed otherwise until then. > Yes you get a number of warnings if you turn > -DSTRICT on, most of them should disappear once the conversion is > complete; fixing them before that is a waste of time. Since we can't fix before that why show them at all? People that want to fix for example output messages can do, s/DECLARE_OLD_HANDLE/DECLARE_HANDLE/ in their tree, fix them and submit the patches (without the s/DECLARE_OLD_HANDLE/DECLARE_HANDLE/). > This is the > reason why -DSTRICT is not the default yet. Read bug report #90, > Francois explains everything there. OK. I have read bug report #90 now. > And don't forget the number one rule of the -DSTRICT conversion is: > *no* *typecasts*. If you have to add typecasts something is wrong. No typecasts where the handle is used in conjuction with other handles, certainly not, no argument there. The code some expect all handles to be the of same type. However for the debugging output I disagree. I orginally thought as Francois (and you it seems) that handles are pointers and should be treated as such. But then I realized that when we implement Win32 on 64-bit platforms we can't have handles as pointers even internally if we wan't to support x86 emulation and even exposing a 64-bit handle to Winelib application can only cause trouble since they might store it is a 32-bit memory location. Sure we will probably be able to handle 64-bit pointers truncated to 32-bit by storing all objects in the lower 32-bit part of memory, but fear it might cause trouble all the same. Beside doing TRACE("(%p)", handle) on 64-bit platforms will needlessly display the always the same presumably zero upper 32-bit part of the handle. That why I decided to should use TRACE("(0x%08lx)", (DWORD) handle) instead to avoid such issues. In short, the code should IMHO support both 32-bit pointers as well and 32-bit integers as handles presuming of course that all handles use the same. The real reason that we should support compiling Wine with -DSTRICT is not because handles becomes pointers but because callbacks gets the correct prototype. I case not you haven't realized the obvious, it doesn't matter if the handles are 32-bit integer or 32-bit pointers as long as all handles are the same. The code either 1. Just pass them around as the same type of handles of other types of handles (HANDLE/HGLOBAL). 2. Tries to access the underlying object, in such case a void pointer will not do use any good, we must use a cast either after calls to functions like GlobalLock or alone.

2 1

Re: -DSTRICT warning fixes
by Alexandre Julliard July 28, 2001

July 28, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > However for the debugging output I disagree. I orginally thought > as Francois (and you it seems) that handles are pointers and should > be treated as such. But then I realized that when we implement Win32 on > 64-bit platforms we can't have handles as pointers even internally if > we wan't to support x86 emulation and even exposing a 64-bit > handle to Winelib application can only cause trouble since they > might store it is a 32-bit memory location. Sure we will probably be > able to handle 64-bit pointers truncated to 32-bit by storing all > objects in the lower 32-bit part of memory, but fear it might > cause trouble all the same. Handles are pointers in the Windows API, and they should be pointers inside of Wine. On a 64-bit platforms pointers will be 64-bit, and so will handles. If you want to run 32-bit code on such a platform you need a conversion for pointers anyway, so you might as well use the same conversion for handles. Not to mention that some handles are actually pointers (like HMODULE). So no, there is absolutely no reason to force handles to be 32 bits. > Beside doing TRACE("(%p)", handle) on 64-bit platforms will needlessly > display the always the same presumably zero upper 32-bit part > of the handle. That why I decided to should use > TRACE("(0x%08lx)", (DWORD) handle) instead to avoid such issues. Sorry but this is wrong. Handles are pointers and must be printed as pointers. Assuming that handles are always exactly 32-bit is very shortsighted. > The real reason that we should support compiling Wine with -DSTRICT > is not because handles becomes pointers but because callbacks gets > the correct prototype. No, it's because handles become pointers; you cannot do the -DSTRICT typechecking with integers anyway. Callbacks are a very minor issue; the real point is to fix all incorrect handle manipulations, like implicit 16-bit handle conversions or arithmetic on handle values. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: -DSTRICT warning fixes
by Alexandre Julliard July 28, 2001

July 28, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > Concerning some parts of my warnings patch that was > partly rejected I disagree with the rejection. > The patch in question is in warnings_rejected.diff. > Note the field "u" is a union. But perhaps you know > and rejected it for other reasons? I know it is a union; I thought it was one of these cases that would get fixed by -DSTRICT, but now I see that it is a slightly different problem. I'll apply it. > If you accept all the strict_*.diff patches, perhaps we > should consider adding -DSTRICT as a permanent flag? > It removes the HOOKPROC/TIMERPROC warnings that is not > possible to fix otherwise. > > If we do that can just do > s/DECLARE_OLD_HANDLE/DECLARE_HANDLE/ > on the handle types on by one and fix the warnings. That's precisely the plan, and it is just the opposite of what you are doing with your patch (you are turning DECLARE_HANDLE back into DECLARE_OLD_HANDLE). Yes you get a number of warnings if you turn -DSTRICT on, most of them should disappear once the conversion is complete; fixing them before that is a waste of time. This is the reason why -DSTRICT is not the default yet. Read bug report #90, Francois explains everything there. And don't forget the number one rule of the -DSTRICT conversion is: *no* *typecasts*. If you have to add typecasts something is wrong. -- Alexandre Julliard julliard(a)winehq.com

1 0

(no subject)
by Ladislav Sladecek July 28, 2001

July 28, 2001

Alexandre Julliard: > I think GetClipBox is correct, the problem is > that the WM_ERASEBKGND > handler should not be using it, but > GetClientRect. You can try this: Hello Alexandre, thank you for your reccomendation. Unfortunately the DefWindowProc improvement does not help, because the default handler newer gets called in my app. The application (Progress _prowin.exe version 7) uses custom dialog boxes (forms) and also custom controls. The controls handle WM_ERASEBKGND themeselves. I have no access to the sources. What I know about GetClipRect, I know from the trace. I agree that your method (GetClientRect in the handler) is much better, but I cannot use it. I also agree that Windows should return the parent area in GetClipBox as Wine does. Unfortunalelly, the Windows do not do that while the _prowin.exe depends on it. I enclose a simple C example which I hacked to demonstrate this. The example displays two red children in a white parent. The value returned by GetClipBox is wsprintf-ed. If you run the binary in the Windows, you will see two properly sized red rectangles on a white background. If you run the same binary in Wine, you will see only one large red child but no white parent background. If either the CS_PARENTDC or WS_CLIPSIBLINGS gets removed from my example, both Windows and Wine give identical results. Regards Ladislav Sladecek

1 0

Re: -DSTRICT warning fixes
by Francois Gouget July 28, 2001

July 28, 2001

- FIXME("(%x),stub!\n",hrasconn); + FIXME("(0x%08lx): stub\n", (DWORD) hrasconn); [...] I think I would rather use %p to print handles. After all they are pointers, not integers. The annoying aspect of it is that %08p is not very well supported IIRC. Maybe gcc has been fixed though. I forgot to mention it before. But I assume you saw bug #90. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Advice is what we ask for when we already know the answer but wish we didn't -- Eric Jong

1 0

wine on clusters ??
by Francisco Perez July 28, 2001

July 28, 2001

Hi everybody: Has anybody tried to run wine on a High Availabity cluster ?. Especifically we are interested on a Mosix environment where applications don't need be changed. The windows application to be clustered is a Remote IP network back-up system so no grafic intensive or plug modern like ActiveX and so. Any comments are highly apreciated thanks

1 0

Re: PATCH: wrong clipRect when CS_PARENTDC and WS_CLIPSIBLINGS styles are combined
by Alexandre Julliard July 28, 2001

July 28, 2001

lsla(a)post.cz writes: > Where the Wine's GetClipRect returns the area of the parent, the > Windows version returns only the area of the child. Therefore in > Wine the WM_ERASEBKGND message erases the whole parent including the > other radio buttons. I think GetClipBox is correct, the problem is that the WM_ERASEBKGND handler should not be using it, but GetClientRect. You can try this: Index: windows/defwnd.c =================================================================== RCS file: /opt/cvs-commit/wine/windows/defwnd.c,v retrieving revision 1.57 diff -u -r1.57 defwnd.c --- windows/defwnd.c 2001/06/20 23:16:34 1.57 +++ windows/defwnd.c 2001/07/27 23:47:26 @@ -457,20 +457,15 @@ case WM_ICONERASEBKGND: { RECT rect; + HDC hdc = (HDC)wParam; HBRUSH hbr = GetClassLongW( wndPtr->hwndSelf, GCL_HBRBACKGROUND ); if (!hbr) return 0; - /* Since WM_ERASEBKGND may receive either a window dc or a */ - /* client dc, the area to be erased has to be retrieved from */ - /* the device context. */ - GetClipBox( (HDC)wParam, &rect ); - - /* Always call the Win32 variant of FillRect even on Win16, - * since despite the fact that Win16, as well as Win32, - * supports special background brushes for a window class, - * the Win16 variant of FillRect does not. - */ - FillRect( (HDC) wParam, &rect, hbr ); + /* GetClientRect used to be GetClipBox, but it is not what + * Windows does, and it breaks badly with CS_PARENTDC */ + GetClientRect( wndPtr->hwndSelf, &rect ); + DPtoLP( hdc, (LPPOINT)&rect, 2 ); + FillRect( hdc, &rect, hbr ); return 1; } -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: winapi update
by Patrik Stridvall July 27, 2001

July 27, 2001

> make_filter: : can't parse output: 'Make.rules.in is newer > than Make.rules, please rerun ./configure!' Fixed in my tree. > Would it be possible to have the messages pass through as-is when > they are not recognized (with the current directory for context)? [snip] > make_filter: gcc: can't parse output: 'd3ddevice/mesa.c:817: > warning: unused variable `xvis'' I have fixed that for gcc messages (unless --pedantic is specified), however I'm not sure it is good always doing that. I will think about it. > It looks like there's an incompatibility with colorgcc. [snip] > So it must be the controls characters added by colorgcc > that confuse > make_filter. No it wasn't, colorgcc checks whether STDOUT is a TTY or not.

1 0

RE: Even more misc fixes
by Patrik Stridvall July 27, 2001

July 27, 2001

> > But OK I will try and compile with -DSTRICT and see what happends. > > IIRC somebody tried that but it didn't turn out so well. > > That would be me, probably. I started the conversion to -DSTRICT but > then other priorities came up and now it's on the back burner. I will > get back to it eventually but at the current rate it's hard > to know when > that will be :-( > Compiling with -DSTRICT is not that bad: with a relatively simple > patch it compiles (see attachement). Or at least, it used to. No patch is needed for the file in question. windows/property.c needs a simple patch though. > But there > are tons of warnings, which means tons of places that need > attention and > possibly fixing. That's where the work is. Yes. I've noticed that and I have fixed a few of them as well. However I'm not optimistic on fixing them all on the short term. The problem is not the number of them, the problem is that some of the warnings like the Global* can't be fixing in the .c files. It involves changing the .h files and that generated even more warnings. :-( I will investigate furher, but as I said, I'm not optimistic.

1 0

Re:Re: native dll's
by José Soriano Díaz July 27, 2001

July 27, 2001

>From: Francois Gouget <fgouget(a)free.fr> >To: José Soriano Díaz <jose__sor(a)hotmail.com> >CC: wine-devel(a)winehq.com >Subject: Re: native dll's >Date: Thu, 26 Jul 2001 10:10:17 -0700 (PDT) > >On Wed, 25 Jul 2001, José Soriano Díaz wrote: > > > > > Hi there, I'm working in a telerobotics project and I need to >link a > > windows dll in order to use a Cybernet Joystick. > > First I tried to use the winAPI functions LoadLibrary, > > FreeLibrary and GetProccessAddress as I were working on Windows, and > > I recompiled my program with winelib: > > *. winemaker /my_path/ > > *. ./configure > > *. make all > > but it didn't create any executable, what I obtained was a > > lib*.so, because winemaker thought I was trying to compile a dll, > > not to use one. > > To force winemaker to generate an executable simply use it as >follows: > * type "winemaker --cuiexe /my_path" to indicate a console executable > * type "winemaker --guiexe /my_path" to indicate a graphical executable > > You can also use "winemaker -?" to get a list of options supported by >winemaker. > > > > So my question is quite siple How can I link a native dll in > > a Unix project? > > I think you have used the right approach: LoadLibrary / >GetProccessAddress / FreeLibrary. If that works for you then it's the >simplest approach. I'm afraid it doesn't work, when I executed what I compiled , I obtained "Undefined Symbol" in any call to the native dll. Thanks anyway for the advice. _________________________________________________________________ Descargue GRATUITAMENTE MSN Explorer en http://explorer.msn.es/intl.asp

2 1

[Fwd: Re: Any use for glyph bounding boxes in printer driver?]
by Ian Pilcher July 27, 2001

July 27, 2001

Travis Michielsen wrote: > > What about GetCharABCWidth* what does this function use? (or could it use > this?) I see the function still shows a fixme (or atleast the last time I > checked). > The only one that works for printer fonts is GetCharABCWidthsFloat. I just tested it on Windows 2000 and verified that it always returns 0 for abcfA and abcfC (and returns the advance width in abcfB) when it is called on a printer font. -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

Re: ChangeDisplaySettings
by Travis Michielsen July 27, 2001

July 27, 2001

--- Lionel Ulmer <lionel.ulmer(a)free.fr> wrote: > > This patch partially implements the ChangeDisplaySettings* functions. > > Well, I am 100 % sure that Alexandre will reject it :-) :-\ > If you want to do something like that, you need to implement the feature in > the X11 driver and then call it via the 'USER_Driver.pFunctionName' > protocol. Hmm, I was going to try something like that, however, I had problems with that method simply b/c of the load order between the dlls. ChangeDisplaySettings is implemented in user32.dll which loads BEFORE x11drv. This makes it impossible to initalize the function with the user32.dll. However, with DDraw, the x11drv.dll is loaded before the ddraw.dll! The only way I saw to exchange info was to initialize the function with a call from x11drv.dll. If you can suggest an alternative that takes load order into account I will likely use it. > Moreover, there are already some DDraw-related mode change functions (in > dlls/x11drv/xvidmode.c). This should be factorized between both code. Already using so of that code, although it could probably be cleaned up a bit. I will get to that soon. - Travis Michielsen __________________________________________________ Do You Yahoo!? Make international calls for as low as $.04/minute with Yahoo! Messenger http://phonecard.yahoo.com/

2 2

Re: How do I stop clipping?
by Travis Michielsen July 27, 2001

July 27, 2001

--- Bill Medland <medbi01(a)accpac.com> wrote: > I don't like submitting incomplete code but I may have little choice unless > someone can point me in the correct direction here. As you may guess from > the following, my Windows experience is not that extensive but I think it's > enough to allow me to make sensible contributions. > > I am working on correcting the LISTVIEW_DrawLargeItem function, especially > when the item text is large. I have already got most of the way. However > the problem is this. > > When a user selects a large icon the text should be written completely (by > calling DrawText with DT_NOCLIP). It is doing so; I can prove it by > resizing the window and I will see the full text being displayed for a > selected item. However when drawing it at the moment of selecting it, the > text is being clipped to the usual two and a bit rows. Presumably this > means that there is a clipping rectangle in the DC or the window that I > need to inflate. Or Do I simply invalidate that rectangle (from within the > WM_PAINT handler!!!). > > Any help would be appreciated. > > Bill Looking at the DrawText code I see that DrawText just passes the NOCLIP flag to ExtTextOut, so the problem I likely not with DrawText but with ExtTextOut instead. I can take a look at the code for both functions (time providing) and find out what is happening. - Travis Michielsen __________________________________________________ Do You Yahoo!? Make international calls for as low as $.04/minute with Yahoo! Messenger http://phonecard.yahoo.com/

1 0

Any use for glyph bounding boxes in printer driver?
by Ian Pilcher July 27, 2001

July 27, 2001

Currently, the Wine PostScript driver stores the bounding box (xMin, yMin, xMax, yMax) for every glyph in every font. This information is not currently used, and I'd like to get rid of it. (Note: this is distinct from the advance width of each glyph, which is certainly required.) >From what I can tell, there is no API that a Win32 application or the Windows GDI can use to get this information from a printer driver. Since I'm not that familiar with either, however, I figure I should try to confirm that this is indeed the case. So, does anyone know of any API that an application or the GDI can use to get the dimensions of an individual glyph from a "real" Windows printer driver? (I have verified that calling the GetTextExtentPoint functions with a one-character string returns the height of the font, not the height of the glyph. For example, it returns the same height for 'A' and '_'.) Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

2 1

RE: winapi update
by Patrik Stridvall July 27, 2001

July 27, 2001

> Btw, what does make filter do? > > Your post to wine-patches says it's nice an all but it does not say > what it does. Try and run it it is self describing. :-) Since Alexandre didn't apply the Makefile patch, running it is a little awkwark. Will fix that it later versions though. Try do: cd wine ./tools/winapi/make_filter make You can also give it parameters like ./tools/winapi/make_filter make clean Warning "make clean" doesn't look that good currently. PS. It filters the make messages and only display important messages. It might not always work 100% though, but I will fix problems as I find them. I wrote it many months ago and have run it from time to time since, so most issues have been fixed. The reason I wrote it was that I was irritated that important messages scrolled of screen. > If it's nice isn't it worth advertising to the Wine > developper community? I had intended to do that if but since I was unsure that Alexandre would apply my Makefile patch I decided to wait until it could present a better "user interface". But by all means test it.

2 1

RE: Even more misc fixes
by Patrik Stridvall July 26, 2001

July 26, 2001

> [...] > > > Most of these are because of the transition to making > HANDLE a void* > > > and compiling with STRICT. > > > > Yes, I notice this was the case with TIMERPROC casts. > > However it is no so with the HOOKPROC casts, > > and yes it is the same with the real Windows headers. > > ??? > AFAICS there are two versions of HOOKPROC: one for -DSTRICT and a > FARPROC one. Hmm. I looked again and it seems you are right. Must have missed it somehow. Strange. > [...] > > But OK I will try and compile with -DSTRICT and see what happends. > > IIRC somebody tried that but it didn't turn out so well. > > That would be me, probably. I started the conversion to -DSTRICT but > then other priorities came up and now it's on the back burner. I will > get back to it eventually but at the current rate it's hard > to know when > that will be :-( > Compiling with -DSTRICT is not that bad: with a relatively simple > patch it compiles (see attachement). Or at least, it used to. > But there > are tons of warnings, which means tons of places that need > attention and > possibly fixing. That's where the work is. OK. Will look at it later.

1 0

RE: Even more misc fixes
by Patrik Stridvall July 26, 2001

July 26, 2001

> The volatile stuff in dplay.h is part of the Windows header, you > cannot remove it. No it isn't. I'm not sure why it was added in the first place. It is neither used by Wine, nor defined by Windows. In fact only a few strange headers use volitile at all, and none of them is supported by Wine. > Most of these are because of the transition to making HANDLE a void* > and compiling with STRICT. Yes, I notice this was the case with TIMERPROC casts. However it is no so with the HOOKPROC casts, and yes it is the same with the real Windows headers. > Please don't add typecasts, consider the > warnings as an incentive to do the right fix... As you wish, but as I said HOOKPROC can't be fixed with STRICT. But OK I will try and compile with -DSTRICT and see what happends. IIRC somebody tried that but it didn't turn out so well. Oh well, lets see what happends.

2 1

RE: Even more misc fixes
by Patrik Stridvall July 26, 2001

July 26, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > No it isn't. I'm not sure why it was added in the first place. > > It is neither used by Wine, nor defined by Windows. > > It is in the Windows headers I have. It is not in my Microsoft Visual C++ 6.0 header, but perhaps you have a newer version? DPlay using volatile seems a little strange, so I thought is was wrong especially since it was not in my version, but then I have seen stranger things. :-) > > As you wish, but as I said HOOKPROC can't be fixed with STRICT. > > Why not? Because it would be incompatible (warning wise) with Winelib applications compile with -DSTRICT since Windows doesn't provide a special -DSTRICT version of HOOKPROC. The application might pass a FARPROC to it and expect it to work. Well, of course it works but it would generate a warning.

1 0

Re: winapi update
by Alexandre Julliard July 26, 2001

July 26, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > The make_filter.diff patch is quite nice. > > Try it after applying it with by running: > make filter I'm not sure about the portability of the wildcard rule. Why don't you have make_filter call make instead of the other way around? This would avoid the need for changing the makefiles at all. -- Alexandre Julliard julliard(a)winehq.com

2 1

RE: winapi update
by Patrik Stridvall July 26, 2001

July 26, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > The make_filter.diff patch is quite nice. > > > > Try it after applying it with by running: > > make filter > > I'm not sure about the portability of the wildcard rule. Why don't you > have make_filter call make instead of the other way around? This > would avoid the need for changing the makefiles at all. Well, make_filter actually calls make already. :-) Seriously, one reason that I added it to the Makefiles in the first place is that make_filter doesn't know what version of make to use. Sure it is called make on almost all systems and gmake (GNU Make) on most of rest, but since the user knows and calls "make", $(MAKE) contains the correct "make". Oh well, I guess just calling make will work on most platforms, it will on all platforms that I current use. The Wine Makefile is supposed to be portable so I guess it will have to do.

1 0

Re: Even more misc fixes
by Alexandre Julliard July 26, 2001

July 26, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > No it isn't. I'm not sure why it was added in the first place. > It is neither used by Wine, nor defined by Windows. It is in the Windows headers I have. > As you wish, but as I said HOOKPROC can't be fixed with STRICT. Why not? > But OK I will try and compile with -DSTRICT and see what happends. > IIRC somebody tried that but it didn't turn out so well. No it needs a lot of fixes, which is what the warnings are here to remind us of. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Even more misc fixes
by Alexandre Julliard July 26, 2001

July 26, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > * include/commctrl.h, > include/dplay.h: > Cleanup/removal of unnessary things that would have made > winapi_* parsing more complicated. The volatile stuff in dplay.h is part of the Windows header, you cannot remove it. > * dlls/comctl32/commctrl.c, > dlls/comctl32/tab.c, > dlls/dinput/dinput_main.c, > dlls/dsound/dsound_main.c, > dlls/ole32/clipboard.c, > dlls/ole32/ole2.c, > dlls/wineps/ps.c, > dlls/winmm/joystick.c, > dlls/winmm/wineoss/midi.c, > loader/dos/dosmod.c, > windows/caret.c: > Fixed some warnings. Most of these are because of the transition to making HANDLE a void* and compiling with STRICT. Please don't add typecasts, consider the warnings as an incentive to do the right fix... -- Alexandre Julliard julliard(a)winehq.com

1 0

How do I stop clipping?
by Bill Medland July 26, 2001

July 26, 2001

I don't like submitting incomplete code but I may have little choice unless someone can point me in the correct direction here. As you may guess from the following, my Windows experience is not that extensive but I think it's enough to allow me to make sensible contributions. I am working on correcting the LISTVIEW_DrawLargeItem function, especially when the item text is large. I have already got most of the way. However the problem is this. When a user selects a large icon the text should be written completely (by calling DrawText with DT_NOCLIP). It is doing so; I can prove it by resizing the window and I will see the full text being displayed for a selected item. However when drawing it at the moment of selecting it, the text is being clipped to the usual two and a bit rows. Presumably this means that there is a clipping rectangle in the DC or the window that I need to inflate. Or Do I simply invalidate that rectangle (from within the WM_PAINT handler!!!). Any help would be appreciated. Bill

1 0

Re: Handling X errors using exception handlers
by Alexandre Julliard July 26, 2001

July 26, 2001

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > Do you plan to implement it or should I do it (be warned though that I can > work on it only if the weather is bad this week-end :-) ). I'll do it. I had a version working some time ago, I just need to adapt it to the new per-thread displays. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Handling X errors using exception handlers
by Alexandre Julliard July 26, 2001

July 26, 2001

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > The only problems I could see with this approach is that : > > - it cannot 'expect' more than one kind of error at the same time I was thinking you could use a special value as a "wildcard" for the error codes, in which case it wouldn't be tested for a match. > - I am not sure that the parameters thing are really a good idea. Are we > sure that the error code are the same on all X servers ? Are they > standardized ? They are part of the X spec AFAICT, so yes it should be pretty much standard. -- Alexandre Julliard julliard(a)winehq.com

2 1

native dll's
by José Soriano Díaz July 26, 2001

July 26, 2001

Hi there, I'm working in a telerobotics project and I need to link a windows dll in order to use a Cybernet Joystick. First I tried to use the winAPI functions LoadLibrary,FreeLibrary and GetProccessAddress as I were working on Windows, and I recompiled my program with winelib: *. winemaker /my_path/ *. ./configure *. make all but it didn't create any executable, what I obtained was a lib*.so, because winemaker thought I was trying to compile a dll, not to use one. After that I tried to compile my program without winemaker, and I obtained a HEAP_PTR error when executing what I copiled. And If I tried to link the lib*.so and load the main symbol I obtained the same error. So my question is quite siple How can I link a native dll in a Unix project? I've read somewhere that I have to use a parser, Is there anybody who can give me some code? Thanks for your precious time. _________________________________________________________________ Descargue GRATUITAMENTE MSN Explorer en http://explorer.msn.es/intl.asp

2 1

DrawText
by Travis Michielsen July 26, 2001

July 26, 2001

Fully implement DrawText* functions. - Travis Michielsen __________________________________________________ Do You Yahoo!? Make international calls for as low as $.04/minute with Yahoo! Messenger http://phonecard.yahoo.com/

2 5

Re: CallWindowProc syntax
by Alexandre Julliard July 25, 2001

July 25, 2001

Marco Bizzarri <m.bizzarri(a)icube.it> writes: > While looking at the source code of wine, I looked into the synopsys of > the CallWindowProc function. According to winproc.c, the hWnd parameter > should be the handle to the window which has to receive the message. > > OTOH, if you look at MSDN, at > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/hh/w… > > it looks like the hWnd is the windows procedure which should receive the > message. hWnd is clearly a window handle, not a window procedure. As a rule, any resemblance between what MSDN says and what the code actually does is purely fortuitous. -- Alexandre Julliard julliard(a)winehq.com

1 0

Wine Winex Half-life/Nox and alsa
by FT Rathore July 25, 2001

July 25, 2001

Hi I tried Jul 23 cvs of wine and winex and tried with Nox and Half Life. Both wine and winex work fine with the stock kernel sound drivers (es1371) but they do not work well with alsa with oss emulation. The sound gets played extremely fast in Half-Life like someone hit the fast-forward button. It is strange because the timing on the alsa oss-emulation (and commercial oss drivers) is better than the stock kernel drivers. Winex does a lot of improvement in Half-Life and it is fully playable (the splash, the menu and everything). Nox works near perfect with wine but it does not work at all with winex. FT

1 0

(no subject)
by José Soriano Díaz July 25, 2001

July 25, 2001

Hi there, I'm working in a telerobotics project and I need to link a windows dll in order to use a Cybernet Joystick. First I tried to use the winAPI functions LoadLibrary,FreeLibrary and GetProccessAddress as I were working on Windows, and I recompiled my program with winelib: *. winemaker /my_path/ *. ./configure *. make all but it didn't create any executable, what I obtained was a lib*.so, because winemaker thought I was trying to compile a dll, not to use one. After that I tried to compile my program without winemaker, and I obtained a HEAP_PTR error when executing what I copiled. And If I tried to link the lib*.so and load the main symbol I obtained the same error. So my question is quite siple How can I link a native dll in a Unix project? I've read somewhere that I have to use a parser, Is there anybody who can give me some code? Thanks for your precious time. _________________________________________________________________ Descargue GRATUITAMENTE MSN Explorer en http://explorer.msn.es/intl.asp

1 0

CallWindowProc syntax
by Marco Bizzarri July 25, 2001

July 25, 2001

Hi all. While looking at the source code of wine, I looked into the synopsys of the CallWindowProc function. According to winproc.c, the hWnd parameter should be the handle to the window which has to receive the message. OTOH, if you look at MSDN, at http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/hh/w… it looks like the hWnd is the windows procedure which should receive the message. Can anyone help? Thanks Marco Bizzarri m.bizzarri(a)icube.it

1 0

Re: Make built-in font data read-only
by Alexandre Julliard July 25, 2001

July 25, 2001

Ian Pilcher <ian.pilcher(a)home.com> writes: > If all pointers have to be eliminated, I can't see any way to do it. > In order for the code to have any kind of sanity, built-in font metrics > and dynamically loaded font metrics have to use the same data model, and > I don't think it's even remotely practical to get rid of the pointers in > the case of the dynamically loaded metrics. Well, if it's not feasible so be it. But if it's at all possible I think it's worth some reasonable amount of trouble. > I'm open to suggestions, but I think that the effort involved in doing > this (assuming a sane way could be found) probably far outweighs the > benefit (less swap usage if the data is paged out; is there any other > benefit?). The main benefit is sharing between processes; so if you have 10 processes that want to print you only have one copy of the font data in memory. Plus it gets loaded on-demand so data that isn't used doesn't need to be loaded from disk at all. > Just in case I get inspired, though, what tool/command are you using to > determine read-only vs. read/write data sizes? Can I just go by what > objdump says about .data and .rodata? objdump is fine yes. size works too, though I seem to remember some versions not counting .rodata correctly. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Make built-in font data read-only
by Alexandre Julliard July 25, 2001

July 25, 2001

Ian Pilcher <ian.pilcher(a)home.com> writes: > Log message: > Ian Pilcher <ian.pilcher(a)home.com> > WINEPS: make built-in font data read-only Unfortunately the data still isn't stored in read-only memory even though it is declared const, because the structures contain pointers that require relocation. Would it be possible to store offsets instead of pointers? -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: move 16bit COMM code to USER
by lawson_whitney＠juno.com July 25, 2001

July 25, 2001

On Tue, 24 Jul 2001 11:11:05 +1000 Mike McCormack <mike_mccormack(a)start.com.au> writes: > This is a multi-part message in MIME format > > ------=_NextPart_000_83577347 > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > > > This patch completes the seperation of the 16bit COMM code from > KERNEL > and moves it to USER. Seems to work with Terminal from WFW 3.11. > > Mike If you get this, it seems to work for juno 1.49 too. Lawson ---oof--- > ChangeLog: > move 16-bit COMM code to USER dll > > ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Microsoft source code releases - a danger to Wine?
by Ian Pilcher July 24, 2001

July 24, 2001

According to Slashdot, Microsoft has released the Windows CE source code under one of their "shared source" licenses. Needless to say, it would be an *extremely* bad idea for anyone associated with the Wine project to look at it. This leads me to wonder if anyone's ever thought of taking steps to protect Wine from "contamination" by Microsoft IP (legally, not tech- nically :-). As the number of programmers who have been exposed to MS source code grows the chances of this happening will increase. I believe that the FSF uses some type of form/statement before they will accept code, and it seems like the nature of this project would make it particularly beneficial. -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

5 6

Re: oleaut32 patch
by Alexandre Julliard July 24, 2001

July 24, 2001

Andreas Mohr <a.mohr(a)mailto.de> writes: > - changes OaBuildVersion() to always return a very high version value > (2.xx.0xffff), which can be overridden in the config file to deliver > an exact value instead Do we really need such an obscure parameter in the main config file? Are there actual cases where setting the version based on -winver is not enough? -- Alexandre Julliard julliard(a)winehq.com

1 0

Compile error, Please help!!!!!Thanks
by EriK W July 24, 2001

July 24, 2001

Hi gurus, Please help me out with the fatal compiling problem. I am using soalris8 x86 with wine-20010629, Any suggestion would be highly appreciated! /usr/openwin/include/X11/Xutil.h:56: warning: ignoring pragma: "@(#)Xutil.h 1.2 00/07/05 SMI gcc -Wl,-G -Wl,-h,/usr/local/lib/libwine_tsx11.so locking.o ts_xf86dga.o ts_xf86dga2.o ts_xf86vmode.o ts_xshm.o ts_xlib.o ts_xresource.o ts_xvideo.o ts_xutil.o ts_shape.o ts_xpm.o -o libwine_tsx11.so.1.0 rm -f libwine_tsx11.so && ln -s libwine_tsx11.so.1.0 libwine_tsx11.so LD_LIBRARY_PATH="../../unicode:$LD_LIBRARY_PATH" ../../tools/winebuild/winebuild -fPIC -L../../dlls -o ntdll.spec.c -spec ./ntdll.spec ld.so.1: ../../tools/winebuild/winebuild: fatal: /usr/local/lib/libwine_unicode.so: open failed: No such file or directory *** Error code 137 make: Fatal error: Command failed for target `ntdll.spec.c' Current working directory /export/home/ericw/system/wine-20010629/dlls/ntdll *** Error code 1 make: Fatal error: Command failed for target `ntdll/libntdll.so' Current working directory /export/home/ericw/system/wine-20010629/dlls *** Error code 1 make: Fatal error: Command failed for target `dlls'

1 0

Re: Function declaration fixes
by Francois Gouget July 23, 2001

July 23, 2001

On Mon, 23 Jul 2001, Patrik Stridvall wrote: [...] > *** declarations > > * dlls/msvcrt/cpp.c, > dlls/msvcrt/exit.c, > dlls/msvcrt/mbcs.c, > dlls/msvcrt/msvcrt.h, > dlls/ntdll/signal_i386.c, > dlls/shell32/shlmenu.c, > include/wine/undocshell.h: > - Made sure that the files that contains the declarations > of the implementated functions are included. > - Corrected mismatching prototypes. > - Cleaned up the include section. You should not add a prototype for MSVCRT_isleadbyte and MSVCRT_realloc in wine/dlls/msvcrt/msvcrt.h. These are declared in include/msvcrt/wctype.h and include/msvcrt/malloc.h respectively. The correct fix is to include these headers where needed. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

1 0

[PROBLEM REPORT] Edit control line scrolling
by Gerard Patel July 23, 2001

July 23, 2001

With programs using a multiline edit control, such as Notepad (I'm using Win3.11 version) or Eudora Light 1.5 with mails from the 'In' mailbox (this is a 32 bits application), scrolling down the edit buffer line by line mostly does not work. In fact, it works only if the edit buffer size is an exact multiple of the line height. In all other cases, the format rectangle is smaller than the client size, and when the edit control tries to redraw the last line, the update rectangle is wrong : only the lower part of the line is drawn. I think that this problem can be traced to the replacement of code in ScrollWindowEx by the call to ScrollDC. What is happening is that the client rectangle is scrolled, but the client rectangle is bigger than the formatting rectangle by a few pixels; these pixels are missing in the update region. In Wine previous version, the client rectangle was first ANDed with the so-called 'visible region' (hvisRgn), so the result was not bigger than the format rectangle before being scrolled, then diff-ed with it. The following patch works around this problem. I don't have time to investigate further as I am taking one week of holidays :-) but if someone is interested in the edit control.... Gerard Index: dlls/x11drv/scroll.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/scroll.c,v retrieving revision 1.2 diff -u -r1.2 scroll.c --- dlls/x11drv/scroll.c 2001/06/20 00:18:48 1.2 +++ dlls/x11drv/scroll.c 2001/07/22 22:12:06 @@ -114,7 +114,7 @@ hrgn2 = CreateRectRgnIndirect( &rect ); if (hrgn) SetRectRgn( hrgn, rClip.left, rClip.top, rClip.right, rClip.bottom ); else hrgn = CreateRectRgn( rClip.left, rClip.top, rClip.right, rClip.bottom ); - CombineRgn( hrgn, hrgn, hrgn2, RGN_AND ); + CombineRgn( hrgn2, hrgn, hrgn2, RGN_AND ); OffsetRgn( hrgn2, dx, dy ); CombineRgn( hrgn, hrgn, hrgn2, RGN_DIFF );

2 1

Why is this wrong?
by Bill Medland July 23, 2001

July 23, 2001

The code of "perfect_graphics" (attached) gives my system problems. The visible aspect of the problem is that the text in our application's listview doesn't get drawn properly. By experimentation I have narrowed it down to when perfect_graphics was edited. I observe that our application works correctly under the two following cases: 1. When the body of the function is removed and the value is hard-coded to true 2. When the "inline" is removed (which is the fix I am proposing and will submit in a moment) Since I do not like working without understanding I would like to know: Is there something wrong with the use of "inline" in this context? Or is there clearly something wrong with my build environment? Or is everyone else as confused by it as me? TIA Bill begin 600 e1 M+RHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ M*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ#0H@*B @(" @(" @(" @<&5R M9F5C=%]G<F%P:&EC<PT*("H-"B J($9A=F]R(&-O<G)E8W1N97-S(&]R('-P M965D/PT*("HO#0IS=&%T:6,@:6YL:6YE(&EN="!P97)F96-T7V=R87!H:6-S M*'9O:60I#0I[#0H@(" @<W1A=&EC(&EN="!P97)F96-T(#T(a)+3$[#0H@(" @ M:68@*'!E<F9E8W0@/3T(a)+3$I#0H@(" @>PT*"4A+15D@:&ME>3L-"@EC:&%R M(&)U9F9E<ELR,%T[#0H)+RH(a)9&5F875L="!V86QU92 J+PT*"7!E<F9E8W0@ M/2 P.PT*"6EF*"%296=/<&5N2V5Y02A(2T597TQ/0T%,7TU!0TA)3D4L(")3 M;V9T=V%R95Q<5VEN95Q<5VEN95Q<0V]N9FEG7%QX,3%D<G8B+" F:&ME>2DI M#0H)>PT*"2 @("!$5T]21"!T>7!E+"!C;W5N=" ]('-I>F5O9BAB=69F97(I M.PT*"2 @("!I9B(a)A4F5G475E<GE686QU945X02AH:V5Y+" B4&5R9F5C=$=R M87!H:6-S(BP@,"P@)G1Y<&4L(&)U9F9E<BP@)F-O=6YT*2D-"B @(" @(" @ M(" @('L-"B @(" @(" @(" @(" @("!C:&%R(&-H(#T(a)8G5F9F5R6S!=.PT* M(" @(" @(" @(" @(" @('!E<F9E8W0@/2 H8V@@/3T@)WDG('Q\(&-H(#T] M("=9)R!\?"!C:" ]/2 G="<@?'P(a)8V@@/3T@)U0G('Q\(&-H(#T]("<Q)RD[ M#0H@(" @(" @(" @("!]#0H)(" @(%)E9T-L;W-E2V5Y*&AK97DI.PT*"7T- @"B @("!]#0H@(" @<F5T=7)N('!E<F9E8W0[#0I]#0IY ` end

1 0

Re: Executable permissions on .exe/.com files
by Alexandre Julliard July 23, 2001

July 23, 2001

Bernhard Rosenkraenzer <bero(a)redhat.de> writes: > Since some people will probably want to use BINFMT_MISC or similar > functionality to run wine transparently, I think we need the possibility > to set executable permissions on wine-generated (e.g. by "wine setup.exe") > .exe/.com files. > > This patch implements this (optionally - new configure switch). I have applied it, but without the configure switch. I think it should be OK to always set the permissions, and if it turns out to cause trouble we should add a run-time option, not a compile-time one. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: implement BuildCommDCB16 using BuildCommDCB
by lawson_whitney＠juno.com July 23, 2001

July 23, 2001

On Mon, 23 Jul 2001 16:59:35 +1000 Mike McCormack <mike_mccormack(a)start.com.au> writes: > This is a multi-part message in MIME format > > ------=_NextPart_000_80675836 > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > > > This (untested) patch completes the COMM16 code seperation. The > COMM16 > code can now be moved into USER (i think). > > Mike Juno 1.49 finds no fault with this, but AFAICS from a comm trace, the app doesn't use the DCB functions, so this is not such a conclusive test. Anybody else have any 16 bit comms apps? Lawson ---oof--- > ChangeLog: > rewrite BuildCommDCB16 to depend on BuildCommDCB, not vice-versa > ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Still problems with snoop
by Uwe Bonnes July 23, 2001

July 23, 2001

Hallo, some days ago I reported early crashes when running with the snoop debug option. E.g. vc98 msedv.exe is a good example. Running with "+snoop" crashes early. Running with "-snoop=devshl" lets the program succeed much further. Running without snoop gets even substancial further. So I think there must be something wrong with snoop. I tried to look hard at relay32/snoop.c, but didn't see anything fishy. So perhaps somebody else has some idea what's going wrong. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Re: PATCH: msvcrt.ungetc
by Alexandre Julliard July 23, 2001

July 23, 2001

Marcus Meissner <marcus(a)jet.franken.de> writes: > --- include/msvcrt/stdio.h 2001/05/07 18:18:34 1.2 > +++ include/msvcrt/stdio.h 2001/07/21 12:43:43 > @@ -72,6 +72,7 @@ > int _charbuf; > int _bufsiz; > char* _tmpfname; > + int _ungetc; > } MSVCRT(FILE); You cannot do that, the FILE structure has to remain binary compatible. -- Alexandre Julliard julliard(a)winehq.com

2 1

RE: Microsoft source code releases - a danger to Wine?
by Patrik Stridvall July 22, 2001

July 22, 2001

> There'a a legal doctrine whose name I can remember (I'm too young for > senior moments!) ... "inevitable contamination" or something It is call "inevitable disclosure" I think. > like that. > The basic idea is that someone who had been exposed to > Microsoft source > code and then worked on Wine within a given period of time would be > assumed to have used knowledge gained from that exposure. I believe > that the burden would be on that person or the Wine project to show > the opposite. For that person, perhaps. IIRC the doctrine of "inevitable disclosure" it on a little shaky ground as it is eventhough some Judges have use it so far, it is NOT 100% established doctrine. As far as the Wine project is concerned, you will have to stretch the doctrine pretty far since the Wine project can't possibly know what a patch submittor has done before unless he tells us himself. > This is what I'm really worried about. Some well-meaning hacker takes > "Advanced Operating System Theory" at a Microsoft-beholden university > and then makes a contribution to Wine. (The more I think about it, > I'm surprised Microsoft isn't trying harder to expose more people to > their code and license.) Sure, we probaly need to make others more aware of that, but that primarily concerns them, not us. > Fair use? We don't need stinking fair use! After all, that might > interfere with corporate earnings reports. (I'm too old to become a > communist!) And favouring fair use have what to do with communism? It is entirely possible to have a capitalistic society without Intellectuall Property (IP) at all or with very weak IP (strong fair use). > > That said, nothing I can see appears to restrict someone > who has accepted > > their license from answering explicit questions we might > have, so long as > > they are not doing so for hire (thus 'commercially'), and > so long as they > > don't distribute source code. A fair bit of useful > knowledge might be > > gained in that way, albeit slowly. > > > > > Now you're really scaring me! Why? Any violation is primarily their problem and extending derived work over a verbal description is stretching far to far. This has already been established by actual court case.

2 1

RE: Microsoft source code releases - a danger to Wine?
by Patrik Stridvall July 22, 2001

July 22, 2001

> > Worse yet: If we coincidentally use similar code to theirs, > how can we > > prove we haven't looked at their code? If I were paranoid, > I'd say the > > single purpose of releasing the source was to get wine in trouble. > > It's not paranoia when they really are out to get you! Perhaps not, but do you really have proof that they are out to get you? :-) Seriously, I think you should calm down, getting to upset will do you no good. > IANAL, but distribution has been limited enough to this point > that they > would probably have to show some plausible manner in which > the exposure > could have occured. That's why I think wider distribution increases > the vigilance required. The burden of proof is still on Microsoft, not us.

1 0

RE: Microsoft source code releases - a danger to Wine?
by Patrik Stridvall July 22, 2001

July 22, 2001

> On Sat, 21 Jul 2001, Ian Pilcher wrote: > > > This leads me to wonder if anyone's ever thought of taking steps to > > protect Wine from "contamination" by Microsoft IP (legally, > not tech- > > nically :-). > > What can we do about that? Since none of the people involved > is going to > have a look at the actual M$ source, how are we supposed to know if a > patch posted on the list is taken from them? We can't and we don't have to. The burden of proof is on Microsoft. Of course it is a civil cases and the proof need only be on preponderence of evidence but it still their burden primarily. > Worse yet: If we coincidentally use similar code to theirs, how can we > prove we haven't looked at their code? If I were paranoid, I'd say the > single purpose of releasing the source was to get wine in trouble. First of all: We know who submitted a patch since that information is in the CVS log, so unless they can prove that Alexandre should have realized the person submitting the patch, submitted code not copyrighted by that person, the burden fall on that person and that person alone. If that person can't be identified through the e-mail adress to bad for Microsoft. If he can they will have to drag him to court, not the Wine project. Sure Microsoft probably can ask the Wine remove the offending code and sue us if we don't, but since we in fact also are a victim of the submitters misrepresentation I think any reasonable judge would: 1. Require that Microsoft prove that the code is theirs. This might be a little difficult without providing the actual code to the Wine project and requiring any developer of the Wine project to taint him self by signing a NDA with Microsoft would probably not required by the court. So the reasonable cause of action would for Microsoft to release the code without a license that could taint us or pay for an independent 3rd party to review and establish this. 2. Require that Microsoft provide a patch to remove the offending code from the current CVS. Note that we also are a victim so requiring more would probably be considered unreasonable. Why should we pay for (in money or effort) somebody elses crime or legal liabillity against Microsoft. All in all I think the Judge would be rather annoyed that Microsoft didn't try to solve this problem without him. In short, while IANAL, if Microsoft (or somebody) feels that some code in the CVS is copyrighted by them we should simple require that. 1. Prove it to us, without any risk of taint, or to some independent 3rd party at their expense. 2. Provide a patch against the current CVS that removes the offending code preferable made by the same 3rd party as above at their expense. 3. Require that the 3rd party sign a statement under perjury that the patch removes the offending code and only the offending code. Remember we are also a victim under such an event and requiring more would probably not be look on favourable by the courts.

1 0

Proposed config file change
by Andreas Mohr July 21, 2001

July 21, 2001

Hi all, I've been thinking for a rather long while now that the config file has a rather poor format. Several settings are pretty misplaced, and it tends to get chaotic. Let me just suggest something different: [COMM\\ParallelPorts] "Lpt1" = "..." "ppdev_378" = "..." [COMM\\SerialPorts] [COMM\\RASAPI] [COMM\\TAPI] [COMM\\WININET] [COMM\\WINSOCK] [DLLs\\Overrides] [File\\Drive x] [File\\General] "Windows" = "..." "System" = "..." "Temp" = "..." "Path" = "..." "ShowDirSymlinks" = "..." [File\\Registry] "LoadGlobalRegistryFiles" = "Y" "LoadHomeRegistryFiles" = "Y" "LoadWindowsRegistryFiles" = "Y" "WritetoHomeRegistryFiles" = "Y" "SaveOnlyUpdatedKeys" = "Y" "Profile" = "c:\\windows\\Profiles\\Administrator" [Graphics] "GraphicsDriver" = "x11drv" "WineLook" = "Win95" [Graphics\\DirectX] [Graphics\\Fonts] ;See a couple of examples for russian users below "Resolution" = "96" "Default" = "-adobe-helvetica-" "DefaultFixed" = "fixed" "DefaultSerif" = "-adobe-times-" "DefaultSansSerif" = "-adobe-helvetica-" [Graphics\\OpenGL] [Graphics\\Printing\\afmdirs] [Graphics\\Printing\\Spooler] "FILE:" = "tmp.ps" "LPT1:" = "|lpr" "LPT2:" = "|gs -sDEVICE=bj200 -sOutputFile=/tmp/fred -q -" "LPT3:" = "/dev/lp3" [Graphics\\Screen\\ttydrv] ;"Drivers" = "tty" ;"XtermProg" = "nxterm" ;"InitialRows" = "25" ;"InitialColumns" = "80" ;"TerminalType" = "nxterm" [Graphics\\Screen\\x11drv] ... [Sound\\DSOUND] "EmulatedDriver" = "..." [Sound\\WinMM] "Drivers" = "wineoss.drv" "WaveMapper" = "msacm.drv" "MidiMapper" = "midimap.drv" [wine] "ShellLinker" = "wineshelllink" [wine\\Clipboard] "ClearAllSelections" = "0" "PersistentSelection" = "1" [wine\\Ports] ;"read" = "0x779,0x379,0x280-0x2a0" ; "write" = "0x779,0x379,0x280-0x2a0" [wine\\Spy] "Exclude" = "WM_SIZE;WM_TIMER;" This has the advantage that it has a very basic structure (COMM, DLLs, File, Sound, Wine), and you always know where to start searching. I haven't spent much thought on whether it's really "right" and, most importantly, extensible, though. Comments ? -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0

Re: glibc bug mmap/malloc
by Alexandre Julliard July 21, 2001

July 21, 2001

Andreas Mohr <a.mohr(a)mailto.de> writes: > I mean, come on: why did they bother to implement malloc() at all > if the resulting architecture is THAT broken ? It's not broken, it just doesn't play well with programs like Wine that muck around with the process address space. But it's a perfectly reasonable (if not optimal) implementation for "normal" Unix apps. -- Alexandre Julliard julliard(a)winehq.com

2 1

Wine doesn't seem to like TrueType fonts.
by David Hagood July 21, 2001

July 21, 2001

Has anybody else seen this behavior: I have a directory of TrueType fonts that I can point xfs to. When I have that directory in the fontlist, wine ALWAYS regenerates the font cache on every start (thus slowing Wine down immensely). Remove the TrueType directory from the font table, and all is well: Wine will regenerate the font cache once, and then use the font cache from there on.

1 0

Marshaling
by Daniel Walker July 21, 2001

July 21, 2001

From what I've read when someone creates a custom interface for COM, an IDL file is generated, then the MIDL compiler uses the IDL file to create proxy and stub code that works with the standard COM RPC functionality.. So under some (most) circumstances wine's COM implementation would only have to facilitate the sending and recieving of the marshaled data .. Not to minimize the work involved .. The standard marshaling would have to do all the generic COM interfaces like IUnknown, IStorage, IStream (I think). Even though full implementations of those would be available . But most components would have custom interfaces so they would also have their own marshaling code .. If I'm 100% correct then , I guess, there wouldn't be a need for the type information. Yet it exists .. Unless the type info is used for something other than marshaling. Daniel Walker

2 1

Re: more misc fixes
by Alexandre Julliard July 20, 2001

July 20, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > OK. So what you really what is exactly the opposite of what I tried to do? Yep ;-) > You want all 16-bit exported function prototypes moved from the .h > files to the implementing .c file in all cases that is is possible (ie Wine > compiles without errors or warnings)? Exactly; but note that in most cases the prototype is not even needed at all. I don't want all 16-bit C files to start with a bunch of prototypes either, this would just be unnecessary duplication; only the functions that are actually called from elsewhere in the file should be prototyped IMO. > Do you also want the types and structures moved as well? > That will often not be possible, but do you want it > despite this in the cases where it is possible? Wherever possible it would be a good thing yes. -- Alexandre Julliard julliard(a)winehq.com

3 2

UNC
by Bill Medland July 20, 2001

July 20, 2001

Is anyone doing anything on UNC filenames? (In particular I am interested in GetFileAttributes) Bill

2 1

Re: attempting to load mIRC32 5.91 using latest wine cvs
by mdew July 20, 2001

July 20, 2001

On Thu, 19 Jul 2001 11:05:55 +0200 Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > >>>>> "mdew" == mdew <rpbrown(a)xtra.co.nz> writes: > > mdew> mdew(a)storm:~$ /usr/local/bin/wine fake_windows/mIRC/mirc32.exe > mdew> FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock > mdew> FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock > mdew> err:module:BUILTIN32_dlopen failed to load .so lib for builtin > mdew> x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: > mdew> XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' > > Either get an newer X-Server with DGA capabilities, or configure and compile > on your system. i do...in fact, i downloaded an older version of wine (20010510) which works fine... Im running Debian Sid which comes with XFree86 4.0.3 and using the Nvidia openGL drivers.. dga works in all apps i use (mplayer, quake3, MAME) just not the latest cvs of wine.

1 0

Re: COMM16: use overlapped I/O not service thread
by lawson_whitney＠juno.com July 20, 2001

July 20, 2001

On Fri, 20 Jul 2001, Mike McCormack wrote: > > Hi, > > i've tested this patch a little... with wfw3.1 terminal, i can type AT > and receive OK from my modem, but i'm not supremely confident about > it. If somebody :-) could test it and review it a bit i'd be > grateful... > > Mike > > ChangeLog: > Replace service thread with ReadFileEx/WriteFileEx for COMM16. > > So as not to damn it with faint praise, my 16 bit app sent a response, and received 0 messages successfully. I _think_ it is OK, there shouldn't have been any messages for it to receive. Lawson ---oof--- ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Re: COMM16: use overlapped I/O not service thread
by lawson_whitney＠juno.com July 20, 2001

July 20, 2001

On Fri, 20 Jul 2001 12:33:23 +1000 Mike McCormack <mike_mccormack(a)start.com.au> writes: > This is a multi-part message in MIME format > > ------=_NextPart_000_53222353 > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > > > Hi, > > i've tested this patch a little... with wfw3.1 terminal, i can type > AT > and receive OK from my modem, but i'm not supremely confident about > it. If somebody :-) could test it and review it a bit i'd be > grateful... > > Mike > > ChangeLog: > Replace service thread with ReadFileEx/WriteFileEx for COMM16. > > If you get this, my 16 bit comms app can at least send mail with your patch. It aint much, but it is a bit more than terminal.exe talking to a modem. Lawson --- Somebody, somebody has to, you see, So she picked out two somebodies, Sally and me. - T.S.G. ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

RE: more misc fixes
by Patrik Stridvall July 19, 2001

July 19, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Ah. You are right, I orginally meant to add it in a > > different file (wine/obj_base16.h perhaps) but I didn't > > think it would matter since other 16 bit interface like > > IStream16 and IStorage16 is in wine/obj_*.h already. > > Perhaps they should be move out as well? > > > > If so to where? wine/obj_*16.h or perhaps the DLLs > directories if possible? > > The DLL directories definitely; and if possible in the .c file where > they are needed, to make it clear they must not be used from the > outside. Ah, yes. The implementing .c file, thats an idea. Like in dlls/lzexpand/lzexpand_main.c, I guess you mean? > > In addition (as I hinted in 5.) requiring all non-static functions > > to have a .h file declaration is good policy for any application > > including Wine. Hint, if a function isn't static somebody else > > should use it otherwise some else is wrong, ie it really should > > be static after all. > > All 16-bit API functions must be treated as if they were static. Well we could actually make them truely static with a little trickery and a corrensponding change of winebuild. Idea: #define DECLARE_ENTRY_POINT16(module, function) \ void *module##_p##function = (void *) &function /* After the includes */ static void Foo(void *, int); DECLARE_ENTRY_POINT16(BAR, Foo); /* ... */ static void Foo(void *, int) { /* ... */ } It is probably not worth the trouble though. > They > cannot be because of the spec file reference, but ideally no code > should ever call a 16-bit API, it should use the corresponding 32-bit > API. Adding prototypes and a header file is only going to encourage > using these functions which is not what we want. OK. So what you really what is exactly the opposite of what I tried to do? You want all 16-bit exported function prototypes moved from the .h files to the implementing .c file in all cases that is is possible (ie Wine compiles without errors or warnings)? Do you also want the types and structures moved as well? That will often not be possible, but do you want it despite this in the cases where it is possible?

1 0

RE: Lots of #defines OK?
by Patrik Stridvall July 19, 2001

July 19, 2001

> Patrik Stridvall wrote: > > Not really, but as an alternative solution you could has a structure > > instead of an array like: > > > > typedef struct { > > GLYPHNAME A; > > GLYPHNAME AE; > > GLYPHNAME AEacute; > > GLYPHNAME AEsmall; > > /* ... */ > > } GLYPHNAMES; > > > > Perhaps this is better since it doesn't use the preprocessor. > > I not thought of that -- neat idea. What is the downside of using the > preprocessor, however? Well, the preprocessor "pollutes" the namespace in a way that is sometimes bad and my solution gives IMHO a slightly nicer syntax. Is this case in don't think it matters so much though, your orginal solution is fine, in fact is the standard solution in C to the problem you have AFAIK. My suggestion is really just brainstorming to give you hopefully a different perspective of the issue. Also note that your solution is not possible with languages that don't have pointer aritmetics that C, fortunately or unluckily depending on how you see it, have.

2 1

Re: more misc fixes
by Alexandre Julliard July 19, 2001

July 19, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > Ah. You are right, I orginally meant to add it in a > different file (wine/obj_base16.h perhaps) but I didn't > think it would matter since other 16 bit interface like > IStream16 and IStorage16 is in wine/obj_*.h already. > Perhaps they should be move out as well? > > If so to where? wine/obj_*16.h or perhaps the DLLs directories if possible? The DLL directories definitely; and if possible in the .c file where they are needed, to make it clear they must not be used from the outside. > In addition (as I hinted in 5.) requiring all non-static functions > to have a .h file declaration is good policy for any application > including Wine. Hint, if a function isn't static somebody else > should use it otherwise some else is wrong, ie it really should > be static after all. All 16-bit API functions must be treated as if they were static. They cannot be because of the spec file reference, but ideally no code should ever call a 16-bit API, it should use the corresponding 32-bit API. Adding prototypes and a header file is only going to encourage using these functions which is not what we want. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: more misc fixes
by Patrik Stridvall July 19, 2001

July 19, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Index: wine/include/wine/obj_base.h > > =================================================================== > > RCS file: /home/wine/wine/include/wine/obj_base.h,v > > retrieving revision 1.40 > > diff -u -u -r1.40 obj_base.h > > --- wine/include/wine/obj_base.h 2001/05/07 18:15:40 1.40 > > +++ wine/include/wine/obj_base.h 2001/07/19 14:50:28 > > @@ -34,6 +34,8 @@ > > #include "wtypes.h" > > #include "guiddef.h" > > > > +#include "wine/windef16.h" > > This is wrong; Win32 header files must not include 16-bit ones. Ah. You are right, I orginally meant to add it in a different file (wine/obj_base16.h perhaps) but I didn't think it would matter since other 16 bit interface like IStream16 and IStorage16 is in wine/obj_*.h already. Perhaps they should be move out as well? If so to where? wine/obj_*16.h or perhaps the DLLs directories if possible? > Also please avoid adding more 16-bit headers in include/wine, there > are already too many of them. Well that was the idea at first but at least of the new ones are was needed in more that one directory some I ended up adding all of them there. But sure I can move the ones that are not use in more of one directory to that directory, I'm just a little worried that since the wine/*16.h header are 16-bit "mirrors" of the corresponding 32-bit files that functions from other DLLs happends to end up there as well. Microsoft seems have mixed headers and DLLs without much thought especially as far as OLE is concerned. Sure we can have several .h files with the same name in different DLL directories as far as functions are concerned since 16-bit functions shouldn't call across different DLLs anyway, but duplicating types and such are not a very good idea. But sure I can examine the files more carefully and see if it is possible and of course we can add it to a DLL directory first and then move it to include/wine if is because nessary in the future. > These headers (when they are really > necessary) belong in their respective dll directory. And BTW your new > lzexpand16.h is an example of a header file that is *not* necessary. Nessary for compiling Wine no, clearly not since it already compiles. However IMO all exported functions whether they are 16-bit or 32-bit and whether they are actually uses by other files or not should have declarations in some header file. For 32-bit it must obviously be so because of Winelib. The undocumented functions is of course not strictly nessary but I see not reason not to have them as a Wine extension that can be ported to Windows eventually in order to have the same source on both Unix and Windows. For 16-bit is seems that you disagree. Well, the advantages that I can think of for doing it for 16-bit as well is the following. 1. It makes it much easier for developer to add calls across files between 16-bit functions or move functions between files if the infrastructure is alreay in place. 2. It makes it possible to see related 16-bit functions together in a .h file instead of having to search the .c files. 3. It makes it possible go through each 16-bit .h file compare it with Windows and add the missing functions in the .h files and when somebody in the future runs winapi_check (or whatever) it is possible to present a list of what is not yet implemented. Sure the .spec contains that information as well in some meaning but it misses which functions that are actually listed in the 16-bit header files and thus likely to actually be used by real applications. 4. Since some of the 16-bit exported functions must be declared in some .h since it is used in some of file than it was declared, it is be much easier to require all 16-bit export function to be declared since it is difficult to tell which that are (or will be) really needed. 5. There is nothing unreasonable to require every non-static function let alone functions that are exported by either Win16 or Win32 to have a declaration in some .h files. Indeed tools like lint (at least on Solaris) have flags to check for this. In short trying to only add the 16-bit functions that are stricly nessary to .h files is more trouble than it is worth, especially compare to the advantages that having all of them .h files. In addition (as I hinted in 5.) requiring all non-static functions to have a .h file declaration is good policy for any application including Wine. Hint, if a function isn't static somebody else should use it otherwise some else is wrong, ie it really should be static after all. But OK. You think that there are too many 16-bit files in include/wine. No problem. I will try to avoid it if at all possible.

1 0

Re: more misc fixes
by Alexandre Julliard July 19, 2001

July 19, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > Index: wine/include/wine/obj_base.h > =================================================================== > RCS file: /home/wine/wine/include/wine/obj_base.h,v > retrieving revision 1.40 > diff -u -u -r1.40 obj_base.h > --- wine/include/wine/obj_base.h 2001/05/07 18:15:40 1.40 > +++ wine/include/wine/obj_base.h 2001/07/19 14:50:28 > @@ -34,6 +34,8 @@ > #include "wtypes.h" > #include "guiddef.h" > > +#include "wine/windef16.h" This is wrong; Win32 header files must not include 16-bit ones. Also please avoid adding more 16-bit headers in include/wine, there are already too many of them. These headers (when they are really necessary) belong in their respective dll directory. And BTW your new lzexpand16.h is an example of a header file that is *not* necessary. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: Lots of #defines OK?
by Patrik Stridvall July 19, 2001

July 19, 2001

> I would like to get rid of the "hardcoded" offset into the glyph name > array and replace it with a macro ('GN_exclam', for example). > Each font > data file could then simply include a header that gets > regenerated when- > ever the glyphlist is changed -- eliminating the current > requirement to > regenerate all the font data. > > Anyone see any problems with this? (There are currently 1258 built-in > glyph names.) Not really, but as an alternative solution you could has a structure instead of an array like: typedef struct { GLYPHNAME A; GLYPHNAME AE; GLYPHNAME AEacute; GLYPHNAME AEsmall; /* ... */ } GLYPHNAMES; Perhaps this is better since it doesn't use the preprocessor. However I'm not sure if all C compilers supports 1258 structure members. Another possible problem is alignment on some platforms if you must be able for iterate over it and use it as and array. Of course you can simply have a seperate array of pointers like: GLYPHNAMES glyphnames = { /* ... */ }; GLYPHNAME *pGlyphnames[] = { &glyphnames.A; &glyphnames.AE; &glyphnames.AEacute; &glyphnames.AEsmall; /* ... */ };

2 1

Lots of #defines OK?
by Ian Pilcher July 19, 2001

July 19, 2001

I'm giving some thought to cleaning up the data structures used by the PostScript driver. Any significant change here will require that the glyph list and font data be regenerated. This is not particularly difficult, but it would be easier if I could remove the dependency of the font data on the glyph name array. Each glyph's metrics include a pointer to its name, and all of the built-in glyph names are in a single array named PSDRV_AGLGlyphNames (in dlls/wineps/data/agl.c). So the metrics for a glyph look like this: { 33, 0x0021, 600, PSDRV_AGLGlyphNames + 907, { 236, -15, 364, 572 }, NULL /* exclam */ } I would like to get rid of the "hardcoded" offset into the glyph name array and replace it with a macro ('GN_exclam', for example). Each font data file could then simply include a header that gets regenerated when- ever the glyphlist is changed -- eliminating the current requirement to regenerate all the font data. Anyone see any problems with this? (There are currently 1258 built-in glyph names.) Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

attempting to load mIRC32 5.91 using latest wine cvs
by mdew July 19, 2001

July 19, 2001

mdew(a)storm:~$ /usr/local/bin/wine fake_windows/mIRC/mirc32.exe FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock err:module:BUILTIN32_dlopen failed to load .so lib for builtin x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found fixme:console:SetConsoleCtrlHandler (0x546e60,1) - no error checking or testing yet FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock err:module:BUILTIN32_dlopen failed to load .so lib for builtin x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock err:module:BUILTIN32_dlopen failed to load .so lib for builtin x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! spews this message out many times (then quits)..., using the same wine config ..as always.. Using Debian Sid x86 (gcc-2.95.4-XFree86-4.0.3)

2 1

Re: glibc bug mmap/malloc
by Gerard Patel July 19, 2001

July 19, 2001

At 10:15 PM 18/07/2001 +0200, you wrote: <snip about glibc> >> > This is a BUG. While this glibc question is slightly offtopic here, I think that maybe a few people on this list could be interested in glibc, since the subject comes back on a regular basis... the following web page : http://sources.redhat.com/glibc is definitely the place to go. I feel that maybe this information could help someone, since I have wasted more than one hour searching www.gnu.org for the glibc mailing list archive :-) Also http://www.suse.de/~aj/Projects.html#glibc where it's said that Andrea Jaeger is responsible for glibc bug reports. Reading the archive gives me the impression that the whole glibc is written by no more than half a dozen programmers, btw. What's more, I have also the impression that these few are not even contributing full time to glibc :-/ Gerard

1 0

Problem with 'GetPrivateProfileString'
by Lionel Ulmer July 18, 2001

July 18, 2001

Hi all, I have an installer crashing in 'GetPrivateProfileString' because of an NULL section pointer : 3 0x40076161 (GetPrivateProfileStringA+0x31(section=0x0, entry=0x40391efc, def_val=0x4039a394, buffer=0x403b0410, len=0x3e7, filename=0x4039a4e8) [profile.c:1232] in libntdll.so) (ebp=40586748) When looking at the code, there is the following comment (and code) : /* * undoc_feature means: * return section names string list if both section and entry are NULL. */ (...) if ((undoc_feature) && (section == NULL) && (entry == NULL)) /* undocumented; both section and entry are NULL */ But if I look at the entry for 'GetPrivateProfileString' in the MSDN, I get this : pAppName [in] Pointer to a null-terminated string that specifies the name of the section containing the key name. If this parameter is NULL, the GetPrivateProfileString function copies all section names in the file to the supplied buffer. lpKeyName [in] Pointer to the null-terminated string specifying the name of the key whose associated string is to be retrieved. If this parameter is NULL, all key names in the section specified by the lpAppName parameter are copied to the buffer specified by the lpReturnedString parameter. This is not in sync. with what Wine does.... It seems that only pAppName needs to be NULL to return a section name list. And there is another behaviour not done by Wine yet : copy all the keys of a section to the output buffer. So who is the author of this 'undocumented' feature in the Wine code ? Do you all agree that I should code it according to the (now) documented feature ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Re: glibc bug mmap/malloc
by Alexandre Julliard July 18, 2001

July 18, 2001

Andreas Mohr <a.mohr(a)mailto.de> writes: > You can clearly see that malloc() is able to squeeze up to 10232 bytes > into the memory range just before the mmap()ed area, but when it gets > slightly larger, it is NOT capable of switching to an entirely different > memory area, throws its arms up in desperation and simply returns a shabby > NULL. > It only uses a new memory area in case the values get *much* larger, > i.e. at least 131060 bytes. > > This is a BUG. > (IMHO) > What else should it be ? This is more a limitation of the malloc implementation than an actual bug. malloc uses brk() to allocate memory, but brk() cannot grow past an mmapped area, so malloc fails. With a standard Linux app shared libraries are mapped high in memory (usually from 0x40000000) so the malloc limit is about 1Gb; but if stuff is mapped lower, malloc capacity is reduced. The reason it works for mallocs larger than 128Kb is that glibc uses anonymous mmaps to reserve space for these instead of brk(). All in all, it's probably one more good reason for avoiding malloc in Wine. -- Alexandre Julliard julliard(a)winehq.com

2 1

Reaktivate
by Daniel Walker July 18, 2001

July 18, 2001

Are the reaktivate patches going to be put in the CVS eventually? Daniel Walker

3 5

Re: use GetCommState16 to save state in OpenComm16
by lawson_whitney＠juno.com July 18, 2001

July 18, 2001

On Wed, 18 Jul 2001, Mike McCormack wrote: > > with this patch, all use of unix fds has been eliminated from the > 16bit comm code. Next step is to remove use of the service thread... > > ChangeLog: > use GetCommState16 to save state in OpenComm16 > merge comm16 globals into one structure gcc -shared -Wl,-soname,libkernel32.so kernel32.spec.o comm.spec.o kernel.spec.o stress.spec.o system.spec.o toolhelp.spec.o windebug.spec.o win87em.spec.o wprocs.spec.o comm.o debugger.o format_msg.o kernel_main.o stress.o string.o sync.o thunk.o time.o toolhelp.o utthunk.o win87em.o windebug.o wowthunk.o utthunk.glue.o -o libkernel32.so -L../../dlls -lntdll -L../../library -lwine -lm -lutil -ldl /usr/i386-slackware-linux/bin/ld: warning: type and size of dynamic symbol `CALL32_Regs' are not defined make[2]: Leaving directory `/oof/Wine-20010629/dlls/kernel' Is this right, or are my binutils getting long in the tooth? Seems to work OK though. Lawson ---cut here--- ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

2 1

Re: use GetCommState16 to save state in OpenComm16
by lawson_whitney＠juno.com July 18, 2001

July 18, 2001

On Wed, 18 Jul 2001 12:08:51 +1000 Mike McCormack <mike_mccormack(a)start.com.au> writes: > This is a multi-part message in MIME format > > ------=_NextPart_000_33334807 > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > > > with this patch, all use of unix fds has been eliminated from the > 16bit comm code. Next step is to remove use of the service thread... > > ChangeLog: > use GetCommState16 to save state in OpenComm16 > merge comm16 globals into one structure Okay, if you get this, it does no harm to my 16 bit comms app. Does throw a little ld warning though. Well, let's see. Lawson ---cut here--- ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Re: How to unsubscribe
by Antonio Augusto Todo Bom Neto July 18, 2001

July 18, 2001

Begin forwarded message: Date: Wed, 18 Jul 2001 08:31:30 -0300 From: Antonio Augusto Todo Bom Neto <antonio(a)xultz.wox.org> To: wine-devel(a)winehq.com Subject: Re: How to unsubscribe On Wed, 18 Jul 2001 07:48:03 -0300 (ADT) tlegge(a)fundy.net wrote: > Hi > > How do I unsubscribe from this list? > > Regards > > Tim > > try it: http://www.winehq.com/mailman/options/wine-devel/tlegge%40fundy.net ;)

1 0

How to unsubscribe
by tlegge＠fundy.net July 18, 2001

July 18, 2001

Hi How do I unsubscribe from this list? Regards Tim

1 0

Announcement : SynCE project
by Ludovic LANGE July 18, 2001

July 18, 2001

Hello, First of all sorry for the intrusion, but I think this may be of interest for some of you. SynCE project's ambitious goal is to provide a mean of synchronising handhelds devices with a (desktop) computer. By handheld, we mean any portable / embedded / PDA.... device, that needs to synchronize its data with a less mobile computer. (An exemple would be any PDA/PocketPC running Windows CE, or any PDA running Linux, etc...) The first step of this project is to provide a full (client & server) implementation of Microsoft's RAPI protocol, which is the low-level protocol used in ActiveSync synchronisation. This will allow, when completed : - a Windows CE device to communicate with any (non-Microsoft) computer, - A Linux device to communicate with a Microsoft computer and benefits from the existing tools, - etc, etc... The second step will be to provide a set of tools to synchronize data with 'standard' open or closed source application : Mozilla, KMail, etc.... Right now, the project is in its early, early stages ( we don't even have an alpha release ! ), but yet there are some bits that allow an implementation of the client part of the RAPI protocol, to query informations (registry, filesystem, databases,...) from a WindowsCE device. One tool (DBBackup) allows a full dump of the databases of the device. I won't interfere more with the list, and I invite all people interested to have a look on the project page ( http://www.sourceforge.net/projetcs/synce & http://synce.sourceforge.net ) and to subscribe to the mailing-list. We currently are looking for developper, and for testers having mobile devices still under Windows CE (PDA, PocketPC, etc...) and an unix-like desktop environment. Best regards, Ludovic LANGE

2 1

how to add a new language wine?
by jerry.zhang July 18, 2001

July 18, 2001

hello,everyone: I want to add a new language to wine,but I found the document about this is out of date, so,I want to know how to add a new language to the latest version of wine. In additional,I want to know how to define the value of many parameters in the file "/dlls/kernel/nls/youlanguage.nls". Best regards Jerry Zhang Redflag Software Co. Ltd E-mail: wenlongzhang(a)redflag-linux.com

2 1

glibc bug mmap/malloc
by Andreas Mohr July 17, 2001

July 17, 2001

[yeah, it's glibc bug time AGAIN] Hello all, I just wanted to let you all know that I found what I believe to be a glibc malloc bug. (yes, this happens even with 2.4.6 and latest Debian glibc 2.2.3-6). This is the only thing I did today, BTW. When Wine loads a very large (129 MB) exe file, it does an mmap() on it. After that it tries to do some malloc()s. That fails, which causes the entirely loading/execution of that file to abort. Thus I did malloc()/free() in a for loop after that 129 MB mmap() to test the problematic behaviour. Output: trace:module:map_image mapped PE file at 0x8051000-0xfc45000 err:virtual:VIRTUAL_CreateView now that the PE file has been mmap() /dev/zero:ed, we do some other malloc()s: malloc of 4 bytes: 0x804d878 malloc of 8 bytes: 0x804d878 malloc of 12 bytes: 0x804d878 malloc of 16 bytes: 0x804d878 malloc of 20 bytes: 0x804db20 <---- (chunk size optimization algorithm) malloc of 24 bytes: 0x804db20 <---- ("") malloc of 28 bytes: 0x804e7f8 <---- ("") malloc of 32 bytes: 0x804e7f8 malloc of 36 bytes: 0x804e7f8 . . . malloc of 10224 bytes: 0x804e7f8 malloc of 10228 bytes: 0x804e7f8 malloc of 10232 bytes: 0x804e7f8 up to 0x8050fef malloc of 10236 bytes: (nil) (0x8050ff3, which probably touches mmap() management headers) malloc of 10240 bytes: (nil) . . . malloc of 131052 bytes: (nil) malloc of 131056 (0x1fff0) bytes: (nil) ... malloc of 131060 bytes: 0x404c2008 malloc of 131064 bytes: 0x404c2008 . . . You can clearly see that malloc() is able to squeeze up to 10232 bytes into the memory range just before the mmap()ed area, but when it gets slightly larger, it is NOT capable of switching to an entirely different memory area, throws its arms up in desperation and simply returns a shabby NULL. It only uses a new memory area in case the values get *much* larger, i.e. at least 131060 bytes. This is a BUG. (IMHO) What else should it be ? I already contacted Ulrich Drepper about it, and I'll hopefully get a positive reply soon. -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Microsoft Windows: Made for the Internet The Internet: Made for Unix

1 0

Re: Significant change to WINEPS - please test!
by Gerard Patel July 17, 2001

July 17, 2001

At 07:29 PM 15/07/2001 -0500, you wrote: >So please give me your feedback. I particularly want to know if it >breaks anything before I submit it. Anything ? everything is a better word. I use a 'latin' language. No unicode for me. I test with the software I use to send this mail. There is a 'preview' feature and I can preview (and print) a mail. This is working fine with current Cvs. If I use your patch, most characters in the mail body, are overlayed, printed scattered in black heaps with small lines all around , strangely evoking some insects. Pretty funny :-) If my description is not clear, I can send you a screen capture. Strangely the page header and footer are still correct, though. Gerard

2 1

Re: Small OpenGL fix
by Alexandre Julliard July 17, 2001

July 17, 2001

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > In the current code, there seems to be two different mechanisms for driver > calling : > > - one that is 'GDI' specific with the 'dc->funcs->pFUNC_NAME' sort of calls > > - the other for 'USER' with 'USER_Driver.pFUNC_NAME' > > So which one of the two methods should I use the 'WGL' that is neither in > GDI nor in USER ? You can't really use either. The GDI one requires calling DC_GetDCPtr which you cannot do from outside GDI, and the USER one requires a reference to a global variable that isn't visible outside USER. A possible way is to use the Escape function and add a few x11drv-specific escape codes. But first it would probably be a good thing to check how opengl32 is implemented under Windows; I have no idea how it works, but it probably needs some way to communicate with the graphics driver, and we could use the same mechanism. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Small OpenGL fix
by Alexandre Julliard July 17, 2001

July 17, 2001

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > This is more a problem of inter-dependencies of X11DRV and USER32 (as the > former should NEVER be loaded before the latter)... But as I could not fix > this problem, I prefered going 'around' the problem :-) The dependencies between x11drv and user should certainly be fixed, but the real problem is that opengl32 and ddraw import x11drv at all. x11drv is an internal driver and should never be imported by any dll. Anybody feeling like fixing that? -- Alexandre Julliard julliard(a)winehq.com

2 1

using cvs diff
by Bill Medland July 17, 2001

July 17, 2001

I can't see it in TFM I thought I was keeping an eye on what patches had actually been applied to the wine source (especially to see if mine had) by using "cvs diff wine". It seemed to be working but I now realise it wasn't. I guess it was diffing my local code against the corresponding revisions. How do I diff my current set of code against the current cvs? Bill

3 2

ChangeDisplaySettings
by Travis Michielsen July 17, 2001

July 17, 2001

Hi, I was planning on implementing ChangeDisplaySettingsA soon but I'm not certain on how to do it. I have been browsing the source tree and was following the methods used by DirectDraw and was considering a similar approach. While I was browsing the source, I was eventually lead to dlls/x11drv/xvidmode.c which contains most of the functions that I will probably need. But I still have a few concerns: 1) Is the x11drv used for ddraw AND the gdi or just one? 2) what is the best way to query if the video exists? without knowing syncs? 3) and if i need to know syncs how do I find them? Another question I have is about pixel depth. From what I understand, it is imposible to change the pixel format of the screen while X is running. However, it is possible to start more than one X server with different configs (and depth) which we could use if we have to but probably not a good idea. Of course another posibility is to emulate the pixel depth, but that would probably cause performance problems, especially when used by games. Anyone have any suggestions or should we just leave changing depths as unimplemented? Thanks! - Travis Michielsen __________________________________________________ Do You Yahoo!? Get personalized email addresses from Yahoo! Mail http://personal.mail.yahoo.com/

2 1

DrawText
by Travis Michielsen July 17, 2001

July 17, 2001

Hi all, I have put together a quick patch that SHOULD fully implement the DrawText functions. However, I have not had time to thoroughly tested most of the logic so I thought I would post it here rather than sending it directly to the patches list. I welcome any/all comments/suggestions. - Travis Michielsen Index: wine/dlls/user/text.c =================================================================== RCS file: /home/wine/wine/dlls/user/text.c,v retrieving revision 1.12 diff -u -r1.12 text.c --- wine/dlls/user/text.c 2001/07/17 00:51:00 1.12 +++ wine/dlls/user/text.c 2001/07/17 13:55:22 @@ -235,6 +235,7 @@ int prefix_x = 0; int prefix_end = 0; TEXTMETRICW tm; + int lmargin = 0, rmargin = 0; int x = rect->left, y = rect->top; int width = rect->right - rect->left; int max_width = 0; @@ -242,10 +243,8 @@ TRACE("%s, %d , [(%d,%d),(%d,%d)]\n", debugstr_wn (str, count), count, rect->left, rect->top, rect->right, rect->bottom); - if(dtp) { - FIXME("Ignores params:%d,%d,%d,%d\n", dtp->cbSize, - dtp->iTabLength, dtp->iLeftMargin, dtp->iRightMargin); - } + if (dtp) TRACE("Params: iTabLength=%d, iLeftMargin=%d, iRightMargin=%d\n", + dtp->iTabLength, dtp->iLeftMargin, dtp->iRightMargin); if (!str) return 0; if (count == -1) count = strlenW(str); @@ -258,8 +257,17 @@ else lh = tm.tmHeight; + if (dtp) + { + lmargin = dtp->iLeftMargin * tm.tmAveCharWidth; + rmargin = dtp->iRightMargin * tm.tmAveCharWidth; + if (!(flags & (DT_CENTER | DT_RIGHT))) + x += lmargin; + dtp->uiLengthDrawn = 0; //This param RECEIVES number of chars processed + } + if (flags & DT_TABSTOP) - tabstop = flags >> 8; + tabstop = dtp ? dtp->iTabLength : flags >> 8; if (flags & DT_EXPANDTABS) { @@ -292,7 +300,7 @@ if (flags & DT_SINGLELINE) { - if (flags & DT_VCENTER) y = rect->top + + if (flags & DT_VCENTER) y = rect->top + (rect->bottom - rect->top) / 2 - size.cy / 2; else if (flags & DT_BOTTOM) y = rect->bottom - size.cy; @@ -312,7 +320,7 @@ if (flags & DT_WORD_ELLIPSIS) flags |= DT_WORDBREAK; - if (flags & DT_PATH_ELLIPSIS) + if (flags & DT_PATH_ELLIPSIS) { WCHAR* lastBkSlash = NULL; WCHAR* lastFwdSlash = NULL; @@ -320,14 +328,11 @@ line[totalLen] = '\0'; lastBkSlash = strrchrW(line, BACK_SLASHW[0]); lastFwdSlash = strrchrW(line, FORWARD_SLASHW[0]); - fnameDelim = lastFwdSlash ? lastFwdSlash : lastBkSlash; - if (lastBkSlash && lastFwdSlash) /* which is last? */ - if (lastBkSlash > lastFwdSlash) - fnameDelim = lastBkSlash; + fnameDelim = lastBkSlash > lastFwdSlash ? lastBkSlash : lastFwdSlash; if (fnameDelim) fnameLen = &line[totalLen] - fnameDelim; - else + else fnameDelim = (WCHAR*)str; strcpyW(swapStr, ELLIPSISW); @@ -343,16 +348,16 @@ } len = MAX_STATIC_BUFFER; - TEXT_NextLineW(hdc, swapStr, &count, line, &len, width, flags); + TEXT_NextLineW(hdc, swapStr, &count, line, &len, width, flags); /* if only the ELLIPSIS will fit, just let it be clipped */ len = max(3, len); GetTextExtentPointW(hdc, line, len, &size); /* FIXME: - * NextLine uses GetTextExtentPoint for each character, + * NextLine uses GetTextExtentPoint for each character, * rather than GetCharABCWidth... So the whitespace between - * characters is ignored in the width measurement, and the + * characters is ignored in the width measurement, and the * reported len is too great. To compensate, we must get * the width of the entire line and adjust len accordingly. */ @@ -365,10 +370,10 @@ if (fnameLen < len-3) /* some of the path will fit */ { /* put the ELLIPSIS between the path and filename */ - strncpyW(swapStr, &line[fnameLen+3], len-3-fnameLen); + strncpyW(swapStr, &line[fnameLen+3], len-3-fnameLen); swapStr[len-3-fnameLen] = '\0'; - strcatW(swapStr, ELLIPSISW); - strncpyW(swapStr+strlenW(swapStr), &line[3], fnameLen); + strcatW(swapStr, ELLIPSISW); + strncpyW(swapStr+strlenW(swapStr), &line[3], fnameLen); } else { @@ -382,12 +387,15 @@ line[len] = '\0'; strPtr = NULL; } + if (flags & DT_MODIFYSTRING) + strcpyW(str, swapStr); } } if (!(flags & DT_CALCRECT)) { - if (!ExtTextOutW(hdc, x, y, (flags & DT_NOCLIP) ? 0 : ETO_CLIPPED, - rect, line, len, NULL )) return 0; + if (!ExtTextOutW( hdc, x, y, + ( (flags & DT_NOCLIP) ? 0 : ETO_CLIPPED ) | ( (flags & DT_RTLREADING) ? 0 : ETO_RTLREADING ), + rect, line, len, NULL )) return 0; if (prefix_offset != -1) { HPEN hpen = CreatePen( PS_SOLID, 1, GetTextColor(hdc) ); @@ -410,20 +418,35 @@ break; } } + if (dtp) + dtp->uiLengthDrawn += len; } while (strPtr); + if (flags & DT_CALCRECT) { rect->right = rect->left + max_width; rect->bottom = y; + if (dtp) + rect->right += lmargin + rmargin; } return y - rect->top; } /*********************************************************************** - * DrawTextA (USER32.@) + * DrawTextW (USER32.@) */ -INT WINAPI DrawTextA( HDC hdc, LPCSTR str, INT count, LPRECT rect, UINT flags ) +INT WINAPI DrawTextW( HDC hdc, LPCWSTR str, INT count, + LPRECT rect, UINT flags ) +{ + return DrawTextExW(hdc, str, count, rect, flags, NULL); +} + +/*********************************************************************** + * DrawTextExA (USER32.@) + */ +INT WINAPI DrawTextExA( HDC hdc, LPCSTR str, INT count, + LPRECT rect, UINT flags, LPDRAWTEXTPARAMS dtp ) { WCHAR *wstr; INT ret = 0; @@ -437,32 +460,19 @@ { MultiByteToWideChar( CP_ACP, 0, str, count, wstr, wcount ); ret = DrawTextExW( hdc, wstr, wcount, rect, flags, NULL ); + if (flags & DT_MODIFYSTRING) + WideCharToMultiByte( CP_ACP, 0, wstr, -1, str, count, NULL, NULL ); HeapFree(GetProcessHeap(), 0, wstr); } return ret; } /*********************************************************************** - * DrawTextW (USER32.@) - */ -INT WINAPI DrawTextW( HDC hdc, LPCWSTR str, INT count, - LPRECT rect, UINT flags ) -{ - return DrawTextExW(hdc, str, count, rect, flags, NULL); -} - -/*********************************************************************** - * DrawTextExA (USER32.@) + * DrawTextA (USER32.@) */ -INT WINAPI DrawTextExA( HDC hdc, LPCSTR str, INT count, - LPRECT rect, UINT flags, LPDRAWTEXTPARAMS dtp ) +INT WINAPI DrawTextA( HDC hdc, LPCSTR str, INT count, LPRECT rect, UINT flags ) { - TRACE("(%d,%s,%d,%p,0x%08x,%p)\n",hdc,debugstr_an(str,count),count,rect,flags,dtp); - if(dtp) { - FIXME("Ignores params:%d,%d,%d,%d\n",dtp->cbSize, - dtp->iTabLength,dtp->iLeftMargin,dtp->iRightMargin); - } - return DrawTextA(hdc,str,count,rect,flags); + return DrawTextExA( hdc, str, count, rect, flags, NULL ); } /*********************************************************************** __________________________________________________ Do You Yahoo!? Get personalized email addresses from Yahoo! Mail http://personal.mail.yahoo.com/

1 0

Re: another debugstr patch
by Alexandre Julliard July 17, 2001

July 17, 2001

Andreas Mohr <a.mohr(a)mailto.de> writes: > BTW, Alexandre, why didn't you apply my "debugstr patch" from Jun 04 ? It got lost somewhere; I've applied it now. BTW for everybody, when you submitted a patch and didn't see it applied and didn't hear anything about it, *please* resubmit or ask me what's going on. Patches can get dropped for multiple reasons, and it's your responsibility to follow what happens to your patch, until it is either applied or you know why it wasn't. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Mouse trouble
by Alexandre Julliard July 17, 2001

July 17, 2001

Ove Kaaven <ovehk(a)ping.uio.no> writes: > I did consider that, but who's going to intercept and handle that message? > It's not an operation that is or should be known outside of the x11drv, so > sending the window a custom message will either conflict with some other > message, or get the message ignored (I doubt DefWindowProc passes custom > messages back to x11drv or anything). Or did you have any particular ideas > in this area? You can set a new window procedure to intercept the message, and pass all other messages straight through to the original window procedure. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Mouse trouble
by Alexandre Julliard July 17, 2001

July 17, 2001

Ove Kaaven <ovehk(a)ping.uio.no> writes: > Known bug in the current CVS. Turn dxgrab off. If it's on, mouse events > are lost. I'm working on it, but have not yet thought of a way to fix it; > I need to run a procedure (GrabPointer) in the context of the thread that > owns the window that gets the grab. My latest idea was to queue an APC to > the owner of the window, but QueueUserAPC requires a thread handle, while > GetWindowThreadProcessId only returns a thread ID. I'd strongly suggest using some kind of SendMessage instead of QueueUserAPC. -- Alexandre Julliard julliard(a)winehq.com

2 1

fnt2bdf.c and font names
by Bill Medland July 16, 2001

July 16, 2001

I've just been playing with fonts (sserife and vgasys) to get things working. In the process I notice that fnt2bdf seems to do some strange stuff about choosing a font name, pixel size etc. I don't want to submit a patch that merely demonstrates my stupidity/lack of understanding but am willing to put in my suggested fix. This will result in for example the MS Sans Serif 8 pt font getting a name of -windows-MS Sans Serif-medium-r-normal-sans-13-80-96-96-p-50-microsoft-cp1252 SIZE 8 96 96 as opposed to the current -windows-MS Sans Serif-medium-r-normal-sans-13-130-72-72-p-50-microsoft-cp1252 SIZE 13 96 96 (I don't understand why the 72 dpi is hard-coded) Do I submit it or am I misunderstanding something Bill

1 0

Re: Added sanity check to WINPROC_CallWndProc
by Uwe Bonnes July 16, 2001

July 16, 2001

>>>>> "Jukka" == Jukka Heinonen <jhei(a)iki.fi> writes: Jukka> DeusEx causes Wine to crash (segmentation fault) because it calls Jukka> CallWindowProc and passes null in HWND parameter. While I Jukka> suspect that this is because some Wine function that should Jukka> return a valid HWND is returning a null pointer, the crashing can Jukka> be fixed simply by adding a sanity check to WINPROC_CallWndProc. How does Windows behave on those invalid arguments? Jukka> After this patch, both DeusEx installer and DeusEx dialog for Jukka> choosing rendering engine work. However, DeusEx still crashes Jukka> later because DeusEx for some reason generates a division by zero Jukka> FP exception. DeusEx handler for this exception calls Jukka> __CxxFrameHandler which is not implemented by Wine and thus Jukka> exception handling ends into infinite recursion. Luckily stack Jukka> overflow makes Wine to crash :) Native msvcrt has __CxxFrameHandler, but I aggree that wine-msvcrt needs exception facilities too. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Mouse trouble
by Daniel Bingham July 16, 2001

July 16, 2001

Hi, I just got the latest CVS and when I tried to run starcraft my mouse won't move. I have dxgrab turned on so as not to have my mouse going off the screen when I try to move. I am not very knowledgeable about wine or programming, so I thought I'd tell someone who was. If I have something set up wrong I can't find it and don't find any documentation to address it either. Any help would be much appreciated. Please email me directly because I get the digest and tend to ignore it. Thanks. Daniel Bingham db78(a)att.net

3 2

Re: Added sanity check to WINPROC_CallWndProc
by Jon Griffiths July 16, 2001

July 16, 2001

Hi, >Native msvcrt has __CxxFrameHandler, but I aggree that wine-msvcrt needs >exception facilities too. While I'm still on holiday, i just bought a laptop to do some wine coding on. I had improved the exception handling in builtin msvcrt but my last run of patches to it werent accepted due to using asm instead of register funcs. Once I get my old sources mailed to me I will begin hacking on it again. I'm interested in getting the konqueror/ActiveX stuff working with builtin msvcrt, since the dot.kde.org press release singled it out as non-functional (much to my shame <g>). Meanwhile I'm strolling through shlwapi and should have some patches for that soon. Its great to see the progress made since february though, very impressive. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do You Yahoo!? Get personalized email addresses from Yahoo! Mail http://personal.mail.yahoo.com/

1 0

Significant change to WINEPS - please test!
by Ian Pilcher July 16, 2001

July 16, 2001

The attached patch makes a fundamental change to the way the PostScript driver deals with character encodings -- it ignores them. Instead, the driver now operates directly on 16-bit Unicode characters. This should be a more robust strategy for handling non-Latin, and especially multi-byte, character sets. I really have no idea, however, how the rest of Wine handles non-Latin characters. As an English speaker, I'm not well equipped to test it. So please give me your feedback. I particularly want to know if it breaks anything before I submit it. Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ======================================================================== diff -urN ../wine-20010714cvs/dlls/wineps/font.c ./dlls/wineps/font.c --- ../wine-20010714cvs/dlls/wineps/font.c Sun Jul 15 16:07:36 2001 +++ ./dlls/wineps/font.c Sun Jul 15 16:27:27 2001 @@ -5,6 +5,7 @@ * */ #include <string.h> +#include <stdlib.h> /* for bsearch() */ #include "winspool.h" #include "psdrv.h" #include "debugtools.h" @@ -294,6 +295,7 @@ return TRUE; } +#if 0 /*********************************************************************** * PSDRV_UnicodeToANSI */ @@ -321,9 +323,52 @@ return 0xff; } } +#endif + +/****************************************************************************** + * PSDRV_UVMetrics + * + * Find the AFMMETRICS for a given UV. Returns first glyph in the font + * (space?) if the font does not have a glyph for the given UV. + */ +static int MetricsByUV(const void *a, const void *b) +{ + return (int)(((const AFMMETRICS *)a)->UV - ((const AFMMETRICS *)b)->UV); +} + +const AFMMETRICS *PSDRV_UVMetrics(LONG UV, const PSDRV_PDEVICE *physDev) +{ + AFMMETRICS key; + const AFMMETRICS *needle; + + /* + * Ugly work-around for symbol fonts. Wine is sending characters which + * belong in the Unicode private use range (U+F020 - U+F0FF) as ASCII + * characters (U+0020 - U+00FF). + */ + + if ((physDev->font.afm->Metrics->UV & 0xff00) == 0xf000 && UV < 0x100) + UV |= 0xf000; + + key.UV = UV; + + needle = bsearch(&key, physDev->font.afm->Metrics, + physDev->font.afm->NumofMetrics, sizeof(AFMMETRICS), + MetricsByUV); + + if (needle == NULL) + { + WARN("No glyph for U+%.4lX in %s\n", UV, physDev->font.afm->FontName); + needle = physDev->font.afm->Metrics; + } + + return needle; +} + /*********************************************************************** * PSDRV_GetTextExtentPoint */ +#if 0 BOOL PSDRV_GetTextExtentPoint( DC *dc, LPCWSTR str, INT count, LPSIZE size ) { @@ -346,11 +391,30 @@ return TRUE; } +#endif +BOOL PSDRV_GetTextExtentPoint(DC *dc, LPCWSTR str, INT count, LPSIZE size) +{ + PSDRV_PDEVICE *physDev = (PSDRV_PDEVICE *)dc->physDev; + int i; + float width = 0.0; + + for (i = 0; i < count && str[i] != '\0'; ++i) + width += PSDRV_UVMetrics(str[i], physDev)->WX; + + width *= physDev->font.scale; + + size->cx = GDI_ROUND((FLOAT)width * dc->xformVport2World.eM11); + size->cy = GDI_ROUND((FLOAT)physDev->font.tm.tmHeight * + dc->xformVport2World.eM22); + + return TRUE; +} /*********************************************************************** * PSDRV_GetCharWidth */ +#if 0 BOOL PSDRV_GetCharWidth( DC *dc, UINT firstChar, UINT lastChar, LPINT buffer ) { @@ -365,7 +429,24 @@ return TRUE; } +#endif +BOOL PSDRV_GetCharWidth(DC *dc, UINT firstChar, UINT lastChar, LPINT buffer) +{ + PSDRV_PDEVICE *physDev = (PSDRV_PDEVICE *)dc->physDev; + UINT i; + + if (lastChar > 0xffff || firstChar > lastChar) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + + for (i = firstChar; i < lastChar; ++i) + *buffer++ = PSDRV_UVMetrics(i, physDev)->WX * physDev->font.scale; + + return TRUE; +} /*********************************************************************** * PSDRV_SetFont diff -urN ../wine-20010714cvs/dlls/wineps/ps.c ./dlls/wineps/ps.c --- ../wine-20010714cvs/dlls/wineps/ps.c Sun Jul 15 16:07:36 2001 +++ ./dlls/wineps/ps.c Sun Jul 15 16:25:12 2001 @@ -115,6 +115,9 @@ static char psshow[] = /* string */ "(%s) show\n"; +static const char psglyphshow[] = /* glyph name */ +"/%s glyphshow\n"; + static char pssetfont[] = /* fontname, xscale, yscale, ascent, escapement */ "/%s findfont\n" "[%d 0 0 %d 0 0]\n" @@ -634,6 +637,7 @@ return TRUE; } +#if 0 BOOL PSDRV_WriteShow(DC *dc, LPCWSTR str, INT count) { char *buf, *buf1; @@ -671,6 +675,32 @@ return TRUE; } +#endif + +BOOL PSDRV_WriteShow(DC *dc, LPCWSTR str, INT count) +{ + char buf[128]; + int i; + + for (i = 0; i < count; ++i) + { + LPCSTR name; + int l; + + name = PSDRV_UVMetrics(str[i], (PSDRV_PDEVICE *)dc->physDev)->N->sz; + l = snprintf(buf, sizeof(buf), psglyphshow, name); + + if (l < sizeof(psglyphshow) - 2 || l > sizeof(buf) - 1) + { + WARN("Unusable glyph name '%s' - ignoring\n", name); + continue; + } + + PSDRV_WriteSpool(dc, buf, l); + } + + return TRUE; +} BOOL PSDRV_WriteFill(DC *dc) { diff -urN ../wine-20010714cvs/dlls/wineps/psdrv.h ./dlls/wineps/psdrv.h --- ../wine-20010714cvs/dlls/wineps/psdrv.h Tue May 29 17:06:11 2001 +++ ./dlls/wineps/psdrv.h Sun Jul 15 16:11:36 2001 @@ -421,6 +421,7 @@ GLYPHNAME *PSDRV_GlyphName(LPCSTR szName); VOID PSDRV_IndexGlyphList(); BOOL PSDRV_GetTrueTypeMetrics(); +const AFMMETRICS *PSDRV_UVMetrics(LONG UV, const PSDRV_PDEVICE *physDev); #endif

1 0

RE: Documentation fixes
by Patrik Stridvall July 15, 2001

July 15, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > What kludge? Ugly OK, that is your subjective opinion, but kludge? > > Even if we only see it from a purely C language perspective, > > it solves the problem of making sure that the C library functions > > have the prototypes we expect them to have. There is no other > > way to solve that problem that I can think of so it is certainly > > not a kludge. > > Not only is it not a problem we need to solve, but it's more likely to > actually cause new problems. I wouldn't be surprised at all if your > patch broke compile on some platforms that have some slight > differences in prototypes (like char* vs. const char*). Well, believe it or not the thought actually occured to me before I submitted the patch, so I actually tested it on Solaris, FreeBSD and Linux, and the only thing I had to change was the include order or stdarg.h to make it work on all platforms. The thing is that if it actually breaks on some platform it is a red light that something might be (and probably is) wrong. We can always fix it with #ifdef:s and winapi_{check,extract,fixup} or whatever can use the #ifdef to generate a correct entry for that platform if need be. Of course the more likely scenario will be that it serves as a reminder that we really can't export the C library function directly because of platform incompabillities and simply don't do it. And no, I don't believe const/non-const is a problem. Beside even if it turn out I'm wrong we can just add a "#define const /* nothing */" at the top of each externs.c file. That, I admit, is a kludge but only a very small and harmless one. > > If you are not convinced now, you never will be. > > I think we agree on this one ;-) Probably. I don't have much hope of convincing you with the statement above either.

1 0

Re: Handling X errors using exception handlers
by Alexandre Julliard July 15, 2001

July 15, 2001

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > When discussing with Ove yesterday on #WineHQ about the handling of X > errors, he told me about an idea of his : using exceptions to handle X > errors. The main problem with that is that I don't think you can jump out of Xlib without corrupting its state. Also you'd need to properly unlock the tsx11 lock in case of exception, which will probably require an finally handler around each X call. My idea was to have the following two functions: void X11DRV_expect_error( unsigned char request, unsigned char error, XID id ); int X11DRV_check_error(void); You'd call X11DRV_expect_error before doing an X call that can fail; then if an X error happens that matches what you expect, the X error handler will simply set a flag and ignore the error (if it doesn't match you get the standard error handling). Then after the call you use X11DRV_check_error to see if your error happened or not. Would this work for what you need? -- Alexandre Julliard julliard(a)winehq.com

2 1

Wine freshman class
by Paul Gaynor July 15, 2001

July 15, 2001

Hi, I am new to the development of wine, part of the wine freshman class :) I am really interested in developing wine for use with OpenGL hopefully to push the performance of the 3-D to window$ level. I am interested in making a striped build that just handles OpenGL strictly for gaming. Any pointers that any of you can give to get me started on my journey would be wonderfully appreciated. :) How much Win$/Linux programming experience is needed with the various tasks associated with developing wine? What are the different areas (and how much programming) is required for each task of developing wine? What do you think a good place for a beginning programmer/ developer to start? I am very excited that this group exists and I am looking forward to hacking on wine :) Paul Gaynor gpk2(a)uswest.net

2 1

re: small named pipe patch
by Mike McCormack July 15, 2001

July 15, 2001

Hi Ove, funny that, i had the same problems with install shield and thought about the same solution... but i don't know enough about COM to make it work. i'll have a go at implementing WaitForNamedPipe... it'd be great to have an interprocess COM implementation :-) Mike > I'm planning to use named pipes to implement a basic interprocess COM, to > support the stupid InstallShield v6 under Wine, so it would be nice if > they could be implemented fully (would e.g. be nice if someone implemented > WaitForNamedPipe for me, and things like that). > > (Would that be a good idea?) ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

Re: Documentation fixes
by Alexandre Julliard July 15, 2001

July 15, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > What kludge? Ugly OK, that is your subjective opinion, but kludge? > Even if we only see it from a purely C language perspective, > it solves the problem of making sure that the C library functions > have the prototypes we expect them to have. There is no other > way to solve that problem that I can think of so it is certainly > not a kludge. Not only is it not a problem we need to solve, but it's more likely to actually cause new problems. I wouldn't be surprised at all if your patch broke compile on some platforms that have some slight differences in prototypes (like char* vs. const char*). > If you are not convinced now, you never will be. I think we agree on this one ;-) -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: implement SetCommState16 using SetCommState
by lawson_whitney＠juno.com July 15, 2001

July 15, 2001

On Sat, 14 Jul 2001, Mike McCormack wrote: > > quickly checked. > > ChangeLog: > Rewrite SetCommState16 to use SetCommState > Okay, if you get this, juno 1.49 finds no fault in this patch either. Lawson ---cut here--- ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Win95 version fix
by Francois Gouget July 14, 2001

July 14, 2001

Hi, Bob Goodwin proposes the following change to misc/version.c as a fix for bug #232 (http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=232) --- cut here --- Index: misc/version.c =================================================================== RCS file: /home/wine/wine/misc/version.c,v retrieving revision 1.43 diff -u -r1.43 version.c --- misc/version.c 2001/07/02 19:59:49 1.43 +++ misc/version.c 2001/07/14 20:58:49 @@ -75,7 +75,7 @@ }, /* WIN95 */ { - 0x07005F03, + 0x07000304, 0xC0000004, { sizeof(OSVERSIONINFOA), 4, 0, 0x40003B6, --- cut here --- Note that the previous value for Win95 was the same as that for Win98 which is a bit strange. Can someone check the value proposed by Bob Goodwin? Or alternately, how would I check it myself? I have access to Win95/98/2000/Me so I could also check the value for Win2000 and even add one for Wine Me. Btw, if someone needs to check values for one of the above platforms and you can provide me with a simple test program, just let me know. I can probably help you. Of course, the simpler the program is to execute, the more likely I am to be able to help you. I can also accept source (Win32) so you can develop the test program with Winelib and just send me the source, I'll recompile it on Windows. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.

1 0

RE: Documentation fixes
by Patrik Stridvall July 14, 2001

July 14, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > However I'm a little curious where the documentation, > > and yes I'm talking about real documentation not just > > the external name and the ordinal, should be placed. > > Sure you have the underlying Unix man pages at least > > if we are talking about the MSVCRT and NTDLL functions, > > but it would be nice to have a proper Windows style > > man page for them eventually. > > Given that nobody is writing documention for the Windows functions > anyway, I don't think the documentation of standard C library > functions is an issue at all. Well, lack of people writing documentation is a problem in most open source projects and Wine doesn't seem to be an exception. However, denying people the possiblity to do so for some functions doesn't help either. > > I can't fix winapi_check properly. I can kludge it yes, but fix no. > > Your proposed solution is not fixing it either, it's just moving the > kludge from winapi_check directly into the source. And that's not a > good thing IMO. What kludge? Ugly OK, that is your subjective opinion, but kludge? Even if we only see it from a purely C language perspective, it solves the problem of making sure that the C library functions have the prototypes we expect them to have. There is no other way to solve that problem that I can think of so it is certainly not a kludge. Of course you can always argue that it is a solution searching for a problem, but that is not a what I would call a kludge. Anyway, arguing about misuse of words is a waste of time and I don't think I have anything more to add that are likely to convince you. If you are not convinced now, you never will be.

1 0

Re: Documentation fixes
by Alexandre Julliard July 14, 2001

July 14, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > However I'm a little curious where the documentation, > and yes I'm talking about real documentation not just > the external name and the ordinal, should be placed. > Sure you have the underlying Unix man pages at least > if we are talking about the MSVCRT and NTDLL functions, > but it would be nice to have a proper Windows style > man page for them eventually. Given that nobody is writing documention for the Windows functions anyway, I don't think the documentation of standard C library functions is an issue at all. > I can't fix winapi_check properly. I can kludge it yes, but fix no. Your proposed solution is not fixing it either, it's just moving the kludge from winapi_check directly into the source. And that's not a good thing IMO. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: Documentation fixes
by Patrik Stridvall July 14, 2001

July 14, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > What primarily intrests me now is how should the needed > information be > > stored? The problem with normal entry point is solved, the > question is > > how the stubs and forwards should be stored? Before we know that > > we can't really write any working extraction tool can we? > > Sure we can, that's the easy part; the hard part is making it work for > the normal entry points. And I'm not going to add anything to support > stubs etc. until it's clear that we can do it for normal entry points > in a way that I consider acceptable. Fair enough. However note that I'm not suggesting that we shuld. I said "While we probably should not actually change the .c files to look like this until we have a tool of acceptable complexity that can generate the .spec files, there is quite a few preparations that need to be done before that" But OK, I will concentrate on supporting normal entry points in an acceptable way first. > > While we probably should not actually change the .c files to > > look like this until we have a tool of acceptable complexity > > that can generate the .spec files, there is quite a few preparations > > that need to be done before that and I would really like to have the > > "Exported external functions" patch applied in the meantime > > for other reasons like winapi_check likes to know where all > > the DLL:s functions are "implemented". > > Then fix winapi_check. I don't want to have to add a bunch of external > declaration for C library functions, that's very ugly. First of all ugly is subjective, I can't see what is ugly about it, but OK you decide what you want, so arguing that point is no use. However I'm a little curious where the documentation, and yes I'm talking about real documentation not just the external name and the ordinal, should be placed. Sure you have the underlying Unix man pages at least if we are talking about the MSVCRT and NTDLL functions, but it would be nice to have a proper Windows style man page for them eventually. Perhaps the some of the functions have some limitation in Windows that the Unix variant doesn't have (or vice versa) and thus if you extend the Winelib application you really want to know that, so the Unix man page will not really be enough. So yes, I'm really curious to know where you think the documentation should be placed. I think my solution is quite good since it solve three problem. 1. Provides somewhere to write the documentation 2. Provides a C compiler checkable prototype that can give a warning if any of the native system functions happends to have another prototype. 3. Helps tools like winapi_check a place to check things that the .spec files entries are correct. Even if you still considers it ugly, it might be worth it considering what you get. > So no, I'm not > going to apply your patch. I can't fix winapi_check properly. I can kludge it yes, but fix no. There is no implementation or anything else in the source that indicates that it is supposed to use functions from another DLL. But sure I can kludge winapi_check to ignore the atom functions and lstrcmpi in USER. The functions from the C Library is already kludged since a long time ago, so what the hell lets just add another kludge, it is only 5 new functions. If you don't apply it I don't have much choice have I.

1 0

Re: Documentation fixes
by Alexandre Julliard July 14, 2001

July 14, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > What primarily intrests me now is how should the needed information be > stored? The problem with normal entry point is solved, the question is > how the stubs and forwards should be stored? Before we know that > we can't really write any working extraction tool can we? Sure we can, that's the easy part; the hard part is making it work for the normal entry points. And I'm not going to add anything to support stubs etc. until it's clear that we can do it for normal entry points in a way that I consider acceptable. > While we probably should not actually change the .c files to > look like this until we have a tool of acceptable complexity > that can generate the .spec files, there is quite a few preparations > that need to be done before that and I would really like to have the > "Exported external functions" patch applied in the meantime > for other reasons like winapi_check likes to know where all > the DLL:s functions are "implemented". Then fix winapi_check. I don't want to have to add a bunch of external declaration for C library functions, that's very ugly. So no, I'm not going to apply your patch. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: hello all
by Travis Michielsen July 14, 2001

July 14, 2001

Hi all, After reading Brandon's message I was inspired to introduce myself to this list as well. Although I have been following wine for several months now, I have just recently started wine development (only 1 small patch so far :-( ). Currently I am focusing on learning the API before I persue patches that are significantly larger, but have started a todo list. I am an avid C/C++ programmer and have experimented with serveral other languages including Java(script), Pascal, Basic, etc. I have done allot of programming for Windows/DOS in the past but when I discovered linux about 2 years ago, I immediately switched OS's and began pursuing linux programming. I do, however, still run windows occasionally, when I have trouble running programs under wine, but I believe that someday (hopefully sooner rather than latter), we will be able to use linux (and wine) to run almost every program without thought. Anyways, Welcome Brandon, and Hello All. :) Travis Michielsen __________________________________________________ Do You Yahoo!? Get personalized email addresses from Yahoo! Mail http://personal.mail.yahoo.com/

1 0

[PATCH] dde unicode warning
by Gerard Patel July 14, 2001

July 14, 2001

ChangeLog: * dlls/user/dde/misc.c Fix unicode warning

1 0

[PATCH] Toolbar : image list can be changed after TB_SETIMAGELIST;
by Gerard Patel July 14, 2001

July 14, 2001

The imagelist of a toolbar can be changed by the app after it has set it to the toolbar (using TB_SETIMAGELIST). In this case the bitmap number can be wrong, leading to some apps not displaying text correctly (although the bitmaps were still showing because of Wine code not really testing for bitmap number in this case). Fix for Winzip 8.0, replaces the preceding one (same problem) ChangeLog: * dlls/comctl32/toolbar.c Refresh bitmap count to take in account imagelist changes after TB_SETIMAGELIST

1 0

RE: Documentation fixes
by Patrik Stridvall July 14, 2001

July 14, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Well, there is the issue of maintaining redundant information. > > Sure winapi_check can (and indeed was the original reason for it) > > find missmatchs. But given the number of errors I have seen people > > make that winapi_check detected, we really should avoid having > > redundant information if we can. > > If there is an easy way to avoid it, sure. But if it requires a Perl > script as complex as winapi_check, especially the maintaining of the > *.api files, I'm not sure it's a win. Well the *.api files (or at least the manual maintainance of them) will be eliminated some day. I will just have to implement parsing of the "typedefs" in the headers. However, note that I'm not suggesting that we change to automatic generation of spec files right now, but at some point in the future. What tool we should for it is a later problem. With the exception of which types maps to which "kinds" (long ptr str wstr) the tool will not nessarily be very complex and I'm not sure what the parsing of typedefs to find out will be very complex either. But I wont know until I try. What primarily intrests me now is how should the needed information be stored? The problem with normal entry point is solved, the question is how the stubs and forwards should be stored? Before we know that we can't really write any working extraction tool can we? While I'm not entirely happy with your: /* ##spec## foo "@ forward bar(ptr str) BAZ.bar" */ solution it is the better that any ideas I have. Simplicity has its charm. :-) Then we could just, taking USER as example add /* ##spec## user "name user" */ /* ##spec## user "type win16" */ /* ##spec## user "heap 65520" */ /* ##spec## user "file user.exe" */ /* ##spec## user "owner user32" */ /* ##spec## user "rsrc resources/version16.res" */ /* ##spec## user "2 stub OldExitWindows" */ /* ##spec## user "3 stub EnableOEMLayer" */ /* ##spec## user "4 stub DisableOEMLayer" */ /* ... */ in a appropriate place in say dlls/user/user_main.c. The order that winapi_extract finds the directive is not important the .spec file format happends to make it possible to always get everything in the right order anyway. However this solves the header, the debug_channels, forwards and stubs problem and could be used to solve the remaining problems with "Exported external functions" but I would rather have it solved with my patch with that name, that you didn't apply when applying the other patches. So will accept such a solution? While we probably should not actually change the .c files to look like this until we have a tool of acceptable complexity that can generate the .spec files, there is quite a few preparations that need to be done before that and I would really like to have the "Exported external functions" patch applied in the meantime for other reasons like winapi_check likes to know where all the DLL:s functions are "implemented". > And it seems to me you are > finding a lot more errors in the comments than in the spec files ;-) Well, considering that our developers have neglected the comments for many year and only changing the spec files that is not very suprising. That is the problem with having redundant information, most developers only change where it really count either out of ignorance or lack of time. > > In addition it will be much easier for the developers (especially > > newbies). If you change the prototype in the .c files or the > > ordinal in the comment above it, it will be enough. Stub files > > will be something normal developers needn't concern himself with. > > If normal developers need to change the spec file for an existing > function, something is seriously wrong. The spec entry is dictated by > the dll interface, and there is no reason to change it (except maybe > to change a 'ptr' into an 'str', but this is a cosmetic issue). Well, you also have implementing new functions. You have FooA and want to implement FooW for example. It is much easier and much more natural to be able to just cut and paste without having to change the spec files. I have seen many such errors detected by winapi_check over the years.

1 0

Handling X errors using exception handlers
by Lionel Ulmer July 14, 2001

July 14, 2001

Hi all, When discussing with Ove yesterday on #WineHQ about the handling of X errors, he told me about an idea of his : using exceptions to handle X errors. This way, when we have to explicitely handle X errors (as we will need to do for XVidmode and XDGA2 due to some (stupidly done IMHO :-) ) security fixes in XFree 4.x), we could do that using exceptions. Before doing this 'properly' (ie change the X11 drv, update the XShm error mechanism, the debugger, ...), here is what I did for now : 1) I created a new Wine-private exception type in include/wine/exception.h : /* unhandled X error */ #define EXCEPTION_WINE_X11DRV 0x80000104 2) I created a new X error handler that is installed at X11DRV initialization : static int X11DRV_XErrorHandler(Display *dpy, XErrorEvent *event) { EXCEPTION_RECORD rec; rec.ExceptionCode = EXCEPTION_WINE_X11DRV; rec.ExceptionFlags = 0; rec.ExceptionRecord = NULL; rec.ExceptionAddress = XGLErrorHandler; rec.NumberParameters = 4; rec.ExceptionInformation[0] = (DWORD)event->serial; rec.ExceptionInformation[1] = (DWORD)event->error_code; rec.ExceptionInformation[2] = (DWORD)event->request_code; rec.ExceptionInformation[3] = (DWORD)event->minor_code; RtlRaiseException(&rec); return 0; } 3) I changed the XVidMode detection code thus : /* handle only X errors */ static WINE_EXCEPTION_FILTER(xerror_handler) { switch (GetExceptionCode()) { case EXCEPTION_WINE_X11DRV: return EXCEPTION_EXECUTE_HANDLER; default: return EXCEPTION_CONTINUE_SEARCH; } } (...) void X11DRV_XF86VM_Init(void) { (...) wine_tsx11_lock(); (...) __TRY { if (!XF86VidModeQueryVersion(gdi_display, &xf86vm_major, &xf86vm_minor)) { xf86vm_major = 0; } XSync(gdi_display, False); } __EXCEPT(xerror_handler) { xf86vm_major = 0; } __ENDTRY wine_tsx11_unlock(); if (xf86vm_major == 0) { TRACE("No XVidmode\n"); return; } (...) } So what do you all think of this ? Is this something that I should add to the whole Wine tree ? The only problem with that is that it would make debugging X errors a bit more difficult as we won't have the standard X error message in debug reports from users... Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

cvs changes
by mdew July 14, 2001

July 14, 2001

i havent had any problems until i updated to the latest CVS.., what exactly changed to cause this to pop up? (Using mIRC etc) fixme:console:SetConsoleCtrlHandler (0x3000f330,0) - no error checking or testing yet

1 0

Re: GetCommState16 ....
by Mike McCormack July 14, 2001

July 14, 2001

Hey Lawson, thanks for sending Juno... i got it, but i haven't tried it yet... i thought i'd just keep patching a bit at a time until somebody complained :-) If anybody knows of any free win3.1 terminal programs, please tell me. Anyhow, this is my TODO list: * use SetCommState in SetCommState16 * save and restore m_stat using Get/SetCommState in OpenComm16 * use ReadFileEx/WriteFileEx instead of service thread * finally, move 16bit comm implementation to USER Mike > Good day! > > If you get this, neither this patch nor any of the recently committed > patches that muck with 16 bit comms bother my 16 bit comms app. > > Mike, did you not get juno.tar.gz or do you just not want to be bothered > filling in the junk to make a new account? > > Regards, > > Lawson ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

Re: PATCH: createwindow small unicode prob
by Alexandre Julliard July 14, 2001

July 14, 2001

Marcus Meissner <marcus(a)jet.franken.de> writes: > Changelog: > WM_NCCREATE has a A/W struct, so check unicode flag for which call > to use. In what case did this cause a problem? The desktop window proc is Unicode-only, and the structure doesn't contain strings anyway, so it shouldn't make a difference. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Documentation fixes
by Alexandre Julliard July 14, 2001

July 14, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > Well, there is the issue of maintaining redundant information. > Sure winapi_check can (and indeed was the original reason for it) > find missmatchs. But given the number of errors I have seen people > make that winapi_check detected, we really should avoid having > redundant information if we can. If there is an easy way to avoid it, sure. But if it requires a Perl script as complex as winapi_check, especially the maintaining of the *.api files, I'm not sure it's a win. And it seems to me you are finding a lot more errors in the comments than in the spec files ;-) > In addition it will be much easier for the developers (especially > newbies). If you change the prototype in the .c files or the > ordinal in the comment above it, it will be enough. Stub files > will be something normal developers needn't concern himself with. If normal developers need to change the spec file for an existing function, something is seriously wrong. The spec entry is dictated by the dll interface, and there is no reason to change it (except maybe to change a 'ptr' into an 'str', but this is a cosmetic issue). -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: Documentation fixes
by Patrik Stridvall July 13, 2001

July 13, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > For normal entry point, however, I respectfully disagree. > > One of the major reasons of having automatically > > generated .spec files is to avoid having to > > store redundant information. The needed information > > is already in the C function declaration and storing > > in a comment as well brings us back to the current > > situation. Sure it makes that generator less > > complicatated but it really isn't that important > > as long as it is reliable and not ambigeous. > > IMO, this is true if we can make the generator work purely on the > source code, so that you can give it the unmodified source of a > Windows dll and it spits out the spec file. If you need to add > comments before each and every exported function, then I don't see > much advantage to parsing the source. You might as well put all the > information in the comment (or leave it in the current spec file for > that matter). Well, the ordinal of each function and for that that matter which functions that should be exported must be specified somewhere. Currently winapi_extract takes this information from the comment lines looking like this in the nearest preceding comment: * Foo (BAR.@) All non-static functions with such preceding comment line(s) is considered exported using the name specified in the comment as the external name. Of course, I can take this information from anywhere, but for obvious reason I can't guess it. If the unmodified source contains Microsoft Visual C++ __declspec(dllexport) directives or the project has a Microsoft Export file (a .def file) I can generate a spec file. This is not supported yet, but is no particular problem supporting in itself. A little worse problem is that I currently doesn't extract the function "kinds" (long ptr double str wstr) from the source but use the tools/winapi_check/win{16,32}/*.api files to determine the "kinds". This is not a teoretical problem, however it might take some time to fix all the same. But after that winapi_extract will be able to take unmodified source if __declspec(dllexport) directives or a .def file exists. However I think we concentrate primarily on the Wine source. I think as far the it is concerned it will suffice to use comment lines like * Foo (BAR.@) to extract the normal entries for the spec files. The stubs and forwards need to have special handling but then so must it in the case of __declspec(dllexport) directives or a .def file as well. There is no problem for winapi_extract to support all the above either (except implementation time of course). > Basically, if the source parsing allows doing more than we do now > (like build spec files for new dlls) it's worthwhile; if all it does > is generate the existing spec files some other way I don't think > there's much point. After all, we have the spec files already, and > they are not going to change much. Well, there is the issue of maintaining redundant information. Sure winapi_check can (and indeed was the original reason for it) find missmatchs. But given the number of errors I have seen people make that winapi_check detected, we really should avoid having redundant information if we can. In addition it will be much easier for the developers (especially newbies). If you change the prototype in the .c files or the ordinal in the comment above it, it will be enough. Stub files will be something normal developers needn't concern himself with. > Another use of the source parser could be to generate more detailed > debugging information for +relay; but in this case I'd say it should > go to a completely different file, used by some external relay dumping > program. I don't want all the extra debug information to clutter up > the spec files. That is another thing that I have planned to do with winapi_extract. I don't have any good idea how this should look like yet. You (or somebody else) are welcome to write a specification on exactly what you want so I can fix the how when I have time.

1 0

Re: Documentation fixes
by Alexandre Julliard July 13, 2001

July 13, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > For normal entry point, however, I respectfully disagree. > One of the major reasons of having automatically > generated .spec files is to avoid having to > store redundant information. The needed information > is already in the C function declaration and storing > in a comment as well brings us back to the current > situation. Sure it makes that generator less > complicatated but it really isn't that important > as long as it is reliable and not ambigeous. IMO, this is true if we can make the generator work purely on the source code, so that you can give it the unmodified source of a Windows dll and it spits out the spec file. If you need to add comments before each and every exported function, then I don't see much advantage to parsing the source. You might as well put all the information in the comment (or leave it in the current spec file for that matter). Basically, if the source parsing allows doing more than we do now (like build spec files for new dlls) it's worthwhile; if all it does is generate the existing spec files some other way I don't think there's much point. After all, we have the spec files already, and they are not going to change much. Another use of the source parser could be to generate more detailed debugging information for +relay; but in this case I'd say it should go to a completely different file, used by some external relay dumping program. I don't want all the extra debug information to clutter up the spec files. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: GetCommState16 ....
by lawson_whitney＠juno.com July 13, 2001

July 13, 2001

Good day! If you get this, neither this patch nor any of the recently committed patches that muck with 16 bit comms bother my 16 bit comms app. Mike, did you not get juno.tar.gz or do you just not want to be bothered filling in the junk to make a new account? Regards, Lawson ---cut--- ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

hello all
by Brandon Kilgore July 13, 2001

July 13, 2001

Hi everyone, Just letting you all know that there's a new listener out here, eager to pick up on what you're discussing. I'm only 17, so I'll be pretty much staying out of the way, but I love programming so hopefully you won't mind if I stick my hand up to ask a question or respond to someone every once in a while. Just so you can know a bit about me...I used to be a purely QBasic programmer in my "early" days, but a few years ago I began broadening my horizons, mostly with HTML and Visual Basic. For a long time I had wanted to learn C but never really got around to it, but a little over a year ago I finally sat down and started learning, and now its one of the only languages I ever use. Some other languages I currently program in (or would come back to me if need be :-) : C/C++/Visual C++ (Q)Basic/Visual Basic HTML Perl BF (there's an interesting language...) Java/JavaScript WISE InstallMaster scripting ;-) Anyways, I'll let you all get back to the important development discussions. I'll be talking to you... - Brandon

2 2

RE: Documentation fixes
by Patrik Stridvall July 13, 2001

July 13, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Like: > > > > > /************************************************************* > ********** > > * strcpy (MSVCRT.@) > > */ > > #if 0 /* Suppress warnings */ > > extern char *strcpy(char *dest, const char *src); > > #endif > > > > Perhaps we could do the same with atom functions and lstrcmpi? > > The #if 0 #endif isn't even needed for them I believe. > > That's quite ugly IMO. The #if 0 #endif or having to have a documentation comment at all? Anyway the #if 0 is not needed I thought it might be needed in some cases but it is not. I mistakingly believed it might be type conflicts but it can't be since any exported function must of course use the C library types otherwise you can't export them directly. If you are refering to the documentation comment, I can't really see why. All other functions have it and adding additional documentation might be a good idea in some cases as well. Furthermore the extern declaration makes it possible for the C compiler to check that the prototype is the same as the prototype in the included files. I spotted several error when doing the patch because of this. As hinted above, I have implemented a working solution that does what I have described above. See separate mail. > As long as we require comments, we might as > well put everything explicitly in the comment, something like: > > /* ##spec## msvcrt "@ cdecl strcpy(ptr str) strcpy" */ > > (we can probably come up with a better syntax, but you get the idea). > Then we can simply grep for '##spec##' and extract everything into the > spec file. We can do the same for forwards etc. (and in fact we could > do it for normal entry points as well). For forwards, stubs and other special cases, perhaps. I don't like it very much but it is acceptable. But we need not decide that now. I will think more about it and come back later with some kind of proposal that might or might not match yours. I'm not sure, we will see. For normal entry point, however, I respectfully disagree. One of the major reasons of having automatically generated .spec files is to avoid having to store redundant information. The needed information is already in the C function declaration and storing in a comment as well brings us back to the current situation. Sure it makes that generator less complicatated but it really isn't that important as long as it is reliable and not ambigeous. PS. For the record: I consider winapi_extract a prototype not something that nessary will finally use in "production". We might of course use it, but I would rather rewrite it so it becomes simpler and more reliable. Perhaps it shouldn't be in Perl but in C instead? Oh, well, that is a minor issue compared to how the information should be stored.

1 0

To strip or not to strip
by Jeremy White July 13, 2001

July 13, 2001

We've always built the CodeWeavers Wine RPM unstripped, in the theory that it made supporting Wine newbies easier. However, AFAICT from watching cemw, we never get into a situation where a newbie goes into winedbg; more often, they shift first to the CVS tip, and from there maybe to winedbg. So, it seems like shipping debug symbols may just be a waste of bandwidth. (Note, we build with all full logging enabled, and we'll never change that). However, before we go ahead and yank the debug info out of our RPM, I thought I'd post a note, and let someone tell me if I'm wrong. Thanks, Jer

1 0

Re: Documentation fixes
by Alexandre Julliard July 12, 2001

July 12, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > Like: > > /*********************************************************************** > * strcpy (MSVCRT.@) > */ > #if 0 /* Suppress warnings */ > extern char *strcpy(char *dest, const char *src); > #endif > > Perhaps we could do the same with atom functions and lstrcmpi? > The #if 0 #endif isn't even needed for them I believe. That's quite ugly IMO. As long as we require comments, we might as well put everything explicitly in the comment, something like: /* ##spec## msvcrt "@ cdecl strcpy(ptr str) strcpy" */ (we can probably come up with a better syntax, but you get the idea). Then we can simply grep for '##spec##' and extract everything into the spec file. We can do the same for forwards etc. (and in fact we could do it for normal entry points as well). -- Alexandre Julliard julliard(a)winehq.com

2 1

RE: Documentation fixes
by Patrik Stridvall July 12, 2001

July 12, 2001

> > The problem is that if I say that the memory directory doesn't > > "belong" to dlls/user/user.spec winapi_{check,extract,fixup} will > > not find implementations for all functions, which will cause > > problems. > > > > For example how should winapi_extract know that I should > generate the line > > 471 pascal16 lstrcmpi(str str) lstrcmpiA > > when it generates the spec files? > > Well, it's a more general problem, namely that the spec files can > reference functions that are not implemented directly in the dll. > > You also have for instance: > > @ cdecl strcpy(ptr str) strcpy > > in MSVCRT, and strcpy is clearly not implemented there since it's in > the C library. So you cannot assume that only the functions contained > in the dll can be used in the spec files, it is legal for the spec > file to reference external functions. True. I didn't even thought of that particular problem. Functions like strcpy is currently suppressed by having it listed in tools/winapi_check/nativeapi.dat, but that is a little kludgy. [Thinking...] Well you could simply have an function documentation comment without a function implementation in some file that belongs to MSVCRT. Like: /*********************************************************************** * strcpy (MSVCRT.@) */ #if 0 /* Suppress warnings */ extern char *strcpy(char *dest, const char *src); #endif Perhaps we could do the same with atom functions and lstrcmpi? The #if 0 #endif isn't even needed for them I believe. > > I think that we need to move the solution of this problem one step > > up the "ladder" and discuss the more general problem: > > How should we store the information needed to generate > > the spec files in the source, especially concerning > > the forwards and stubs? > > You'll need a file somewhere that specifies all the entries that > cannot be determined automatically from the source. You simply cannot > build a 100% correct spec file based only on the function comments. Yes. I have some ideas, but no really good one. My currently best suggestion is having a .spec.in file that approximately looks like the .spec files but supports configure like substitutions. foo.spec.in: ---8<--- name foo type win32 init @init@ rsrc foo.res import baz.dll @debug_channels@ 101 forward Bar BAZ.Bar 102 stub BarFoo @fixed@ @ forward Foo BAZ.Foo @ stub FooBar @unfixed@ ---8<--- And simply let winapi_extract or whatever simple substitute @init@, @debug_channels@, @fixed@ and @unfixed@ with what can be extracted from the source. > And you definitely do not want to need to parse KERNEL source files > (like the ones in memory/) to build the USER spec file. Of course. The question was whether the memory directory belongs to USER or not. I have now accepted that it does not.

1 0

Re: Documentation fixes
by Alexandre Julliard July 12, 2001

July 12, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > > No, USER does not use the memory directory. It links directly to > > libkernel32.so because it needs some internal functions in there, > > Like the atom functions that are implemented in memory/atom.c I guess > you mean. Actually no, the atom functions are similar to lstrcmpi, they are exported from kernel so we don't need to link to libkernel32.so to get them (and they shouldn't have USER comments either). The real problem is the internal kernel functions called by user, things like THUNK_Alloc or LOCAL_Alloc. > The problem is that if I say that the memory directory doesn't > "belong" to dlls/user/user.spec winapi_{check,extract,fixup} will > not find implementations for all functions, which will cause > problems. > > For example how should winapi_extract know that I should generate the line > 471 pascal16 lstrcmpi(str str) lstrcmpiA > when it generates the spec files? Well, it's a more general problem, namely that the spec files can reference functions that are not implemented directly in the dll. You also have for instance: @ cdecl strcpy(ptr str) strcpy in MSVCRT, and strcpy is clearly not implemented there since it's in the C library. So you cannot assume that only the functions contained in the dll can be used in the spec files, it is legal for the spec file to reference external functions. > I think that we need to move the solution of this problem one step > up the "ladder" and discuss the more general problem: > How should we store the information needed to generate > the spec files in the source, especially concerning > the forwards and stubs? You'll need a file somewhere that specifies all the entries that cannot be determined automatically from the source. You simply cannot build a 100% correct spec file based only on the function comments. And you definitely do not want to need to parse KERNEL source files (like the ones in memory/) to build the USER spec file. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: Documentation fixes
by Patrik Stridvall July 12, 2001

July 12, 2001

> Patrik Stridvall <ps(a)leissner.se> writes: > > > PS. And yes, the added lstrcmpi (USER.471) in memory/string.c > > should really be there. Both KERNEL and USER uses the memory > > directory. > > No, USER does not use the memory directory. It links directly to > libkernel32.so because it needs some internal functions in there, Like the atom functions that are implemented in memory/atom.c I guess you mean. > but > that's a different problem. lstrcmpi is a purely KERNEL function, that > happens to be imported by USER (and by other dlls too), That might be so, but it is also _exported_ by USER: grep lstrcmpi dlls/user/user.spec 471 pascal16 lstrcmpi(str str) lstrcmpiA and lstrcmpiA is not implemented anyware else The same goes for the atom functions: grep Atom dlls/user/user.spec 268 pascal16 GlobalAddAtom(str) GlobalAddAtomA 269 pascal16 GlobalDeleteAtom(word) GlobalDeleteAtom 270 pascal16 GlobalFindAtom(str) GlobalFindAtomA 271 pascal16 GlobalGetAtomName(word ptr s_word) GlobalGetAtomNameA > so USER must > not be mentioned in the comment IMO. The problem is that if I say that the memory directory doesn't "belong" to dlls/user/user.spec winapi_{check,extract,fixup} will not find implementations for all functions, which will cause problems. For example how should winapi_extract know that I should generate the line 471 pascal16 lstrcmpi(str str) lstrcmpiA when it generates the spec files? Of course the automatic generation of spec files is not 100% complete most importantly handling of forwards and stubs is not supported. I think that we need to move the solution of this problem one step up the "ladder" and discuss the more general problem: How should we store the information needed to generate the spec files in the source, especially concerning the forwards and stubs? I will address this issue in a separate mail, but you are welcome to add comments specific to this problem in this thread, I'm not sure I feel to writing it today. I have been postponing the writing of mail for quite some time and I'm currenly beginning to get rather tired. PS. Why not as an interim solution simply add support for forward in the Win16 spec files so 471 pascal16 lstrcmpi(str str) lstrcmpiA becomes 471 forward lstrcmpi(str str) USER32.lstrcmpiA which winebuild until actual need simply interprets as 471 pascal16 lstrcmpi(str str) lstrcmpiA Hmm. Perhaps we should have forward16 and forward to separate the pascal16 and pascal cases? Anyway this gives winapi_{check,fixup} enough information to handle the situation where the memory directory doesn't "belong" to dlls/user/user.spec.

1 0

Re: New problems with the debugger
by Uwe Bonnes July 12, 2001

July 12, 2001

>>>>> "Alexandre" == Alexandre Julliard <julliard(a)winehq.com> writes: Alexandre> Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: >> WineDbg starting... file_set_error: No such process Can't attach >> process 8068d98: error 317 Alexandre> I don't see this here. Could you please run wineserver under Alexandre> gdb, put a breakpoint on the file_set_error message Alexandre> (server/file.c line 334), and send me the backtrace at this Alexandre> point? Thanks. Breakpoint 1, file_set_error () at file.c:334 334 default: perror("file_set_error"); set_error( ERROR_UNKNOWN /* FIXME */ ); break; (gdb) bt #0 file_set_error () at file.c:334 #1 0x804b1e5 in get_thread_context (thread=0x97fa210, flags=65537, context=0xbffff350) at context_i386.c:142 #2 0x804b567 in get_thread_single_step (thread=0x97fa210) at context_i386.c:481 #3 0x8051d2e in continue_thread (thread=0x97fa210) at ptrace.c:177 #4 0x8050e9f in resume_process (process=0x8068d98) at process.c:518 #5 0x804bfc6 in debugger_attach (process=0x8068d98, debugger=0x97fa778) at debugger.c:420 #6 0x804c278 in req_debug_process (req=0xbffff4d8) at debugger.c:540 #7 0x805669f in read_request (thread=0x97fa778) at request.c:168 #8 0x805922b in thread_poll_event (obj=0x97fa778, event=1) at thread.c:157 #9 0x8057642 in select_loop () at select.c:262 #10 0x804e5af in main (argc=1, argv=0xbffff6d4) at main.c:108 #11 0x40178baf in __libc_start_main () from /lib/libc.so.6 Perhaps to notice: I run 2.4.6 on a SMP machine, Suse 7.1 Hope this helps Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: Documentation fixes
by Alexandre Julliard July 12, 2001

July 12, 2001

Patrik Stridvall <ps(a)leissner.se> writes: > PS. And yes, the added lstrcmpi (USER.471) in memory/string.c > should really be there. Both KERNEL and USER uses the memory > directory. No, USER does not use the memory directory. It links directly to libkernel32.so because it needs some internal functions in there, but that's a different problem. lstrcmpi is a purely KERNEL function, that happens to be imported by USER (and by other dlls too), so USER must not be mentioned in the comment IMO. -- Alexandre Julliard julliard(a)winehq.com

1 0

New problems with the debugger
by Uwe Bonnes July 12, 2001

July 12, 2001

Hallo, since the update yesterday evening ( and a fresh update recently), on a crash the debugger has problems like this one: 08067330:Call kernel32.UnhandledExceptionFilter(404e4b00) ret=7800f2b8 fixme:pthread_kill_other_threads_np FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock Could not stat /home/bon/ikda/vol2 (No such file or directory), ignoring drive Y: FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock Could not stat /home/bon/ikda/sys (No such file or directory), ignoring drive Z: WineDbg starting... file_set_error: No such process Can't attach process 8068d98: error 317 Beendet Is this known? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: The [Windows] section
by Alexandre Julliard July 12, 2001

July 12, 2001

"Bill Medland" <medbi01(a)accpac.com> writes: > The answer, for those interested > > In Windows 95 a load of configuration information moved from win.ini (esp > the [windows] section) to the registry. Now (when the edits are added to > the cvs) information should come from the [windows] section of win.ini if > the winelook is WIN31 and from the registry in general otherwise, with the > Tweak.Layout overriding both. Actually I have hacked your patch a bit when committing it (hope you don't mind ;-), with the idea of phasing out the Tweak.Layout stuff. So now the values come from the registry for Win95, and from win.ini (plus some hard-coded values) for Win3.1. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: PATCH: internetgetconnectionstate
by Gerard Patel July 12, 2001

July 12, 2001

At 11:37 PM 09/07/2001 +0200, you (Marcus Meissner) wrote: >Hi, > >QuickTimePlayer 5 is using InternetGetConnectedState to check whether to >download its 'homepage'. > >Just say we are connected, and on a LAN. > >Ciao, Marcus > >Changelog: > Have InternetGetConnectedState always return 'LAN connection'. Theoretically this could cause trouble when used with a computer having no connection to the Internet, as an app could think it can connect, try to do it, fail and terminate or display annoying messages. It's not really a strong objection, as most decent computers are connected to the Internet these days, but maybe a config option could be better ? Just a thought. Gerard

3 2

CreateWindow issue?
by Bill Medland July 12, 2001

July 12, 2001

Can anyone shed any light on this? 1. If I take Petzold's POPPAD1 project and slightly modify it so that the style is WS_CHILD | WS_BORDER | WS_VISIBLE | ES_AUTOHSCROLL and then spy on the WM_NCCREATE and WM_CREATE it tells me that the style passed in is WS_OVERLAPPEDWINDOW | WS_CHILDWINDOW | WS_VISIBLE | ES_AUTOHSCROLL which is not the same thing. Does anyone know if a. The Windows Spy++ is telling fibs b. (Win95) CreateWindow patches them up in some way. 2. (Why I was even looking at 1) In the application I am working on we open Edit controls almost as above inside dialogs and they appear with a single pixel solid frame under Windows whereas under Wine they appear with a 2-pixel sunken frame. There are several changes I can make in the controls/edit.c to get the same behaviour under Wine but so far they all "mess up" normal sunken ones. (Under windows the resulting windows end up with zero extended style and 50000088 style.) Any thoughts would be appreciated. Bill

1 1

The [Windows] section
by Bill Medland July 12, 2001

July 12, 2001

Is the [Windows] section of the config still supposed to be in use or should Tweak.Layout be used instead? (I am looking at the [Windows].BorderWidth in particular) Bill

1 1

Re: msvcrt switching from builtin to native
by Alexandre Julliard July 11, 2001

July 11, 2001

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > _ismbcdigit is unimplemented. The log looks like wine starts to think with > that call that msvcrt is a native dll. Implementing a semi stub for that > gives the same behaviour at the next unimplemented msvcrt function. This should fix it: Index: loader/pe_image.c =================================================================== RCS file: /opt/cvs-commit/wine/loader/pe_image.c,v retrieving revision 1.94 diff -u -r1.94 pe_image.c --- loader/pe_image.c 2001/05/24 18:43:16 1.94 +++ loader/pe_image.c 2001/07/11 20:50:37 @@ -655,7 +655,7 @@ return NULL; } - if (pe_export) + if (!builtin && pe_export) SNOOP_RegisterDLL( hModule, wm->modname, pe_export->Base, pe_export->NumberOfFunctions ); /* Send DLL load event */ -- Alexandre Julliard julliard(a)winehq.com

1 0

msvcrt switching from builtin to native
by Uwe Bonnes July 11, 2001

July 11, 2001

Hallo, trying to run msdev.exe with builtin msvcrt, at some point thins strange +snoop,+relay log appears: 08066950:Call msvcrt._strdup(4040b294 "Microsoft Visual C++") ret=5f416652 08066950:Call kernel32.HeapAlloc(40390000,00000000,00000015) ret=4063d846 08066950:Ret kernel32.HeapAlloc() retval=4041c338 ret=4063d846 08066950:Ret msvcrt._strdup() retval=4041c338 ret=5f416652 08066950:Call msvcrt._mbsinc(5f49d450 "%d") ret=5f4160fb 08066950:Ret msvcrt._mbsinc() retval=5f49d451 ret=5f4160fb 08066950:Call msvcrt.atoi(5f49d451 "d") ret=5f41614d 08066950:Ret msvcrt.atoi() retval=00000000 ret=5f41614d 08066950:CALL msvcrt.292: _ismbcdigit(<unknown, check return>) ret=5f416161 ^^^^ 08066950:Call ntdll.RtlRaiseException(406064e0) ret=40631056 08066950:CALL msvcrt.74: __CxxFrameHandler(<unknown, check return>) ret=4006ac97 08066950:Call ntdll.RtlRaiseException(406061d0) ret=40631056 08066950:CALL msvcrt.74: __CxxFrameHandler(<unknown, check return>) ret=4006ac97 _ismbcdigit is unimplemented. The log looks like wine starts to think with that call that msvcrt is a native dll. Implementing a semi stub for that gives the same behaviour at the next unimplemented msvcrt function. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Early crash with msdev.exe
by Uwe Bonnes July 11, 2001

July 11, 2001

Hallo, trying msdev.exe from Microsoft Visual C in a demonstration at Linuxtag, I was astonished how far wine proceeds. Only when trying to create a template, wine crashed. Trying to debug with snoop, however the crash happens much earlier. I tried to look hard at snoop.c, but couldn't find where this error may originate from. Has anybody some idea? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- 08066950:RET msvcrt.658: malloc() retval = 40b01f20 ret=50043066 tid=08066950 08066950:CALL msvcrt.272: _initterm() ret=50043090 08066950:CALL devshl.1603: @(00000700,00000081,00000000,40605ad4,4060576c) ret=50301f0a 08066950:RET devshl.1603: @() retval = 00000000 ret=50301f0a tid=08066950 08066950:CALL mfc42.6374: @(<unknown, check return>) ret=50301f51 08066950:CALL mfc42.5163: @(<unknown, check return>) ret=5f401aff 08066950:CALL msvcrt.67: _EH_prolog(4101007d,00000081,00000000,40605ad4,40605728,40b06da0,00000000,40605748,41010064,00000081,00000000,40605ad4,40b06da0,40b06da0,40605764,50301f1f, ...) ret=5f401b2b 08066950:RET msvcrt.67: _EH_prolog() retval = 41010096 ret=5f401b2b tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler(<unknown, check return>) ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.74: __CxxFrameHandler() ret=4006ac97 08066950:RET msvcrt.74: __CxxFrameHandler() retval = 00000001 ret=4006ac97 tid=08066950 08066950:CALL msvcrt.203: _except_handler3(<unknown, check return>) ret=4006ac97 08066950:CALL msvcrt.73: _XcptFilter(<unknown, check return>) ret=0040175d fixme:pthread_kill_other_threads_np FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock Could not stat /home/bon/ikda/vol2 (No such file or directory), ignoring drive Y: FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock Could not stat /home/bon/ikda/sys (No such file or directory), ignoring drive Z: WineDbg starting... on pid 80683b0 No debug information in 32bit DLL '<Debugged process>' (0x00400000) Loaded debug information from ELF 'wine' (0x00000000) Breakpoint 1 at 0x4000da00 (_end+0x37fc1284) Loaded debug information from ELF '/spare/bon/wine/dlls/libntdll.so' (0x40026000) Loaded debug information from ELF '/spare/bon/wine/libwine.so' (0x40127000) Loaded debug information from ELF '/spare/bon/wine/libwine_unicode.so' (0x4013d000) Loaded debug information from ELF '/lib/libncurses.so.5' (0x40205000) Loaded debug information from ELF '/lib/libm.so.6' (0x4024f000) No debug information in ELF '/lib/libutil.so.1' (0x4026d000) No debug information in ELF '/lib/libdl.so.2' (0x40270000) Loaded debug information from ELF '/lib/libc.so.6' (0x40273000) Loaded debug information from ELF '/lib/ld-linux.so.2' (0x40000000) Loaded debug information from ELF '/spare/bon/wine/dlls/libkernel32.so' (0x40617000) Loaded debug information from ELF '/spare/bon/wine/dlls/libgdi32.so' (0x406b4000) Loaded debug information from ELF '/spare/bon/wine/dlls/libadvapi32.so' (0x40723000) Loaded debug information from ELF '/spare/bon/wine/dlls/libuser32.so' (0x40762000) Loaded debug information from ELF '/spare/bon/wine/dlls/libshell32.so' (0x40882000) Loaded debug information from ELF '/spare/bon/wine/dlls/libshlwapi.so' (0x408e8000) Loaded debug information from ELF '/spare/bon/wine/dlls/libcomctl32.so' (0x40923000) Loaded debug information from ELF '/spare/bon/wine/dlls/libx11drv.so' (0x40c00000) Loaded debug information from ELF '/spare/bon/wine/libwine_tsx11.so' (0x40741000) No debug information in ELF '/usr/X11R6/lib/libSM.so.6' (0x40019000) No debug information in ELF '/usr/X11R6/lib/libICE.so.6' (0x40c4d000) No debug information in ELF '/usr/X11R6/lib/libXpm.so.4' (0x40c65000) No debug information in ELF '/usr/X11R6/lib/libXxf86dga.so.1' (0x40387000) No debug information in ELF '/usr/X11R6/lib/libXxf86vm.so.1' (0x404e5000) No debug information in ELF '/usr/X11R6/lib/libXv.so.1' (0x404ea000) No debug information in ELF '/usr/X11R6/lib/libXext.so.6' (0x40752000) No debug information in ELF '/usr/X11R6/lib/libX11.so.6' (0x40c74000) No debug information in ELF '/usr/lib/gconv/ISO8859-1.so' (0x4038d000) Loaded debug information from ELF '/spare/bon/wine/dlls/libversion.so' (0x404d3000) Loaded debug information from ELF '/spare/bon/wine/dlls/liblz32.so' (0x40695000) No debug information in 32bit DLL 'NTDLL.DLL' (0x40060000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\MSVCRT.DLL' (0x78000000) No debug information in 32bit DLL 'ADVAPI32.DLL' (0x40731000) No debug information in 32bit DLL 'GDI32.DLL' (0x406d0000) No debug information in 32bit DLL 'USER32.DLL' (0x40790000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\MFC42.DLL' (0x5f400000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\OLE32.DLL' (0x7ff20000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\OLEAUT32.DLL' (0x7fe80000) No debug information in 32bit DLL 'SHLWAPI.DLL' (0x408fd000) No debug information in 32bit DLL 'COMCTL32.DLL' (0x4092f000) No debug information in 32bit DLL 'SHELL32.DLL' (0x4089c000) No debug information in 32bit DLL 'K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVSHL.DLL' (0x50000000) No debug information in 32bit DLL 'X11DRV.DLL' (0x40c11000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\MFC42LOC.DLL' (0x7baf0000) No debug information in 32bit DLL 'LZ32.DLL' (0x40698000) No debug information in 32bit DLL 'VERSION.DLL' (0x404d6000) No debug information in 32bit DLL 'C:\WINDOWS\SYSTEM\RPCRT4.DLL' (0x7fb90000) No debug information in 32bit DLL 'K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVEDIT.PKG' (0x50800000) No debug information in 32bit DLL 'K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVPRJ.PKG' (0x50300000) 08066950:RET msvcrt.73: _XcptFilter() retval = 00000000 ret=0040175d 08066950:RET msvcrt.203: _except_handler3() retval = 00000001 ret=4006ac97 Unhandled exception: page fault on read access to 0x0000000f in 32-bit code (0x5f401ead). In 32-bit mode. 0x5f401ead (MFC42.DLL.1145+0x10 in C:\WINDOWS\SYSTEM\MFC42.DLL): cmpl $0,0x10(%ebx) Wine-dbg>bt Backtrace: =>0 0x5f401ead (MFC42.DLL.1145+0x10 in C:\WINDOWS\SYSTEM\MFC42.DLL) (ebp=40605684) 1 0x5f401c94 (MFC42.DLL.5163+0x173 in C:\WINDOWS\SYSTEM\MFC42.DLL) (ebp=4060570c) 2 0x4101007d (_end+0x3c3255) (ebp=4060572c) 3 0x41010064 (_end+0x3c323c) (ebp=40605748) 4 0x50301f1f (DEVPRJ.PKG..text+0xf1f in K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVPRJ.PKG) (ebp=40605764) 5 0x5f401a88 (MFC42.DLL.1109+0x74 in C:\WINDOWS\SYSTEM\MFC42.DLL) (ebp=406057c4) 6 0x5f401a10 (MFC42.DLL.1578+0x2a in C:\WINDOWS\SYSTEM\MFC42.DLL) (ebp=406057e0) 7 0x5f4019cf (MFC42.DLL.1579+0x39 in C:\WINDOWS\SYSTEM\MFC42.DLL) (ebp=4060580c) 8 0x40803b87 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=40605830) 9 0x40803c06 (WINPROC_CallWndProc+0x76(proc=0x5f401996, hwnd=0x700, msg=0x81, wParam=0x0, lParam=0x40605ad4) [winproc.c:171] in libuser32.so) (ebp=4060585c) 10 0x408097f8 (CallWindowProcA+0x88(func=0x40d70dbc, hwnd=0x700, msg=0x81, wParam=0x0, lParam=0x40605ad4) [winproc.c:2589] in libuser32.so) (ebp=40605884) 11 0x407ea1a3 (MSG_SendMessage+0x3b3(hwnd=0x700, msg=0x81, wParam=0x0, lParam=0x40605ad4, timeout=0xffffffff, type=0x2, pRes=0x406058ec) [message.c:1733] in libuser32.so) (ebp=406058bc) 12 0x407ea2a2 (SendMessageA+0x32(hwnd=0x700, msg=0x81, wParam=0x0, lParam=0x40605ad4) [message.c:1772] in libuser32.so) (ebp=406058f0) 13 0x40c15014 (X11DRV_CreateWindow+0x184(hwnd=0x700, cs=0x40605ad4, unicode=0x0) [window.c:871] in libx11drv.so) (ebp=40605938) 14 0x407fce51 (WIN_CreateWindowEx+0x6d1(cs=0x40605ad4, classAtom=0xc066, type=0x2) [win.c:865] in libuser32.so) (ebp=406059b0) 15 0x407fd2fb (CreateWindowExA+0x14b(exStyle=0x0, className=0x403fcebc, windowName=0x0, style=0x42000001, x=0x0, y=0x0, width=0x0, height=0x0, parent=0x2b4, menu=0x7310, instance=0x400000, data=0x40605be0) [win.c:1030] in libuser32.so) (ebp=40605b04) 16 0x5f40c211 (MFC42.DLL.2152+0x9a in C:\WINDOWS\SYSTEM\MFC42.DLL) (ebp=40605b74) 17 0x5f40aaa5 (MFC42.DLL.2124+0x46 in C:\WINDOWS\SYSTEM\MFC42.DLL) (ebp=40605bb0) 18 0x4101004b (_end+0x3c3223) (ebp=40605c04) 19 0x50311b41 (DEVPRJ.PKG.InitPackage+0x4b5 in K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVPRJ.PKG) (ebp=40605c2c) 20 0x50310336 (DEVPRJ.PKG.EntryPoint+0xb5e in K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVPRJ.PKG) (ebp=40605c58) 21 0x50311a22 (DEVPRJ.PKG.InitPackage+0x396 in K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVPRJ.PKG) (ebp=40605c84) 22 0x50311760 (DEVPRJ.PKG.InitPackage+0xd4 in K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVPRJ.PKG) (ebp=406060c0) 23 0x50036fa3 (DEVSHL.DLL.3467+0x9a in K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVSHL.DLL) (ebp=40606664) 24 0x500344be (DEVSHL.DLL.3219+0x53d in K:\USR\LOCAL\SPARE\BON\NT4SP5G\PROGRAMME\MICROSOFT VISUAL STUDIO\COMMON\MSDEV98\BIN\DEVSHL.DLL) (ebp=40606e0c) 25 0x41010019 (_end+0x3c31f1) (ebp=40606ecc) 26 0x400dbf23 (start_process+0x1a3 [process.c:391] in libntdll.so) (ebp=40606f30) 27 0x400dfaa1 (SYSDEPS_DoCallOnStack+0x21(func=0x400dbd80, arg=0x0) [sysdeps.c:173] in libntdll.so) (ebp=40606ff0) 28 0x400dfb43 (SYSDEPS_CallOnStack+0x2f in libntdll.so) (ebp=bffff5f0) 29 0x400dfbfa (SYSDEPS_SwitchToThreadStack+0x9a(func=0x400dbd80) [sysdeps.c:236] in libntdll.so) (ebp=bffff62c) 30 0x400dc2be (PROCESS_InitWine+0x1ce(argc=0x4, argv=0xbffff6c4, win16_exe_name=0x804c660, win16_exe_file=0x804c764) [process.c:519] in libntdll.so) (ebp=bffff644) 31 0x0804b20a (Letext [main.c] in wine) (ebp=bffff65c) 32 0x4028fbaf (__libc_start_main+0xcf in libc.so.6) (ebp=bffff698) 33 0x08049021 (_start+0x21 in wine) (ebp=00000000) Wine-dbg>quit WineDbg terminated on pid 80683b0

1 0

Re: PATCH: include mess up
by Francois Gouget July 11, 2001

July 11, 2001

On Tue, 10 Jul 2001, Marcus Meissner wrote: > Hi, > > There is some bad recursion when including objbase.h in non-WINE programs. > This fixes that problem, by using winbase.h instead of windows.h. Yes but rpc.h is supposed to include 'windows.h', not 'winbase.h'. The correct fix must be elsewhere. What is the recursion that happens and which include statement (in your application) triggers it? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: the choice of a GNU generation

2 1

Re: implement overlapped completion routines
by Alexandre Julliard July 10, 2001

July 10, 2001

Mike McCormack <mike_mccormack(a)start.com.au> writes: > This patch implements overlapped completion routines, and fixes up a > small problem with the overlapped implementation. According to ms > docs, the transfer count should not be stored in the overlapped > structure. Shouldn't you queue an APC instead of calling the completion routine directly? -- Alexandre Julliard julliard(a)winehq.com

1 0

Joysiick under Wine
by David Hagood July 10, 2001

July 10, 2001

I've seen a couple of messages about getting USB joysticks working under Wine, but do regular (i.e. gameport) sticks work? I've confirmed that my stick is being read by Linux, and that it is reporting events correctly. Now, how do I get Wine to pass them along? I've confirmed: 1) that I have read/write permissions to /dev/js0 2) that Wine tries to read /dev/js0 3) that Wine indeed does read from /dev/js0, but that 4) Wine shortly thereafter closes /dev/js0, never to read it again. Do I need to have the X Window system joystick driver loaded? Or do I need to add something to the system.ini or .wine/config files. This is a Windowless install, under RH6.1, with 2.4.6, and a CVS pull of Wine from a few days ago. I'm trying to get HalfLife running under Wine. I have the GL working, I have sound working, but I am one of those strange fellows that likes to move with a stick, and look with a mouse. Are there any Windows/Wine tools that I can run to try to troubleshoot this?

2 1

Re: some rasapi32 stubs
by Marcus Meissner July 10, 2001

July 10, 2001

On Tue, Jul 10, 2001 at 10:10:17PM +1000, Mike McCormack wrote: > > ChangeLog: > * dlls/rasapi32/rasapi.c, dlls/rasapi32/rasapi32.spec > Stub some rasapi functions. If you know arguments are strings you can use 'str' instead of 'ptr' in the .spec file, and relay debugging will print strings ;) Also you can use the return value of debugstr_a(a) for string output. Ciao, Marcus

1 0

Re: wv{sn,ns}printf[AW]
by Alexandre Julliard July 9, 2001

July 9, 2001

Peter Hunnisett <hunnise(a)yahoo.com> writes: > 2) Can wvnsprintf be moved from user32 into shlwapi? This would cause > user32 to have to import shlwapi (because wsprintfA and friends use it > in their implementation) and I don't know if that's legal because user32 > seems to only import gdi32 and kernel32. If not, what's the solution? > Reimplement everything in user32 to not use wvnsprintf and move the > implementation over or just keep the existing situation and rename > wvnsprintf to wvnsprintf and forward the shlwapi calls to user32? user32 cannot import shlwapi, since this would create a circular dependency. Since the functions are needed both in user32 and shlwapi, they have to be implemented in user32 and forwarded from shlwapi to user32 (the alternative is to have two complete wsprintf implementations, which is a bit of a pain). I guess you could also rename the user32 ones, but this is not strictly necessary (and the current name has the advantage of following the C library naming of vsnprintf). -- Alexandre Julliard julliard(a)winehq.com

1 0

wv{sn,ns}printf[AW]
by Peter Hunnisett July 9, 2001

July 9, 2001

Hi, it appears that we have a bit of a hack in the wine code. Presently we export wvsnprintf[AW] from user32. - These two functions do not appear to be in the real user32.dll and the comments in the code seem to back it up. - Windows does have wvnsprintf[AW] (note the transposed "sn") exported from shlwapi.dll So my questions are: 1) Was the user32 a bit of a hack because those routines just weren't noticed or was it because of something from before shlwapi? 2) Can wvnsprintf be moved from user32 into shlwapi? This would cause user32 to have to import shlwapi (because wsprintfA and friends use it in their implementation) and I don't know if that's legal because user32 seems to only import gdi32 and kernel32. If not, what's the solution? Reimplement everything in user32 to not use wvnsprintf and move the implementation over or just keep the existing situation and rename wvnsprintf to wvnsprintf and forward the shlwapi calls to user32? Thanks, Peter hunnise(a)yahoo.com _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

1 0

Re: Are these the ordinal names?
by Alexandre Julliard July 8, 2001

July 8, 2001

Peter Hunnisett <hunnise(a)yahoo.com> writes: > Howdy, > I have a couple of questions about the following error messages > > err:win32:fixup_imports No implementation for > SHLWAPI.dll.281(wvnsprintfA) imported from > C:\windows\system\shdocvw.dll, setting to 0xdeadbeef > err:win32:fixup_imports No implementation for > SHLWAPI.dll.282(wvnsprintfW) imported from > C:\windows\system\shdocvw.dll, setting to 0xdeadbeef > err:win32:fixup_imports No implementation for > SHLWAPI.dll.240(StrRetToStrW) imported from > C:\windows\system\shdocvw.dll, setting to 0xdeadbeef > > 1) Do these messages mean that 281 is named wvnsprintfA and so on? If > so, why does the SHLWAPI.240 name not seem to jive with the existing > implementation? If a name is specified, the ordinal is only a hint, so it's OK for it to be different. What this means is that in some version of shlwapi StrRetToStrW is at ordinal 240, but it can be at other ordinals in other versions since it is looked up by name. In our builtin version, ordinal 240 is something else (which is fine), and StrRetToStrW is not implemented at all (which is the cause of your problem). You can either implement it, or use the native shlwapi. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: sharing windows between processes
by Alexandre Julliard July 8, 2001

July 8, 2001

"Bill Medland" <medbi01(a)accpac.com> writes: > Some time ago I raised the issue of the fact that windows handles cannot be > shared between processes on the same server and was told that it was a > known significant issue. > > Is anyone doing anything about it? Sure, that's the main reason behind all the recent window management and messaging changes. So yes, it is being worked on. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Mouse events
by Alexandre Julliard July 8, 2001

July 8, 2001

Duane Clark <dclark(a)akamail.com> writes: > I assume some problem led to its removal. I regularly try out Myst (the > 32 bit version) as a test, running locally on a 700MHz Athlon, so this > can't be blamed on a slow ethernet connection or slow machine. When > dragging the slide controls in the "planetarium", they used to follow > the mouse just fine. With this patch, if you grab the control, move the > mouse and release it, the control does not keep up with the mouse but > just moves at a moderately slow pace until it reaches the point where > the mouse was released (a few seconds to travel from one end to the > other). At that point everything returns to normal. The new hardware event handling does not yet attempt to merge mouse motion events, so this is probably the reason for the problem. This should be fixed soon. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: printing docu
by Duane Clark July 8, 2001

July 8, 2001

Andreas Mohr wrote: > Hi all, > > while trying to configure Wine for printing in order to be able to use > Windows Acrobat Reader instead of Linux acroread which is crashing on certain > PDF files, I remembered that the printing docu is everything but perfect. > > Updated printing docu a bit. > > ... > - <sect3> > <title>Spooling</title> > <para> > Spooling is rather primitive. The [spooler] section of > @@ -82,13 +82,14 @@ > example the following lines > </para> > <screen> > -"LPT1:" = "foo.ps" "LPT2:" = "|lpr" > +"LPT1:" = "foo.ps" > +"LPT2:" = "|lpr" > </screen> > <para> > map <systemitem>LPT1:</systemitem> to file <filename>foo.ps</filename> > and <systemitem>LPT2:</systemitem> to the <command>lpr</command> > - command. If a job is sent to an unlisted port then a file is created > - with that port's name e.g. for <systemitem>LPT3:</systemitem> a file > + command. If a job is sent to an unlisted port, then a file is created > + with that port's name; e.g. for <systemitem>LPT3:</systemitem> a file > called <systemitem>LPT3:</systemitem> would be created. > </para> > <para> While it used to work that way, for me at least, the part about - a job that is sent to an unlisted port will create a file with the port's name - stopped working a few months ago. And I just tested it a few minutes ago and it still does not work (for me). I don't know where the data goes, but it does not appear to be written to a file anywhere. Actually, I think that is probably a good thing. In most cases, the print dialog should have a "Print to file" button. And if there is no way to specify a file name, then the ~/.wine/config entry "FILE:" = "foo.ps" will control where it is written, and in this case it will in fact be correctly written to the indicated file name. Duane

1 0

Half-Life/CS under WINE
by David Bronaugh July 8, 2001

July 8, 2001

Just as a follow-up to my previous email.. if you want a quick response from me, email me off the list - I'm getting the digest, as I don't want to massively clutter up my inbox. David Bronaugh

1 0

Problems running WINE with Half-Life with CounterStrike
by David Bronaugh July 8, 2001

July 8, 2001

Hey all, I'm having some interesting issues with Half-Life running under WINE... I'm guessing these are due to it running under WINE (they are strange enough). #1 problem: I can't type normally in the Half-Life console (the keyboard is mapped to a completely nonsensical map). I believe this is because they implemented their own custom key handler. Is there any workaround in software/with config for this? Note that this is only in the game when the game engine is initialized, otherwise the keyboard works great (Kudos to the WINE people that my dvorak-mapped QWERTY keyboard works as it should in dvorak). #2 problem: I can't get to the Half-Life console without going through some convolutions... This in itself is useless to tell you people. How I do get into the game is by the following method: I join a game or whatever, and the "Loading" screen pops up. At this point.. it will sit there for hours (I'm guessing this is a locking issue with pthreads?). What I do that appears to relieve the deadlock is to click the "Done" button that is invisible (but I know where it is, so I click it). Then the game loads normally, and runs decently enough (performance isn't great, but playable... huge kudos to the Wine crew for that). Note that the only button that does this is the "Done" button, the rest do nothing out of the ordinary. Again, this may be due to some peculiarity with Half-Life or with my config.. I'm betting on a peculiarity with Half-Life interacting with some unimplemented feauture or bug in WINE. If anyone has suggestions re these two, send em to me.. I'm more than happy to spend a few hours to help resolve this. David Bronaugh

1 0

Are these the ordinal names?
by Peter Hunnisett July 8, 2001

July 8, 2001

Howdy, I have a couple of questions about the following error messages err:win32:fixup_imports No implementation for SHLWAPI.dll.281(wvnsprintfA) imported from C:\windows\system\shdocvw.dll, setting to 0xdeadbeef err:win32:fixup_imports No implementation for SHLWAPI.dll.282(wvnsprintfW) imported from C:\windows\system\shdocvw.dll, setting to 0xdeadbeef err:win32:fixup_imports No implementation for SHLWAPI.dll.240(StrRetToStrW) imported from C:\windows\system\shdocvw.dll, setting to 0xdeadbeef 1) Do these messages mean that 281 is named wvnsprintfA and so on? If so, why does the SHLWAPI.240 name not seem to jive with the existing implementation? 2) Why would I be getting the error for SHLWAPI.dll.240(StrRetToStrW) given the fact that the shlwapi.spec file contains the following line and there does seem to be an implementation in ordinal.c? 240 stdcall @(long long long long) SHLWAPI_240 Ciao, Peter Hunnisett hunnise(a)yahoo.com _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

1 0

Re: Win16 problems
by Gerard Patel July 7, 2001

July 7, 2001

At 10:43 PM 03/07/2001 +0200, you wrote: <snip> >winmine fails to draw, whereas freecell runs just fine Yes, I see the problem with winmine; but is it really a 16-bits problem ? What I see is an app creating its main window iconic (minimized), then showing it using ShowWindow. Current Wine code does not take this particular behaviour (completely absurd, granted) in account - When the window is created the 'client' window is not mapped (since it's iconic, nothing surprising here), but in ShowWindow the iconic flag (WS_MINIMIZED) is cleared, and when SetWindowPos is called by ShowWindow, X11DRV_sync_client_window_position cleverly detects that the window is already mapped ;-) and decides that it's not necessary to do anything more. This seems more a Winmine specific problem than otherwise. BTW, I can't see any problem with sol.exe (win3.11 version) This patch : --- window.c.orig Wed Jun 27 03:03:36 2001 +++ window.c Sat Jul 7 23:19:03 2001 @@ -596,7 +596,7 @@ if (was_mapped && !is_client_window_mapped( win )) XUnmapWindow( display, data->client_window ); XConfigureWindow( display, data->client_window, mask, &changes ); - if (!was_mapped && is_client_window_mapped( win )) + if (is_client_window_mapped( win )) XMapWindow( display, data->client_window ); wine_tsx11_unlock(); } works around this particular problem. Gerard

1 0

Windows .lnk file parsing
by J. Henning Schwentner July 7, 2001

July 7, 2001

Hi Wine developers, I am planning to write a little tool "lnk2desktop" which converts Windows LNK links into KDE/Gnome .desktop links, which you could use then to integrate your Windows start menu into your K menu. When I searched through the wine news archive I found a message about library that parses .lnk files and returns the command to execute, the icon etc. My question is now, does such a library exist and what other ways do exist for finding out such infomations? Regards, Henning Schwentner Lanthan Software KG P.S.: Please CC me, since I am not subscribed to the list.

1 0

sharing windows between processes
by Bill Medland July 6, 2001

July 6, 2001

Some time ago I raised the issue of the fact that windows handles cannot be shared between processes on the same server and was told that it was a known significant issue. Is anyone doing anything about it? It seems to me that what has to be done is to have wineserver coordinate the allocation of handles. Any comments? Bill

1 0

Confusing SHGetFolderPath
by nog July 6, 2001

July 6, 2001

Hi, While I was looking through some of the wine dlls' code I found that the function SHGetFolderPath is in the shell32 dll and the shfolder dll. Is this ment to be like this? Because the docs that I read says that the function is meant to be in shfolder. Anyway are the two functions meant to do the same thing? If so then why is the one in shell32 implemented and working and the one on shfolder doesn't eaven appear to give a fixme message? Nog

4 3

Help with nonclient Windows 95 frame
by Bill Medland July 6, 2001

July 6, 2001

I'd appreciate some advice here before I mess things up for everyone else. In the longer term I am fixing a border issue with the edit control, but before doing so I am fixing up the nonclient frame drawing code (i.e. NC_DoNCPaint95). The code contains quite a bit of calculation based upon the system metrics. The code seems to reflect the Windows documentation. However it should come as no surprise that there are disagreements between that documentation and what I see on my Win95 computer! For example a frame with WS_THICKEDGE but no WS_BORDER nor WS_DLGFRAME nor WS_EX_DLGMODALFRAME on my computer is only 3 pixels wide, not 4 (although one of those pixels is the COLOR_WINDOW associated with the WS_THICKEDGE) Is there a way to adjust the size of the borders on the Win95 to be able to see what affects what? Bill

1 1

Mouse events
by Duane Clark July 3, 2001

July 3, 2001

Howdy, Just tried the most recent CVS. I found that the patch from 6/25 to windows/x11drv/event.c has led to mildly annoying mouse behavior in certain (admittedly very limited) cases. Here is the change that did it: @@ -292,21 +291,8 @@ case ButtonRelease: EVENT_ButtonRelease( hWnd, (XButtonEvent*)event ); break; case MotionNotify: - /* Wine between two fast machines across the overloaded campus - ethernet gets very boged down in MotionEvents. The following - simply finds the last motion event in the queue and drops - the rest. On a good link events are servered before they build - up so this doesn't take place. On a slow link this may cause - problems if the event order is important. I'm not yet seen - of any problems. Jon 7/6/96. - */ - if ((current_input_type == X11DRV_INPUT_ABSOLUTE) && - (in_transition == FALSE)) - /* Only cumulate events if in absolute mode */ - while (TSXCheckTypedWindowEvent(display,((XAnyEvent *)event)->;window, - MotionNotify, event)); EVENT_MotionNotify( hWnd, (XMotionEvent*)event ); break; I assume some problem led to its removal. I regularly try out Myst (the 32 bit version) as a test, running locally on a 700MHz Athlon, so this can't be blamed on a slow ethernet connection or slow machine. When dragging the slide controls in the "planetarium", they used to follow the mouse just fine. With this patch, if you grab the control, move the mouse and release it, the control does not keep up with the mouse but just moves at a moderately slow pace until it reaches the point where the mouse was released (a few seconds to travel from one end to the other). At that point everything returns to normal. Other similar slide controls, such as the musical slide controls in the space ship, work fine with the patch, however. Perhaps it is possible that the code above was masking some other problem causing the control to move too slowly to follow the mouse? Duane

1 0

Win16 problems
by Ove Kaaven July 3, 2001

July 3, 2001

Is it just me, or does no Win16 GUI apps work in the current Wine CVS? If Wine is compiled with --enable-opengl, then we get BadMatch errors in X_CreateWindow (some kind of visual mismatch), If I disable the OpenGL visual, then the windows are created and seem to exist, but they're never drawn. Win32 apps work fine, of course. I could probably look into the OpenGL problem if that was the only problem, but why are Win16 windows never drawn anyway? (Unfortunately, I don't have sol.exe here, I tested with MS Word Viewer 16-bit, but DOS apps like Monkey Island gets the same issues in my tree)

2 2

Mixed mode CD's and volume label
by David Hagood July 3, 2001

July 3, 2001

I was trying to get Half-Life running under Wine last night, and ran into a problem with getting the CD label under Wine. Since the HL CD is a mixed mode data/audio disk (as are most game disks nowadays) Wine complained with a We don't have a way of determining the label of a mixed mode CD - Linux doesn't allow raw access ! However, Xcdroast was easily able to access the data. As an experiment, I disabled this check in misc/cdrom.c, and it worked quite happily. Perhaps this check is out of date. Perhaps it is my system setup: 2.4.6-pre7, Samsung CD-Writer/DVD reader on IDE, ide-scsi module loaded, Wine configured to use the /dev/scd0 link. Now, if I could just work out why the OpenGL is flashing...

2 1

Window painting problem
by Glenn Schrader July 3, 2001

July 3, 2001

I've been tracking down a window painting problem and I think that I know whats happening but I'd like to get some opinions on the 'right' way to fix it. The symptom is that (in some cases) any change to a window will cause the entire window to be repainted. For instance, using the mouse to select a single character causes the whole window to update rather than just the small region which needs to be highlighted. This doesn't happen on most applications. In fact, the only one where i've seen this effect is RoAClient (a really good MUD client). Even so, its really annoying and makes the window flash so much that the app is effectively useless. The problem appears to be in BeginPaint. There is a test which checks to see if the window has the CS_PARENTDC flag set. If so then then the update region is discarded and the window is painted. This has the side effect of making the whole window repaint every time anything in the window changes. According to the windows docs that i've looked at, the CS_PARENTDC should just make the window paint using its parent's device context. There isn't any mention of also removing the invalid region clipping so i'm pretty sure that what BeginPaint is doing isn't right. In my hacking around, I disabled the branch of the test which removes the clipping region and things appear to work a lot better. The screen updating is definitely smoother. What I'm not sure of is whether this is good enough or whether the CS_PARENTDC case really should be slightly different. Normally the clipping region is offset relative to the window thats being drawn but with CS_PARENTDC should the offset be done relative to the parent window instead? Are there any other subtle things that CS_PARENTDC affects? Any insight would be appreciated... Thanks much, G. Schrader

2 1

Re: Window painting problem
by r.maurizzi＠gvs.it July 3, 2001

July 3, 2001

Glenn Schrader <gschrad(a)ll.mit.edu> wrote: > The symptom is that (in some cases) any change to a > window will cause the entire window to be repainted. > (...) > This doesn't happen on most applications. > In fact, the only one where i've seen this effect is > RoAClient (a really good MUD client). Even so, its > really annoying and makes the window flash so much > that the app is effectively useless. Just for info, Lotus Notes v 4.6x has the same problem. Ciao, Roberto.

1 0

Re: Win16 problems
by Gerard Patel July 3, 2001

July 3, 2001

At 02:58 AM 03/07/2001 +0200, you wrote: >Is it just me, or does no Win16 GUI apps work in the current Wine CVS? If >Wine is compiled with --enable-opengl, then we get BadMatch errors in >X_CreateWindow (some kind of visual mismatch), If I disable the OpenGL >visual, then the windows are created and seem to exist, but they're never >drawn. > >Win32 apps work fine, of course. For me Win16 apps have not more problems than Win32 ones. Word viewer 16 bits has one regression with current Cvs vs say one month ago, a focus problem that is occuring only in managed mode. Other than that, it is starting and loading files, either on my old computer with Xfree 3.3 and on my newer one with Xfree 4 (compiled with --enable-opengl) I still run most of my test apps on the old computer, but none of them crashes and the new redrawing problems are less than what you say. IMO Wine behaviour depends more now on the specific X server and window manager. I use Kde on both computers, btw (1.1.1 and 2.1 respectively) Gerard

1 0

Re: dead lock
by Alexandre Julliard July 3, 2001

July 3, 2001

eric pouech <eric.pouech(a)wanadoo.fr> writes: > let's assume fixing it is now on Alexandre's TODO list ;-) Yes, I'll fix it, thanks for the report. You'll have to wait a bit though, as I will be away most of the week. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: PATCH: setsockopt differences for winsock/winsock2
by Alexandre Julliard July 3, 2001

July 3, 2001

Marcus Meissner <marcus(a)jet.franken.de> writes: > That was the time that I spotted that the #defines for the IP_* > stuff _differs_ between winsock and winsock2. So I had to split up > the IPPROTO_IP handling. I tried to keep code duplication to a minimum. > > I am not sure whether the forwarders are good style. They are not IMHO. I'd suggest writing a ws1-to-ws2 conversion function instead, and use it (by duplicating its code) both for the 16-bit functions in ws2_32 and for the version 1 functions in wsock32. A little code duplication is better than adding entry points. An even better alternative that would avoid the duplication could be to have the 16-bit functions implemented in wsock32 instead of ws2_32, but this is probably a lot more work. -- Alexandre Julliard julliard(a)winehq.com

1 0

tray icon creation problem
by Adriaan Moors July 3, 2001

July 3, 2001

hi, earlier, i reported a problem with create_icon_window. It doesn't crash anymore with today's cvs (it says an error occurred when initing the tray icon). The application (winmx) continues to load, but it keeps moving downwards. This only occurs when using enlightenment, with window maker it stays still :-) Maybe it's a bug in enlightenment? regards adriaan moors -- Have you ever noticed that the people who are always trying to tell you, "There's a time for work and a time for play," never find the time for play?

1 0

Request for feature
by David Ronis July 2, 2001

July 2, 2001

I posted this to comp.emulators.ms-windows.wine, but got no reply. I'd been having problems with a windows application that want's to pass off a URL to a browser (netscape). OK I figured out part of my problem. [In short, I have an windows application that spawn netscape with some command-line url]. As was suggested in this thread, I had to install a windows version of netscape (I only had the linux native version installed). The installation set up the registry and things work (well sort of, netscape complains about not being able to write to the tmp directory e: [which is /tmp]). The problem now is that I seem to be on the slippery slope; i.e., most of the plugins/helper applications are absent, so in order to see various file types I have to download more windows versions of things already on my system. None of this would be necessary if there was some way to get wine to first try a native program; e.g., before trying netscape.exe or whatever was in the registry, try netscape using a standard unix system call; only if this failed would wine look for a windows version. Alternately the order could be reversed (I'd be more than willing to remove the windows versions of netscape). The best solution, would be some sort of override capability be added to the config file, for example, similar to the way native vs windows .dll's are chosen. I'm willing to play around with this, but have no experience with the internals of wine. Can somebody point me to the right point of the source code? It'd probably be trivial (and less likely to mess up wine) to first try to fork off a linux command (e.g., by mapping the end of command to something lowercase and less the .exe or .com suffix) and if that failed resort to the windows command. David P.S., I don't subscribe to this list, so please CC me.

1 0

dead lock
by eric pouech July 2, 2001

July 2, 2001

an app of mine, using two threads, dead locks as follows: thread 1 0 0x40057b1b (RtlpWaitForCriticalSection+0x147(crit=0x40652d48, crit=0x40652d48) [critsection.c:185] in libntdll.so) (ebp=40a96a74) 1 0x40057bf6 (RtlEnterCriticalSection+0x3e(crit=0x40652d48) [critsection.c:241] in libntdll.so) (ebp=40a96a88) 2 0x400ca883 (_EnterSysLevel+0xf7(lock=0x40652d48) [syslevel.c:80] in libntdll.so) (ebp=40a96ab4) 3 0x40639a5f (GDI_AllocObject+0x2f(size=0x34, magic=0x4f4b, handle=0x40a96afc, handle=0x40a96afc) [gdiobj.c:427] in libgdi32.so) (ebp=40a96ad8) 4 0x4062c668 (CreateBitmap+0x78(width=0x20, height=0x20, planes=0x1, bpp=0x18, bits=0x4039fe1c) [bitmap.c:124] in libgdi32.so) (ebp=40a96b00) 5 0x40770f66 (GetIconInfo+0xca(hIcon=0x24e, iconinfo=0x40a96b50) [cursoricon.c:1816] in libuser32.so) (ebp=40a96b30) 6 0x40805a4a (set_icon_hints+0xe6(display=0x8082898, wndPtr=0x4037fe00, hints=0x8083da0, display=0x8082898, win=0x4037fe00, display=0x8082898, win=0x4037fe00) [window.c:263] in libx11drv.so) (ebp=40a96b8c) 7 0x40805ccb (set_wm_hints+0xf3(display=0x8082898, win=0x4037fe00) [window.c:370] in libx11drv.so) (ebp=40a96bbc) 8 0x4080691e (create_whole_window+0x1aa(display=0x8082898, win=0x4037fe00, win=0x4037fe00) [window.c:699] in libx11drv.so) (ebp=40a96c50) 9 0x40806ead (X11DRV_CreateWindow+0xb5(hwnd=0x4ac, cs=0x40a96e2c, unicode=0x0) [window.c:856] in libx11drv.so) (ebp=40a96c90) 10 0x40797831 (WIN_CreateWindowEx+0x6c9(cs=0x40a96e2c, classAtom=0xc014, type=0x2) [win.c:865] in libuser32.so) (ebp=40a96d08) 11 0x40797cca (CreateWindowExA+0x15a(exStyle=0x0, className=0x404c86ce, windowName=0x4049ef3c, style=0xcf0000, x=0x366, y=0x14, width=0x19a, height=0x16f, parent=0x0, menu=0x0, instance=0x4049d000, data=0x0) [win.c:1030] in libuser32.so) (ebp=40a96e5c) 12 0x4049be85 (SInitInstance+0x169(hInstance=0x4049d000, nCmdShow=0x1) [sinit.c:247] in a.so) (ebp=40a96ecc) 13 0x4049911b (ServerThread+0x4b(p=0x405e6e14) [a.c:19] in a.so) (ebp=40a96f1c) 14 0x400cb1ac (THREAD_Start+0x98 [thread.c:273] in libntdll.so) (ebp=40a96f38) 15 0x400ca44e (SYSDEPS_StartThread+0x36(teb=0x40aa7000) [sysdeps.c:73] in libntdll.so) (ebp=40a96ff4) 16 0x4030531a (NTDLL.DLL.memcpy+0x494aa in libc.so.6) (ebp=00000000) thread 2 0 0x40057b1b (RtlpWaitForCriticalSection+0x147(crit=0x40841d10, crit=0x40841d10) [critsection.c:185] in libntdll.so) (ebp=405e6ac0) 1 0x40057bf6 (RtlEnterCriticalSection+0x3e(crit=0x40841d10) [critsection.c:241] in libntdll.so) (ebp=405e6ad4) 2 0x4080b668 (lock_tsx11+0x1c [x11drv_main.c:109] in libx11drv.so) (ebp=405e6ae4) 3 0x4080f595 (X11DRV_StretchBlt+0x39(dcDst=0x4039f710, xDst=0x0, yDst=0x0, widthDst=0xa0, heightDst=0x80, dcSrc=0x4039f4e8, xSrc=0x0, ySrc=0x0, widthSrc=0x190, heightSrc=0x140, rop=0xcc0020) [bitblt.c:1555] in libx11drv.so) (ebp=405e6b10) 4 0x4061bbf2 (StretchBlt+0x102(hdcDst=0xf4, xDst=0x0, yDst=0x0, widthDst=0xa0, heightDst=0x80, hdcSrc=0xf0, xSrc=0x0, ySrc=0x0, widthSrc=0x190, heightSrc=0x140, rop=0xcc0020) [bitblt.c:120] in libgdi32.so) (ebp=405e6b54) 5 0x40499b84 (CInitializeCoolBitmaps+0x36c [cinit.c:229] in a.so) (ebp=405e6bd4) 6 0x4049a265 (CMainWndProc+0x205(hWnd=0x13c, msg=0x590, wParam=0x0, lParam=0x0) [client.c:131] in a.so) (ebp=405e6d24) 7 0x4079e197 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405e6d48) 8 0x4079e216 (WINPROC_CallWndProc+0x76(proc=0x4049a060, hwnd=0x13c, msg=0x590, wParam=0x0, lParam=0x0) [winproc.c:171] in libuser32.so) (ebp=405e6d74) 9 0x407a3da8 (CallWindowProcA+0x88(func=0x4096054c, hwnd=0x13c, msg=0x590, wParam=0x0, lParam=0x0) [winproc.c:2589] in libuser32.so) (ebp=405e6d9c) 10 0x40785fcc (DispatchMessageA+0xd8(msg=0x405e6e24) [message.c:2359] in libuser32.so) (ebp=405e6de0) 11 0x404991ff (WinMain+0x9b(hInstance=0x4049d000, hPrevInstance=0x0, lpCmdLine=0x40360747, nCmdShow=0x1) [a.c:78] in a.so) (ebp=405e6e40) 12 0x4049e082 (__wine_exe_main+0x82 [a.spec.c:5838] in <Debugged process>) (ebp=405e6ecc) 13 0x400c6d52 (start_process+0x1a6 [process.c:391] in libntdll.so) (ebp=405e6f30) 14 0x400ca559 (SYSDEPS_DoCallOnStack+0x25(func=0x400c6bac, arg=0x0) [sysdeps.c:173] in libntdll.so) (ebp=405e6ff0) 15 0x400ca603 (SYSDEPS_CallOnStack+0x2f in libntdll.so) (ebp=bffff660) 16 0x400ca6ad (SYSDEPS_SwitchToThreadStack+0x95(func=0x400c6bac) [sysdeps.c:236] in libntdll.so) (ebp=bffff69c) 17 0x400c70de (PROCESS_InitWine+0x1ce(argc=0x1, argv=0xbffff734, win16_exe_name=0x804c620, win16_exe_file=0x804c724) [process.c:519] in libntdll.so) (ebp=bffff6b4) 18 0x0804b1ee (Letext [main.c] in wine) (ebp=bffff6cc) 19 0x4027bcbe (NTDLL.DLL.sqrt+0x3262e in libc.so.6) (ebp=bffff708) 20 0x08049021 (_start+0x21 in wine) (ebp=00000000) it (simply) deadlocks because the new window management code (written by Alexandre), (rev 1.5 of dlls/x11drv/window.c, change log entry Create an X window for every window, including children. Fixed non-client rectangle calculations in managed mode. Added support for icon window in managed mode. ) does call GDI functions (here GetIconInfo) while the x11drv critical section is held, which shouldn't be the case let's assume fixing it is now on Alexandre's TODO list ;-) A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

Re: convert 16bit comm stuff to use handles
by Ove Kaaven July 2, 2001

July 2, 2001

On Sat, 30 Jun 2001, Mike McCormack wrote: > this is the first step in cleaning up the 16bit comm code. > This patch is untested, so have a look, and give it a go! > - ptr->s_read = SERVICE_AddObject( FILE_DupUnixHandle( ptr->fd, > - GENERIC_READ | SYNCHRONIZE ), > + ptr->s_read = SERVICE_AddObject( ptr->handle, > comm_notification, > (ULONG_PTR)ptr ); Not good... you *must* duplicate the handle (probably with DuplicateHandle) before passing it to SERVICE_AddObject. The SERVICE_Delete will close the handle passed to AddObject, which is bound to cause problems if it's not a duplicate.

2 1

GDI Memory Leak + err:x11drv:X11DRV_SetDeviceClipping Rgn is 0. Please report this.
by adoniz＠hushmail.com July 2, 2001

July 2, 2001

I got these errors while trying to do something a little uncommon: I have been running Halflife from my windows partiton just fine. But I wanted to remove the huge files and replace them with symlinks to a cdrom, but since I can't do symlinks on fat32 (is there a wine hack for this?? i think it would be a great idea!!), I figured I copy the basic files of HL to my linux partition, and symlink the huge pak files. So, I have /mnt/halflife and under there I have some symlinks. I went ahead and added these to my ~/.wine/config [Drive H] "Path" = "/mnt" "Type" = "hd" "Filesystem" = "vfat" Now, as root try running halflife with: cd /mnt/halflife ; wine hl.exe or wine h:\\halflie\hl.exe (or with all the command line options for opengl, software, etc) I get these errors and a SegFault from wine: /mnt/halflife# wine h:\\halflife\\hl.exe -- -console -toconsole -soft -w 640 -win err:local:LOCAL_GetBlock not enough space in GDI heap 0237 for 108 bytes err:region:CombineRgn Invalid rgn=0000 err:x11drv:X11DRV_SetDeviceClipping Rgn is 0. Please report this. err:region:CombineRgn Invalid rgn=0000 err:region:CombineRgn Invalid rgn=0000 err:region:CombineRgn Invalid rgn=0000 err:region:CombineRgn Invalid rgn=0000 Segmentation fault whatever:/mnt/halflife# err:ntdll:RtlpWaitForCriticalSection Critical section 0x4065da54 wait timed out, retrying (60 sec) fs=0257 Running notepad.exe from /mnt/ works just fine. So something else is happening here... Email me if you need more info thanks Free, encrypted, secure Web-based email at www.hushmail.com

2 1

Re: Re: rebar trouble with WinZip 8.0
by Mike McCormack July 2, 2001

July 2, 2001

Hi Guy, Yep, that does it. Thanks, Mike Original message from: "Guy L. Albertelli" <galberte(a)neo.lrun.com> > >Hi Mike, > >See if the attached patch fixes your problem. It seems to do it for me. > >Thanks for finding this. > >Guy > >-----Original Message----- >From: Mike McCormack <mike_mccormack(a)start.com.au> >To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> >Date: Thursday, June 28, 2001 10:46 PM >Subject: rebar trouble with WinZip 8.0 > > >>Hi, >> >>WinZip 8.0 has a toolbar. It used to show all the toolbar buttons, but >>it seems to have a problem now, since only the LHS >>button is shown. Some debug output below. >> >>Mike ------------------------------------------ mailto:Mike_McCormack(a)looksmart.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

opengl32.dll works, but how about opengl.dll
by adoniz＠hushmail.com July 1, 2001

July 1, 2001

Another (small I think) problem I noticed is that some braindead Windows apps (yes, 32bit, Windows 9x) are linked against opengl.dll as opposed to opengl32.dll !! But this makes wine refuse to run them because it doesn't "recognize" that the application needs the built-in openGL support. So how would one go about fixing this, so that Wine will use the builtin OpenGL support not just for openg32.dll but also for opengl.dll ? thanks in advance ps. please email me as i am not subscribed to the ML Free, encrypted, secure Web-based email at www.hushmail.com

1 0

Re: rebar trouble with WinZip 8.0
by Guy L. Albertelli July 1, 2001

July 1, 2001

Hi Mike, See if the attached patch fixes your problem. It seems to do it for me. Thanks for finding this. Guy -----Original Message----- From: Mike McCormack <mike_mccormack(a)start.com.au> To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> Date: Thursday, June 28, 2001 10:46 PM Subject: rebar trouble with WinZip 8.0 >Hi, > >WinZip 8.0 has a toolbar. It used to show all the toolbar buttons, but >it seems to have a problem now, since only the LHS >button is shown. Some debug output below. > >Mike > > >mike(a)linux:~/c > wine Program\ Files/WinZip/WINZIP32.EXE >Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: >x11drv: Warning: $DISPLAY variable ignored, using ':0.0' specified in >config file >.. >trace:rebar:REBAR_AdjustBands start=0, end=0, max x=550, max y=61 >trace:rebar:REBAR_AdjustBands Phase 1 band 0, (0,0)-(69,61), orig x=0, >xsep=0 >trace:rebar:REBAR_AdjustBands Phase 2 band 0, (0,0)-(69,61), orig x=0, >xsep=0 >err:rebar:REBAR_AdjustBands Serious problem adjusting row 1, start >band 0, end band 0 >trace:rebar:REBAR_AdjustBands start=0, end=0, max x=561, max y=61 >trace:rebar:REBAR_AdjustBands Phase 1 band 0, (0,0)-(69,61), orig x=0, >xsep=0 >trace:rebar:REBAR_AdjustBands Phase 2 band 0, (0,0)-(69,61), orig x=0, >xsep=0 >err:rebar:REBAR_AdjustBands Serious problem adjusting row 1, start >band 0, end band 0 >.. >fixme:shell:SHGetFileInfoA set icon to shell size, stub >fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray >0x405a6a74 >mike(a)linux:~/c > > > >------------------------------------------ >mailto:Mike_McCormack(a)looksmart.com.au >ph +82 16 430 0425 > >__________________________________________________________________ >Get your free Australian email account at http://www.Looksmart.com.au > > >

1 0

Re: convert 16bit comm stuff to use handles (fwd)
by lawson_whitney＠juno.com July 1, 2001

July 1, 2001

OOPS, this was meant for wine-devel, not wine-patches. Sorry! On Sat, 30 Jun 2001, Mike McCormack wrote: > > Hi, > > this is the first step in cleaning up the 16bit comm code. > This patch is untested, so have a look, and give it a go! > > Mike > Good day! Turns out the app will still run with --winver win31 (I swear it worked with --winver nt40 before, I think :-) but with the patch, it can't find the modem with both hands and a flashlight. Seems not to see input. comm trace is attached. Let me know if (which) additional traces would help. Lawson ---blah---

1 0