August 2001 - Wine-Devel - list.winehq.org

Re: Extra space at bottom of toolbar
by Guy L. Albertelli Aug. 16, 2001

Aug. 16, 2001

-----Original Message----- From: Bobby Bingham <uhmmmm(a)ameritech.net> To: Wine Devel <wine-devel(a)winehq.com> Date: Thursday, August 16, 2001 12:28 AM Subject: Extra space at bottom of toolbar >Has anyone else seen this... In WinZip 8.0 (I don't know about other >versions/software), there are about 6 extra pixels at the bottom of the >toolbar below the buttons. Does anyone know what's causing this? I can look >into it if I get some time, but I was wondering if anybody knew. > >Bobby Bingham > > The current CVS shows the following differences between the builtin control and the native one: 1. Button top-left corner is 2 pixels too high. 2. Button is 2 pixels too short. 3. Background bar is 2 pixels too wide. This gives the 6 pixels you noticed. Items 1 & 2 are definitely within the toolbar.c. Item 3 may be in either toolbar or rebar. I need to work on moving screenshots from Win to Linux for comparison. Guy

1 0

Re: Protocol for adding FIXMEs
by Alexandre Julliard Aug. 16, 2001

Aug. 16, 2001

"Bill Medland" <medbi01(a)accpac.com> writes: > However I am occasionally frustrated by the number of times I see the same > FIXME (e.g. the pthread_rwlock* and the "kill other threads" one). I also > recognise from posts that these disconcert newbies whereas after a couple > of weeks one gets used to them. > > So maybe it is better to use FIXME comments where one knows that something > is wrong but it doesn't seem to matter. FIXME macros should be used in cases where we know something is wrong but we don't expect this part of the code to ever get used. This way if some app triggers the wrong code we can hear about it. It doesn't make sense to add FIXME output to parts of the code we know are going to be called, it just generates noise; a comment is much better in this case. > (For example the WM_NCCALCSIZE message uses wParam as a Boolean value and > if it is TRUE then the lParam no longer points to a simple rectangle but to > a structure whose first element is a rectangle. Very little if any code > handles that case explicitly.) I don't think this specific case is a FIXME at all. Apps are allowed to ignore the extra information if they don't have any use for it. -- Alexandre Julliard julliard(a)winehq.com

1 0

_CheckNotSysLevel (was: patch.py?id=997918367324549717828631)
by lawson_whitney＠juno.com Aug. 16, 2001

Aug. 16, 2001

On Thu, 16 Aug 2001 whit(a)giftie.alien.org wrote: > Good day! > > I can't remember that I've ever seen the fixme that was here before, > but I'll check again when I send this. > Is that a new fixme? I reversed just this patch and there are more of this fixme than any other. Hope the backtrace I sent before is useful. Regards, Lawson ---oof--- ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Re: _CheckNotSysLevel Patch
by Alexandre Julliard Aug. 16, 2001

Aug. 16, 2001

Bobby Bingham <uhmmmm(a)ameritech.net> writes: > winedbg winzip32 > ... > err:win32:_CheckNotSysLevel Holding lock 0x40800fe8 level 3 > err:win32:_CheckNotSysLevel Holding lock 0x40800fe8 level 3 > Stopped on breakpoint 1 at 0x004677fa (WINZIP32.EXE.EntryPoint in C:\Program > Files\WinZip\WINZIP32.EXE) If you run under winedbg directly the CheckNotSysLevel breakpoints are ignored, and it only stops at the program entry point; and the backtrace there is useless. Please run it under wine and let it start the debugger by itself when encountering the first CheckNotSysLevel, then you should get a proper backtrace. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: _CheckNotSysLevel Patch
by Alexandre Julliard Aug. 16, 2001

Aug. 16, 2001

Bobby Bingham <uhmmmm(a)ameritech.net> writes: > err:win32:_CheckNotSysLevel Holding lock 0x40800fe8 level 3 > err:seh:start_debugger Couldn't start debugger (winedbg 134640360 52) (2) > Read the Wine Developers Guide on how to set up winedbg or another debugger > > if the debugger is set up, I can continue, and and it works just fine. Before the continue, could you please do a backtrace and mail it to me? Thanks. -- Alexandre Julliard julliard(a)winehq.com

2 1

Protocol for adding FIXMEs
by Bill Medland Aug. 16, 2001

Aug. 16, 2001

What do people think? I seem to have a knack for finding things that are probably going to need fixing at some point but for which I do not have time or knowledge currently. My first temptation is to add a FIXME macro in the code directly. However I am occasionally frustrated by the number of times I see the same FIXME (e.g. the pthread_rwlock* and the "kill other threads" one). I also recognise from posts that these disconcert newbies whereas after a couple of weeks one gets used to them. So maybe it is better to use FIXME comments where one knows that something is wrong but it doesn't seem to matter. (For example the WM_NCCALCSIZE message uses wParam as a Boolean value and if it is TRUE then the lParam no longer points to a simple rectangle but to a structure whose first element is a rectangle. Very little if any code handles that case explicitly.) I know that the manual (wine-devel 8.0) says to add FIXMEs I am concerned that this could lead to ridiculously large traces that hide the important stuff (to say nothing of upsetting timing) Any other views? Bill

1 0

RE: Toolbar background error
by Medland, Bill Aug. 16, 2001

Aug. 16, 2001

I'll handle it. I have this horrible feeling its the compiler again (2.96-85; RedHat 7.1). (It seems to be a side-effect of DPtoLP!!??) Bill > -----Original Message----- > From: Guy L. Albertelli [SMTP:galberte(a)neo.lrun.com] > Sent: Wednesday, August 15, 2001 7:30 PM > To: Bill Medland > Cc: Wine Devel > Subject: Re: Toolbar background error > > > -----Original Message----- > From: Bill Medland <medbi01(a)accpac.com> > To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> > Date: Wednesday, August 15, 2001 4:39 PM > Subject: Re: Toolbar background error > > > >> > >> > >In case you haven't found it yet it is in windows/defwnd.c; the change > made > >between 1.57 and 1.58. Are you going to handle it? > > > >Bill > > > > > Bill, > > Great job in tracking it down. I probably won't get to having time till > Friday evening. If you see the problem and know the fix, by all means go > and > fix it. Otherwise I will look into this Friday. > > Thanks again, > Guy

3 2

patch.py?id=997918367324549717828631
by lawson_whitney＠juno.com Aug. 16, 2001

Aug. 16, 2001

Good day! I guess native riched32.dll does something nasty to provoke the new DbgBreakPoint in _CheckNotSysLevel. Builtin riched32 doesn't, of course, but then the app won't start. I can't remember that I've ever seen the fixme that was here before, but I'll check again when I send this. I've attached a backtrace. I'd appreciate some guidance on what else might be useful, or maybe a pointer to some doco on critical sections in Wine, even it is in .sgml, .c or .h in case I have to debug it myself. Regards, Lawson

1 0

Wine call graph; wineserver; the "big picture"
by Phillip Schmitz Aug. 16, 2001

Aug. 16, 2001

[I mistakenly posted this to comp.emulators.ms-windows.wine / wine-users rather than here. Thanks to eric pouech for his reply there. Sorry if you've already seen this there] Hi, I've been lurking for a while now with a view to starting work on wine - specifically COM and DCOM. I know some people have started some work and there might be some patent issues with COM at least - so maybe DCOM is a better bet (I had the possibly naive idea of implementing COM via DCOM - it would be almost transparent, slower but less "dangerous"). I've read most of the developer docs and some relevant source but I'm still having problems grokking the interrelationships between different parts of wine and the role(s) of wineserver. I have a general understanding of Win32 from a programatic point of view rather than wine's implementation details. While I'm quite willing to "read the source" there's rather a lot of it :) and rather deep dependencies (even with tags one jumps around for a while trying to understand what does what). Does anyone have a call graph for wine or a (decent, open-source) program for making one. I've considered Source-Navigator but it seems like the required database would be twice the size of the wine source! Since (D)COM affects many parts of function and message handling and process address space tampering I considered the less ambitious project of fixing up (Net)DDE first - at least then the all-important Hearts will run networked. Is anyone actively working on that (the source has sporadic updates)? I don't want to start hacking off on a tangent. The different behaviours of win9x and NT will also be a problem since I don't have a real NT installation Also, what do people use in terms of test-suites? custom win32 apps? free/shareware? While I have quite a few larger apps like Office etc I imagine it's better to try smaller, more specific apps at first. I want to do comparisons and communication with Win95/8 in VMWare and don't really want to _purchase more Win32 apps_ for testing! Thanks for any experience or insight you might share. Phillip

6 5

Extra space at bottom of toolbar
by Bobby Bingham Aug. 16, 2001

Aug. 16, 2001

Has anyone else seen this... In WinZip 8.0 (I don't know about other versions/software), there are about 6 extra pixels at the bottom of the toolbar below the buttons. Does anyone know what's causing this? I can look into it if I get some time, but I was wondering if anybody knew. Bobby Bingham

2 1

_CheckNotSysLevel Patch
by Bobby Bingham Aug. 16, 2001

Aug. 16, 2001

Ever since _CheckNotSysLevel was implemented in the CVS yesterday, I can't run any programs if the debugger isn't set up. I get: ... err:win32:_CheckNotSysLevel Holding lock 0x40800fe8 level 3 err:seh:start_debugger Couldn't start debugger (winedbg 134640360 52) (2) Read the Wine Developers Guide on how to set up winedbg or another debugger if the debugger is set up, I can continue, and and it works just fine. Somehow I don't recall windows not running programs without setting up the debugger :-) Bobby Bingham

1 0

Re: Toolbar background error
by Guy L. Albertelli Aug. 15, 2001

Aug. 15, 2001

-----Original Message----- From: Bill Medland <medbi01(a)accpac.com> To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> Date: Wednesday, August 15, 2001 4:39 PM Subject: Re: Toolbar background error >> >> >In case you haven't found it yet it is in windows/defwnd.c; the change made >between 1.57 and 1.58. Are you going to handle it? > >Bill > Bill, Great job in tracking it down. I probably won't get to having time till Friday evening. If you see the problem and know the fix, by all means go and fix it. Otherwise I will look into this Friday. Thanks again, Guy

1 0

Re: Toolbar background error
by Guy L. Albertelli Aug. 15, 2001

Aug. 15, 2001

-----Original Message----- From: Bill Medland <medbi01(a)accpac.com> To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> Date: Wednesday, August 15, 2001 1:58 PM Subject: Re: Toolbar background error > >BTW since you are working on controls I thought I'd better let you know >this. > >I intend at some point working on the ListView control's handling of the >text in the large icon view unless someone gets there first. However it >will require corrections to DrawText/DrawTextEx's handling of the >EDIT_CONTROL style flag first (which affects the word wrapping/cutting of >long words in multiline stuff). In addition from a quick experiment I >think that quite a lot of work will be required within listview.c because >it appears to be unstably dependent on the fact that the size of the text >portion is currently constant; the clipping and repainting falls to pieces >when the size of the text depends on whether the icon is selected or not >etc. > >I thought I'd better let people know in case they get there before me. > Sounds great!! Have at it!! Guy

1 0

Re: toolbar
by Guy L. Albertelli Aug. 15, 2001

Aug. 15, 2001

-----Original Message----- From: Mike McCormack <mike_mccormack(a)start.com.au> To: galberte(a)neo.lrun.com <galberte(a)neo.lrun.com> Date: Wednesday, August 15, 2001 8:11 PM Subject: Re: toolbar >Hey Guy, > >i updated from CVS thismorning, and saw some messages in wine-devel >about the toolbar, so did a quick test with WinZip 8. > >Everything seems to be fine! There are still some minor drawing >problems, but they were there before. They are: > >* button sometimes remains in the clicked state after i click it... >for example after clicking on the Open button in WinZip, the Open File >dialog appears, but the Open button is still in the clicked state. It >remains that way until i move the mouse over it again. Yes , I have seen this also. I am not sure what the problem is or even where. Possibilities: - WM_MOUSELEAVE not always getting generated. - Toolbar processing of WM_MOUSELEAVE is not 100% correct. - Something totally else. > >* sometimes after the tooltips disappear, the rectangle around the >edge of the button is not redrawn, so there is a "mark" where the >tooltip was. > I have not seen this, but I haven't looked for it. Thanks, Guy

1 0

Re: Toolbar background error
by Guy L. Albertelli Aug. 15, 2001

Aug. 15, 2001

Bill, Can you try the current CVS and let me know how that works. I have been doing some work with Toolbar, Rebar, etc. and the background drawing was one of the problems. If it still has problems, let me know the application and I will work on it. Thanks, Guy -----Original Message----- From: Bill Medland <medbi01(a)accpac.com> To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> Date: Wednesday, August 15, 2001 11:12 AM Subject: Toolbar background error >Has anyone else noticed this? Is anyone already looking into this? > >Sometime during July something was changed that resulted on my setup >failing to draw the toolbar background properly (it leaves the bottom third >transparent). > >Since I have had previous problems with this setup (due to some sort of gcc >bug) I thought I'd check. > >Bill > > > > >

2 2

RE: Toolbar background error
by Medland, Bill Aug. 15, 2001

Aug. 15, 2001

I am just compiling up today's Wine; it was certainly there yesterday. As far as I can tell it crept in between 20010726 and 20010731 (dates in the WINE cvs itself). I will send you a test executable that shows the problem. Let me know how it appears on yours. Bill > -----Original Message----- > From: Guy L. Albertelli [SMTP:galberte(a)neo.lrun.com] > Sent: Wednesday, August 15, 2001 10:01 AM > To: Bill Medland > Cc: Wine Devel > Subject: Re: Toolbar background error > > Bill, > > Can you try the current CVS and let me know how that works. I have been > doing some work with Toolbar, Rebar, etc. and the background drawing was > one > of the problems. > > If it still has problems, let me know the application and I will work on > it. > > Thanks, > > Guy > -----Original Message----- > From: Bill Medland <medbi01(a)accpac.com> > To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> > Date: Wednesday, August 15, 2001 11:12 AM > Subject: Toolbar background error > > > >Has anyone else noticed this? Is anyone already looking into this? > > > >Sometime during July something was changed that resulted on my setup > >failing to draw the toolbar background properly (it leaves the bottom > third > >transparent). > > > >Since I have had previous problems with this setup (due to some sort of > gcc > >bug) I thought I'd check. > > > >Bill > > > > > > > > > >

1 0

Transparent child windows
by Timo Kujala Aug. 15, 2001

Aug. 15, 2001

Hi, Some time ago I posted a problem with M$ 32-bit terminal server client, as it did not paint it's window. Finally I got some time to look into this a bit more and found out following: The terminal server client creates (among other windows) two child windows, "Input Capture Window" and "Output Painter Window" (in that order). Input capture window is specified as transparent and it is laid over the output painter window so that the actual image is painted in the output painter window and input capture window just receives mouse clicks and keyboard input. The problem is that the input capture window is not really transparent. Output painter window is behind it and therefore output is never seen. (I was able to find this out by moving input capure window away from the view by modifying code in createwindow-call in win.c, but then mouse won't work in terminal server client) Any fixes for this?

1 0

Toolbar background error
by Bill Medland Aug. 15, 2001

Aug. 15, 2001

Has anyone else noticed this? Is anyone already looking into this? Sometime during July something was changed that resulted on my setup failing to draw the toolbar background properly (it leaves the bottom third transparent). Since I have had previous problems with this setup (due to some sort of gcc bug) I thought I'd check. Bill

1 0

Re: printing AND memory
by Richard Canada Aug. 15, 2001

Aug. 15, 2001

> Richard Canada wrote: > >>trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' >>err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for >>printer 'Wine PostScript Driver' >>trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) >>trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' >>err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for >>printer 'Wine PostScript Driver' >>trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) >>fixme:pthread_kill_other_threads_np >> >> > > It looks like you haven't specified a PPD file for your printer. The > right method for configuring this varies, depending on how you've > configured your printer, so I need to know how you set up your printer. > -- > ======================================================================== > Ian Pilcher ian.pilcher(a)home.com > ======================================================================== This is how I have my printer set up: (snip from my wine config file) [afmfiles] "file<n>" = "/usr/share/fonts/afms/adobe/pagd8a.afm" [psdrv] "ppdfile" = "/windows/wine/TEMP/ADOBE/HP/HP4PLUS6.PPD" [serialports] "Com1" = "/dev/ttyS0" "Com2" = "/dev/ttyS1" "Com3" = "/dev/ttyS2" "Com4" = "/dev/modem" [parallelports] "Lpt1" = "/dev/lp0" [ppdev] ;; key: io-base of the emulated port ;; value : parport-device{,timeout} ;; timeout for auto closing an open device ( not yet implemented) ;"378" = "/dev/parport0" ;"278" = "/dev/parport1" ;"3bc" = "/dev/parport2" [spooler] "FILE:" = "tmp.ps" "LPT1:" = "|lp -ddevelp -tRICHARD" "LPT2:" = "|gs -sDEVICE=bj200 -sOutputFile=/tmp/fred -q -" "LPT3:" = "/dev/lp3" I have set up the win.ini file correctly, here is the file: [devices] Wine PostScript Driver=WINEPS,LPT1: [windows] device=Wine PostScript Driver,WINEPS,LPT1: [PrinterPorts] Wine PostScript Driver=WINEPS,LPT1: BTW, I am using LPRng on my RedHat 7.1 box. I have no local printers, only network printers that I print to through a print server. Any more suggestions, I would appreciate it. Regards, Richard

1 0

wine server
by Mike McCormack Aug. 15, 2001

Aug. 15, 2001

Hi Phillip, The wineserver does the job of the Windows NT kernel in wine. Here's a summary of what i've worked out about the wineserver: * the wineserver is responsible for all system level synchronization of wine processes, and maintaining integrity of handles * the wineserver is the sole repository for all HANDLE data in the wine process group. * wineserver communicates with each wine process thru a socket and shared memory. There is one socket and one shared memory area per wine process. * the main task of wineserver is a loop which polls on all the wine process sockets, and handles timeouts. * the wineserver processes requests one by one (it is a single thread). * each request is triggered by the wine process writing to its socket, and ended when the wineserver writes back to the socket. During the request, the wine process is effectively stopped. * request data may be read to or written from the shared memory, but the shared memory is not used for synchronization. Synchronization is maintained solely by socket reads and writes. * the wineserver should end each request before processing the next * the wineserver must never wait for or depend upon any wine processes. All wine processes must be assumed to be unstable and unreliable. (even if they're not) * the wineserver design is reliable, but rather slow due to all the context switching required by each request. David Howells made an effort to turn it into a Linux kernel module... he hasn't finished yet. hope that's accurate and helpful... Mike ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

Unable to use RegisterClass(&WndClass);
by Craig Chandler Aug. 14, 2001

Aug. 14, 2001

when i use the RegisterClass(&WndClass); under wine the call fails. I'm using it to sub class the button class. Does wine not support this? Interdynamics Web Page : http://www.interdynamics.com

2 8

printing AND memory
by Richard Canada Aug. 14, 2001

Aug. 14, 2001

Does anyone know why I am getting an error message about "Insufficient memory" when I try to print from wine? I can see the printer is there, but I cannot print. I am running Lotus Notes 5.0.6. Thanks Richard

3 4

Re: Solaris X86 mmap...
by Alexandre Julliard Aug. 14, 2001

Aug. 14, 2001

Robert Lunnon <bob(a)yarrabee.net.au> writes: > After that point I can't find any reference to this patch, it certainly > hasn't made it into the CVS yet ? > > Does anyone know the outcome of this work, or am I the only Solaris X86 > user out there :-) Last I heard it needed someone to test it on Solaris x86, but nobody ever did. So yes it seems you may be the only user out there... If you tested it and it works for you, please submit it to wine-patches. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Advice please. adding a MODULE_LoadLibraryExA argument
by Alexandre Julliard Aug. 14, 2001

Aug. 14, 2001

"Bill Medland" <medbi01(a)accpac.com> writes: > The way I would prefer would be to add an argument to all the functions in > the recursion and use that to carry the name around. > MODULE_LoadLibraryExA > PE_LoadLibraryExA > ELF_LoadLibraryExA > PE_CreateModule > fixup_imports > > Any objections? This won't work for builtin dlls, you cannot pass an argument into dlopen(). This is not a problem for builtins themselves since they are not searched the same way, but it may break if a builtin imports a native dll. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: SNOOP: How to find out if an DLL entry is a DATA reference?
by Alexandre Julliard Aug. 14, 2001

Aug. 14, 2001

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > However I like to ask if there are other methods of distinguishing DATA and > function references? Could the PE loader perhaps know? Or can we perhaps > protect our snoop entries from being read as data and catch those exceptions? > Any other idea? I don't think there's any way to make snoop 100% reliable, the PE file simply doesn't contain enough information. This is the reason we have to build special tables in the builtin dlls for relay debugging. -- Alexandre Julliard julliard(a)winehq.com

1 0