August 2001 - Wine-Devel - list.winehq.org

x11drv port to win32 possible ?
by Rudi De Vos Aug. 9, 2001

Aug. 9, 2001

HI, Has anyone already try to compile it with VC++. Using the win32X11 port from http://sources.redhat.com/win32-x11/ and microsoft visual C++ 6.0 I was able to compile some parts: tsx11 and wineclipsrv.exe. The intention is to create a dll that exports the winapi graphic functions for X11: X11DRV_CreateWindow,X11DRV_InitKeyboard,.. see x11drv.spec. 1)If we can compile that dll, can we recompile a win32 app so it runs on a pc and display on a X-terminal? 2)Can multiple users run the same app on win95/98 and display on diff X-terminals? thxs Rudi

1 0

Re: Rewrite AFM parsing code
by Dmitry Timoshkov Aug. 9, 2001

Aug. 9, 2001

"Ian Pilcher" <ian.pilcher(a)home.com> wrote: > Log message: > Ian Pilcher <ian.pilcher(a)home.com> > WINEPS: rewrite and separate AFM parsing code (no more [afmfiles]) [...] > +inline static BOOL IsWinANSI(LONG uv) > +{ > + if ((0x0020 <= uv && uv <= 0x007e) || (0x00a0 <= uv && uv <= 0x00ff) || > + (0x2018 <= uv && uv <= 0x201a) || (0x201c <= uv && uv <= 0x201e) || > + (0x2020 <= uv && uv <= 2022)) ^^^^ Shouldn't it be 0x2022? -- Dmitry.

2 1

Re: Remove redundant implementations
by Alexandre Julliard Aug. 9, 2001

Aug. 9, 2001

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Remove redundant implementation of __get_cs,__get_ds,__get_es, > __get_fs,__get_gs,__get_ss,__set_fs,__set_gs. These are here to support compilers that don't have gcc-style inline assembly. This is admittedly a theoretical issue at this point, but there shouldn't be any harm in keeping them around just in case. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Remove redundant implementations
by Alexandre Julliard Aug. 9, 2001

Aug. 9, 2001

"Dmitry Timoshkov" <dmitry(a)baikal.ru> writes: > Perhaps they should be protected from compiling under gcc? Why would you want that? They could conceivably be useful even with gcc in case it decides not to use the inline version. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: CS_PARENTDC with WS_CLIPSIBLINGS
by Alexandre Julliard Aug. 8, 2001

Aug. 8, 2001

Ladislav Sladecek <lsla(a)post.cz> writes: > The function is called like this: > > 0806c1c8:Call GDI.38: ESCAPE(0x0000,0x000d,0x0000,0x00000000,0657:e8f4) ret=0ff7:4428 ds=1207 > > The in_data pointer is null but the code assigns to it, thats why it > crashes. I think that the result should be assigned to the output parameter. Yes of course, stupid typo on my part. Thanks for spotting it. -- Alexandre Julliard julliard(a)winehq.com

1 0

Some strange code in configure.in
by Lionel Ulmer Aug. 8, 2001

Aug. 8, 2001

Hi all, By looking at some guy's config.log, I found out this in configure.in : dnl Check for GLU32 library. AC_CHECK_LIB(GLU,glBegin, X_PRE_LIBS="$X_PRE_LIBS -lGLU" GLU32FILES='$(GLU32FILES)' GLU32_DLL=glu32 ,, $X_LIBS $X_PRE_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS ) My question is why do we test for 'glBegin' in GLU and not something better like, say, 'gluLookAt' ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

Re: CS_PARENTDC with WS_CLIPSIBLINGS
by Alexandre Julliard Aug. 8, 2001

Aug. 8, 2001

Ladislav Sladecek <lsla(a)post.cz> writes: > 2) The real reason for the crash is that the application calls Escape16 with > hdc equal to 0 and function equal to GETPRINTINGOFFSET. I do not understand > why, they did not even start to print. Maybe, this is an undocumented windows > function? After I temporarily disabled Escape16, the application began to > work. It's not supposed to crash even if the hdc is invalid. Do you have a backtrace of the crash? > 4) To fix Escape16, the 16bit printer driver is necessary. I need printing > either. I will try to work on it if you just give me a piece of advice. I think > that two ways are possible: > > A) To use the static table and to modify create_driver to work with it. > > B] To create a 16bit printer driver DLL similarly to the 32bit drivers. The static table is OK, but you'll need to add a number of functions that were done by escapes before (AbortDoc, StartDoc, etc.) And of course there is still the GDI lock issue so I don't know if you can actually print something even if you fix the initialisation. -- Alexandre Julliard julliard(a)winehq.com

2 1

Eliminating [afmfiles] from .wine/config
by Ian Pilcher Aug. 8, 2001

Aug. 8, 2001

Anyone see any reason not to? [afmdirs] has been around for quite a while now. -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

Re: CS_PARENTDC with WS_CLIPSIBLINGS
by Alexandre Julliard Aug. 7, 2001

Aug. 7, 2001

Ladislav Sladecek <lsla(a)post.cz> writes: > Maybe the printer driver never gets initialised? (Just a stupid speculation). Not stupid at all, actually the 16-bit driver support is temporarily broken (not that it really worked well before anyway). It shouldn't be too hard to fix, but I haven't had time yet. Volunteers are welcome... -- Alexandre Julliard julliard(a)winehq.com

2 1

Implementing Winsock2 Function
by Nick Bauer Aug. 7, 2001

Aug. 7, 2001

Hello, I was working with Andreas Mohr on a program I was trying to get running under Wine, and he suggested that I email this list and ask for help to get an un-implemented function implemented. My application is a software program used to control our phone system. The error is: Unhandled exception: unimplemented function ws2_32.WSALookupServiceBeginA called in 32-bit code (0x407be056). In 32-bit mode. 0x407be056 (__wine_unimplemented+0x56 [ws2_32.spec.c:40] in WS2_32.DLL): jmp 0x407be050 (__wine_unimplemented+0x50 [ws2_32.spec.c:40] in WS2_32.DLL) 43 void __wine_stub_ws2_32_WPUCompleteOverlappedRequest(void) { __wine_unimplemented("WPUCompleteOverlappedRequest"); } I have tried using the native WS2_32 DLL and then the program no longer crashes, but it looks like its attempting to connect to the server, but never gets connected. I set up iptables to log all packets going to that server out eth0, but it never catches any packets. Any help would be greatly appreciated, as I have no knowledge of coding. Also, I am not on the list, so please include my email on any responses. Thanks a lot, -Nick

1 0

printing with wine
by Ricahrd Canada Aug. 7, 2001

Aug. 7, 2001

Does anybody have complete instructions on how to set up a printer to use in wine? I have tried all of the suggestions with add entries to the wine.conf file, using the internal driver, etc. I cannot seem to get wine to see any printers. I use lprng through a print server, so I do not have any local printers attached. Can anyone help?? Richard

1 0

printing in wine
by richard.canada＠mrlinternational.com Aug. 7, 2001

Aug. 7, 2001

Does anybody have complete instructions on how to set up a printer to use in wine? I have tried all of the suggestions with add entries to the wine.conf file, using the internal driver, etc. I cannot seem to get wine to see any printers. I use lprng through a print server, so I do not have any local printers attached. Can anyone help?? Richard

1 0

AbiWord 0.9 problems even with latest Wine from CVS
by Dan Kegel Aug. 7, 2001

Aug. 7, 2001

The AbiWord win32 0.9 problems I described recently on wine-users with Codeweavers Preview 4 also happen with the latest Wine built from CVS this afternoon. These problems don't happen when run on Windows, nor when running the native Linux version; they therefore appear to be Wine bugs. Details at http://www.kegel.com/wine/abiword0.9/readme.html I stand ready and willing to apply and test patches, but might not have time to write any fixes myself. Thanks, Dan -- "I have seen the future, and it licks itself clean." -- Bucky Katt

2 4

Re: named critical sections
by Andreas Mohr Aug. 7, 2001

Aug. 7, 2001

On Tue, Aug 07, 2001 at 04:15:41PM +0200, Andreas Mohr wrote: > Hi all, > > this patch implements *names* for the most important critical sections. > > I simply grew tired of constantly having to look up the crst addresses > in winedbg whenever there was some crst timeout. > Yeah, I know, that patch is slightly weird/dirty, but it's useful. Yup, this patch is weird: > + TRACE("#1\n"); > + TRACE("#2: %p\n", obj); Alexandre, please apply it without this crap ;-) (hmm, I really thought I had properly checked it) -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0

Re: CoGetClassObject
by r.maurizzi＠gvs.it Aug. 7, 2001

Aug. 7, 2001

[Notes 5.0.8] > The only error message the installer came up with was a dialog saying > "AddFolderIcon" failed. The same here. > I had also understood that there was now a facility to add programs that > would have installed themselves into the Windows startup menu into the KDE > menu structure. I am running KDE 2.2 from CVS if it matters. But nothing > appeared. Had I understood wrong, or do I need to try to do some > debugging? Maybe not for all the InstallShield versions: it worked for me for the game "I-War" (quite old... DirectX 5 I think), with KDE 2.1 Or it could be that the installer crash doesn't help in getting the icon loaded... :-) I didn't had time to look into this feature. Ciao, Roberto.

3 2

CoGetClassObject
by Daniel Walker Aug. 7, 2001

Aug. 7, 2001

I was thinking of ways to get the CLSCTX_LOCAL_SERVER option working in wine. The only program that uses it , that I know of, is installshield v6 .. I pretty sure some other people are working on this, but I don't know that status. (Anyone care to update me?) There is another problem. It's with the TypeLib information in the IKernel.exe that comes with InstallShield v6. The TypeLib information is encoded somehow, any ideas? I was able to get around that problem because installshield also looks for type information in "ikernel.tlb" . So I was able to create a .tlb that worked. I also used the reaktivate typelib patch so the typelib info gets put into the registry. So the way I understand it is that when CoGetClassObject is called Wine is suppose to , in this case, execute IKernel.exe . Then IKernel.exe will CoRegisterClassObject on all needed objects .. One problem is that the registered class object list isn't shared between the two processes, so we would need to move that list into the wine server (Right?) .. Then we would also need to send an instance of the class object to the Wine server (Yeah??) .. Following that road seems to lead to some messy address translations for DLL's and whatever else.. Since we have complete control over how IKernel.exe is run, how would we get the two processes to share memory? Maybe have IKernel.exe execute in a thread? IKernel.exe doesn't do anything but register it's class objects .. Would it be possible to treat IKernel.exe as a DLL then run CoRegisterClassObject for it? Daniel Walker

8 13

Re: CoGetClassObject
by David.Goodenough＠dga.co.uk Aug. 7, 2001

Aug. 7, 2001

Curiously (on the subject of InstallSheild) I have just successfully installed the latest (5.0.8) Lotus Notes client on a wine system (latest tarball) and the new Lotus installer is InstallSheild based. It ran perfectly EXCEPT that the program would not terminate. The Lotus installer takes over the whole screen, and that went away, but wine never returned to the command line. As far as I could see there were no messages about locks or anything. The only error message the installer came up with was a dialog saying "AddFolderIcon" failed. I had also understood that there was now a facility to add programs that would have installed themselves into the Windows startup menu into the KDE menu structure. I am running KDE 2.2 from CVS if it matters. But nothing appeared. Had I understood wrong, or do I need to try to do some debugging? Ove Kaaven <ovehk(a)ping.uio.no> on 08/07/2001 07:55:41 AM To: Rein Klazes <rklazes(a)xs4all.nl> cc: wine-devel(a)winehq.com (bcc: David Goodenough/DGA/GB) Subject: Re: CoGetClassObject On Tue, 7 Aug 2001, Rein Klazes wrote: > On Tue, 7 Aug 2001 01:12:34 +0200 (CEST), you wrote: > > > > > > > It couldn't get it from the ikernel.exe because I think > > > it's encoded somehow (unicode, MultiByte??). > > > > It doesn't look encoded, it's just different (it's most likely what is > > boasted as the "Typelib 2 Format"). Win2000's stdole32.tlb also uses this > > new format (it has a "SLTG" signature instead of the old "MSFT"). > > > SLTG is the old format, MSFT came later. Wine can (natively) only read > MSFT. Allright, but the most important question remains: who will volunteer to reverse engineer these SLTG typelibs and make Wine able to read them, so I can concentrate on the actual COM marshaling stuff (which is pretty hard enough as it is), so we can finally get those @#&% InstallShields up?

1 0

Re: ownerdrawn button fix
by Alexandre Julliard Aug. 6, 2001

Aug. 6, 2001

Aric Stewart <aric(a)codeweavers.com> writes: > A full fix would be to make sure we never call the paint function > directly. However the only time this seems to actually cause a crash is > with owner drawn. This patch corrected the problem with owner drawn so > that we do not have to retest everything with buttons. This seems to defeat the purpose of having the ODA_* constants. Would it also fix your problem to only do the PAINT_BUTTON when the window is visible? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: (no subject)
by Alexandre Julliard Aug. 5, 2001

Aug. 5, 2001

Ladislav Sladecek <lsla(a)post.cz> writes: > If you run the binary in the Windows, you will see two properly sized > red rectangles on a white background. If you run the same binary in > Wine, you will see only one large red child but no white parent > background. If either the CS_PARENTDC or WS_CLIPSIBLINGS gets removed > from my example, both Windows and Wine give identical results. Yes, there were a number of problems with the flags handling in GetDCEx. I think the behavior with the current CVS should now be correct in all cases; please give it a try. -- Alexandre Julliard julliard(a)winehq.com

3 3

Just out of interest whats this?
by Robert Laverick Aug. 5, 2001

Aug. 5, 2001

FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock what's this, what's causing it and what needs fixing (I'll give it a look if it's needed) or is it just an old error that dosn't really need fixing (I can run almost everything I want to and the all show this error) just intersted Rob

1 1

Window-position bug?
by davep Aug. 4, 2001

Aug. 4, 2001

Here's one I haven't seen before. Build the 'winemine' application in the programs directory and start it running. Click on the smiley-face button (which redraws the window). Every time I press the button the entire window moves down the screen one pixel. Dave

1 0

Re: wine/dlls/oleaut32 typelib.c
by Dmitry Timoshkov Aug. 4, 2001

Aug. 4, 2001

"Alexandre Julliard" <julliard(a)winehq.com> wrote: > Log message: > Malte Starostik <malte(a)kde.org> > Implemented RegisterTypeLib. > > Patch: http://cvs.winehq.com/patch.py?id=99686240431774649117142 + if (res == S_OK && RegCreateKeyExA(key, "FLAGS", 0, NULL, 0, + KEY_WRITE, NULL, &subKey, NULL) == ERROR_SUCCESS) + { + CHAR buf[20]; + /* FIXME: is %u correct? */ + snprintf(buf, strlen(buf), "%u", attr->wLibFlags); ^^^^^^^^^^^ + if (RegSetValueExA(subKey, NULL, 0, REG_SZ, + buf, lstrlenA(buf) + 1) != ERROR_SUCCESS) + res = E_FAIL; + } I'm sorry, it's late a bit. But anyway, instead of strlen() above should be sizeof(). -- Dmitry.

1 0

Re: PATCH: ITypeInfo::Invoke
by Dmitry Timoshkov Aug. 4, 2001

Aug. 4, 2001

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > +static void dump_VarType(VARTYPE vt,char *szVarType) { > + /* FIXME : we could have better trace here, depending on the VARTYPE > + * of the variant > + */ > + switch(vt) { > + case VT_UI1: MESSAGE(szVarType, "VT_UI"); break; ^^^^^^^ > + case VT_I2: sprintf(szVarType, "VT_I2"); break; > + case VT_I4: sprintf(szVarType, "VT_I4"); break; Seems to be a typo. Shouldn't it be sprintf instead of MESSAGE? -- Dmitry.

1 0

RE: What is the @ in the function headers
by Patrik Stridvall Aug. 3, 2001

Aug. 3, 2001

> Quick question. What is the @ in a function header supposed > to contain? > Presumably it is the ordinal in the Dll. Well, functions either has an ordinal or a @. If it has a @ it is means that it doesn't matter what the ordinal is, that winebuild can assign any ordinal it likes for the function. > But what if the > same function has > different ordinals in different copies of the Dll? You mean different versions? Anyway, Wine has no support for it, because none is really needed, because any application that tries to access functions by ordinal that doesn't have a fixed ordinal across DLL version is broken even on Windows.

1 0

What is the @ in the function headers
by Bill Medland Aug. 3, 2001

Aug. 3, 2001

Quick question. What is the @ in a function header supposed to contain? Presumably it is the ordinal in the Dll. But what if the same function has different ordinals in different copies of the Dll? Bill

1 0

Re: Dont allow SetSelectorBase to change into an kernel region
by Alexandre Julliard Aug. 3, 2001

Aug. 3, 2001

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > If I only allow to set the selector base when (selector base + selector > limit) is smaller than 0x8000000, the application goes on and lets me read > an eprom plugged into the Galep3 Programmer. Is the appended fix a right > acceptable? No, it's legal to have selectors covering the entire address space. I'm afraid there is no good solution to this kind of problem. What does the app do under NT or with -winver nt40? -- Alexandre Julliard julliard(a)winehq.com

2 1

Some questions about TB_REPLACEBITMAP
by Marco Bizzarri Aug. 3, 2001

Aug. 3, 2001

Hi all. I'm trying to implement the TB_REPLACEBITMAP message in the comctrl32, and I would like to have some advice about the ImageList structure. The TB_REPLACEBITMAP provides (via the hInst, nID pair) the handle to the old bitmap and the handle to the new bitmap, as well as the number of button in the new bitmap. I think I could use the ImageList_Replace to actually replace the bitmaps. However, the ImageList_Replace function requires a number, which is the first bitmap to be replaced. How can I retrieve this information? For what I can see, once a bitmap has been added to the imagelist, no information about is is stored. I'm doing some tests, using a value (like 0) as the bitmap index, but this is of little help, of course. Any help will be appreciated. Bye Marco

1 0

Some questions about TB_REPLACEBITMAP
by Marco Bizzarri Aug. 3, 2001

Aug. 3, 2001

Hi all. I'm trying to implement the TB_REPLACEBITMAP message in the comctrl32, and I would like to have some advice about the ImageList structure. The TB_REPLACEBITMAP provides (via the hInst, nID pair) the handle to the old bitmap and the handle to the new bitmap, as well as the number of button in the new bitmap. I think I could use the ImageList_Replace to actually replace the bitmaps. However, the ImageList_Replace function requires a number, which is the first bitmap to be replaced. How can I retrieve this information? For what I can see, once a bitmap has been added to the imagelist, no information about is is stored. I'm doing some tests, using a value (like 0) as the bitmap index, but this is of little help, of course. Any help will be appreciated. Bye Marco

1 0

Switching threads in winedbg
by Francois Gouget Aug. 3, 2001

Aug. 3, 2001

Is it possible to switch threads in winedbg? I can use 'walk thread' to see a list of the threads of my application but I could not find how to get a backtrace of one of these other threads. It's not in the Wine Developper's Guide and I could not find it from the source. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In a world without fences who needs Gates?

2 1

Dose wine people hate Solaris?
by EriK W Aug. 3, 2001

Aug. 3, 2001

I have posted my question for compiling Wine in solaris x86 for 2 weeks, seems no anybody even has a bit interest. Do you guys hate solaris? :) I checked almost all the documents and faq, except it mentioned wine works with Solaris, there almost have no other info for it at all. Does anybody has even a suggestion for me? pls don't tell me nuke my solaris. :)

5 8

Re: Documenting functions
by Alexandre Julliard Aug. 2, 2001

Aug. 2, 2001

"Bill Medland" <medbi01(a)accpac.com> writes: > Ay, there's the rub. It isn't our function. It';s Microsoft's function. > Now was it Holub or McConnell that complains about functions having weird > behaviour on certain inputs. IMO Microsoft functions need less documentation than internal ones, since there is MSDN and other countless books about Windows. You can assume that people reading your code already know what the various APIs are supposed to do. > The biggest problem, I believe, is the functions that take flags. Bear in > mind that a single DWORD argument used for flags is equivalent to up to 32 > boolean arguments. Documenting the relationship between those is a pain > but it needs to be done if we expect compatibility. This is clearly something that is best documented with code, not with text. You may need pages of text to describe the flags behavior in English, while with code it's usually only a few lines, plus a few comments here and there. This doesn't mean it wouldn't be a good thing to also have the full description in English; but in a separate document, not in the code. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Prevent excessive clipping in SysListView32
by Uwe Bonnes Aug. 2, 2001

Aug. 2, 2001

>>>>> "Medland," == Medland, Bill <Bill.Medland(a)accpac.com> writes: Medland,> I am not very comfortable with this one but strange as it may Medland,> seem it solves the problem. I'd love to know why. Medland,> <<diff13.txt>> Bill Medland (medbi01(a)accpac.com) Prevents Medland,> excessive clipping in SysListView32. Medland,> Medland,>-static inline int perfect_graphics(void) Medland,>+static int perfect_graphics(void) Medland,> { Medland,> static int perfect = -1; Medland,> if (perfect == -1) Medland,> Some C-Expert is requested here, but I suspect that in the old function the variable "perfect" was created in every instantiation of the "perfect_graphics" inlined function. Could you perhaps try to declare the "perfect" outside the inlined function, like static int perfect = -1; static inline int perfect_graphics(void) Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

6 9

Re: Documenting functions
by Alexandre Julliard Aug. 2, 2001

Aug. 2, 2001

Jeremy White <jwhite(a)codeweavers.com> writes: > I would say that I would rather have 100% of the effort a > particular developer *wants* to put in, rather than only > have his/her coding efforts. Absolutely; I'm not going to discourage anybody from writing doc if they feel like it. But I don't want anyone to feel somehow obliged to spend time on the doc if they'd rather be writing code, which I expect is the case with most developers... > However, I think that there should be a standard function > header, with a standard place to put notes and comments > in general about a function. I don't see a need to standardize anything. If you want to add a comment before a function just do it, there is no need for a standard format, plain text works just as well. > I have been trained, and I suspect that many of us have > been trained, to look at a function header for general > tips and tricks before diving into the code. I know > this is sacriledge to you, Alexandre, but there are some > of us who like to quickly look at a function, rather than > always reading the code to understand it completely. I think you misunderstand my position; I'm not opposed to having a comment at the start of the function explaining the general goal and the non-obvious things going on. But if you need more than a couple of paragraphs to do this, then either there are too many non-obvious things going on in your function, or you are wasting space explaining the obvious. I do strongly think that the goal should be to write code that doesn't require documentation in order to be understood. Of course adding a small amount of comments is a good idea; but when you start having more lines of documentation than lines of code, something is very wrong IMO. But this is mainly a matter of personal taste, and except in extreme cases I'm not going to reject code because it has too much (or not enough) documentation. It may happen that some of your beloved horizontal lines get lost during the cvs commit though ;-) -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Documenting functions
by Jeremy White Aug. 2, 2001

Aug. 2, 2001

[Resend due to exim crash; thanks Ove] >> I'd much rather have developers spend their time writing code. Making >> them duplicate the whole MSDN documentation would be a huge waste of >> their time. Our resources are not infinite, and it's much more useful >> to have 100% API coverage with no docs at all than 50% coverage and >> tons of docs. I think this is a dangerous attitude to take. I think that you cannot (and should not) attempt to force volunteer developers to add documentation to code. However, there are some few of us, who don't feel that the job is satisfactorily done until the documentation reflects important things that we've learned. I would say that I would rather have 100% of the effort a particular developer *wants* to put in, rather than only have his/her coding efforts. If I, like Bill, spend 24 hours ripping my hair out to learn some oddball things, I want a place to put those things. I want someone else (or an older version of me) to have a chance to not have to learn those things the hard way. Please don't misunderstand me. I agree that we shouldn't try to replicate MSDN. I'm not even sure we should provide minimal documentation like parameter lists and return values. Further, I agree that where it makes sense, the best place for comments is inline with the relevant code. However, I think that there should be a standard function header, with a standard place to put notes and comments in general about a function. I have been trained, and I suspect that many of us have been trained, to look at a function header for general tips and tricks before diving into the code. I know this is sacriledge to you, Alexandre, but there are some of us who like to quickly look at a function, rather than always reading the code to understand it completely. <in joke> Finally, I think all the code would be dramatically improved, in fact, I bet we'd be at Wine 1.0 by now, if there were nice big horizontal separator lines everywhere. </in joke>

1 0

Re: Documenting functions
by Alexandre Julliard Aug. 2, 2001

Aug. 2, 2001

Francois Gouget <fgouget(a)free.fr> writes: > So I think the functions implemented in Wine should be fully > documented. And the only place to do that is in the code source because > this is the only place where they have a remote chance of staying up to > date (and also where it's most practical to have it). I have to disagree here. Yes it would be nice to have a free Win API documentation, but it definitely doesn't belong inside the Wine source. First it would be a huge bloat in the source; and more importantly the Wine source doesn't define the Windows API, it is defined by Microsoft. > Of course developpers are very well-known for hating to document > stuff so it's going to be pretty hard to get proper documentation. But > we should encourage all Wine developpers to write good documentation for > the functions they implement/fix, not dissuade them to do so. I'd much rather have developers spend their time writing code. Making them duplicate the whole MSDN documentation would be a huge waste of their time. Our resources are not infinite, and it's much more useful to have 100% API coverage with no docs at all than 50% coverage and tons of docs. > Also I agree with you that the strict minimum is to at least document > all the undocumented/weird behaviors. Especially since without some sort > of documentation the next developper may be tempted to remove what looks > like unnecessarily convoluted/obviously wrong code. That should be done with comments inside the code itself. And in many cases it would actually be better to comment the places where the behavior is not right. What I mean is, instead of adding a comment on every line stating "yes this is what Windows does", I'd prefer adding a comment/FIXME to mark the lines that have been written without checking whether Windows really does it this way. -- Alexandre Julliard julliard(a)winehq.com

2 1

Dont allow SetSelectorBase to change into an kernel region
by Uwe Bonnes Aug. 1, 2001

Aug. 1, 2001

Hallo, galep3 crashes with following sequence: 096c7b38:Call KERNEL.189: SETSELECTORLIMIT(0x0d87,0x0000045f) ret=02e7:6fb5 ds=099f 096c7b38:Ret KERNEL.189: SETSELECTORLIMIT() retval=0x0d87 ret=02e7:6fb5 ds=099f 096c7b38:Call KERNEL.187: SETSELECTORBASE(0x0d87,0xc02924e0) ret=02e7:6fc1 ds=099f 096c7b38:Ret KERNEL.187: SETSELECTORBASE() retval=0x0d87 ret=02e7:6fc1 ds=099f ... Unhandled exception: page fault on read access to 0xc0292545 Obviously the application trys to reach some kernel memory. If I only allow to set the selector base when (selector base + selector limit) is smaller than 0x8000000, the application goes on and lets me read an eprom plugged into the Galep3 Programmer. Is the appended fix a right acceptable? Index: wine/memory/selector.c =================================================================== RCS file: /home/wine/wine/memory/selector.c,v retrieving revision 1.39 diff -u -r1.39 selector.c --- wine/memory/selector.c 19 Jul 2001 00:39:10 -0000 1.39 +++ wine/memory/selector.c 1 Aug 2001 17:30:48 -0000 @@ -327,7 +327,12 @@ LDT_ENTRY entry; wine_ldt_get_entry( sel, &entry ); wine_ldt_set_base( &entry, DOSMEM_MapDosToLinear(base) ); - wine_ldt_set_entry( sel, &entry ); + if ((base + wine_ldt_copy.limit[sel >> __AHSHIFT]) > 0x8000000) + { + FIXME("Illegal region base %lx limit %lx\n", base,wine_ldt_copy.limit[sel >> __AHSHIFT]); + } + else + wine_ldt_set_entry( sel, &entry ); return sel; } Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 1

Strange window handle in the trace
by Marco Bizzarri <m.bizzarri＠icube.it> Aug. 1, 2001

Aug. 1, 2001

Hi all. I'm working on a no-windows installation. The system is a RH 6.2 system, upgraded to the latest patches. I've installed XFree4 and KDE 2.1 I'm experiencing an unhandled exception when I try to a VC application. The application works (almost) fine until it opens a selection dialog, with a list on it. As you can see from the trace, it is trying to do an RDW_UpdateRgns with a wndPtr of 0xffff Unhandled exception: page fault on read access to 0x08fd506b in 32-bit code (0x406d1771). In 32-bit mode. Symbol h_errno is invalid Symbol hack_digit is invalid 0x406d1771 (RDW_UpdateRgns+0x3c9 [painting.c:720] in libuser32.so): testb $ 0x10,0x6b(%esi) 720 if( wnd->dwStyle & WS_VISIBLE ) Wine-dbg>bt Backtrace: =>0 0x406d1771 (RDW_UpdateRgns+0x3c9(wndPtr=0xffff, hRgn=0x0, flags=0x180, firstRecursLevel=0x0) [painting.c:720] in libuser32.so) (ebp=405b1bc4) 1 0x406d1787 (RDW_UpdateRgns+0x3df(wndPtr=0x40377824, hRgn=0x0, flags=0x180, firstRecursLevel=0x0) [painting.c:721] in libuser32.so) (ebp=405b1c20) 2 0x406d1787 (RDW_UpdateRgns+0x3df(wndPtr=0x40377538, hRgn=0x0, flags=0x180, firstRecursLevel=0x1) [painting.c:721] in libuser32.so) (ebp=405b1c7c) 3 0x406d1e08 (RedrawWindow+0x38c(hwnd=0x43f0, rectUpdate=0x0, hrgnUpdate=0x0, flags=0x180) [painting.c:982] in libuser32.so) (ebp=405b1cd4) 4 0x406d1f1d (UpdateWindow+0x21(hwnd=0x43f0) [painting.c:1015] in libuser32.so) (ebp=405b1cf0) 5 0x0043df7a (<Debugged process>.EntryPoint+0x13625 in <Debugged process>) (ebp=0046e660) 6 0x00000623 (ebp=000044e4) Just for "fun", I've tryied to add checks for 0xffff, but it crashes when it enters non Wine DLL (actually they are Spread dlls from Farpoint) Any clue? Thanks you all in advance Bye Marco -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588

1 0

CloseHandle with 0xffffffff parameter
by Marco Bizzarri Aug. 1, 2001

Aug. 1, 2001

Hi All. While trying to make an application working under wine, I've stumped into the following trace fragment, obtained with --debugmsg +relay: 081612c8:Call kernel32.CreateFileA(405f6454 "c:\\rs\\project\\apitest\\vc\\32\\apitestvc60\\debug\\ret_dll.pdb",80000000,00000001,00000000,00000003,00000080,00000000) ret=404aa001 081612c8:Ret kernel32.CreateFileA() retval=ffffffff ret=404aa001 081612c8:Call kernel32.CloseHandle(ffffffff) ret=404aa0bd 081612c8:Ret kernel32.CloseHandle() retval=00000000 ret=404aa0bd As you can see, the program is trying to open a file, which is not found. An invalid handle (ffffffff) is returned. The program however closes the handle. My question is: is this correct? Should the CloseHandle check to see if it is a correct handle? Thank you all in advance Marco Bizzarri -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588

1 0

Documenting functions
by Bill Medland Aug. 1, 2001

Aug. 1, 2001

Getting back to what we are and are not allowed to do.. Suppose I am looking at a low-level function that I believe is only 75%-complete (the most important 75% of course and no disrespect meant to those who have got it that far). One of the problems with it is it is not totally clear EXACTLY what the function should do in some of its more esoteric modes. To me the first task is to define what it should do and that should be part of the documentation of the function. The particular function currently does not have any true documentation within the code; the best documentation of what it does is the code itself, and the best documentation of what it should do is the MSDN description of the function. 1. Should the function be completely defined in its header in the source code (which will probably make the header twice as large as the function) or should the details be put somewhere else. 2. Are we walking into copyright danger if the Wine documentation of the function is clearly based on the MSDN documentation, even if we acknowledge that. 3. Are we interested in that level of documentation? Bill

4 3