January 2002 - Wine-Devel - list.winehq.org

MS' hidden API
by Zhang Shu July 9, 2002

July 9, 2002

Dear wine developers, I have one question on the development of wine. Long(one or two years) ago I've heard that Microsoft got some hidden APIs in their products of various windows, and they use these APIs in their own applications. I wonder if this is still a problem on their recent product like windows XP. If it is, I guess wine will not be able to run such MS applications which uses hidden APIs. Is this right? And, is wine designed(or its goal is) to run all applications(including MS product and non-MS product) that runs on windows? Please forgive me if this problem has appeared in the past. I just joined this list a couple of days ago. Thank you. Regards, -- Zhang Shu

10 10

Bug in MoveFileEx
by Gerhard W. Gruber Feb. 1, 2002

Feb. 1, 2002

I just played around with Thandor trying to install it and see what the differences are between Win98 and Wine because I noticed a slightly different behaviour. Now I discovered that MoveFileEx is not even available in Windows 98 but wine supplies it nevertheless. I suspect that the Setup doesn't check the windows version, but rather calls MoveFileEx and if that fails with not implemented returncode continues with other code to supply the functionality. I wrote a small test app to confirm this and this returns an error code when calling MoveFileEx on a native win98 whiel wine executes it. How shall I fix this? Shall I simply call GetVersion() to determine if MoveFileEx should be allowed or is there a different way with wine to determine which functions are available for which version (a global variable or such)? I looked through the sources but I couldn't find anywhere something where a versioncheck has been used to switch code but then again I don't know much functions where I know for sure that they are available in one version and not in the other. -- Bye, Gerhard If you think education is expensive, try ignorance.

4 4

CreateProcess API - undocumented use
by Ricardo Feb. 1, 2002

Feb. 1, 2002

hi, I have a program that use the CreateProcess API with dwFileAttribute as a parameter. But not to use in the command line. It's used to write some data into a file and then another program read that file. But this isn't working. I'm not a programmer, I'm just testing the program. Does anybody know how can the program be changed, or wine patched, to solve this? thanks, Ricardo

3 10

Fix for MoveFileExA
by Gerhard W. Gruber Feb. 1, 2002

Feb. 1, 2002

I just wrote a fix for a fixme located in MoveFileExA. Since this is the first time I'm writing something for wine I wanted to ask how I shall proceed now. Shall I simply add it into the CVS or does it have to go somewhere for revision? Also I don't want to submit it right now because my current fix is a bit ugly. The fix is applied for files that should be moved or deleted when windows boots after an application is installed. Currently there was a message telling the user that he has to delete/rename the specified files. Now I added some code that writes an entry in (WINECONFIG)/bootmove and (WINECONFIG)/bootdel when these functions are called. I also added some code in loader/main.c that checks if these files exists and if they do it will open them and deletes/renames the specified files. I hope this solution is acceptable. :) The only ugly thing about this is that the filenames for bootmove and bootdel are curerntly hardcoded where I need them. I don't know if there is a global space somewhere where I can add some fixed names so I did it this way for now, but this is not the best way in case the names should be changed or something and also I don't like hardecoded names. Another drawback of this approach is that it would be possible that more than one process is writing or reading at the same time there could be potential problems, so I'd like to hear some opinions if this is ok. -- Bye, Gerhard If you think education is expensive, try ignorance.

9 16

Re: DESTDIR support for make install
by Alexandre Julliard Feb. 1, 2002

Feb. 1, 2002

Bernhard Rosenkraenzer <bero(a)redhat.de> writes: > wine currently doesn't support the DESTDIR flag commonly used by > packagers. The patch I've attached fixes this. Could you explain this a bit more? Why can't you use the existing $prefix to do the same thing? -- Alexandre Julliard julliard(a)winehq.com

4 5

Re: Pajama Sam's unmanaged window
by Ove Kaaven Feb. 1, 2002

Feb. 1, 2002

On Sun, 27 Jan 2002, Ori Pessach wrote: > On Sunday 27 January 2002 11:22, Ove Kaaven wrote: > > On Sat, 26 Jan 2002, Ori Pessach wrote: > > > FALSE for those windows. Are there any other types of windows that > > > shouldn't be managed? > > > > Yes, Alexandre mentions popup menus and tooltips. Perhaps a chart could be > > made, so that it is possible to work out what conditions should be used to > > decide whether to make a window managed... > > Yep... Managed tooltips look silly. In any case, unmanaged windows behave > badly, and I don't see any reason to use unmanaged windows when Wine is > running in managed mode. > > Does anybody know how X toolkits display tooltips, popup menus, etc.? I looked at the GTK+ sources before creating that patch... for popup windows like menus and tooltips and stuff, GTK+ sets the override-redirect window attribute, which causes the window to become unmanaged. Effectively the same as Wine does. > I would think that when running managed Wine, all window should be > managed, and the distinction should be between decorationless windows > and everything else, not managed windows and everything else. > > If nobody else wants to dig into this, I'll probably take a shot at it. Go ahead.

4 10

ROTD (Rant Of The Day): patches
by Dimitrie O. Paun Feb. 1, 2002

Feb. 1, 2002

Guys, I've come to _hate_ diffs attached as Application/OCTET-STREAM. Can you please, Please, PLEASE, attach them as Text/PLAIN? I use Pine over a ssh connection to read wine-{devel,patches}, and I can simply view the Text/PLAIN attachments, whereas I have to: -- press V to view the list of attachments -- select the attachment I want to view -- press S to save it to disk -- exit Pine -- start vi to actually view the thing -- restart pine... Just to view a Application/OCTET-STREAM attachment. Which means 2 things: -- I get frustrated (and look what happens when I do:)) -- I simply ignore those patches For all these reasons (and more), I think Linus is right when he insists on: -- ONE patch per email -- ONLY Text/PLAIN attachments. -- Dimi.

6 8

Bug in WritePrivateProfileSection
by Gerhard W. Gruber Jan. 31, 2002

Jan. 31, 2002

I just wrote a small up to test the behaviour of WritePrivateProfileSection. This confirmed my suspicion that the wine implementation is wrong because on Win98 I can create multiple keys with the same name when using this function, while wine always substitutes the new value if the key already exists. If nobody is working on that, then I'll fix this first before continuing with the boot process. -- Bye, Gerhard If you think education is expensive, try ignorance.

2 2

Re: treeview.c
by Uwe Bonnes Jan. 31, 2002

Jan. 31, 2002

>>>>> "Aric" == Aric Stewart <aric(a)codeweavers.com> writes: Aric> This is a bit of a cover to help find other problems, but we would Aric> crash if trying to sort a treeview with null strings in it. This Aric> prevents this crash so that one can try to figure out why we have Aric> empty strings. Aric> CHANGELOG: prevent crash on sorting treeview with null strings Aric> - return strcasecmp(first->pszText, second->pszText); + if Aric> (first->pszText && second->pszText) + return Aric> strcasecmp(first->pszText, second->pszText); + else if Aric> (first->pszText) + return -1; + else if (second->pszText) + return Aric> 1; + else + return 0; } Should this fail silently? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: Microsoft Visual C (MSVC) compabillity
by Alexandre Julliard Jan. 31, 2002

Jan. 31, 2002

Patrik Stridvall <ps(a)leissner.se> writes: > All of the forms: > > (1) void WINAPI (*foo)(void); > (2) void (* WINAPI foo)(void); > (3) void (WINAPI *foo)(void); > > Seems to work with gcc. Even with gcc 2.7.x. I believe the problems were rather with g++. In my 2.95.4 version, case (2) still doesn't work (well it compiles but generates wrong code). Case (3) works though, so that sounds like the way to go, I'll apply your patch. -- Alexandre Julliard julliard(a)winehq.com

2 1

mingw32 port and cygwin
by Steven Edwards Jan. 31, 2002

Jan. 31, 2002

I'm having a bitch of a time with configure on mingw. I understand not wanting to #ifdef OSNAME in the wine source tree and how this would be a pain if a project forked. Would you be opposed to a #ifdef statement for mingw? Thanks Steven _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

3 4

Compilation errors for Freetype support
by Andriy Palamarchuk Jan. 31, 2002

Jan. 31, 2002

Trying to compile today's Wine I get errors: freetype.c: In function `WineEngGetGlyphOutline': freetype.c:947: `FT_Angle' undeclared (first use in this function) freetype.c:947: (Each undeclared identifier is reported only once freetype.c:947: for each function it appears in.) freetype.c:947: parse error before `angle' freetype.c:993: `angle' undeclared (first use in this function) freetype.c:1003: warning: implicit declaration of function `FT_Vector_Rotate' freetype.c:1059: warning: implicit declaration of function `FT_Cos' freetype.c:1060: warning: implicit declaration of function `FT_Sin' Huw, these functions calls were introduced to the file by your patch, applyed on Jan 29, 2002. I believe the problems are because of differences between freetype versions. The problem occurs on freetype 2.0.1, but according to thread "Prob with freetype..." is fixed after upgrading to 2.0.3. Regards, Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Great stuff seeking new owners in Yahoo! Auctions! http://auctions.yahoo.com

4 5

RE: New to wine
by Patrik Stridvall Jan. 31, 2002

Jan. 31, 2002

> All wine headers seem to declare function pointers like > > <return value> WINAPI (*<function pointer name)(<parameter list>) > > Visual C 5 does not like the WINAPI (eg __stdcall) outside of > the brackets and requires: > > <return value> (WINAPI *<function pointer name>)(<parameter list>) [snip] > Maybe there is someone on this list which can give me an > direct answer to this. If you want to compile with Visual C++ you will have to do something like below. #ifdef __GNUC__ #define WINAPI_PTR * WINAPI #else #define WINAPI_PTR WINAPI * #endif And replace all WINAPI function with: <return value> (WINAPI_PTR <function pointer name>)(<parameter list>) Hmm. That reminds me. I experimented with this some year ago but I have no distinct memory of asking Alexandre whether he wanted a patch that does this for Wine. Then I forgot about it. Alexandre: Will you accept a patch that does this?

2 1

Problems building wrc on mingw
by Steven Edwards Jan. 31, 2002

Jan. 31, 2002

bison -y -v -d -t ./parser.y conflicts: 2 shift/reduce gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -mpreferred-stack-boundary=2 -D__WINE__ -D_REENTRANT -o y.tab.o y.tab.c gcc: y.tab.c: No such file or directory gcc: No input files make: *** [y.tab.o] Error 1 I've got the -v option going but I can't get a debug output form bison to figure out whats going wrong. Anyone got any ideas? Thanks Steven _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

1 0

Current CVS doesn't compile
by Bernhard Rosenkraenzer Jan. 30, 2002

Jan. 30, 2002

dlls/Makefile.in refers to msvcrt20, but the directory doesn't exist. Guess someone forgot a "cvs add". LLaP bero -- This message is provided to you under the terms outlined at http://www.bero.org/terms.html

3 2

err:ntdll:RtlpWaitForCriticalSection section 0xXXXXXXX "?" wait timed out, retrying (60sec) fs = XXXX
by Sylvain Petreolle Jan. 30, 2002

Jan. 30, 2002

Hi, Like many users now, I have this message when I launch some programs : err:ntdll:RtlpWaitForCriticalSection section 0xXXXXXXX "?" wait timed out, retrying (60sec) fs = XXXX To clear the situtation : What does this message means and what could be done to make it disappear ? Some users have made post with these and have got no response... ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.fr

2 4

New to wine
by Rolf Kalbermatter Jan. 30, 2002

Jan. 30, 2002

Hello I happened to find wine when researching some undocumented stuff in shell32.dll for my own shell extensions I had written. It was interesting to see how things may be done in windows. I also identified some parts in the wine shell32 which need more attention and plan to submit some patches concerning that after I have familiarized myself a little more with wine. Since I had no Linux system at my hands I tried to use the Visual C 5 compiler on my windows system to compile the shell32 dll and found some problems with that. Separate from some wine specific project definitions which need to be made for Visual C to process the wine headers Iand which I probably haven't done all properly) there was one problem with function pointer definitions. All wine headers seem to declare function pointers like <return value> WINAPI (*<function pointer name)(<parameter list>) Visual C 5 does not like the WINAPI (eg __stdcall) outside of the brackets and requires: <return value> (WINAPI *<function pointer name>)(<parameter list>) I could also not find any comprehensible ANSI C description which would care to explain what would be the correct way of function pointer declarations with a calling convention identifier. I tried to figure out how this could be solved. Declaring WINAPI to be empty and telling Visual C to use __stdcall as default gives other problems with internal wine functions without explicit calling convention declaration and with a variable argument list, which requires __cdecl. The only way I could find was to adjust the function pointer definitions in the affected headers. Of course this goes quite far and might cause problems with other compilers. As I will soon have a new development machine on which I will install Linux alongside of Windows I can fairly easily check if this would cause problems with gcc, but wine seems to care for more compilers than that and I have no idea if such a change would cause problems (it probably would anyhow :-| ). Maybe there is someone on this list which can give me an direct answer to this. Rolf Kalbermatter

2 1

Prob with freetype...
by Meths Jan. 30, 2002

Jan. 30, 2002

Hiya, Didn't see anyone mention this so... When compiling CVS tonight... gcc -c -I. -I. -I../../include -I../../include -I/usr/include/freetype2 -g -O2 -Wall -mpreferred-stack-boundary=2 -fPIC -D__WINE__ -D_REENTRANT -I/usr/X11R6/include -o freetype.o freetype.c freetype.c: In function `WineEngGetGlyphOutline': freetype.c:947: `FT_Angle' undeclared (first use in this function) freetype.c:947: (Each undeclared identifier is reported only once freetype.c:947: for each function it appears in.) freetype.c:947: parse error before `angle' freetype.c:993: `angle' undeclared (first use in this function) freetype.c:1003: warning: implicit declaration of function `FT_Vector_Rotate' freetype.c:1059: warning: implicit declaration of function `FT_Cos' freetype.c:1060: warning: implicit declaration of function `FT_Sin' make[2]: *** [freetype.o] Error 1 make[2]: Leaving directory `/root/cvs_root/wine/dlls/gdi' make[1]: *** [gdi/libgdi32.so] Error 2 make[1]: Leaving directory `/root/cvs_root/wine/dlls' make: *** [dlls] Error 2 Compilation failed, aborting install. Meths

2 1

Re: SetEndOfFile fix
by Guy L. Albertelli Jan. 30, 2002

Jan. 30, 2002

----- Original Message ----- From: <lawson_whitney(a)juno.com> To: <rklazes(a)xs4all.nl>; <galberte(a)neo.lrun.com> Cc: <wine-patches(a)winehq.com> Sent: Sunday, January 27, 2002 4:30 PM Subject: Re: SetEndOfFile fix > On Sun, 27 Jan 2002, Rein Klazes wrote: > > > You still need ftruncate in case the file has to shrink. To do that > > without ftruncate takes a lot more work then an lseek and a write. > > > > Rein. > > > Right. I meant sort of like this. Unfortunately I haven't an app that > does this, to be sure I have it right. > > Changelog > server : file.c > Lawson Whitney <lawson_whitney(a)juno.com> > Rein Klazes <rklazes(a)xs4all.nl> > Guy Albertelli <galberte(a)neo.lrun.com> > Do not rely on ftruncate to grow a file. It may refuse or fail > to do so. (eg with vfat filesystem under Linux) > > Outlook Express 5.0 is happy (relatively). Lets commit this. Guy

1 0

RE: Sooo quiet...
by Patrik Stridvall Jan. 29, 2002

Jan. 29, 2002

> ... I feel like starting a flamewar, just to get some > traffic on this list :) Yes!!! Flamewar!!! No retreat!!! No surrender!!! > Speaking of which, I figured I should rattle Alexandre's cage :) Well, I guess he will have fun with all the outstanding patches. I think he has never had so many. :-) > So here I go: > > Wine's been around for 8 (_eight_) years (how time flies)! It is my > understanding that we're approaching the 1.0 status. I say, > let's change > the versioning scheme, just to give the outside world a feeling of > progress. Really, I think the current scheme kindda hurts us on a PR > level. > > We can start with something like 0.90.0. This should give us plenty > numbers to the upcoming 1.0, don't you think? Unfortunetely there won't be any flamewar as far as I'm concerned since don't care very much either way. :-) But if anybody is intrested in my opinion anyway here goes: I'm slightly against changing the versioning scheme before 1.0. After 1.0 we probably want to have so sort of different versioning especially since we might release different versions of the DLL:s independently of each other. However I don't think there is much use of having that pre 1.0.

8 10

Re: A new SDL back-end we've been toying with
by Steven Edwards Jan. 29, 2002

Jan. 29, 2002

> > You might want to take a look at microwindows if > you > > want GDI/framebuffer > > However, keep in mind that Microwindows can be had > at > either MPL and GPL licenses. True, but you might be able to get them relicense certain parts for wine. __________________________________________________ Do You Yahoo!? Great stuff seeking new owners in Yahoo! Auctions! http://auctions.yahoo.com

1 0

FW: Prob with freetype...
by Medland, Bill Jan. 29, 2002

Jan. 29, 2002

-----Original Message----- From: Medland, Bill Sent: Tuesday, January 29, 2002 2:22 PM To: 'Meths' Subject: RE: Prob with freetype... Mentioned it this morning (sort of). Michael Stefaniuc upgraded to freetype 2.0.3 and that worked. I just cheated; I inserted the following lines into freetype.c to get it compiled; Index: wine/dlls/gdi/freetype.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/freetype.c,v retrieving revision 1.4 diff -u -r1.4 freetype.c --- wine/dlls/gdi/freetype.c 2002/01/29 03:02:51 1.4 +++ wine/dlls/gdi/freetype.c 2002/01/29 20:29:42 @@ -56,6 +56,12 @@ #endif #ifdef HAVE_FREETYPE_FTTRIGON_H #include <freetype/fttrigon.h> +#else +/* Just a hack to get it to compile without upgrading my freetype */ +typedef FT_Fixed FT_Angle; +inline FT_Fixed FT_Sin(FT_Angle a) {return 0;} +inline FT_Fixed FT_Cos(FT_Angle a) {return 65536;} +inline FT_Vector_Rotate(FT_Vector *v, FT_Angle a) {return;} #endif static FT_Library library = 0; Bill > -----Original Message----- > From: Meths [mailto:meths(a)btinternet.com] > Sent: Tuesday, January 29, 2002 1:27 PM > To: wine-devel(a)winehq.com > Subject: Prob with freetype... > > > Hiya, > > Didn't see anyone mention this so... > > When compiling CVS tonight... > > gcc -c -I. -I. -I../../include -I../../include > -I/usr/include/freetype2 > -g -O2 -Wall -mpreferred-stack-boundary=2 -fPIC -D__WINE__ > -D_REENTRANT > -I/usr/X11R6/include -o freetype.o freetype.c > freetype.c: In function `WineEngGetGlyphOutline': > freetype.c:947: `FT_Angle' undeclared (first use in this function) > freetype.c:947: (Each undeclared identifier is reported only once > freetype.c:947: for each function it appears in.) > freetype.c:947: parse error before `angle' > freetype.c:993: `angle' undeclared (first use in this function) > freetype.c:1003: warning: implicit declaration of function > `FT_Vector_Rotate' > freetype.c:1059: warning: implicit declaration of function `FT_Cos' > freetype.c:1060: warning: implicit declaration of function `FT_Sin' > make[2]: *** [freetype.o] Error 1 > make[2]: Leaving directory `/root/cvs_root/wine/dlls/gdi' > make[1]: *** [gdi/libgdi32.so] Error 2 > make[1]: Leaving directory `/root/cvs_root/wine/dlls' > make: *** [dlls] Error 2 > > Compilation failed, aborting install. > > Meths > > >

1 0

GetNearestColor Fix
by Dave Hawkes Jan. 29, 2002

Jan. 29, 2002

Fix for GetNearestColor so it returns the true color rather than the system palette if the device does not support a palette (ie > 256 colors). This not quite what the Windows SDK docs say, but it's what happens in practice... Dave Hawkes

1 0

DOSfs - further work ?
by Keith Matthews Jan. 29, 2002

Jan. 29, 2002

While this is not critical, or even a large amount of work, I noticed when playing around with the floppy media problem that wine does not attempt to mount either a floppy or CD to display the contents. Was this intentional does anyone remember ? If not does anyone have reservations about trying to enable it? -- Keith Matthews Frequentous Consultants - Linux Services, Oracle development & database administration

1 0

Patch that broke SetFileAttributes
by Jukka Heinonen Jan. 29, 2002

Jan. 29, 2002

Fallout II requires that a certain file is located on a CDROM drive. For some reason it checks this using SetFileAttributes, which is supposed to fail on readonly drives. This used to work until the following patch broke this behaviour (message continues after the patch): Index: file.c =================================================================== RCS file: /home/wine/wine/win32/file.c,v retrieving revision 1.26 retrieving revision 1.27 diff -u -r1.26 -r1.27 --- file.c 2001/05/14 20:09:39 1.26 +++ file.c 2001/05/18 23:18:25 1.27 @@ -104,7 +104,7 @@ { FILE_SetDosError(); MESSAGE("Wine ERROR: Couldn't set file attributes for existing file \"%s\". Check permissions or set VFAT \"quiet\" flag !\n", full_name.long_name); - return FALSE; + return TRUE; } return TRUE; } The above patch obviously breaks Windows compatibility (and likely has a bug related to FILE_SetDosError). I would like to suggest that this patch is either removed or replaced with a patch that includes a C comment that properly documents reasons for this deliberate incompatibility and that either only affects non-CDROM drives or drives configured using some magic flag in Wine configuration file. -- Jukka Heinonen <http://www.iki.fi/jhei/>

4 8

system directory selection
by Brian Elliott Jan. 29, 2002

Jan. 29, 2002

Hi folks, I just installed WINE for the first time and had some trouble getting dlls to load until I set the "system" option to my Win2k partition's system32 directory in wine.conf. Auto discovery of the proper system directory for wine.conf by wineinstall seems like a useful thing for new users. Would it be useful if I put together a small patch to the wineconf program so that running wineinstall will select the right system directory for configuration? Also, is it correct to assume that if a system32 subdirectory exists under the winnt or windows directory that it should be set given preference in wine.conf as the system directory? Thanks, Brian _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

3 2

To which freetype should I upgrade? 2.0.6 or earlier
by Bill Medland Jan. 29, 2002

Jan. 29, 2002

and while we are on the subject what is the philosophy on ifdefing header files? (I have freetype 2.0.1 from RedHat 7.1 so this morning's build failed because I don't have the trig stuff.) If we test for a header file and only include it if it is present should we be putting similar ifdefs around the code that required the header and providing alternatives when it is not present, or specifying that it NEEDS to exist? Bill

2 1

A new SDL back-end we've been toying with
by Gavriel State Jan. 29, 2002

Jan. 29, 2002

Hi everyone, We just put this together for some testing, and thought that someone might find it handy. I'm not submitting it to wine-patches, since we haven't tested it on the most recent winehq tree, but it should be pretty easy to integrate in. It's not 100% complete by any means, but it has both GDI bitmap and DDraw support. We can vouch that it runs some of the DDraw samples, but beyond that, who knows. That said, the SDL driver should be a useful alternative to the ttydrv for testing purposes. -Gav -- Gavriel State, CEO TransGaming Technologies Inc. http://www.transgaming.com gav(a)transgaming.com

6 8

Re: Driver critical section changes from CW
by Gerard Patel Jan. 29, 2002

Jan. 29, 2002

At 10:11 AM 1/29/02 +0100, you wrote: >Running the program The 4th Coming after updating >today, >results into these messages : >fixme:win32:SetCriticalSectionSpinCount >critsection=0x7ff063b8: spincount=1000 not supported <snip> This patch is not yet applied, it can hardly be responsible. See documentation/cvs-regression for the complete procedure to make sure a particular patch has caused a regression. Gerard

1 0

Driver critical section changes from CW
by Duane Clark Jan. 29, 2002

Jan. 29, 2002

Modified files: dlls/gdi : driver.c loader : module.c Log message: Codeweavers Replace Rtl...PebLock with Rtl...CriticalSection. Slight change to library loading. Index: dlls/gdi/driver.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/driver.c,v retrieving revision 1.6 diff -u -r1.6 driver.c --- dlls/gdi/driver.c 2001/09/14 01:00:57 1.6 +++ dlls/gdi/driver.c 2002/01/26 15:02:42 @@ -27,8 +27,8 @@ static struct graphics_driver *first_driver; static struct graphics_driver *display_driver; static const DC_FUNCTIONS *win16_driver; +static CRITICAL_SECTION driver_section = CRITICAL_SECTION_INIT( "driver_section" ); - /********************************************************************** * create_driver * @@ -207,13 +207,13 @@ HMODULE module; struct graphics_driver *driver; - RtlAcquirePebLock(); + RtlEnterCriticalSection( &driver_section ); /* display driver is a special case */ if (!strcasecmp( name, "display" )) { driver = load_display_driver(); - RtlReleasePebLock(); + RtlLeaveCriticalSection( &driver_section ); return &driver->funcs; } @@ -224,7 +224,7 @@ if (driver->module == module) { driver->count++; - RtlReleasePebLock(); + RtlLeaveCriticalSection( &driver_section ); return &driver->funcs; } } @@ -233,19 +233,19 @@ if (!(module = LoadLibraryA( name ))) { if (!win16_driver) win16_driver = WIN16DRV_Init(); - RtlReleasePebLock(); + RtlLeaveCriticalSection( &driver_section ); return win16_driver; } if (!(driver = create_driver( module ))) { FreeLibrary( module ); - RtlReleasePebLock(); + RtlLeaveCriticalSection( &driver_section ); return NULL; } TRACE( "loaded driver %p for %s\n", driver, name ); - RtlReleasePebLock(); + RtlLeaveCriticalSection( &driver_section ); return &driver->funcs; } @@ -259,7 +259,7 @@ { struct graphics_driver *driver; - RtlAcquirePebLock(); + RtlEnterCriticalSection( &driver_section ); if (funcs != win16_driver) { for (driver = first_driver; driver; driver = driver->next) @@ -267,7 +267,7 @@ if (!driver) ERR( "driver not found, trouble ahead\n" ); driver->count++; } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &driver_section ); return funcs; } @@ -281,7 +281,7 @@ { struct graphics_driver *driver; - RtlAcquirePebLock(); + RtlEnterCriticalSection( &driver_section ); if (funcs == win16_driver) goto done; @@ -300,7 +300,7 @@ FreeLibrary( driver->module ); HeapFree( GetProcessHeap(), 0, driver ); done: - RtlReleasePebLock(); + RtlLeaveCriticalSection( &driver_section ); } Index: loader/module.c =================================================================== RCS file: /home/wine/wine/loader/module.c,v retrieving revision 1.145 diff -u -r1.145 module.c --- loader/module.c 2002/01/18 18:58:08 1.145 +++ loader/module.c 2002/01/26 15:02:43 @@ -29,6 +29,8 @@ static int free_lib_count; /* recursion depth of FreeLibrary calls */ static int process_detaching; /* set on process detach to avoid deadlocks with thread detach */ +static CRITICAL_SECTION loader_section = CRITICAL_SECTION_INIT( "loader_section" ); + /*********************************************************************** * wait_input_idle * @@ -176,9 +178,13 @@ BOOL retv = TRUE; int i; - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); - if (!wm) wm = exe_modref; + if (!wm) + { + wm = exe_modref; + PE_InitTls(); + } assert( wm ); /* prevent infinite recursion in case of cyclical dependencies */ @@ -221,7 +227,7 @@ TRACE("(%s,%p) - END\n", wm->modname, lpReserved ); done: - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); return retv; } @@ -236,7 +242,7 @@ { WINE_MODREF *wm; - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); if (bForceDetach) process_detaching = 1; do { @@ -258,7 +264,7 @@ } } while ( wm ); - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); } /************************************************************************* @@ -276,8 +282,10 @@ if (process_detaching) return; /* FIXME: there is still a race here */ - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); + PE_InitTls(); + for ( wm = MODULE_modref_list; wm; wm = wm->next ) if ( !wm->next ) break; @@ -292,7 +300,7 @@ MODULE_InitDLL( wm, DLL_THREAD_ATTACH, lpReserved ); } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); } /************************************************************************* @@ -310,7 +318,7 @@ if (process_detaching) return; /* FIXME: there is still a race here */ - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); for ( wm = MODULE_modref_list; wm; wm = wm->next ) { @@ -322,7 +330,7 @@ MODULE_InitDLL( wm, DLL_THREAD_DETACH, lpReserved ); } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); } /**************************************************************************** @@ -335,7 +343,7 @@ WINE_MODREF *wm; BOOL retval = TRUE; - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); wm = MODULE32_LookupHMODULE( hModule ); if ( !wm ) @@ -343,7 +351,7 @@ else wm->flags |= WINE_MODREF_NO_DLL_CALLS; - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); return retval; } @@ -1231,13 +1239,13 @@ { WINE_MODREF *wm; - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); lpFileName[0] = 0; if ((wm = MODULE32_LookupHMODULE( hModule ))) lstrcpynA( lpFileName, wm->filename, size ); - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); TRACE("%s\n", lpFileName ); return strlen(lpFileName); } @@ -1284,7 +1292,18 @@ NULL, OPEN_EXISTING, 0, 0 ); if (hFile != INVALID_HANDLE_VALUE) { - hmod = PE_LoadImage( hFile, filename, flags ); + DWORD type; + MODULE_GetBinaryType( hFile, filename, &type ); + if (type == SCS_32BIT_BINARY) + { + HANDLE mapping = CreateFileMappingA( hFile, NULL, PAGE_READONLY, + 0, 0, NULL ); + if (mapping) + { + hmod = (HMODULE)MapViewOfFile( mapping, FILE_MAP_READ, 0, 0, 0 ); + CloseHandle( mapping ); + } + } CloseHandle( hFile ); } if (hmod) return (HMODULE)((ULONG_PTR)hmod + 1); @@ -1293,7 +1312,7 @@ /* Fallback to normal behaviour */ } - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); wm = MODULE_LoadLibraryExA( libname, hfile, flags ); if ( wm ) @@ -1307,7 +1326,7 @@ } } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); return wm ? wm->module : 0; } @@ -1381,7 +1400,7 @@ if ( !filename ) return NULL; *filename = 0; /* Just in case we don't set it before goto error */ - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); if ((flags & LOAD_WITH_ALTERED_SEARCH_PATH) && FILE_contains_path(libname)) { @@ -1459,7 +1478,7 @@ HeapFree ( GetProcessHeap(), 0, (LPSTR)libdir ); libdir = NULL; } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); HeapFree ( GetProcessHeap(), 0, filename ); return pwm; } @@ -1511,7 +1530,7 @@ HeapFree ( GetProcessHeap(), 0, (LPSTR)libdir ); libdir = NULL; } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); SetLastError( err ); /* restore last error */ HeapFree ( GetProcessHeap(), 0, filename ); return pwm; @@ -1527,7 +1546,7 @@ HeapFree ( GetProcessHeap(), 0, (LPSTR)libdir ); libdir = NULL; } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); WARN("Failed to load module '%s'; error=0x%08lx\n", filename, GetLastError()); HeapFree ( GetProcessHeap(), 0, filename ); return NULL; @@ -1634,13 +1653,13 @@ return TRUE; } - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); free_lib_count++; if ((wm = MODULE32_LookupHMODULE( hLibModule ))) retv = MODULE_FreeLibrary( wm ); free_lib_count--; - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); return retv; } @@ -1818,13 +1837,13 @@ else TRACE_(win32)("(%08lx,%p)\n",(DWORD)hModule,function); - RtlAcquirePebLock(); + RtlEnterCriticalSection( &loader_section ); if ((wm = MODULE32_LookupHMODULE( hModule ))) { retproc = wm->find_export( wm, function, snoop ); if (!retproc) SetLastError(ERROR_PROC_NOT_FOUND); } - RtlReleasePebLock(); + RtlLeaveCriticalSection( &loader_section ); return retproc; }

2 2

Fwd: Total Annihilation
by Daniel Davis Jan. 29, 2002

Jan. 29, 2002

Hi guys, I sent this to the wine-users list but didn't get any response so I thought maybe you could answer this. I am simply trying to figure out why Total Annihilation keeps terminating with a code 21. I would prefer to know where the list of errors is so that I can solve these on my own without needing to pester people all the time. :-) Daniel ---------- Forwarded Message ---------- Subject: Total Annihilation Date: Sun, 27 Jan 2002 13:40:38 -0500 From: Daniel Davis <planetes(a)cfl.rr.com> To: wine-users(a)winehq.com Hi everyone, I just started tinkering with wine on my system and everytime I try to run Total Annihilation it dies with a return (error) code 21. Is there a list of return codes anywhere in wine that can help me determine where this program and any others I try to run in the future are dying? Daniel -------------------------------------------------------

3 3

Sooo quiet...
by Dimitrie O. Paun Jan. 28, 2002

Jan. 28, 2002

... I feel like starting a flamewar, just to get some traffic on this list :) Speaking of which, I figured I should rattle Alexandre's cage :) So here I go: Wine's been around for 8 (_eight_) years (how time flies)! It is my understanding that we're approaching the 1.0 status. I say, let's change the versioning scheme, just to give the outside world a feeling of progress. Really, I think the current scheme kindda hurts us on a PR level. We can start with something like 0.90.0. This should give us plenty numbers to the upcoming 1.0, don't you think? -- Dimi.

3 3

Compilation error
by Christian Schmitt Jan. 28, 2002

Jan. 28, 2002

Hello, i have a strange problem compiling the newest wine version (20020122). The compilation process stops with an error message concerning freetype: make[2]: Entering directory `/usr/src/wine-20020122/dlls/gdi' gcc -c -I. -I. -I../../include -I../../include -I/usr/local/include/freetype2 -g -O2 -Wall -fno-strength-reduce -mpreferred-stack-boundary=2 -fPIC -D__WINE__ -D_REENTRANT -I/usr/X11R6/include -o freetype.o freetype.c freetype.c:56: parse error before `library' freetype.c:56: warning: type defaults to `int' in declaration of `library' freetype.c:56: warning: data definition has no type or storage class freetype.c:74: parse error before `FT_Face' freetype.c:74: warning: no semicolon at end of struct or union freetype.c: In function `AddFontFileToList': freetype.c:81: `FT_Face' undeclared (first use in this function) freetype.c:81: (Each undeclared identifier is reported only once freetype.c:81: for each function it appears in.) freetype.c:81: parse error before `ft_face' freetype.c:89: warning: implicit declaration of function `FT_New_Face' freetype.c:89: `ft_face' undeclared (first use in this function) freetype.c:94: warning: implicit declaration of function `FT_IS_SFNT' freetype.c:95: warning: implicit declaration of function `FT_Done_Face' freetype.c:138: `FT_STYLE_FLAG_ITALIC' undeclared (first use in this function) freetype.c:139: `FT_STYLE_FLAG_BOLD' undeclared (first use in this function) freetype.c: In function `WineEngInit': freetype.c:193: warning: implicit declaration of function `FT_Init_FreeType' freetype.c: At top level: freetype.c:230: parse error before `OpenFontFile' freetype.c:231: warning: return-type defaults to `int' freetype.c: In function `OpenFontFile': freetype.c:232: `FT_Error' undeclared (first use in this function) freetype.c:232: parse error before `err' freetype.c:233: `TT_OS2' undeclared (first use in this function) freetype.c:233: `pOS2' undeclared (first use in this function) freetype.c:233: warning: statement with no effect freetype.c:234: `FT_Face' undeclared (first use in this function) freetype.c:234: parse error before `ft_face' freetype.c:237: `err' undeclared (first use in this function) freetype.c:237: `ft_face' undeclared (first use in this function) freetype.c:243: warning: implicit declaration of function `FT_Get_Sfnt_Table' freetype.c:243: `ft_sfnt_os2' undeclared (first use in this function) freetype.c:262: `ppem' undeclared (first use in this function) freetype.c:267: warning: implicit declaration of function `FT_Set_Pixel_Sizes' freetype.c: In function `WineEngCreateFontInstance': freetype.c:288: dereferencing pointer to incomplete type freetype.c:289: dereferencing pointer to incomplete type freetype.c:317: dereferencing pointer to incomplete type freetype.c: In function `WineEngAddRefFont': freetype.c:330: dereferencing pointer to incomplete type freetype.c:331: warning: control reaches end of non-void function freetype.c: In function `WineEngDecRefFont': freetype.c:339: dereferencing pointer to incomplete type freetype.c:342: dereferencing pointer to incomplete type freetype.c: In function `GetEnumStructs': freetype.c:353: dereferencing pointer to incomplete type freetype.c:355: dereferencing pointer to incomplete type freetype.c:356: dereferencing pointer to incomplete type freetype.c: In function `WineEngGetGlyphOutline': freetype.c:469: `FT_Face' undeclared (first use in this function) freetype.c:469: parse error before `ft_face' freetype.c:470: `FT_UInt' undeclared (first use in this function) freetype.c:472: `FT_Bitmap' undeclared (first use in this function) freetype.c:472: parse error before `ft_bitmap' freetype.c:478: `glyph_index' undeclared (first use in this function) freetype.c:480: warning: implicit declaration of function `FT_Get_Char_Index' freetype.c:480: `ft_face' undeclared (first use in this function) freetype.c:482: warning: implicit declaration of function `FT_Load_Glyph' freetype.c:482: `FT_LOAD_DEFAULT' undeclared (first use in this function) freetype.c:494: `ft_glyph_format_outline' undeclared (first use in this function) freetype.c:506: `ft_bitmap' undeclared (first use in this function) freetype.c:509: `ft_pixel_mode_mono' undeclared (first use in this function) freetype.c:512: warning: implicit declaration of function `FT_Outline_Translate'freetype.c:517: warning: implicit declaration of function `FT_Outline_Get_Bitmap' freetype.c: In function `WineEngGetTextMetrics': freetype.c:531: `FT_Face' undeclared (first use in this function) freetype.c:531: parse error before `ft_face' freetype.c:532: `TT_OS2' undeclared (first use in this function) freetype.c:532: `pOS2' undeclared (first use in this function) freetype.c:532: warning: statement with no effect freetype.c:533: `TT_HoriHeader' undeclared (first use in this function) freetype.c:533: `pHori' undeclared (first use in this function) freetype.c:533: warning: statement with no effect freetype.c:534: `FT_Fixed' undeclared (first use in this function) freetype.c:534: parse error before `x_scale' freetype.c:536: `x_scale' undeclared (first use in this function) freetype.c:536: `ft_face' undeclared (first use in this function) freetype.c:537: `y_scale' undeclared (first use in this function) freetype.c:539: `ft_sfnt_os2' undeclared (first use in this function) freetype.c:545: `ft_sfnt_hhea' undeclared (first use in this function) freetype.c:558: warning: implicit declaration of function `FT_MulFix' freetype.c:581: `FT_STYLE_FLAG_ITALIC' undeclared (first use in this function) freetype.c:586: warning: implicit declaration of function `FT_IS_FIXED_WIDTH' freetype.c:587: warning: implicit declaration of function `FT_IS_SCALABLE' freetype.c: In function `WineEngGetOutlineTextMetrics': freetype.c:602: `FT_Face' undeclared (first use in this function) freetype.c:602: parse error before `ft_face' freetype.c:604: `TT_OS2' undeclared (first use in this function) freetype.c:604: `pOS2' undeclared (first use in this function) freetype.c:604: warning: statement with no effect freetype.c:605: `TT_HoriHeader' undeclared (first use in this function) freetype.c:605: `pHori' undeclared (first use in this function) freetype.c:605: warning: statement with no effect freetype.c:606: `FT_Fixed' undeclared (first use in this function) freetype.c:606: parse error before `x_scale' freetype.c:613: `ft_face' undeclared (first use in this function) freetype.c:615: `family_nameW' undeclared (first use in this function) freetype.c:621: `style_nameW' undeclared (first use in this function) freetype.c:648: `x_scale' undeclared (first use in this function) freetype.c:649: `y_scale' undeclared (first use in this function) freetype.c:651: `ft_sfnt_os2' undeclared (first use in this function) freetype.c:658: `ft_sfnt_hhea' undeclared (first use in this function) freetype.c:704: `cp' undeclared (first use in this function) freetype.c:714: `spaceW' undeclared (first use in this function) freetype.c: In function `WineEngGetFontData': freetype.c:785: `FT_Face' undeclared (first use in this function) freetype.c:785: parse error before `ft_face' freetype.c:786: `TT_Face' undeclared (first use in this function) freetype.c:787: `SFNT_Interface' undeclared (first use in this function) freetype.c:787: `sfnt' undeclared (first use in this function) freetype.c:787: warning: statement with no effect freetype.c:788: parse error before `len' freetype.c:789: `FT_Error' undeclared (first use in this function) freetype.c:791: `ft_face' undeclared (first use in this function) freetype.c:794: `tt_face' undeclared (first use in this function) freetype.c:794: parse error before `ft_face' freetype.c:795: parse error before `)' freetype.c:798: `len' undeclared (first use in this function) freetype.c:807: `err' undeclared (first use in this function) make[2]: *** [freetype.o] Error 1 make[2]: Leaving directory `/usr/src/wine-20020122/dlls/gdi' make[1]: *** [gdi/libgdi32.so] Error 2 make[1]: Leaving directory `/usr/src/wine-20020122/dlls' make: *** [dlls] Error 2 Compilation failed, aborting install. I don't know what to do to solve this problem. I tried "./configure --disable-freetype" to no avail. I use Xfree86 4.1.0 (self compiled) on a Debian 2.2r2 system. Can anybody help me with this issue? I need a way to disable freetype or another solution. I hope somebody can help me. Bye Chris -- Linux - Cause life is too short for reboots

2 1

Re: CodeWeaver's patches
by Gerard Patel Jan. 28, 2002

Jan. 28, 2002

At 01:57 AM 1/28/02 -0500, you wrote: >I have finished doing that with one exception: the ListView. This one will >require a lot more work due to the fact that it was extensively modified. >I will work on the listview.c file this week, as I have some of my own >changes that I need to cleanup and submit, as well as CW's changes. Speaking of listview, I have issues with your last changes : notification is broken. I can see it with Eudora 4, but I have a test app in Python that I can send you if you want. I attach the changes I did to get Eudora working again Note that the change in notify() is unrelated, I just noticed the problem when searching the notification problem. Also the following change - if (*ppszText == NULL) - *lpLVItem->pszText = '\0'; is not related to your changes, this was broken a very long time ago. It's just that it makes listview work again for columns > 0. If you think to send your changes soon, maybe you could use my changes or implement them to your liking. Else I can send them myself (if you don't object to my changes), as you prefer. Gerard

2 1

DOSfs - removable media drives.
by Keith Matthews Jan. 28, 2002

Jan. 28, 2002

I noticed earlier today that DOSfs is not correctly handling removable media drives. In particular floppies will get a permissions error message regardless of the actual permissions if there is no media in the drive. Presumeably Jazz type drives would do the same. I have made the assumption that the fact that there is no media in the drive needs to be stored and have added a new value to the drive flags for this. If someone knows better that it cannot be used or clashes with something I have not spotted then please say so. ================================================================ Index: files/drive.c =================================================================== RCS file: /home/wine/wine/files/drive.c,v retrieving revision 1.64 diff -u -u -r1.64 drive.c --- files/drive.c 2002/01/13 01:44:00 1.64 +++ files/drive.c 2002/01/28 16:41:26 @@ -7,6 +7,7 @@ * Label & serial number read support. * (c) 1999 Petr Tomasek <tomasek(a)etf.cuni.cz> * (c) 2000 Andreas Mohr (changes) + * (c) 2002 Keith Matthews (changes) * */ @@ -508,21 +509,95 @@ #define DRIVE_SUPER 96 int fd; off_t offs; + struct stat dev_data; + uid_t user; + gid_t group; if (memset(buff,0,DRIVE_SUPER)!=buff) return -1; - if ((fd=open(DOSDrives[drive].device,O_RDONLY)) == -1) + + if (!DOSDrives[drive].device) { - struct stat st; - if (!DOSDrives[drive].device) - ERR("No device configured for drive %c: !\n", 'A'+drive); - else - ERR("Couldn't open device '%s' for drive %c: ! (%s)\n", DOSDrives[drive].device, 'A'+drive, - (stat(DOSDrives[drive].device, &st)) ? - "not available or symlink not valid ?" : "no permission"); - ERR("Can't read drive volume info ! Either pre-set it or make sure the device to read it from is accessible !\n"); + ERR("No Device Configured for drive %c: !\n",'A'+drive); PROFILE_UsageWineIni(); return -1; } + + if (( stat(DOSDrives[drive].device,&dev_data)) == -1) + { + if (errno == ENOENT || errno == ENOTDIR || errno == ELOOP || errno == ENAMETOOLONG ) + { + ERR("Device ('%s) Configured for drive %c: is not a valid device path!\n",DOSDrives[drive].device,'A'+drive); + } else if ( errno == EACCES ) + ERR("Permissions problem on device for drive %c: !\n", 'A'+drive); + PROFILE_UsageWineIni(); + return -1; + } else + { + user = getuid(); + group = getgid(); + if ( user == dev_data.st_uid) + { + /* We are running as the device owner - check those perms */ + if ( (dev_data.st_mode & S_IRUSR) == 0 ) + { + /* owner does not have read perms - stupid but */ + ERR("Permissions problem on device for drive %c: - user does not have read access !\n", 'A'+drive); + PROFILE_UsageWineIni(); + return -1; + } + } else if ( group == dev_data.st_gid ) + { + if ( (dev_data.st_mode & S_IRGRP) == 0 ) + { + /* group does not have read perms */ + ERR("Permissions problem on device for drive %c: - group does not have read access !\n", 'A'+drive); + PROFILE_UsageWineIni(); + return -1; + } + + } else if ( (dev_data.st_mode & S_IROTH) == 0 ) + { + /* not owning user or group and no perms */ + ERR("Permissions problem on device for drive %c: - effective user does not have read access !\n", 'A'+drive); + PROFILE_UsageWineIni(); + return -1; + + } + } + + if ((fd=open(DOSDrives[drive].device,O_RDONLY)) == -1) + { + if (DOSDrives[drive].type == DRIVE_REMOVABLE ) + { + /***************************************************************************** + * OK, we've checked just about everything we can, it's a removeable media + * device, so assume no media since that gives same response + * + * Wrong if not running as root and user does not have read to device but + * we've already checked for that above + * + **************************************************************************/ + + DOSDrives[drive].flags = DOSDrives[drive].flags | DRIVE_NO_MEDIA; + return 0; + +/* ++++++++++++++++ should we be down here for CD's also ? also what about Jazz drives etc ?+++++++++++++++++++++++ */ + + } else { + /**************************************************************************** + * + * Not removeable media device - must be permissions problem + * + ***************************************************************************/ + ERR("Couldn't open device '%s' for drive %c: ! (%s)\n", DOSDrives[drive].device, 'A'+drive, + "no permission"); + ERR("Can't read drive volume info ! Either pre-set it or make sure the device to read it from is accessible !\n"); + PROFILE_UsageWineIni(); + return -1; + + } + } + Index: include/drive.h =================================================================== RCS file: /home/wine/wine/include/drive.h,v retrieving revision 1.8 diff -u -u -r1.8 drive.h --- include/drive.h 2000/12/12 00:44:43 1.8 +++ include/drive.h 2002/01/28 16:41:57 @@ -19,6 +19,7 @@ #define DRIVE_CASE_PRESERVING 0x0008 /* Drive fs is case preserving */ #define DRIVE_FAIL_READ_ONLY 0x0010 /* Fail opening read-only files for writing */ #define DRIVE_READ_VOL_INFO 0x0020 /* Try to read volume info from the device? */ +#define DRIVE_NO_MEDIA 0x0040 /* no media in drive */ extern int DRIVE_Init(void); extern int DRIVE_IsValid( int drive ); -- Keith Matthews Frequentous Consultants - Linux Services, Oracle development & database administration

1 0

CodeWeaver's patches
by Dimitrie O. Paun Jan. 28, 2002

Jan. 28, 2002

Hi people, As you already know, I've signed up for the task of breaking down CW's patches (office[12].diff), for the common controls (dlls/comctl32/*) I have finished doing that with one exception: the ListView. This one will require a lot more work due to the fact that it was extensively modified. I will work on the listview.c file this week, as I have some of my own changes that I need to cleanup and submit, as well as CW's changes. -- Dimi.

1 0

ReactOS/Mingw32 port
by Steven Edwards Jan. 28, 2002

Jan. 28, 2002

Hello, I am in the process of merging our wine tree back in to the main WINE branch and have a few issues that need to be addressed: 1. Makefiles and Resources Alexandre: I know you said you might not accept our makefiles but I went ahead and sent them for your review, if you dont want to apply them no problem. Will you accept the .def's for the dlls as we cannot use the .specs? No big deal if not because we can keep them on our CVS. Also due to a bug in windress we cannot use the wine resources so we have to use binary resources for our port. Will you accept those? If not, once again no big deal we can keep the makefiles, resources and defs in our CVS tree. 2. Winsock.h problems I've been looking at what our guys changed in the wine headers vs the current wine headers and the current winsock.h seems to have compatiblity problems for non-posix-like platforms. Any suggestions on how to fix it for our port? 3. Everything else I'm still new to the whole programming thing so I'm open for suggestions from everyone. If anyone has a better way of doing the port rather then #ifdef/#endif let me know. I'm going to start submitting patches to the headers today. Thanks Steven Edwards _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

3 4

Managed windows with Wine frames
by Mike McCormack Jan. 28, 2002

Jan. 28, 2002

Hi, This patch build's upon Ove's decorationless managed window patch. It removes the windowmanager frames from all managed windows, and uses Wine drawn frames as default. IMO it gives a better feel to the desktop... I haven't tested it extensively, but it seems to work with some apps such as Netscape, Acrobat, etc. Add "WMFrames"="Y" to .wine/config to restore the default managed behaviour. All comments welcome. Mike ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

Re: Patch to make wcmd compile on mingw/reactos
by Francois Gouget Jan. 27, 2002

Jan. 27, 2002

On Sun, 27 Jan 2002, Isolation wrote: > Changelog: > Changed wineman to main for mingw/reactos #ifdefs are not too popular in the Wine project :-) A better approach would be to just systematically change 'wine_main' to 'main' (in wcmdmain.c and wcmd.spec). We used wine_main as a workaround for a Wine problem in the past but the problem is gone so there is no reason to keep it that way. It would even be better to be able to use whatever entry-point the user wants in ReactOS but that's another issue and you can deal with it later. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In a world without fences who needs Gates?

2 1

Pajama Sam's unmanaged window
by Ori Pessach Jan. 27, 2002

Jan. 27, 2002

Hi, I spent some time trying to hunt down the window management problems I reported a while ago (dialogs displayed by the game Pajama Sam appearing behind the main window, and sometimes not getting keyboard focus). I found that the game's main window simply wasn't managed. The game opens a window that covers the entire screen, and doesn't have a caption. is_window_managed(), in dlls/x11drv/window.c therefore returns FALSE for that window, and (I'm guessing here) since Wine is running in managed mode, it manages that window poorly. Switching desktops in KDE doesn't remove the window from the screen, it's impossible to get any window to display on top of the game window, and in general, several functions in x11drv/winpos.c behave badly when Wine has a mix of managed and unmanaged windows. Changing is_window_managed()'s default return value to TRUE makes the game behave much better, but not perfectly. The KDE panel stays on top of the game window - it can be hidden away, but Windows handles this differently, letting the game window obscure the task bar. I'm inclined to call this a KDE problem, rather than a Wine problem. Also, I don't know whether the tests in is_window_managed() cover all the cases in which a window should stay unmanaged. Right now, is_window_managed() tests for child windows and tool windows, and returns FALSE for those windows. Are there any other types of windows that shouldn't be managed? -Ori Pessach _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

2 2

Re: Fix for overlapped I/O using ReadFile/WriteFile
by lawson_whitney＠juno.com Jan. 27, 2002

Jan. 27, 2002

On Sun, 27 Jan 2002, Tony Bryant wrote: > This patch fixes 2 problems ... > diff -r1.131 file.c > 1359c1359,1360 > < LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine) > --- > > LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine, Welcome to the "I didn't read the README" club. | If you add something, or fix a bug, please send a patch ('diff -u' | format preferred) to julliard(a)winehq.com or to the | wine-patches(a)winehq.com mailing list for inclusion in the next | release. | | -- | Alexandre Julliard | julliard(a)winehq.com Lawson

1 0

Re: SetEndOfFile fix
by Guy L. Albertelli Jan. 27, 2002

Jan. 27, 2002

----- Original Message ----- From: "Rein Klazes" <rklazes(a)xs4all.nl> To: <wine-patches(a)winehq.com> Sent: Sunday, January 20, 2002 2:13 PM Subject: SetEndOfFile fix > hi, > > This fixes office 97 MSword error (disk full or write protected) when > saving files on a vfat partition. MSword calls SetEndOfFile() which > uses ftruncate() that, in Linux, cannot grow files in this filesystem. > > BTW. A google search shows that the ftruncate problem has been > mentioned at least 3 times on c.e.m.w. in the last 6 months Since > nobody entered a fix, I could be overlooking something... This was a great catch. It was the reason Scandisk complained about OutlookExpress's files (see my message from 1/11/2001). However your fix still fails on my outdated kernel (2.2.12-20). The attached version seems to work better on this kernel. Guy

4 5

wine debug question
by Shane Shields Jan. 27, 2002

Jan. 27, 2002

hi all im trying to debug a program in wine but im not having any luck as to where the problem is. most probably due to my inexperience with wine:-P. maybe you can help. i know this program works on another wine developers computer with no problems but not on mine. attached is the output from the wine debugger and the last few lines from -debugmsg +all (the original log is 20+mb). i cant decide whether its a memory read problem or file write problem or ole problem or my problem ;-). if you want to test the program its at locutus.all.at and is called superlotto. the program is in turkish but the instructions on the web site are in english (im an aussie living in turkey). i wrote this program in vb5. ive been having this problem from cvs 26122001 and have been trying that long to debug it. if you can help me with some pointers or solutions it would be greatly appreciated. i would like to fix it myself but im stuck. thanks in advance Shane Shields To drink the WINE of success you must first seek the sayings of source ps im seeking the source but im nowhere near getting drunk ;-P

1 0

Re: Once again - this time with feeling - and no wrapping...
by Francois Gouget Jan. 27, 2002

Jan. 27, 2002

On Sun, 27 Jan 2002, Tony Bryant wrote: > ? patch.diff > Index: files/file.c > =================================================================== > RCS file: /home/wine/wine/files/file.c,v > retrieving revision 1.131 > diff -r1.131 file.c > 1359c1359,1360 > < LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine) > --- > > LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine, > > HANDLE hCompletionEvent) Please use unified diff. It's much more readable, more robust and the recommended format for Wine patches. See: http://wine.codeweavers.com/docs/wine-devel/patches.shtml#PATCH-FORMAT -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

1 0

ReactOS/Mingw Patches
by Isolation Jan. 27, 2002

Jan. 27, 2002

I have submitted diffs to wine-patches to build mingw/reactos. These diffs are only the makefiles and dll def's. I will working on extracting the patches need to compile in the next week. Thanks Steven

1 0

license issue: winebuild->libbfd
by clemens Jan. 26, 2002

Jan. 26, 2002

hi! winebuild parses an nm symbol dump in order to get the lists of exported dll symbols from shared libraries. 1) nm isn't called with the -D option. without -D it will just dump regular symbols. this will work when winebuild is used when compiling wine, because the generated .so files will include both, regular symbols, and dynamic symbols. prepackaged wine installations will have their shared libraries stripped from any regular symbols leaving just dynamic symbols making winebuild useless on those systems. I modified tools/winebuild/import.c:read_export_symbols to call nm with the -D option. works fine for stripped shared libraries, but crashes for some reasons in the regular wine building process. 2) instead of touching ugly C parsing code and fixing the bug, i would have liked to do it the right way: utilize libbfd. the problem: libbfd is GPL. not LGPL. as far as i can see I'm unable to use libbfd from winebuild now unless winebuild would become GPL too. any hints to resolve this? clemens

1 0

Re: Tab Ctrl fix
by Dimitrie O. Paun Jan. 26, 2002

Jan. 26, 2002

On Sat, 26 Jan 2002, Dimitrie O. Paun wrote: > [extracted from office2.diff] > > ChangeLog > Tab Control: forward the notification message to the parent. Oops, never mind this one, it's already in the tree. -- Dimi.

1 0

Re: int 33
by Andreas Mohr Jan. 26, 2002

Jan. 26, 2002

On Sat, Jan 26, 2002 at 05:34:33PM +0200, Nog wrote: > With this patch I can get into the copy protection screen in monkey > island 2 but the keyboard still doesn't work. > > Changelog: > * dlls/winedos/int33.c > Implement function number 0x5 (Return mouse button press information) > > nog > > P.S. Does anyone know how the Mouse motion counters (function 0xb) work? >From Ralf Brown's Intlist: --------M-33000B----------------------------- INT 33 - MS MOUSE v1.0+ - READ MOTION COUNTERS AX = 000Bh Return: CX = number of mickeys mouse moved horizontally since last call DX = number of mickeys mouse moved vertically Notes: a mickey is the smallest increment the mouse can sense positive values indicate down/right SeeAlso: AX=0003h,AX=001Bh,AX=0027h -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0

Re: int 33
by Nog Jan. 26, 2002

Jan. 26, 2002

Sorry forgot the file. Nog wrote: > With this patch I can get into the copy protection screen in monkey > island 2 but the keyboard still doesn't work. > > Changelog: > * dlls/winedos/int33.c > Implement function number 0x5 (Return mouse button press > information) > > nog > > P.S. Does anyone know how the Mouse motion counters (function 0xb) work? > > > > > Index: dlls/winedos/int33.c =================================================================== RCS file: /home/wine/wine/dlls/winedos/int33.c,v retrieving revision 1.1 diff -u -r1.1 int33.c --- dlls/winedos/int33.c 2001/12/04 19:54:45 1.1 +++ dlls/winedos/int33.c 2002/01/26 15:17:29 @@ -19,6 +19,7 @@ static struct { DWORD x, y, but; + WORD lbcount, rbcount, rlastx, rlasty, llastx, llasty; FARPROC16 callback; WORD callmask; } mouse_info; @@ -52,6 +53,22 @@ case 0x04: FIXME("Position mouse cursor\n"); break; + case 0x05: + TRACE("Return Mouse button press Information for %s mouse button\n", + BX_reg(context) ? "right" : "left"); + if (BX_reg(context)) { + BX_reg(context) = mouse_info.rbcount; + mouse_info.rbcount = 0; + CX_reg(context) = mouse_info.rlastx; + DX_reg(context) = mouse_info.rlasty; + } else { + BX_reg(context) = mouse_info.lbcount; + mouse_info.lbcount = 0; + CX_reg(context) = mouse_info.llastx; + DX_reg(context) = mouse_info.llasty; + } + AX_reg(context) = mouse_info.but; + break; case 0x07: FIXME("Define horizontal mouse cursor range\n"); break; @@ -106,7 +123,8 @@ if (!VGA_GetMode(&Height,&Width,NULL)) { /* may need to do some coordinate scaling */ - SX = 640/Width; + if (Width) + SX = 640/Width; if (!SX) SX=1; } mouse_info.x = LOWORD(lParam) * SX; @@ -119,6 +137,9 @@ case WM_LBUTTONDBLCLK: mouse_info.but |= 0x01; mask |= 0x02; + mouse_info.llastx = mouse_info.x; + mouse_info.llasty = mouse_info.y; + mouse_info.lbcount++; break; case WM_LBUTTONUP: mouse_info.but &= ~0x01; @@ -128,6 +149,9 @@ case WM_RBUTTONDBLCLK: mouse_info.but |= 0x02; mask |= 0x08; + mouse_info.rlastx = mouse_info.x; + mouse_info.rlasty = mouse_info.y; + mouse_info.rbcount++; break; case WM_RBUTTONUP: mouse_info.but &= ~0x02;

1 0

Filename parsing
by Duane Clark Jan. 26, 2002

Jan. 26, 2002

Modified files: dlls/commdlg : file.c Log message: Codeweavers Add SHGDN_FORPARSING flag when looking for filenames. Index: dlls/commdlg/filedlg95.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/filedlg95.c,v retrieving revision 1.62 diff -u -r1.62 filedlg95.c --- dlls/commdlg/filedlg95.c 2001/12/04 19:39:33 1.62 +++ dlls/commdlg/filedlg95.c 2002/01/26 14:54:17 @@ -2374,7 +2374,7 @@ { /* get the total length of the selected file names*/ lpstrTemp[0] = '\0'; - GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER, lpstrTemp ); + GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER|SHGDN_FORPARSING, lpstrTemp ); if ( ! IsPidlFolder(fodInfos->Shell.FOIShellFolder, pidl) ) /* Ignore folders */ { @@ -2403,7 +2403,7 @@ { /* get the file name */ lpstrTemp[0] = '\0'; - GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER, lpstrTemp ); + GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER|SHGDN_FORPARSING, lpstrTemp ); if (! IsPidlFolder(fodInfos->Shell.FOIShellFolder, pidl)) /* Ignore folders */ {

1 0