January 2002 - Wine-Devel - list.winehq.org

Patch for OLEClipbrd_IDataObject_GetData
by Sander van Leeuwen Jan. 26, 2002

Jan. 26, 2002

Hi, Forte Agent was unable to copy text from the clipboard into the message body window because of a bug in this method. I'm not sure how Wine's clipboard implementation works, but handles returned by GetClipboardData are not supposed to be valid after the app calls CloseClipboard (see MS docs). The attached patch makes a copy of the clipboard handle and passes that to the application. Forte Agent frees this handle after it has extracted the clipboard data, so there's no memory leak. Sander

1 0

The cat is out of the bag (Lindows)
by Hetz Ben Hamo Jan. 26, 2002

Jan. 26, 2002

Hi People, In case you didn't see - Lindows "preview" review is on www.newsforge.com... Hetz

1 1

cvs run
by lee johnson Jan. 26, 2002

Jan. 26, 2002

just got wine cvs but it refuses to run even with copying missing shared file from $HOME to say /usr/lib here is error: --------------- [codewind(a)imyourhandiman codewind]$ wine wine: error while loading shared libraries: libwine.so: cannot open shared object file: No such file or directory [codewind(a)imyourhandiman codewind]$ thx lee -====

2 1

Does Windows have one of these?
by Bill Medland Jan. 25, 2002

Jan. 25, 2002

As I look deeper into the DrawText boundary behaviour it becomes clear to me that the Microsoft version must actually keep the & symbols in the string until the very last moment. In particular it looks to me like they actually measure strings that contain them. I can't see how they can do that with GetTextExtent and its relatives; I can't see where to hide a flag as to whether to interpret the & or not. Does anyone know if there are Microsoft undocumented functions or undocumented ways to measure and output a text that includes & symbols with a way of specifying whether they count as prefix characters or not? Personally it seems silly to me and I don't intend doing so myself unless there is a good reason to duplicate all of Microsoft's weird bugs. Bill

1 0

RE: Excessive clipping of text in listview
by Medland, Bill Jan. 25, 2002

Jan. 25, 2002

> -----Original Message----- > From: Dimitrie O. Paun [mailto:dimi(a)cs.toronto.edu] > Sent: Friday, January 25, 2002 9:11 AM > To: Bill Medland > Cc: wine-devel(a)winehq.com > Subject: Re: Excessive clipping of text in listview > > > On Fri, 25 Jan 2002, Bill Medland wrote: > > > Does anyone know how we (again) broke the text in the large > icon display of > > listview? It seems to come and go as we develop. > > <blush>I probably broke it</blush> I know the feeling. (not surprising given the size of the delta; you ought to see what my last big one would have screwed up). > > > The symptom. Our application has a ListView window. As of > yesterday's cvs > > most of the text only displays about 2 or 3 pixels wide, > while a few are > > readable. > > Are you using Unicode or ANSI? Can I get access to the code > to test with? ANSI Do you have access to the Microsoft "rowlist" sample? If so then use that but edit a couple of the labels to be longer than one line. It's the "being longer than one line" that messes it up. > > > I am just backtracking but I'm in a rush (I have to put together > > a demo machine by yesterday) and I'd like to know how far > back to go. > > Tell me, is 1.106 OK? Most likely the patch 1.106 -> 1.107 broke it. It did work on 1/jan so it was probably your delta. > > > -- > Dimi. > Thanks for the rapid response Bill p.s. what is going on in DrawLargeItem with the ellipsification; it looks like it ellipsifies it and then throws the result away. I am currently working on DrawText which should provide everything needed to draw the text properly. I am feeding it to Alexandre in small pieces so that we don't break anything. Microsoft, as far as I can see, don't actually use DrawText; they appear to reimplement all the ellipsification but I don't see why.

3 6

RE: Excessive clipping of text in listview
by Medland, Bill Jan. 25, 2002

Jan. 25, 2002

Panic over; the 20020101 version will do for now. > -----Original Message----- > From: Dimitrie O. Paun [mailto:dimi(a)cs.toronto.edu] > Sent: Friday, January 25, 2002 9:11 AM > To: Bill Medland > Cc: wine-devel(a)winehq.com > Subject: Re: Excessive clipping of text in listview > > > On Fri, 25 Jan 2002, Bill Medland wrote: > > > Does anyone know how we (again) broke the text in the large > icon display of > > listview? It seems to come and go as we develop. > > <blush>I probably broke it</blush> > > > The symptom. Our application has a ListView window. As of > yesterday's cvs > > most of the text only displays about 2 or 3 pixels wide, > while a few are > > readable. > > Are you using Unicode or ANSI? Can I get access to the code > to test with? > > > I am just backtracking but I'm in a rush (I have to put together > > a demo machine by yesterday) and I'd like to know how far > back to go. > > Tell me, is 1.106 OK? Most likely the patch 1.106 -> 1.107 broke it. > > > -- > Dimi. >

1 0

Excessive clipping of text in listview
by Bill Medland Jan. 25, 2002

Jan. 25, 2002

Does anyone know how we (again) broke the text in the large icon display of listview? It seems to come and go as we develop. The symptom. Our application has a ListView window. As of yesterday's cvs most of the text only displays about 2 or 3 pixels wide, while a few are readable. I am just backtracking but I'm in a rush (I have to put together a demo machine by yesterday) and I'd like to know how far back to go. Bill

2 1

Re: Patch to improve Microsoft Office 2000 functionality
by Duane Clark Jan. 25, 2002

Jan. 25, 2002

Jeremy White wrote: > ... > by getting it out now, maybe some other folks will help out <grin>. > I'll be happy to sync this to the current CVS, test it out with the apps I have, and chop it up into a series of patches, if no one else wants to take that on.

2 4

C++ Winelib problems
by Peter Hunnisett Jan. 25, 2002

Jan. 25, 2002

Hello all, I've been tooling around with building a C++ application using Winelib and I've come across a couple of problems resulting from the use of global constructors. The problems can be reproduced with a simple C++ application which from a constructor calls a method which is resolved through a dll import. 1) If this program is the main program, wine_dll_set_callback has not yet been invoked so the __wine_dll_register call doesn't resolve the import list. The problem is that the constructors of the program are run immediately after the dll is registered which results in calling a non resolved import. This can be worked around by simply creating a non C++ stub which does a LoadLibrary/GetProcAddress on the real main exe. However I'm wondering if there is a good reason for needing to wait until after the main exe is loaded before being able to resolve imports? I must be missing something from my quick view of the code. 2) The order of running constructor execution and DLL entry point is incorrect. To show the problem assume you have foo.dll which imports bar.dll Present order for builtins: Load foo.dll Start to resolve foo.dll dependencies Start to resolve bar.dll dependencies Finsh resolving bar.dll dependencies Run bar.dll C++ constructors Finish resolving foo.dll dependencies Run foo.dll C++ constructors Run bar.dll DLL entry point Run foo.dll DLL entry point I actually haven't checked if PE images presently have the same problem since I don't know what triggers the ctor execution for a PE image. I assume that it's the running of the DLL entry point, but I don't know for sure. Hopefully I'll find the time at some point this week to whip up a test. The correct order: Load foo.dll Start to resolve foo.dll dependencies Start to resolve bar.dll dependencies Finsh resolving bar.dll dependencies Run bar.dll C++ constructors Run bar.dll DLL entry point Finish resolving foo.dll dependencies Run foo.dll C++ constructors Run foo.dll DLL entry point The problem seems reasonably simple enough to resolve but I'm sure that I'm missing something since my patch doesn't work for the present version of wine :(. I think that the problem is that there's an issue with inter DLL dependencies somewhere as it dies in SYSMETRICS_Init with a bad hdc. I've attached a patch which removes the recursive dep search from MODULE_DllProcessAttach and moves MODULE_DllProcessAttach from LoadLibraryExA into MODULE_LoadLibraryExA. Does this seem like a reasonable approach to take? Any problems with the patch? Ciao, Peter

2 2

Word97 (winver win95) - no luck with wine
by Heiko Nardmann Jan. 25, 2002

Jan. 25, 2002

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi! I have problems starting Word97 using wine-20020122. I use the following command line: env LANG=de_DE LD_LIBRARY_PATH=/opt/wine-20020122/lib:$LD_LIBRARY_PATH /opt/wine-20020122/bin/wine --winver=win95 winword.exe The working directory is: /usr/Windows_NT_Files/Programs/Office/Word Inside this directory there are the following files: - -rwxr----- 1 nardmann users 1108752 Jun 23 2001 MSO7DEU.DLL - -rwxr--r-- 1 nardmann users 3792896 Aug 18 2000 mso97.dll - -rw-r--r-- 1 nardmann users 31232 Jun 29 2001 Normal.dot - -rwxr--r-- 1 nardmann users 5337088 Mai 8 2001 winword.exe - -rwxr--r-- 1 nardmann users 1724416 Aug 18 2000 wwintl32.dll I do not use an installed Windows, only these files! I use Wine on SuSE Linux 7.1 remote using Exceed on Windows NT 4.0. Some time ago I got Word97 running using a CVS version but now I get the following: For language 'german' several language ids were found: de_DE - 0407; de_CH - 0807; de_LU - 1007; de_LI - 1407; Instead of using first in the list, suggest to define your LANG environment variable like this: LANG=de_DE fixme:keyboard:X11DRV_KEYBOARD_DetectLayout Your keyboard layout was not found! Using closest match instead (German keyboard layout without dead keys) for scancode mapping. Please define your layout in windows/x11drv/keyboard.c and submit them to us for inclusion into future Wine releases. See the Wine User Guide, chapter "Keyboard" for more information. wine: Unhandled exception, starting debugger... And nothing happens then ... I could add '--debugmsg +all' and provide gzipped file if necessary. How can I locate the problem? I tried to run Wine at the console of the Linux machine logged in as root instead of user nardmann. Then I see the splash screen and get a message box saying that my registry is corrupted and that I should restart the Word setup program. I cannot click the button in this message box. I am going to check the '--debugmsg +reg' output during the next week and compare it with the contents of the registry in the .wine directory and the registry on my local WinNT machine. Running Wine remote using Exceed but being root gives me the following in the shell: snsrv053:root[Word]#env LANG=de_DE LD_LIBRARY_PATH=/opt/wine-20020122/lib:$LD_LIBRARY_PATH /opt/wine-20020122/bin/wine --winver=nt40 winword.exe fixme:keyboard:X11DRV_KEYBOARD_DetectLayout Your keyboard layout was not found! Using closest match instead (German keyboard layout without dead keys) for scancode mapping. Please define your layout in windows/x11drv/keyboard.c and submit them to us for inclusion into future Wine releases. See the Wine User Guide, chapter "Keyboard" for more information. X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 1 (X_CreateWindow) Serial number of failed request: 27 Current serial number in output stream: 37 The display variable is set correctly. How can I debug this bug? - -- Heiko Nardmann (Dipl.-Ing.), h.nardmann(a)secunet.de, Software Development secunet Security Networks AG - Sicherheit in Netzwerken (www.secunet.de) Weidenauer Str. 223-225, D-57076 Siegen Tel. : +49 271 48950-13, Fax : +49 271 48950-50 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8URippm53PRScYygRAnAZAJ4tAWZzU+QnKaChlXFZtyvJJkLwhQCgsoUG WwRlq+Fb46jaQuZ7s0kHbAI= =ObqT -----END PGP SIGNATURE-----

1 0

C testing framework. ASCII/Unicode portable version
by Andriy Palamarchuk Jan. 24, 2002

Jan. 24, 2002

Attached version of the C testing framework, which is implemented with using TCHAR.H macros, so it is portable between ASCII and Unicode platforms. Also implemented test which can be used to test ASCII and Unicode API. As I found out creating ASCII/Unicode portable code requires much more attention than creating plain ASCII-only code, probably the same level of difficulty as creation Unicode-only code. Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

5 33

Re: Microsoft's version of "WINE"
by Srdjan Matovina -- Customer Engineering Jan. 23, 2002

Jan. 23, 2002

They use MainWin from MainSoft Inc. See http://www.mainsoft.com >To: wine-devel(a)winehq.com >From: "Sander Wichers" <wichers(a)usa.net> >Subject: Microsoft's version of "WINE" >X-Priority: 3 >X-MSMail-Priority: Normal >X-Newsreader: Microsoft Outlook Express 5.50.4807.1700 >X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 >X-BeenThere: wine-devel(a)winehq.com >X-Mailman-Version: 2.0 >List-Help: <mailto:wine-devel-request(a)winehq.com?subject=help> >List-Post: <mailto:wine-devel(a)winehq.com> >List-Subscribe: <http://www.winehq.com/mailman/listinfo/wine-devel>, <mailto:wine-devel-request(a)winehq.com?subject=subscribe> >List-Id: Wine Developer's List <wine-devel.winehq.com> >List-Unsubscribe: <http://www.winehq.com/mailman/listinfo/wine-devel>, <mailto:wine-devel-request(a)winehq.com?subject=unsubscribe> >List-Archive: <http://www.winehq.com/hypermail/wine-devel/> >Date: Wed, 23 Jan 2002 16:20:35 +0100 > >Hi, > >Maybe you guys already seen this, and it's old news for you... but i'll post >this anyway in case you didn't know. It can be a good thing to learn from. > >I do not own a SUN or a HP-UX system. But I was just interested how >microsoft implemented IE 4 / IE 5 on HP-UX and SUN. So I extracted their >installation files to disk. It seems that microsoft made their own version >of wine. It's amazing that they didn't modified IE to run on unix. Instead >they made the choice to emulate all the windows functionality. And compile >IE on that. Microsoft is ready to run their applications on linux. They have >a complete "system" libary full of ported functionality to SUN and HP-UX... >all the libaries are there, libkernel32.so etc.... It's also nice to see how >they seperated the resources from the binaries. and let the kernel deal with >these resource files. > >Has any one of you looked into these system libaries? Is this information >relevant to anyone? > >bye, > >Sander Wichers > > > > > > ==== Srdjan Matovina Sun Microsystems Inc. SunPS Integration Services/ Americas Customer Engineering srdjan.matovina(a)sun.com Ph.(905) 415-2883 Fax.(905) 477-0217

2 1

Privaleged instruction
by Nog Jan. 23, 2002

Jan. 23, 2002

Hi, Just for the fun of it I tried to run the dos installer of Mechwarrior 2: Mercenaries. It didn't get too far as the installer crashed on an unhandeled Privileged instruction. According to winedbg the instruction is 0x0002:0x10000 push %cs. To see what the opcode of this instruction might be, I added a trace to the INSTR_EmulateInstruction. Looking at the trace I found that the instruction it was having to emulate was 0x00 which looks very wrong to me. But just to check I simply made that function return true if the instruction was 0x00 but this only seemed to make things worse, the exception still occured but the debugger didn't launch. What I would like to know is, is push %cs realy a Privileged instruction (which I think it might be)? Looking into why INSTR_EmulateInstruction doesn't get the right pointer, the offset looked too big to me. Shouldn't it roll over to the next segment after 0xffff? The problem with the way that it is now is that the following macro, which converts the segment offset pair to linear addresses cuts off the upper bits, which looks correct. #define PTR_REAL_TO_LIN(seg,off) \ ((void*)(((unsigned int)(seg) << 4) + LOWORD(off))) What I want to know is why the offset is so high? nog.

2 1

RE: runtest: new option -M for testing current module as builtin
by Patrik Stridvall Jan. 23, 2002

Jan. 23, 2002

> On Wed, 23 Jan 2002, Patrik Stridvall wrote: > [...] > > BEGIN { > > require wine; > > &wine::module_native("wininet"); > > &wine::module_builtin("imm32", "msacm32"); > > } > > I am not sure any test should require the native version > of any dll. > > We cannot ship native dlls with Wine for obvious reasons, so requiring > the native dll would force Wine developpers to have a Windows > partition > installation around, and one configured for use in the tests. > Otherwise > they would not be able to run the tests, would they? > > I don't think that's good. Of course it shouldn't require it. It should simply skip parts of the test if the native version is not available. if(&wine::is_native("wininet")) { # Do native wininet tests } > Choosing to use a native dll is more up to the developper > to debug a > test. And then modifying the configuration file, as we usually do to > debug applications, should be simple and familiar enough. > > But maybe I misunderstood something. Well it allows us to automatically test a non-developer Windows installation directly under Linux without requiring him to reboot. Even developers make find it useful to quickly be able to modify the loadorder without having to modify his configuration. Sometimes what you want to test is quite subtle, like you have a function A in module B that calls function C in module D. Perhaps you want to test the robustness of Wines implementation of function A by testing it both with the native and the builtin version of D. If you have many such tests it would be a lot of unnessary manual work to switch D between native and builtin while testing B as builtin. Then perhaps somebody else have some use I haven't even though of. The main use will be I think to force tests to as the default test the builtin version since if you type "make test" in a directory you really expect to test the files in THAT directory, not the native version even if your ~/.wine/config specifies that.

1 0

Re: runtest: new option -M for testing current module as builtin
by Francois Gouget Jan. 23, 2002

Jan. 23, 2002

On Wed, 23 Jan 2002, Patrik Stridvall wrote: [...] > BEGIN { > require wine; > &wine::module_native("wininet"); > &wine::module_builtin("imm32", "msacm32"); > } I am not sure any test should require the native version of any dll. We cannot ship native dlls with Wine for obvious reasons, so requiring the native dll would force Wine developpers to have a Windows partition installation around, and one configured for use in the tests. Otherwise they would not be able to run the tests, would they? I don't think that's good. Choosing to use a native dll is more up to the developper to debug a test. And then modifying the configuration file, as we usually do to debug applications, should be simple and familiar enough. But maybe I misunderstood something. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

1 0

Re: wine/windows dialog.c
by Uwe Bonnes Jan. 23, 2002

Jan. 23, 2002

>>>>> "Alexandre" == Alexandre Julliard <julliard(a)winehq.com> writes: Alexandre> ChangeSet ID: 1011730184150795614346862 CVSROOT: Alexandre> /opt/cvs-commit Module name: wine Changes by: Alexandre> julliard(a)wine2. 02/01/22 15:09:44 Alexandre> Modified files: windows : dialog.c Alexandre> Log message: Removed no longer used average width Alexandre> calculation. Well, for the encarta 99 setup this gives the same bad result as before. I have attached a gif of the dialog in question. The manual calculation with the corrections in my resent patch gave better results. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Microsoft's version of "WINE"
by Sander Wichers Jan. 23, 2002

Jan. 23, 2002

Hi, Maybe you guys already seen this, and it's old news for you... but i'll post this anyway in case you didn't know. It can be a good thing to learn from. I do not own a SUN or a HP-UX system. But I was just interested how microsoft implemented IE 4 / IE 5 on HP-UX and SUN. So I extracted their installation files to disk. It seems that microsoft made their own version of wine. It's amazing that they didn't modified IE to run on unix. Instead they made the choice to emulate all the windows functionality. And compile IE on that. Microsoft is ready to run their applications on linux. They have a complete "system" libary full of ported functionality to SUN and HP-UX... all the libaries are there, libkernel32.so etc.... It's also nice to see how they seperated the resources from the binaries. and let the kernel deal with these resource files. Has any one of you looked into these system libaries? Is this information relevant to anyone? bye, Sander Wichers

1 0

Verbose tests ?
by Sylvain Petreolle Jan. 23, 2002

Jan. 23, 2002

Hi, running programs/winetest/runtest -v -v -v -v -v tests/wine.pl or programs/winetest/runtest -vvvvv only reports : tests/wine.pl: 22 tests executed, 2 marked as todo, 0 failures. Is this the normal behavior or have I made something wrong ? ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Courrier : http://courrier.yahoo.fr

2 1

Open Letter to DOJ re Microsoft Settlement
by Dan Kegel Jan. 22, 2002

Jan. 22, 2002

The proposed settlement in the Microsoft antitrust trial will probably be accepted by the judge unless a lot of people complain soon, even though it lacks any useful enforcement provisions and fails to prohibit many of Microsoft's anticompetitive practices. I've drafted an open letter to the Department of Justice to explain why the proposed settlement should not be accepted; it's at http://www.kegel.com/remedy/letter.html I'd be honored if you would read it, and consider signing it with me, or submitting your own comment to the DOJ. Either way, the federal deadline for public comment is Monday the 28th. For more information, see http://www.kegel.com/remedy/ See also Jeremy White's page http://www.codeweavers.com/~jwhite/tunney.html Sincerely, Dan Kegel

2 2

sparc solaris build
by Srdjan Matovina -- Customer Engineering Jan. 22, 2002

Jan. 22, 2002

Hi, I've built wine-20011226 on sparc with the only one issue left open: The resource compiler wrc core dumps when hit the bitmap (BINRES) part of .rc file. There is an alignment problem inside convert_bitmap() in newstruc.c file. The alignment problem came out from BITMAPINFOHEADER struct. But this was just the beginning! I've commented out body of convert_bitmap() just to see what will happen when run libtest/hello test case. After running wineserver, the libtest/hello core with the same problem: Program terminated by signal BUS (invalid address alignment). This time at different place: RtlSecondsSince1970ToTime from ntdll.so (time.c) struct FILETIME. Obviously I'll have an alignment problem with every structure in general. Is there any guideline for this kind of problem? Thanks Srdjan

2 1

Re: [PATCH] Overlapped recv(), WSARecv()
by Martin Wilck Jan. 22, 2002

Jan. 22, 2002

As you may see from the different email address, I am currently off work - I'll look deeper into your traces next week. Many thanks for generating them, anyway. >From a first glance, it seems that the app doesn't do overlapped recv(). (lpOverlapped & completion_func are always NULL), so there should actually be no difference (well I'm now using recvmsg() instead of recv(), and the overhead for 16 bit Winsock apps is definitely larger, but I cannot see why that should slow everything down that much). Perhaps I screwed up the blocking semantics of non-overlapped IO. Have you generated the traces under exactly the same conditions? Can you explain what exactly you did? Martin

3 7

Article about WINE on DesktopLinux.com
by Roland Jan. 22, 2002

Jan. 22, 2002

Hello, I found a very interesting article about WINE there: http://www.desktoplinux.com/articles/AT5502857506.html I have to fully agree with that author, I think he is a real genius! :))) Roland

1 0

Re: Decorationless managed windows again
by Alexandre Julliard Jan. 21, 2002

Jan. 21, 2002

Ove Kaaven <ovehk(a)ping.uio.no> writes: > The logic in this patch is now somewhat revised according to Alexandre's > comments. I did not make this configurable, though, thinking that if the > user's WM really is too old to support them, then he probably wouldn't > mind getting more top-level windows managed anyway... Top-level windows maybe not, but menus and tooltips with wm decorations are pretty annoying... so I applied it, but without the is_window_managed changes, we will need a better algorithm there. -- Alexandre Julliard julliard(a)winehq.com

2 4

Re: Some fixes for dumb X errors :-)
by Alexandre Julliard Jan. 21, 2002

Jan. 21, 2002

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > PS for Alexandre: we once discussed how we could 'streamline' this X error > handling (ie to prevent doing the same kind of code at three different > locations in the Wine code). Did you progress on this issue or not ? Yes, here's what I came up with. Basically you have to wrap the call that might fail with X11DRV_expect_error/X11DRV_check_error. Would this work for what you need to do? Index: dlls/x11drv/x11drv_main.c =================================================================== RCS file: /opt/cvs-commit/wine/dlls/x11drv/x11drv_main.c,v retrieving revision 1.47 diff -u -r1.47 x11drv_main.c --- dlls/x11drv/x11drv_main.c 2001/11/30 23:15:32 1.47 +++ dlls/x11drv/x11drv_main.c 2002/01/21 18:58:48 @@ -63,6 +63,12 @@ static char *desktop_geometry; static XVisualInfo *desktop_vi; +static x11drv_error_callback err_callback; /* current callback for error */ +static Display *err_callback_display; /* display callback is set for */ +static void *err_callback_arg; /* error callback argument */ +static int err_callback_result; /* error callback result */ +static int (*old_error_handler)( Display *, XErrorEvent * ); + #define IS_OPTION_TRUE(ch) \ ((ch) == 'y' || (ch) == 'Y' || (ch) == 't' || (ch) == 'T' || (ch) == '1') #define IS_OPTION_FALSE(ch) \ @@ -97,12 +103,57 @@ } #endif /* NO_REENTRANT_X11 */ + +/*********************************************************************** + * X11DRV_expect_error + * + * Setup a callback function that will be called on an X error. The + * callback must return non-zero if the error is the one it expected. + * This function acquires the x11 lock; X11DRV_check_error must be + * called in all cases to release it. + */ +void X11DRV_expect_error( Display *display, x11drv_error_callback callback, void *arg ) +{ + wine_tsx11_lock(); + XSync( display, False ); + err_callback = callback; + err_callback_display = display; + err_callback_arg = arg; + err_callback_result = 0; +} + + +/*********************************************************************** + * X11DRV_check_error + * + * Check if an expected X11 error occurred; return non-zero if yes. + * Also release the x11 lock obtained in X11DRV_expect_error. + */ +int X11DRV_check_error(void) +{ + int ret = err_callback_result; + XSync( err_callback_display, False ); + err_callback = NULL; + wine_tsx11_unlock(); + return ret; +} + + /*********************************************************************** * error_handler */ -static int error_handler(Display *display, XErrorEvent *error_evt) +static int error_handler( Display *display, XErrorEvent *error_evt ) { - DebugBreak(); /* force an entry in the debugger */ + if (err_callback && display == err_callback_display) + { + if ((err_callback_result = err_callback( display, error_evt, err_callback_arg ))) + { + TRACE( "got expected error\n" ); + return 0; + } + } + if (synchronous) DebugBreak(); /* force an entry in the debugger */ + old_error_handler( display, error_evt ); return 0; } @@ -297,6 +348,7 @@ screen = DefaultScreenOfDisplay( display ); visual = DefaultVisual( display, DefaultScreen(display) ); root_window = DefaultRootWindow( display ); + old_error_handler = XSetErrorHandler( error_handler ); /* Initialize screen depth */ @@ -328,11 +380,7 @@ */ TSXOpenIM( display, NULL, NULL, NULL); - if (synchronous) - { - XSetErrorHandler( error_handler ); - XSynchronize( display, True ); - } + if (synchronous) XSynchronize( display, True ); screen_width = WidthOfScreen( screen ); screen_height = HeightOfScreen( screen ); Index: include/x11drv.h =================================================================== RCS file: /opt/cvs-commit/wine/include/x11drv.h,v retrieving revision 1.95 diff -u -r1.95 x11drv.h --- include/x11drv.h 2002/01/04 18:27:45 1.95 +++ include/x11drv.h 2002/01/21 18:59:08 @@ -391,7 +391,9 @@ extern void X11DRV_SetFocus( HWND hwnd ); extern Cursor X11DRV_GetCursor( Display *display, struct tagCURSORICONINFO *ptr ); -extern void X11DRV_expect_error( unsigned char request, unsigned char error, XID id ); +typedef int (*x11drv_error_callback)( Display *display, XErrorEvent *event, void *arg ); + +extern void X11DRV_expect_error( Display *display, x11drv_error_callback callback, void *arg ); extern int X11DRV_check_error(void); extern void X11DRV_register_window( Display *display, HWND hwnd, struct x11drv_win_data *data ); extern void X11DRV_set_iconic_state( WND *win ); -- Alexandre Julliard julliard(a)winehq.com

1 0

Some musings about DGA2 support in Wine...
by Lionel Ulmer Jan. 21, 2002

Jan. 21, 2002

Hi all, After being prodded by people on #WineHQ to look at the current DGA2 problem in Wine (it it works fine for graphics, but does not accept any user input at all and needs to either kill Wine remotely or do the three finger salute to the X server), I found the following things : - the DGA2 code (in dlls/x11drv/dga2.c) used the gdi_display connection to open the framebuffer and setting-up all the input handling. But it was the thread->display connection that was used to process the events. This is a no-go as when DGA2 is entered, there is only one connection that receives the event, the one which has grabbed the frame buffer (thanks to Ove to remind me of the 'one connection per thread' thingy). - so I removed all the mentions to 'gdi_display' in dga2.c and replaced them by the current thread display and still no go (although I checked that the event processing in WaitForMultipleEvents and subsequent process_events was done on the correct display). Still no go. So I investigated a bit with a little test program : = I did first try setting up DGA2 in a separate display and then doing all the 'standard' processing on another display (that is Wine does with DGA2 set-up in the init function to test if DGA2 is available and then really use it in another thread). As my test application still was working fine, this was not the problem... = then, I saw in the logs some calls to X11DRV functions after we have entered DGA2 (some due to the DDraw stuff creating DIB sections and so on, some due to the application I think). After adding the same stuff in my test program (ie I created a window just after entering DGA2), I found that it perturbed the event processing (I still had motion events, but neither key presses nor button presses). - so, finally, just to try, I backed off my changes in dga2.c (ie I used again the gdi_display for all the set-up) and had the process_events function in windows/x11drv/event.c use gdi_display instead of data->display when DGA was used (by testing the DGAUsed variable). And now it seems to work just fine.... All this leads now to the 10 � (an Euro sign for all the people not having an iso8859-15 font :-) ) question : how to fix this 'properly' and not with the hack I just did ? The only somewhat 'clean' solution I found would be to create a display connection specifically used for DGA2 (thus we would be sure that no X calls would 'pollute' the link). And in process_events, if DGA2 is used, use this connection instead of the thread connection (we already have some DGA specific variables there, what would be one more :-)) ). After, the question would be how we are sure that it's the 'good' WaitForMultipleEvents that receives the events (if the application is multi-threaded and has multiple threads calling this function). Anyway, if people want just to play some games using DGA2, they can always use my hacky solutions I just described up there :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 2

Re: _UNICODE vs UNICODE
by Andriy Palamarchuk Jan. 21, 2002

Jan. 21, 2002

Francois Gouget wrote: > On Fri, 18 Jan 2002, Andriy Palamarchuk wrote: > > Using macro name "UNICODE" instead of "_UNICODE" is a > > typo, right? > > No, not necessarily. Windows has both and dinput.h, > for instance, > uses UNICODE, not _UNICODE. > > But I have no idea why they have two. I did a little research and found in a few places information that UNICODE is used by Windows headers, _UNICODE is used by C-runtime/MFC headers. However I did not find official explanation of this. Some examples, including a few MSDN ones, define both. E.g. see: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/wss/wss/_e… Can you tell now where we need to use which one? Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

2 1

Re: GetPrivateProfileInt*() fix
by Alexandre Julliard Jan. 21, 2002

Jan. 21, 2002

Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> writes: > these functions were pretty much broken (overflow and signed/unsigned > behaviour), so I fixed almost every problem. Why did you add an exception handler? Do you have an app that passes garbage pointers to GetPrivateProfileInt? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Unnecessary imports?
by Ove Kaaven Jan. 21, 2002

Jan. 21, 2002

On Mon, 21 Jan 2002, Francois Gouget wrote: > Compiling Wine I noticed many warnings saying that the dlls we import > are not used. Is there any reason to still import them? I suppose it could in many cases be because someone *plan* to import stuff from there sometime later (after they've churned out some code to fill the stubs in the dll implementation with)...

3 2

Re: struct async-private - now tested and cleaned up
by Mike McCormack Jan. 21, 2002

Jan. 21, 2002

Hi Martin, Each DLL should only import standard win32 api functions exported by other (lower level) DLLs. Where possible, the code should be able to be compiled and run on a windows box. (ok, that excludes kernel, gdi, user, winsock, etc). That is necessary to support dll=native linking. In theory, we should only have to implement ntdll and the device driver interfaces, then Microsoft's kernel, gdi, user, etc. would all run on top of those too. Practically, some of our low level DLLs need the wineserver interface. Your client side register_async() func should be present in all the dlls that use it because Windows has no equivilent export from NTDLL (or any other dll). Maybe you could create an inline function in a header? My guess is that WinNT implements WSARecv() and ReadFile() using something like NtReadFile(). http://www.osr.com/ntinsider/1996/native.htm Mike > On 16 Jan 2002, Alexandre Julliard wrote: > > > Also note that because of dll separation you cannot use functions like > > register_async() from winsock. If absolutely necessary they could be > > exported, but I think it would be much better to use straight server > > calls (and in theory these functions shouldn't be used from comm.c > > either). > > Hmm. I guess I don't fully understand dll separation. Are you telling me > that the scheduling mechanism for async requests shouls be implemented > separately in each DLL? If so, I could have spared my efforts to build > a "generic" interface to async requests. I'd just mention that > this would be error-prone, because different parts of wine with > equivalent functionality would need to be maintained. Note > that an app is allowed to mix ReadFile() and WSARecv() calls > for a socket (however braindead that would be). I'd assume that > in Windows there must be a hidden layer for asynchronous requests > somewhere, too, or do you think their respective code is completely > separate? ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

MapVirtualKeyExA fixme
by John Atkinson Jan. 21, 2002

Jan. 21, 2002

I've been using an app that the shortcut keys don't work, I get the following messages. fixme:keyboard:MapVirtualKeyExA (17,0,0x04090409), hkl unhandled! fixme:keyboard:MapVirtualKeyExA (68,0,0x04090409), hkl unhandled! fixme:keyboard:MapVirtualKeyExA (18,0,0x04090409), hkl unhandled! fixme:keyboard:MapVirtualKeyExA (90,0,0x04090409), hkl unhandled! Does anyone know how to fix this type of problem. TIA

1 0

Re: small configure patch
by Andreas Mohr Jan. 21, 2002

Jan. 21, 2002

On Sun, Jan 20, 2002 at 09:49:49PM +0100, Ove Kaaven wrote: > Log: > Andrew Lewycky <andrew(a)transgaming.com> > Ove Kaaven <ovek(a)transgaming.com> > Check for common broken nVidia+Mesa OpenGL library setups. > Add some quoting. > > Index: wine/configure.in > diff -u wine/configure.in:1.1.1.25 wine/configure.in:1.50 > --- wine/configure.in:1.1.1.25 Wed Jan 16 10:58:58 2002 > +++ wine/configure.in Fri Jan 18 09:28:22 2002 > @@ -253,6 +281,14 @@ > ) dnl *** End of X11/Xlib.h check > > dnl Check for the presence of OpenGL > + > + if test -e /usr/X11R6/lib/libGL.a -a ! -e /usr/X11R6/lib/libGL.so > + then > + AC_MSG_ERROR( > +[/usr/X11R6/lib/libGL.a is present on your system. > +This prevents linking to OpenGL. Delete the file and restart configure.]) > + fi Umm, doesn't this get cached in config.cache ? Shouldn't we therefore add to delete config.cache before restarting, too ? -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

2 1

Fix for the web site (WineHQ)
by Francois Gouget Jan. 21, 2002

Jan. 21, 2002

This fixes a bug in the Web site: a pre tag was not closed properly. Changelog: * dev.shtml Fix a mis-closed <pre> tag -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

3 2

Re: struct async-private - now tested and cleaned up
by Alexandre Julliard Jan. 21, 2002

Jan. 21, 2002

Martin Wilck <Martin.Wilck(a)fujitsu-siemens.com> writes: > It is a polished resubmit of my former posting, without the GetOverlappedResult() stuff > which will follow in a separate patch. It is against clean CVS 2002-01-15. > > I would be really grateful if this patch was applied, because it is a prerequisite for me to > get going with Winsock2 overlapped IO. The comm.c part doesn't apply, are you sure this is against a clean CVS? You should probably consider using cvs diff, it helps making sure you do the diff against the right file. Also note that because of dll separation you cannot use functions like register_async() from winsock. If absolutely necessary they could be exported, but I think it would be much better to use straight server calls (and in theory these functions shouldn't be used from comm.c either). -- Alexandre Julliard julliard(a)winehq.com

3 2

Re: SetEndOfFile fix
by Andreas Mohr Jan. 21, 2002

Jan. 21, 2002

On Sun, Jan 20, 2002 at 08:13:53PM +0100, Rein Klazes wrote: > hi, > > This fixes office 97 MSword error (disk full or write protected) when > saving files on a vfat partition. MSword calls SetEndOfFile() which > uses ftruncate() that, in Linux, cannot grow files in this filesystem. Ah ! :-))) I already suspected this to be the case. At least I already found due to some error code that some ftruncate() must have failed, and I think I thus called it an ftruncate problem. Oh, and yes, that error condition was in the server, too, so it must have been this ftruncate. And one more: In several cases, some guys reported that programs needed some "touch"ing before being able to save a file. What do you wanna bet that *this* is the problem that's now solved ?? :) In short: a very important fix, I think. I guess we can call you a Wine Master now ;) -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0

Re: SetEndOfFile fix
by lawson_whitney＠juno.com Jan. 20, 2002

Jan. 20, 2002

On Sun, 20 Jan 2002, Rein Klazes wrote: > hi, > > BTW. A google search shows that the ftruncate problem has been > mentioned at least 3 times on c.e.m.w. in the last 6 months Since > nobody entered a fix, I could be overlooking something... Not exactly, I think. I remember several mentions of MSword (disk full or write protected), but nobody called it an ftruncate problem. I did think up some other rather ingenious ways you could misconfigure a fat filesystem to cause wine to be unable to save a file, but I missed ftruncate. I thought ftruncate only didn't work with umsdos, but I see I was wrong. I think you have just been paying better attention than some others of us. Good catch! > > Rein. > Lawson

1 0

Re: Questions for developing functions
by David Elliott Jan. 20, 2002

Jan. 20, 2002

On 2002.01.20 12:46 Gerhard W. Gruber wrote: > On Sun, 20 Jan 2002 11:38:48 -0500, David Elliott <dfe(a)tgwbd.org> wrote: > > >Well, if the code you contribute could be considered a derived work of > the > >code you disassembled then you'd have problems. But for instance if you > > >disassembled for the purposes of figuring out how many arguments the > >function takes and what not but didn't actually directly write your code > > >based on the disassembly, then you should be in the clear as far as that > > >is concerned. > > Of course I primarily use that insight to get information on what > arguments > are used. I don't intend to make a 1:1 representation of the binary code > to C. > :) > > >Now, as for the breaking of the license agreement on your software. > That > >mostly concerns you as you are the person under the license, not the > Wine > >project. So if you feel like you would get into legal trouble by even > >disassembling something to simply see what types of parameters it takes, > > >then I would suggest that you didn't do it. However if you feel that > you > >would not get into legal trouble, and assuming you don't create your > >implementation directly from the disassembly (i.e. you reimplement from > >scratch, but just use the disassembly to get some ideas of function > >parameters) then you should be very much in the clear, and so should the > > >wine project. > > Thanks. :) > Remember though.. I am not a lawyer, and I am not Alexandre Julliard. > >Hey man, if no one responds in this mailing list within a reasonable > >timeframe then probably no-one is working on it. Just have a go and if > >someone else beats you to it without saying anything you can always do a > > >peer-review of the code and see if maybe something should be done > >different. Two pairs of eyes are better than one. > > OK. Sorry to bother you with this, but I'm just starting out, so I don't > know > much about the procedure on how to contribute a bit. :) I'd also hate to > start > investingating when a few days later a patch is thrown at the list that > does > what I just started out to do. :) I also think that it wasted time on > behalf > of wine if many developers work on the same things and leave other areas > to > its own. > No, it's not a bother.. the fact that you just posted saying that you were gonna work on it is desirable. -Dave

1 0

Questions for developing functions
by Gerhard W. Gruber Jan. 20, 2002

Jan. 20, 2002

I have already posted this in the NG but I was told that this would be more appropriate here. One of my questions is how wine developers actualy develop their functions. I'm aware that some functions are (rather) easily determind just because of their name (i.e. CreateFile). Other functions can be derived from reading the documentation but there is quite a number of functions that arenot documented and some are not even mentioned anywhere (like functions in the rpcnt.dll). Now I wonder how you go about this. My approach would be to disassemble such functions and see how they work. Of course I know that in some countries this will be illegal while it is not in others. If I live in a country where this is legal would it still be a problem for the maintainer if I submit a function that is written based on the method I used to get the knowledge to write it? How do you circumvent that problem that you might infringe copyright as reverse engineering is usually prohibited by the licence where this licence is actually legally binding. Another question is concerning the function CreateDispTypeInfo. I'd like to work on Hotline which uses this function. As I noticed, this function is stubbed but not implemented and the last time it was worked on was somewhere in 2000, so I'd like to know if somebody is working on this. If I start work on it, do I have to submit this info somewhere in order to avoid duplicate work? Thanks. -- Bye, Gerhard If you think education is expensive, try ignorance.

2 1

Int 09 keyboard handler?
by Nog Jan. 20, 2002

Jan. 20, 2002

Hi there, For 3 days now I have been trying to get Monkey Island 2 to work with wine, but I just can't seem to make it respond to keyboard input. The game installs a keyboard handler on int 09 which works. When a key gets pressed on the keyboard the key does get queued and then Monkey Island reads the key from port 0x60, which returns the correct key. So everything seems to work on the wine side of things but the game does not respond in any way. I have attached a +int,+io trace if that helps anyone. nog.

1 0

Full screen, always on top window doesn't get keyboard input
by Ori Pessach Jan. 19, 2002

Jan. 19, 2002

Hello, While playing some more with Pajama Sam (for those of you who are wondering: yes, that's all I ever play. Pajama Sam Rocks!), I noticed the following bug: The game opens a full screen window, which doesn't get keyboard input. Furthermore, under RedHat 7.2's KDE 2 window manager, managed game dialog boxes appear BELOW the game window. The dialogs, even though they're invisible, respond to keyboard input. For example, it is possible to exit the game by clicking the exit icon, and pressing "Y", for Yes, on the dialog. Under Gnome's window manager (Sawfish?) the dialogs appear in front of the game window, but the game window still doesn't accept keyboard input. Under KDE, I can't get any other window to appear in front of the game window, nor can I minimize it. I looked at dlls/x11drv, and didn't see any WM hints being set that are obviously bad. Chances are that I wouldn't recognize bad WM hints even if they jumped up and bit me on the forehead, though. I've also poked around the system with xwininfo, and found out that the game has a full screen window, named "Pajama Sam", which has a nameless child window, which is also full window and visible. Only the parent window has any WM hints set. I seem to remember some discussion a while ago, about similar problems with installers (???). Could that be related? Bye, Ori _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

1 0

WinProc recursion
by Niclas Carlsson Jan. 19, 2002

Jan. 19, 2002

Hi! The 7 year old incarnation of m$word currently causes some weird problems. What happens is that a certain dlgproc (or winproc?) WM_NCPAINT handler calls DefWindowProc and then UpdateWindow. This last call causes Wine to emit a WM_PAINT which calls BeginPaint which emits a WM_NCPAINT etc ad nauseum. ==> Recursion until the stack overflows. Of course, other things may have made the logic in the winproc go haywire, but doing the same thing (calling DefWindowProc followed by UpdateWindow in WM_NCPAINT) under win95 works just fine. The same application bombs under Wine. I'm using CVS as of yesterday (20020118). Here's the relevant part of the word backtrace: 146 0x406450d5 (RedrawWindow+0x3b1(hwnd=0x1002a, rectUpdate=0x0, hrgnUpdate=0x0, flags=0x180) [painting.c:787] in libuser32.so) (ebp=40419b0c) 147 0x40645129 (UpdateWindow+0x21(hwnd=0x1002a) [painting.c:802] in libuser32.so) (ebp=40419b28) 148 0x500236e8 (winword.exe.PvAllocStack+0x10755 in D:\Program\office95\Winword\winword.exe) (ebp=40419ba8) 149 0x40656257 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=40419bcc) 150 0x406562ed (WINPROC_CallWndProc+0x8d(proc=0x50023491, hwnd=0x1002a, msg=0x85, wParam=0xbe76, lParam=0x0) [winproc.c:167] in libuser32.so) (ebp=40419bfc) 151 0x4065bb0b (CallWindowProcA+0x3b(func=0x50023491, hwnd=0x1002a, msg=0x85, wParam=0xbe76, lParam=0x0) [winproc.c:2594] in libuser32.so) (ebp=40419c24) 152 0x405f8df3 (call_window_proc+0xf3(hwnd=0x1002a, msg=0x85, wparam=0xbe76, lparam=0x0, unicode=0x0) [message.c:1106] in libuser32.so) (ebp=40419c74) 153 0x405f99c6 (SendMessageTimeoutA+0xea(hwnd=0x1002a, msg=0x85, wparam=0xbe76, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x40419cf4, hwnd=0x1002a) [message.c:1502] in libuser32.so) (ebp=40419ccc) 154 0x405f9b1f (SendMessageA+0x33(hwnd=0x1002a, msg=0x85, wparam=0xbe76, lparam=0x0) [message.c:1547] in libuser32.so) (ebp=40419cf8) 155 0x405fc29c (begin_ncpaint+0x90(hwnd=0x1002a) [painting.c:116] in libuser32.so) (ebp=40419d24) 156 0x405fc3a9 (BeginPaint+0x6d(hwnd=0x1002a, lps=0x40419da8) [painting.c:157] in libuser32.so) (ebp=40419d64) 157 0x50023575 (winword.exe.PvAllocStack+0x105e2 in D:\Program\office95\Winword\winword.exe) (ebp=40419de8) 158 0x40656257 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=40419e0c) 159 0x406562ed (WINPROC_CallWndProc+0x8d(proc=0x50023491, hwnd=0x1002a, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:167] in libuser32.so) (ebp=40419e3c) 160 0x4065b7a6 (WINPROC_CallProc32WTo32A+0x8a(func=0x50023491, hwnd=0x1002a, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2438] in libuser32.so) (ebp=40419e64) 161 0x4065bc38 (CallWindowProcW+0x88(func=0x409b090e, hwnd=0x1002a, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2645] in libuser32.so) (ebp=40419e8c) 162 0x405f8dce (call_window_proc+0xce(hwnd=0x1002a, msg=0xf, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1102] in libuser32.so) (ebp=40419edc) 163 0x405f986d (SendMessageTimeoutW+0xdd(hwnd=0x1002a, msg=0xf, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x40419f58) [message.c:1454] in libuser32.so) (ebp=40419f30) 164 0x405f9adf (SendMessageW+0x33(hwnd=0x1002a, msg=0xf, wparam=0x0, lparam=0x0) [message.c:1536] in libuser32.so) (ebp=40419f5c) 165 0x40644b9c (RDW_Paint+0xbc(wndPtr=0x40345d6c, hrgn=0x0, flags=0x180, ex=0x0) [painting.c:599] in libuser32.so) (ebp=40419f90) 166 0x406450d5 (RedrawWindow+0x3b1(hwnd=0x1002a, rectUpdate=0x0, hrgnUpdate=0x0, flags=0x180) [painting.c:787] in libuser32.so) (ebp=40419ffc) 167 0x40645129 (UpdateWindow+0x21(hwnd=0x1002a) [painting.c:802] in libuser32.so) (ebp=4041a018) Here's a corresponding relay trace: 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_PAINT,wp=00000000,lp=00000000) 0806e328:Call user32.GetWindowLongA(0001002a,00000000) ret=500238be 0806e328:Ret user32.GetWindowLongA() retval=4031ecfc ret=500238be 0806e328:Call user32.BeginPaint(0001002a,40524d1c) ret=50023575 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_NCPAINT,wp=00001abe,lp=00000000) 0806e328:Call user32.GetWindowLongA(0001002a,00000000) ret=500238be 0806e328:Ret user32.GetWindowLongA() retval=4031ecfc ret=500238be 0806e328:Call user32.DefWindowProcA(0001002a,00000085,00001abe,00000000) ret=500236d3 0806e328:Call x11drv.GetDC(0001002a,0000091c,00001abe,00050093) ret=4062f66c 0806e328:Call x11drv.SetDeviceClipping(4033f59c) ret=40702c4b 0806e328:Ret x11drv.SetDeviceClipping() retval=00000000 ret=40702c4b 0806e328:Ret x11drv.GetDC() retval=00000001 ret=4062f66c 0806e328:Call x11drv.SetDeviceClipping(4033f59c) ret=40702c4b 0806e328:Ret x11drv.SetDeviceClipping() retval=00000000 ret=40702c4b 0806e328:Call x11drv.SelectObject(4033f59c,000000e6) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=0000008a ret=4070f7fa 0806e328:Call x11drv.SetDeviceClipping(4033f59c) ret=40702c4b 0806e328:Ret x11drv.SetDeviceClipping() retval=00000000 ret=40702c4b 0806e328:Call x11drv.SelectObject(4033f59c,00000000) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=00000000 ret=4070f7fa 0806e328:Call x11drv.SelectObject(4033f59c,0000006e) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=0000006e ret=4070f7fa 0806e328:Call x11drv.GetDeviceCaps(4033f59c,00000022) ret=407057c8 0806e328:Ret x11drv.GetDeviceCaps() retval=000039f7 ret=407057c8 0806e328:Call x11drv.SelectObject(4033f59c,000000a2) ret=4070f6f9 0806e328:Ret x11drv.SelectObject() retval=00000001 ret=4070f6f9 0806e328:Call x11drv.SelectObject(4033f59c,0000008a) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=000000e6 ret=4070f7fa 0806e328:Call x11drv.SetBkColor(4033f59c,00ffffff) ret=40705846 0806e328:Ret x11drv.SetBkColor() retval=00ffffff ret=40705846 0806e328:Call x11drv.SetTextColor(4033f59c,00000000) ret=407058da 0806e328:Ret x11drv.SetTextColor() retval=00000000 ret=407058da 0806e328:Ret user32.DefWindowProcA() retval=00000000 ret=500236d3 0806e328:Call user32.UpdateWindow(0001002a) ret=500236e8 0806e328:Call x11drv.MsgWaitForMultipleObjectsEx(00000001,405247bc,00000000,000000ff,00000000) ret=4063ebcd 0806e328:Ret x11drv.MsgWaitForMultipleObjectsEx() retval=00000000 ret=4063ebcd 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_PAINT,wp=00000000,lp=00000000) 0806e328:Call user32.GetWindowLongA(0001002a,00000000) ret=500238be 0806e328:Ret user32.GetWindowLongA() retval=4031ecfc ret=500238be 0806e328:Call user32.BeginPaint(0001002a,405246e8) ret=50023575 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_NCPAINT,wp=00001ac6,lp=00000000) Cheers, Nicke -- -[ nkarlsso(a)abo.fi ]- Seek simplicity, and distrust it. (A. Whitehead)

1 0

Re: common controls updown patch
by David Elliott Jan. 19, 2002

Jan. 19, 2002

On 2002.01.19 04:37 Shane Shields wrote: > On Saturday 19 January 2002 12:23, you wrote: > > to realize that almost no other programming language does things like > > BASIC. > > you got that right! > > > Might I suggest Python if you are in the process of learning > programming. > > isnt programming a never ending learning experience? > Oh yeah it is. :-) > > Python is an extremely elegant language, interfaces well with C code, > and > > at the moment i am really concentrating on C. most of my C experience is > with > STL which again forces a different mind set. but once i clean my mind of > misconceptions then i can really start doing things ;-) > Don't forget, C++ and C are two different languages no matter how much all the marketing suggests that they aren't. They are close, but not quite the same. Wine is all C code with no C++ code. There have been several times when I wished Alexandre would accept C++ code into the source tree. The Windows API is fairly heavily object oriented with a C interface. Sometimes it would seem to make sense to actually use an OO language to do the OO programming. But in reality C can be easily coaxed into an OO programming style even though it is a functional language. As for Python... well, I'd really suggest taking a look at it. I was of the mindset that C and C++ were so great why bother with anything else. Then earlier last year I took a look at Python and was absolutely amazed. Looking at python code will help you out with the core concepts of programming in any lanuage. That specifically includes C and C++. Python just lends itself to good programming style. Of course any bad progrmamer can still write a bad program in it though. > > has several GUI toolkits. I think the default toolkit is Tk (yuk) but > > what do you think of QT (KDE's gui) > Well, I have mixed feelings about it. I dislike the fact that you must run all of your code through the MOC to compile it. My understanding of this is that it is done so that the event system can pass pointers to the various objects around. I think wxWindows has a by far more elegant event system. For ease of programming along with power I don't think you can beat wxWindows. wxWindows also has a non-STL but still typesafe implementation of lists and arrays! Basically all you have to do is declare that you're going to need a list or array that holds items of "SomeType" and you give it a name such as "SomeTypeList" (can be called anything though). I am thoroughly impressed with the thought that has gone into this toolkit. Plus writing to it means you get Windows, Linux, and Mac (mac support is beta) for free. This was an instant sell for my boss, which made me happy because I really didn't feel like screwing with the beast that is MFC. As for some of the other toolkits. GTK is nice and they did a really good job hacking OO code into C, a non-OO language. Supposedly this helps them because it makes it easier to do language bindings. Maybe when they started, yes. If I were to write GTK today I would do it in C++. GNU C++ has come a long way and GCC 3.0.3 is a very nice compiler. I am using linux-cross-mingw32 GCC 3.0.3 along with wxWindows to write a GUI app for work and it has been going great. The only gripe I have is that GCC takes a very long time to compile what is fairly minimal C++ code. This is on an Athlon 1.4 Ghz machine! I have watched the GCC2.96 from RH compile C code on the same machine faster than I can figure out what the hell its compiling. Took like 10 minutes to build the GCC3.0.3 cross compiler with it after I spent much longer than that fixing the bugs in the GCC3.0.3 source. > > The general form is booleanexpression?then:else > > things like that would never occur to the basic mind (there are two forms > of > basic mind if you think about it) ;-) > Yeah, I tripped over that one many a time. Eventually I started using it frequently because in many cases it makes the code so much more readable. And with C++ it's almost a requirement that you use it sometimes. > > > To drink the WINE of success you must first seek the > > > sayings of source. > > > > hehe.. how true. Do you know the author of that quote? We should put > it > > on the webpage. > > yes i know the author...........and its me! :-) If you want you can put > it on > the web page (cool!) > hehe.. thought so, I just wondered if it was a paraphrase of some other more well known quote. Anyway... this is getting to be offtopic and this message barely has anything to do with Wine, so if you reply and it doesn't have anything at all to do with Wine, please send directly. -Dave

1 0

Re: common controls updown patch
by Shane Shields Jan. 19, 2002

Jan. 19, 2002

On Thursday 17 January 2002 4:13, you wrote: > The remainder of any even number divided by two is 0, the remainder of any > odd number divided by two is 1. > > Knowing this doesn't: > > len+=(len%2); > > make more sense. Leave the comment as is for clarity if you wish. > > -Dave thanks Dave, its also a lot more elegant and will work faster too. i will generate a patch for it to be applied on top of the first one. as my biggest strength is visual basic things like this dont come to me straight away. im still trying to work out what this means (delta < 0 ? 1 : -1) its got me stuck. im currently looking at the wine install script as it doesnt find the windows registry when installing wine with an existing windows installation. Shane To drink the WINE of success you must first seek the sayings of source. __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

2 2

Re: _UNICODE vs UNICODE
by Francois Gouget Jan. 19, 2002

Jan. 19, 2002

On Fri, 18 Jan 2002, Andriy Palamarchuk wrote: > Using macro name "UNICODE" instead of "_UNICODE" is a > typo, right? No, not necessarily. Windows has both and dinput.h, for instance, uses UNICODE, not _UNICODE. But I have no idea why they have two. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

2 1

Re: C testing framewok. Updated. SystemParametersInfo unit test.
by Andriy Palamarchuk Jan. 18, 2002

Jan. 18, 2002

Alexandre Julliard wrote: > You don't need to > set the variable when running make test, but you have the possibility > to set it if you want to override the default for whatever reason. > I don't see why we should impose a less flexible solution that won't > be more robust anyway. Alexandre, by your suggestion I implemented the switch, but left automated platform detection in place. Platform detection will work when the environment variable is not set or set to unknown value. Can you suggest more reliable way to detect if test runs on Wine? One more important change in C framework is support of Unicode in testing. Dimitry, can you look at it? See how it is used in sysparams.c, search for "has_unicode" function call. I'm interested in your comments. Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

5 14

Re: wine-patches@winehq.com
by Alexandre Julliard Jan. 18, 2002

Jan. 18, 2002

Shane Shields <locutusenterprises(a)yahoo.com> writes: > just a little improvement suggested by dave elliot on > the updown.c patch > that i posted before. it doesnt change the > functionality but is more elegant > coding. to be installed on top of the previous patch. I must confess I still don't see the reason for your patch in the first place. Unless I missed something the behavior should be exactly the same before and after your change (I mean the first one, not the cosmetic improvement). What is it supposed to fix? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: C testing framewok. Updated. SystemParametersInfo unit test.
by Andriy Palamarchuk Jan. 18, 2002

Jan. 18, 2002

Alexandre Julliard wrote: > It's not enough to simply pass converted ASCII strings > to the W functions, > we have to test with real Unicode to check for > lossy W->A->W conversions, surrogate handling, non-spacing chars, etc. Aren't all these requirements just additional to testing with converted ASCII strings? At least we'll have minimal tests of W functions without spending much time. One more advantage in creation TCHAR-portable code - we can eventually test with it multibyte character set support. We still can have specific A and W tests sections, enclosed in #ifdef _UNICODE. Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

1 0

XP registry
by Eric Pouech Jan. 18, 2002

Jan. 18, 2002

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/appendix/h… this may answer the latest question from Andi A+ --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle ____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

1 0

Wine "Please Report" Error
by Scott Sipe Jan. 18, 2002

Jan. 18, 2002

Hi, I'm running wine20011226 compiled on FreeBSD 4.5 rc recent build, built wine from the ports collection. When I start wine, it says: scott(a)dragon> wine Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: err:reg:_nt_dump_lf unknown node id 0x686c, please report! err:reg:_nt_dump_lf unknown node id 0x686c, please report! err:reg:_nt_dump_lf unknown node id 0x686c, please report! Wine release 20011226 So, what should I report? thanks, Scott

2 1

License problem with files in dlls/icmp/
by Ilja Kamps Jan. 18, 2002

Jan. 18, 2002

It appaers that files under dlls/icmp/ are licensed under the BSD license and not the X11 license, this might be a problem as wine does not honor the advertisment part and also it makes wine GPL incompaitible, I would consider this a serious problem. Either we honor the advertisment part and note that wine is not directly GPL compaitible (GPL doesn't allow such texts) or we reimplement that dll. I hope I got it right.

3 3

RE: What are you really aiming to do with winetest?
by Patrik Stridvall Jan. 17, 2002

Jan. 17, 2002

> Patrik Stridvall <ps(a)leissner.se> writes: > > > So what you basicly want is something like: > > > > my %return_type_exceptions; > > > > $return_type_exceptions{"foo"} = { > > Bar => "str", > > Baz => "ptr" > > }; > > > > $return_type_exceptions{"bar"} = { > > Foo => "str" > > }; > > > Yes, that would work fine for now. OK. I made a script (adapted winapi_extract) to do this (attached). Output attached as well, but you can regenerate it by doing tools/winapi/winapi_extract in the topsrcdir. I realized that when I was at it I could output the argument types as well and thus having a hash table that can be given to wine::declare directly. Here is also a script make_modules that generates modules to use this directly and thus there is no need to any spec2pm any longer. However I'm not postive that we want to have seperate include for constants and functions. Perhaps it would be better if people used to C could just do use winuser; instead of #include "winuser.h" and not have to do any additional use user32; as well. Oh, well, I don't really have any strong feelings in any direction. But it would be easier if you told me how you wanted it. Oh BTW: What is your opinion on having special Perl adapted versions of some functions like: sub GlobalGetAtomNameA { my $atom = shift; my $buffer = "\0" x 256; # FIXME: Fixed buffer length my $length = &kernel32::GlobalGetAtomNameA($atom, \$buffer, length($buffer)); return substr($buffer, 0, $length); } Should we have them as the default imported function in say kernel32.pm or should each test that wants a easier to use version declare it in the test itself.

2 1