November 2002 - Wine-Devel - list.winehq.org

Plea to fix winelib COM vtable bug
by Matthew Bloch Nov. 2, 2002

Nov. 2, 2002

This is a summary of my recent probs with Winelib in the hope that someone who knows the COM stuff can fix them quickly, because hacking through the jungle of include files and definitions is hard work In short, I've built the latest wine cvs with the ICOM_MSVTABLE_COMPAT flag set in include/wine/obj_base.h, so each vtable has two dummy words at the start for g++'s benefit. I then added these statements to the start of my WinMain to cause a segfault: IDirectDraw* dd; DirectDrawCreate(0, &dd, NULL;) and for good measure, wrapped the call to IDirectDraw7_QueryInterface in DDRAW_Create (which is where the segfault occurs) in ddraw/main.c with these two warnings: WARN("about to call IDirectDraw7_QueryInterface vtbl size = %d\n", sizeof(DDCF_Vtbl)); hr = IDirectDraw7_QueryInterface(pDD, iid, lplpDD); WARN("called IDirectDraw7_QueryInterface\n"); and when running the program, the trace clearly shows that the Release entry point is being called instead, and crashing, though the vtable is the expected size (5 entry points, plus 2 dummy dwords): warn:ddraw:DDRAW_Create about to call IDirectDraw7_QueryInterface vtbl size = 28 warn:ddraw:DDRAW_Create offset is 12271064 trace:ddraw:Main_DirectDraw_Release (0x403a7c70)->() decrementing from 1. warn:ddraw:Main_DirectDraw_Release doing final release Looking at the pre-processor output from compiling ddraw/main.c, I can see that IDirectDraw7Vtbl type has the two extra words grafted onto the front, as it should: struct IDirectDraw7Vtbl { long dummyRTTI1; long dummyRTTI2; HRESULT (__attribute__((__stdcall__)) *QueryInterface)(IDirectDraw7* me, const IID* const a, LPVOID* b); ULONG (__attribute__((__stdcall__)) *AddRef)(IDirectDraw7* me); ULONG (__attribute__((__stdcall__)) *Release)(IDirectDraw7* me); ... The problem seems to be that the call is offset not just by two table entries, but four. Somewhere in that jungle of macros, the "vtable base adjustment" of +2 is being applied twice, I'm sure of it. But I'm buggered if I can find out where this is happening; I'm still looking but it's slow progress and I believe it's a winelib bug. Any suggestions on how to fix it would be welcome. cheers, -- Matthew Bloch Bytemark Computer Consulting Limited http://www.bytemark.co.uk/ tel. +44 (0) 8707 455026

3 4

Re: dlls/msvcrt: msvcrt-popen-2.diff
by Jaco Greeff Nov. 2, 2002

Nov. 2, 2002

On Sat, 2 Nov 2002 10:56:02 -0500, "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote : > On November 2, 2002 10:41 am, Jaco Greeff wrote: > > +#define POPEN_WCMD_EXEC "C:\\Windows\\System32\\cmd.exe /c" > > Do we need this hardcoded path here?!? What about the COMSPEC > idea that Francois suggested? I'm still trying to get that one to go. As soon as I've got it, I'll submit the small change. <snip> > > + else > > \ > > + CloseHandle(hHandle); > > What's up with all the macro abuse? :) We don't like cpp that much! ;) > Please, try to do things without macros, it can't be that bad. And everybody is a critic ;) I really hate duplicating code in any function. I'd rather use a macro which make the function 1. more readable, 2. shorter :) I would potentially rather more it to it's own header file than doing the cut-n-paste thing inside a function... Would it be 50% ok with macro abuse in a seperate header file? Greetings Jaco

2 1

PATCH: DirectDraw vtable fixes
by Matthew Bloch Nov. 2, 2002

Nov. 2, 2002

Found it; a few of the DirectDraw ICOM_VTABLE declarations did not have the ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE macro prefixing their elements. This meant that, well, all sorts of havoc broke loose when wrong functions were called :) I hope this is an uncontentious patch attached. -- Matthew Bloch Bytemark Computer Consulting Limited http://www.bytemark.co.uk/ tel. +44 (0) 8707 455026

1 0

Re: dlls/msvcrt: msvcrt-popen-2.diff
by Dimitrie O. Paun Nov. 2, 2002

Nov. 2, 2002

On November 2, 2002 10:41 am, Jaco Greeff wrote: > +#define POPEN_WCMD_EXEC "C:\\Windows\\System32\\cmd.exe /c" Do we need this hardcoded path here?!? What about the COMSPEC idea that Francois suggested? > +#define LPCWSTR_TO_LPSTR(wszIn, nIn, szOut, nOut) \ > + *nOut = WideCharToMultiByte(CP_ACP, 0, wszIn, nIn, NULL, 0, NULL, > NULL); \ > + szOut = (CHAR *)MSVCRT_malloc((*nOut+1)*sizeof(CHAR)); > \ > + if (szOut) > \ > + { > \ > + WideCharToMultiByte(CP_ACP, 0, wszIn, nIn, szOut, *nOut+1, NULL, > NULL); \ > + szOut[nLen] = '\0'; > \ > + } > \ > + else > \ > + *nOut = 0; > + > +#define CREATE_PIPE(hRead, hWrite, security) \ > + if (!CreatePipe(&hRead, &hWrite, &security, 0)) > \ > + { > \ > + TRACE("Creation of pipe failed\n"); > \ > + return NULL; > \ > + } > + > +#define REDIRECT_STREAM(type, handle)\ > + if (!SetStdHandle(type, handle)) > \ > + { > \ > + TRACE("Redirection of stream failed"); > \ > + return NULL; > \ > + } > + > +#define RESTORE_STREAM(type, handle) \ > + if (!SetStdHandle(type, handle)) > \ > + TRACE("Restore of stream failed\n"); > + > +#define DUPLICATE_HANDLE(hHandle, hDup, type, hOrig) \ > + if (!DuplicateHandle(GetCurrentProcess(), hHandle, > \ > + GetCurrentProcess(), &hDup, 0, > \ > + FALSE, DUPLICATE_SAME_ACCESS)) > \ > + { > \ > + TRACE("Duplication of piped handle failed\n"); > \ > + RESTORE_STREAM(type, hOrig); > \ > + return NULL; > \ > + } > \ > + else > \ > + CloseHandle(hHandle); What's up with all the macro abuse? :) We don't like cpp that much! ;) Please, try to do things without macros, it can't be that bad. -- Dimi.

1 0

Re: Wine 0.8 TODO v0.1
by Dustin Navea Nov. 2, 2002

Nov. 2, 2002

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > On November 2, 2002 09:42 am, Dustin Navea wrote: > > apps such as slocate to gain root access and then that would give wine a > > bad rep with both windows newbies and linux users... > > That can't happen as WIne runs non-root. At mostthey can gain user access. > Anything more is a Linux bug. > No but if there is a big enough hole, they could use it to get access to the /etc/passwd and then use a dos program (crackerjack comes to mind here) to decrypt the program (especially if they are dual-booting win9x and linux) --Dustin __________________________________________________ Do you Yahoo!? HotJobs - Search new jobs daily now http://hotjobs.yahoo.com/

2 1

Re: Wine 0.8 TODO v0.1
by Dimitrie O. Paun Nov. 2, 2002

Nov. 2, 2002

On November 2, 2002 03:26 am, Keith Matthews wrote: > Note that an increasing number of apps are assuming that IE is present > and use it to provide crucial functionality. For this, we should look into supporting the IWebBrowser interface, via Mozilla. It's been mentioned here before. Actually, there is a LGPL implementation for this in the Mozilla tree, it's just that it's written in C++. One option would be to just install the binaries, and that would be it, but it's not that sexy... -- Dimi.

1 0

RtlQueryTimeZoneInformation
by György 'Nog' Jeney Nov. 2, 2002

Nov. 2, 2002

Does anyone know anything about RtlQueryTimeZoneInformation? I would like to implement it... nog.

1 0

Re: Hungarian resources
by nagyzoli＠drotposta.hu Nov. 2, 2002

Nov. 2, 2002

Upgraded: dlls/user/resources/user32_hu.rc Thanks Zoly

1 0

Re: Wine 0.8 TODO v0.1 + help request :)
by Kye Lewis Nov. 2, 2002

Nov. 2, 2002

> These are my success stories with a plain installation of wine (i do > have windows, but i created a new config which doesn't use it) > > Well, Acrobat can install and run pretty much perfectly. > http://www.adobe.com/ With Latest CVS Acrobat Reader 4.0 seems to only have 1 problem (the licence agreement screen comes up behind the splash screen - but it is visible enough to move it anyway) > Family Tree Maker 9 runs really well as well > Not freely downloadable > Only problem with this one is the installer shows the setup instructions > behind the background. - but the actual app works pretty much fine Apart from setup this works very well, although not flawlessly. I don't know if the internet functions work or not. > The #1 at Tucows - IrfanView - works pretty much flawlessly as well. > http://www.tucows.com/ - look for the #1 (or search for it) In fact, after a little more detailed look, I would say this works *perfectly* > MS Calculator ;) works well > >From the Microsoft Plus! Pack: > Again, not freely downloadable. > > Spider Solitaire: FLAWLESS :) - just a tad slow on animations > Pinball also FLAWLESS - again a little slow but works! > > More coming soon... Note: Pinball now comes with windows - so It can be tested out. Don't include this in the list of working apps, but Adobe Premiere 6.0 has made great progress in the last month or two - It now not only opens, but will add titles and transitions (normal AVI files will not open however - it says that they are not a known compression format) - and when printing to video, it freezes after a few seconds (well, when I tried it anyway). There are also slight problems with the timeline (but it is still workable - a great wine success story) Also, DK Multimedia's "The Way things work" works almost perfectly I've done some screenshots of running applications in Wine which i'm going to post to: http://winepics.oxygen-x.net/ a little later on today. Thanks, Kye Lewis kyethespy(a)liquid2k.com

1 0

Re: Hungarian resources
by Dmitry Timoshkov Nov. 2, 2002

Nov. 2, 2002

<nagyzoli(a)drotposta.hu> wrote: > dlls/user/resources/user32_hu.rc Please use either CVS or release 20021031 as the source for user32 resources. Specifically there is no such an identifier MDI_IDS_MOREWINDOWS but IDS_MDI_MOREWINDOWS instead and one more string in the user32 string table has been added. -- Dmitry.

1 0