December 2002 - Wine-Devel - list.winehq.org

Re: CxxFrameHandler problem
by John K. Hohm April 11, 2003

April 11, 2003

Alexandre Julliard <julliard(a)winehq.com> wrote: > Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > > > Appended program uses CxxFrameHandler and crashes in wine with builtin > > msvcrt, but not with native. Compile as Release version and include the > MFC > > dll. Can somebody compile for Alexandre? Alexandre, is this a start or do > > you need something complete? > > That's a start, yes, thanks. I'll need a more complete example with > nested try blocks, destructors all over the place, typed exceptions, > etc. to make sure I understand all the compiler internal structures; > but I can at least try to make that simple case not crash... Although this may duplicate effort, I am familiar with several strange combinations of exception handling that I know work with Visual C++ 6.0; I will put them a test program for you. You can never have too many test programs, right?

1 1

DirectSound and i810 soundcards
by Francois Gouget Jan. 10, 2003

Jan. 10, 2003

There is a problem with Directsound and i810 soundcards. The test I just sent to wine-patches illustrates it very well. Basically sounds are being played too fast. Here's my understanding of the problem (if my memory and understanding of the logs is correct): When DSound initializes it create a primary sound buffer and invokes winmm to actually get access to a sound device. The default format of the primary buffer is 22050x16x2 (i.e. 22050Hz, 16 bit sound, stereo). This means the device it's going to get will be handled by msacm.drv which will be responsible for performing the conversions on the fly. However during the primary buffer creation DSDB_MapPrimary gets invoked in wineoss and does an mmap of the hardware sound buffer. So when we then play sound in a secondary sound buffer, this sound gets mixed into the primary buffer, but because of the mmap this then goes straight to the sound card with no further conversion. So you end up with a chipmunk sound effect since you play a 22050x16x2 sound at 48000x16x2. I will try to make more tests to confirm this but does it seem to make sense? Should I look in some other direction? Any suggestion about a fix? If you have an i810 soundcard you can reproduce by doing the following: * apply "Add WINETEST_INTERACTIVE" from wine-patches * apply "Add 'audiophile' DirectSound tests" from wine-patches * cd dlls/dsound/tests * make * WINETEST_INTERACTIVE=1 ../../../tools/runtest -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so dsound.c (you can also set WINETEST_DEBUG=2 to get more debug info about the test's buffer management, though this is probably not relevant here) Alternately, you can download the latest Windows test binaries from my site (http://fgouget.free.fr/wine/winetests.zip) and run them using Wine, or on Windows: set WINETEST_INTERACTIVE=1 dsound_test dsound Actually I would be interested in the results of this test on Windows: * the test tone is usually played three times. Are all three, and especially the first one, at the right pitch? * what is the output of the test? I'm interested in reported capabilities as stated by Windows and Wine for instance (to determine whether the primary buffer is emulated for instance). * what is the primary buffer's default format? 22050x16x2? (that's not supported by the sound card!) * does the winmm test work? set WINETEST_INTERACTIVE=1 winmm_test wave * in particular, what happens when the test tone is played with WAVE_FORMAT_DIRECT on Windows? (except Win9x platforms which don't support that flag) -- Francois Gouget fgouget(a)codeweavers.com

3 8

Re: Registering DLL's
by John K. Hohm Jan. 9, 2003

Jan. 9, 2003

Alexandre said: > Part of it should be done with DllRegisterServer, the rest can be > handled by the .inf script. And I think it's OK to add the necessary > DllRegisterServer entry points even if the native dll doesn't have > them. I'm glad you feel that way. I created bug 1117, "Make all Wine OLE DLLs self-registerable", and have been working on an implementation. For some reason I can't accept the bug; though I've tried several times, it stays at UNCONFIRMED. What to do about DLLs like ole32.dll that have a native DllRegisterServer but no corresponding DllUnregisterServer? I'm inclined to include it for completeness, though it's unlikely that anyone would ever want to unregister such a basic system DLL. I posted my idea for representing the registration data, accidentally from "jhohm(a)happyhappy.dyndns.org" rather than my usual "jhohm(a)acm.org" (see http://www.winehq.com/hypermail/wine-devel/2002/11/1409.html) but I haven't gotten any responses, not even "looks fine" or "you are a moron". I guess I'll just start submitting patches, then.

4 11

Re: tchar fixes: _tcs{dup,icmp}
by Francois Gouget Jan. 3, 2003

Jan. 3, 2003

On Mon, 23 Dec 2002, Dimitrie O. Paun wrote: > That's what I have to do on my system. > > Francois, does this seem OK to you? If the fix is right, > what about the other _str* symbols? According to the latest sdk I have (2000), _tcsdup is supposed to map to _strdup and _tcsicmp to _stricmp. I think the catch is you are supposed to link with the msvcrt library since these symbols are only exported there. Now, pointing _tcsdup to strdup should not make any difference. However I am not sure that _stricmp really behaves exactly like strcasecmp: you would need to check how each of these handles accentuated characters and locale. Then the question is whether tchar.h should be considered to be a pure msvcrt thing, i.e. don't use it if you don't link to msvcrt, or whether we want to make is usable in Ansi mode with a regular C library. Currently we set the macros based on _MBCS and _UNICODE. Maybe we need to add a WINE_LIBC flag and add mappings to the native C library routines? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ A black hole is just God dividing by zero.

5 7

Debugger / wineconsole problem
by Lionel Ulmer Jan. 3, 2003

Jan. 3, 2003

Hi all, I have a little annoying problem with the wineconsole / winedbg : as soon as I switch to another window and come back to the debugger, I loose keyboard input. Mouse input still works fine. I have also often graphical glitches (ie I have only garbage when scrolling due to a newline being displayed). The scollbar seems also to be non-functionnal. Lionel -- Lionel Ulmer - http://www.bbrox.org/

3 5

__WINE__ vs. __WINESRC__
by Dimitrie O. Paun Jan. 3, 2003

Jan. 3, 2003

Hi folks, Here is another problem: we are currently defining the __WINE__ symbol to signal the headers that we are compiling Wine. This is fine. The problem that I'm facing is that there are apps (such as wxWindows) that want to know that they are _compiled_ (not run) under Wine. All platforms (and Wine is a platform, even if a virtual one) define standard symbols by default: __WIN32__, __MINGW32__, you name it. There are valid reasons for a program to be able to test that is being compiled under Wine, and not under MinGW for example. Thus, we need to define a standard symbol, and __WINE__ seems to be the most appropriate. I think it's better to expose the prettier name, and use a longer/uglier one internally. So, my proposal is: let's rename the __WINE__ symbol (as it's currently used) to something else (__WINESRC__, or whatever, suggestions welcome), once that's done, define __WINE__ when __WINESRC__ is not defined (the symbols would be mutually exclusive). I can send in a patch if people don't object... -- Dimi.

6 10

Re: Make RECT === RECTL, fix compile warnings, use uniform format
by Dimitrie O. Paun Jan. 2, 2003

Jan. 2, 2003

On December 28, 2002 04:10 pm, Dan Kegel wrote: > Decided to leave debugrect for later, too much of a pain for now. > This patch just uses a uniform format for RECTs where possible. > It reorders three or so TRACEs that had the coordinates in > nonstandard order, too. Patch against current CVS attached. > Should compile fine, but I haven't tested it (so do look it over :-) Cool stuff. Can you please turn this thing: Index: dlls/comctl32/datetime.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/datetime.c,v retrieving revision 1.34 diff -d -u -r1.34 datetime.c --- dlls/comctl32/datetime.c 2 Dec 2002 18:11:00 -0000 1.34 +++ dlls/comctl32/datetime.c 28 Dec 2002 20:43:22 -0000 @@ -1098,7 +1098,7 @@ infoPtr->rcClient.bottom = HIWORD(lParam); infoPtr->rcClient.right = LOWORD(lParam); - TRACE("Height=%d, Width=%d\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); + TRACE("Height=%ld, Width=%ld\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); /* use DrawEdge to adjust the size of rcEdge to get rcDraw */ memcpy((&infoPtr->rcDraw), (&infoPtr->rcClient), sizeof(infoPtr->rcDraw)); Into a standard [(%ld,%ld)-(%ld,%ld)]? As for debugrect(), it seems like half of the printed rectangles are in commctrl, so what we can do is use debugrect() in there without having to introduce any infrastructure changes. We can do that after Alexandre commits this change, so we don't cram too much stuff into one patch. -- Dimi.

3 7

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)
by Patrik Stridvall Jan. 2, 2003

Jan. 2, 2003

> On December 30, 2002 03:41 pm, Patrik Stridvall wrote: > > I'm already on it by improving winapi_cleanup. > > Very well, I've put you up for it instead. But make sure > you don't over do it :) Well, for the future I have planned grouping and automatic addition of #ifdef HAVE_ and that sort of things. That is overdoing a little perhaps but it will look nicer. :-) > It seems to me the algo is simple > (if the include can not be accessed relative to the dir in > which the .c file is, change it to <>), This is that it already does I think. Please try it out yourself. > and the operation > is really one time. It depends what you mean by one time. People make mistakes. winapi_cleanup does C++ comment to C comment conversion and this is "one time" as well... > So if you have something that works, > let's just get the patch (and here I'm referring to the one > that does the actual "" to <> change) in, and check this off. I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things. If not please inform me what the problem is. In my tree, the patch is over 800k.

4 4

Visual-MinGW: Winelib patch
by Dimitrie O. Paun Jan. 2, 2003

Jan. 2, 2003

Hi Manu, I got around getting Visual-MinGW to compile under Winelib. This patch touches only your makefile, and I hope the changes are not controversial: -- Use forward slash instead of backslash -- Explicitly list the DLLs you link against (shell32, comdlg32, advapi32) -- It make sense to specify -mno-cygwin For some reason, the code seems to require it. Please check that it works under Windows as well. If it does, if makes sense to have it as Visual-MinGW should not have a dependency on Cygwin, as far as I can tell. -- Do not use -pedantic, the code does not compile with gcc 3.2 on Linux with that flag. -- Do not use -fvtable-thunks, it is deprecated in gcc 3.2 Please apply this patch with 'patch -p1 < winelib.diff'. Note that I still need to get some changes integrated into the official Wine tree before you can actually compile Visual-MinGW under Winelib. The changes are not controversial, and I hope to get them in real soon. I will let you know when that happens. Regardless, I think the changes I'm proposing are logical in and of themselves, so I figured they can be integrated regardless. Enjoy! --- Visual-MinGW.orig/Projects/vmingw/src/makefile 2002-06-08 06:07:10.000000000 -0400 +++ Visual-MinGW/Projects/vmingw/src/makefile 2002-12-31 01:43:29.000000000 -0500 @@ -1,25 +1,25 @@ # Generated automatically by Visual-MinGW. # http://visual-mingw.sourceforge.net/ -CC = g++ +CXX = g++ WRES = windres DLLWRAP = dllwrap CPPFLAGS = -D_WIN32_IE=0x0400 -LDBASEFLAGS = -mwindows -lcomctl32 -lole32 +LDBASEFLAGS = -mwindows -mno-cygwin -lcomctl32 -lole32 -lshell32 -lcomdlg32 -ladvapi32 INCDIRS = -I ../include OPTIMIZ = -O2 STRIP = -s ifeq ($(MAKECMDGOALS),debug) -CXXFLAGS = -W -Wall -pedantic $(INCDIRS) -g -fvtable-thunks -fno-rtti +CXXFLAGS = -W -Wall $(INCDIRS) -g -mno-cygwin -fno-rtti LDFLAGS = $(LDBASEFLAGS) else -CXXFLAGS = -W -Wall -pedantic $(INCDIRS) $(OPTIMIZ) -fvtable-thunks -fno-rtti +CXXFLAGS = -W -Wall $(INCDIRS) $(OPTIMIZ) -mno-cygwin -fno-rtti LDFLAGS = $(STRIP) $(LDBASEFLAGS) endif -SRCDIR = .\src -BINDIR = ..\bin +SRCDIR = ./src +BINDIR = ../bin LIBDIRS = %.o : %.rc @@ -51,7 +51,7 @@ # Dependency rules $(TARGET): $(OBJS) - $(CXX) -o $(BINDIR)\visual-mingw.exe $(OBJS) $(INCDIRS) $(LIBDIRS) $(LDFLAGS) + $(CXX) -o $(BINDIR)/visual-mingw.exe $(OBJS) $(INCDIRS) $(LIBDIRS) $(LDFLAGS) rsrc.o: rsrc.rc -- Dimi.

2 6

Alexandre?
by Jeff Smith Jan. 2, 2003

Jan. 2, 2003

I've seen no activity on wine-cvs for a week (Dec 23). What's up? Holiday vacation? Either way, Happy (if belated) Holidays to everyone who celebrates a holiday. :-) -- Jeff S _________________________________________________________________ MSN 8 helps eliminate e-mail viruses. Get 3 months FREE*. http://join.msn.com/?page=features/virus&xAPID=42&PS=47575&PI=7324&DI=7474&… http://www.hotmail.msn.com/cgi-bin/getmsg&HL=1216hotmailtaglines_virusprote…

4 3

Set/WindowLong problem in user/win test
by Francois Gouget Jan. 2, 2003

Jan. 2, 2003

This test uses {Get,Set}WindowLongW which of course does not work on Win9x, thus causing the test to fail. I guess part of the goal is to check that mixing Ansi calls (CreatewindowExA) with Unicode calls works. So I wrote a function test_set_window_long function that calls SetWindowLongW and then SetWindowLongA and checks that their results match but that causes the test to fail (at least on NT4 and Wine). More precisely even if all this function does is the following, then the test fails: { LONG rc=SetWindowLongA(hwnd,nIndex,dwNewLong); SetWindowLongA(hwnd,nIndex,dwNewLong); return rc; } Comment out the second SetWindowLongA and it works. Why would calling SetWindowLong a second time make any difference? Here's the full patch, just change '#if 0' into '#if 1' to make the test fail. Index: dlls/user/tests/win.c =================================================================== RCS file: /home/wine/wine/dlls/user/tests/win.c,v retrieving revision 1.5 diff -u -r1.5 win.c --- dlls/user/tests/win.c 15 Nov 2002 00:02:51 -0000 1.5 +++ dlls/user/tests/win.c 24 Dec 2002 03:16:36 -0000 @@ -45,6 +45,47 @@ static HWND hwndMain, hwndMain2; +static LONG test_set_window_long(HWND hwnd, int nIndex, LONG dwNewLong) +{ + LONG rc; + + SetLastError(0); + rc=SetWindowLongW(hwnd,nIndex,dwNewLong); + if (rc==0 && GetLastError()==ERROR_CALL_NOT_IMPLEMENTED) { + rc=SetWindowLongA(hwnd,nIndex,dwNewLong); + } +#if 0 + else { + LONG set,get; + get=GetWindowLongW(hwnd,nIndex); + set=SetWindowLongA(hwnd,nIndex,dwNewLong); + ok(set==get, + "SetWindowLongA/W(%ld) failed: got %ld, expected %ld\n", + dwNewLong,set,get); + } +#endif + return rc; +} + +static LONG test_get_window_long(HWND hwnd, int nIndex) +{ + LONG rc; + + SetLastError(0); + rc=GetWindowLongW(hwnd,nIndex); + if (rc==0 && GetLastError()==ERROR_CALL_NOT_IMPLEMENTED) { + rc=GetWindowLongA(hwnd,nIndex); + } else { + LONG rcA; + SetLastError(0); + rcA=GetWindowLongA(hwnd,nIndex); + ok(rc==rcA, + "GetWindowLongW failed: got %ld, expected %ld\n", + rc,rcA); + } + return rc; +} + /* check the values returned by the various parent/owner functions on a given window */ static void check_parents( HWND hwnd, HWND ga_parent, HWND gwl_parent, HWND get_parent, HWND gw_owner, HWND ga_root, HWND ga_root_owner ) @@ -56,7 +97,7 @@ res = pGetAncestor( hwnd, GA_PARENT ); ok( res == ga_parent, "Wrong result for GA_PARENT %p expected %p", res, ga_parent ); } - res = (HWND)GetWindowLongW( hwnd, GWL_HWNDPARENT ); + res = (HWND)test_get_window_long( hwnd, GWL_HWNDPARENT ); ok( res == gwl_parent, "Wrong result for GWL_HWNDPARENT %p expected %p", res, gwl_parent ); res = GetParent( hwnd ); ok( res == get_parent, "Wrong result for GetParent %p expected %p", res, get_parent ); @@ -97,31 +138,31 @@ /* desktop window */ check_parents( desktop, 0, 0, 0, 0, 0, 0 ); - style = GetWindowLongW( desktop, GWL_STYLE ); - ok( !SetWindowLongW( desktop, GWL_STYLE, WS_POPUP ), "Set GWL_STYLE on desktop succeeded" ); - ok( !SetWindowLongW( desktop, GWL_STYLE, 0 ), "Set GWL_STYLE on desktop succeeded" ); - ok( GetWindowLongW( desktop, GWL_STYLE ) == style, "Desktop style changed" ); + style = test_get_window_long( desktop, GWL_STYLE ); + ok( !SetWindowLongA( desktop, GWL_STYLE, WS_POPUP ), "Set GWL_STYLE on desktop succeeded" ); + ok( !SetWindowLongA( desktop, GWL_STYLE, 0 ), "Set GWL_STYLE on desktop succeeded" ); + ok( test_get_window_long( desktop, GWL_STYLE ) == style, "Desktop style changed" ); /* normal child window */ test = create_tool_window( WS_CHILD, hwndMain ); trace( "created child %p\n", test ); check_parents( test, hwndMain, hwndMain, hwndMain, 0, hwndMain, hwndMain ); - SetWindowLongW( test, GWL_STYLE, 0 ); + test_set_window_long( test, GWL_STYLE, 0 ); check_parents( test, hwndMain, hwndMain, 0, 0, hwndMain, test ); - SetWindowLongW( test, GWL_STYLE, WS_POPUP ); + test_set_window_long( test, GWL_STYLE, WS_POPUP ); check_parents( test, hwndMain, hwndMain, 0, 0, hwndMain, test ); - SetWindowLongW( test, GWL_STYLE, WS_POPUP|WS_CHILD ); + test_set_window_long( test, GWL_STYLE, WS_POPUP|WS_CHILD ); check_parents( test, hwndMain, hwndMain, 0, 0, hwndMain, test ); - SetWindowLongW( test, GWL_STYLE, WS_CHILD ); + test_set_window_long( test, GWL_STYLE, WS_CHILD ); DestroyWindow( test ); /* child of desktop */ test = create_tool_window( WS_CHILD, desktop ); trace( "created child of desktop %p\n", test ); check_parents( test, desktop, 0, desktop, 0, test, desktop ); - SetWindowLongW( test, GWL_STYLE, WS_POPUP ); + test_set_window_long( test, GWL_STYLE, WS_POPUP ); check_parents( test, desktop, 0, 0, 0, test, test ); - SetWindowLongW( test, GWL_STYLE, 0 ); + test_set_window_long( test, GWL_STYLE, 0 ); check_parents( test, desktop, 0, 0, 0, test, test ); DestroyWindow( test ); @@ -129,9 +170,9 @@ test = create_tool_window( WS_CHILD, child ); trace( "created child of child %p\n", test ); check_parents( test, child, child, child, 0, hwndMain, hwndMain ); - SetWindowLongW( test, GWL_STYLE, 0 ); + test_set_window_long( test, GWL_STYLE, 0 ); check_parents( test, child, child, 0, 0, hwndMain, test ); - SetWindowLongW( test, GWL_STYLE, WS_POPUP ); + test_set_window_long( test, GWL_STYLE, WS_POPUP ); check_parents( test, child, child, 0, 0, hwndMain, test ); DestroyWindow( test ); @@ -139,9 +180,9 @@ test = create_tool_window( 0, 0 ); trace( "created top-level %p\n", test ); check_parents( test, desktop, 0, 0, 0, test, test ); - SetWindowLongW( test, GWL_STYLE, WS_POPUP ); + test_set_window_long( test, GWL_STYLE, WS_POPUP ); check_parents( test, desktop, 0, 0, 0, test, test ); - SetWindowLongW( test, GWL_STYLE, WS_CHILD ); + test_set_window_long( test, GWL_STYLE, WS_CHILD ); check_parents( test, desktop, 0, desktop, 0, test, desktop ); DestroyWindow( test ); @@ -149,9 +190,9 @@ test = create_tool_window( 0, hwndMain ); trace( "created owned top-level %p\n", test ); check_parents( test, desktop, hwndMain, 0, hwndMain, test, test ); - SetWindowLongW( test, GWL_STYLE, WS_POPUP ); + test_set_window_long( test, GWL_STYLE, WS_POPUP ); check_parents( test, desktop, hwndMain, hwndMain, hwndMain, test, hwndMain ); - SetWindowLongW( test, GWL_STYLE, WS_CHILD ); + test_set_window_long( test, GWL_STYLE, WS_CHILD ); check_parents( test, desktop, hwndMain, desktop, hwndMain, test, desktop ); DestroyWindow( test ); @@ -159,9 +200,9 @@ test = create_tool_window( WS_POPUP, 0 ); trace( "created popup %p\n", test ); check_parents( test, desktop, 0, 0, 0, test, test ); - SetWindowLongW( test, GWL_STYLE, WS_CHILD ); + test_set_window_long( test, GWL_STYLE, WS_CHILD ); check_parents( test, desktop, 0, desktop, 0, test, desktop ); - SetWindowLongW( test, GWL_STYLE, 0 ); + test_set_window_long( test, GWL_STYLE, 0 ); check_parents( test, desktop, 0, 0, 0, test, test ); DestroyWindow( test ); @@ -169,9 +210,9 @@ test = create_tool_window( WS_POPUP, hwndMain ); trace( "created owned popup %p\n", test ); check_parents( test, desktop, hwndMain, hwndMain, hwndMain, test, hwndMain ); - SetWindowLongW( test, GWL_STYLE, WS_CHILD ); + test_set_window_long( test, GWL_STYLE, WS_CHILD ); check_parents( test, desktop, hwndMain, desktop, hwndMain, test, desktop ); - SetWindowLongW( test, GWL_STYLE, 0 ); + test_set_window_long( test, GWL_STYLE, 0 ); check_parents( test, desktop, hwndMain, 0, hwndMain, test, test ); DestroyWindow( test ); @@ -210,7 +251,7 @@ /* desktop window */ check_parents( desktop, 0, 0, 0, 0, 0, 0 ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); ok( !ret, "Set GWL_HWNDPARENT succeeded on desktop" ); check_parents( desktop, 0, 0, 0, 0, 0, 0 ); ok( !SetParent( desktop, hwndMain ), "SetParent succeeded on desktop" ); @@ -220,24 +261,24 @@ test = create_tool_window( WS_CHILD, hwndMain ); trace( "created child %p\n", test ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); ok( ret == hwndMain, "GWL_HWNDPARENT return value %p expected %p", ret, hwndMain ); check_parents( test, hwndMain2, hwndMain2, hwndMain2, 0, hwndMain2, hwndMain2 ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)child ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)child ); ok( ret == hwndMain2, "GWL_HWNDPARENT return value %p expected %p", ret, hwndMain2 ); check_parents( test, child, child, child, 0, hwndMain, hwndMain ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)desktop ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)desktop ); ok( ret == child, "GWL_HWNDPARENT return value %p expected %p", ret, child ); check_parents( test, desktop, 0, desktop, 0, test, desktop ); /* window is now child of desktop so GWL_HWNDPARENT changes owner from now on */ - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)child ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)child ); ok( ret == 0, "GWL_HWNDPARENT return value %p expected 0", ret ); check_parents( test, desktop, child, desktop, child, test, desktop ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, 0 ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, 0 ); ok( ret == child, "GWL_HWNDPARENT return value %p expected %p", ret, child ); check_parents( test, desktop, 0, desktop, 0, test, desktop ); DestroyWindow( test ); @@ -246,15 +287,15 @@ test = create_tool_window( 0, 0 ); trace( "created top-level %p\n", test ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); ok( ret == 0, "GWL_HWNDPARENT return value %p expected 0", ret ); check_parents( test, desktop, hwndMain2, 0, hwndMain2, test, test ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)child ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)child ); ok( ret == hwndMain2, "GWL_HWNDPARENT return value %p expected %p", ret, hwndMain2 ); check_parents( test, desktop, child, 0, child, test, test ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, 0 ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, 0 ); ok( ret == child, "GWL_HWNDPARENT return value %p expected %p", ret, child ); check_parents( test, desktop, 0, 0, 0, test, test ); DestroyWindow( test ); @@ -263,15 +304,15 @@ test = create_tool_window( WS_POPUP, 0 ); trace( "created popup %p\n", test ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)hwndMain2 ); ok( ret == 0, "GWL_HWNDPARENT return value %p expected 0", ret ); check_parents( test, desktop, hwndMain2, hwndMain2, hwndMain2, test, hwndMain2 ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (LONG_PTR)child ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (LONG_PTR)child ); ok( ret == hwndMain2, "GWL_HWNDPARENT return value %p expected %p", ret, hwndMain2 ); check_parents( test, desktop, child, child, child, test, hwndMain ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, 0 ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, 0 ); ok( ret == child, "GWL_HWNDPARENT return value %p expected %p", ret, child ); check_parents( test, desktop, 0, 0, 0, test, test ); DestroyWindow( test ); @@ -310,7 +351,7 @@ ok( ret == desktop, "SetParent return value %p expected %p", ret, desktop ); check_parents( test, child, child, hwndMain2, hwndMain2, hwndMain, hwndMain2 ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (ULONG_PTR)hwndMain ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (ULONG_PTR)hwndMain ); ok( ret == child, "GWL_HWNDPARENT return value %p expected %p", ret, child ); check_parents( test, hwndMain, hwndMain, hwndMain2, hwndMain2, hwndMain, hwndMain2 ); DestroyWindow( test ); @@ -343,7 +384,7 @@ owner = create_tool_window( WS_CHILD, hwndMain2 ); test = create_tool_window( WS_POPUP, 0 ); trace( "created owner %p and popup %p\n", owner, test ); - ret = (HWND)SetWindowLongW( test, GWL_HWNDPARENT, (ULONG_PTR)owner ); + ret = (HWND)test_set_window_long( test, GWL_HWNDPARENT, (ULONG_PTR)owner ); ok( ret == 0, "GWL_HWNDPARENT return value %p expected 0", ret ); check_parents( test, desktop, owner, owner, owner, test, hwndMain2 ); DestroyWindow( owner ); -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

3 5

RtlUnicodeStringToInteger prototype missing, and wrong?
by Dan Kegel Jan. 2, 2003

Jan. 2, 2003

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/kmarch/hh/… says "NTSTATUS RtlUnicodeStringToInteger( IN PUNICODE_STRING String, IN ULONG Base OPTIONAL, OUT PULONG Value ); Declared in wdm.h and ntddk.h. Include wdm.h or ntddk.h." Shouldn't this be declared in wine/include/winternl.h, like the other Rtl functions? And shouldn't wine/dlls/ntdll/rtlstr.c declare it to use an unsigned long instead of an int as its 2nd arg, and an unsigned long * instead of an int * as its 3rd arg? If so, I can submit a patch to fix all that, but as I'm a total wine newbie, I bet there's something I'm missing. - Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

3 2

Win2000 Conformance R3:
by Kye Lewis Jan. 1, 2003

Jan. 1, 2003

Win2000 Conformance Tests Round 3: dsound_test refused to run, complaining of a missing MSVCRTD.dll shlwapi_test shreg gave what I consider to be a rather interesting string in it's error Apart from that, a lot of things were just like WinXP, except for the advapi32_test registry. === advapi32_test === registry: 56 tests executed, 0 marked as todo, 0 failures. === dsound_test === "The dynamic link library MSVCRTD.dll could not be found in the specified path" === gdi32_test === generated: 2786 tests executed, 0 marked as todo, 0 failures. === kernel32_test === alloc: 58 tests executed, 0 marked as todo, 0 failures. atom: 229398 tests executed, 0 marked as todo, 0 failures. codepage: 2 tests executed, 0 marked as todo, 0 failures. directory: 51 tests executed, 0 marked as todo, 0 failures. drive: 160 tests executed, 0 marked as todo, 0 failures. environ: 39 tests executed, 0 marked as todo, 0 failures. file: 487239 tests executed, 0 marked as todo, 0 failures. format_msg: 58 tests executed, 0 marked as todo, 0 failures. generated: 609 tests executed, 0 marked as todo, 0 failures. locale.c:154: Test failed: GetTimeFormat got '' instead of '4' locale.c:155: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:181: Test failed: GetTimeFormat got '8.@:56AM' instead of '8.@:56.@:AM' locale.c:182: Test failed: GetTimeFormat: got 9 instead of 12 locale.c:190: Test failed: GetTimeFormat got '' instead of '3' locale.c:191: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:474: Test failed: GetDateFormat got '5/4/2002' instead of '5/4/02' locale.c:475: Test failed: GetDateFormat: got 9 instead of 7 locale.c:499: Test failed: GetDateFormat check DATE_YEARMONTH with null format expected ERROR_INVALID_FLAGS got return of '10' and error of '0' locale: 109 tests executed, 0 marked as todo, 9 failures. path: 1730 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. process.c:378: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\DOCUME~1\KYELEW~1\DESKTOP\WINETE~1\kernel32_test.exe process.c:530: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\DOCUME~1\KYELEW~1\DESKTOP\WINETE~1\kernel32_test.exe process: 116 tests executed, 0 marked as todo, 2 failures. thread: 112 tests executed, 0 marked as todo, 0 failures. === msvcrt_test === file: 2 tests executed, 0 marked as todo, 0 failures. scanf: 8 tests executed, 0 marked as todo, 0 failures. === netapi32_test === access.c:110: Test failed: Bad Network Path: rc=0 access: 23 tests executed, 0 marked as todo, 1 failure. apibuf: 15 tests executed, 0 marked as todo, 0 failures. wksta: 14 tests executed, 0 marked as todo, 0 failures. === ntdll_test === error: 813 tests executed, 0 marked as todo, 0 failures. rtlbitmap: 201 tests executed, 0 marked as todo, 0 failures. rtlstr: 38 tests executed, 0 marked as todo, 0 failures. === oleaut32_test === safearray: 348 tests executed, 0 marked as todo, 0 failures. vartest.c:1707: ======== Testing VarUI1FromXXX ======== vartest.c:1713:VarUI1FromI2: passing in NULL as return val makes it crash, need to write proper test. vartest.c:1797: ======== Testing VarUI2FromXXX ======== vartest.c:1802:VarUI2FromI2: passing in NULL as return val makes it crash, needs to be fixed. vartest.c:1873: ======== Testing VarUI4FromXXX ======== vartest.c:1876:VarUI4FromI2: passing in NULL as return val makes it crash, implement me. vartest.c:1951: ======== Testing VarI1FromXXX ======== vartest.c:2004: ======== Testing VarI2FromXXX ======== vartest.c:2047: ======== Testing VarI4FromXXX ======== vartest.c:2091: ======== Testing VarR4FromXXX ======== vartest.c:2138: ======== Testing VarR8FromXXX ======== vartest.c:2158: ======== Testing VarDateFromXXX ======== vartest.c:2208: Test failed: VarDateFromStr([7]="0.49") got 0.0340278 instead of 0.034028 vartest.c:2208: Test failed: VarDateFromStr([8]="0.5") got 0.00347222 instead of 0.003472 vartest.c:2208: Test failed: VarDateFromStr([9]="0.51") got 0.0354167 instead of 0.035417 vartest.c:2208: Test failed: VarDateFromStr([34]=" 1 2 ") got 37653 instead of 35797 vartest.c:2215: Test failed: VarDateFromStr([35]="1,2,3") got 37653 instead of 37623 vartest.c:2215: Test failed: VarDateFromStr([36]="1 2 3") got 37653 instead of 37623 vartest.c:2215: Test failed: VarDateFromStr([37]="1,2, 3") got 37653 instead of 37623 vartest.c:2208: Test failed: VarDateFromStr([39]="1.2.3") got 0.0430903 instead of 0.04309 vartest.c:2208: Test failed: VarDateFromStr([69]=" 1999/ 11/21 11 :11:11am") got 36485.5 instead of 36485.5 vartest.c:2208: Test failed: VarDateFromStr([70]="11/11/1999 11:11:11Am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([71]="11/11/1999 11:11:11PM") got 36476 instead of 36476 vartest.c:2208: Test failed: VarDateFromStr([73]="11/11/1999 0:0:11am") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([75]="11/11/1999 11:11:11am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([77]="11/11/1999 11:11AM") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([78]="11/11/1999 1AM") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([80]="11/11/1999 11:11:11") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([89]="1 January 1999 11AM") got 36161.5 instead of 36161.5 vartest.c:2208: Test failed: VarDateFromStr([90]="4AM 11/11/1999") got 36475.2 instead of 36475.2 vartest.c:2208: Test failed: VarDateFromStr([109]="1.5") got 0.0451389 instead of 0.045139 vartest.c:2208: Test failed: VarDateFromStr([110]="2.5") got 0.0868056 instead of 0.086806 vartest.c:2208: Test failed: VarDateFromStr([111]="3.5") got 0.128472 instead of 0.128472 vartest.c:2208: Test failed: VarDateFromStr([112]="4.5") got 0.170139 instead of 0.170139 vartest.c:2223: ======== Testing VarBoolFromXXX ======== vartest.c:2283: ======== Testing VarBSTRFromXXX ======== vartest.c:2308: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2315: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2308: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2315: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2308: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2315: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2308: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2315: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2308: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2315: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2359: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2365: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2359: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2365: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2359: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2365: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2359: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2365: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2359: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2365: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2382: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07, but return val is "8.765432E+07" vartest.c:2388: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2382: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08, but return val is "9.876543E+08" vartest.c:2388: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2382: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09, but return val is "1.987654E+09" vartest.c:2388: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2408: Test failed: d is 0.2345, should be cvt. to 0.2345001, but return val is "0.2345" vartest.c:2432: Test failed: d is 654322, should be cvt. to 654322.2, but return val is "654322.3" vartest.c:2438: Test failed: d is -654322, should be cvt. to -654322.2, but return val is "-654322.3" vartest.c:2432: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07, but return val is "8.765432E+07" vartest.c:2438: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2432: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08, but return val is "9.876543E+08" vartest.c:2438: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2432: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09, but return val is "1.987654E+09" vartest.c:2438: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2457: Test failed: should be '1/2/1900 8:09:36 AM', but is "2/01/1900 8:09:36 AM" vartest.c:2463: Test failed: should be '2/20/1909 8:09:36 AM', but is "20/02/1909 8:09:36 AM" vartest.c:2469: Test failed: should be '12/30/1900', but is "30/12/1900" vartest.c:2475: Test failed: should be '12/30/1900 6:00:00 AM', but is "30/12/1900 6:00:00 AM" vartest.c:2481: Test failed: should be '12/31/1903', but is "31/12/1903" vartest.c:2487: Test failed: should be '12/31/1903 12:00:00 PM', but is "31/12/1903 12:00:00 PM" vartest.c:2493: ======== Testing Hi-Level Variant API ======== vartest.c:2560: Test failed: should be 5/11/94 7:58:42 AM vartest.c:2578:-------------- Testing different VARTYPES ---------------- vartest: 2281 tests executed, 0 marked as todo, 64 failures. === rpcrt4_test === rpc: 901 tests executed, 0 marked as todo, 0 failures. === shell32_test === generated: 272 tests executed, 0 marked as todo, 0 failures. shlfileop.c:120: Test failed: Deletion was successful shlfileop.c:122: Test failed: File should be removed shlfileop.c:124: Test failed: Directory exists, but is not removed shlfileop.c:129: Test failed: Directory removed shlfileop.c:130: Test failed: Directory should be removed shlfileop.c:132: Test failed: The requested file does not exist shlfileop.c:286: Test failed: Files are copied to other directory shlfileop.c:287: Test failed: The file is copied shlfileop.c:316: Test failed: Files and directories are moved to directory shlfileop.c:317: Test failed: The file is moved shlfileop.c:318: Test failed: The directory is moved shlfileop.c:319: Test failed: The file in subdirectory is moved shlfileop: 121 tests executed, 0 marked as todo, 12 failures. === shlwapi_test === clist: 236 tests executed, 0 marked as todo, 0 failures. generated: 19 tests executed, 0 marked as todo, 0 failures. shreg.c:79: Test failed: RegCreateKeyA failed shreg.c:105: Test failed: SHGetValueA failed shreg.c:106: Test failed: (0123456789,bar\subdir1) shreg.c:107: Test failed: (ffffffff) shreg.c:112: Test failed: SHGetValueA failed shreg.c:113: Test failed: (0123456789) shreg.c:114: Test failed: (ffffffff) shreg.c:139: Test failed: test4 RegOpenKey shreg.c:149: Test failed: SHQueryValueExA failed shreg.c:155: Test failed: SHQueryValueExA failed shreg.c:156: Test failed: (3435973836) shreg.c:163: Test failed: SHQueryValueExA failed shreg.c:164: Test failed: (6,24) shreg.c:170: Test failed: SHQueryValueExA failed shreg.c:171: Test failed: (6,43) shreg.c:181: Test failed: (6) shreg.c:183: Test failed: (3435973836) shreg.c:184: Test failed: (6,24) shreg.c:193: Test failed: ERROR_MORE_DATA shreg.c:195: Test failed: (6,43) shreg.c:196: Test failed: (3435973836) shreg.c:204: Test failed: Expected ERROR_MORE_DATA shreg.c:205: Test failed: (0123456789) shreg.c:206: Test failed: (0123456789) shreg.c:207: Test failed: (39,43) shreg.c:208: Test failed: (3435973836) shreg.c:217: Test failed: (6) shreg.c:218: Test failed: (6,43) shreg.c:219: Test failed: (3435973836) shreg.c:125: Test failed: SHRegGetPathA failed shreg.c:126: Test failed: (”•–—˜™Š›ŒŽŸ ¡¢£¤¥¦§¨©ª«¬®¯°±²³´µ¶·¸¹º»¼½¾¿ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÚÛÜÝÞßÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ÷ØÙÚÛÜÝÞŸ !????????,-./0123456789:;Ÿ{Ÿ{?{BCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcde????????????) shreg.c:240: Test failed: didn't open dest shreg: 36 tests executed, 0 marked as todo, 32 failures. === urlmon_test === generated: 4 tests executed, 0 marked as todo, 0 failures. === user32_test === class: 80 tests executed, 0 marked as todo, 0 failures. generated: 1524 tests executed, 0 marked as todo, 0 failures. sysparams.c:184:testing SPI_{GET,SET}BEEP sysparams.c:306:testing SPI_{GET,SET}MOUSE sysparams.c:374:testing SPI_{GET,SET}BORDER sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=1, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=0, value= sysparams.c:139: Test failed: Missed a message: change_counter=2 sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=7, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=20, value= sysparams.c:406:testing SPI_{GET,SET}KEYBOARDSPEED sysparams.c:139: Test failed: Missed a message: change_counter=2 sysparams.c:440:testing SPI_ICONHORIZONTALSPACING sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=101, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=32, value= sysparams.c:480:testing SPI_{GET,SET}SCREENSAVETIMEOUT sysparams.c:515:testing SPI_{GET,SET}SCREENSAVEACTIVE sysparams.c:555:testing SPI_{GET,SET}KEYBOARDDELAY sysparams.c:590:testing SPI_ICONVERTICALSPACING sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=101, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=32, value= sysparams.c:635:testing SPI_{GET,SET}ICONTITLEWRAP sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=1, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=0, value= sysparams.c:670:testing SPI_{GET,SET}MENUDROPALIGNMENT sysparams.c:707:testing SPI_SETDOUBLECLKWIDTH sysparams.c:738:testing SPI_SETDOUBLECLKHEIGHT sysparams.c:770:testing SPI_SETDOUBLECLICKTIME sysparams.c:817:testing SPI_SETMOUSEBUTTONSWAP sysparams.c:880:testing SPI_{GET,SET}DRAGFULLWINDOWS sysparams.c:915:testing SPI_{GET,SET}WORKAREA sysparams.c:953:testing SPI_{GET,SET}SHOWSOUNDS sysparams.c:997:testing SPI_{GET,SET}DESKWALLPAPER sysparams: 318 tests executed, 0 marked as todo, 12 failures. win.c:132:main window 000202D2 main2 000202C8 desktop 0001000C child 000202C6 win.c:148:created child 000202C4 win.c:161:created child of desktop 000302C4 win.c:171:created child of child 000402C4 win.c:181:created top-level 000502C4 win.c:191:created owned top-level 000602C4 win.c:201:created popup 000702C4 win.c:211:created owned popup 000802C4 win.c:221:created top-level owned by child 000902C4 win.c:227:created popup owned by desktop 000A02C4 win.c:233:created popup owned by child 000B02C4 win.c:239:created WS_CHILD popup 000C02C4 win.c:245:created owned WS_CHILD popup 000D02C4 win.c:250:testing parent changes win.c:262:created child 000E02C4 win.c:288:created top-level 000F02C4 win.c:305:created popup 001002C4 win.c:322:created child 001102C4 win.c:339:created top-level 001202C4 win.c:348:created owned popup 001302C4 win.c:364:created owner 001402C4 and popup 000202C2 win.c:378:created owner 000302C2 and popup 001502C4 win.c:386:created owner 000402C2 and popup 001602C4 win: 428 tests executed, 0 marked as todo, 0 failures. wsprintf: 4 tests executed, 0 marked as todo, 0 failures. === wininet_test === generated: 252 tests executed, 0 marked as todo, 0 failures. (Lines removed...) http.c:172: Test failed: InternetQueryDataAvailable failed (Lines Removed...) http: 28 tests executed, 0 marked as todo, 1 failure. === winmm_test === wave: 149 tests executed, 0 marked as todo, 0 failures. === ws2_32_test sock: 286 tests executed, 0 marked as todo, 0 failures. Thanks, Kye Lewis LinksOS Project Administrator LinksOS Web Team Leader kyethespy(a)softhome.net (New email address! kyethespy(a)liquid2k.comwill still work, but please send all emails now to new email) "640k ought to be enough for anyone!" - Bill Gates ================================= LinksOS: Linking you to the world http://linksos.cjb.net http://linksos.sourceforge.net/ http://linksos.oxygen-x.net/ Now with Bugzilla and phpBB installed :) =================================

2 1

Tests for URL functions in shlwapi
by Matthew Mastracci Jan. 1, 2003

Jan. 1, 2003

I've started on some tests in shlwapi. I've added the following file to the tests directory under shlwapi, but I can't include it in a cvs diff, because I don't have write access to the repository. Any hints as to diffing a new file cleanly w/o write access to CVS? These tests compile and run clean with the last CVS tree I pulled (a few days ago). I need to flesh them out, but it's a start. Here is the diff for the Makefile.in: cvs server: Diffing dlls/shlwapi/tests Index: dlls/shlwapi/tests/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/shlwapi/tests/Makefile.in,v retrieving revision 1.2 diff -u -r1.2 Makefile.in --- dlls/shlwapi/tests/Makefile.in 12 Nov 2002 01:13:10 -0000 1.2 +++ dlls/shlwapi/tests/Makefile.in 31 Dec 2002 20:51:24 -0000 @@ -8,7 +8,8 @@ CTESTS = \ clist.c \ generated.c \ - shreg.c + shreg.c \ + url.c @MAKE_TEST_RULES@ --- 8< --- And the entire file for url.c in dlls/shlwapi/tests/url.c: --- 8< --- /* Unit test suite for Url* functions * * Copyright 2002 Matthew Mastracci * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2.1 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include <assert.h> #include <stdlib.h> #include <stdio.h> #include "wine/test.h" #include "wine/unicode.h" #include "winbase.h" #include "shlwapi.h" #include "wininet.h" const char* TEST_URL_1 = "http://www.winehq.org/tests?date=10/10/1923"; const char* TEST_URL_2 = "http://localhost:8080/tests%2e.html?date=Mon%2010/10/1923"; const char* TEST_URL_3 = "http://foo:bar(a)localhost:21/internal.php?query=x&return=y"; static LPWSTR GetWideString(const char* szString) { LPWSTR wszString = (LPWSTR) HeapAlloc(GetProcessHeap(), 0, (2*INTERNET_MAX_URL_LENGTH) * sizeof(WCHAR)); MultiByteToWideChar(0, 0, szString, -1, wszString, INTERNET_MAX_URL_LENGTH); return wszString; } static void FreeWideString(LPWSTR wszString) { HeapFree(GetProcessHeap(), 0, wszString); } static void hash_url(const char* szUrl) { LPCSTR szTestUrl = szUrl; LPWSTR wszTestUrl = GetWideString(szTestUrl); DWORD cbSize = sizeof(DWORD); DWORD dwHash1, dwHash2; ok(UrlHashA(szTestUrl, (LPBYTE)&dwHash1, cbSize) == S_OK, "UrlHashA didn't return S_OK"); ok(UrlHashW(wszTestUrl, (LPBYTE)&dwHash2, cbSize) == S_OK, "UrlHashW didn't return S_OK"); FreeWideString(wszTestUrl); ok(dwHash1 == dwHash2, "Hashes didn't compare"); } static void test_UrlHash(void) { hash_url(TEST_URL_1); hash_url(TEST_URL_2); hash_url(TEST_URL_3); } static void test_url_part(const char* szUrl, DWORD dwPart, DWORD dwFlags, char* szExpected) { CHAR szPart[INTERNET_MAX_URL_LENGTH]; WCHAR wszPart[INTERNET_MAX_URL_LENGTH]; LPWSTR wszUrl = GetWideString(szUrl); LPWSTR wszConvertedPart; DWORD dwSize; dwSize = INTERNET_MAX_URL_LENGTH; ok( UrlGetPartA(szUrl, szPart, &dwSize, dwPart, dwFlags) == S_OK, "UrlGetPartA didn't return S_OK" ); dwSize = INTERNET_MAX_URL_LENGTH; ok( UrlGetPartW(wszUrl, wszPart, &dwSize, dwPart, dwFlags) == S_OK, "UrlGetPartW didn't return S_OK" ); wszConvertedPart = GetWideString(szPart); ok(strcmpW(wszPart,wszConvertedPart)==0, "Strings didn't match between ascii and unicode UrlGetPart!"); FreeWideString(wszUrl); FreeWideString(wszConvertedPart); ok(strcmp(szPart,szExpected)==0, "Expected %s, but got %s", szExpected, szPart); } static void test_UrlGetPart(void) { test_url_part(TEST_URL_3, URL_PART_HOSTNAME, 0, "localhost"); test_url_part(TEST_URL_3, URL_PART_PORT, 0, "21"); test_url_part(TEST_URL_3, URL_PART_USERNAME, 0, "foo"); test_url_part(TEST_URL_3, URL_PART_PASSWORD, 0, "bar"); test_url_part(TEST_URL_3, URL_PART_SCHEME, 0, "http"); test_url_part(TEST_URL_3, URL_PART_QUERY, 0, "?query=x&return=y"); } START_TEST(url) { test_UrlHash(); test_UrlGetPart(); } -- Matthew Mastracci <matt(a)aclaro.com>

2 1

stricmp
by Shachar Shemesh Jan. 1, 2003

Jan. 1, 2003

Hi, It seems that stricmp is not available for winelib applications. Is this an intentional ommision, or just a missing implementation? Shachar

3 4

Re: fptest.exe output W98SE
by Drew Ogle Jan. 1, 2003

Jan. 1, 2003

I was exploring what was making win2k's cmd.exe crash, and I had found a problem in GetFullPathName, so I wrote a test. AndiM nicly ran it for me in win98se. Andreas Mohr wrote: >Hi, > >A:\>fptest >C:\ returned 3 and C:\ in buf, and 00000000 is the s pointer. >C:\\ returned 4 and C:\\ in buf, and 00000000 is the s pointer. >C:\.. returned 3 and C:\ in buf, and 00000000 is the s pointer. >C:\\.. returned 4 and C:\\ in buf, and 00000000 is the s pointer. >C:\Program Files\.. returned 3 and C:\ in buf, and 00000000 is the s ptr. >C:\\Program Files\.. returned 4 and C:\\ in buf, and 00000000 is the s ptr. >C:\blargzool urned 14 and C:\blargazoool in buf, and 0073FCD3 is the s ptr. > >HTH, > >Andi > > On the XP machine I have, C:\\ returns C:\ and C:\\.. returns C:\ I did not modify any code yet, but instead bring it up here as possibly something we need to have code that behaves differently to mimic different windows versions -Dante

2 2

Win98 Compliance Status
by Mathew McBride Jan. 1, 2003

Jan. 1, 2003

I downloaded and ran the Wine Comformance tests from http://fgouget.free.fr/wine/winetests.zip Dr. Watson (drwatson.exe) was enabled advapi32_test.exe/registry crash DrWatson: The application overflowed its temporary memory area. Module Name: ADVAPI32_TEST.E Application Name: Advapi32_test.exe dsound_text.exe I don't have msvcrtd.dll (where can I get it) REQUEST: Is it possible to compile these tests using mingw32. gdi32_test.exe/generated 2786 tests executed, 0 marked as todo, 0 failures kernel32_test.exe/alloc alloc.c:208: Test failed: GlobalReAlloc failed to convert FIXED to MOVEABLE: err or=87 alloc.c:213: Test failed: Converting from FIXED to MOVEABLE didn't REALLY work alloc.c:238: Test failed: Discarded memory we shouldn't have alloc.c:239: Test failed: GlobalUnlock Failed. alloc: 58 tests executed, 0 marked as todo, 4 failures. kernel32_test.exe/atom atom.c:55:WARNING: Unicode atom APIs are not supported on this platform atom: 163850 tests executed, 0 marked as todo, 0 failures. kernel32_test.exe/codepage 2 tests executed, 0 marked as todo, 0 failures kernel32_test.exe/directory 25 tests executed, 0 todo, 0 failures kernel32_test.exe/drive 80 tests executed,0 todo, 0 failures kernel32_test.exe/environ 19 executed, 0 todo, 0 failures kernel32_test.exe/file file.c:631: Test failed: WriteFile error 183 file.c:632: Test failed: expected number of bytes written 0 file.c:633:Current offset = 0100 file.c:634: Test failed: expected file offset 21 file.c:639: Test failed: WriteFile error 87 file.c:640: Test failed: expected number of bytes written 0 file.c:642: Test failed: expected file offset 517 file.c:656: Test failed: ReadFile error 0 file.c:657: Test failed: expected number of bytes read 0 file.c:658:Current offset = 0000 file.c:659: Test failed: expected file offset 21 file.c:661: Test failed: pattern match failed file: 487224 tests executed, 0 marked as todo, 10 failures. kernel32_test.exe/format_msg 58 executed, 0 todo, 0 failures kernel32_test.exe/generated 609 executed, 0 marked as todo, 0 failures kernel32_test.exe/locale locale.c:499: Test failed: GetDateFormat check DATE_YEARMONTH with null format e xpected ERROR_INVALID_FLAGS got return of '10' and error of '0' /locale: 105 tests executed, 0 marked as todo, 1 failure. kernel32_test.exe/path path.c:881:TMP=C:\WINDOWS\TEMP path.c:892:TMP=C:\WINDOWS path.c:902:TMP=C:\ path.c:912:TMP=C: 1702 executed, 0 todo, 0 failures kernel32_test.exe/process tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. 116 executed, 0 todo, 0 failures kernel32_test.exe/thread thread.c:430: Test failed: SetThreadPriorityBoost Failed thread.c:432: Test failed: GetThreadPriorityBoost Failed thread.c:434: Test failed: SetThreadPriorityBoost Failed thread.c:436: Test failed: GetThreadPriorityBoost Failed 86 executed, 0 todo, 4 failures msvcrt_test.exe/file 2 executed, 0 todo, 4 failures msvcrt_test.exe/scanf 8 tests executed, 0 todo, 0 failures netapi32_test.exe access.c:174:It appears there is no netapi32 functionality on this platform same error reported by all netapi32 tests. ntdll_test.exe/error 813 executed, 0 todo, 0 failures ntdll_test.exe/generated 1279 executed, 0 todo, 0 failures ntdll_test.exe/rtlbitmap, ntdll_test.exe/rtlst 1 executed, 0 todo, 0 failures

2 1

File locking ... need info
by Mike Robinson Jan. 1, 2003

Jan. 1, 2003

[Please reply e-mail; I don't yet subscribe.] I am interested in support for file-locking and locking of specified regions of a file, in order to support databases such as MS-Access and Paradox. But as I ponder the various likely-looking segments of the source-code, I really do not know where to begin ... nor what has been done in this area before. It is clear that an implementation of locking must work on SMB-shares and that it should "actually lock things" in that other Windows users should see the locks as they are placed and removed. It's also clear that implementing timeouts on these locks could be "problematic," since the Unix impl. of file locking is not quite the same as Windows expects. Pointers? Comments? War-stories? Advice? "Someone already did that"s?

3 3

tests: ok(0,"foo") prints a '\n'!
by Francois Gouget Dec. 31, 2002

Dec. 31, 2002

I noticed that the oleaut32/safearray test uses statements such as: ok(a->cDims == i,"a->cDims not initialised?\n"); But it is not necessary to add a '\n' to ok statements. All it does is insert an extra '\n' after each test error. I could send a patch to fix this (small) issue, but I think this behavior of 'ok' is wrong. It goes against the convention established by all other functions such as printf, TRACE, ERR and even the test framework's own trace function. None of these appends a '\n'. 'ok' is the exception there and safearray is not the first test (nor the last) to get caught by this. So if noone objects I'll send a patch that stops 'ok' from appending this '\n', and adds a '\n' to all calls to ok. Actually, I would be pretty happy if someone could come up with a perl script doing the latter... Comments? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ 145 = 1! + 4! + 5!

3 3

Wine Packagers Guide
by Tom Wickline Dec. 31, 2002

Dec. 31, 2002

I read over the Packagers Guide and here is a short list of things that I found that need looking into. I could use some help, input on this. --- 1.3. Terms used in this document FHS 2.1 specifications current version is 2.2 ---- 2.2. Requirements Wine will not run without a configuration file. Further, no default is currently provided by Wine. this has changed ? Wine does not completely support a complex multi-user installation ala Windows NT, but it could fairly readily. Does it now ? ---- 3.1. Wine Static and Shareable Files 2 Shared Object Library Files list 139 now there is 167 ? 3 Man Pages No winemaker man page listed 4 Include Files list 132 files is this list upto date ? 5 Documentation files. Need to make a list of Doc files. --- 5.1. OpenLinux Sample And why not a ditro independent Sample ? 1 Building the package this section needs updated Wine.ini ??? --- Chapter 6. Work to be done Needs work..... Tom

1 0

Re: PathCreateFromUrlW
by Dimitrie O. Paun Dec. 31, 2002

Dec. 31, 2002

On December 31, 2002 02:06 pm, Matthew Mastracci wrote: > Sorry, here's the unified diff. Thanks! However, please generate the diff relative to wine's root, as I suggested: cvs diff -u dlls/shlwapi/path.c What you did is this: cd dlls/shlwapi; cvs diff -u path.c which just makes things harder for Alexandre when applying the patch. -- Dimi.

2 1

PathCreateFromUrlW
by Matthew Mastracci Dec. 31, 2002

Dec. 31, 2002

Here's an implementation of PathCreateFromUrlW that helps Kazaa crash later rather than sooner. :) Can someone review this and check it in (if it doesn't require any fixes)? Index: path.c =================================================================== RCS file: /home/wine/wine/dlls/shlwapi/path.c,v retrieving revision 1.27 diff -r1.27 path.c 3157c3157,3159 < FIXME("(%s,%p,%p,0x%08lx)-stub\n", debugstr_w(lpszUrl), lpszPath, pcchPath, dwFlags); --- > static const WCHAR stemp[] = { 'f','i','l','e',':','/','/',0 }; > LPWSTR pwszPathPart; > TRACE("(%s,%p,%p,0x%08lx)\n", debugstr_w(lpszUrl), lpszPath, pcchPath, dwFlags); 3162c3164,3189 < return S_OK; --- > // Path of the form file://... > if (!strncmpW(lpszUrl, stemp, 7)) > { > lpszUrl += 7; > } > // Path of the form file:... > else if (!strncmpW(lpszUrl, stemp, 5)) > { > lpszUrl += 5; > } > > // Ensure that path is of the form c:... or c|... > if (lpszUrl[1] != ':' && lpszUrl[1] != '|' && isalphaW(*lpszUrl)) > return E_INVALIDARG; > > HRESULT hr = UrlUnescapeW(lpszUrl, lpszPath, pcchPath, dwFlags); > if (lpszPath[1] == '|') > lpszPath[1] = ':'; > > for (pwszPathPart = lpszPath; *pwszPathPart; pwszPathPart++) > if (*pwszPathPart == '/') > *pwszPathPart = '\\'; > > TRACE("Returning %s\n",debugstr_w(lpszPath)); > > return hr; -- Matthew Mastracci <matt(a)aclaro.com>

2 1

XP Conformance Test Results: Round 3...
by Kye Lewis Dec. 31, 2002

Dec. 31, 2002

Windows XP Results: Round 3 More tests added. Some Previous tests fail differently.. 1 regression in kernel32:locale as far as I can see... === advapi32_test === registry.c:96: Test failed: value set to 'xxxxxxxxxx' instead of 'Te' registry.c:97: Test failed: data set to 'xxxxxxx' instead of 'foobar' registry.c:111: Test failed: data set to 'xxxxxxx' instead of 'foobar' registry: 56 tests executed, 0 marked as todo, 3 failures. === dsound_test === dsound: 63 tests executed, 0 marked as todo, 0 failures. === gdi32_test === generated: 2786 tests executed, 0 marked as todo, 0 failures. === kernel32_test === alloc: 58 tests executed, 0 marked as todo, 0 failures. atom: 229398 tests executed, 0 marked as todo, 0 failures. codepage: 2 tests executed, 0 marked as todo, 0 failures. directory: 51 tests executed, 0 marked as todo, 0 failures. drive: 156 tests executed, 0 marked as todo, 0 failures. environ: 39 tests executed, 0 marked as todo, 0 failures. file: 487239 tests executed, 0 marked as todo, 0 failures. format_msg: 58 tests executed, 0 marked as todo, 0 failures. generated: 609 tests executed, 0 marked as todo, 0 failures. locale.c:154: Test failed: GetTimeFormat got '' instead of '4' locale.c:155: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:181: Test failed: GetTimeFormat got '8.@:56AM' instead of '8.@:56.@:AM' locale.c:182: Test failed: GetTimeFormat: got 9 instead of 12 locale.c:190: Test failed: GetTimeFormat got '' instead of '3' locale.c:191: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:474: Test failed: GetDateFormat got '5/4/2002' instead of '5/4/02' locale.c:475: Test failed: GetDateFormat: got 9 instead of 7 locale.c:499: Test failed: GetDateFormat check DATE_YEARMONTH with null format expected ERROR_INVALID_FLAGS got return of '10' and error of '0' locale.c:530: Test failed: GetDateFormatW allowed flags and format locale.c:539: Test failed: GetDateFormatW did not permit null buffer pointer when counting. locale: 109 tests executed, 0 marked as todo, 11 failures. path: 1730 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. (identical lines removed.) tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. process.c:378: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\DOCUME~1\Owner\DESKTOP\WINETE~1\kernel32_test.exe process.c:530: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\DOCUME~1\Owner\DESKTOP\WINETE~1\kernel32_test.exe process: 116 tests executed, 0 marked as todo, 2 failures. thread: 112 tests executed, 0 marked as todo, 0 failures. file: 2 tests executed, 0 marked as todo, 0 failures. === msvcrt_test === scanf: 8 tests executed, 0 marked as todo, 0 failures. === netapi32_test === access.c:110: Test failed: Bad Network Path: rc=0 access: 23 tests executed, 0 marked as todo, 1 failure. apibuf: 15 tests executed, 0 marked as todo, 0 failures. wksta: 14 tests executed, 0 marked as todo, 0 failures. === ntdll_test === error: 813 tests executed, 0 marked as todo, 0 failures. rtlbitmap: 224 tests executed, 0 marked as todo, 0 failures. rtlstr: 38 tests executed, 0 marked as todo, 0 failures. === oleaut32_test === safearray.c:131: Test failed: SAC(20,1,[1,0]), result 8, expected 0 safearray.c:131: Test failed: SAC(21,1,[1,0]), result 8, expected 0 safearray.c:131: Test failed: SAC(37,1,[1,0]), result 4, expected 0 safearray.c:131: Test failed: SAC(38,1,[1,0]), result 4, expected 0 safearray: 348 tests executed, 0 marked as todo, 4 failures. ======== Testing VarUI1FromXXX ======== vartest.c:1713:VarUI1FromI2: passing in NULL as return val makes it crash, need to write proper test. vartest.c:1797: ======== Testing VarUI2FromXXX ======== vartest.c:1802:VarUI2FromI2: passing in NULL as return val makes it crash, needs to be fixed. vartest.c:1873: ======== Testing VarUI4FromXXX ======== vartest.c:1876:VarUI4FromI2: passing in NULL as return val makes it crash, implement me. vartest.c:1951: ======== Testing VarI1FromXXX ======== vartest.c:2004: ======== Testing VarI2FromXXX ======== vartest.c:2047: ======== Testing VarI4FromXXX ======== vartest.c:2091: ======== Testing VarR4FromXXX ======== vartest.c:2138: ======== Testing VarR8FromXXX ======== vartest.c:2158: ======== Testing VarDateFromXXX ======== vartest.c:2208: Test failed: VarDateFromStr([7]="0.49") got 0.0340278 instead of 0.034028 vartest.c:2208: Test failed: VarDateFromStr([8]="0.5") got 0.00347222 instead of 0.003472 vartest.c:2208: Test failed: VarDateFromStr([9]="0.51") got 0.0354167 instead of 0.035417 vartest.c:2208: Test failed: VarDateFromStr([34]=" 1 2 ") got 37258 instead of 35797 vartest.c:2208: Test failed: VarDateFromStr([39]="1.2.3") got 0.0430903 instead of 0.04309 vartest.c:2208: Test failed: VarDateFromStr([69]=" 1999/ 11/21 11 :11:11am") got 36485.5 instead of 36485.5 vartest.c:2208: Test failed: VarDateFromStr([70]="11/11/1999 11:11:11Am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([71]="11/11/1999 11:11:11PM") got 36476 instead of 36476 vartest.c:2208: Test failed: VarDateFromStr([73]="11/11/1999 0:0:11am") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([75]="11/11/1999 11:11:11am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([77]="11/11/1999 11:11AM") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([78]="11/11/1999 1AM") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([80]="11/11/1999 11:11:11") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([89]="1 January 1999 11AM") got 36161.5 instead of 36161.5 vartest.c:2208: Test failed: VarDateFromStr([90]="4AM 11/11/1999") got 36475.2 instead of 36475.2 vartest.c:2208: Test failed: VarDateFromStr([109]="1.5") got 0.0451389 instead of 0.045139 vartest.c:2208: Test failed: VarDateFromStr([110]="2.5") got 0.0868056 instead of 0.086806 vartest.c:2208: Test failed: VarDateFromStr([111]="3.5") got 0.128472 instead of 0.128472 vartest.c:2208: Test failed: VarDateFromStr([112]="4.5") got 0.170139 instead of 0.170139 vartest.c:2223: ======== Testing VarBoolFromXXX ======== vartest.c:2283: ======== Testing VarBSTRFromXXX ======== vartest.c:2308: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2315: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2308: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2315: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2308: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2315: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2308: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2315: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2308: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2315: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2359: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2365: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2359: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2365: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2359: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2365: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2359: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2365: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2359: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2365: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2382: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07, but return val is "8.765432E+07" vartest.c:2388: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2382: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08, but return val is "9.876543E+08" vartest.c:2388: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2382: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09, but return val is "1.987654E+09" vartest.c:2388: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2408: Test failed: d is 0.2345, should be cvt. to 0.2345001, but return val is "0.2345" vartest.c:2432: Test failed: d is 654322, should be cvt. to 654322.2, but return val is "654322.3" vartest.c:2438: Test failed: d is -654322, should be cvt. to -654322.2, but return val is "-654322.3" vartest.c:2432: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07, but return val is "8.765432E+07" vartest.c:2438: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2432: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08, but return val is "9.876543E+08" vartest.c:2438: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2432: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09, but return val is "1.987654E+09" vartest.c:2438: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2493: ======== Testing Hi-Level Variant API ======== vartest.c:2560: Test failed: should be 5/11/94 7:58:42 AM vartest.c:2578:-------------- Testing different VARTYPES ---------------- vartest: 2281 tests executed, 0 marked as todo, 55 failures. === rpcrt4_test === rpc: 901 tests executed, 0 marked as todo, 0 failures. === shell32_test === generated: 272 tests executed, 0 marked as todo, 0 failures. shlfileop.c:120: Test failed: Deletion was successful shlfileop.c:122: Test failed: File should be removed shlfileop.c:124: Test failed: Directory exists, but is not removed shlfileop.c:129: Test failed: Directory removed shlfileop.c:130: Test failed: Directory should be removed shlfileop.c:132: Test failed: The requested file does not exist shlfileop.c:286: Test failed: Files are copied to other directory shlfileop.c:287: Test failed: The file is copied shlfileop.c:316: Test failed: Files and directories are moved to directory shlfileop.c:317: Test failed: The file is moved shlfileop.c:318: Test failed: The directory is moved shlfileop.c:319: Test failed: The file in subdirectory is moved shlfileop: 121 tests executed, 0 marked as todo, 12 failures. === shlwapi_test === clist.c:367: Test failed: allowed bad element size clist.c:372: Test failed: allowed adding a container clist: 236 tests executed, 0 marked as todo, 2 failures. generated: 19 tests executed, 0 marked as todo, 0 failures. shreg.c:171: Test failed: (44,43) shreg.c:195: Test failed: (44,43) shreg.c:205: Test failed: () shreg.c:206: Test failed: () shreg.c:207: Test failed: (44,43) shreg.c:218: Test failed: (44,43) shreg.c:240: Test failed: didn't open dest shreg: 39 tests executed, 0 marked as todo, 7 failures. === urlmon_test === generated: 4 tests executed, 0 marked as todo, 0 failures. === user32_test === class: 80 tests executed, 0 marked as todo, 0 failures. generated: 1524 tests executed, 0 marked as todo, 0 failures. Sysparams: win: 428 tests executed, 0 marked as todo, 0 failures. wsprintf: 4 tests executed, 0 marked as todo, 0 failures. === wininet_test === generated: 252 tests executed, 0 marked as todo, 0 failures. (Lines removed.) http.c:172: Test failed: InternetQueryDataAvailable failed (Lots more lines removed.) http: 25 tests executed, 0 marked as todo, 1 failure. === winmm_test === wave: 149 tests executed, 0 marked as todo, 0 failures. === ws2_32_test === sock: 128 tests executed, 0 marked as todo, 0 failures. Thanks, Kye Lewis LinksOS Project Administrator LinksOS Web Team Leader kyethespy(a)softhome.net (New email address! kyethespy(a)liquid2k.comwill still work, but please send all emails now to new email) "640k ought to be enough for anyone!" - Bill Gates ================================= LinksOS: Linking you to the world http://linksos.cjb.net http://linksos.sourceforge.net/ http://linksos.oxygen-x.net/ Now with Bugzilla and phpBB installed :) =================================

2 1

Putty: Winelib support (take 2)
by Dimitrie O. Paun Dec. 31, 2002

Dec. 31, 2002

On December 18, 2002 04:59 am, Simon Tatham wrote: > That said, I also agree your revised patch is a huge amount better > by comparison! So if you'd rather I wait until that's ready, I'm > fine with that too. Hi Simon, I've managed to cleanup my changes. Currently only this 3-line patch is required to compile putty under Winelib. The way it works is that you simply uncomment 2 (two) lines in the Makefile.cyg file, and do the usual: make -f Makefile.cyg to compile under Wine. This has the advantage that you don't need to maintain a Wine-only Makefile that is quite likely to get bitrotten sooner rather than later. Please let me know if you need any other changes. Happy New Year! Index: mkfiles.pl =================================================================== RCS file: /home/cvs/putty/mkfiles.pl,v retrieving revision 1.38 diff -u -r1.38 mkfiles.pl --- mkfiles.pl 30 Dec 2002 23:14:11 -0000 1.38 +++ mkfiles.pl 31 Dec 2002 09:31:29 -0000 @@ -293,6 +293,9 @@ "# TOOLPATH = /pkg/mingw32msvc/i386-mingw32msvc/bin/\n". "CC = \$(TOOLPATH)gcc\n". "RC = \$(TOOLPATH)windres\n". +"# Uncomment the following two lines to compile under Winelib\n". +"# CC = winegcc\n". +"# RC = wrc\n". "# You may also need to tell windres where to find include files:\n". "# RCINC = --include-dir c:\\cygwin\\include\\\n". "\n". -- Dimi.

1 0

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)
by Patrik Stridvall Dec. 31, 2002

Dec. 31, 2002

> On December 30, 2002 12:43 pm, Dan Kegel wrote: > > OK, maybe that's another janitorial project I can take on. > > You asked for it! :) > http://www.dssd.ca/wine/Wine-Janitorial.html#include-quotes I'm already on it by improving winapi_cleanup. I'm not 100% sure it is correct though and I havn't any time to work on it until after new year so here is what I currently got. Alexandre: You can apply it as it is regardless. It it off by default so it can't hurt. Use it like: winapi_cleanup --include-qoutes Note that you can also do on specific directories by specifing them on the command line. Like: winapi_cleanup --include-qoutes include dlls

2 1