December 2002 - Wine-Devel - list.winehq.org

Re: Listview report mode tweaks #2
by Dimitrie O. Paun Dec. 20, 2002

Dec. 20, 2002

On December 20, 2002 01:02 pm, Duane Clark wrote: > So the only fix to LISTVIEW_GetSubItemRect that remains is to change the > offset that is applied. This looks great. Another small nit: + if (!(uFormat & (DT_RIGHT | DT_CENTER))) + { + if (himl && lvItem.iImage >= 0 && !IsRectEmpty(&rcIcon)) rcLabel.left += 2; + else rcLabel.left += 5; + } + else if (uFormat & DT_RIGHT) rcLabel.right -= 5; It seems this "5" is the same, so maybe a symbolic constant would be better. Also, it seems the 2 has to do with IMAGE_PADDING which you changed to 0, so maybe a small rearangement can make this thing more clear. What I mean is that you disabled image padding, and you achive it some other way using explicit numbers (2, 5, etc). Turning the logic inside out, maybe we can give meaning back to IMAGE_PADDING. If not, we should remove it and introduce another meaningful constant. -- Dimi.

1 0

Re: rpcdce.h fixes
by Ove Kaaven Dec. 20, 2002

Dec. 20, 2002

On Fri, 20 Dec 2002, Dimitrie O. Paun wrote: > MinGW has them defined this way, and wxWindows likes them like this. > Can someone please check that this matches the Windows headers? It does, but it was more difficult to get things (rpcrt4 in particular) to compile without warnings (or huge piles of typecasts) this way, so I decided to just use LPSTR/LPWSTR instead in the rpc headers. Didn't think it would cause problems. > RPCRTAPI RPC_STATUS RPC_ENTRY > - RpcStringFreeA(LPSTR* String); > + RpcStringFreeA(unsigned char** String); > RPCRTAPI RPC_STATUS RPC_ENTRY > - RpcStringFreeW(LPWSTR* String); > + RpcStringFreeW(unsigned short** String); > #define RpcStringFree WINELIB_NAME_AW(RpcStringFree)

3 3

ThunkTheTemplateHandle and Kazaa
by Ender Dec. 20, 2002

Dec. 20, 2002

Hi all. Trying to run any recent version of Kazaa (Lite) under WINE fails for me, as it trys to call an unimplemented krnl386.exe stub... ordinal 538 (ThunkTheTemplateHandle). After doing a little minimal debugging, all I could see that ordinal doing was messing with some segment pointers and calling ordinal 630 (C16ThkSL). I really have no idea what any of this stuff does (*cough*), although copying the line for ordinal 630 into ordinal 538 makes Kazaa work for me :) I don't suppose anybody with a little more knowledge of this bit of Windows knows what actually goes on here? It'd be nice to see this fixed (properly :) in CVS, as Kazaa is a fairly popular application. Cheers, Ender

2 3

Re: Listview report mode tweaks
by Dimitrie O. Paun Dec. 20, 2002

Dec. 20, 2002

On December 19, 2002 07:48 pm, Duane Clark wrote: > I also altered LISTVIEW_GetSubItemRect so that it reports correct > values, as compared against WinNT on ControlSpy. Problem is that LISTVIEW_GetSubItemRect is documented to return same thing for LVIR_LABEL and LVIR_BOUNDS. Of course, incorrect documentation is known to exist, so as long as you checked it... However, when we implement things different from the documented behavior, a clear comment explaining why we deviate is appropriate. Otherwise, someone might get rid of it in the future. :( -- Dimi.

2 1

Wineconsole 'regression'
by Lionel Ulmer Dec. 20, 2002

Dec. 20, 2002

Hi all, Since the introduction of the 'ncurses' driver for the wineconsole program, the only program using the console is completely broken (IDA). Well, it actually starts faster than with the USER back-end but after that it's mostly unusable. I looked at the wineconsole code and it does not seem that there is a configure option or any other mean to have wineconsole act as before (ie to use the slow but working USER driver). So : 1) I did not look long enough 2) I should stop bitching and fix the ncurses driver What irks me is that the debugger is still working as before (ie not very stable, but at least not buggy in an xterm :-) ). Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 2

Re: Conformance tests failing
by chrismorgan＠rcn.com Dec. 20, 2002

Dec. 20, 2002

I'll take a look at it and see what might be up. The tests all passed on my nt4 machine and on my local wine with the ole2nls changes, it should be pretty easy to resolve these issues. Chris > > From: Paul Millar <paulm(a)astro.gla.ac.uk> > Date: 2002/12/20 Fri AM 07:10:27 EST > To: Development to WINE <wine-devel(a)winehq.com> > Subject: Conformance tests failing > > Hi everyone, > > The extra support added by Chris in: > http://cvs.winehq.com/patch.py?id=6743 > doesn't seem be enough for wine to pass all of his new conformance tests > added in: > http://cvs.winehq.com/patch.py?id=6744 > A few of them failed, caused WRT reported: > > locale.c:164: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:164: Test failed: GetTimeFormat: got 6 instead of 8 > > locale.c:146: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:146: Test failed: GetTimeFormat got '08' instead of '8 AM' > > locale.c:147: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:147: Test failed: GetTimeFormat: got 3 instead of 5 > > locale.c:163: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:163: Test failed: GetTimeFormat got '08:56' instead of '8:56 AM' > > for 95, 98, me, NT, Win2k, ... (the database is still updating at the > moment) > > Details of the build are available at: > http://www.astro.gla.ac.uk/users/paulm/WRT/buildinfo.php?id=271 > > ---- > Paul Millar > > > > >

1 0

IE5.5 and 6.0sp1 error [Unimplimented]
by Boris Dec. 20, 2002

Dec. 20, 2002

I just downloaded the latest cvs on a system without windows files. I tried to install IE5.5 and IE 6.0sp1 as win2k or winxp and as it tries to install, the following error occurs Unimplimented Kernel32.dll.VerSetConditionMask in 32bit mode. Anyone looking to write an update to kernel32.dll to add the function?

2 1

Include_winsock_h_before_stdlib_h_or_use_the_MSVCRT_library
by Dimitrie O. Paun Dec. 20, 2002

Dec. 20, 2002

Folks, This does not work (<= is include): winsock.h <= sys/types.h <= sys/select.h BANG! FD_CLR gets defined before we have a chance to manipulate it. Any ideas on how to fix this? -- Dimi.

2 7

Conformance tests failing
by Paul Millar Dec. 20, 2002

Dec. 20, 2002

Hi everyone, The extra support added by Chris in: http://cvs.winehq.com/patch.py?id=6743 doesn't seem be enough for wine to pass all of his new conformance tests added in: http://cvs.winehq.com/patch.py?id=6744 A few of them failed, caused WRT reported: locale.c:164: Test failed 1 of 1 time (100%): [test instance 1] locale.c:164: Test failed: GetTimeFormat: got 6 instead of 8 locale.c:146: Test failed 1 of 1 time (100%): [test instance 1] locale.c:146: Test failed: GetTimeFormat got '08' instead of '8 AM' locale.c:147: Test failed 1 of 1 time (100%): [test instance 1] locale.c:147: Test failed: GetTimeFormat: got 3 instead of 5 locale.c:163: Test failed 1 of 1 time (100%): [test instance 1] locale.c:163: Test failed: GetTimeFormat got '08:56' instead of '8:56 AM' for 95, 98, me, NT, Win2k, ... (the database is still updating at the moment) Details of the build are available at: http://www.astro.gla.ac.uk/users/paulm/WRT/buildinfo.php?id=271 ---- Paul Millar

1 0

I need help debugging COM
by Mehmet YASAR Dec. 20, 2002

Dec. 20, 2002

Hi, I'm working on enhancing Wine's Ddraw surface code. I have not enough experience of COM (and very small knowledge asm) to understand why I have a crash on the following line in my test app test.exe : lpov->Lock(NULL, &SurfaceDesc, DDLOCK_WAIT, NULL); Here is more info on the crash : Wine-dbg>c First chance exception: page fault on read access to 0x00000064 in 32-bit code (0x00401a7b). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:008f GS:0007 EIP:00401a7b ESP:406d28e8 EBP:406d2c68 EFLAGS:00010206( R- 00 I - -P1 ) EAX:403c670c EBX:4086b8bc ECX:403c670c EDX:00000000 ESI:406d2bec EDI:406d2c64 Stack dump: 0x406d28e8 (NTDLL.DLL.memcpy+0x4287b8): 403c670c 00000000 406d2bfc 00000001 0x406d28f8 (NTDLL.DLL.memcpy+0x4287c8): 00000000 00020022 00000000 40098c19 0x406d2908 (NTDLL.DLL.memcpy+0x4287d8): 4086b478 400fa444 406d2934 400be095 0x406d2918 (NTDLL.DLL.memcpy+0x4287e8): 4086b478 00000002 400fa25f 40110360 0x406d2928 (NTDLL.DLL.memcpy+0x4287f8): 4086b8bc 00000000 406d29f0 406d2944 0x406d2938 (NTDLL.DLL.memcpy+0x428808): 408116fc 4086b478 4086b8bc 406d29d8 0x406d2948 (NTDLL.DLL.memcpy+0x428818): 0011: sel=008f base=40110360 limit=00000fff 32-bit rw- Backtrace: =>0 0x00401a7b (test.exe..text+0xa7b in Y:\devel\test.exe) (ebp=406d2c68) 1 0x004028ee (test.exe..text+0x18ee in Y:\devel\test.exe) (ebp=406d2d0c) 2 0x4081a3c3 (WINPROC_wrapper+0x17 in user32.dll.so) (ebp=406d2d30) 3 0x4081a45d (WINPROC_CallWndProc+0x8d(proc=0x402860, hwnd=0x20022, msg=0x708, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=406d2d60) ll.so) (ebp=406d2d60) 4 0x40820e52 (CallWindowProcA+0xb2(func=0x40e80458, hwnd=0x20022, msg=0x708, wParam=0x0, lParam=0x0) [winproc.c:2789] in user32.dll.so) (ebp=406d2d94) l.so) (ebp=406d2d94) 5 0x40802114 (DispatchMessageA+0x134(msg=0x406d2de8) [message.c:1094] in user32.dll.so) (ebp=406d2dd8) 6 0x00402747 (test.exe..text+0x1747 in Y:\devel\test.exe) (ebp=406d2e04) 7 0x00402fe5 (test.exe.EntryPoint+0xce in Y:\devel\test.exe) (ebp=406d2e90) 8 0x400b92bf (start_process+0x24f [process.c:564] in libntdll.dll.so) (ebp=406d2f38) 9 0x400bda27 (call_on_thread_stack+0x27(func=0x400b9070) [sysdeps.c:112] in libntdll.dll.so) (ebp=406d2ff4) 10 0x400bdbe0 (SYSDEPS_CallOnStack+0x14 in libntdll.dll.so) (ebp=00000000) 0x00401a7b (test.exe..text+0xa7b in Y:\devel\test.exe): call *0x64(%edx) Wine-dbg>disas 0x00401a7b (test.exe..text+0xa7b in Y:\devel\test.exe): call *0x64(%edx) 0x00401a7e (test.exe..text+0xa7e in Y:\devel\test.exe): movl %eax,0xffffff5c(%ebp) 0x00401a84 (test.exe..text+0xa84 in Y:\devel\test.exe): movl 0xffffff5c(%ebp),%ecx 0x00401a8a (test.exe..text+0xa8a in Y:\devel\test.exe): pushl %ecx 0x00401a8b (test.exe..text+0xa8b in Y:\devel\test.exe): pushl $0x40a164 0x00401a90 (test.exe..text+0xa90 in Y:\devel\test.exe): pushl $0x1 0x00401a92 (test.exe..text+0xa92 in Y:\devel\test.exe): call 0x00402510 (test.exe..text+0x1510 in Y:\devel\test.exe) 0x00401a97 (test.exe..text+0xa97 in Y:\devel\test.exe): addl $12,%esp 0x00401a9a (test.exe..text+0xa9a in Y:\devel\test.exe): cmpl $0x88760104,0xffffff5c(%ebp) 0x00401aa4 (test.exe..text+0xaa4 in Y:\devel\test.exe): jz 0x00401ab2 (test.exe..text+0xab2 in Y:\devel\test.exe) I have certainly introduced bugs in ddraw code, but where should I look ? Mehmet

2 1

Re: HELP: DEVMODE def
by Dan Kegel Dec. 20, 2002

Dec. 20, 2002

> On December 19, 2002 03:20 pm, Ove Kaaven wrote: >> union { >> struct { >> short dmOrientation; >> short dmPaperSize; >> short dmPaperLength; >> short dmPaperWidth; >> }; >> POINTL dmPosition; >> }; > > This is a problem, because it seems we don't have nameless structs > in g++, and I have no idea how to solve this. gcc3.2 has them. I just verified that a fragment like that compiles fine with g++3.2. Red Hat 8.0, Suse 8.1, and Mandrake 9.0 have already standardized on gcc3.2. Debian supports gcc3.2 only in their 'testing' distribution, but historically, a lot of people switch to 'testing' when they need new stuff. I have a feeling enough distributions have updated to gcc3.2 that it might be ok to start depending on it. - Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

2 1

Re: strcasecmp
by Francois Gouget Dec. 20, 2002

Dec. 20, 2002

On Wed, 18 Dec 2002, Dimitrie O. Paun wrote: > > We don't have a _strcasecmp in msvcrt, but wew do have a _stricmp, > which seems to be doing the same thing. > > ChangeLog > Map strcasecmp to _stricmp. Actually I don't see strcasecmp defined anywhere on Windows, which is a bit strange. Should we remove it? Which application uses it? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ If it stinks, it's chemistry. If it moves, it's biology. If it does not work, It's computer science.

5 8

Re: RECT def
by Dimitrie O. Paun Dec. 20, 2002

Dec. 20, 2002

On December 19, 2002 02:35 pm, Dimitrie O. Paun wrote: > ChangeLog > MS uses LONG for the members of RECT. Of course, this causes a sh*tload of warnings. This may be a good time to convert most of these to the debugrect function that I used in listview.c. Sounds like a plan? -- Dimi.

2 1

About WineLib : there is a lack of API in wine
by Kevin Dec. 20, 2002

Dec. 20, 2002

hi ::) I have an appliction of Windows. In the appliction i call createRemoteThread 、SetDCPenColor and setDCBrushcolor，but wine don't support those API functions ,if there has the related function in wine?? Thanks kevin wine-devel(a)winehq.com ----- Original Message ----- From: <wine-devel-request(a)winehq.com> To: <wine-devel(a)winehq.com> Sent: Friday, December 20, 2002 2:00 AM Subject: wine-devel digest, Vol 1 #1519 - 5 msgs > Send wine-devel mailing list submissions to > wine-devel(a)winehq.com > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.winehq.com/mailman/listinfo/wine-devel > or, via email, send a message with subject or body 'help' to > wine-devel-request(a)winehq.com > > You can reach the person managing the list at > wine-devel-admin(a)winehq.com > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of wine-devel digest..." > > > Today's Topics: > > 1. Re: [D3D8 PATCH] d3d8 shaders update - VS2 (David Laight) > 2. Re: [D3D8 PATCH] d3d8 shaders update - VS2 (Zsolt Rizsanyi) > 3. RE: Win2000 Conformance Test Results... (Kye Lewis) > 4. Re: strcasecmp (Dimitrie O. Paun) > 5. Re: Update to patches sgml (Tony Lambregts) > > --__--__-- > > Message: 1 > Date: Thu, 19 Dec 2002 14:54:21 +0000 > From: David Laight <david(a)l8s.co.uk> > To: "Dimitrie O. Paun" <dpaun(a)rogers.com> > Cc: Fabian Cenedese <Cenedese(a)indel.ch>, wine-devel(a)winehq.com > Subject: Re: [D3D8 PATCH] d3d8 shaders update - VS2 > > On Thu, Dec 19, 2002 at 07:08:40AM -0500, Dimitrie O. Paun wrote: > > On December 19, 2002 05:29 am, David Laight wrote: > > > No, and I would use it if I did :-) > ^^^ > not > > Finger trouble... > > > http://www.vim.org > > Probably... > > > David > > -- > David Laight: david(a)l8s.co.uk > > --__--__-- > > Message: 2 > From: Zsolt Rizsanyi <rizsanyi(a)myrealbox.com> > To: Fabian Cenedese <Cenedese(a)indel.ch>, wine-devel(a)winehq.com > Subject: Re: [D3D8 PATCH] d3d8 shaders update - VS2 > Date: Thu, 19 Dec 2002 16:06:51 +0100 > > On Thursday 19 December 2002 14:27, Fabian Cenedese wrote: > > Considering the age of these two it's maybe understandable why they > > don't have this feature. Tell me an editor in Windows and I may switch. > > There is windows version of Vim. Try that :) > > > --__--__-- > > Message: 3 > From: "Kye Lewis" <kyethespy(a)softhome.net> > To: "'Francois Gouget'" <fgouget(a)free.fr> > Cc: wine-devel(a)winehq.org > Subject: RE: Win2000 Conformance Test Results... > Date: Thu, 19 Dec 2002 16:30:59 +1100 > > XP Results Round 2: > > ** If a test is not listed here, then it has passed ** > > advapi32_test registry: No Change > > Note: Test now always has 3 failures, > No cases of more failures are apparent. > > kernel32_test process: No Change > > netapi32_test access: No Change > > shell32_test shfileop: No Change > > user32_test sysparams: No Change > > Thanks, > Kye Lewis > LinksOS Project Administrator > LinksOS Web Team Leader > kyethespy(a)softhome.net > (New email address! kyethespy(a)liquid2k.com will still work, but please > send all emails now to new email) > > "640k ought to be enough for anyone!" > - Bill Gates > > ================================= > LinksOS: Linking you to the world > http://linksos.cjb.net > http://linksos.sourceforge.net/ > http://linksos.oxygen-x.net/ > Now with Bugzilla and phpBB installed :) > ================================= > > > -----Original Message----- > From: wine-devel-admin(a)winehq.com [mailto:wine-devel-admin(a)winehq.com] > On Behalf Of Francois Gouget > Sent: Friday, December 13, 2002 8:58 AM > To: David Fraser > Cc: Kye Lewis; wine-devel(a)winehq.org > Subject: Re: Win2000 Conformance Test Results... > > > Hmmm, I meant to send this two days ago... > > > On Tue, 10 Dec 2002, David Fraser wrote: > [...] > > for kernel32_test path, I got this additional error (before all the > others) > > I have made tons of fixes to the kernel/path test and it should now work > much better. I just uploaded the new version of the tests compiled from > my sources. One can download them from the usual URL: > > http://fgouget.free.fr/wine/winetests.zip > > > [...] > > >process: 116 tests executed, 0 marked as todo, 4 failures. > > > > > Exactly the same except I have 10 messages interspersed with these, > saying: > > tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. > > Why these extra messages? > > Because this executable invokes itself to test CreateProcess. And each > time it exits it prints statistics about how many tests passed and > failed, although the child processes are not actually performing any > test. So these messages can be ignored. > > > > >h:\wine\wine\dlls\shlwapi\tests\shreg.c:218: Test failed: (6) > > >h:\wine\wine\dlls\shlwapi\tests\shreg.c:219: Test failed: (6,43) > > >h:\wine\wine\dlls\shlwapi\tests\shreg.c:220: Test failed: > (3435973836) > [...] > > Same but I get 0 for all your 3435973836 which is 0xcccccccc. Must be > a > > debug/release build thing - variable not being initialized. > > Should not be the case. The code does: > dwType = -1; > dwRet = SHQueryValueExA( hKey, "Test3", NULL, &dwType, NULL, > &dwSize); > ok( dwType == REG_SZ, "(%lu)" , dwType); > > So we should either get -1 or something that makes sense, not > 0xcccccccc. This needs to be investigated more. > > > > Should we print out some of these results in hex as well to make life > > easier? > > We should print them in just one format, decimal or hex, whichever makes > more sense. > > > > >I will now be concentrating on working out what is wrong with these > > >tests :) > > Yep, I think this is priority number one now. Running the tests on more > platforms would only return pretty much the same list of bugs again and > again. > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > Any sufficiently advanced bug is indistinguishable from a feature. > -- from some indian guy > > > > > > > --__--__-- > > Message: 4 > From: "Dimitrie O. Paun" <dpaun(a)rogers.com> > Reply-To: dpaun(a)rogers.com > Organization: DSSD Software Inc. > To: Waldek Hebisch <hebisch(a)math.uni.wroc.pl>, wine-devel(a)winehq.com > Subject: Re: strcasecmp > Date: Thu, 19 Dec 2002 11:48:23 -0500 > > On December 19, 2002 09:26 am, Waldek Hebisch wrote: > > If we are going to seriously support mingw then we need "mingw headers". > > I am not sure if true mingw headres are different enuugh from normal > > wine and msvcrt headers to warrant extra subdirectory, but logically > > they form a separate set. I suggest to put conditionls (if needed) in > > msvcrt headers corresponding to mingw headers, and make a separate > > subdirectory for mingw headers which emulate Unix headers. > > Right. I haven't looked at the mingw headers, but I assume they are > rather similar to the ones in glibc. If that's the case, we can > reuse those (if you have gcc which you have to anyway if you want to > use the mingwrap stuff): > > [dimi(a)dimi wine.src]$ sed -n 290,296p /usr/lib/gcc-lib/i386-redhat-linux/3.2/include/stddef.h > #ifndef __WCHAR_TYPE__ > #define __WCHAR_TYPE__ int > #endif > #ifndef __cplusplus > typedef __WCHAR_TYPE__ wchar_t; > #endif > #endif > > Which means we can simply -D__WCHAR_TYPE__=unsigned\ short > > But we still can not link. For that, we need to reimplement all wchar_t > using functions, and link those in before the glibc ones. Linking tricks > are not my strenght, anyone know how we can do that? Does it work to > just place a lib with those symbols first in the -l list? > > -- > Dimi. > > > --__--__-- > > Message: 5 > Date: Thu, 19 Dec 2002 10:36:14 -0700 > From: Tony Lambregts <tony_lambregts(a)telusplanet.net> > To: Joerg Mayer <jmayer(a)loplof.de> > CC: "Dimitrie O. Paun" <dpaun(a)rogers.com>, wine-devel(a)winehq.com > Subject: Re: Update to patches sgml > > Joerg Mayer wrote: > > >On Thu, Dec 19, 2002 at 01:10:52AM -0500, Dimitrie O. Paun wrote: > > > > > >>This should read "Patches should be inlined (if you can configure your email > >>client to not wrap lines), or attached as text/plain attachements...." > >> > >> > > > >Maybe you should include a step by step instruction for outlook users > >how to do that. It seems that outlook is the leading misattachment generator, > >so instead of just telling people what NOT to do, maybe you can tell > >people how to do it right. > > > > > > > Well I suppose I could if I had those instructions. However it seems out > of scope for a style section. AFAIK just giving the patch a .txt > extention and attaching will solve the problem for most mailers > including outlook. > > -- > > Tony Lambregts > > > > > > --__--__-- > > _______________________________________________ > wine-devel mailing list - wine-devel(a)winehq.com > http://www.winehq.com/mailman/listinfo/wine-devel > > > End of wine-devel Digest > >

1 0

HELP: DEVMODE def
by Dimitrie O. Paun Dec. 19, 2002

Dec. 19, 2002

Thanks for the help guys, Here is another one: the DEVMODE structure. Ours: typedef struct { BYTE dmDeviceName[CCHDEVICENAME]; WORD dmSpecVersion; WORD dmDriverVersion; WORD dmSize; WORD dmDriverExtra; DWORD dmFields; union { struct { SHORT dmOrientation; SHORT dmPaperSize; SHORT dmPaperLength; SHORT dmPaperWidth; } DUMMYSTRUCTNAME1; POINTL dmPosition; } DUMMYUNIONNAME1; SHORT dmScale; SHORT dmCopies; SHORT dmDefaultSource; SHORT dmPrintQuality; SHORT dmColor; SHORT dmDuplex; SHORT dmYResolution; SHORT dmTTOption; SHORT dmCollate; BYTE dmFormName[CCHFORMNAME]; WORD dmLogPixels; DWORD dmBitsPerPel; DWORD dmPelsWidth; DWORD dmPelsHeight; DWORD dmDisplayFlags; DWORD dmDisplayFrequency; DWORD dmICMMethod; DWORD dmICMIntent; DWORD dmMediaType; DWORD dmDitherType; DWORD dmReserved1; DWORD dmReserved2; DWORD dmPanningWidth; DWORD dmPanningHeight; } DEVMODEA, *PDEVMODEA, *LPDEVMODEA; MinGW: typedef struct _devicemodeA { BYTE dmDeviceName[CCHDEVICENAME]; WORD dmSpecVersion; WORD dmDriverVersion; WORD dmSize; WORD dmDriverExtra; DWORD dmFields; short dmOrientation; short dmPaperSize; short dmPaperLength; short dmPaperWidth; short dmScale; short dmCopies; short dmDefaultSource; short dmPrintQuality; short dmColor; short dmDuplex; short dmYResolution; short dmTTOption; short dmCollate; BYTE dmFormName[CCHFORMNAME]; WORD dmLogPixels; DWORD dmBitsPerPel; DWORD dmPelsWidth; DWORD dmPelsHeight; DWORD dmDisplayFlags; DWORD dmDisplayFrequency; DWORD dmICMMethod; DWORD dmICMIntent; DWORD dmMediaType; DWORD dmDitherType; DWORD dmICCManufacturer; DWORD dmICCModel; } DEVMODEA,*LPDEVMODEA,*PDEVMODEA; -- Dimi.

3 2

Re: Import or ntdll
by Alexandre Julliard Dec. 19, 2002

Dec. 19, 2002

"Jeff Smith" <whydoubt(a)hotmail.com> writes: > Realized that ntdll was not needed in the IMPORTS list. I have tested > this in Linux and have not encountered any problems. It is needed. You don't see a problem on Linux because winebuild adds that import automatically in most cases, but it will break Reactos etc. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: HELP: DEVMODE def
by Jeff Smith Dec. 19, 2002

Dec. 19, 2002

At a glance, for wine's to conform with VC6's: 1.) "SHORT" -> "short" 2.) dmICMMethod and below only if WINVER >= 0x0400 3.) dmPanningWidth and below only if WINVER >= 0x0500 or _WIN32_WINN >= 0x0400 4.) Windows has no DUMMY*NAME*'s -- Jeff S >From: "Dimitrie O. Paun" <dpaun(a)rogers.com> > >Thanks for the help guys, > >Here is another one: the DEVMODE structure. _________________________________________________________________ Add photos to your messages with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail

1 0

Re: another wtypes addition
by Dimitrie O. Paun Dec. 19, 2002

Dec. 19, 2002

On December 19, 2002 02:32 pm, Ove Kaaven wrote: > This is the last of the definition shuffling I had to do before my > (rewind) build tree compiled with a replaced objidl.h. So we should be able to get rid of the include/wine/obj_*.h soon? -- Dimi.

2 1

HELP: RECT definition
by Dimitrie O. Paun Dec. 19, 2002

Dec. 19, 2002

Can someone please check the MS headers for the RECT definition? In our definition, we use INT, while the MinGW people use LONG. Which one is correct? Ours: typedef struct tagRECT { INT left; INT top; INT right; INT bottom; } RECT, *PRECT, *LPRECT; MinGW: typedef struct tagRECT { LONG left; LONG top; LONG right; LONG bottom; } RECT,*PRECT,*LPRECT; -- Dimi.

2 1

Re: Update to patches sgml
by Jeff Smith Dec. 19, 2002

Dec. 19, 2002

Hotmail better get their act together or I will have to go elsewhere. Leading spaces are getting dropped when I inline and even when I attach as a TXT file. The only way it will let all my patches through unharmed is by leaving the extension as DIFF. I have several patches in my queue, but have been reluctant to send them out until I get this resolved. -- Jeff S >From: Tony Lambregts <tony_lambregts(a)telusplanet.net> > >Joerg Mayer wrote: > >>On Thu, Dec 19, 2002 at 01:10:52AM -0500, Dimitrie O. Paun wrote: >> >> >>>This should read "Patches should be inlined (if you can configure your >>>email >>>client to not wrap lines), or attached as text/plain attachements...." >>> >>> >> >>Maybe you should include a step by step instruction for outlook users >>how to do that. It seems that outlook is the leading misattachment >>generator, >>so instead of just telling people what NOT to do, maybe you can tell >>people how to do it right. >> >> >> >Well I suppose I could if I had those instructions. However it seems out of >scope for a style section. AFAIK just giving the patch a .txt extention and >attaching will solve the problem for most mailers including outlook. > >-- > >Tony Lambregts _________________________________________________________________ MSN 8 with e-mail virus protection service: 2 months FREE* http://join.msn.com/?page=features/virus

2 1

Re: Update to patches sgml
by Dimitrie O. Paun Dec. 19, 2002

Dec. 19, 2002

On December 18, 2002 07:10 pm, Tony Lambregts wrote: > In an effort to start a flame war <g> I decided to add a few notes about > style to patches.sgml and while I was at it I added a note about being > able to submit non cvs patches. + Patches should be attached so that they can be read inline. This + may mean some more work for you. However it allows others to review + your patch easily and increase the chances of it not being + overlooked or forgotten. This should read "Patches should be inlined (if you can configure your email client to not wrap lines), or attached as text/plain attachements...." -- Dimi.

3 3

Re: Update to patches sgml
by Dimitrie O. Paun Dec. 19, 2002

Dec. 19, 2002

On December 19, 2002 01:56 am, Tony Lambregts wrote: > Not a bad idea. how's this then. Better. Did you look at this: http://www.winehq.com/hypermail/wine-devel/2002/09/0127.html The rules detailed in there are still valid: -- unified diff only (required) -- have a decent subject (recommended) -- a long description (optional, if the change warrants it) -- a meaningful ChangeLog entry (required) -- new files, if any, included in patch, diffed against /dev/null (required) -- patch inlined at the end of the message (recommended) -- one changeset per message What about including them in point-form for clarity, with some rationale (as you did) for things like patch inlining, etc. Idea being that one shouldn't have read the entire story if he/she only wants to see the rules. The story is good for first timers that want to understand why we have these rules/recommendations, so we can easily point them to them instead of having to answer it in long email every time... :) -- Dimi.

2 1

Re: [D3D8 PATCH] d3d8 shaders update - VS2
by Jeff Smith Dec. 19, 2002

Dec. 19, 2002

Yes, the version of vim that came with (I believe) Red Hat 6.0 has the definitions in its syntax file for proper "#if 0" highlighting. As common a practice as this has become, any syntax-highlighting editor with some degree of maturity that did *not* have this in its default rulesets for C/C++ would surprise me. What language-independent, syntax-highlighting text editor are you using? -- Jeff S >From: Fabian Cenedese <Cenedese(a)indel.ch> > >> > >/* note about reason for commenting block */ >> > >#if 0 >> > >code >> > >code /* comments */ >> > >code >> > >#endif >> > >> > Whereas this is the solution with the least work it's also hard to >>spot. If >> > using >> > a text editor with syntax coloring it all looks the same. But if a code >>isn't >> > effective I'd like to see that. >> >>Actually it could be considered as an editor fault if it changes color for >>commented out code but doesn't recognize the #if 0/#endif construct. > >I wouldn't say so. A comment is easily recognized by the chars /* */ or //. >But to get a #if 0 or #if _ANYTHING you really need a language dependant >preprocessor which goes beyond a normal text editor, even one with >syntax coloring. >Do you have such a text editor that finds #if's? > >bye Fabi _________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail

3 2

Re: [D3D8 PATCH] d3d8 shaders update - VS2
by Jeff Smith Dec. 19, 2002

Dec. 19, 2002

The best way I know to create block comments *without* tampering with interior comments is like this: /* note about reason for commenting block */ #if 0 code code /* comments */ code #endif >From: Fabian Cenedese <Cenedese(a)indel.ch> > >> > >- object->functionLength = 1; /* no Function defined use fixed >> > > function vertex processing */ + object->functionLength = 1; // >>no >> > > Function defined use fixed function vertex processing >> > >> > <nitpick> C++ style comments are strongly discouraged </nitpick> >> >>yes, i know but this comment is INTO a block comment ;) >>and C comments will break the block comment > >What I usually do in such a case is change the existing tags like that: > >code /* comment */ > >becomes (note the spaces in the tags). > >/* block comment >code / * comment * / >*/ > >Like that you still see where the comment was but it doesn't end the block >anymore. Of course if the block comment gets removed you have to change >the tags back. > >bye Fabi _________________________________________________________________ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail

6 7

How long does it take *you* to build wine?
by Dan Kegel Dec. 19, 2002

Dec. 19, 2002

I got tired of waiting for wine to build, and started looking for ways to speed it up. I have three systems handy: a dual 650MHz PIII, a 750MHz PIII laptop, and a 1.1 GHz Celeron with shared memory video (i.e. dog slow). To see if a parallel compile would help, I installed Red Hat 8.0 on all systems, and installed the RPM for distcc from http://distcc.samba.org. I then timed how long it took to do a 'make' after 'make clean' in a recent copy of the wine tree. It does look like distributing the load helps a tiny bit, but it's not clear it's a big win over just building on the dual 650MHz machine. The fastest build I've seen so far is 19 minutes. I'm pretty sure I'm not doing things optimally yet. So how long does it take *you* to do a clean build (just the 'make' part after 'make depend', say) of Wine-20021125? - Dan p.s. No fair using ccache! That's the next tool I want to investigate; it's probably the biggest win of all, at least for regression testing.

9 11