December 2002 - Wine-Devel - list.winehq.org

Re: Listview report mode tweaks #2
by Dimitrie O. Paun Dec. 20, 2002

Dec. 20, 2002

On December 20, 2002 01:02 pm, Duane Clark wrote: > So the only fix to LISTVIEW_GetSubItemRect that remains is to change the > offset that is applied. This looks great. Another small nit: + if (!(uFormat & (DT_RIGHT | DT_CENTER))) + { + if (himl && lvItem.iImage >= 0 && !IsRectEmpty(&rcIcon)) rcLabel.left += 2; + else rcLabel.left += 5; + } + else if (uFormat & DT_RIGHT) rcLabel.right -= 5; It seems this "5" is the same, so maybe a symbolic constant would be better. Also, it seems the 2 has to do with IMAGE_PADDING which you changed to 0, so maybe a small rearangement can make this thing more clear. What I mean is that you disabled image padding, and you achive it some other way using explicit numbers (2, 5, etc). Turning the logic inside out, maybe we can give meaning back to IMAGE_PADDING. If not, we should remove it and introduce another meaningful constant. -- Dimi.

1 0

Re: rpcdce.h fixes
by Ove Kaaven Dec. 20, 2002

Dec. 20, 2002

On Fri, 20 Dec 2002, Dimitrie O. Paun wrote: > MinGW has them defined this way, and wxWindows likes them like this. > Can someone please check that this matches the Windows headers? It does, but it was more difficult to get things (rpcrt4 in particular) to compile without warnings (or huge piles of typecasts) this way, so I decided to just use LPSTR/LPWSTR instead in the rpc headers. Didn't think it would cause problems. > RPCRTAPI RPC_STATUS RPC_ENTRY > - RpcStringFreeA(LPSTR* String); > + RpcStringFreeA(unsigned char** String); > RPCRTAPI RPC_STATUS RPC_ENTRY > - RpcStringFreeW(LPWSTR* String); > + RpcStringFreeW(unsigned short** String); > #define RpcStringFree WINELIB_NAME_AW(RpcStringFree)

3 3

ThunkTheTemplateHandle and Kazaa
by Ender Dec. 20, 2002

Dec. 20, 2002

Hi all. Trying to run any recent version of Kazaa (Lite) under WINE fails for me, as it trys to call an unimplemented krnl386.exe stub... ordinal 538 (ThunkTheTemplateHandle). After doing a little minimal debugging, all I could see that ordinal doing was messing with some segment pointers and calling ordinal 630 (C16ThkSL). I really have no idea what any of this stuff does (*cough*), although copying the line for ordinal 630 into ordinal 538 makes Kazaa work for me :) I don't suppose anybody with a little more knowledge of this bit of Windows knows what actually goes on here? It'd be nice to see this fixed (properly :) in CVS, as Kazaa is a fairly popular application. Cheers, Ender

2 3

Re: Listview report mode tweaks
by Dimitrie O. Paun Dec. 20, 2002

Dec. 20, 2002

On December 19, 2002 07:48 pm, Duane Clark wrote: > I also altered LISTVIEW_GetSubItemRect so that it reports correct > values, as compared against WinNT on ControlSpy. Problem is that LISTVIEW_GetSubItemRect is documented to return same thing for LVIR_LABEL and LVIR_BOUNDS. Of course, incorrect documentation is known to exist, so as long as you checked it... However, when we implement things different from the documented behavior, a clear comment explaining why we deviate is appropriate. Otherwise, someone might get rid of it in the future. :( -- Dimi.

2 1

Wineconsole 'regression'
by Lionel Ulmer Dec. 20, 2002

Dec. 20, 2002

Hi all, Since the introduction of the 'ncurses' driver for the wineconsole program, the only program using the console is completely broken (IDA). Well, it actually starts faster than with the USER back-end but after that it's mostly unusable. I looked at the wineconsole code and it does not seem that there is a configure option or any other mean to have wineconsole act as before (ie to use the slow but working USER driver). So : 1) I did not look long enough 2) I should stop bitching and fix the ncurses driver What irks me is that the debugger is still working as before (ie not very stable, but at least not buggy in an xterm :-) ). Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 2

Re: Conformance tests failing
by chrismorgan＠rcn.com Dec. 20, 2002

Dec. 20, 2002

I'll take a look at it and see what might be up. The tests all passed on my nt4 machine and on my local wine with the ole2nls changes, it should be pretty easy to resolve these issues. Chris > > From: Paul Millar <paulm(a)astro.gla.ac.uk> > Date: 2002/12/20 Fri AM 07:10:27 EST > To: Development to WINE <wine-devel(a)winehq.com> > Subject: Conformance tests failing > > Hi everyone, > > The extra support added by Chris in: > http://cvs.winehq.com/patch.py?id=6743 > doesn't seem be enough for wine to pass all of his new conformance tests > added in: > http://cvs.winehq.com/patch.py?id=6744 > A few of them failed, caused WRT reported: > > locale.c:164: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:164: Test failed: GetTimeFormat: got 6 instead of 8 > > locale.c:146: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:146: Test failed: GetTimeFormat got '08' instead of '8 AM' > > locale.c:147: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:147: Test failed: GetTimeFormat: got 3 instead of 5 > > locale.c:163: Test failed 1 of 1 time (100%): > [test instance 1] > locale.c:163: Test failed: GetTimeFormat got '08:56' instead of '8:56 AM' > > for 95, 98, me, NT, Win2k, ... (the database is still updating at the > moment) > > Details of the build are available at: > http://www.astro.gla.ac.uk/users/paulm/WRT/buildinfo.php?id=271 > > ---- > Paul Millar > > > > >

1 0

IE5.5 and 6.0sp1 error [Unimplimented]
by Boris Dec. 20, 2002

Dec. 20, 2002

I just downloaded the latest cvs on a system without windows files. I tried to install IE5.5 and IE 6.0sp1 as win2k or winxp and as it tries to install, the following error occurs Unimplimented Kernel32.dll.VerSetConditionMask in 32bit mode. Anyone looking to write an update to kernel32.dll to add the function?

2 1

Include_winsock_h_before_stdlib_h_or_use_the_MSVCRT_library
by Dimitrie O. Paun Dec. 20, 2002

Dec. 20, 2002

Folks, This does not work (<= is include): winsock.h <= sys/types.h <= sys/select.h BANG! FD_CLR gets defined before we have a chance to manipulate it. Any ideas on how to fix this? -- Dimi.

2 7

Conformance tests failing
by Paul Millar Dec. 20, 2002

Dec. 20, 2002

Hi everyone, The extra support added by Chris in: http://cvs.winehq.com/patch.py?id=6743 doesn't seem be enough for wine to pass all of his new conformance tests added in: http://cvs.winehq.com/patch.py?id=6744 A few of them failed, caused WRT reported: locale.c:164: Test failed 1 of 1 time (100%): [test instance 1] locale.c:164: Test failed: GetTimeFormat: got 6 instead of 8 locale.c:146: Test failed 1 of 1 time (100%): [test instance 1] locale.c:146: Test failed: GetTimeFormat got '08' instead of '8 AM' locale.c:147: Test failed 1 of 1 time (100%): [test instance 1] locale.c:147: Test failed: GetTimeFormat: got 3 instead of 5 locale.c:163: Test failed 1 of 1 time (100%): [test instance 1] locale.c:163: Test failed: GetTimeFormat got '08:56' instead of '8:56 AM' for 95, 98, me, NT, Win2k, ... (the database is still updating at the moment) Details of the build are available at: http://www.astro.gla.ac.uk/users/paulm/WRT/buildinfo.php?id=271 ---- Paul Millar

1 0

I need help debugging COM
by Mehmet YASAR Dec. 20, 2002

Dec. 20, 2002

Hi, I'm working on enhancing Wine's Ddraw surface code. I have not enough experience of COM (and very small knowledge asm) to understand why I have a crash on the following line in my test app test.exe : lpov->Lock(NULL, &SurfaceDesc, DDLOCK_WAIT, NULL); Here is more info on the crash : Wine-dbg>c First chance exception: page fault on read access to 0x00000064 in 32-bit code (0x00401a7b). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:008f GS:0007 EIP:00401a7b ESP:406d28e8 EBP:406d2c68 EFLAGS:00010206( R- 00 I - -P1 ) EAX:403c670c EBX:4086b8bc ECX:403c670c EDX:00000000 ESI:406d2bec EDI:406d2c64 Stack dump: 0x406d28e8 (NTDLL.DLL.memcpy+0x4287b8): 403c670c 00000000 406d2bfc 00000001 0x406d28f8 (NTDLL.DLL.memcpy+0x4287c8): 00000000 00020022 00000000 40098c19 0x406d2908 (NTDLL.DLL.memcpy+0x4287d8): 4086b478 400fa444 406d2934 400be095 0x406d2918 (NTDLL.DLL.memcpy+0x4287e8): 4086b478 00000002 400fa25f 40110360 0x406d2928 (NTDLL.DLL.memcpy+0x4287f8): 4086b8bc 00000000 406d29f0 406d2944 0x406d2938 (NTDLL.DLL.memcpy+0x428808): 408116fc 4086b478 4086b8bc 406d29d8 0x406d2948 (NTDLL.DLL.memcpy+0x428818): 0011: sel=008f base=40110360 limit=00000fff 32-bit rw- Backtrace: =>0 0x00401a7b (test.exe..text+0xa7b in Y:\devel\test.exe) (ebp=406d2c68) 1 0x004028ee (test.exe..text+0x18ee in Y:\devel\test.exe) (ebp=406d2d0c) 2 0x4081a3c3 (WINPROC_wrapper+0x17 in user32.dll.so) (ebp=406d2d30) 3 0x4081a45d (WINPROC_CallWndProc+0x8d(proc=0x402860, hwnd=0x20022, msg=0x708, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=406d2d60) ll.so) (ebp=406d2d60) 4 0x40820e52 (CallWindowProcA+0xb2(func=0x40e80458, hwnd=0x20022, msg=0x708, wParam=0x0, lParam=0x0) [winproc.c:2789] in user32.dll.so) (ebp=406d2d94) l.so) (ebp=406d2d94) 5 0x40802114 (DispatchMessageA+0x134(msg=0x406d2de8) [message.c:1094] in user32.dll.so) (ebp=406d2dd8) 6 0x00402747 (test.exe..text+0x1747 in Y:\devel\test.exe) (ebp=406d2e04) 7 0x00402fe5 (test.exe.EntryPoint+0xce in Y:\devel\test.exe) (ebp=406d2e90) 8 0x400b92bf (start_process+0x24f [process.c:564] in libntdll.dll.so) (ebp=406d2f38) 9 0x400bda27 (call_on_thread_stack+0x27(func=0x400b9070) [sysdeps.c:112] in libntdll.dll.so) (ebp=406d2ff4) 10 0x400bdbe0 (SYSDEPS_CallOnStack+0x14 in libntdll.dll.so) (ebp=00000000) 0x00401a7b (test.exe..text+0xa7b in Y:\devel\test.exe): call *0x64(%edx) Wine-dbg>disas 0x00401a7b (test.exe..text+0xa7b in Y:\devel\test.exe): call *0x64(%edx) 0x00401a7e (test.exe..text+0xa7e in Y:\devel\test.exe): movl %eax,0xffffff5c(%ebp) 0x00401a84 (test.exe..text+0xa84 in Y:\devel\test.exe): movl 0xffffff5c(%ebp),%ecx 0x00401a8a (test.exe..text+0xa8a in Y:\devel\test.exe): pushl %ecx 0x00401a8b (test.exe..text+0xa8b in Y:\devel\test.exe): pushl $0x40a164 0x00401a90 (test.exe..text+0xa90 in Y:\devel\test.exe): pushl $0x1 0x00401a92 (test.exe..text+0xa92 in Y:\devel\test.exe): call 0x00402510 (test.exe..text+0x1510 in Y:\devel\test.exe) 0x00401a97 (test.exe..text+0xa97 in Y:\devel\test.exe): addl $12,%esp 0x00401a9a (test.exe..text+0xa9a in Y:\devel\test.exe): cmpl $0x88760104,0xffffff5c(%ebp) 0x00401aa4 (test.exe..text+0xaa4 in Y:\devel\test.exe): jz 0x00401ab2 (test.exe..text+0xab2 in Y:\devel\test.exe) I have certainly introduced bugs in ddraw code, but where should I look ? Mehmet

2 1