December 2002 - Wine-Devel - list.winehq.org

Re: strcat+strcat+strcat == baaad"
by vkxzjq6lg＠cswebmail.com Dec. 10, 2002

Dec. 10, 2002

Francois Gouget wrote: > Of course, that implies that we should promptly fix any such crash. > Otherwise it just makes Wine unusable without any benefit. That's the catch. I'm not approaching Wine as a Wine developer. Wine is almost ready for prime time now and as a non-Wine developer (who's roped in so far only as far as necessary to get the app I want to run running) I'm approaching it as a near production system. When only hard core Wine developers were seeing it, opening the debugger made sense. Wine is leaving the core development stage and now it's time to be arranging for bug reporting mechanisms which don't require that you be a programmer willing to start debugging Wine to get your applications running. That means avoiding a raw debugger window and providing something more end user friendly. To me that means something like logging every non-dangerous failure possible rather than killing the application. Then, when the application finishes, winseerver can pop up a polite window telling the user that there was a problem and asking them to report it to the developers, making it easy to do that. It definitely doesn't involve opening debugger windows. Those will scare away the end users who need to be submitting those logs so the developers can see which app or internal routine was breaking the rules and what needs to be fixed. So: Wine's almost there (and congratulations on getting to the point where I can seriously write that!). Time to be thinking about what end users can handle and changing how garbage data reporting is handled to make it more friendly to them. ___________________________________________________ The ALL NEW CS2000 from CompuServe Better! Faster! More Powerful! 250 FREE hours! Sign-on Now! http://www.compuserve.com/trycsrv/cs2000/webmail/

2 1

DOSMEM_Init VirtualProtect fails
by vkxzjq6lg＠cswebmail.com Dec. 10, 2002

Dec. 10, 2002

To further my porting work, I've patched my copy of DOSMEM.C like this: else if (dos_init && !already_mapped) { if (DOSMEM_dosmem) { ERR( "Needs access to the first megabyte for DOS mode\n" ); ExitProcess(1); } MESSAGE( "Warning: unprotecting the first 64KB of memory to allow real-mode calls.\n" " NULL pointer accesses will no longer be caught.\n" ); /* James Day added the if/FIXME/return false around this VirtualProtect because OzWin on my AMD K6-3 gave this result: wine --debugmsg +dosmem ozwin2 fixme:toolhelp:InterruptRegister16 (0000, 0x26f00ba), stub. Warning: unprotecting the first 64KB of memory to allow real-mode calls. NULL pointer accesses will no longer be caught. fixme:dosmem:DOSMEM_Init Failed to unprotect first 64KB of memory. init=1, done=1, mapped=0 fixme:toolhelp:InterruptUnRegister16 (0000), stub. */ if ( ! VirtualProtect( NULL, 0x10000, PAGE_EXECUTE_READWRITE, NULL ) ) { FIXME("Failed to unprotect first 64KB of memory. init=%d, done=%d, mapped=%d\n", (int)dos_init, already_done, already_mapped); return FALSE; } /* copy the BIOS and ISR area down */ memcpy( DOSMEM_dosmem, DOSMEM_sysmem, 0x400 + 0x100 ); NtProtectVirtualMemory is returning STATUS_INVALID_PARAMETER to VirtualProtectEx and DOSMEM_Init wasn't handling this failure gracefully - the memcpy was tripping the debugger and falling flat, taking the application with it. Anyone got any better ideas? Want more information on what's happening, like which of the STATUS_INVALID_PARAMETER cases is happening? Lindows 3.0 OS (Debian plus bits), Wine 20021125 compiled here with only this change. Not running as root. 128MB of RAM. ___________________________________________________ The ALL NEW CS2000 from CompuServe Better! Faster! More Powerful! 250 FREE hours! Sign-on Now! http://www.compuserve.com/trycsrv/cs2000/webmail/

1 0

How to find out if file is loaded?
by Klaus Niederkrueger Dec. 9, 2002

Dec. 9, 2002

Hello, I would like to know the following: I start some program with "wine -debugmsg +file" and I get quite a lot of times trace:file:CreateFileW L"tiles\\TS01.bmp" GENERIC_READ FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x80 trace:file:CreateFileW returning 0x58 trace:file:_lopen ('tiles\TS01.BMP',0000) trace:file:CreateFileW L"tiles\\TS01.BMP" GENERIC_READ FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 trace:file:CreateFileW returning 0x58 trace:file:ReadFile 0x58 0x406d2690 14 0x406d264c (nil) trace:file:ReadFile 0x58 0x406d2668 40 0x406d264c (nil) trace:file:ReadFile 0x58 0x406d26a4 1024 0x406d264c (nil) trace:file:_lclose handle 88 So it seems to me that the file tiles\TS01.BMP is loaded, but when I use "ltrace wine ..." I don't find any output regarding this file. Why is that? Thanks for any answer Klaus

2 2

Re: strcat+strcat+strcat == baaad
by Morten Welinder Dec. 9, 2002

Dec. 9, 2002

Unless we're talking an inner and very intensive loop, all this is a bit silly. However, assuming that it does make sense, sprintf variants are not part of the answer. They're interpreted and var-arg type, both of which are little good for efficiency. More like something along these lines: char *tmpdst = dst; strcpy (tmpdst, src1); tmpdst += strlen (src1); strcpy (tmpdst, src2); tmpdst += strlen (src2); strcpy (tmpdst, src3); tmpdst += strlen (src3); ... strcpy (tmpdst, srcN); tmpdst += strlen (srcN); ... This works even better when the strlen calls have known results. Of course, nothing keeps the compiler from noticing a certain pattern of sprintf calls can producing an equaivalent of the above, but right now gcc will not do that if I recall correctly. Morten

2 1

Non latin fonts and non local fonts
by Shachar Shemesh Dec. 9, 2002

Dec. 9, 2002

Hi list, http://bugs.winehq.com/show_bug.cgi?id=1157 It appears that when I'm copying the Windows fonts to C:\windows\Fonts, setting LANG to he_IL is all it takes for Hebrew to be displayed in edit controls and dialog boxes. When I try to copy the exact same fonts to /usr/lib/X11/fonts/windows, and adding them to the XF86Config fonts dir, and running ttmkfdir, no go. The fonts are available to Wine (and each is enumerated multiple times in the fonts dialog), but Hebrew is not displayed by default. Sometimes, when I force the CHARSET to HEBREW_CHARSET, I get Hebrew after all, but I'm not at all sure the same font is used then. In addition to this problem, I was wondering why we no longer enumerate the X fonts the moment there is ONE font file in c:\windows\Fonts? Is there a reason for them to magically disappear? Shachar

2 1

Re: strcat+strcat+strcat == baaad
by Alexandre Julliard Dec. 9, 2002

Dec. 9, 2002

Francois Gouget <fgouget(a)free.fr> writes: > I don't like pieces of code that go: > > strcpy(foo, bar1); > strcat(foo, bar2); > strcat(foo, bar3); > strcat(foo, bar4); > strcat(foo, bar5); > strcat(foo, bar6); > > It's really inefficient: the cost increases quadratically with the size > of the resulting string. Well, no, the cost is linear. It would only be quadratic if the number of strcat calls depended on the length of the string. > It's more efficient to do: > > sprintf(foo, "%s%s%s%s%s%s", bar1,bar2,bar3,bar4,bar5,bar6); I seriously doubt that sprintf would be faster that a couple of strcats. And I don't think we need to worry about this kind of micro-optimizations right now... -- Alexandre Julliard julliard(a)winehq.com

10 26

Wine startup problem
by Leonardo Giordani Dec. 9, 2002

Dec. 9, 2002

I'm using CVS Wine 20021125, but I cannot start any application: what I gete is always -bash-2.05b$ wine War3.exe Loading required GL library /usr/X11R6/lib/libGL.so.1.2 err:ntdll:RtlpWaitForCriticalSection section 0x4010ad10 "../../loader/module.c: loader_section" wait timed out, retrying (60 sec) tid=09545090 It hangs and does nothing. What's the matter? Thank you ------------ Leonardo Giordani leo.giordani(a)libero.it

3 3

Disassembly of the adobe svg plugin
by Mike Hearn Dec. 9, 2002

Dec. 9, 2002

Well, I have about 2 hours now when I can work on trying to get the adobe svg plugin to work in Wine. I have a deadline to meet for Friday that requires the plugin, so if I can't get it working back to Windows it is (it's like a damn magnet). I've already located a mouse bug (problem with my last patch, oops) and fixed it (patch sent), but the lack of render on paint problem still eludes me. Having not got a response to the last email, I'll assume it's OK to try poking about inside the plugin itself to figure out what's going wrong. If anybody has some tips, now would be the time to tell me about them :) I hope this doesn't invalidate any patches I might produce..... -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

4 6

Turkish keyboard Support
by Armish Dec. 9, 2002

Dec. 9, 2002

Hi all, I tried the latest wine (Wine-20021125.tar.gz) and saw that though it supports the Turkish Keyboard Layout, I cannot write the specail chars of Turkish (Like ı ş ğ � � � ...) Then I found a (Turkish) keyboard.c but still don't know where or how to it? (The keyboard.c is working well with my kernel) What can I do? (The keyboard.c is in the attach. for someone who want to check) Thanks __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

2 1

Re: Turkish keyboard Support
by Jeff Smith Dec. 9, 2002

Dec. 9, 2002

Was this working under Wine-20021031? I have been trying to figure out a similar problem with the Spanish keyboard layout. If this caused a regression for you as well, it means I have been looking at the wrong problem. If you could test with the 20021031 version and compare results, that could be very helpful. -- Jeff S >From: Armish <acemimsi(a)yahoo.com> > >Hi all, >I tried the latest wine (Wine-20021125.tar.gz) and saw >that though it supports the Turkish Keyboard Layout, I >cannot write the specail chars of Turkish (Like ý >þ ð ü ç ö ...) >Then I found a (Turkish) keyboard.c but still don't >know where or how to it? (The keyboard.c is working >well with my kernel) What can I do? >(The keyboard.c is in the attach. for someone who want >to check) >Thanks _________________________________________________________________ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail

1 0