December 2002 - Wine-Devel - list.winehq.org

Re: PathCreateFromUrlW
by Dimitrie O. Paun Dec. 31, 2002

Dec. 31, 2002

On December 31, 2002 02:06 pm, Matthew Mastracci wrote: > Sorry, here's the unified diff. Thanks! However, please generate the diff relative to wine's root, as I suggested: cvs diff -u dlls/shlwapi/path.c What you did is this: cd dlls/shlwapi; cvs diff -u path.c which just makes things harder for Alexandre when applying the patch. -- Dimi.

2 1

PathCreateFromUrlW
by Matthew Mastracci Dec. 31, 2002

Dec. 31, 2002

Here's an implementation of PathCreateFromUrlW that helps Kazaa crash later rather than sooner. :) Can someone review this and check it in (if it doesn't require any fixes)? Index: path.c =================================================================== RCS file: /home/wine/wine/dlls/shlwapi/path.c,v retrieving revision 1.27 diff -r1.27 path.c 3157c3157,3159 < FIXME("(%s,%p,%p,0x%08lx)-stub\n", debugstr_w(lpszUrl), lpszPath, pcchPath, dwFlags); --- > static const WCHAR stemp[] = { 'f','i','l','e',':','/','/',0 }; > LPWSTR pwszPathPart; > TRACE("(%s,%p,%p,0x%08lx)\n", debugstr_w(lpszUrl), lpszPath, pcchPath, dwFlags); 3162c3164,3189 < return S_OK; --- > // Path of the form file://... > if (!strncmpW(lpszUrl, stemp, 7)) > { > lpszUrl += 7; > } > // Path of the form file:... > else if (!strncmpW(lpszUrl, stemp, 5)) > { > lpszUrl += 5; > } > > // Ensure that path is of the form c:... or c|... > if (lpszUrl[1] != ':' && lpszUrl[1] != '|' && isalphaW(*lpszUrl)) > return E_INVALIDARG; > > HRESULT hr = UrlUnescapeW(lpszUrl, lpszPath, pcchPath, dwFlags); > if (lpszPath[1] == '|') > lpszPath[1] = ':'; > > for (pwszPathPart = lpszPath; *pwszPathPart; pwszPathPart++) > if (*pwszPathPart == '/') > *pwszPathPart = '\\'; > > TRACE("Returning %s\n",debugstr_w(lpszPath)); > > return hr; -- Matthew Mastracci <matt(a)aclaro.com>

2 1

XP Conformance Test Results: Round 3...
by Kye Lewis Dec. 31, 2002

Dec. 31, 2002

Windows XP Results: Round 3 More tests added. Some Previous tests fail differently.. 1 regression in kernel32:locale as far as I can see... === advapi32_test === registry.c:96: Test failed: value set to 'xxxxxxxxxx' instead of 'Te' registry.c:97: Test failed: data set to 'xxxxxxx' instead of 'foobar' registry.c:111: Test failed: data set to 'xxxxxxx' instead of 'foobar' registry: 56 tests executed, 0 marked as todo, 3 failures. === dsound_test === dsound: 63 tests executed, 0 marked as todo, 0 failures. === gdi32_test === generated: 2786 tests executed, 0 marked as todo, 0 failures. === kernel32_test === alloc: 58 tests executed, 0 marked as todo, 0 failures. atom: 229398 tests executed, 0 marked as todo, 0 failures. codepage: 2 tests executed, 0 marked as todo, 0 failures. directory: 51 tests executed, 0 marked as todo, 0 failures. drive: 156 tests executed, 0 marked as todo, 0 failures. environ: 39 tests executed, 0 marked as todo, 0 failures. file: 487239 tests executed, 0 marked as todo, 0 failures. format_msg: 58 tests executed, 0 marked as todo, 0 failures. generated: 609 tests executed, 0 marked as todo, 0 failures. locale.c:154: Test failed: GetTimeFormat got '' instead of '4' locale.c:155: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:181: Test failed: GetTimeFormat got '8.@:56AM' instead of '8.@:56.@:AM' locale.c:182: Test failed: GetTimeFormat: got 9 instead of 12 locale.c:190: Test failed: GetTimeFormat got '' instead of '3' locale.c:191: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:474: Test failed: GetDateFormat got '5/4/2002' instead of '5/4/02' locale.c:475: Test failed: GetDateFormat: got 9 instead of 7 locale.c:499: Test failed: GetDateFormat check DATE_YEARMONTH with null format expected ERROR_INVALID_FLAGS got return of '10' and error of '0' locale.c:530: Test failed: GetDateFormatW allowed flags and format locale.c:539: Test failed: GetDateFormatW did not permit null buffer pointer when counting. locale: 109 tests executed, 0 marked as todo, 11 failures. path: 1730 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. (identical lines removed.) tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. process.c:378: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\DOCUME~1\Owner\DESKTOP\WINETE~1\kernel32_test.exe process.c:530: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\DOCUME~1\Owner\DESKTOP\WINETE~1\kernel32_test.exe process: 116 tests executed, 0 marked as todo, 2 failures. thread: 112 tests executed, 0 marked as todo, 0 failures. file: 2 tests executed, 0 marked as todo, 0 failures. === msvcrt_test === scanf: 8 tests executed, 0 marked as todo, 0 failures. === netapi32_test === access.c:110: Test failed: Bad Network Path: rc=0 access: 23 tests executed, 0 marked as todo, 1 failure. apibuf: 15 tests executed, 0 marked as todo, 0 failures. wksta: 14 tests executed, 0 marked as todo, 0 failures. === ntdll_test === error: 813 tests executed, 0 marked as todo, 0 failures. rtlbitmap: 224 tests executed, 0 marked as todo, 0 failures. rtlstr: 38 tests executed, 0 marked as todo, 0 failures. === oleaut32_test === safearray.c:131: Test failed: SAC(20,1,[1,0]), result 8, expected 0 safearray.c:131: Test failed: SAC(21,1,[1,0]), result 8, expected 0 safearray.c:131: Test failed: SAC(37,1,[1,0]), result 4, expected 0 safearray.c:131: Test failed: SAC(38,1,[1,0]), result 4, expected 0 safearray: 348 tests executed, 0 marked as todo, 4 failures. ======== Testing VarUI1FromXXX ======== vartest.c:1713:VarUI1FromI2: passing in NULL as return val makes it crash, need to write proper test. vartest.c:1797: ======== Testing VarUI2FromXXX ======== vartest.c:1802:VarUI2FromI2: passing in NULL as return val makes it crash, needs to be fixed. vartest.c:1873: ======== Testing VarUI4FromXXX ======== vartest.c:1876:VarUI4FromI2: passing in NULL as return val makes it crash, implement me. vartest.c:1951: ======== Testing VarI1FromXXX ======== vartest.c:2004: ======== Testing VarI2FromXXX ======== vartest.c:2047: ======== Testing VarI4FromXXX ======== vartest.c:2091: ======== Testing VarR4FromXXX ======== vartest.c:2138: ======== Testing VarR8FromXXX ======== vartest.c:2158: ======== Testing VarDateFromXXX ======== vartest.c:2208: Test failed: VarDateFromStr([7]="0.49") got 0.0340278 instead of 0.034028 vartest.c:2208: Test failed: VarDateFromStr([8]="0.5") got 0.00347222 instead of 0.003472 vartest.c:2208: Test failed: VarDateFromStr([9]="0.51") got 0.0354167 instead of 0.035417 vartest.c:2208: Test failed: VarDateFromStr([34]=" 1 2 ") got 37258 instead of 35797 vartest.c:2208: Test failed: VarDateFromStr([39]="1.2.3") got 0.0430903 instead of 0.04309 vartest.c:2208: Test failed: VarDateFromStr([69]=" 1999/ 11/21 11 :11:11am") got 36485.5 instead of 36485.5 vartest.c:2208: Test failed: VarDateFromStr([70]="11/11/1999 11:11:11Am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([71]="11/11/1999 11:11:11PM") got 36476 instead of 36476 vartest.c:2208: Test failed: VarDateFromStr([73]="11/11/1999 0:0:11am") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([75]="11/11/1999 11:11:11am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([77]="11/11/1999 11:11AM") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([78]="11/11/1999 1AM") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([80]="11/11/1999 11:11:11") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([89]="1 January 1999 11AM") got 36161.5 instead of 36161.5 vartest.c:2208: Test failed: VarDateFromStr([90]="4AM 11/11/1999") got 36475.2 instead of 36475.2 vartest.c:2208: Test failed: VarDateFromStr([109]="1.5") got 0.0451389 instead of 0.045139 vartest.c:2208: Test failed: VarDateFromStr([110]="2.5") got 0.0868056 instead of 0.086806 vartest.c:2208: Test failed: VarDateFromStr([111]="3.5") got 0.128472 instead of 0.128472 vartest.c:2208: Test failed: VarDateFromStr([112]="4.5") got 0.170139 instead of 0.170139 vartest.c:2223: ======== Testing VarBoolFromXXX ======== vartest.c:2283: ======== Testing VarBSTRFromXXX ======== vartest.c:2308: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2315: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2308: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2315: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2308: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2315: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2308: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2315: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2308: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2315: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2359: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2365: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2359: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2365: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2359: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2365: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2359: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2365: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2359: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2365: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2382: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07, but return val is "8.765432E+07" vartest.c:2388: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2382: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08, but return val is "9.876543E+08" vartest.c:2388: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2382: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09, but return val is "1.987654E+09" vartest.c:2388: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2408: Test failed: d is 0.2345, should be cvt. to 0.2345001, but return val is "0.2345" vartest.c:2432: Test failed: d is 654322, should be cvt. to 654322.2, but return val is "654322.3" vartest.c:2438: Test failed: d is -654322, should be cvt. to -654322.2, but return val is "-654322.3" vartest.c:2432: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07, but return val is "8.765432E+07" vartest.c:2438: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2432: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08, but return val is "9.876543E+08" vartest.c:2438: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2432: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09, but return val is "1.987654E+09" vartest.c:2438: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2493: ======== Testing Hi-Level Variant API ======== vartest.c:2560: Test failed: should be 5/11/94 7:58:42 AM vartest.c:2578:-------------- Testing different VARTYPES ---------------- vartest: 2281 tests executed, 0 marked as todo, 55 failures. === rpcrt4_test === rpc: 901 tests executed, 0 marked as todo, 0 failures. === shell32_test === generated: 272 tests executed, 0 marked as todo, 0 failures. shlfileop.c:120: Test failed: Deletion was successful shlfileop.c:122: Test failed: File should be removed shlfileop.c:124: Test failed: Directory exists, but is not removed shlfileop.c:129: Test failed: Directory removed shlfileop.c:130: Test failed: Directory should be removed shlfileop.c:132: Test failed: The requested file does not exist shlfileop.c:286: Test failed: Files are copied to other directory shlfileop.c:287: Test failed: The file is copied shlfileop.c:316: Test failed: Files and directories are moved to directory shlfileop.c:317: Test failed: The file is moved shlfileop.c:318: Test failed: The directory is moved shlfileop.c:319: Test failed: The file in subdirectory is moved shlfileop: 121 tests executed, 0 marked as todo, 12 failures. === shlwapi_test === clist.c:367: Test failed: allowed bad element size clist.c:372: Test failed: allowed adding a container clist: 236 tests executed, 0 marked as todo, 2 failures. generated: 19 tests executed, 0 marked as todo, 0 failures. shreg.c:171: Test failed: (44,43) shreg.c:195: Test failed: (44,43) shreg.c:205: Test failed: () shreg.c:206: Test failed: () shreg.c:207: Test failed: (44,43) shreg.c:218: Test failed: (44,43) shreg.c:240: Test failed: didn't open dest shreg: 39 tests executed, 0 marked as todo, 7 failures. === urlmon_test === generated: 4 tests executed, 0 marked as todo, 0 failures. === user32_test === class: 80 tests executed, 0 marked as todo, 0 failures. generated: 1524 tests executed, 0 marked as todo, 0 failures. Sysparams: win: 428 tests executed, 0 marked as todo, 0 failures. wsprintf: 4 tests executed, 0 marked as todo, 0 failures. === wininet_test === generated: 252 tests executed, 0 marked as todo, 0 failures. (Lines removed.) http.c:172: Test failed: InternetQueryDataAvailable failed (Lots more lines removed.) http: 25 tests executed, 0 marked as todo, 1 failure. === winmm_test === wave: 149 tests executed, 0 marked as todo, 0 failures. === ws2_32_test === sock: 128 tests executed, 0 marked as todo, 0 failures. Thanks, Kye Lewis LinksOS Project Administrator LinksOS Web Team Leader kyethespy(a)softhome.net (New email address! kyethespy(a)liquid2k.comwill still work, but please send all emails now to new email) "640k ought to be enough for anyone!" - Bill Gates ================================= LinksOS: Linking you to the world http://linksos.cjb.net http://linksos.sourceforge.net/ http://linksos.oxygen-x.net/ Now with Bugzilla and phpBB installed :) =================================

2 1

Putty: Winelib support (take 2)
by Dimitrie O. Paun Dec. 31, 2002

Dec. 31, 2002

On December 18, 2002 04:59 am, Simon Tatham wrote: > That said, I also agree your revised patch is a huge amount better > by comparison! So if you'd rather I wait until that's ready, I'm > fine with that too. Hi Simon, I've managed to cleanup my changes. Currently only this 3-line patch is required to compile putty under Winelib. The way it works is that you simply uncomment 2 (two) lines in the Makefile.cyg file, and do the usual: make -f Makefile.cyg to compile under Wine. This has the advantage that you don't need to maintain a Wine-only Makefile that is quite likely to get bitrotten sooner rather than later. Please let me know if you need any other changes. Happy New Year! Index: mkfiles.pl =================================================================== RCS file: /home/cvs/putty/mkfiles.pl,v retrieving revision 1.38 diff -u -r1.38 mkfiles.pl --- mkfiles.pl 30 Dec 2002 23:14:11 -0000 1.38 +++ mkfiles.pl 31 Dec 2002 09:31:29 -0000 @@ -293,6 +293,9 @@ "# TOOLPATH = /pkg/mingw32msvc/i386-mingw32msvc/bin/\n". "CC = \$(TOOLPATH)gcc\n". "RC = \$(TOOLPATH)windres\n". +"# Uncomment the following two lines to compile under Winelib\n". +"# CC = winegcc\n". +"# RC = wrc\n". "# You may also need to tell windres where to find include files:\n". "# RCINC = --include-dir c:\\cygwin\\include\\\n". "\n". -- Dimi.

1 0

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)
by Patrik Stridvall Dec. 30, 2002

Dec. 30, 2002

> On December 30, 2002 12:43 pm, Dan Kegel wrote: > > OK, maybe that's another janitorial project I can take on. > > You asked for it! :) > http://www.dssd.ca/wine/Wine-Janitorial.html#include-quotes I'm already on it by improving winapi_cleanup. I'm not 100% sure it is correct though and I havn't any time to work on it until after new year so here is what I currently got. Alexandre: You can apply it as it is regardless. It it off by default so it can't hurt. Use it like: winapi_cleanup --include-qoutes Note that you can also do on specific directories by specifing them on the command line. Like: winapi_cleanup --include-qoutes include dlls

2 1

Windows 2000 Pro conformance test update
by Dave Miller Dec. 30, 2002

Dec. 30, 2002

Here is an update using precompiled binaries from 12/28/02. Not that dsound test complains msvcrtd.dll is missing on my system, and so has not been tested. I think this covers everything else missing or different from what is shown on the status page. C:\winetests>gdi32_test.exe generated generated: 2786 tests executed, 0 marked as todo, 0 failures. C:\winetests>kernel32_test.exe generated generated: 609 tests executed, 0 marked as todo, 0 failures. C:\winetests>kernel32_test.exe generated generated: 609 tests executed, 0 marked as todo, 0 failures. C:\winetests>kernel32_test.exe locale locale.c:154: Test failed: GetTimeFormat got '' instead of '4' locale.c:155: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:181: Test failed: GetTimeFormat got '8.@:56AM' instead of '8.@:56.@:AM' locale.c:182: Test failed: GetTimeFormat: got 9 instead of 12 locale.c:190: Test failed: GetTimeFormat got '' instead of '3' locale.c:191: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:474: Test failed: GetDateFormat got '5/4/2002' instead of '5/4/02' locale.c:475: Test failed: GetDateFormat: got 9 instead of 7 locale.c:499: Test failed: GetDateFormat check DATE_YEARMONTH with null format expected ERROR_INVALID_FLAGS got return of '10' and error of '0' locale: 109 tests executed, 0 marked as todo, 9 failures. C:\winetests>kernel32_test.exe path path.c:514: Test failed: GetLongPathNameA: wrong return code, 97 instead of 42 path.c:881:TMP=C:\DOCUME~1\davidm\LOCALS~1\Temp path.c:892:TMP=C:\WINNT path.c:902:TMP=C:\ path.c:912:TMP=C: path: 1730 tests executed, 0 marked as todo, 1 failure. C:\winetests>kernel32_test.exe process tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. process.c:378: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\winetests\kernel32_test.exe tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures.process.c:530: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process, got C:\winetests\kernel32_test.exe tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. process: 116 tests executed, 0 marked as todo, 2 failures. C:\winetests>msvcrt_test.exe file file: 2 tests executed, 0 marked as todo, 0 failures. C:\winetests>msvcrt_test.exe scanf scanf: 8 tests executed, 0 marked as todo, 0 failures. C:\winetests>ntdll_test.exe error error: 813 tests executed, 0 marked as todo, 0 failures. C:\winetests>ntdll_test.exe generated generated: 1279 tests executed, 0 marked as todo, 0 failures. C:\winetests>ntdll_test.exe rtlbitmap rtlbitmap: 201 tests executed, 0 marked as todo, 0 failures. C:\winetests>ntdll_test.exe rtlstr rtlstr: 38 tests executed, 0 marked as todo, 0 failures. C:\winetests>oleaut32_test.exe safearray safearray: 348 tests executed, 0 marked as todo, 0 failures. C:\winetests>oleaut32_test.exe vartest vartest.c:1707: ======== Testing VarUI1FromXXX ======== vartest.c:1713:VarUI1FromI2: passing in NULL as return val makes it crash, needto write proper test. vartest.c:1797: ======== Testing VarUI2FromXXX ======== vartest.c:1802:VarUI2FromI2: passing in NULL as return val makes it crash, needs to be fixed. vartest.c:1873: ======== Testing VarUI4FromXXX ======== vartest.c:1876:VarUI4FromI2: passing in NULL as return val makes it crash, implement me. vartest.c:1951: ======== Testing VarI1FromXXX ======== vartest.c:2004: ======== Testing VarI2FromXXX ======== vartest.c:2047: ======== Testing VarI4FromXXX ======== vartest.c:2091: ======== Testing VarR4FromXXX ======== vartest.c:2138: ======== Testing VarR8FromXXX ======== vartest.c:2158: ======== Testing VarDateFromXXX ======== vartest.c:2208: Test failed: VarDateFromStr([7]="0.49") got 0.0340278 instead of 0.034028 vartest.c:2208: Test failed: VarDateFromStr([8]="0.5") got 0.00347222 instead of 0.003472 vartest.c:2208: Test failed: VarDateFromStr([9]="0.51") got 0.0354167 instead of 0.035417 vartest.c:2208: Test failed: VarDateFromStr([34]=" 1 2 ") got 37258 instead of 35797 vartest.c:2208: Test failed: VarDateFromStr([39]="1.2.3") got 0.0430903 insteadof 0.04309 vartest.c:2208: Test failed: VarDateFromStr([69]=" 1999/ 11/21 11 :11:11am") got 36485.5 instead of 36485.5 vartest.c:2208: Test failed: VarDateFromStr([70]="11/11/1999 11:11:11Am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([71]="11/11/1999 11:11:11PM") got 36476 instead of 36476 vartest.c:2208: Test failed: VarDateFromStr([73]="11/11/1999 0:0:11am") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([75]="11/11/1999 11:11:11am") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([77]="11/11/1999 11:11AM") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([78]="11/11/1999 1AM") got 36475 instead of 36475 vartest.c:2208: Test failed: VarDateFromStr([80]="11/11/1999 11:11:11") got 36475.5 instead of 36475.5 vartest.c:2208: Test failed: VarDateFromStr([89]="1 January 1999 11AM") got 36161.5 instead of 36161.5 vartest.c:2208: Test failed: VarDateFromStr([90]="4AM 11/11/1999") got 36475.2 instead of 36475.2 vartest.c:2208: Test failed: VarDateFromStr([109]="1.5") got 0.0451389 instead of 0.045139 vartest.c:2208: Test failed: VarDateFromStr([110]="2.5") got 0.0868056 instead of 0.086806 vartest.c:2208: Test failed: VarDateFromStr([111]="3.5") got 0.128472 instead of 0.128472 vartest.c:2208: Test failed: VarDateFromStr([112]="4.5") got 0.170139 instead of 0.170139 vartest.c:2223: ======== Testing VarBoolFromXXX ======== vartest.c:2283: ======== Testing VarBSTRFromXXX ======== vartest.c:2308: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2315: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2308: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2315: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2308: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2315: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2308: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2315: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2308: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2315: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2359: Test failed: d is 7.65432e+015, should be cvt. to 7.65432198765432e+15, but return val is "7.65432198765432E+15" vartest.c:2365: Test failed: d is -7.65432e+015, should be cvt. to -7.65432198765432e+15, but return val is "-7.65432198765432E+15" vartest.c:2359: Test failed: d is 8.76543e+016, should be cvt. to 8.76543219876543e+16, but return val is "8.76543219876543E+16" vartest.c:2365: Test failed: d is -8.76543e+016, should be cvt. to -8.76543219876543e+16, but return val is "-8.76543219876543E+16" vartest.c:2359: Test failed: d is 9.87654e+017, should be cvt. to 9.87654321987654e+17, but return val is "9.87654321987654E+17" vartest.c:2365: Test failed: d is -9.87654e+017, should be cvt. to -9.87654321987654e+17, but return val is "-9.87654321987654E+17" vartest.c:2359: Test failed: d is 1.98765e+018, should be cvt. to 1.98765432198765e+18, but return val is "1.98765432198765E+18" vartest.c:2365: Test failed: d is -1.98765e+018, should be cvt. to -1.98765432198765e+18, but return val is "-1.98765432198765E+18" vartest.c:2359: Test failed: d is 2.19877e+019, should be cvt. to 2.19876543219877e+19, but return val is "2.19876543219877E+19" vartest.c:2365: Test failed: d is -2.19877e+019, should be cvt. to -2.19876543219877e+19, but return val is "-2.19876543219877E+19" vartest.c:2382: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07,but return val is "8.765432E+07" vartest.c:2388: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2382: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08,but return val is "9.876543E+08" vartest.c:2388: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2382: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09,but return val is "1.987654E+09" vartest.c:2388: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2408: Test failed: d is 0.2345, should be cvt. to 0.2345001, but return val is "0.2345" vartest.c:2432: Test failed: d is 654322, should be cvt. to 654322.2, but return val is "654322.3" vartest.c:2438: Test failed: d is -654322, should be cvt. to -654322.2, but return val is "-654322.3" vartest.c:2432: Test failed: d is 8.76543e+007, should be cvt. to 8.765432e+07,but return val is "8.765432E+07" vartest.c:2438: Test failed: d is -8.76543e+007, should be cvt. to -8.765432e+07, but return val is "-8.765432E+07" vartest.c:2432: Test failed: d is 9.87654e+008, should be cvt. to 9.876543e+08,but return val is "9.876543E+08" vartest.c:2438: Test failed: d is -9.87654e+008, should be cvt. to -9.876543e+08, but return val is "-9.876543E+08" vartest.c:2432: Test failed: d is 1.98765e+009, should be cvt. to 1.987654e+09,but return val is "1.987654E+09" vartest.c:2438: Test failed: d is -1.98765e+009, should be cvt. to -1.987654e+09, but return val is "-1.987654E+09" vartest.c:2493: ======== Testing Hi-Level Variant API ======== vartest.c:2560: Test failed: should be 5/11/94 7:58:42 AM vartest.c:2578:-------------- Testing different VARTYPES ---------------- vartest: 2281 tests executed, 0 marked as todo, 55 failures. C:\winetests>shell32_test.exe generated generated: 272 tests executed, 0 marked as todo, 0 failures. C:\winetests>shlwapi_test.exe clist clist: 236 tests executed, 0 marked as todo, 0 failures. C:\winetests>shlwapi_test.exe generated generated: 19 tests executed, 0 marked as todo, 0 failures. C:\winetests>urlmon_test.exe generated generated: 4 tests executed, 0 marked as todo, 0 failures. C:\winetests>user32_test.exe generated generated: 1524 tests executed, 0 marked as todo, 0 failures. C:\winetests>user32_test.exe win win.c:132:main window 001F00FC main2 001E0104 desktop 0001000C child 001E0108 win.c:148:created child 001C00BA win.c:161:created child of desktop 001D00BA win.c:171:created child of child 001E00BA win.c:181:created top-level 001F00BA win.c:191:created owned top-level 002000BA win.c:201:created popup 002100BA win.c:211:created owned popup 002200BA win.c:221:created top-level owned by child 002300BA win.c:227:created popup owned by desktop 002400BA win.c:233:created popup owned by child 002500BA win.c:239:created WS_CHILD popup 002600BA win.c:245:created owned WS_CHILD popup 002700BA win.c:250:testing parent changes win.c:262:created child 002800BA win.c:288:created top-level 002900BA win.c:305:created popup 002A00BA win.c:322:created child 002B00BA win.c:339:created top-level 002C00BA win.c:348:created owned popup 002D00BA win.c:364:created owner 002E00BA and popup 001D011A win.c:378:created owner 001E011A and popup 002F00BA win.c:386:created owner 001F011A and popup 003000BA win: 428 tests executed, 0 marked as todo, 0 failures. C:\winetests>user32_test.exe sysparams sysparams.c:184:testing SPI_{GET,SET}BEEP sysparams.c:306:testing SPI_{GET,SET}MOUSE sysparams.c:374:testing SPI_{GET,SET}BORDER sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=1, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=0, value= sysparams.c:139: Test failed: Missed a message: change_counter=2 sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=7, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=BorderWidth, testValue=20, value= sysparams.c:406:testing SPI_{GET,SET}KEYBOARDSPEED sysparams.c:139: Test failed: Missed a message: change_counter=2 sysparams.c:440:testing SPI_ICONHORIZONTALSPACING sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=101, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconSpacing, testValue=32, value= sysparams.c:480:testing SPI_{GET,SET}SCREENSAVETIMEOUT sysparams.c:515:testing SPI_{GET,SET}SCREENSAVEACTIVE sysparams.c:555:testing SPI_{GET,SET}KEYBOARDDELAY sysparams.c:590:testing SPI_ICONVERTICALSPACING sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=101, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconVerticalSpacing, testValue=32, value= sysparams.c:635:testing SPI_{GET,SET}ICONTITLEWRAP sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=1, value= sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=IconTitleWrap, testValue=0, value= sysparams.c:670:testing SPI_{GET,SET}MENUDROPALIGNMENT sysparams.c:707:testing SPI_SETDOUBLECLKWIDTH sysparams.c:738:testing SPI_SETDOUBLECLKHEIGHT sysparams.c:770:testing SPI_SETDOUBLECLICKTIME sysparams.c:817:testing SPI_SETMOUSEBUTTONSWAP sysparams.c:880:testing SPI_{GET,SET}DRAGFULLWINDOWS sysparams.c:915:testing SPI_{GET,SET}WORKAREA sysparams.c:953:testing SPI_{GET,SET}SHOWSOUNDS sysparams.c:997:testing SPI_{GET,SET}DESKWALLPAPER sysparams.c:170: Test failed: Wrong value in registry: subKey=Control Panel\Desktop, valName=Wallpaper, testValue=, value=(None) sysparams: 318 tests executed, 0 marked as todo, 13 failures. C:\winetests>wininet_test.exe generated generated: 252 tests executed, 0 marked as todo, 0 failures. C:\winetests>wininet_test.exe http <Ouput snipped> http: 24 tests executed, 0 marked as todo, 0 failures.

1 0

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)
by Patrik Stridvall Dec. 30, 2002

Dec. 30, 2002

> "--include-qoutes" needs to be "--include-quotes" > ^^ ^^ > This is incorrect in both the message and the patch. Ah. Thanks. :-) Somehow I can never learn that to spell the quo* words correctly. I always seem to believe it is spelled qou*. Despite working with Unix more than 10 year I STILL frequently type "qouta" instead of "quota" when I wish to check for available quota. I probably mistyped it over 100 times during these years but I never seem to learn. Unlearning/relearning some things are hard... :-) Anyway. Here is the patch again with this fixed (hopefully). *** winapi_cleanup * tools/winapi_check/nativeapi.pm, tools/winapi/winapi_cleanup, tools/winapi/winapi_cleanup_options.pm: Added --include-quotes option that fixes #include to use the correct of <> and "".

1 0

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)
by Jeff Smith Dec. 30, 2002

Dec. 30, 2002

"--include-qoutes" needs to be "--include-quotes" ^^ ^^ This is incorrect in both the message and the patch. -- Jeff S >From: "Patrik Stridvall" <ps(a)leissner.se> > >I'm already on it by improving winapi_cleanup. > >I'm not 100% sure it is correct though and I havn't any time to >work on it until after new year so here is what I currently got. > >Alexandre: You can apply it as it is regardless. It it off by default >so it can't hurt. > >Use it like: >winapi_cleanup --include-qoutes > >Note that you can also do on specific directories by specifing them >on the command line. > >Like: >winapi_cleanup --include-qoutes include dlls > > ><< winapi_cleanup.diff >> _________________________________________________________________ Protect your PC - get McAfee.com VirusScan Online http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

1 0

Re: conformance test for ShellExecute
by Dimitrie O. Paun Dec. 30, 2002

Dec. 30, 2002

On December 29, 2002 07:45 pm, Dan Kegel wrote: > I added a few definitions that let this file > optionally compile standalone, which made things > easier on Windows. > +#include "wtypes.h" > +#include "winbase.h" > +#include "windef.h" > +#include "shellapi.h" > +#include "wine/test.h" Please use <> instead of "" even in Wine. The old code uses "" for historical reasons that are no longer an issue. It needs to be changed (and we're waiting for some Perl wizard to help out <g>), but the new code should not perpetuate this deprecated practice IMO. -- Dimi.

2 3

Regression in msvideo patch
by Stephen Mollett Dec. 30, 2002

Dec. 30, 2002

Hi, [Following on from a thread on wine-users] I've had some problems recently with running the VirtualDub video post-processing package on Wine. It used to work, but then stopped working (it no longer displays the frame previews when seeking in a video file) recently. I've done a regression test and narrowed the problem down to the patch described in: http://www.winehq.com/hypermail/wine-cvs/2002/11/0187.html Before this patch (2002-11-20 13:47:00 CST), frame preview works normally in VirtualDub. Afterwards, vdub crashes when seeking. Later cvs versions don't crash but don't display frames either. The console output from Wine includes: fixme:msvideo:DrawDibRealize (0x1, 0x8f4, 0), stub just once before a load of messages similar to: fixme:psapi:EnumProcessModules (hProcess=0xffffffff, 0x425cf000, 4096, 0x405c0038) fixme:psapi:GetModuleBaseNameA (hProcess=0xffffffff, hModule=0x400000, "", 65212): stub fixme:psapi:GetModuleBaseNameA (hProcess=0xffffffff, hModule=0x425e0000, "", 65212): stub fixme:psapi:GetModuleBaseNameA (hProcess=0xffffffff, hModule=0x78000000, "", 65212): stub ... when a crash occurs; the later non-crashing versions just display loads of messages similar to the first one about DrawDibRealize. If you like, I can try to track down when the crashing behaviour changed to simple non-drawing. Regards, Stephen

3 5