August 2002 - Wine-Devel - list.winehq.org

right way to compile wine with a "buildroot" DESTDIR is missing
by Raul Dias Aug. 16, 2002

Aug. 16, 2002

Hi, I have been building wine RPMs for some time now. The way I do is to specify the correct paths to ./configure script (like prefix, mandir, bindir, ...). After building I have to use an ugly make install in orther to install it into another dir that is different from the one. However, talking to some wine developers on #winehq in openprojects network. They state that a ./configure --prefix=<you buildroot>/prefix was enough. That's because wine does not hardcode any %prefix related path. This would simplify a lot the process. However I just checked that wine does hardcode the %prefix dir in the binaries. This is done in dlls/ntdll/ntdll.dll.so and possible at miscemu/wine . AFAIU, this is done to keep the path to the global registries which is the Right Thing to do. So what I really would like to know is which way is the right way to install wine in a dir different than %prefix or /usr/local (default %prefix)? Is there any chance to get a DESTDIR implemented in the Makefiles? []'s Raul Dias

4 12

microsoft CFileDialog problem
by mayonaise＠beer.com Aug. 16, 2002

Aug. 16, 2002

hi everybody, i am currently working on making a windows program function in wine. it works for the most part, so i'm trying to iron out a few critical bugs. first off... i'm looking at microsoft's CFileDialog class - it is what the standard windows 'open file' and 'save file' dialog windows use. the problem is this: CFileDialog has a built in function called OnFolderChange, that is used to determine whether the user has changed folders in the dialog, whether by double click or what not.. the program i'm working on overrides the CFileDialog class, and includes more code for the OnFolderChange function (and for other functions) for its own purposes. the new OnFolderChange function works perfectly fine in windows, but is completely ignored when using wine - it never even gets called, while the rest of the dialog window retains all of its intended functionality. as a reference, the built in functions OnFileNameChange, GetFolderPath, and others gets overridden successfully. as far as i can tell, the only function that is not working properly is the OnFolderChange function. the overriding of CFileDialog was accomplished by using a hooking procedure provided in the MSDN library. i hope this is enough information, however i don't expect anyone to fully be able to address this issue without seeing the code i'm working on first.thank you for your time! -kyle

2 1

note to packagers (new optional dependancy)
by Shachar Shemesh Aug. 16, 2002

Aug. 16, 2002

Hi all, A patch just submitted to wine-patches changes the rules when building binary packages of WINE for distributions. This is an optional change, so ignoring this email will not break anything, but will result in decreased functionality. During the configure phase ./configure will now check for the availability of the libfribidi header files. These are typically distributed in a package called "libfribidi-dev". I would highly recommend installing this library on the machine you compile the package on, so as to include the option for BiDi support in the resulting binary. If the headers are found during compile time, a run time check is performed whether the libfribidi library is available. If it is not, Wine will continue without BiDi support. If it is, BiDi support will (at some future date, admitably) be enabled. In .deb speak, libfribidi-dev is build recommended for wine src. libfribidi is suggested for wine. Shachar

2 1

RE: New user/developer has questions ...
by Medland, Bill Aug. 16, 2002

Aug. 16, 2002

> -----Original Message----- > From: Crispen Scott [mailto:C.Scott(a)astronautics.com] > Sent: Friday, August 16, 2002 6:56 AM > To: wine-devel(a)winehq.com > Subject: New user/developer has questions ... > > > I have just RPMed wine-20020512-1.i386.rpm and attempted to > run several WIN > programs (to wit: sol.exe and a proprietary package). > Both fail. I am including the entire run/error message from > my attempt to run > sol.exe below. Being new to WINE, I have no idea where > to begin to find the problem. I have annotated the error > message with notes. > All notes are separated by a > > <NOTE - TEXT> then a CR and follows the line(s) that the NOTE > applies to. > > [root(a)localhost root]# wine /mnt/windows/windows/system32/sol.exe > <NOTE - This is the command line entry > > > err:reg:_convert_win95_registry_to_wine_format unable to load > native win95 > registry file C:\WINDOWS\system.dat: unknown signature. > err:reg:_convert_win95_registry_to_wine_format Unable to load > native win95 > registry file C:\WINDOWS\system.dat. > err:reg:_convert_win95_registry_to_wine_format Please report to > a.mohr(a)mailto.de. > err:reg:_convert_win95_registry_to_wine_format Make a backup > of the file, run > a good reg cleaner program and try again! > <NOTE - The SYSTEM.DAT file located in the windows SUBDIR was > exported from > regedit.exe. This is from a WIN2K OS > That's your mistake. You shouldn't export it. reg_convert_win95_registry_to_wine_format actually reads the files that store a Win95 registry (the actual files, not exports). > > fixme:win32:PE_CreateModule Security directory ignored > <NOTE - I assume this is a FIXME in the SRC> True > > err:font:AddFontFileToList Unable to load font file > "/mnt/windows/windows/Fonts/desktop.ini" err = 55 > <NOTE - This file exists in the proper location so what is the error?> I don't know the font stuff; someone else maybe will help here. > > err:font:AddFontFileToList Already loaded font L"Garamond" L"Bold" > err:font:AddFontFileToList Already loaded font L"Garamond" L"Italic" > err:font:AddFontFileToList Already loaded font L"Garamond" L"Regular" > > err:font:AddFontFileToList Unable to load font file > "/mnt/windows/windows/Fonts/modern.fon" err = 2 > err:font:AddFontFileToList Unable to load font file > "/mnt/windows/windows/Fonts/mtsorts.ttf" err = 2 > err:font:AddFontFileToList Unable to load font file > "/mnt/windows/windows/Fonts/roman.fon" err = 2 > err:font:AddFontFileToList Unable to load font file > "/mnt/windows/windows/Fonts/script.fon" err = 2 > <NOTE - These files exist so why are they able to be loaded?> > > X Error of failed request: XF86DGANoDirectVideoMode > Major opcode of failed request: 136 (XFree86-DGA) > Minor opcode of failed request: 22 (XDGAOpenFramebuffer) > Serial number of failed request: 181 > Current serial number in output stream: 181 > <NOTE - What does this indicate?> > > I am trying to come up to speed on the use of WINE but, as > everyone knows, > the documentation is a little light > as is the commenting of the source code. If someone could > please head me in > the right direction, I would greatly appreciate it. > > Once I have gained some additional expertise in WINE I will > use my 15+ years > of Windows development experience and knowledge > to try and resolve some of the issues and bugs that are > reported. This may > take me several more weeks. > > I am also intending to write a technical book on WINE so will > submit chapters > for review to the community as the become available. > Much of the information will deal with the issues the I, as a > newbie, am > encountering. > > I await the response. > > Crispen Scott > > BTW: I downloaded the source for 20020804 and, after fixing > several build > related problems (incorrect build order, root objections, & > eliminating > programs with build problems I couldn't readily resolve, i.e. > widl), I had > even worse problems with trying to get that version of wine > to run. That is > why I reverted to the latest RPM version. Some of the > problems with the > 20020804 build might be resolved after I see the answers to > the problems I > stated above. > > I am excited about becoming an integral part of this > community but need some > start-up help! > Thanks! > > -- > Crispen Scott > Engineer - Software > Astronautics.com > 4115 Teutonia Road > Milwaukee, WI 53209 > Tel: 414-447-8200 x4434 > C.Scott(a)Astronautics.com > What is your environment; you shouldn't have had all those build problems. Bill

4 3

RFC: winedefault.reg
by lawson_whitney＠juno.com Aug. 16, 2002

Aug. 16, 2002

Good day! Should we maybe install it somewhere in --prefix so it has a chance to get included in binary packages? I have one in /usr/local, but it is from April 19, 2001 and not much use... Lawson ---oops---

2 1

RE: window parent/owner handling
by Medland, Bill Aug. 16, 2002

Aug. 16, 2002

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Thursday, August 15, 2002 8:22 PM > To: Medland, Bill > Cc: wine-devel(a)winehq.com > Subject: Re: window parent/owner handling > > > "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > > Includes my previous patch for SetWindowLong (for Bug 825) > > Seems that your investigations are correct, at least test succeeds > under win2000. I would suggest to apply tiny patch (attached) to catch > some additional problems. Thanks Dmitry; for all your help on this. p.s. I suddenly realised I'd put only my name on the copyright in the test. It's based on your code; You want to be mentioned? (Or is this sufficient ackowledgement?). > > -- > Dmitry. > Bill

2 1

FW: what's with WS_OVERLAPPED?
by Medland, Bill Aug. 16, 2002

Aug. 16, 2002

(Damn; Outlook bugs me) -----Original Message----- From: Medland, Bill Sent: Friday, August 16, 2002 8:19 AM To: 'rolf.kalbermatter(a)citeng.com' Subject: RE: what's with WS_OVERLAPPED? > -----Original Message----- > From: Rolf Kalbermatter [mailto:r.kalbermatter(a)hccnet.nl] > Sent: Thursday, August 15, 2002 11:31 PM > To: Bill.Medland(a)accpac.com > Cc: wine-devel(a)winehq.com > Subject: RE: what's with WS_OVERLAPPED? > > > On Thu, 15 Aug 2002 "Medland, Bill" <Bill.Medland(a)accpac.com> wrote > > > >> On Wednesday, August 14, 2002 Ove Kaaven [mailto:ovehk(a)ping.uio.no] > wrote: > > <snip> > > >> WS_OVERLAPPED is in practice considered the absence of the > >> WS_POPUP and > >> WS_CHILD flags, I believe. > > > >Thanks Ove; that'll do for a working hypothesis. (I wish > Microsoft would > be > >consistant) > > > >Just for the record it is clearly more complex than that. I > guess since > >Microsoft wrote it we can trust Spy++ a little. I have seen > spy++ declare > >that a "tooltips" class window (style 0x84800000/00000088) has style > >WS_OVERLAPPED whereas a "tooltips_class32" class window (style > >0x84800003/00000088) doesn't. > > Hmm, this is just a wild guess but couldn't it be that the > WS_OVERLAPPED > style applies only to the lower word of the windows style. > Windows coming > from 16bit DOS it wouldn't be surprising if the original > windows style was > 16 bit only as well. Either that or Spy++ has a bug, even > though you trust > it so much ;-). Except all the general style stuff is in the top word; the only difference between the two styles, the 3, is two TTS_* toolbar style; generally the stuff in the low word is, I believe, control-specific. I honestly think that it is not so much that Spy++ has a bug as that it is based on some knowledge within Microsoft that describes how they have worked around the mess they have generated over the years. > > Rolf Kalbermatter > mailto:rolf.kalbermatter(a)citeng.com > > Bill

1 0

New user/developer has questions ...
by Crispen Scott Aug. 16, 2002

Aug. 16, 2002

I have just RPMed wine-20020512-1.i386.rpm and attempted to run several WIN programs (to wit: sol.exe and a proprietary package). Both fail. I am including the entire run/error message from my attempt to run sol.exe below. Being new to WINE, I have no idea where to begin to find the problem. I have annotated the error message with notes. All notes are separated by a <NOTE - TEXT> then a CR and follows the line(s) that the NOTE applies to. [root(a)localhost root]# wine /mnt/windows/windows/system32/sol.exe <NOTE - This is the command line entry > err:reg:_convert_win95_registry_to_wine_format unable to load native win95 registry file C:\WINDOWS\system.dat: unknown signature. err:reg:_convert_win95_registry_to_wine_format Unable to load native win95 registry file C:\WINDOWS\system.dat. err:reg:_convert_win95_registry_to_wine_format Please report to a.mohr(a)mailto.de. err:reg:_convert_win95_registry_to_wine_format Make a backup of the file, run a good reg cleaner program and try again! <NOTE - The SYSTEM.DAT file located in the windows SUBDIR was exported from regedit.exe. This is from a WIN2K OS > fixme:win32:PE_CreateModule Security directory ignored <NOTE - I assume this is a FIXME in the SRC> err:font:AddFontFileToList Unable to load font file "/mnt/windows/windows/Fonts/desktop.ini" err = 55 <NOTE - This file exists in the proper location so what is the error?> err:font:AddFontFileToList Already loaded font L"Garamond" L"Bold" err:font:AddFontFileToList Already loaded font L"Garamond" L"Italic" err:font:AddFontFileToList Already loaded font L"Garamond" L"Regular" err:font:AddFontFileToList Unable to load font file "/mnt/windows/windows/Fonts/modern.fon" err = 2 err:font:AddFontFileToList Unable to load font file "/mnt/windows/windows/Fonts/mtsorts.ttf" err = 2 err:font:AddFontFileToList Unable to load font file "/mnt/windows/windows/Fonts/roman.fon" err = 2 err:font:AddFontFileToList Unable to load font file "/mnt/windows/windows/Fonts/script.fon" err = 2 <NOTE - These files exist so why are they able to be loaded?> X Error of failed request: XF86DGANoDirectVideoMode Major opcode of failed request: 136 (XFree86-DGA) Minor opcode of failed request: 22 (XDGAOpenFramebuffer) Serial number of failed request: 181 Current serial number in output stream: 181 <NOTE - What does this indicate?> I am trying to come up to speed on the use of WINE but, as everyone knows, the documentation is a little light as is the commenting of the source code. If someone could please head me in the right direction, I would greatly appreciate it. Once I have gained some additional expertise in WINE I will use my 15+ years of Windows development experience and knowledge to try and resolve some of the issues and bugs that are reported. This may take me several more weeks. I am also intending to write a technical book on WINE so will submit chapters for review to the community as the become available. Much of the information will deal with the issues the I, as a newbie, am encountering. I await the response. Crispen Scott BTW: I downloaded the source for 20020804 and, after fixing several build related problems (incorrect build order, root objections, & eliminating programs with build problems I couldn't readily resolve, i.e. widl), I had even worse problems with trying to get that version of wine to run. That is why I reverted to the latest RPM version. Some of the problems with the 20020804 build might be resolved after I see the answers to the problems I stated above. I am excited about becoming an integral part of this community but need some start-up help! Thanks! -- Crispen Scott Engineer - Software Astronautics.com 4115 Teutonia Road Milwaukee, WI 53209 Tel: 414-447-8200 x4434 C.Scott(a)Astronautics.com

2 1

RE: what's with WS_OVERLAPPED?
by Rolf Kalbermatter Aug. 16, 2002

Aug. 16, 2002

On Thu, 15 Aug 2002 "Medland, Bill" <Bill.Medland(a)accpac.com> wrote > >> On Wednesday, August 14, 2002 Ove Kaaven [mailto:ovehk(a)ping.uio.no] wrote: <snip> >> WS_OVERLAPPED is in practice considered the absence of the >> WS_POPUP and >> WS_CHILD flags, I believe. > >Thanks Ove; that'll do for a working hypothesis. (I wish Microsoft would be >consistant) > >Just for the record it is clearly more complex than that. I guess since >Microsoft wrote it we can trust Spy++ a little. I have seen spy++ declare >that a "tooltips" class window (style 0x84800000/00000088) has style >WS_OVERLAPPED whereas a "tooltips_class32" class window (style >0x84800003/00000088) doesn't. Hmm, this is just a wild guess but couldn't it be that the WS_OVERLAPPED style applies only to the lower word of the windows style. Windows coming from 16bit DOS it wouldn't be surprising if the original windows style was 16 bit only as well. Either that or Spy++ has a bug, even though you trust it so much ;-). Rolf Kalbermatter mailto:rolf.kalbermatter(a)citeng.com

1 0

Re: wine/ dlls/gdi/Makefile.in dlls/gdi/bidi16.c d ...
by Dimitrie O. Paun Aug. 16, 2002

Aug. 16, 2002

On August 15, 2002 08:42 pm, Alexandre Julliard wrote: [...] > Log message: > Moved a large number of 16-bit functions to a separate gdi16.c file. This is a great idea that I've been advocating for a loooong time now <g>. I think moving 16 bit code into separate files is cool: -- runtime efficiency: If 16 bit code is not invoked, it's not going to be paged in during execution -- code neatness: developers working on the 32-bit code (which is _the_ code in Wine) will not get distracted by silly 16-to-32-to-16 bit conversions. -- helps correctness: 16-bit code is in general a simple: 16-to-32 bit conversion call the 32-bit equivalent function 32-to-16 bit conversion Which means there is a lot of repetition, template-like coding. Any departure from the usual pattern is a *lot* more easily spotted by the naked eye if it's present in a file that does just that. -- 16-to-32 bit: we can more easily see (and fix) cases where 32 bit code calls 16 bit code. For all these reasons, I think we should have _all_ 16-bit code into separate files. Always. Who knows, maybe we can have makefiles done such a way that we can avoid compiling 16 bit code altogether! :) Even if only as a simple check that no 32 bit code calls down to 16 bit... And again, the _same_ rationale applies to xxxW & xxxA functions, but I'll not pursue this point for now ;). -- Dimi.

1 0

Re: window parent/owner handling
by Dmitry Timoshkov Aug. 15, 2002

Aug. 15, 2002

"Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > Includes my previous patch for SetWindowLong (for Bug 825) Seems that your investigations are correct, at least test succeeds under win2000. I would suggest to apply tiny patch (attached) to catch some additional problems. -- Dmitry.

1 0

RE: Some observations on window parentage etc.
by Medland, Bill Aug. 15, 2002

Aug. 15, 2002

> -----Original Message----- > From: Medland, Bill [mailto:Bill.Medland(a)accpac.com] > Sent: Thursday, August 15, 2002 8:59 AM > To: Wine devel (E-mail) > Subject: Some observations on window parentage etc. > > > Here are some observations with regard to Window > parentage/ownership etc. snip > > More to follow. > > Bill > OK guys; who can justify the claim in the server (set_window_owner) that the owner and the window must have the same parent? I think it is untrue, but I don't know what it should be. I believe we need to extend the WIN_SetOwner to return the previous owner. Should we take that out of the structure on the user side or should we modify the server reply to return it? I guess modifying the server reply is the safer option and should have no performance penalty. So here is what I am looking at doing. (I'd prefer comments here rather than after I submit the patch) 1. Modify the set_window_owner reply to return both the new full handle and the previous full handle. (p.s. what is this full handle anyway? Why is it different from the one passed in the request?) 2. Modify the set_window_owner handler to fill in the reply and also remove the parent test (or replace it with anything you guys think makes sense) 3. Modify WIN_SetOwner to return the value 4. Leave GetParent as it is 5. Modify GetWindowLong (GWL_HWNDPARENT to return the parent if a WS_CHILD and the owner otherwise (even if not a WS_POPUP) 6. Modify GetAncestor (GA_ROOTWINDOW) to return the same as recursing on GetParent. 7. Write a test set. Comments? Bill

1 0

RE: Re:can windows be reparented?
by Medland, Bill Aug. 15, 2002

Aug. 15, 2002

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Thursday, August 15, 2002 10:00 AM > To: Medland, Bill > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > > > "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > > (Do you want the test case code?) > > Why not? :-) > > -- > Dmitry. > > > First is without WS_POPUP, second is with

1 0

RE: Re:can windows be reparented?
by Medland, Bill Aug. 15, 2002

Aug. 15, 2002

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Thursday, August 15, 2002 9:17 AM > To: Medland, Bill > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > > > "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > > Honest question : how do you know the parent is changing? > by calling > > GetWindowLong (GWL_HWNDPARENT)? > > Yes, and verifying the result in Spy++. (As discussed in my other email) I guess Spy++ is displaying the result of GetWindowLong > > > I believe that it is the owner that is changing and the > parent (as returned > > by getAncestor (GA_PARENT) willl be unchanged. > > Hmm, I didn't try GetAncestor(), only GetWindowLong() and GetParent(). (Do you want the test case code?) > > -- > Dmitry. > > >

2 1

RE: Re:can windows be reparented?
by Medland, Bill Aug. 15, 2002

Aug. 15, 2002

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Tuesday, August 13, 2002 6:33 PM > To: us(a)the-edmeades.demon.co.uk > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > snip > Could you please test patch posted by Bill Medland to > wine-patches today? It's > not entirely correct though. My tests show that > SetWindowLong(GWL_HWNDPARENT) > call changes simultaneously both parent and owner for top > level windows and > returns old value (not sure old owner or parent it is). Honest question : how do you know the parent is changing? by calling GetWindowLong (GWL_HWNDPARENT)? I believe that it is the owner that is changing and the parent (as returned by getAncestor (GA_PARENT) willl be unchanged. snip Bill

2 1

Some observations on window parentage etc.
by Medland, Bill Aug. 15, 2002

Aug. 15, 2002

Here are some observations with regard to Window parentage/ownership etc. Clearlt Microsoft documentation is quite out of date and contradictory on the subject these days so we are going to have to experiment and find out what actually happens. We also are going to have to be careful about terminology and not jumping to conclusions. I mean what ther heck are we supposed to think when Spy++ shows a window as a top-level window (by which I mean just below the desktop in the listview that Spy++ uses), tells us that its parent is its owner (a different top-level window) but that "parent" says it has no children. So. 1. GetParent does not necessarily return the same value as GetWindowLong (GWL_HWNDPARENT). I have seen GetParent returning 0 while GetWindowLong returns the same non zero value as GetWindow (GW_OWNER). 2. GetAncestor (GA_PARENT) seems to be the best way to get the "true parent". 3. WIN_CreateWindowEx is currently slightly wrong. I know MSDN says don't mix WS_POPUP and WS_CHILD but if you do then the result is wrong, I believe. However I am loth to fix it and submit the patch because that really messes everything else up so I guess we need a bigger patch first. (Heck, even under windows 98 you can get the kernel to fall over rather easily this way). 4. I don't like the look of GetAncestor (GA_ROOTOWNER). The MSDN documentation suggests that it should return the result of recursively calling GetParent (or should it be recursively calling GetWindowLong (GWL_HWNDPARENT) whereas GetAncestor (GA_ROOT) should return the result of recursively calling GetAncestor (GA_PARENT) (each stopping just before the desktop, of course). (And of course that is definition, not necessarily mechanism) More to follow. Bill

1 0

RE: what's with WS_OVERLAPPED?
by Medland, Bill Aug. 15, 2002

Aug. 15, 2002

> -----Original Message----- > From: Ove Kaaven [mailto:ovehk(a)ping.uio.no] > Sent: Wednesday, August 14, 2002 11:08 AM > To: Medland, Bill > Cc: Wine devel (E-mail) > Subject: Re: what's with WS_OVERLAPPED? > > > > On Wed, 14 Aug 2002, Medland, Bill wrote: > > > (Regarding the whole issue of windows reparenting) > > > > MSDN keeps going on about windows with the WS_OVERLAPPED > style. However > > surely (since WS_OVERLAPPED=0) every window has such a > style these days. > > > > Is there something I don't understand? > > WS_OVERLAPPED is in practice considered the absence of the > WS_POPUP and > WS_CHILD flags, I believe. > Thanks Ove; that'll do for a working hypothesis. (I wish Microsoft would be consistant) Just for the record it is clearly more complex than that. I guess since Microsoft wrote it we can trust Spy++ a little. I have seen spy++ declare that a "tooltips" class window (style 0x84800000/00000088) has style WS_OVERLAPPED whereas a "tooltips_class32" class window (style 0x84800003/00000088) doesn't. Bill

1 0

ListView Patch
by Steve Whine Aug. 15, 2002

Aug. 15, 2002

Hi all, I should maybe have posted this to the patches list, but I would like your comments first. I have fixed a few problems with the ListView control when using icons larger than the sizes returned by the system metrics. This (attached) patch also causes LISTVIEW_Arrange (which was previously a stub) to call the LISTVIEW_AlignTop/Left when appropriate. Please let me know what you think. This is my first time doing any of this, so let me know what I'm doing wrong/right. Cheers Steve

1 0

ListView Issues
by Steve Whine Aug. 14, 2002

Aug. 14, 2002

Hi, I've just started looking into getting a project of wine running on Linux via Wine, and I'm very impressed so far! However, there are a few (mostly minor) problems with the ListView control: - When using icons bigger than the sizes returned by SystemParametersInfo(SPI_GETICONMETRICS), the text for the items is not displayed correctly at the bottom of the icon. - When running a program created by C++ Builder 5, clicking on an item in the listview causes an access violation in C++ Builder's VCL library code - it is obviously getting passed an unexpected value. - The amount of text displayed is often far less than is displayed in Windows, making the listbox difficult to use. I have been looking into the ListView code and have hacked a fix for the first and third problem, but I am having a little difficulty understanding the code - the LISTVIEW_INFO struct has both an nItemWidth/nItemHeight pair describing the width/height of each item, and an iconSpacing SIZE struct that seems to do the same. What is the difference in these, where should one be used and where should the other be used? Is anyone actively maintaining the listview code, or should I just carry on hacking until I'm happy with it, and post the changes here? I have created a small test program to demonstrate these problems which I can post if anyone is interested. I must say it's very nice to be able to wade into the code to fix these problems myself rather than waiting for someone else (not) to do it! Cheers Steve __________________________________________________ Do You Yahoo!? Everything you'll ever need on one web page from News and Sport to Email and Music Charts http://uk.my.yahoo.com

3 2

Re: New Slovak translation
by Vincent Béron Aug. 14, 2002

Aug. 14, 2002

Le lun 12/08/2002 à 08:35, Andrej Kruták a écrit : > > [snip] > > PS3: What about documentation. Are you going to write also some desc. > of > WinAPI or not? I know there's MSDN, but not everyone can subscribe > it... > At least basic things like file IO, windowing, you know :) I have some > experiences with this, so I could help... The documentation on http://msdn.microsoft.com is quite accessible. If you know on which API you want some info, just type it's name in the search box, and you'll get a bunch of results. In my experience, some of the top results are often about WinCE, just skip them. Vincent

1 0

what's with WS_OVERLAPPED?
by Medland, Bill Aug. 14, 2002

Aug. 14, 2002

(Regarding the whole issue of windows reparenting) MSDN keeps going on about windows with the WS_OVERLAPPED style. However surely (since WS_OVERLAPPED=0) every window has such a style these days. Is there something I don't understand? Bill

2 1

Re: RESUBMIT: Quicken 2000 bug/Category blanking => Wine patch
by Dimitrie O. Paun Aug. 14, 2002

Aug. 14, 2002

On August 14, 2002 01:53 pm, Carl Sopchak wrote: > It was suggested to me that I should not use strlen(), since I'm not > positive if the string will ever really terminate (which may cause a seg > fault), so I programmed my own scan for a null character.. > > Here's the revised patch (attached). What about this: --- controls/edit.c 13 Jun 2002 19:20:43 -0000 1.95 +++ controls/edit.c 14 Aug 2002 17:49:13 -0000 @@ -3957,20 +3957,25 @@ */ static INT EDIT_WM_GetText(EDITSTATE *es, INT count, LPARAM lParam, BOOL unicode) { + INT ii; + if(!count) return 0; if(unicode) { LPWSTR textW = (LPWSTR)lParam; strncpyW(textW, es->text, count); - textW[count - 1] = 0; /* ensure 0 termination */ + for (ii = 0; (ii < count) & textW[ii]; i++) ; + textW[ii - 1] = 0; /* force 0 termination */ return strlenW(textW); } else { LPSTR textA = (LPSTR)lParam; WideCharToMultiByte(CP_ACP, 0, es->text, -1, textA, count, NULL, NULL); - textA[count - 1] = 0; /* ensure 0 termination */ + for (ii = 0; (ii < count) & textA[ii]; i++) ; + textA[ii - 1] = 0; /* force 0 termination */ return strlen(textA); } } Untested :) -- Dimi.

1 0

Am I the only one getting replies from RealNetworks?
by Medland, Bill Aug. 14, 2002

Aug. 14, 2002

I am getting messages from RealNetworks corresponding to each of my posts to wine-devel. I presume "Mysore Jaisimha" is on the mailing list but no longer works there. Can we do anything about it or do I just throw the messages away? Bill

2 1

RE: Re:can windows be reparented?
by Medland, Bill Aug. 14, 2002

Aug. 14, 2002

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] > Sent: Wednesday, August 14, 2002 9:34 AM > To: Medland, Bill > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > > > keep cc'ing wine-devel please Sorry; I just realised. It's the way I have Outlook set up; I get confused. > > "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > > > Could you please test patch posted by Bill Medland to > > > wine-patches today? It's > > > not entirely correct though. My tests show that > > > SetWindowLong(GWL_HWNDPARENT) > > > call changes simultaneously both parent and owner for top > > > level windows and > > > returns old value (not sure old owner or parent it is). > > > > Even if the window is not in fact a child? > > Yes. According to my test program. > > > Please excuse my ignorance here; > > I am still a little shaky on terminology. Surely if it is > a top level > > window then its parent is the desktop and always will be. > > > > Or are you saying that it reparents to the desktop (and so > the problem is > > down in the SetParent code)? > > I don't see a reparenting to desktop in the relay trace. > > > > But top level windows created by Visual Vasic are special: > > > they have no parent, > > > but only owner according to Spy++. In my tests I can't > > > reproduce it yet. > > > > So you suspect that Spy++ is not telling the truth? (It > wouldn't be the > > first time) > > I incline to trust Spy++ here. It correctly shows paerent/owner for my > test application playing with SetParent/SetWindowLong. It seems that > Windows always sets 0 in the parent field if the parent is > desktop. Even > after explicit SetParent(GetDesktopWindow()) or > SetWindowLong(GWL_HWNDPARENT, > GetDesktopWindow()) GetWindowLong(GWL_HWNDPARENT)/GetWindow(GW_OWNER) > return 0 in my tests. > > > > A bit of investigation of Wine source revealed that some > places use > > > GetAncestor(hwnd, GA_PARENT), while others use GetParent(hwnd). > > > > And, in the case of WIN_CreateWindowEx, GetAncestor (hwnd, GA_ROOT) > > > > > Since > > > their behaviour is different in respect of top level and > > > child windows, > > > some major clean up in that area in Wine is needed. > > > > Careful. > > > > In our particular case, according to Spy++ the owner of the > ThunderRT6FormDC > > is a third-generation window. viz. the actual window > requested, not one of > > its ancestors. > > > > i.e. I see the call to SetWindowLong (30056 (The > ThunderRT6FormDC), -8, > > 10046 (The ThunderRT6UserControlDC)) > > > > I guess an important point here is that in our case the > Visual Basic is an > > OCX sitting inside a container and so the > ThunderRT6UserControlDC is not > > first generation. > > Now I don't understand your terminology. parent - child - sibling are > the termings in the Windows world. Who of them was born > earlier matters > only when Z order and visibility are taken into account (and > can be easily > changed). Sorry; I am being unclear. I mean that (statically, according to Spy++, when the popup form is active) 1. The ThunderRT6FormDC which "is" the form has style WS_OVERLAPPED, no parent (i.e. the desktop) and owner is the ThunderRT6UserControlDC 2. The ThunderRT6UserControlDC which, I believe, "is" the ocx, has style WS_OVERLAPPED and no owner, but its parent is an ATL window 3. That ATL window's parent is another ATL window 4. That second ATL window has no parent. (So, by generations I am talking about the static parent relationship, independent of how it came to be; c.f. old people adopting young ones resulting in skipped generations) > > -- > Dmitry. > > > And I have just noticed the lie in MSDN. It says (Platform SDK - Windows User Interface - Owned windows) that once the window has been created, with an owner, you cannot change the owner. That has to be wrong. A propos. I think there is a related error in CreateWindowEx. At least it disagrees with MSDN. If passed a parent If this is a child set parent to the paremt passed in and leave the owner 0 else set the parent to the desktop and the owner to the GA_ROOT ancestor of the window passed in. Surely it should be (according to MSDN) if passed a parent if style includes WS_OVERLAPPED or WS_POPUP assert style does not include WS_CHILD if the parent is itself WS_OVERLAPPED or WS_POPUP parent is desktop and owner is the parent passed in else if the parent is a WS_CHILD then parent is desktop and owner is the GetAncestor(parent, GA_ROOT) else assert false? else assert WS_CHILD owner is 0 and parent is as specified Comments? One datum of use. In our particular case this fits; the ThunderRT6FormDC is WS_OVERLAPPED with no parent. Its owner is the ThunderRT6UserControlDC which also is WS_OVERLAPPED but has a parent. Bill

1 0

Re: CVS not building?
by jhurst＠ii.net Aug. 14, 2002

Aug. 14, 2002

I'm *really* sorry about the multiple messages! :( It seemed I jumped the gun and a manual removal of what i thought were problematic .o files did not resolve my build error! :( -jan On Thu, 2002-08-15 at 00:54, jhurst(a)ii.net wrote: > Hello, > > I just updated my CVS tree, and as several files seemed to have been > updated since my last CVS update I attempted to build a new wine. The > build fails with the error attached below. > > My questions are: > > 1. what is the "correct" way to (re)build wine when an existing wine has > previously been built? I have used ./tools/wineinstall previously (and > the attached error is a result). Is this correct? > > 2. Is there a problem with the files I have just pulled from CVS or have > I broken something on this end?! > > Regards, > > -jan > jhurst(a)ii.net > > --> snip <-- > make[2]: Entering directory `/usr/src/wine/dlls/urlmon' > LD_LIBRARY_PATH="../../library:../../unicode:$LD_LIBRARY_PATH" > ../../tools/winebuild/winebuild -fPIC -D__WINE__ -o urlmon.spec.c -spec > ./urlmon.spec urlmon.dll.tmp.o -L../../dlls -lole32 -lwininet -luser32 > -lkernel32 > ./urlmon.spec:1: could not open .so file for wininet.dll > make[2]: *** [urlmon.spec.c] Error 1 > make[2]: Leaving directory `/usr/src/wine/dlls/urlmon' > make[1]: *** [urlmon] Error 2 > make[1]: Leaving directory `/usr/src/wine/dlls' > make: *** [dlls] Error 2 > --> snip <--

1 0