September 2002 - Wine-Devel

GetCursorPos & NTCurrentTeb question
by Rick Romero Sept. 23, 2002

Sept. 23, 2002

I'm trying to track down the buttonup issue for Foxpro, and I've found an inconsistency, but I can't track it down. I started with GetCursorPos. It assigns PosX to pt->x, and PosY to pt->y, then calls X11drv.GetCursorPos, and assigns the current mouse coords to pt->x and pt->y. The problem is when the button is clicked, PosX and PosY retain the original values forever: A second or so after the left button is clicked: *Input.c current GetCursorPos (490,172) && (490,172) PosX,PosY && pt->X,pt->y *Button1Mask / state 256 / 16 (button is now up) *trace:cursor:X11DRV_GetCursorPos pointer at (489,186) (Where X says the pointer is) *-userdrivercall complete- (X11) Now: (490, 172)- 489,186- PosX,PosY && pt->X,pt->y (* my traces are just printf's) Even though the values are updated, they never get reassigned to PosX and PosY. I'm not sure WHERE that's supposed to happen, nor have I been able to figure out where GetCursorPos is called from. Is it possible that the values, and GetCursorPos are dealt with INTERNAL to MS FoxPro? I also am finding that the Wine server is returning Status Pending, then Status Timeout in WaitforMultipleObjectsEX in synchro.c. This happens a couple times when FoxPro starts up, but is eventually 'broken' out of. The Status_Pending triggers a call to wait_reply() in WaitforMultipleObjectsEx which does: ret = read( NtCurrentTeb()->wait_fd[0], &reply, sizeof(reply) ); GetCursorPos is called about 180 times before ret is set. I can't seem to find any reference to NTCurrentTeb in Wine (grep -nr), even though I found mention of it in the archive. Seems like an internal OS call. I don't know what's calling GetCursorPos, I don't know where pt->x gets assigned to PosX (but that's just a side effect, the mouse moves, it's the button that's stuck), and I don't know why wait_reply is getting a STATUS_TIMEOUT. Any ideas for me? Thanks, Rick

1 0

Re: Listview updates
by Dmitry Timoshkov Sept. 23, 2002

Sept. 23, 2002

"Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > @@ -1034,13 +1035,13 @@ > /* Update Vertical Scrollbar */ > nListHeight = infoPtr->rcList.bottom - infoPtr->rcList.top; > scrollInfo.fMask = SIF_POS; > - if (GetScrollInfo(infoPtr->hwndSelf, SB_VERT, &scrollInfo) == FALSE > + if (GetScrollInfo(infoPtr->hwndSelf, SB_VERT, &scrollInfo) Exclamation mark (!) is missing... -- Dmitry.

1 0

wininet test fails under Win2K SP3 - compiled with gcc 3.2
by Steven Edwards Sept. 23, 2002

Sept. 23, 2002

$ ./wininet_test.exe http http.c:86:Starting with flags 0x10000000 http.c:88:InternetOpenA <-- http.c:91:InternetOpenA --> http.c:95:InternetConnectA <-- http.c:74:Callback 00CC0004 0xdeadbeef INTERNET_STATUS_HANDLE_CREATED(60) 0022EB 34 4 http.c:98:InternetConnectA --> http.c:103:HttpOpenRequestA <-- http.c:74:Callback 00CC0008 0xdeadbead INTERNET_STATUS_HANDLE_CREATED(60) 0022ED A4 4 http.c:109:HttpOpenRequestA --> http.c:111:HttpSendRequestA --> http.c:118:HttpSendRequestA <-- http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESOLVING_NAME(10) 0119FB DC 15 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_NAME_RESOLVED(11) 0119FBC C 12 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTING_TO_SERVER(20) 0119FC48 12 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTED_TO_SERVER(21) 0 119FDDC 12 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_SENDING_REQUEST(30) 00000 000 0 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_SENT(31) 0119FD84 4 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RECEIVING_RESPONSE(40) 00 000000 0 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESPONSE_RECEIVED(41) 011 9FE04 4 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_COMPLETE(100) 011 9FE40 8 http.c:125:Option 0x17 -> 1 0 http.c:129:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:134:Option 0x16 -> 1 HTTP/1.1 200 OK Date: Mon, 23 Sep 2002 06:45:41 GMT Server: Apache/1.3.22 (Unix) (Red-Hat/Linux) mod_ssl/2.8.5 OpenSSL/0.9.6 PHP/4. 1.2 X-Powered-By: PHP/4.1.2 Keep-Alive: timeout=15, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/html http.c:139:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:143:Option 0x5 -> 0 http://www.winehq.com/about/ (12150) http.c:148:Option 0x1 -> 1 text/html http.c:151:Entery Query loop http.c:168:ReadFile -> 1 743 http.c:168:ReadFile -> 1 7728 http.c:157: Test failed: InternetQueryDataAvailable failed http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_COMPLETE(100) 011 9FE40 8 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CLOSING_CONNECTION(50) 00 000000 0 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTION_CLOSED(51) 000 00000 0 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_HANDLE_CLOSING(70) 0022ED 5C 4 http.c:74:Callback 00CC0008 0xdeadbeef INTERNET_STATUS_HANDLE_CLOSING(70) 0022ED 8C 4 http.c:176: Test failed: InternetCloseHandle failed http.c:86:Starting with flags 0x0 http.c:88:InternetOpenA <-- http.c:91:InternetOpenA --> http.c:95:InternetConnectA <-- http.c:74:Callback 00CC0004 0xdeadbeef INTERNET_STATUS_HANDLE_CREATED(60) 0022EB 34 4 http.c:98:InternetConnectA --> http.c:103:HttpOpenRequestA <-- http.c:74:Callback 00CC0008 0xdeadbead INTERNET_STATUS_HANDLE_CREATED(60) 0022ED A4 4 http.c:109:HttpOpenRequestA --> http.c:111:HttpSendRequestA --> http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTING_TO_SERVER(20) 0022EBEC 12 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTED_TO_SERVER(21) 0 022EBC8 12 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_SENDING_REQUEST(30) 00000 000 0 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_SENT(31) 0022ECD0 4 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RECEIVING_RESPONSE(40) 00 000000 0 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESPONSE_RECEIVED(41) 002 2ECB4 4 http.c:118:HttpSendRequestA <-- http.c:125:Option 0x17 -> 1 0 http.c:129:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:134:Option 0x16 -> 1 HTTP/1.1 200 OK Date: Mon, 23 Sep 2002 06:45:41 GMT Server: Apache/1.3.22 (Unix) (Red-Hat/Linux) mod_ssl/2.8.5 OpenSSL/0.9.6 PHP/4. 1.2 X-Powered-By: PHP/4.1.2 Keep-Alive: timeout=15, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/html http.c:139:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:143:Option 0x5 -> 0 http://www.winehq.com/about/ (12150) http.c:148:Option 0x1 -> 1 text/html http.c:151:Entery Query loop http.c:168:ReadFile -> 1 743 http.c:168:ReadFile -> 1 436 http.c:168:ReadFile -> 1 3728 http.c:168:ReadFile -> 1 644 http.c:168:ReadFile -> 1 3736 http.c:168:ReadFile -> 1 2097 http.c:168:ReadFile -> 1 403 http.c:74:Callback 00CC000C 0xdeadbead INTERNET_STATUS_HANDLE_CLOSING(70) 0022ED 5C 4 http.c:74:Callback 00CC0008 0xdeadbeef INTERNET_STATUS_HANDLE_CLOSING(70) 0022ED 8C 4 http.c:176: Test failed: InternetCloseHandle failed http: 23 tests executed, 0 marked as todo, 3 failures. Administrator(a)PH33R /g/src/wine-dev/wine/dlls/wininet/tests $

1 0

Re: ASIO and wine
by Thomas Wickline Sept. 23, 2002

Sept. 23, 2002

Tom Hibbert wrote: >On Sun, Sep 22, 2002 at 11:44:53AM -0400, Thomas Wickline wrote: > > >>Cubase will not run with wine as it need's VxD support .. >>ASIO (Audio Stream Input Output) needs Communication between >>audio software and a piece of audio hardware and this is where >>the VxD problem comes in .. >> >>Can someone here confirm this ?? >> >>Tom >> >> > > >Cubase SX is pure 32bit.. i would have thought it didnt use VxDs which >AFAIK were obseleted with win2k... > > I am not 100% sure this was only my thoughts of what would/could happen .. That is why I ask for someone else to confirm . Tom

1 0

email to webmaster@winehq.com dead?
by Andreas Schuldei Sept. 22, 2002

Sept. 22, 2002

i and others have mailed to webmaster(a)winehq.com to report changes in the daily wine builds for debian. (it was about the fact that i should not read gluck.debian.org but people.debian.org in the apt/sources.list lines) that has been quite a while. i do still get mails by confused users which do not know how to fix their download of wine packages. could someone fix that, please?

1 0

Re: FD_ZERO and FD_SET problems.
by Michael Stefaniuc Sept. 22, 2002

Sept. 22, 2002

Could you please resubmit it as unified diff (diff -u)? The diff's are more readable and are more robust regarding to changes in the target file. bye michael On Fri, Sep 20, 2002 at 08:10:41PM -1000, Patrick J. McNerthney wrote: > I hope I am doing this correctly. I am porting some Win32 software > using WineLib and ran into some problems with the WinSock headers, > specifically with regards to the use of FD_ZERO and FD_SET (they just > wouldn't compile at all). Attached is the patch that resolved my > problems. > > ChangeLog > Fixed if statement in __WS_FD_SET2 which did not have it's outer set > of parenthesis. > Removed parentheses around type to be cast in __WS_FD_SET macro. > Removed WS macro usage from within other macros because the WS macro > is undefined when these macros are expanded. > > Pat McNerthney > Icicle Software, Inc. -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

ASIO and wine
by Tom Hibbert Sept. 22, 2002

Sept. 22, 2002

Hello, I am very interested in creating a home studio system with Linux. I get 1/4 the latency i do using Windows with the same hardware.. there is more control.. etc etc.. there are many reasons why I want to do this. I would especially like to use Cubase SX. The main barrier hampering this (besides copy protection ;) is the lack of ASIO support under Wine. Secondly, timing issues, but that is easy to tweak by the user. I am wondering if there are any progects or plans to implement ASIO in Wine/WineX. If so, I would like to contribute. If not, I will have to go to university and study computer science as well as electronic music. ;) Oh, yes - i know there are a lot of quality open source audio products (Audacity, Psycle, Csound, MAX/MSP come to mind...) I am mainly interested in seeing some VST implementation on Linux because VST is a very widely used and mature base for software synthesisers and effects. I'm told the only barrier to a NATIVE VST-capable app (Yes, the code is all there in the Audacity sources AFAIK) is the porting of a library known as libvstgui... why not run this through Winelib is the next thing i am going to ask the developers of that particular product :) Tom Hibbert Work: someday Home: +649 815 1838 Obtain my GPG Key from: http://cryptocracy.hn.org/pubkey.txt

2 2

Re: fix listview trace crash
by Dimitrie O. Paun Sept. 22, 2002

Sept. 22, 2002

On September 21, 2002 02:46 am, Rein Klazes wrote: > Hi, > > With these fixes the original reason to debug disappeared as well ;-) > > dlls/comctl32/ : listview.c > Fix some crashes running with --debugmsg +listview > + ZeroMemory(&item, sizeof(item)); We shouldn't need these. In fact, they just hide bugs, and most of them are superfluous anyways. The first hunk is a good find though, I've integrated it in my patch. Alexandre, please use this one instead. ChangeLog -- Fix outputing of a text pointer in debug mode (by Rein Klazes) -- Remove a large bunch of superfluous ZeroMemory calls -- Fix couple of bugs Index: dlls/comctl32/listview.c =================================================================== RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.148 diff -u -r1.148 listview.c --- dlls/comctl32/listview.c 18 Sep 2002 18:29:28 -0000 1.148 +++ dlls/comctl32/listview.c 21 Sep 2002 15:08:20 -0000 @@ -337,7 +337,7 @@ wstr = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); if (wstr) MultiByteToWideChar(CP_ACP, 0, (LPCSTR)text, -1, wstr, len); } - TRACE(" wstr=%s\n", debugstr_w(wstr)); + TRACE(" wstr=%s\n", text == LPSTR_TEXTCALLBACKW ? "(callback)" : debugstr_w(wstr)); return wstr; } @@ -423,7 +423,7 @@ " pszText=%s, cchTextMax=%d, iImage=%d, lParam=%lx, iIndent=%d}", lpLVItem->mask, lpLVItem->iItem, lpLVItem->iSubItem, lpLVItem->state, lpLVItem->stateMask, - debugtext_tn(lpLVItem->pszText, isW, 80), + lpLVItem->mask & LVIF_TEXT ? debugtext_tn(lpLVItem->pszText, isW, 80) : 0, lpLVItem->cchTextMax, lpLVItem->iImage, lpLVItem->lParam, lpLVItem->iIndent); return buf; @@ -605,6 +605,7 @@ BOOL bReturn; item.iItem = iItem; + item.iSubItem = 0; item.mask = LVIF_PARAM; LISTVIEW_GetItemT(infoPtr, &item, TRUE, TRUE); @@ -865,7 +866,6 @@ } /* get item */ - ZeroMemory(&item, sizeof(item)); item.mask = LVIF_TEXT; item.iItem = idx; item.iSubItem = 0; @@ -1557,7 +1557,6 @@ if (adj_sel_only) return TRUE; /* set the selection on items */ - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.state = LVIS_SELECTED; lvItem.stateMask = LVIS_SELECTED; for(i = lower; i <= upper; i++) @@ -1576,7 +1575,7 @@ LVITEMW lvItem; INT index, i; - ZeroMemory(&lvItem, sizeof(lvItem)); + lvItem.state = 0; lvItem.stateMask = LVIS_SELECTED; remsel.lower = lower; @@ -1734,7 +1733,6 @@ INT oldFocus = infoPtr->nFocusedItem; LVITEMW lvItem; - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.state = LVIS_FOCUSED; lvItem.stateMask = LVIS_FOCUSED; LISTVIEW_SetItemState(infoPtr, nItem, &lvItem); @@ -1830,8 +1828,8 @@ if (nFirst == -1) nFirst = nItem; - item.stateMask = LVIS_SELECTED; item.state = LVIS_SELECTED; + item.stateMask = LVIS_SELECTED; /* FIXME: this is not correct LVS_OWNERDATA * See docu for LVN_ITEMCHANGED. Is there something similar for @@ -1889,8 +1887,6 @@ POINT ptItem; RECT rcSel; - item.stateMask = LVIS_SELECTED; - if ((uView == LVS_LIST) || (uView == LVS_REPORT)) { if (infoPtr->nSelectionMark == -1) @@ -1910,6 +1906,8 @@ nFirst = nLast = -1; } + item.stateMask = LVIS_SELECTED; + for (i = 0; i <= GETITEMCOUNT(infoPtr); i++) { if (nFirst > -1) @@ -2397,8 +2395,6 @@ lpSubItem = (LISTVIEW_SUBITEM *)COMCTL32_Alloc(sizeof(LISTVIEW_SUBITEM)); if (!lpSubItem) return FALSE; - ZeroMemory(lpSubItem, sizeof(LISTVIEW_SUBITEM)); - /* we could binary search here, if need be...*/ for (i = 1; i < hdpaSubItems->nItemCount; i++) { @@ -2692,7 +2688,6 @@ TRACE("(hdc=%x, nItem=%d)\n", hdc, nItem); /* get information needed for drawing the item */ - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.mask = LVIF_TEXT | LVIF_IMAGE | LVIF_STATE | LVIF_INDENT; lvItem.stateMask = LVIS_SELECTED | LVIS_STATEIMAGEMASK; lvItem.iItem = nItem; @@ -2874,7 +2869,6 @@ hdc, nItem, rcItem.left, rcItem.top, rcItem.right, rcItem.bottom); /* get information needed for drawing the item */ - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.mask = LVIF_TEXT | LVIF_IMAGE | LVIF_STATE; lvItem.stateMask = LVIS_SELECTED | LVIS_FOCUSED; lvItem.iItem = nItem; @@ -3752,7 +3746,7 @@ /* remove it from the selection range */ - ZeroMemory(&item,sizeof(item)); + item.state = LVIS_SELECTED; item.stateMask = LVIS_SELECTED; LISTVIEW_SetItemState(infoPtr,nItem,&item); @@ -3858,10 +3852,10 @@ else { ZeroMemory(&lvItemRef,sizeof(LISTVIEW_ITEM)); - ZeroMemory(&item,sizeof(item)); item.iItem = nItem; item.iSubItem = 0; item.mask = LVIF_PARAM | LVIF_STATE; + item.stateMask = ~0; ListView_GetItemW(infoPtr->hwndSelf, &item); lvItemRef.hdr.iImage = item.iImage; lvItemRef.state = item.state; @@ -3873,7 +3867,7 @@ dispInfo.item.mask = 0; dispInfo.item.iItem = nItem; dispInfo.item.state = lpItem->state; - dispInfo.item.stateMask = 0; + dispInfo.item.stateMask = 0; /* FIXME: why not copy the state mask in here? */ dispInfo.item.pszText = pszText; dispInfo.item.cchTextMax = textlenT(pszText, isW); dispInfo.item.iImage = lpItem->hdr.iImage; @@ -3940,11 +3934,10 @@ else { LVITEMW item; - ZeroMemory(&lvItemRef,sizeof(LISTVIEW_ITEM)); - ZeroMemory(&item, sizeof(item)); item.iItem = nItem; item.iSubItem = 0; item.mask = LVIF_PARAM | LVIF_STATE; + item.stateMask = ~0; ListView_GetItemW(infoPtr->hwndSelf, &item); lvItemRef.hdr.iImage = item.iImage; lvItemRef.state = item.state; @@ -3953,7 +3946,6 @@ } /* get information needed for drawing the item */ - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.mask = LVIF_TEXT; lvItem.iItem = nItem; lvItem.iSubItem = 0; @@ -3966,7 +3958,7 @@ dispInfo.item.mask = 0; dispInfo.item.iItem = nItem; dispInfo.item.state = lpItem->state; - dispInfo.item.stateMask = 0; + dispInfo.item.stateMask = 0; /* FIXME: why not copy the state mask in here? */ dispInfo.item.pszText = lvItem.pszText; dispInfo.item.cchTextMax = lstrlenW(lvItem.pszText); dispInfo.item.iImage = lpItem->hdr.iImage; @@ -4218,8 +4210,6 @@ if ((nItem >= -1) && (lpFindInfo != NULL)) { - ZeroMemory(&lvItem, sizeof(lvItem)); - if (lpFindInfo->flags & LVFI_PARAM) { lvItem.mask |= LVIF_PARAM; @@ -5131,7 +5121,6 @@ if (uView & LVS_REPORT) { - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.mask = LVIF_INDENT; lvItem.iItem = nItem; lvItem.iSubItem = 0; @@ -5544,9 +5533,9 @@ TRACE("(nItem=%d)\n", nItem); - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.mask = LVIF_TEXT; lvItem.iItem = nItem; + lvItem.iSubItem = 0; lvItem.cchTextMax = DISP_TEXT_SIZE; lvItem.pszText = szDispText; if (LISTVIEW_GetItemW(infoPtr, &lvItem, TRUE)) @@ -5603,10 +5592,10 @@ if ((nItem >= 0) && (nItem < GETITEMCOUNT(infoPtr))) { - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.iItem = nItem; - lvItem.stateMask = uMask; + lvItem.iSubItem = 0; lvItem.mask = LVIF_STATE; + lvItem.stateMask = uMask; if (LISTVIEW_GetItemW(infoPtr, &lvItem, TRUE)) uState = lvItem.state & uMask; } @@ -6352,8 +6341,6 @@ if ( !(lpItem = (LISTVIEW_ITEM *)COMCTL32_Alloc(sizeof(LISTVIEW_ITEM))) ) return -1; - ZeroMemory(lpItem, sizeof(LISTVIEW_ITEM)); - /* insert item in listview control data structure */ if ( (hdpaSubItems = DPA_Create(8)) ) nItem = DPA_InsertPtr(hdpaSubItems, 0, lpItem); @@ -6718,7 +6705,6 @@ } else { - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.iSubItem = iCol; lvItem.mask = LVIF_TEXT; lvItem.cchTextMax = DISP_TEXT_SIZE; @@ -6783,7 +6769,6 @@ SelectObject(hdc, old_font); /* restore the old font */ ReleaseDC(infoPtr->hwndSelf, hdc); - ZeroMemory(&lvItem, sizeof(lvItem)); lvItem.iSubItem = iCol; lvItem.mask = LVIF_TEXT; lvItem.cchTextMax = DISP_TEXT_SIZE; @@ -7190,14 +7175,13 @@ BOOL bResult = TRUE; LVITEMW lvItem; - TRACE("(nItem=%d, lpLVItem=%s)\n", - nItem, debuglvitem_t(lpLVItem, TRUE)); + TRACE("(nItem=%d, lpLVItem=%s)\n", nItem, debuglvitem_t(lpLVItem, TRUE)); - ZeroMemory(&lvItem, sizeof(lvItem)); + lvItem.iItem = nItem; + lvItem.iSubItem = 0; lvItem.mask = LVIF_STATE; lvItem.state = lpLVItem->state; lvItem.stateMask = lpLVItem->stateMask ; - lvItem.iItem = nItem; if (nItem == -1) { @@ -7227,24 +7211,18 @@ */ static BOOL LISTVIEW_SetItemTextT(LISTVIEW_INFO *infoPtr, INT nItem, LPLVITEMW lpLVItem, BOOL isW) { - BOOL bResult = FALSE; - LVITEMW lvItem; + LVITEMW lvItem; - TRACE("(nItem=%d, lpLVItem=%s, isW=%d)\n", - nItem, debuglvitem_t(lpLVItem, isW), isW); + TRACE("(nItem=%d, lpLVItem=%s, isW=%d)\n", nItem, debuglvitem_t(lpLVItem, isW), isW); - if ((nItem >= 0) && (nItem < GETITEMCOUNT(infoPtr))) - { - ZeroMemory(&lvItem, sizeof(LVITEMW)); - lvItem.mask = LVIF_TEXT; - lvItem.pszText = lpLVItem->pszText; + if ((nItem < 0) && (nItem >= GETITEMCOUNT(infoPtr))) return FALSE; + lvItem.iItem = nItem; lvItem.iSubItem = lpLVItem->iSubItem; - if(isW) bResult = ListView_SetItemW(infoPtr->hwndSelf, &lvItem); - else bResult = ListView_SetItemA(infoPtr->hwndSelf, &lvItem); - } - - return bResult; + lvItem.mask = LVIF_TEXT; + lvItem.pszText = lpLVItem->pszText; + + return LISTVIEW_SetItemT(infoPtr, &lvItem, isW); } /*** @@ -7489,7 +7467,6 @@ if (!infoPtr) return -1; SetWindowLongW(hwnd, 0, (LONG)infoPtr); - ZeroMemory(infoPtr, sizeof(LISTVIEW_INFO)); infoPtr->hwndSelf = hwnd; /* determine the type of structures to use */ @@ -8097,9 +8074,8 @@ bGroupSelect = (LISTVIEW_GetItemState(infoPtr, nItem, LVIS_SELECTED) == 0); - ZeroMemory(&item, sizeof(item)); + item.state = bGroupSelect ? LVIS_SELECTED : 0; item.stateMask = LVIS_SELECTED; - if(bGroupSelect) item.state = LVIS_SELECTED; LISTVIEW_SetItemState(infoPtr, nItem, &item); LISTVIEW_SetItemFocus(infoPtr, nItem);

2 3

Patch - stub and workaround to make wineserver compile on cygwin
by Steven Edwards Sept. 22, 2002

Sept. 22, 2002

This will allow you to run wineserver on cygwin. We still lack tons of stuff before we can have a WINE that really works on Cygwin but over the next few months/years++ as I am learning, I will keep working on this. Changelog: Wineserver - Stub get/set_thread_context in wineserver so it will build/run Change permission error to a Warning when running on Windows/Cygwin Index: context_i386.c =================================================================== RCS file: /home/wine/wine/server/context_i386.c,v retrieving revision 1.23 diff -u -r1.23 context_i386.c --- context_i386.c 14 Aug 2002 20:59:03 -0000 1.23 +++ context_i386.c 22 Sep 2002 03:19:41 -0000 @@ -460,9 +460,24 @@ file_set_error(); } -#else /* linux || __sun__ || __FreeBSD__ */ +#elif defined(__MINGW__) || defined(__CYGWIN__) || defined(_WINDOWS) + +/* retrieve a thread context */ +static void get_thread_context( struct thread *thread, unsigned int flags, CONTEXT *context ) +{ + printf("get_thread_context is a stub on WINDOWS!\n"); + return 0; +} + +static void set_thread_context( struct thread *thread, unsigned int flags, const CONTEXT *context ) +{ + printf("get_thread_context is a stub on WINDOWS!\n"); + return 0; +} + +#else /* linux || __sun__ || __FreeBSD__ || _WINDOWS */ #error You must implement get/set_thread_context for your platform -#endif /* linux || __sun__ || __FreeBSD__ */ +#endif /* linux || __sun__ || __FreeBSD__ || _WINDOWS */ /* copy a context structure according to the flags */ Index: request.c =================================================================== RCS file: /home/wine/wine/server/request.c,v retrieving revision 1.67 diff -u -r1.67 request.c --- request.c 16 Aug 2002 20:02:15 -0000 1.67 +++ request.c 22 Sep 2002 03:21:04 -0000 @@ -483,7 +483,11 @@ } if (!S_ISDIR(st->st_mode)) fatal_error( "%s is not a directory\n", name ); if (st->st_uid != getuid()) fatal_error( "%s is not owned by you\n", name ); +#if defined(__MINGW__) || defined(__CYGWIN__) || defined(_WINDOWS) + fprintf( stderr, "Warning: %s is accessible by other users\n", name ); +#else if (st->st_mode & 077) fatal_error( "%s must not be accessible by other users\n", name ); +#endif /* defined(__MINGW__) || defined(__CYGWIN__) || defined(_WINDOWS) */ } /* create the server directory and chdir to it */

1 0

Re: wine status page
by Brian Vincent Sept. 22, 2002

Sept. 22, 2002

> that's ok. I've just uploaded your file to winehq > it's up (& running). thanx for your good work If someone wants to forward me the raw HTML I'll edit it to include WWN threads. -brian

4 4