January 2003 - Wine-Devel - list.winehq.org

Re: Add filesytem type NTFS to config
by Mike Hearn Jan. 14, 2003

Jan. 14, 2003

Just curious tony, but if that's the case why doesn't Wine return NTFS all the time? Are there some apps that actually won't run if it returns NTFS at all? On Tue, 2003-01-14 at 04:06, Tony Lambregts wrote: > Some program (VirtualDub) checks the fsname returned by > GetVolumeInformation, to find the name of the file system, when it needs > to write files that are larger than 2GB. It refuses to create the file > when we return FAT but will successfully write the file when NTSF is > returned. > > Change Log: add configuration option to report NTFS as the file system > type for a drive. > > Files changed: documentation/samples/config > documnetation/configuring.sgml > files/drive.c -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

1 0

Re: patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by Dimitrie O. Paun Jan. 14, 2003

Jan. 14, 2003

On January 13, 2003 09:02 pm, liu spider wrote: > (The patch seems to be ignored without any comments. > Could anyone give some clues on how to improve this > patch? thanks.) If no one complained, it's probably OK until Alexandre gets around to it. He can't reply in real time, wait for a few days. If you see commits going in (subscribe to, or check the mail archives for wine-cvs(a)winehq.org to monitor the checkins) and yours is not applied, email and ask him what's up. -- Dimi.

2 1

[D3D status] Page update...
by Lionel Ulmer Jan. 14, 2003

Jan. 14, 2003

Hi all, I updated the D3D status page (http://www.bbrox.org/d3d_status.html) with some new screenshots and some new demos. Nothing revolutionnary though :-) Thanks to Christian for the 3D Mark 2000 paragraph. Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Wine, Mozilla & IE ?
by Juan Rey Saura Jan. 14, 2003

Jan. 14, 2003

Hi ! I've read in the list there is a project about compiling Mozilla under Wine, I think it would be great. Several parts of wine need an IWebBrowser implemtation; CHM support, some applications... One implementation based on the khtml is in the works, but Mozilla does implement it yet ( see http://www.iol.ie/~locka/mozilla/mozilla.htm ). Could Mozilla, under Wine or maybe native version, be used as a replacement for the IE IWebBrowser implementation?

10 18

WineMine wrc error
by John Westerman Jan. 14, 2003

Jan. 14, 2003

Hi, I seem to have a bit of trouble building the winemine sample. When it gets to the wrc stage it just says: make: *** [rsrc.res] Error 1 Any ideas?

1 0

Re: distcc and wine
by Martin Pool Jan. 14, 2003

Jan. 14, 2003

On 8 Jan 2003, Paul Millar <paulm(a)astro.gla.ac.uk> wrote: > Hi Martin, > > On a similar note, I've been investigating OpenMOSIX on and off (mostly > off) for doing distributed compiling. In general, I've found it not > particularly stable (although its improving) and the performance not > particularly great -- although I've not had time to investigate the causes > of these problems. Besides, compiling code is quite a tricky task for it > to schedule/migrate. I haven't tried it myself but I would have expected the short, intense jobs generated by compilation to be a problem. > A reduction in compilation time by a factor of 2.6 (for three machines) > isn't bad at all! > > If you have the time, could you repeat this with different values for the > -j option? Timing how long it takes with -j2 (and perhaps -j3 and -j4) > would be interesting. Yes, I've been meaning to add that to the benchmark tool. I'll let you know. > Also, repeat the compilation several times for each value of -j and taking > the mean and standard deviation would be interesting too. In informal measurements it seems to be quite reproducible. The sd is typically only a few percent of the overall time. But that might be an interesting option to add too. -- Martin

2 2

Re: prevent dereferencing null
by Dimitrie O. Paun Jan. 14, 2003

Jan. 14, 2003

On January 9, 2003 07:08 pm, Bill Medland wrote: > + if (!tpinfo->chanbuf) { > + ERR("tpinfo has no Rpc Channel Buffer\n"); > + return 0; > + } Is this expected behaviour? If so, there's no need for the ERR msg. If not, there's no need for the test, we need to fix the root cause... -- Dimi.

3 4

patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by liu spider Jan. 14, 2003

Jan. 14, 2003

Thanks to Dmitry Timoshkov. This patch is the second edition, adopted his suggestions. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW GetFileTitleA now is a call to GetFileTitleW (The patch seems to be ignored without any comments. Could anyone give some clues on how to improve this patch? thanks.) liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com Index: dlls/commdlg/filetitle.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/filetitle.c,v retrieving revision 1.12 diff -u -r1.12 filetitle.c --- dlls/commdlg/filetitle.c 31 May 2002 23:25:45 -0000 1.12 +++ dlls/commdlg/filetitle.c 12 Jan 2003 07:09:56 -0000 @@ -3,6 +3,7 @@ * * Copyright 1994 Martin Ayotte * Copyright 1996 Albrecht Kleine + * Copyright 2003 liuspider * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -24,10 +25,10 @@ #include "winbase.h" #include "winnls.h" #include "commdlg.h" +#include "wine/unicode.h" +#include "winternl.h" #include "wine/debug.h" -#include "heap.h" /* Has to go */ - WINE_DEFAULT_DEBUG_CHANNEL(commdlg); #include "cdlg.h" @@ -38,19 +39,39 @@ */ short WINAPI GetFileTitleA(LPCSTR lpFile, LPSTR lpTitle, UINT cbBuf) { - int i, len; + int ret; + UNICODE_STRING strWFile, strWTitle; + RtlCreateUnicodeStringFromAsciiz(&strWFile, lpFile); + RtlCreateUnicodeStringFromAsciiz(&strWTitle,lpTitle); + ret = GetFileTitleW(strWFile.Buffer, strWTitle.Buffer, cbBuf * sizeof(WCHAR)); + if (!ret){ + WideCharToMultiByte( CP_ACP, 0, strWTitle.Buffer, -1, lpTitle, cbBuf, NULL, NULL ); + } + RtlFreeUnicodeString( &strWFile ); + RtlFreeUnicodeString( &strWTitle ); + return ret; +} + +/*********************************************************************** + * GetFileTitleW (COMDLG32.@) + * + */ +short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) +{ + int i, len; + WCHAR brkpoint[] = {'*','[',']'}; TRACE("(%p %p %d); \n", lpFile, lpTitle, cbBuf); if(lpFile == NULL || lpTitle == NULL) return -1; - len = strlen(lpFile); + len = strlenW(lpFile); if (len == 0) return -1; - if(strpbrk(lpFile, "*[]")) + if(strpbrkW(lpFile, brkpoint)) return -1; len--; @@ -70,34 +91,14 @@ if(i == -1) i++; - TRACE("---> '%s' \n", &lpFile[i]); + TRACE("---> '%s' \n", debugstr_w(&lpFile[i])); - len = strlen(lpFile+i)+1; + len = strlenW(lpFile+i)+1; if(cbBuf < len) return len; - strncpy(lpTitle, &lpFile[i], len); + strncpyW(lpTitle, &lpFile[i], len); return 0; -} - - -/*********************************************************************** - * GetFileTitleW (COMDLG32.@) - * - */ -short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) -{ - LPSTR file = HEAP_strdupWtoA(GetProcessHeap(), 0, lpFile); /* Has to go */ - LPSTR title = HeapAlloc(GetProcessHeap(), 0, cbBuf); - short ret; - - ret = GetFileTitleA(file, title, cbBuf); - - if (cbBuf > 0 && !MultiByteToWideChar( CP_ACP, 0, title, -1, lpTitle, cbBuf )) - lpTitle[cbBuf-1] = 0; - HeapFree(GetProcessHeap(), 0, file); - HeapFree(GetProcessHeap(), 0, title); - return ret; }

1 0

Re: tests for GetPrinterDriverDirectoryA
by Francois Gouget Jan. 14, 2003

Jan. 14, 2003

On Mon, 13 Jan 2003, Stefan Leichter wrote: > Am Montag 13 Januar 2003 18:42 schrieben Sie: > > On Sun, 12 Jan 2003, Stefan Leichter wrote: > > > Am Sonntag 12 Januar 2003 02:43 schrieben Sie: [...] > > > > However it fails on Wine: > > > > info.c:25: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:30: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:34: Test failed: expected result == 0, got 18 > > > > info.c:35: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:48: Test failed: expected result != 0, got 0 > > > > info.c:71: Test failed: expected result != 0, got 0 > > after this patch wine will fix the errors listed above Yep, that works. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

Re: Help with /?? stuff
by Alberto Massari Jan. 13, 2003

Jan. 13, 2003

At 20.24 10/01/2003 +0200, Shachar Shemesh wrote: >Alberto Massari wrote: > >[...] >> >>BTW, do you need any help on this task? > >"Need" is a strong term. I can complete the task on my own, but your help >will be most welcome (in other words, if there is another aread of Wine >that needs your attention and noone seems to be working on, that would be >a better use of everyone's time). If you want to help with wineboot, I >think the best place to start is with the "win.ini" processing, and then >to port Andy's function to run whole "run" keys to the new prog. > >If you do decide to help with wineboot, please email me in private when >starting to work on each activity, to prevent "competition" on writing >stuff in. Unfortunately I'm currently fully booked on trying to fix the bugs that prevent ole32 and shell32 from working with IE6; but installing IE6 needs a working wineboot, so, whenever I succeed in the first task, I will start working on wineboot. Alberto

3 11

what does __leave do?
by Greg Turner Jan. 13, 2003

Jan. 13, 2003

Could someone run the following code under a microsoft compiler for me, and let me know the result? main() { int x = 0; __try { x = 1; __leave; } __finally { x = 2; } printf("x was %d\n", x); } thanks, -- gmt "If everyone is thinking alike then somebody isn't thinking." --George S. Patton

2 2

Sysparams registry tests
by Francois Gouget Jan. 13, 2003

Jan. 13, 2003

Here are the failing user32/sysparams registry tests on Win95, Win98 and NT4. sysparams.c:676:testing SPI_{GET,SET}MENUDROPALIGNMENT sysparams.c:161: Test failed: Wrong value in registry: subKey=Software\Microsoft\Windows NT\CurrentVersion\Windows, valName=MenuDropAlignment, testValue=1, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Software\Microsoft\Windows NT\CurrentVersion\Windows, valName=MenuDropAlignment, testValue=0, value= -> on Win9x this is in Control Panel\desktop sysparams.c:711:testing SPI_{GET,SET}DOUBLECLKWIDTH sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickWidth, testValue=0, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickWidth, testValue=10000, value= -> on Win9x this is in Control Panel\desktop sysparams.c:741:testing SPI_{GET,SET}DOUBLECLKHEIGHT sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickHeight, testValue=0, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickHeight, testValue=10000, value= -> on Win9x this is in Control Panel\desktop sysparams.c:644:testing SPI_{GET,SET}ICONTITLEWRAP sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Desktop\WindowMetrics, valName=IconTitleWrap, testValue=1, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Desktop\WindowMetrics, valName=IconTitleWrap, testValue=0, value= -> on NT4 this is in Control Panel\Desktop Notice how this is not even a clean separation between NT OSes and Win9x ones: Win9x aligns with XP for SPI_SETICONTITLEWRAP but not NT4, while for the other settings it's the opposite. Anyway, is it worth keeping these tests? That is making sure that SPI_xxx stores the setting in the registry key we expect? Do we know of applications that depend on these specific settings? If not then I will just submit a patch to remove these checks. Or maybe Wine should store these settings in all known locations? Note that I already removed these tests for SPI_ICONHORIZONTALSPACING and SPI_ICONVERTICALSPACING because for these Windows does not even always store the same value: sometimes it's the value we provide but most of the time that value seems to be multiplied by -15 (resulting in the negative number!). And the -15 changes to anothe value if you change the icon size. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

1 0

Re: user32.SendMessageCallback
by Alexandre Julliard Jan. 13, 2003

Jan. 13, 2003

"Robert Shearman" <R.J.Shearman(a)warwick.ac.uk> writes: > ChangeLog: > - Fix SendMessageCallback so that it works in all cases now You can't do it that way, the callback has to be called in the context of the thread that sent the message. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: tests for GetPrinterDriverDirectoryA
by Francois Gouget Jan. 13, 2003

Jan. 13, 2003

On Tue, 7 Jan 2003, Stefan Leichter wrote: > Hello, > > here are some tests for GetPrinterDriverDirectoryA. They should pass on NT4 > and hopefully win95 too. Thanks to Francois Gouget for testing. I see this test has not been committed yet... I tested it and it works on Win95, Win98, NT4 and XP. It's a much better score than some other tests... However it fails on Wine: info.c:25: Test failed: pcbNeeded set to 18 instead of 19 info.c:30: Test failed: pcbNeeded set to 18 instead of 19 info.c:34: Test failed: expected result == 0, got 18 info.c:35: Test failed: pcbNeeded set to 18 instead of 19 info.c:48: Test failed: expected result != 0, got 0 info.c:71: Test failed: expected result != 0, got 0 The easy solution is to just wrap the relevant tests in a 'todo_wine'. The better one is to fix Wine... Or if the fix is too long to do, wrap with todo_wine now so the test can be committed now, and then fix Wine and remove the relevant todo_wine statements after each fix. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

2 2

Re: Re: The version info patches + d3d question
by fenix＠club-internet.fr Jan. 13, 2003

Jan. 13, 2003

----Message d'origine---- >Date: Mon, 13 Jan 2003 16:04:10 +0100 >De: Lionel Ulmer <lionel.ulmer(a)free.fr> >A: fenix(a)club-internet.fr >Copie à: farmboy1(a)subdimension.com, wine-devel(a)winehq.com >Sujet: Re: The version info patches + d3d question > >> >the problem is they dont run even with the patches because they cant get >> >version info from d3dim.dll and probably other d3d dlls. >> >since wine doesnt have these dlls how can wine give these programs the needed >> >info or is it planned to split ddraw in a ddraw and a d3d component? >> >> actually, we are speaking about d3d architecture, but it will be possible to implement d3dim.dll (minors d3d calls) into near future using the "new" codebase. >> And d3d component (for version 3..7) is contained into ddraw.dll > >I don't even know WHAT d3dim.dll is :-) What does it contain for API ? d3dim.dll - D3DFree - D3DMalloc - D3DRealloc - Direct3DCreateDevice - Direct3DCreateTexture - Direct3DGetSWRastZPixFmts - Direct3DCreate - Direct3D_HALCleanUp - FlushD3DDevices2 - FlushD3DDevices - PaletteAssociateNotify - PaletteUpdateNotify - SurfaceFlipNotify d3dim700.dll - D3DFree - D3DMalloc - D3DRealloc - Direct3DCreateDevice - CreateTexture - D3DBreakVBLock - D3DTextureUpdate - DestroyTexture - Direct3DCreate - Direct3D_HALCleanUp - FlushD3DDevices - GetLOD - GetPriority - PaletteAssociateNotify - PaletteUpdateNotify - SetLOD - SetPriority - SurfaceFlipNotify >I know about D3DRM.DLL (that won't be supported) for the 'retained mode' API >but I thought that all 'immediate mode' API was in ddraw.dll and not in a >separate library. yes, you are right. d3dim is only some utilities functions and interfaces for d3d immediate mode. (with d3d8 most of the code of d3dim and d3dxof was moved into d3dx8) >Why not first test with an empty DLL with just the version ressources in it >and see if it's enough ? maybe with only emtpy stubs now :) > Lionel Raphael

1 0

Re: The version info patches + d3d question
by fenix＠club-internet.fr Jan. 13, 2003

Jan. 13, 2003

----Message d'origine---- >De: Enrico Horn <farmboy1(a)subdimension.com> >A: wine-devel(a)winehq.com >Sujet: The version info patches + d3d question >Date: Mon, 13 Jan 2003 14:47:31 +0100 > >Hi, Hi, >The patches add version info to directx libraries. >some games(for instance lucasarts games) wont run without finding a valid >version of the directx files. thanks, maybe you can do the same for d3d8 :) >the problem is they dont run even with the patches because they cant get >version info from d3dim.dll and probably other d3d dlls. >since wine doesnt have these dlls how can wine give these programs the needed >info or is it planned to split ddraw in a ddraw and a d3d component? actually, we are speaking about d3d architecture, but it will be possible to implement d3dim.dll (minors d3d calls) into near future using the "new" codebase. And d3d component (for version 3..7) is contained into ddraw.dll >Have fun >Enrico Regards, Raphael

2 1

The version info patches + d3d question
by Enrico Horn Jan. 13, 2003

Jan. 13, 2003

Hi, The patches add version info to directx libraries. some games(for instance lucasarts games) wont run without finding a valid version of the directx files. the problem is they dont run even with the patches because they cant get version info from d3dim.dll and probably other d3d dlls. since wine doesnt have these dlls how can wine give these programs the needed info or is it planned to split ddraw in a ddraw and a d3d component? Have fun Enrico

1 0

Direct3D/OpenGL compilation error
by Francois Gouget Jan. 13, 2003

Jan. 13, 2003

One of the machines I compile on from time to time is an old RedHat 6.2 which is nice because it still has glibc 2.1.3 so the binaries it produces work on all Linux distributions. Anyway, the latest Wine does not compile anymore on that machine. I get: gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -g -O2 -Wall -gstabs+ -fPIC -D__WINESRC__ -D_REENTRANT -o device.o device.c device.c: In function `SOURCEx_RGB_EXT': device.c:859: `GL_SOURCE2_RGB_EXT' undeclared (first use in this function) device.c:859: (Each undeclared identifier is reported only once device.c:859: for each function it appears in.) device.c:860: `GL_SOURCE0_RGB_EXT' undeclared (first use in this function) device.c:861: `GL_SOURCE1_RGB_EXT' undeclared (first use in this function) device.c:869: warning: control reaches end of non-void function device.c: In function `OPERANDx_RGB_EXT': device.c:872: `GL_OPERAND2_RGB_EXT' undeclared (first use in this function) device.c:873: `GL_OPERAND0_RGB_EXT' undeclared (first use in this function) device.c:874: `GL_OPERAND1_RGB_EXT' undeclared (first use in this function) device.c:882: warning: control reaches end of non-void function device.c: In function `SOURCEx_ALPHA_EXT': device.c:885: `GL_SOURCE2_ALPHA_EXT' undeclared (first use in this function) device.c:886: `GL_SOURCE0_ALPHA_EXT' undeclared (first use in this function) device.c:887: `GL_SOURCE1_ALPHA_EXT' undeclared (first use in this function) device.c:895: warning: control reaches end of non-void function device.c: In function `OPERANDx_ALPHA_EXT': device.c:898: `GL_OPERAND2_ALPHA_EXT' undeclared (first use in this function) device.c:899: `GL_OPERAND0_ALPHA_EXT' undeclared (first use in this function) device.c:900: `GL_OPERAND1_ALPHA_EXT' undeclared (first use in this function) device.c:908: warning: control reaches end of non-void function device.c: In function `IDirect3DDevice8Impl_SetTextureStageState': device.c:3312: `GL_PREVIOUS_EXT' undeclared (first use in this function) device.c:3314: `GL_PRIMARY_COLOR_EXT' undeclared (first use in this function) device.c:3318: `GL_CONSTANT_EXT' undeclared (first use in this function) device.c:3350: `GL_COMBINE_ALPHA_EXT' undeclared (first use in this function) device.c:3350: `GL_COMBINE_RGB_EXT' undeclared (first use in this function) device.c:3409: `GL_RGB_SCALE_EXT' undeclared (first use in this function) device.c:3423: `GL_ADD_SIGNED_EXT' undeclared (first use in this function) So is it just that the OpenGL headers on that machine are hopelessly out of date (mesa 3.3) or is there some configure test that can/should be done? Note that if I compile with --without-opengl Wine compiles ok so it's not so bad. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

1 0

Developers current e-mail addresses listed in authors.ent
by Tom Wickline Jan. 13, 2003

Jan. 13, 2003

I am getting ready to update the WINE Packagers Guide See : http://www.winehq.com/Docs/wine-pkg/ And the first thing that I noticed was Andreas & Marcus e-mail address were incorrect. So I then looked at : http://cvs.winehq.com/cvsweb/~checkout~/wine/documentation/authors.ent?rev=… And found that alot of other's were different from my Address Book. I have listed them below Current is what is now there current address in the *authors.ent* file. And below is the addresses that is listed in my address book. There are also a couple DOA addresses listed in this file and there at the bottom. I dont want to change this file and not have people's e-mail correct! So can everyone look over the file and let me know if your e-mail needs to be changed ?? Also a couple people below have multiable addresses can you let me know what address you want listed. Tom Current = ovek(a)winehq.com Ove Kaaven <ovek(a)arcticnet.no Ove Kaaven <ovehk(a)ping.uio.no ovek <ovek(a)transgaming.com --- Current = Marcus.Meissner(a)caldera.de Marcus Meissner <marcus(a)jet.franken.de Marcus Meissner <mm(a)lst.de ---- Current = amohr(a)codeweavers.com Andreas Mohr <andi(a)rhlx01.fht-esslingen.de --- Current = Speeddymon(a)yahoo.com Dustin Navea <Speeddymon(a)sbcglobal.net --- Current = dimi(a)cs.toronto.edu "Dimitrie O. Paun" <dpaun(a)rogers.com --- Current = juergen.schmied(a)metronet.de juergen schmied <juergen.schmied(a)debitel.net DOA addresses Should I leave them or remove them ?? douglas-ridgway "ridgway(a)winehq.com"> john-sheets "jsheets(a)codeweavers.com">

2 2

Re: Bug Fix With Delay load function in Shell32 (version2)
by Dimitrie O. Paun Jan. 12, 2003

Jan. 12, 2003

On January 12, 2003 12:08 pm, Robert Shearman wrote: > Index: shellole.c Please make your patches relative to wine's root. > -HINSTANCE hShellOle32 = 0; > +HINSTANCE g_hShellOle32 = 0; /* global handle to ole32.dll */ Also, please do not introduce ugly naming conventions like the above, especially when the style the DLL is written in does not call for it. In general, we have none of these conventions in Wine, and it's preferable to just avoid them. We have a bunch of others though. :) -- Dimi.

1 0

Re: FreeBSD Compilation Fix
by Dimitrie O. Paun Jan. 12, 2003

Jan. 12, 2003

On January 11, 2003 09:00 pm, Jared Goldberg wrote: > Index: dlls/dsound/tests/dsound.c > =================================================================== > RCS file: /home/wine/wine/dlls/dsound/tests/dsound.c,v > retrieving revision 1.3 > diff -r1.3 dsound.c > 20a21,23 > > >#if defined(__FreeBSD__) > >#include <stdlib.h> > >#else > > 21a25 > > >#endif Uniffied diffs please: cvs diff -u or diff -u See: http://www.winehq.org/development/#patches In this case, I suggest you just include stdlib.h without any ifdefs. It's a standard header, it should exist on all systems. -- Dimi.

1 0

Re: Shell Ordinals
by j.schmied＠t-online.de Jan. 12, 2003

Jan. 12, 2003

Hi! We have a problem here... win9x and winnt have a very different set of ordinal functions exported. We have to decide what we support. At the moment most ordinals functions are win9x style. We should never mix both cases since then both explorer won't run. I think we don't have any chance to get the win9x explorer running. A long time ago I did a lot of explorer debugging and the nt4 explorer was nearly running since it's not as much involved into the booting of the system as the win9x one. So I would suggest to change the ordinals into the nt ones. It would cause some 9x only functions to be removed. The change of shell32.spec should be done in one go. PS: Since I recently started to do some shell32 work again: Who is doing what at the moment? Bye Juergen > > This includes a few ordinals used by explorer and desk.cpl > There seems to be a conflict between SHLocalAlloc/Free and the ordinals I > have made stubs for (on Win2k SP3 shell32.dll), but I have no way of knowing > which ordinal (if any) SHLocalAlloc/Free should be. > > ChangeLog: > - Implement some PropertySheetExtArray ordinals > - Add some stubs used by explorer > > Rob > -- juergen.schmied(a)debitel.net FAX über T-Online Fax&Fon: 01805 060 334 316 35 (12Cent/Min)

2 1

Re: conformance test for ShellExecute
by Francois Gouget Jan. 12, 2003

Jan. 12, 2003

On Sun, 29 Dec 2002, Dan Kegel wrote: > Well, the puny little beginnings of one, anyway. > (I'll improve this later. Still, it already > catches a difference between Windows and Wine, > so it's worth committing as is.) I tested it on Win95, Win98, NT4 and XP and it worked on all platforms. However, since it currently fails in Wine should should enclose the test in a 'todo_wine' and resubmit it. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

1 0

patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by liu spider Jan. 12, 2003

Jan. 12, 2003

Thanks to Dmitry Timoshkov. This patch is the second edition, adopted his suggestions. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW make GetFileTitleA a wrapper of GetFileTitleW liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

1 0

Re: wine/programs/wineboot wineboot.c Makefile.in
by Shachar Shemesh Jan. 11, 2003

Jan. 11, 2003

Alexandre Julliard wrote: >ChangeSet ID: 6997 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2003/01/11 15:02:50 > >Modified files: > programs/wineboot: wineboot.c Makefile.in > >Log message: > Shachar Shemesh <wine-patches(a)sun.consumer.org.il> > Implemented the "pending rename" registry processing. > >Patch: http://cvs.winehq.com/patch.py?id=6997 > >Old revision New revision Changes Path > 1.2 1.3 +158 -3 wine/programs/wineboot/wineboot.c > 1.1 1.2 +1 -1 wine/programs/wineboot/Makefile.in > > > > Hi Alexander, Two points about the differences between the version I submitted and the version that made it in. 1. If you are going to reject the printing of "Windows is finishing to install your programs..." closing message, at least also remove the starting message (lines 105 and 106 of version 1.3 of the file). 2. The reason I added the cast on the free line was to remove a compilation warning. If you made sure the warning doesn't happen by changing somewhere else in the code, that's, of course, fine. Otherwise there is a warning when compiling (I am currently doing a clean compile to make sure whether that happens on my system). Shachar

3 5