January 2003 - Wine-Devel - list.winehq.org

Fwd: patch for "GetFileTitleW: illegal call to GetFileTitleA" 3ed
by liu spider Jan. 18, 2003

Jan. 18, 2003

Thanks to Alexandre Julliard. He pointed out to me the right method, and I hope this patch is the correct one. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW GetFileTitleA now is a call to GetFileTitleW liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com Index: dlls/commdlg/filetitle.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/filetitle.c,v retrieving revision 1.12 diff -u -r1.12 filetitle.c --- dlls/commdlg/filetitle.c 31 May 2002 23:25:45 -0000 1.12 +++ dlls/commdlg/filetitle.c 18 Jan 2003 14:13:02 -0000 @@ -3,6 +3,7 @@ * * Copyright 1994 Martin Ayotte * Copyright 1996 Albrecht Kleine + * Copyright 2003 liuspider * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -24,10 +25,10 @@ #include "winbase.h" #include "winnls.h" #include "commdlg.h" +#include "wine/unicode.h" +#include "winternl.h" #include "wine/debug.h" -#include "heap.h" /* Has to go */ - WINE_DEFAULT_DEBUG_CHANNEL(commdlg); #include "cdlg.h" @@ -38,19 +39,41 @@ */ short WINAPI GetFileTitleA(LPCSTR lpFile, LPSTR lpTitle, UINT cbBuf) { - int i, len; + int ret,totalW; + UNICODE_STRING strWFile; + LPWSTR lpWTitle; + totalW = cbBuf * sizeof(WCHAR); + RtlCreateUnicodeStringFromAsciiz(&strWFile, lpFile); + lpWTitle = RtlAllocateHeap( GetProcessHeap(), 0, totalW); + ret = GetFileTitleW(strWFile.Buffer, lpWTitle, totalW); + if (!ret){ + WideCharToMultiByte( CP_ACP, 0, lpWTitle, -1, lpTitle, cbBuf, NULL, NULL ); + } + RtlFreeUnicodeString( &strWFile ); + RtlFreeHeap( GetProcessHeap(), 0, lpWTitle ); + return ret; +} + +/*********************************************************************** + * GetFileTitleW (COMDLG32.@) + * + */ +short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) +{ + int i, len; + WCHAR brkpoint[] = {'*','[',']'}; TRACE("(%p %p %d); \n", lpFile, lpTitle, cbBuf); if(lpFile == NULL || lpTitle == NULL) return -1; - len = strlen(lpFile); + len = strlenW(lpFile); if (len == 0) return -1; - if(strpbrk(lpFile, "*[]")) + if(strpbrkW(lpFile, brkpoint)) return -1; len--; @@ -70,34 +93,14 @@ if(i == -1) i++; - TRACE("---> '%s' \n", &lpFile[i]); + TRACE("---> '%s' \n", debugstr_w(&lpFile[i])); - len = strlen(lpFile+i)+1; + len = strlenW(lpFile+i)+1; if(cbBuf < len) return len; - strncpy(lpTitle, &lpFile[i], len); + strncpyW(lpTitle, &lpFile[i], len); return 0; -} - - -/*********************************************************************** - * GetFileTitleW (COMDLG32.@) - * - */ -short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) -{ - LPSTR file = HEAP_strdupWtoA(GetProcessHeap(), 0, lpFile); /* Has to go */ - LPSTR title = HeapAlloc(GetProcessHeap(), 0, cbBuf); - short ret; - - ret = GetFileTitleA(file, title, cbBuf); - - if (cbBuf > 0 && !MultiByteToWideChar( CP_ACP, 0, title, -1, lpTitle, cbBuf )) - lpTitle[cbBuf-1] = 0; - HeapFree(GetProcessHeap(), 0, file); - HeapFree(GetProcessHeap(), 0, title); - return ret; }

1 0

Running Wine with a Windows install
by Tom Wickline Jan. 18, 2003

Jan. 18, 2003

I have hit a small road block in updating the Packagers Guide and i'm in need of a little help here :) Section 3.3 : http://www.winehq.com/Docs/wine-pkg/pkg-winpartition.shtml Talks about useing files from an installation of the actual Microsoft Windows operating system. And as I dont have Windows on this box and I only have Win2000 on my second HD at this time I am not sure if this section is out of date. And what the differances between 9x and NT, 2K, XP are. So if you have Windows on your box or if you run Wine with Windows can you send me the path to the .dat files .ini file and system dlls ? In the future is this going to be done for the user by a config script ? One more question while im at it :)) I sent a patch to wine-patches about 6 hours ago and its still not listed how long does this take ? are the patches moderated before being posted ? Tom

1 0

Re: Implementation of "start.exe", take 3
by davep Jan. 18, 2003

Jan. 18, 2003

On Saturday 18 Jan 2003 08:44, Dan Kegel wrote: > Remaining issue I could use help with: > * multiline strings from resource file are displayed with extra newline > between lines in wine, but not in windows. To reproduce, build > either as winelib app or build under MSVC6, then run in wine; > usage message comes out double-spaced. Help! Use a backslash on the end of each line to escape the LF. Look at programs/wcmd/wcmdrc.rc for an example. Dave

1 0

how to make a proper .diff
by Tom Wickline Jan. 18, 2003

Jan. 18, 2003

Hi, I have what may be a stupid question but im going to ask it :) If im working on lets say packaging.sgml and I finish one section and make a diff against cvs. Then should I refresh my packaging.sgml from cvs and start on section #2 ? This is what I have done... Because if I keep working on the same file the diff grows and I would send the same patch over and over.. So I am doing this the correct way ? Tom

2 1

Implementation of "start.exe", take 3
by Dan Kegel Jan. 18, 2003

Jan. 18, 2003

Changes since take 2: * internationalized * can be built with MSVC6.0; resulting .exe works in both Windows and Wine * winelib app now installed by wineinstall * winedefault.reg now has entries needed to make 'start foo.txt' work Remaining issue I could use help with: * multiline strings from resource file are displayed with extra newline between lines in wine, but not in windows. To reproduce, build either as winelib app or build under MSVC6, then run in wine; usage message comes out double-spaced. Help! I suspect it's worth submitting to wine-patches until that issue is resolved. Again, to those who are confused why I didn't just use cygstart, cygstart's license seems to be an issue, and cygstart doesn't implement one of the four options in the real Windows start.exe, so I plowed ahead with my own version. We can add options from Cygstart later. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.122 diff -u -r1.122 configure.ac --- configure.ac 15 Jan 2003 00:50:48 -0000 1.122 +++ configure.ac 18 Jan 2003 08:11:26 -0000 @@ -1519,6 +1519,7 @@ programs/regtest/Makefile programs/rpcss/Makefile programs/rundll32/Makefile +programs/start/Makefile programs/uninstaller/Makefile programs/view/Makefile programs/wcmd/Makefile Index: winedefault.reg =================================================================== RCS file: /home/wine/wine/winedefault.reg,v retrieving revision 1.61 diff -u -r1.61 winedefault.reg --- winedefault.reg 19 Dec 2002 21:16:56 -0000 1.61 +++ winedefault.reg 18 Jan 2003 08:11:26 -0000 @@ -2838,3 +2838,18 @@ "LongDistanceRule"=" 8WFG" "Name"="Uzbekistan" "SameAreaRule"="G" + +# +# Entries to get ShellExecute to map .txt files to notepad +# + +[HKEY_CLASSES_ROOT\.txt] +@="txtfile" +"Content Type"="text/plain" + +[HKEY_CLASSES_ROOT\txtfile\shell\open\command] +@="C:\\WINDOWS\\NOTEPAD.EXE %1" + +[HKEY_CLASSES_ROOT\txtfile\shell\print\command] +@="C:\\WINDOWS\\NOTEPAD.EXE /p %1" + Index: programs/Makefile.in =================================================================== RCS file: /home/wine/wine/programs/Makefile.in,v retrieving revision 1.33 diff -u -r1.33 Makefile.in --- programs/Makefile.in 4 Jan 2003 02:52:05 -0000 1.33 +++ programs/Makefile.in 18 Jan 2003 08:11:26 -0000 @@ -19,6 +19,7 @@ regtest \ rpcss \ rundll32 \ + start \ uninstaller \ view \ wcmd \ @@ -43,6 +44,7 @@ regsvr32 \ rpcss \ rundll32 \ + start \ uninstaller \ wcmd \ wineboot \ @@ -73,6 +75,7 @@ # Symlinks to apps that we want to run from inside the source tree SYMLINKS = \ + start.exe \ rpcss.exe \ wcmd.exe \ wineconsole.exe \ @@ -136,6 +139,9 @@ winhelp.exe$(DLLEXT): winhelp/winhelp.exe$(DLLEXT) $(RM) $@ && $(LN_S) winhelp/winhelp.exe$(DLLEXT) $@ + +start.exe$(DLLEXT): start/start.exe$(DLLEXT) + $(RM) $@ && $(LN_S) start/start.exe$(DLLEXT) $@ wcmd/wcmd.exe$(DLLEXT): wcmd wineconsole/wineconsole.exe$(DLLEXT): wineconsole Index: tools/wineinstall =================================================================== RCS file: /home/wine/wine/tools/wineinstall,v retrieving revision 1.50 diff -u -r1.50 wineinstall --- tools/wineinstall 5 Dec 2002 19:05:44 -0000 1.50 +++ tools/wineinstall 18 Jan 2003 08:11:26 -0000 @@ -101,6 +101,7 @@ function create_windows_directories { for tdir in "$CROOT/windows" "$CROOT/windows/system" \ + "$CROOT/windows/command" \ "$CROOT/windows/Start Menu" "$CROOT/windows/Start Menu/Programs" \ "$CROOT/Program Files" "$CROOT/Program Files/Common Files" \ "$CROOT/windows/Profiles" "$CROOT/windows/Profiles/Administrator" \ @@ -129,6 +130,7 @@ #puts windows applications replacements to windows directories, #configures them function configure_wine_applications { + link_app start "$CROOT/windows/command/start.exe" link_app notepad "$CROOT/windows/notepad.exe" link_app regedit "$CROOT/windows/regedit.exe" link_app rundll32 "$CROOT/windows/rundll32.exe" --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/Makefile.in 2003-01-17 23:25:49.000000000 -0800 @@ -0,0 +1,15 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +MODULE = start.exe +APPMODE = cui +IMPORTS = shell32 user32 + +C_SRCS = start.c + +RC_SRCS = rsrc.rc + +(a)MAKE_PROG_RULES@ + +### Dependencies: --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/start.c 2003-01-18 00:04:53.000000000 -0800 @@ -0,0 +1,190 @@ +/* + * Start a program using ShellExecuteEx, optionally wait for it to finish + * Compatible with Microsoft's "c:\windows\command\start.exe" + * + * Copyright 2003 Dan Kegel + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <windows.h> +#include <winuser.h> +#include <stdio.h> +#include <stdlib.h> +#include <shlobj.h> + +#include "resources.h" + +/** + Output given message to stdout without formatting. +*/ +static void output(const char *message) +{ + DWORD count; + WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); +} + +/** + Output given message, + followed by ": ", + followed by description of given GetLastError() value to stdout, + followed by a trailing newline, + then terminate. +*/ +static void fatal_error(const char *msg, DWORD error_code) +{ + LPVOID lpMsgBuf; + int status; + + output(msg); + output(": "); + status = FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, NULL, error_code, 0, (LPTSTR) & lpMsgBuf, 0, NULL); + if (!status) { + output("FormatMessage failed\n"); + } else { + output(lpMsgBuf); + LocalFree((HLOCAL) lpMsgBuf); + output("\n"); + } + ExitProcess(1); +} + +/** + Output given message from string table, + followed by ": ", + followed by description of given GetLastError() value to stdout, + followed by a trailing newline, + then terminate. +*/ +static void fatal_string_error(int which, DWORD error_code) +{ + char msg[2048]; + + if (!LoadString(GetModuleHandle(NULL), which, + msg, sizeof(msg))) + fatal_error("LoadString failed", GetLastError()); + + fatal_error(msg, error_code); +} + +static void fatal_string(int which) +{ + char msg[2048]; + + if (!LoadString(GetModuleHandle(NULL), which, + msg, sizeof(msg))) + fatal_error("LoadString failed", GetLastError()); + + output(msg); + ExitProcess(1); +} + +static void usage() +{ + fatal_string(STRING_USAGE); +} + +static void license() +{ + fatal_string(STRING_LICENSE); +} + +int main(int argc, char *argv[]) +{ + char arguments[MAX_PATH]; + char *p; + SHELLEXECUTEINFO sei; + int argi; + + memset(&sei, 0, sizeof(sei)); + sei.cbSize = sizeof(sei); + sei.lpVerb = "open"; + sei.nShow = SW_SHOWNORMAL; + /* Dunno what these mean, but it looks like winMe's start uses them */ + sei.fMask = SEE_MASK_FLAG_DDEWAIT|SEE_MASK_FLAG_NO_UI; + + /* Canonical Microsoft commandline flag processing: + * flags start with /, are case insensitive, + * and may be run together in same word. + */ + for (argi=1; argi<argc; argi++) { + int ci; + + if (argv[argi][0] != '/') + break; + + /* Handle all options in this word */ + for (ci=0; argv[argi][ci]; ) { + /* Skip slash */ + ci++; + switch(argv[argi][ci]) { + case 'l': + case 'L': + license(); + break; /* notreached */ + case 'm': + case 'M': + if (argv[argi][ci+1] == 'a' || argv[argi][ci+1] == 'A') + sei.nShow = SW_SHOWMAXIMIZED; + else + sei.nShow = SW_SHOWMINIMIZED; + break; + case 'r': + case 'R': + /* sei.nShow = SW_SHOWNORMAL; */ + break; + case 'w': + case 'W': + sei.fMask |= SEE_MASK_NOCLOSEPROCESS; + break; + default: + printf("Option '%s' not recognized\n", argv[argi]+ci-1); + usage(); + } + /* Skip to next slash */ + while (argv[argi][ci] && (argv[argi][ci] != '/')) + ci++; + } + } + + if (argi == argc) + usage(); + + sei.lpFile = argv[argi++]; + + /* FIXME - prone to overflow */ + arguments[0] = 0; + for (p = arguments; argi < argc; argi++) + p += sprintf(p, " %s", argv[argi]); + + sei.lpParameters = arguments; + + if (!ShellExecuteEx(&sei)) + fatal_string_error(STRING_EXECFAIL, GetLastError()); + + if (sei.fMask & SEE_MASK_NOCLOSEPROCESS) { + DWORD exitcode; + DWORD waitcode; + waitcode = WaitForSingleObject(sei.hProcess, INFINITE); + if (waitcode) + fatal_error("WaitForSingleObject", GetLastError()); + if (!GetExitCodeProcess(sei.hProcess, &exitcode)) + fatal_error("GetExitCodeProcess", GetLastError()); + /* fixme: haven't tested whether exit code works properly */ + ExitProcess(exitcode); + } + + ExitProcess(0); +} --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/resources.h 2003-01-17 23:26:09.000000000 -0800 @@ -0,0 +1,3 @@ +#define STRING_USAGE 101 +#define STRING_LICENSE 102 +#define STRING_EXECFAIL 103 --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/En.rc 2003-01-17 23:26:09.000000000 -0800 @@ -0,0 +1,64 @@ +/* + * Start + * English Language Support + * + * Copyright 2003 Dan Kegel + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US +#pragma code_page(850) + +STRINGTABLE DISCARDABLE LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT +{ +STRING_USAGE, "Start a program, or open a document in the program normally used for files with that suffix. \n\ +Usage: \n\ +start [options] program_filename [...] \n\ +start [options] document_filename \n\ + \n\ +Options: \n\ +/M[inimized] Start the program minimized. \n\ +/MAX[imized] Start the program maximized. \n\ +/R[estored] Start the program normally (neither minimized nor maximized). \n\ +/W[ait] Wait for started program to finish, then exit with its exit code. \n\ +/L Show end-user license. \n\ + \n\ +start.exe version 0.2 Copyright (C) 2003, Dan Kegel \n\ +Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option. \n\ +This is free software, and you are welcome to redistribute it \n\ +under certain conditions; run 'start /L' for details. \n\ +" + +STRING_LICENSE, "start.exe version 0.2 Copyright (C) 2003, Dan Kegel \n\ +This program is free software; you can redistribute it and/or \n\ +modify it under the terms of the GNU Lesser Public License \n\ +as published by the Free Software Foundation; either version 2.1 \n\ +of the License, or (at your option) any later version. \n\ + \n\ +This program is distributed in the hope that it will be useful, \n\ +but WITHOUT ANY WARRANTY; without even the implied warranty of \n\ +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the \n\ +GNU Lesser Public License for more details. \n\ + \n\ +You should have received a copy of the GNU Lesser Public License \n\ +along with this program; if not, write to the Free Software \n\ +Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. \n\ + \n\ +See the COPYING.LIB file for license information. \n\ +" + +STRING_EXECFAIL "Application could not be started, or no application associated with the specified file.\nShellExecuteEx failed" +} --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/rsrc.rc 2003-01-17 23:26:09.000000000 -0800 @@ -0,0 +1,24 @@ +/* + * Copyright 2003 Dan Kegel + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <windows.h> +#include "resources.h" + +LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL + +#include "En.rc"

1 0

Re: * Hack * for Wine-20030115 DOSFS_Hash on Solaris 8 x86
by Andreas Mohr Jan. 18, 2003

Jan. 18, 2003

Hi ! On Fri, Jan 17, 2003 at 08:40:30PM -0500, John Wehle wrote: > wine photoed reports it can't find GIFIMP32.FLT (and friends) > which prevents images from being imported. The trace is: > > trace:dosfs:DOSFS_GetFullName L"C:\\PROGRA~1\\COMMON~1\\MICROS~1\\GRPHFLT\\GIFIM > P32.FLT" (last=0) > trace:dosfs:DOSFS_FindUnixName /dos,L"PROGRA~1\\COMMON~1\\MICROS~1\\GRPHFLT\\GIF > IMP32.FLT" > trace:dosfs:DOSFS_ToDosFCBFormat (L"PROGRA~1\\COMMON~1\\MICROS~1\\GRPHFLT\\GIFIM > P32.FLT", df621770) > trace:dosfs:DOSFS_OpenDir "/dos" > ... > trace:dosfs:DOSFS_ReadDir Read: long_name: L"Program Files", short_name: (null) > trace:dosfs:DOSFS_FindUnixName checking L"PROGRA~1 " L"PROG~FBU " > > What happens is DOSFS_Hash hashes "Program Files" in an unexpected fashion > which prevents DOSFS_FindUnixName from realizing it matches ""PROGRA~1 ". > > The enclosed * hack * allows wine photoed to load images. It is * not * > the correct answer. One possible approach is to modify DOSFS_OpenDir_Normal > to generate "proper" short names after it has read all the directory entries. Hmm, somehow I don't think this is a proper solution. The reasoning being that you probably have a Windows partition in your Wine install with that ~1 path buried somewhere in the registry or so. And IMHO if the registry contains such a setting (*from installation only* - a program most likely wouldn't create a ~1 .3 shortcut pathname on its own !), then we are SOL and probably should keep it like that instead of adding hacks that probably don't improve the code a whole lot. Instead, people should install the program via Wine, thus gaining "proper" registry keys with "proper" 8.3 *Wine* hashing during the install via Wine ! We simply don't seem to have a way to have a *fixed* mapping of long filenames to the ~1 shortcuts used in Windows; that's why we need our hashing. (someone correct me if I'm wrong about this issue !) Or maybe I'm wrong and we should indeed try to cope even with such a pretty hopeless situation. Oh, and I just realized that maybe yet another patch from you might get rejected ;-\ (although I'm grateful for the discussion about that issue) Andreas Mohr P.S.: Please CC me on followup discussions - I'm not on wine-devel currently.

1 0

Implementation of 'start', take 2
by Dan Kegel Jan. 18, 2003

Jan. 18, 2003

I had a look at cygstart, but it doesn't even try to be commandline-compatible with Microsoft's start.exe. Oh, well. I've verified that this implementation of start can do both start notepad and start foo.txt and that it obeys all the options obeyed by WindowsMe's start.exe. It also implements the /L option to print out the LGPL. (Do we have a convention for what this option, required by the LGPL, should be?) I'd rather compile it as a .exe rather than a winelib app - is there a way to do that in the Wine tree? Also, what do I have to do to cause the resulting .exe to end up as %windir%/command/start.exe, so it's in the same place as it is in real Microsoft Windows? BTW, to make 'start foo.txt' work, you need the registry entries [HKEY_CLASSES_ROOT\.txt] @="txtfile" "Content Type"="text/plain" [HKEY_CLASSES_ROOT\txtfile\shell\open\command] @="C:\\WINDOWS\\NOTEPAD.EXE %1" I verified that removing either of these on WinMe caused 'start foo.txt' to fail. I did not verify that, when you use the /w flag, the exit status of the subprocess is returned in the same way as it's done in Windows. Thanks, Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.116 diff -u -r1.116 configure.ac --- configure.ac 4 Jan 2003 02:52:05 -0000 1.116 +++ configure.ac 18 Jan 2003 02:41:32 -0000 @@ -1497,6 +1497,7 @@ programs/regtest/Makefile programs/rpcss/Makefile programs/rundll32/Makefile +programs/start/Makefile programs/uninstaller/Makefile programs/view/Makefile programs/wcmd/Makefile Index: programs/Makefile.in =================================================================== RCS file: /home/wine/wine/programs/Makefile.in,v retrieving revision 1.33 diff -u -r1.33 Makefile.in --- programs/Makefile.in 4 Jan 2003 02:52:05 -0000 1.33 +++ programs/Makefile.in 18 Jan 2003 02:41:32 -0000 @@ -19,6 +19,7 @@ regtest \ rpcss \ rundll32 \ + start \ uninstaller \ view \ wcmd \ @@ -43,6 +44,7 @@ regsvr32 \ rpcss \ rundll32 \ + start \ uninstaller \ wcmd \ wineboot \ @@ -73,6 +75,7 @@ # Symlinks to apps that we want to run from inside the source tree SYMLINKS = \ + start.exe \ rpcss.exe \ wcmd.exe \ wineconsole.exe \ @@ -136,6 +139,9 @@ winhelp.exe$(DLLEXT): winhelp/winhelp.exe$(DLLEXT) $(RM) $@ && $(LN_S) winhelp/winhelp.exe$(DLLEXT) $@ + +start.exe$(DLLEXT): start/start.exe$(DLLEXT) + $(RM) $@ && $(LN_S) start/start.exe$(DLLEXT) $@ wcmd/wcmd.exe$(DLLEXT): wcmd wineconsole/wineconsole.exe$(DLLEXT): wineconsole --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/Makefile.in 2003-01-16 08:20:35.000000000 -0800 @@ -0,0 +1,13 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +MODULE = start.exe +APPMODE = cui +IMPORTS = shell32 + +C_SRCS = start.c + +(a)MAKE_PROG_RULES@ + +### Dependencies: --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/start.c 2003-01-17 17:34:36.000000000 -0800 @@ -0,0 +1,199 @@ +/* + * Start a program using ShellExecuteEx, optionally wait for it to finish + * Compatible with Microsoft's "c:\windows\command\start.exe" + * + * Copyright 2003 Dan Kegel + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include "config.h" +#include "wine/debug.h" + +#include <windows.h> +#include <stdio.h> +#include <stdlib.h> +#include <shlobj.h> + +#define VERSIONMSG "start.exe version 0.1 Copyright (C) 2003, Dan Kegel" + +/** + Output given message to stdout without formatting. +*/ +static void output(const char *message) +{ + DWORD count; + WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); +} + +/** + Output given message, + followed by ": ", + followed by description of given GetLastError() value to stdout, + followed by a trailing newline, + then terminate. +*/ +static void fatal_error(const char *msg, DWORD error_code) +{ + LPVOID lpMsgBuf; + int status; + + output(msg); + output(": "); + status = FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, NULL, error_code, 0, (LPTSTR) & lpMsgBuf, 0, NULL); + if (!status) { + output("FormatMessage failed\n"); + } else { + output(lpMsgBuf); + LocalFree((HLOCAL) lpMsgBuf); + output("\n"); + } + ExitProcess(1); +} + +static void usage() +{ + output("\ +Start a program, or open a document in the program normally used for files with that suffix.\n\ +Usage:\n\ +start [options] program_filename [...]\n\ +start [options] document_filename\n\ +\n\ +Options:\n\ +/M[inimized] Start the program minimized.\n\ +/MAX[imized] Start the program maximized.\n\ +/R[estored] Start the program normally (neither minimized nor maximized).\n\ +/W[ait] Wait for started program to finish, then exit with its exit code.\n\ +/L Show end-user license.\n\ +\n\ +" VERSIONMSG "\n\ +Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option.\n\ +This is free software, and you are welcome to redistribute it\n\ +under certain conditions; run 'start /L' for details.\n\ +"); + ExitProcess(1); +} + +static void license() +{ + output("\ +" VERSIONMSG "\n\n\ +This program is free software; you can redistribute it and/or\n\ +modify it under the terms of the GNU Lesser Public License\n\ +as published by the Free Software Foundation; either version 2.1\n\ +of the License, or (at your option) any later version.\n\ +\n\ +This program is distributed in the hope that it will be useful,\n\ +but WITHOUT ANY WARRANTY; without even the implied warranty of\n\ +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n\ +GNU Lesser Public License for more details.\n\ +\n\ +You should have received a copy of the GNU Lesser Public License\n\ +along with this program; if not, write to the Free Software\n\ +Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.\n\ +\n\ +See the COPYING.LIB file for license information.\n\ +"); + ExitProcess(1); +} + +int main(int argc, char *argv[]) +{ + char arguments[MAX_PATH]; + char *p; + SHELLEXECUTEINFO sei; + int argi; + + memset(&sei, 0, sizeof(sei)); + sei.cbSize = sizeof(sei); + sei.lpVerb = "open"; + sei.nShow = SW_SHOWNORMAL; + /* Dunno what these mean, but it looks like winMe's start uses them */ + sei.fMask = SEE_MASK_FLAG_DDEWAIT|SEE_MASK_FLAG_NO_UI; + + /* Canonical Microsoft commandline flag processing: + * flags start with /, are case insensitive, + * and may be run together in same word. + */ + for (argi=1; argi<argc; argi++) { + int ci; + + if (argv[argi][0] != '/') + break; + + /* Handle all options in this word */ + for (ci=0; argv[argi][ci]; ) { + /* Skip slash */ + ci++; + switch(argv[argi][ci]) { + case 'l': + case 'L': + license(); + break; /* notreached */ + case 'm': + case 'M': + if (argv[argi][ci+1] == 'a' || argv[argi][ci+1] == 'A') + sei.nShow = SW_SHOWMAXIMIZED; + else + sei.nShow = SW_SHOWMINIMIZED; + break; + case 'r': + case 'R': + /* sei.nShow = SW_SHOWNORMAL; */ + break; + case 'w': + case 'W': + sei.fMask |= SEE_MASK_NOCLOSEPROCESS; + break; + default: + printf("Option '%s' not recognized\n", argv[argi]+ci-1); + usage(); + } + /* Skip to next slash */ + while (argv[argi][ci] && (argv[argi][ci] != '/')) + ci++; + } + } + + if (argi == argc) + usage(); + + sei.lpFile = argv[argi++]; + + /* FIXME - prone to overflow */ + arguments[0] = 0; + for (p = arguments; argi < argc; argi++) + p += sprintf(p, " %s", argv[argi]); + + sei.lpParameters = arguments; + + if (!ShellExecuteEx(&sei)) { + fatal_error("Application could not be started, or no application associated with the specified file. ShellExecuteEx failed", GetLastError()); + } + + if (sei.fMask & SEE_MASK_NOCLOSEPROCESS) { + DWORD exitcode; + DWORD waitcode; + waitcode = WaitForSingleObject(sei.hProcess, INFINITE); + if (waitcode) + fatal_error("WaitForSingleObject", GetLastError()); + if (!GetExitCodeProcess(sei.hProcess, &exitcode)) + fatal_error("GetExitCodeProcess", GetLastError()); + /* fixme: haven't tested whether exit code works properly */ + ExitProcess(exitcode); + } + + ExitProcess(0); +}

2 3

Wine kernel acceleration module?
by Mathew McBride Jan. 18, 2003

Jan. 18, 2003

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I just installed Total Annililation the other day (without expansions), it ran quite fast even on the bigger maps (e.g Seven Islands) then installed the Core Contingency and Battle Tatics expansions, and it was as slow as a 486 (not implying that Wine processes everything at 66Mhz, but Total Annilihation is a game that likes chewing up memory). Most notably, the mouse is quite slow. If we implemented a kernel module (keep in mind, it would have to be enabled in the kernel and wine config file so it doesn't make wine directly attached to Linux, e.g so people can port it easier to other Unixes), would that help speed up some DirectX games? (as Linux display drivers don't implement DirectX functions). There are other ways, Bug 176 (http://bugs.winehq.com/show_bug.cgi?id=176) suggested implementing a SDL backend, which is not a bad idea, as SDL also has sound support and since it forwards to DirectX on Windows, gives us some idea on what functions we need to implement. Gavriel State of Transgaming developed a SDL driver (http://www.winehq.com/hypermail/wine-devel/2002/01/0519.html) (which also asks, has anyone successfully used a SDL game under Wine?). My system is a RH 7.3 with a lot of packages from the rawhide repository (namely glibc-2.3), XFree86 build from a recent (=< 4 days) CVS, Wine built from a 2 week old CVS sources, Duron (Thunderbird-cored) 800Mhz(a)840Mhz. - -- Mathew McBride matt(a)mcbridematt.dhs.org http://mcbridematt.dhs.org Jabber: mcbridematt on the jabber.org server -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iQCVAwUBPikHI5nKHiPoVMMhAQJp9wQAuFTcgW9aHfe52L/OcXtbLQfs+icGfrjD k95CRxxf8u/RYGxDEM2FBoJpG9K/tXLz1LlGryGCqOndNPIxWcUzz76sTpwgv8OK PTJYzonhfHBGsCMJ2RhBniurrJuzTDYhRtYOgiroYHJBnOITxGbxNWbKTy4KKCaT IZ8ahWhMM9o= =7S1V -----END PGP SIGNATURE-----

1 0

Re: * Hack * for Wine-20030115 DOSFS_Hash on Solaris 8 x86
by Marcus Meissner Jan. 18, 2003

Jan. 18, 2003

On Fri, Jan 17, 2003 at 08:40:30PM -0500, John Wehle wrote: > wine photoed reports it can't find GIFIMP32.FLT (and friends) > which prevents images from being imported. The trace is: > > trace:dosfs:DOSFS_GetFullName L"C:\\PROGRA~1\\COMMON~1\\MICROS~1\\GRPHFLT\\GIFIM > P32.FLT" (last=0) > trace:dosfs:DOSFS_FindUnixName /dos,L"PROGRA~1\\COMMON~1\\MICROS~1\\GRPHFLT\\GIF > IMP32.FLT" > trace:dosfs:DOSFS_ToDosFCBFormat (L"PROGRA~1\\COMMON~1\\MICROS~1\\GRPHFLT\\GIFIM > P32.FLT", df621770) > trace:dosfs:DOSFS_OpenDir "/dos" > ... > trace:dosfs:DOSFS_ReadDir Read: long_name: L"Program Files", short_name: (null) > trace:dosfs:DOSFS_FindUnixName checking L"PROGRA~1 " L"PROG~FBU " > > What happens is DOSFS_Hash hashes "Program Files" in an unexpected fashion > which prevents DOSFS_FindUnixName from realizing it matches ""PROGRA~1 ". > > The enclosed * hack * allows wine photoed to load images. It is * not * > the correct answer. One possible approach is to modify DOSFS_OpenDir_Normal > to generate "proper" short names after it has read all the directory entries. The proper idea is to install the program using WINE too, so you get the same hashes into the registry. Your hack will not work if 2 files hash to the same value. Ciao, Marcus

1 0

Re: Patch for Wine-20030115 GetFreeSpace on Solaris 8 x86
by Marcus Meissner Jan. 18, 2003

Jan. 18, 2003

On Fri, Jan 17, 2003 at 06:03:35PM -0500, John Wehle wrote: > wine ie5setup reports it can't determine the free disk space. > truss shows statfs failed with EOVERFLOW and sys/statfs.h > says: > > * Structure returned by statfs(2) and fstatfs(2). > * This structure and associated system calls have been replaced > * by statvfs(2) and fstatvfs(2) and will be removed from the system > * in a near-future release. > > This patch allows wine ie5setup to at least startup. A cleaner > patch would probably use an explict autoconf check for statvfs > in addition to checking for sys/vfs.h. > > ChangeLog: > > Fri Jan 17 18:02:37 EST 2003 John Wehle (john(a)feith.com) > > * files/drive.c (DRIVE_GetFreeSpace): Use statvfs > on systems which have sys/vfs.h. This will break on Linux, it has have sys/vfs.h but no statvfs. Better use an autoconf check for the 'statvfs' function and use the result. > + #ifdef HAVE_SYS_VFS_H Use #ifdef HAVE_STATVFS > + struct statvfs info; > + #else > struct statfs info; > + #endif > *** 1297,1305 **** > return 0; > } > > ! /* FIXME: add autoconf check for this */ > ! #if defined(__svr4__) || defined(_SCO_DS) || defined(__sun) > ! if (statfs( DOSDrives[drive].root, &info, 0, 0) < 0) > #else > if (statfs( DOSDrives[drive].root, &info) < 0) > #endif > --- 1301,1308 ---- > return 0; > } > > ! #ifdef HAVE_SYS_VFS_H Dito. > ! if (statvfs( DOSDrives[drive].root, &info) < 0) > #else Ciao, Marcus

1 0

Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
by John Wehle Jan. 18, 2003

Jan. 18, 2003

>On Fri, Jan 17, 2003 at 01:52:08PM -0500, John Wehle wrote: >> Currently wine exits after complaining about an invalid heap during >> startup on Solaris 8 x86. What happens is mmap is returning an address >> above 0xc0000000 which HEAP_InitSubHeap passes to NtAllocateVirtualMemory >> who rejects it. Perhaps someone familiar with the code can suggest >> a better solution or explain why the ADDRESS_SPACE_LIMIT check is there. > Correct me if I'm wrong, but AFAICS this is even the third time that you > submit this. Yep. > Don't you think that it would have been time to ask Alexandre > what the hell he's been thinking about constantly rejecting it ? ;-) Didn't know it had been rejected. I'm really not up on how wine development is done. In general I'm suppose to email julliard(a)winehq.com if I don't receive an ACK / NACK regarding a patch? -- John ------------------------------------------------------------------------- | Feith Systems | Voice: 1-215-646-8000 | Email: john(a)feith.com | | John Wehle | Fax: 1-215-540-5495 | | -------------------------------------------------------------------------

2 1

Check for block device in DRIVE_ReadSuperblock
by Michal Janusz Miroslaw Jan. 18, 2003

Jan. 18, 2003

I thought, that this may be useful to somebody ... If this patch were here before it would save me a few hours searching why every program hanged on commdlg open/save file dialogs ... I'm sending it here because I'm not sure whether I should be more/less paranoid and stat() the file before open() or not, or even if this check really should go into this function. Decide. ;) Changelog: [MQ] Add check for block device in DRIVE_ReadSuperblock Index: files/drive.c =================================================================== RCS file: /home/wine/wine/files/drive.c,v retrieving revision 1.83 diff -u -r1.83 drive.c --- files/drive.c 13 Jan 2003 20:44:13 -0000 1.83 +++ files/drive.c 18 Jan 2003 02:05:38 -0000 @@ -623,20 +623,36 @@ int fd; off_t offs; int ret = 0; + struct stat stat_buf; if (memset(buff,0,DRIVE_SUPER)!=buff) return -1; if ((fd=open(DOSDrives[drive].device,O_RDONLY)) == -1) { - struct stat st; if (!DOSDrives[drive].device) ERR("No device configured for drive %c: !\n", 'A'+drive); else ERR("Couldn't open device '%s' for drive %c: ! (%s)\n", DOSDrives[drive].device, 'A'+drive, - (stat(DOSDrives[drive].device, &st)) ? + (stat(DOSDrives[drive].device, &stat_buf)) ? "not available or symlink not valid ?" : "no permission"); ERR("Can't read drive volume info ! Either pre-set it or make sure the device to read it from is accessible !\n"); PROFILE_UsageWineIni(); return -1; + } + + /* MQ: I guess, we don't have to merge this call with the one above - some weird user + may try to swap the file before stat() and open() while we're not watching ;) + OTOH if we open FIFO we're stuck anyway, so FIXME */ + if (fstat(fd, &stat_buf) < 0) { /* shouldn't happen since we just opened that file */ + ERR("fstat() failed for opened device '%s' (drive %c:) ! IT SHOULDN'T HAPPEN !!!\n", + DOSDrives[drive].device, 'A'+drive); + ret = -1; + goto the_end; + } + if (!S_ISBLK(stat_buf.st_mode)) { + ERR("Device '%s' (drive %c:) is not a block device - check your config\n", + DOSDrives[drive].device, 'A'+drive); + ret = -1; + goto the_end; } switch(DOSDrives[drive].type)

1 0

Heap* in memory/heap.c
by Michal Janusz Miroslaw Jan. 18, 2003

Jan. 18, 2003

While checking why my new shiny man pages for HeapAlloc and friends didn't get generated, I found something weird. The functions HeapAlloc, HeapFree, (...) are redirected to ntdll equivalents RtlAllocateHeap, RtlFreeHeap, (...). There are more functions that are of return RtlXXX(args); type but are not forwarded in kernel32.spec. My questions: * Should the forwardings be added for the rest of functions ? * What about documenting them (and changing c2man.pl to support it) ? -- Michal Miroslaw

1 0

Getting a program to crash
by Duane Clark Jan. 17, 2003

Jan. 17, 2003

Howdy, I am trying to make a program crash ;) Instead, the program apparently captures exceptions, pops up a dialog, and continues on. I am hoping for a way to prevent that from happening, and instead falling into the debugger. It does call EXC_RtlRaiseException when the exception occurs, but it is not clear to me how that function works. Hopefully I can comment out something there to get it to crash properly?

2 1

wine-releases has gone?
by Mike Hearn Jan. 17, 2003

Jan. 17, 2003

Hi, On the Wine release notice it talks about a mailing list for large diffs between the releases, which would be useful for me (no cvs access at the moment at work), but the list appears to be dead, with no archives available. Is it still in use? -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

3 2

Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
by Andreas Mohr Jan. 17, 2003

Jan. 17, 2003

On Fri, Jan 17, 2003 at 01:52:08PM -0500, John Wehle wrote: > Currently wine exits after complaining about an invalid heap during > startup on Solaris 8 x86. What happens is mmap is returning an address > above 0xc0000000 which HEAP_InitSubHeap passes to NtAllocateVirtualMemory > who rejects it. Perhaps someone familar with the code can suggest > a better solution or explain why the ADDRESS_SPACE_LIMIT check is there. Correct me if I'm wrong, but AFAICS this is even the third time that you submit this. Don't you think that it would have been time to ask Alexandre what the hell he's been thinking about constantly rejecting it ? ;-) Have a nice day ! -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://mohr.de.tt

2 1

wine robustness?
by Dan Kegel Jan. 17, 2003

Jan. 17, 2003

Say, how much address space protection is there in Wine? If a Wine process follows a wild pointer or passes garbage arguments to a Windows function call, are Wineserver and the other wine processes protected? Imagine a user running Word, and also some less reliable windows program. When that other program crashes, it shouldn't take Word with it. One way to check that kind of protection is with programs like 'crashme': http://people.delphiforums.com/gjc/crashme.html Has anyone tried running crashme on wine yet? - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

2 1

Away for 9 days
by Dimitrie O. Paun Jan. 17, 2003

Jan. 17, 2003

Hi folks, I'll be away for 9 days starting tomorrow, skiing. Just in case you wonder whether I've fallen off the net. :) -- Dimi.

2 1

Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
by Dan Kegel Jan. 17, 2003

Jan. 17, 2003

John Wehle wrote: > Currently wine exits after complaining about an invalid heap during > startup on Solaris 8 x86. What happens is mmap is returning an address > above 0xc0000000 which HEAP_InitSubHeap passes to NtAllocateVirtualMemory > who rejects it. Perhaps someone familar with the code can suggest > a better solution or explain why the ADDRESS_SPACE_LIMIT check is there. See http://groups.google.com/groups?selm=%2Bjq*-eaVn%40news.virata.com Not that I know, but I suspect Wine is trying to avoid handing out pointers that Windows can't possibly hand out. I have a strong feeling of deja vu on this question... has it never been answered before? - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

system call tracing
by Dan Kegel Jan. 17, 2003

Jan. 17, 2003

This looks like an interesting tool: http://razor.bindview.com/tools/desc/strace_readme.html It only traces NT native calls, but what the hey, it comes with source. -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

Time
by Oliver Sampson Jan. 17, 2003

Jan. 17, 2003

Howdy, Forgive me if this is already known, but I checked the bug list and didn't see it. It would seem that when Agent makes a call to get the Wine system time, it's returned the BIOS time, but not the adjusted time zone. For example I have set in my KDE environment as the time and as CET (which is where I am.) You see that the time that this email was sent is actually around 15:32 instead of the real 16:32. Should I submit a bug? Thanks, ==================================================== Oliver Sampson olsam(a)quickaudio.com http://www.oliversampson.com

4 7

Re: Add check to SetMenuItemInfo
by Dmitry Timoshkov Jan. 17, 2003

Jan. 17, 2003

"Mike Hearn" <m.hearn(a)signal.qinetiq.com> wrote: > Fail SetMenuItemInfo if both MFT_BITMAP and MFT_SEPARATOR are > specified (an api violation). I thought that Alexandre will not commit this patch, since it's obviously wrong. > + if (lpmii->fType & (MFT_BITMAP | MFT_SEPARATOR)) { > + WARN("fType contains MFT_BITMAP and MFT_SEPARATOR, API violation\n"); > + return FALSE; > + } You are testing here whether either MFT_BITMAP or MFT_SEPARATOR is set, which is perfectly valid to specify one of them. If you want to test whether both flags are set simultaneously then use something like this: if ((lpmii->fType & (MFT_BITMAP | MFT_SEPARATOR)) == (MFT_BITMAP | MFT_SEPARATOR)) A conformance test to show the real behaviour is urgently required. -- Dmitry.

5 10

RE: wine-devel digest, Vol 1 #1607 - 14 msgs
by Robert Shearman Jan. 17, 2003

Jan. 17, 2003

> From: "=?ISO-8859-1?Q?J=FCrgen_Schmied?=" <juergen.schmied(a)debitel.net> > To: wine-devel(a)winehq.com > Date: Wed, 15 Jan 2003 13:25:12 +0100 > Subject: shell - drag&drop > Reply-To: juergen.schmied(a)debitel.net > > Hi! > > Since some people recently did work on shell32... > > Is anybody doing this stuff? Yes, I assume you mean IDragSourceHelper and I DropTargetHelper. I have a working IDragSourceHelper and I am just cleaning up the patch, but I fear that we may not have the underlying WS_EX_TRANSPARENT and WS_EX_LAYERED styles implemented that are needed for IDropTargetHelper. UpdateLayeredWindow is also not present, but making a stub for it would probably break a few apps. > juergen > -- > juergen.schmied(a)debitel.net > FAX über T-Online Fax&Fon: 01805 060 334 316 35 (12Cent/Min) Rob

1 0

Problems switching keyboards
by Shachar Shemesh Jan. 17, 2003

Jan. 17, 2003

Hi, I have a problem when working with a one keyboard option for language switching, and would like your help. I am using the default X11 IL keyboard. This keyboard has two layouts - US English one and an alternate IL Hebrew one. I have instructed X to switch between the keyboards when pressing both shifts (the full command was "setxkbmap -option grp:shift_toggle,grp:switch,grp_led:scroll il", and it should work on your machine assuming you have the he_IL locale compiled). The problem is this. When I run "notepad" with the proper LANG settings (LANG=he_IL wine --debugmsg +keyboard notepad), I can type English ok. I can also type Hebrew ok if I don't perform a permanent switch (i.e. - pressing the right Alt and typing produces Hebrew ok). If I do perform the permenant switch (pressing both shifts), I get all-caps. After switching back, I still get allcaps unless I press the caps lock. The only way to get out of this deadlock is by togelling to Hebrew, pressing the caps lock, and toggeling back. I get the following messages on toggle: trace:keyboard:X11DRV_ToUnicode Found keycode 50 (0x32) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000fe0a err:keyboard:X11DRV_ToUnicode Please report: no char for keysym FE0A (ISO_Prev_Group) : err:keyboard:X11DRV_ToUnicode (virtKey=10,scanCode=2A,keycode=32,state=2001) trace:keyboard:X11DRV_KeyEvent Ignoring ISO_Next_Group keyboard event trace:keyboard:X11DRV_KeyEvent Ignoring ISO_Next_Group keyboard event trace:keyboard:X11DRV_KeyEvent Ignoring ISO_Prev_Group keyboard event I am out of my depth here on X. I will also note that I am not using the currently compiled Israeli keymap, but I have applied the attached patch (which I cannot seem to debug) Any help will be apretiated. Shachar Index: dlls/x11drv/keyboard.c =================================================================== RCS file: /home/sun/sources/cvs/wine/dlls/x11drv/keyboard.c,v retrieving revision 1.17 diff -u -r1.17 keyboard.c --- dlls/x11drv/keyboard.c 7 Jan 2003 20:36:22 -0000 1.17 +++ dlls/x11drv/keyboard.c 17 Jan 2003 07:10:59 -0000 @@ -631,10 +631,10 @@ /*** Israeli keyboard layout */ static const char main_key_IL[MAIN_LEN][4] = { - "`~;","1!1","2(a)2","3#3","4$4","5%5","6^6","7&7","8*8","9(9","0)0","-_-","=+=", - "qQ/","wW'","eE÷","rRø","tTà","yYè","uUå","iIï","oOí","pPô","[{[","]}]", - "aAù","sSã","dDâ","fFë","gGò","hHé","jJç","kKì","lLê",";:ó","\'\",","\\|\\", - "zZæ","xXñ","cCá","vVä","bBð","nNî","mMö",",<ú",".>õ","/?." + "`~;~","1!1!","2(a)2@","3#3#","4$4$","5%5%","6^6^","7&7&","8*8*","9(9(","0)0)","-_-_","=+=+", + "qQ/Q","wW'W","eE÷E","rRøR","tTàT","yYèY","uUåU","iIïI","oOíO","pPôP","[{[{","]}]}", + "aAùA","sSãS","dDâD","fFëF","gGòG","hHéH","jJçJ","kKìK","lLêL",";:ó:","\'\",\"","\\|\\|", + "zZæZ","xXñX","cCáC","vVäV","bBðB","nNîN","mMöM",",<ú<",".>õ>","/?.?" }; /*** Greek keyboard layout (contributed by Kriton Kyrimis <kyrimis(a)cti.gr>)

1 0

Implementation of "start" command
by Dan Kegel Jan. 17, 2003

Jan. 17, 2003

I saw somebody at work type the following commandline in Windows: start notepad blah.c He said "It's the easiest way to bring up a random file in Notepad." Well, of course Wine should be able to do that, I realized when I woke up this morning, and I vowed to make it happen before I went to work today. So here's a quickie implementation of the start command. Seems to work... comments welcome. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.116 diff -d -u -r1.116 configure.ac --- configure.ac 4 Jan 2003 02:52:05 -0000 1.116 +++ configure.ac 16 Jan 2003 16:28:55 -0000 @@ -1497,6 +1497,7 @@ programs/regtest/Makefile programs/rpcss/Makefile programs/rundll32/Makefile +programs/start/Makefile programs/uninstaller/Makefile programs/view/Makefile programs/wcmd/Makefile Index: programs/Makefile.in =================================================================== RCS file: /home/wine/wine/programs/Makefile.in,v retrieving revision 1.33 diff -d -u -r1.33 Makefile.in --- programs/Makefile.in 4 Jan 2003 02:52:05 -0000 1.33 +++ programs/Makefile.in 16 Jan 2003 16:28:55 -0000 @@ -19,6 +19,7 @@ regtest \ rpcss \ rundll32 \ + start \ uninstaller \ view \ wcmd \ @@ -43,6 +44,7 @@ regsvr32 \ rpcss \ rundll32 \ + start \ uninstaller \ wcmd \ wineboot \ @@ -61,6 +63,7 @@ progman \ regedit \ regsvr32 \ + start \ uninstaller \ wcmd \ wineboot \ @@ -73,6 +76,7 @@ # Symlinks to apps that we want to run from inside the source tree SYMLINKS = \ + start.exe \ rpcss.exe \ wcmd.exe \ wineconsole.exe \ --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/Makefile.in 2003-01-16 08:20:35.000000000 -0800 @@ -0,0 +1,13 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +MODULE = start.exe +APPMODE = cui +IMPORTS = shell32 + +C_SRCS = start.c + +(a)MAKE_PROG_RULES@ + +### Dependencies: --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/start.c 2003-01-16 08:23:33.000000000 -0800 @@ -0,0 +1,59 @@ +/* + * Start a program using ShellExecute + * + * Copyright 2003 Dan Kegel + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include "config.h" +#include "wine/debug.h" + +#include <windows.h> +#include <stdio.h> +#include <stdlib.h> + +WINE_DEFAULT_DEBUG_CHANNEL(start); + +/* Placeholder implementation for now. */ + +int main(int argc, char *argv[]) +{ + char *program; + char *arguments; + HINSTANCE hres; + + if (argc == 1) { + printf("Usage: start file-or-program ...\n"); + exit(0); + } + if (argc > 3) { + WINE_FIXME("More than one argument not implemented"); + exit(1); + } + + program = argv[1]; + arguments = NULL; + if (argc == 3) + arguments = argv[2]; + + hres = ShellExecute(NULL, "open", program, arguments, NULL, SW_SHOWNORMAL); + if (((int)hres) <= 32) { + printf("Cannot execute %s %s, error %d\n", program, arguments?arguments:"", (int)hres); + exit(1); + } + + exit(0); +}

5 11

(no subject)
by J. Wesley Cleveland Jan. 16, 2003

Jan. 16, 2003

1 0

timegettime - WinMM.dll funciton
by Ann and Jason Edmeades Jan. 16, 2003

Jan. 16, 2003

I was trying to debug a DirectX8 simple sample, and found a bug in timegettime. Once this call has been made, my program never exits, probably because of the launched thread? Can anyone take a look at this? I'll happily test it :-) For now I have commented out that call and the pgm exits fine. It is also worth noting that the values I get back dont seem anything like on windows (I know the magnitude is based off when the timer thread gets kicked off, but I am talking about the deltas between two successive calls). Jason

1 0

shlwapi/path test compilation error
by Francois Gouget Jan. 16, 2003

Jan. 16, 2003

This test does not compile on Windows. There is a header include problem but changing them to the following solves the problem: #include "windef.h" #include "wtypes.h" #include "shlwapi.h" #include "wininet.h" #include "wine/test.h" #include "wine/unicode.h" However we then have problems with missing declarations on Windows: path.c(58) : warning C4013: 'UrlHashA' undefined; assuming extern returning int path.c(59) : warning C4013: 'UrlHashW' undefined; assuming extern returning int path.c(83) : warning C4013: 'UrlGetPartA' undefined; assuming extern returning int path.c(85) : warning C4013: 'UrlGetPartW' undefined; assuming extern returning int path.c(99) : error C2065: 'URL_PART_HOSTNAME' : undeclared identifier path.c(100) : error C2065: 'URL_PART_PORT' : undeclared identifier path.c(101) : error C2065: 'URL_PART_USERNAME' : undeclared identifier path.c(102) : error C2065: 'URL_PART_PASSWORD' : undeclared identifier path.c(103) : error C2065: 'URL_PART_SCHEME' : undeclared identifier path.c(104) : error C2065: 'URL_PART_QUERY' : undeclared identifier -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

1 0

Problem compiling current CVS on Redhat 8
by Martin Cracauer Jan. 16, 2003

Jan. 16, 2003

wine/dlls/comcat/: comcat_private.h:45: conflicting types for `ClassFactoryImpl' comcat.h:49: previous declaration of `ClassFactoryImpl' [more of same error for ther types] The two struct definitions actually are the same typedef struct { /* IUnknown fields */ ICOM_VFIELD(IClassFactory); DWORD ref; } ClassFactoryImpl; However, the gcc version 3.2 20020903 (Red Hat Linux 8.0 3.2-7) on Redhat 8 rejects the redefinition of the extern class which follows: extern ClassFactoryImpl COMCAT_ClassFactory; Is it neccessary to declare these types two times and/or include both *.h files? I also get this: gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -mpreferred-stack-boundary=2 -gstabs+ -fPIC -D__WINESRC__ -D_REENTRANT -o comcat_main.o comcat_main.c In file included from comcat.h:28, from comcat_private.h:29, from comcat_main.c:21: ../../include/wine/obj_base.h:26:2: #error DO NOT INCLUDE DIRECTLY Martin

1 0

Installing IE5.5
by Shachar Shemesh Jan. 16, 2003

Jan. 16, 2003

I managed to install IE5.5 using the following procedure: 1. Download the IE5.5 base install from MS 2. Set .wine/config as suggested a few days ago (ver=nt40, setupapi=builtin, *=native,builtin) 3. Using the latest Wine (20030115), run the setup tool 4. I, personally, made two sessions. One downloading everything, and the other for installing. 5. Install just the basic IE. No Connection wizard or anything else. 6. When setup finshes (and you get an error in processing the reboot) - wait for all wine instances to exit 7. run wineboot. 8. One of the programs initiated by wineboot fails to run (starts winedbg), just shut it down. 9. That's it - IE works, sortof. I'm hoping this proves useful to everyone. Shachar

1 0

RunOnceEx - is it necessary?
by Shachar Shemesh Jan. 16, 2003

Jan. 16, 2003

RunOnceEx is a key that is not available "by default" in Windows 95 and in Windows NT. Its processing is installed as part of the "IE integration" (shell integration?). When installing IE 5.5 on systype "nt40", these entries are processed by a rundll entry that was added to "runonce", even with wineboot as it is today. The question that needs to be answered is how important it is to add explicit support for it in wineboot? Shachar

1 0

WINE in CD-ROM
by Jelcyn Jan. 16, 2003

Jan. 16, 2003

Hi, I write a book about editing binary files (Hex Workshop, Resource Hacker etc.) to polish Helion publishing (www.helion.pl) Can I add in CD-ROM in my book wine ?? Damian Daszkiewicz

4 4

FHS vs LSB
by Tom Wickline Jan. 16, 2003

Jan. 16, 2003

In updating the Packagers Guide I plan to replace FHS with LSB any objections ? FHS = http://www.pathname.com/fhs/ LSB = http://www.linuxbase.org/ Tom

5 5

Help wanted: Implementing Wine dlls that need access to X11 commands.
by Robert North Jan. 16, 2003

Jan. 16, 2003

I'm about to start serious implementation on the wintab32 dll. I now need some guidance as to how best to implement it's access to X11 calls. My current thoughts on how to do this are given below. Are they reasonable?? I need to access a number of X11 calls, largely in the XInput extension. None of these are exposed by the x11drv dll. My intention is currently to change nothing in the x11drv dll. The only hints I can find about how to do this are from the direct draw and open gl dlls. These dlls can do the following: Get the X11 Display object of a gdi context. Get the X11 window handle given a win32 window handle. Synchronise with the x11_drv code for multi threading. My wintab code will do the same. The one difference will be that wintab will create it's own X11 Display objects. It will interrogate a gdi's X11 Display object to ensure it talks to the same screen. The wintab code will also require multiple message queues. To implement this I intend to use one display object per queue. (Much as wine uses one display object per thread) Hope I'm on the right track -Rob.

4 9

Re: Add filesytem type NTFS to config
by Andreas Mohr Jan. 16, 2003

Jan. 16, 2003

On Mon, Jan 13, 2003 at 09:06:28PM -0700, Tony Lambregts wrote: > Some program (VirtualDub) checks the fsname returned by > GetVolumeInformation, to find the name of the file system, when it needs > to write files that are larger than 2GB. It refuses to create the file > when we return FAT but will successfully write the file when NTSF is > returned. > > Change Log: add configuration option to report NTFS as the file system > type for a drive. Hmm, I'm not sure whether we should increase the preexisting Filesystem type mess by doing that. I've hated the "win95", "vfat" etc. syntax almost from the beginning (well, to be fair, I think I'm not too innocent when it comes to its implementation, but at some time I just came to the conclusion that it sucked) After all we're running on *Unix* file systems in many cases, so "win95" does have no place here at all ! (neither does "vfat") Not to mention that "win95" awfully collides with the "win95" winver... And adding yet another "incorrect" "ntfs" setting makes my head want to go bonkey ;-) So I guess that it might be a good idea to think about how to solve this configuration issue in a nicer way (and of course keep the old config capabilities for about 2 years in order to have backward compatibility). We might even want to think of introducing "nameless" filesystem type settings (instead of having "broken" conflicting and "wrong" FS type names). And of course it seems as if we also need a separate FS *name* setting in order to have Wine return "NTFS" instead of "FAT" in your case... So could we start a discussion about that perhaps ? > Files changed: documentation/samples/config > documnetation/configuring.sgml > files/drive.c Finally a beautifully implemented patch ! I hate having to clean up the docu "after the fact". > -;; DON'T use "unix" unless you intend to port programs using Winelib ! > +;; - "ntfs" for ext2fs (some program need this to write files > 2GB) ^^^^^^^^ urks ! a significant portion of unix FS users don't even use ext2fs... > +;; - "unix" DO NOT USE unless you intend to port programs using Winelib ! Somehow that setting is also quite some pain... Andreas Mohr

10 19

Re: Problems install ie5+ie6
by Brian Vincent (C) Jan. 15, 2003

Jan. 15, 2003

> I downloaded the latest wine cvs tonight and compiled it on my windows-less > system. I ran ie6setup and ie5setup.exe and it downloads the data from the > web but has problems during installation. If your goal is to just run IE, then you may find this helpful: http://frankscorner.org/wine/modules.php?op=modload&name=Sections&file=index &req=viewarticle&artid=125&page=1 If you're actually trying to hack Wine into getting it to work.. well.. I suppose there's a lot of others on this list that can help you more. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

2 1

'95 and 2000 conformance test results
by Susan Pierce Jan. 15, 2003

Jan. 15, 2003

Hello, I've attached the results of my Wine conformance testing. I'm sending in my text based Wordpad files because I did not see a recommended format for result submission. Is there one? I briefly considered hacking the html table and returning that as an attachment. Then I gave up and decided you would just like the info. Also, there is a problem on both my machines when I display the nice table of results: ntdll/rtlbitmap, ntdll/rtlstr, oleaut32/safearray, oleaut32/vartest, and rpcrt4/rpc show up in the html source but are not displayed by IE. I stared at the source for a while but I do not know enough html to be dangerous, let alone figure it out. I've downloaded the Wine source and thought I'd try my hand at fixing some of the problems. This has been fun. Thanks, Susan

1 0

RE: The version info patches + d3d question
by Patrik Stridvall Jan. 15, 2003

Jan. 15, 2003

> Hi, > The patches add version info to directx libraries. > some games(for instance lucasarts games) wont run without > finding a valid > version of the directx files. OK. > the problem is they dont run even with the patches because > they cant get > version info from d3dim.dll and probably other d3d dlls. Yes, there are a lot of them, but don't see we any choice, but to do what I suggest below. > since wine doesnt have these dlls how can wine give these > programs the needed > info or is it planned to split ddraw in a ddraw and a d3d component? We simply have to create one new directory in dlls/ for each DirectX dll with an appropriate .spec file and a version.rc. This would be quite easy to do AFAICS. Are you voluntering?

2 1

New tests failing ...
by Paul Millar Jan. 15, 2003

Jan. 15, 2003

Hi everyone, Just a quick note to say the new conformance tests (in dlls/winspool/tests/info.c) are failing for Wine running as NT-like OSes. For NT351, the results are: info.c:61: Test failed 1 of 1 time (100%): [test instance 1] info.c:61: Test failed: expected result == 0, got 1 info.c:62: Test failed 1 of 1 time (100%): [test instance 1] info.c:62: Test failed: last error set to 87 instead of ERROR_INVALID_USER_BUFFER info.c:74: Test failed 1 of 1 time (100%): [test instance 1] info.c:74: Test failed: expected result == 0, got 1 info.c:75: Test failed 1 of 1 time (100%): [test instance 1] info.c:75: Test failed: last error set to 87 instead of RPC_X_NULL_REF_POINTER info.c:84: Test failed 1 of 1 time (100%): [test instance 1] info.c:84: Test failed: expected result == 0, got 1 info.c:85: Test failed 1 of 1 time (100%): [test instance 1] info.c:85: Test failed: last error set to 87 instead of RPC_X_NULL_REF_POINTER The others fail in the same way. See http://www.astro.gla.ac.uk/users/paulm/WRT/buildinfo.php?id=292 and http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php for more details. Cheers, Paul. ---- Paul Millar

1 0

shell - drag&drop
by Jürgen Schmied Jan. 15, 2003

Jan. 15, 2003

Hi! Since some people recently did work on shell32... Is anybody doing this stuff? juergen -- juergen.schmied(a)debitel.net FAX über T-Online Fax&Fon: 01805 060 334 316 35 (12Cent/Min)

1 0

gcc 3.2 warnings
by Dimitrie O. Paun Jan. 15, 2003

Jan. 15, 2003

Folks, Currently I am real busy, so I can't fix these myself, but if anyone is so inclined, here are the warnings I get with gcc 3.2 on a RedHat 8.0 system: ../../../wine.src/dlls/d3d8/device.c: In function `DrawPrimitiveI': ../../../wine.src/dlls/d3d8/device.c:475: warning: statement with no effect ../../../wine.src/dlls/ddraw/ddraw/hal.c:152: warning: initialization from incompatible pointer type ../../../../wine.src/dlls/ntdll/tests/rtlstr.c: In function `test_RtlUnicodeStringToInteger': ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:147: warning: decimal constant is so large that it is unsigned ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:148: warning: decimal constant is so large that it is unsigned ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:170: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:175: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:176: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:178: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:179: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:181: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:182: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:184: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/ntdll/tests/rtlstr.c:185: warning: wchar_t format, different type arg (arg 3) ../../../../wine.src/dlls/user/tests/sysparams.c: In function `run_spi_setmouse_test': ../../../../wine.src/dlls/user/tests/sysparams.c:238: warning: `rc' might be used uninitialized in this function ../../../../wine.src/include/winbase.h: At top level: ../../../../wine.src/dlls/user/tests/sysparams.c:379: warning: `test_SPI_SETBORDER' defined but not used ../../../wine.src/dlls/oleaut32/variant.c: In function `VarBstrFromDate': ../../../wine.src/dlls/oleaut32/variant.c:3567: warning: `%x' yields only last 2 digits of year in some locales ../../../wine.src/dlls/oleaut32/variant.c:3571: warning: `%x' yields only last 2 digits of year in some locales In file included from ../../../wine.src/include/mssip.h:49, from ../../../wine.src/dlls/crypt32/main.c:22: ../../../wine.src/include/pshpack8.h:47:6: warning: #warning "8 as alignment is not supported" In file included from ../../../wine.src/include/mssip.h:80, from ../../../wine.src/dlls/crypt32/main.c:22: ../../../wine.src/include/pshpack8.h:47:6: warning: #warning "8 as alignment is not supported" In file included from ../../../wine.src/include/mssip.h:88, from ../../../wine.src/dlls/crypt32/main.c:22: ../../../wine.src/include/pshpack8.h:47:6: warning: #warning "8 as alignment is not supported" In file included from ../../../wine.src/include/mssip.h:97, from ../../../wine.src/dlls/crypt32/main.c:22: ../../../wine.src/include/pshpack8.h:47:6: warning: #warning "8 as alignment is not supported" In file included from ../../../wine.src/include/mssip.h:109, from ../../../wine.src/dlls/crypt32/main.c:22: ../../../wine.src/include/pshpack8.h:47:6: warning: #warning "8 as alignment is not supported" In file included from ../../../wine.src/include/mssip.h:123, from ../../../wine.src/dlls/crypt32/main.c:22: ../../../wine.src/include/pshpack8.h:47:6: warning: #warning "8 as alignment is not supported" In file included from ../../../wine.src/include/mssip.h:140, from ../../../wine.src/dlls/crypt32/main.c:22: ../../../wine.src/include/pshpack8.h:47:6: warning: #warning "8 as alignment is not supported" -- Dimi.

3 2

Two Simple Qs ?
by mohanad al-shayeb Jan. 15, 2003

Jan. 15, 2003

Hi all, As most of you know, the client needs to send some requests to accomplish some special tasks which could not be handled by the client itself. Qs: 1. Why this could not by the client itself ? [may be it is better to save memory by centelizing the shared code in the server ] 2. How and when the server is loaded? Thanx for your help in advance, _________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail

2 1

Re: Change Russian keyboard codepage (bug #1213)
by Dmitry Timoshkov Jan. 14, 2003

Jan. 14, 2003

"Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote: > change main Russian keyboard layout to use codepage 1251 instead of > 20866. See bug #1213. This is completely wrong. The bug reporter (and it seems you too) doesn't understand the difference between the code page which is used by the underlying system (and therefore by the keyboard driver) and the code page in which characters are sent to the aplication. -- Dmitry.

1 0

Winedbg: Open Xterm when Controlling console no more available
by Uwe Bonnes Jan. 14, 2003

Jan. 14, 2003

Hallo Eric, another winedbg feature request: When the starting application spawns off other processes and exec itself, with the other spawned processes still running, and one of these processes crashes, and winedbg is configured to work on the starting console, winedbg starts, loads all dll, but then exits immediate due to the missing console. In this situation, winedbg should test if console access is still possible, and when not, it should start magically an xterm. I still prefer to use the console for winedbg interaction, as scrolling is easier. Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by Alexandre Julliard Jan. 14, 2003

Jan. 14, 2003

liu spider <liuspider(a)yahoo.com> writes: > short WINAPI GetFileTitleA(LPCSTR lpFile, LPSTR lpTitle, UINT cbBuf) > { > - int i, len; > + int ret; > + UNICODE_STRING strWFile, strWTitle; > + RtlCreateUnicodeStringFromAsciiz(&strWFile, lpFile); > + RtlCreateUnicodeStringFromAsciiz(&strWTitle,lpTitle); > + ret = GetFileTitleW(strWFile.Buffer, strWTitle.Buffer, cbBuf * sizeof(WCHAR)); lpTitle is an output parameter, you can't convert it to Unicode on input, you should allocate a buffer instead. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Bug Fix With Delay load function in Shell32
by j.schmied＠t-online.de Jan. 14, 2003

Jan. 14, 2003

Hi! This isn't the best solution since GetShellOle() initializes the ole subsystem by calling OleInitialize(). This is not nessesary for _CoCreateInstance(). Bye Juergen > > This fixes a bug in Shell32 where one function caused the function > responsible for setting up the delay load function pointers to assume they > had already been loaded, and they hadn't. > Maybe we should make the hShellOle32 variable static so this can't happen > again. > > ChangeLog: > - Set up all delay load functions in GetShellOle() function to avoid > GetShellOle assuming that they were all loaded when they weren't > > Rob > -- juergen.schmied(a)debitel.net FAX über T-Online Fax&Fon: 01805 060 334 316 35 (12Cent/Min)

6 8

Wine and Windows error code
by mpfbk＠free.fr Jan. 14, 2003

Jan. 14, 2003

Tests of win32 API returned error codes inside Wine This subject has maybe been treated before, sorry if it has already been discussed and closed. Running the following simple and standard program, nothing special happens: the windows opens itself, it can be closed with the close button, and the message box is displayed when the left mouse button is pressed inside the window. /* * testbed1_ref.c * */ #define STRICT #include <windows.h> const char g_szClassName[] = "testbed1WindowClass"; /* ============================================================ */ static void ErrorBox(LPCSTR msg) { LPVOID error_msg; DWORD error_code; char error_buffer[256]; error_code = GetLastError(); FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, NULL, error_code, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPTSTR) &error_msg, 0, NULL ); /* TBC: should be snprintf */ sprintf(error_buffer, "%s: %d:%s", msg, error_code, error_msg); MessageBox(NULL, error_buffer, "Error!", MB_ICONEXCLAMATION | MB_OK); LocalFree( error_msg ); } /* ============================================================ */ LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch(msg) { case WM_LBUTTONDOWN: { char szFileName[MAX_PATH]; HINSTANCE hInstance; if(IsDebuggerPresent()) { MessageBox(NULL, "Running under debugger control", "Debug!", MB_ICONINFORMATION | MB_OK); } else { OutputDebugString(TEXT("No debugger, but 'OutputDebugString' works, since you see this (in DBWin32 for instance)")); } hInstance = GetModuleHandle(NULL); GetModuleFileName(hInstance, szFileName, MAX_PATH); MessageBox(hwnd, szFileName, "This program is:", MB_OK | MB_ICONINFORMATION); } break; case WM_CLOSE: DestroyWindow(hwnd); break; case WM_DESTROY: PostQuitMessage(0); break; default: return DefWindowProc(hwnd, msg, wParam, lParam); } return 0; } /* ============================================================ */ int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { WNDCLASSEX wc; HWND hwnd; MSG Msg; /* Register the Window Class */ wc.cbSize = sizeof(WNDCLASSEX); wc.style = 0; wc.lpfnWndProc = WndProc; wc.cbClsExtra = 0; wc.cbWndExtra = 0; wc.hInstance = hInstance; wc.hIcon = LoadIcon(NULL, IDI_APPLICATION); wc.hCursor = LoadCursor(NULL, IDC_ARROW); wc.hbrBackground = (HBRUSH)(COLOR_WINDOW+1); wc.lpszMenuName = NULL; wc.lpszClassName = g_szClassName; wc.hIconSm = LoadIcon(NULL, IDI_APPLICATION); if(!RegisterClassEx(&wc)) { ErrorBox("Window Class Registration Failed!"); return 0; } /* Create the Window */ hwnd = CreateWindowEx(WS_EX_CLIENTEDGE, g_szClassName, "The title of my window", WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, 240, 120, NULL, NULL, hInstance, NULL); if(hwnd == NULL) { ErrorBox("Window Creation Failed"); return 0; } ShowWindow(hwnd, nCmdShow); UpdateWindow(hwnd); /* Run Message Loop */ while(GetMessage(&Msg, NULL, 0, 0) > 0) { TranslateMessage(&Msg); DispatchMessage(&Msg); } return Msg.wParam; } What is a little bit unusual is the ErrorBox function : often, a message box simply reports the error and aborts the program. ErrorBox uses GetLastError() and FormatMessage() to provide somewhat more information. By accident, let's make an error, commenting out the RegisterClassEx() call : #if 0 if(!RegisterClassEx(&wc)) { ErrorBox("Window Class Registration Failed!"); return 0; } #endif Under Windows (tested with NT4 and XP), the displayed message (by ErrorBox) is: == Window Creation Failed: 1407: Can't find window class == But, under wine (20021219), the displayed message is, unfortunately : == Window Creation Failed: 0: No error == While looking inside the wine sources, it appears that no error code is set in the functions 'CreateWindowExA' in windows/win.c file when the window's class is not found : an error message is printed and 0 is returned. The following adds the appropriate error code in function CreateWindowExA : around line 1291 and 1301: SetLastError(ERROR_CANNOT_FIND_WND_CLASS); before the return 0; Questions : does it have any interest for wine to add these error codes ? If yes, according to DLL separation, is it allowed to call SetLastError() in any context ? Should I submit a patch ? Any other feedback ?

2 1

problem building tests with msvc6
by Dan Kegel Jan. 14, 2003

Jan. 14, 2003

Trying to build conformance tests on Windows Me with msdev6, but got the following link errors: safearray.obj : error LNK2001: unresolved external symbol _IID_IStorage safearray.obj : error LNK2001: unresolved external symbol _IID_IDispatch safearray.obj : error LNK2001: unresolved external symbol _IID_IUnknown Output\Win32_Wine_Headers/oleaut32_test.exe : fatal error LNK1120: 3 unresolved externals Any suggestions? (Sorry to act so helpless...) FWIW, here's the full recipe I followed: On linux: cd ~/wine msvcmaker --no-wine find *.dsp *.dsw include */*/tests -name CVS -prune -o -type f -not -name '*.o' -not -name '*.so' -not -name '*.ok' -not -name '*.spec.c' -print | cpio -oH tar | gzip > wtest.tgz sudo cp wtest.tgz /dos/c reboot On Windows Me: (install msvc6) (install cygwin) cd c:/ mkdir wtest cd wtest tar -xzvf ../wtest.tgz start c:/wtest/wineruntests.dsw rebuild all -- Dan Kegel Linux User #78045 http://www.kegel.com

5 18

Problem with interrupt vector
by Gustavo Junior Alves Jan. 14, 2003

Jan. 14, 2003

Hi, Since 20021107, some programs is not functional anymore. The problem begins with change of INT_GetPMHandler to DOSVM_GetPMHandler16. When the function try to read the interrupt vector, the app crashs, with following error message: Unhandled exception: page fault on read access to 0x00000090 in 32-bit code (0x41cc7cb3). In 32-bit mode. 0x41cc7cb3 (WINEDOS.DLL.EmulateInterruptPM+0x30b in winedos.dll.so): movl 0x0(,%eax,4),%eax Any ideas about this problem?? How I can fix this? Thanks, Gustavo Junior Alves alves(a)coslinux.com.br

2 4

Restarting winedbg
by Uwe Bonnes Jan. 14, 2003

Jan. 14, 2003

Hallo (Eric), is there another way of restarting a debugged process than to quit winedbg and restart the whole thing? All the dll need to get reparsed, all breakpoint need to get set up again. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1