January 2003 - Wine-Devel - list.winehq.org

Re: Add filesytem type NTFS to config
by Mike Hearn Jan. 14, 2003

Jan. 14, 2003

Just curious tony, but if that's the case why doesn't Wine return NTFS all the time? Are there some apps that actually won't run if it returns NTFS at all? On Tue, 2003-01-14 at 04:06, Tony Lambregts wrote: > Some program (VirtualDub) checks the fsname returned by > GetVolumeInformation, to find the name of the file system, when it needs > to write files that are larger than 2GB. It refuses to create the file > when we return FAT but will successfully write the file when NTSF is > returned. > > Change Log: add configuration option to report NTFS as the file system > type for a drive. > > Files changed: documentation/samples/config > documnetation/configuring.sgml > files/drive.c -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

1 0

Re: patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by Dimitrie O. Paun Jan. 14, 2003

Jan. 14, 2003

On January 13, 2003 09:02 pm, liu spider wrote: > (The patch seems to be ignored without any comments. > Could anyone give some clues on how to improve this > patch? thanks.) If no one complained, it's probably OK until Alexandre gets around to it. He can't reply in real time, wait for a few days. If you see commits going in (subscribe to, or check the mail archives for wine-cvs(a)winehq.org to monitor the checkins) and yours is not applied, email and ask him what's up. -- Dimi.

2 1

[D3D status] Page update...
by Lionel Ulmer Jan. 14, 2003

Jan. 14, 2003

Hi all, I updated the D3D status page (http://www.bbrox.org/d3d_status.html) with some new screenshots and some new demos. Nothing revolutionnary though :-) Thanks to Christian for the 3D Mark 2000 paragraph. Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Wine, Mozilla & IE ?
by Juan Rey Saura Jan. 14, 2003

Jan. 14, 2003

Hi ! I've read in the list there is a project about compiling Mozilla under Wine, I think it would be great. Several parts of wine need an IWebBrowser implemtation; CHM support, some applications... One implementation based on the khtml is in the works, but Mozilla does implement it yet ( see http://www.iol.ie/~locka/mozilla/mozilla.htm ). Could Mozilla, under Wine or maybe native version, be used as a replacement for the IE IWebBrowser implementation?

10 18

WineMine wrc error
by John Westerman Jan. 14, 2003

Jan. 14, 2003

Hi, I seem to have a bit of trouble building the winemine sample. When it gets to the wrc stage it just says: make: *** [rsrc.res] Error 1 Any ideas?

1 0

Re: distcc and wine
by Martin Pool Jan. 13, 2003

Jan. 13, 2003

On 8 Jan 2003, Paul Millar <paulm(a)astro.gla.ac.uk> wrote: > Hi Martin, > > On a similar note, I've been investigating OpenMOSIX on and off (mostly > off) for doing distributed compiling. In general, I've found it not > particularly stable (although its improving) and the performance not > particularly great -- although I've not had time to investigate the causes > of these problems. Besides, compiling code is quite a tricky task for it > to schedule/migrate. I haven't tried it myself but I would have expected the short, intense jobs generated by compilation to be a problem. > A reduction in compilation time by a factor of 2.6 (for three machines) > isn't bad at all! > > If you have the time, could you repeat this with different values for the > -j option? Timing how long it takes with -j2 (and perhaps -j3 and -j4) > would be interesting. Yes, I've been meaning to add that to the benchmark tool. I'll let you know. > Also, repeat the compilation several times for each value of -j and taking > the mean and standard deviation would be interesting too. In informal measurements it seems to be quite reproducible. The sd is typically only a few percent of the overall time. But that might be an interesting option to add too. -- Martin

2 2

Re: prevent dereferencing null
by Dimitrie O. Paun Jan. 13, 2003

Jan. 13, 2003

On January 9, 2003 07:08 pm, Bill Medland wrote: > + if (!tpinfo->chanbuf) { > + ERR("tpinfo has no Rpc Channel Buffer\n"); > + return 0; > + } Is this expected behaviour? If so, there's no need for the ERR msg. If not, there's no need for the test, we need to fix the root cause... -- Dimi.

3 4

patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by liu spider Jan. 13, 2003

Jan. 13, 2003

Thanks to Dmitry Timoshkov. This patch is the second edition, adopted his suggestions. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW GetFileTitleA now is a call to GetFileTitleW (The patch seems to be ignored without any comments. Could anyone give some clues on how to improve this patch? thanks.) liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com Index: dlls/commdlg/filetitle.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/filetitle.c,v retrieving revision 1.12 diff -u -r1.12 filetitle.c --- dlls/commdlg/filetitle.c 31 May 2002 23:25:45 -0000 1.12 +++ dlls/commdlg/filetitle.c 12 Jan 2003 07:09:56 -0000 @@ -3,6 +3,7 @@ * * Copyright 1994 Martin Ayotte * Copyright 1996 Albrecht Kleine + * Copyright 2003 liuspider * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -24,10 +25,10 @@ #include "winbase.h" #include "winnls.h" #include "commdlg.h" +#include "wine/unicode.h" +#include "winternl.h" #include "wine/debug.h" -#include "heap.h" /* Has to go */ - WINE_DEFAULT_DEBUG_CHANNEL(commdlg); #include "cdlg.h" @@ -38,19 +39,39 @@ */ short WINAPI GetFileTitleA(LPCSTR lpFile, LPSTR lpTitle, UINT cbBuf) { - int i, len; + int ret; + UNICODE_STRING strWFile, strWTitle; + RtlCreateUnicodeStringFromAsciiz(&strWFile, lpFile); + RtlCreateUnicodeStringFromAsciiz(&strWTitle,lpTitle); + ret = GetFileTitleW(strWFile.Buffer, strWTitle.Buffer, cbBuf * sizeof(WCHAR)); + if (!ret){ + WideCharToMultiByte( CP_ACP, 0, strWTitle.Buffer, -1, lpTitle, cbBuf, NULL, NULL ); + } + RtlFreeUnicodeString( &strWFile ); + RtlFreeUnicodeString( &strWTitle ); + return ret; +} + +/*********************************************************************** + * GetFileTitleW (COMDLG32.@) + * + */ +short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) +{ + int i, len; + WCHAR brkpoint[] = {'*','[',']'}; TRACE("(%p %p %d); \n", lpFile, lpTitle, cbBuf); if(lpFile == NULL || lpTitle == NULL) return -1; - len = strlen(lpFile); + len = strlenW(lpFile); if (len == 0) return -1; - if(strpbrk(lpFile, "*[]")) + if(strpbrkW(lpFile, brkpoint)) return -1; len--; @@ -70,34 +91,14 @@ if(i == -1) i++; - TRACE("---> '%s' \n", &lpFile[i]); + TRACE("---> '%s' \n", debugstr_w(&lpFile[i])); - len = strlen(lpFile+i)+1; + len = strlenW(lpFile+i)+1; if(cbBuf < len) return len; - strncpy(lpTitle, &lpFile[i], len); + strncpyW(lpTitle, &lpFile[i], len); return 0; -} - - -/*********************************************************************** - * GetFileTitleW (COMDLG32.@) - * - */ -short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) -{ - LPSTR file = HEAP_strdupWtoA(GetProcessHeap(), 0, lpFile); /* Has to go */ - LPSTR title = HeapAlloc(GetProcessHeap(), 0, cbBuf); - short ret; - - ret = GetFileTitleA(file, title, cbBuf); - - if (cbBuf > 0 && !MultiByteToWideChar( CP_ACP, 0, title, -1, lpTitle, cbBuf )) - lpTitle[cbBuf-1] = 0; - HeapFree(GetProcessHeap(), 0, file); - HeapFree(GetProcessHeap(), 0, title); - return ret; }

1 0

Re: tests for GetPrinterDriverDirectoryA
by Francois Gouget Jan. 13, 2003

Jan. 13, 2003

On Mon, 13 Jan 2003, Stefan Leichter wrote: > Am Montag 13 Januar 2003 18:42 schrieben Sie: > > On Sun, 12 Jan 2003, Stefan Leichter wrote: > > > Am Sonntag 12 Januar 2003 02:43 schrieben Sie: [...] > > > > However it fails on Wine: > > > > info.c:25: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:30: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:34: Test failed: expected result == 0, got 18 > > > > info.c:35: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:48: Test failed: expected result != 0, got 0 > > > > info.c:71: Test failed: expected result != 0, got 0 > > after this patch wine will fix the errors listed above Yep, that works. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

Re: Help with /?? stuff
by Alberto Massari Jan. 13, 2003

Jan. 13, 2003

At 20.24 10/01/2003 +0200, Shachar Shemesh wrote: >Alberto Massari wrote: > >[...] >> >>BTW, do you need any help on this task? > >"Need" is a strong term. I can complete the task on my own, but your help >will be most welcome (in other words, if there is another aread of Wine >that needs your attention and noone seems to be working on, that would be >a better use of everyone's time). If you want to help with wineboot, I >think the best place to start is with the "win.ini" processing, and then >to port Andy's function to run whole "run" keys to the new prog. > >If you do decide to help with wineboot, please email me in private when >starting to work on each activity, to prevent "competition" on writing >stuff in. Unfortunately I'm currently fully booked on trying to fix the bugs that prevent ole32 and shell32 from working with IE6; but installing IE6 needs a working wineboot, so, whenever I succeed in the first task, I will start working on wineboot. Alberto

3 11