November 2003 - Wine-Devel - list.winehq.org

Re: regedt: fix couple of HeapReAlloc()s
by Steven Edwards Nov. 21, 2003

Nov. 21, 2003

I think HeapReAlloc problem exists in the listbox control. We have a patch in ReactOS CVS for it but I dont have time to try and merge it. Thanks Steven --- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > ChangeLog > HeapReAlloc() does not allocate memory. > > Index: programs/regedit/regproc.c __________________________________ Do you Yahoo!? Free Pop-Up Blocker - Get it now http://companion.yahoo.com/

2 1

include files
by Ralf Juengling Nov. 21, 2003

Nov. 21, 2003

A Makefile created by winemake & configure adds /whereever/include/wine/windows to the include paths. Why doesn't it also add /whereever/include/wine/msvcrt ? What is the status of the include files in msvcrt? Ralf -- Ralf Juengling <juenglin(a)cse.ogi.edu>

3 5

Re: _end Symbol and Mac OS X
by Alexandre Julliard Nov. 21, 2003

Nov. 21, 2003

"Pierre d'Herbemont" <stegefin(a)free.fr> writes: > On Mac OS X There is no _end symbol. There is a convenience function > get_end() to replace it, mainly because of the Mach-O file format. So > we have to get the value of get_end at launch time and store it in the > nt_header. Does get_end really return the _end value of the current library? I suspect it returns the value for the main executable in all cases, which is not what we need here. -- Alexandre Julliard julliard(a)winehq.com

2 2

Windows programs no more running with the new wine-glibc
by Sylvain Petreolle Nov. 20, 2003

Nov. 20, 2003

With yesterday cvs update, whch adds a glibc-threading detection, wine doesnt load a _Windows_ program anymore. Using the RedHat rpm Yarrow kernel, I get : err:virtual:map_image Standard load address for a Win32 program (0x00400000) not available - security-patched kernel ? wine: could not load L"C:\\arakas.exe" as Win32 binary Funny thing : If I set up a symlink to the wine-glibc in another directory, it works without problems. [syl(a)wine c]$ ls -l /usr/local/bin/wine /home/wine/loader/wine-* -rwxr-xr-x 1 syl wine 97265 nov 13 20:08 /home/wine/loader/wine-glibc -rwxr-xr-x 1 syl wine 156037 nov 13 20:08 /home/wine/loader/wine-kthread -rwxr-xr-x 1 syl wine 109482 nov 13 20:08 /home/wine/loader/wine-pthread -rwxr-xr-x 1 root root 97265 nov 13 20:29 /usr/local/bin/wine With plain binary, not working : [syl(a)wine c]$ which wine /usr/local/bin/wine [syl(a)wine c]$ wine arakas.exe err:virtual:map_image Standard load address for a Win32 program (0x00400000) not available - security-patched kernel ? wine: could not load L"C:\\arakas.exe" as Win32 binary With the symlink : [syl(a)wine c]$ ls -l /c/wine lrwxrwxrwx 1 syl wine 28 nov 13 20:41 /c/wine -> /home/wine/loader/wine-glibc [syl(a)wine c]$ ./wine arakas.exe fixme:keyboard:X11DRV_KEYBOARD_DetectLayout Your keyboard layout was not found! Using closest match instead (French keyboard layout) for scancode mapping. Please define your layout in dlls/x11drv/keyboard.c and submit them to us for inclusion into future Wine releases. See the Wine User Guide, chapter "Keyboard" for more information. Any thoughts ? ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

3 5

removed problem with OpenGL extensions under X11
by Daniel Skorka Nov. 20, 2003

Nov. 20, 2003

This patch fixes a problem with bad OpenGL libraries wich uncorrectly report the Extensions they support. Those libs would incorrectly report not supporting glXGetProcAddresARB, on which wine relies for OpenGL extension support. The problem was noticed with libGL from XFree86 4.2 under Linux x86. ChangeLog: * dlls/opengl32/wgl.c: Daniel Skorka <skorka(a)gmx.net> Fixed a problem using glXGetProcAddresARB with bad OpenGL libs. ---snip--- ? patch.diff ? miscemu/Makefile Index: dlls/opengl32/wgl.c =================================================================== RCS file: /home/wine/wine/dlls/opengl32/wgl.c,v retrieving revision 1.39 diff -u -u -r1.39 wgl.c --- dlls/opengl32/wgl.c 17 Sep 2003 20:04:25 -0000 1.39 +++ dlls/opengl32/wgl.c 20 Nov 2003 22:33:51 -0000 @@ -671,12 +671,12 @@ XFree(vis); LEAVE_GL(); - if ((extensions != NULL) && (strstr(extensions, "GLX_ARB_get_proc_address"))) { - opengl_handle = wine_dlopen(SONAME_LIBGL, RTLD_NOW|RTLD_GLOBAL, NULL, 0); - if (opengl_handle != NULL) { - p_glXGetProcAddressARB = wine_dlsym(opengl_handle, "glXGetProcAddressARB", NULL, 0); - wine_dlclose(opengl_handle, NULL, 0); - } + opengl_handle = wine_dlopen(SONAME_LIBGL, RTLD_NOW|RTLD_GLOBAL, NULL, 0); + if (opengl_handle != NULL) { + p_glXGetProcAddressARB = wine_dlsym(opengl_handle, "glXGetProcAddressARB", NULL, 0); + wine_dlclose(opengl_handle, NULL, 0); + if (p_glXGetProcAddressARB == NULL) + TRACE("could not find glXGetProcAddressARB in libGL.\n"); } if (default_cx == NULL) { ---snip---

1 1

Re: wineps: fix a few HeapReAlloc()s
by Huw D M Davies Nov. 20, 2003

Nov. 20, 2003

On Thu, Nov 20, 2003 at 03:33:48PM -0500, Dimitrie O. Paun wrote: > Huw, > I didn't dig deep enough to see if glyphList/->glyph_sent > can't be NULL at that point, but it wasn't obvious to me > that they can't. You know this part a lot better than myself, > can you please check that I'm not adding extranous uglifying > bits to the code? Hi Dimi, All of these are unnecessary afaics. glyphList gets alloc'ed in GlyphListInit and the two glyph_sent's are alloc'ed in T{1|42}_download_header Huw.

2 1

[624] Agent 2.0 Beta Dialog crashes
by Gerhard W. Gruber Nov. 20, 2003

Nov. 20, 2003

When I download newsgroup articles and I selecte any article in any newsgroup, then right-click and choose Index from the context menu, Agent crashes. This works under Windows, so this is a Wine problem. Maybe it will crash also when not downloading, just to open that dialog. I haven't tried this yet, but I would bet this is the case. -- Gerhard Gruber Maintainer of SoftICE for Linux - http://sourceforge.net/projects/pice Fast application launcher - http://sourceforge.net/projects/launchmenu

2 2

Re: rpcrt4: fix NULL pointer access
by Gregory M. Turner Nov. 20, 2003

Nov. 20, 2003

On Thursday 20 November 2003 02:26 pm, Dimitrie O. Paun wrote: > Ran into this while browsing the code, it seems to > be a NULL pointer reference waiting to happen. > Am I missing something? > > ChangeLog > Bail when we're out of memory. > > Index: dlls/rpcrt4/rpc_binding.c > =================================================================== > RCS file: /var/cvs/wine/dlls/rpcrt4/rpc_binding.c,v > retrieving revision 1.15 > diff -u -r1.15 rpc_binding.c > --- dlls/rpcrt4/rpc_binding.c 7 Oct 2003 22:54:17 -0000 1.15 > +++ dlls/rpcrt4/rpc_binding.c 20 Nov 2003 06:33:52 -0000 > @@ -516,7 +516,11 @@ > { > DWORD len = strlen(dst), slen = strlen(src); > LPSTR ndst = HeapReAlloc(GetProcessHeap(), 0, dst, > (len+slen+2)*sizeof(CHAR)); - if (!ndst) HeapFree(GetProcessHeap(), 0, > dst); > + if (!ndst) > + { > + HeapFree(GetProcessHeap(), 0, dst); > + return NULL; > + } > ndst[len] = ','; > memcpy(ndst+len+1, src, slen*sizeof(CHAR)); > ndst[len+slen+1] = 0; > @@ -527,7 +531,11 @@ > { > DWORD len = strlenW(dst), slen = strlenW(src); > LPWSTR ndst = HeapReAlloc(GetProcessHeap(), 0, dst, > (len+slen+2)*sizeof(WCHAR)); - if (!ndst) HeapFree(GetProcessHeap(), 0, > dst); > + if (!ndst) > + { > + HeapFree(GetProcessHeap(), 0, dst); > + return NULL; > + } > ndst[len] = ','; > memcpy(ndst+len+1, src, slen*sizeof(WCHAR)); > ndst[len+slen+1] = 0; looks like a real bug to me... but the consumers of those functions probably assume success, so maybe the right solution is really to raise an exception. There are lots of places in rpcrt4 where exceptions ought to raise on error conditions but don't, mainly due to developer laziness. I guess it's hard to justify fixing error paths when success doesn't work either ;) So, at some point there needs to be an error-handling audit of rpcrt4; until then, your patch is better than nothing, and probably should go in. -- gmt "It is to be the assent and ratification of the several States, derived from the supreme authority in each State, the authority of the people themselves. The act, therefore, establishing the Constitution, will not be a NATIONAL, but a FEDERAL act." --James Madison, Federalist No. 39

1 0

Re: WineX relation to Wine
by Gerhard W. Gruber Nov. 20, 2003

Nov. 20, 2003

On Thu, 20 Nov 2003 15:17:22 -0500, "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: [LaunchMenu Windowsversion under Wine] >> Are hooks supported under Wine? > >What do you need? I just tried it under Wine. the dialog and everything works, but the hook doesn't respond. I would have to debug it to see whats not working, but I guess that it is the hookfunction. When the hook couldn't be installed I raise a dialog and this does not appear, so the the CreateHook appears to return something. I don't see any errormessages from wine, though. -- Gerhard Gruber Maintainer of SoftICE for Linux - http://sourceforge.net/projects/pice Fast application launcher - http://sourceforge.net/projects/launchmenu

1 0

Further loader/pthread.c issues
by Gerald Pfeifer Nov. 20, 2003

Nov. 20, 2003

After last night's changes to loader/pthread.c,v revision 1.2 date: 2003/11/09 01:25:23; author: julliard; state: Exp; lines: +67 -11 Moved the remaining SYSDEPS_* functions to the wine_pthread interface. Let the pthread library allocate the stack itself. we have a new portability problem, namely wine/loader/pthread.c:97: undefined reference to `pthread_getattr_np' Given that loader/pthread.c is about POSIX threads, is it really correct/good to use a non-POSIX function? Gerald PS: On FreeBSD, pthread_getattr_np does not exist, but there is a function pthread_attr_get_np which seems to be equivalent. On Solaris, neither seems to exist.

3 3