December 2003 - Wine-Devel - list.winehq.org

Winmm resources and WINE Resource Compiler
by Steven Edwards Dec. 14, 2003

Dec. 14, 2003

Hello, It seems the Wine Resource compiler accepts \"string\" in resources while windres and MS RC do not. I have updated the resources for winmm and wrc still accepts the proper handling of this ""string"". Can someone look at the sources for WRC and fix this? Thanks Steven Changelog: Porting fix for Winmm Resources (patch by Filip Navara) __________________________________ Do you Yahoo!? New Yahoo! Photos - easier uploading and sharing. http://photos.yahoo.com/

1 0

Allocating too much memory for prelink workaround
by Vincent Béron Dec. 14, 2003

Dec. 14, 2003

Thinking about what Fabian and Marcus hit... Would it be possible to just have a dummy executable which allocates the 256MB chunk of memory from 11/22, linked to the same libs as the main wine-{k,p}thread, but having that executable not actually used? That way, we still gain the prelink workaround by reserving the memory, but Wine should continue to work on computers with less memory, or those who do not overcommit memory. Vincent

3 6

Help w/fd_ops for SMB
by Juan Lang Dec. 14, 2003

Dec. 14, 2003

Hi folks, I'm trying to modify Wine's SMB code to use Netbios(), rather than implementing NetBIOS-over-TCPIP itself. I'm having trouble figuring out how to handle the fd_ops in the wineserver. I was hoping for input. Currently, the SMB code creates a socket directly, and this socket is polled by the server for readability. Netbios() hides a connection behind an 8-bit adapter index and an 8-bit session index, so there's no way (through the Netbios() interface) to get the socket handle being used for a connection. Any opinions on whether (and if yes, how) the polling should be done? One possibility might be to figure out the TDI stuff, as using TDI for NetBIOS allows you to avoid the Netbios() interface. However, I haven't found any public documentation for the TDI interface to NetBIOS, except perhaps in the NT DDK (whose license I think is problematic). Any suggestions appreciated. Thanks, --Juan __________________________________ Do you Yahoo!? New Yahoo! Photos - easier uploading and sharing. http://photos.yahoo.com/

2 3

Alsa 1.0 and Wine
by Brett I. Holcomb Dec. 14, 2003

Dec. 14, 2003

I checked the archives and noticed the thread on Alsa 1.0. What was the resolution on that? I guess my concern is that for those of us that have 1.0 what happens if it's left for 0.9. I know with Winex it broke and I had to patch the winex alsa files. I used the quick and dirty method of modifying the header file but that is really a kluge and not long term. I have Alsa 1.0 installed so it works but it's not transportable to a system with 0.9. The better method is the patch that supports both interfaces so it doesn't matter what we have. I know I made the move to Alsa 1.0 because it does fix the oss emulation problem which has been bothering a lot of people. Thanks.

1 0

Printing with no printer
by Mike Hearn Dec. 14, 2003

Dec. 14, 2003

Hi, It seems from reading the documentation that it's possible to print to a .ps file in Wine, even if you don't actually have a printer. However, I'm not sure how to do that - I've got far enough to get the "Couldn't find PPD file '/unix/path/to/PPD/file', expect a crash now!" message, but am not sure where to go from here. I don't have any PPD files, as I have no printer. Has anybody done this before? thanks -mike

2 1

win16 app crashes in SCROLL_GetScrollRange()
by Saulius Krasuckas Dec. 14, 2003

Dec. 14, 2003

hi, once i got this crash. i have ve filled a bug report: http://bugs.winehq.com/show_bug.cgi?id=1503 now, inspired with a notice made by Andreas Mohr..: > Ah, WAIT!! Watcom has: > ./h/nt/winuser.h:#define SBM_GETRANGE 0x00E3 /*not in win3.1 */ .i decided to dig into some details. and i've stopped at one unclear state. wine has a patch in cvs: http://www.winehq.org/hypermail/wine-patches/2003/03/0052.html which says: > As discussed with Alexandre, this patch makes the GetScroll* API > functions send a message to the Window in the case of SB_CTL scroll > bars. - if (!(infoPtr = SCROLL_GetScrollInfo( hwnd, nBar ))) - { - if (lpMin) lpMin = 0; - if (lpMax) lpMax = 0; - return FALSE; - } - if (lpMin) *lpMin = infoPtr->minVal; - if (lpMax) *lpMax = infoPtr->maxVal; - return TRUE; + /* Refer SB_CTL requests to the window */ + if (nBar == SB_CTL) + return SendMessageA(hwnd, SBM_GETRANGE, (WPARAM)lpMin, (LPARAM)lpMax); + else + return SCROLL_GetScrollRange(hwnd, nBar, lpMin, lpMax); may now i ask someone for a help or explanation? the question is: if the win16 doesn't handle SBM_GETRANGE message, should wine send it in a case of win16 app? if no, then i'd like to start writing an additional check ;-). and one more question. msdn states: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… If the nBar parameter is SB_CTL and the window specified by the hWnd parameter is not a system scroll bar control, the system sends the SBM_GETRANGE message to the window to obtain scroll bar information. This allows GetScrollRange to operate on a custom control that mimics a scroll bar. aren't we missing one more check here? maybe we need to check class-name of control targeted by hwnd? additional greps led me to: [s2(a)katleriai wine-cvs]$ grep -A10 Scrollbar.messages wine/include/wine/winuser16.h /* Scrollbar messages */ #define SBM_SETPOS16 (WM_USER+0) #define SBM_GETPOS16 (WM_USER+1) #define SBM_SETRANGE16 (WM_USER+2) #define SBM_GETRANGE16 (WM_USER+3) #define SBM_ENABLE_ARROWS16 (WM_USER+4) #define SBM_SETRANGEREDRAW16 WM_NULL /* Not in Win16 */ #define SBM_SETSCROLLINFO16 WM_NULL /* Not in Win16 */ #define SBM_GETSCROLLINFO16 WM_NULL /* Not in Win16 */ /* CBT hook structures */ any ideas about where these constants came from? googling with "-wine" keyword gave me NULL :-/.

5 7

Re: locale: Fix for too small buffers
by Vitaliy Margolen Dec. 14, 2003

Dec. 14, 2003

Yep that is the problem I was seeing with one program I'm running. And this patch took care of it. Thanks! Vitaliy Margolen Tuesday, December 2, 2003, 13:01:18, Vitaliy Margolen wrote: > Hi, found a problem with the latest locale changes. When it calls the > GetLocaleInfoW() function, the attached error occurs. > This occurred because of the new code using the LOCALE_RETURN_NUMBER flag. The > problem is if the buffer supplied to get_registry_locale_info is quite small > (say sizeof(INT)). The value returned by NtQueryValueKey() however, is for a > string, and is much longer. As NtQueryValueKey updates the value of size, > this caused other parts of the code to corrupt memory.

3 4

msg.c:333: Test failed: ShowWindow:overlapped: in msg 0x0047 expecting wParam 0x47 got 0x0
by Uwe Bonnes Dec. 13, 2003

Dec. 13, 2003

Hallo, running "make test" in "ddls/user/test", I get ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:333: Test failed: ShowWindow:overlapped: in msg 0x0047 expecting wParam 0x47 got 0x0 make: *** [msg.ok] Error 1 This is on a Suse 9.0 system, SMP with two P3, kernel "Linux siemens 2.4.21-144-smp4G" Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: config: add resources path
by Alexandre Julliard Dec. 13, 2003

Dec. 13, 2003

Kevin Koltzau <kevin(a)plop.org> writes: > Many registry keys under XP refer to a %ResourceDir% env that points > to the path where windows themes are located. > > In case any apps refer to this, or if someone loads a registry > export from XP this should be available in wine also > > Interestingly, windows doesn't actually have this env set..my guess > is ExpandEnvironmentStrings has a special case to handle this > particular name I seriously doubt that; most likely it's something that is either handled internally in uxtheme, or uxtheme defines the variable before expanding the string. I think this needs more investigation, but it doesn't seem to be something that should be handled in kernel. -- Alexandre Julliard julliard(a)winehq.com

3 4

[Bug 939] We need a resolution for abandoned bugs
by Uwe Bonnes Dec. 13, 2003

Dec. 13, 2003

Hallo, what about having a mechanisme that mails the bug autor after a given time, lets say 1/2 year, asking to reconfirm the bug. With no reaction from the bug author after some time ( several weeks), the bug is marked as abandonned. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Delayed debug tracing
by Mike Hearn Dec. 13, 2003

Dec. 13, 2003

Hi, I'd like to implement delayed debug tracing, by which I mean you can do a +relay,+seh,+tid,+win,+otherstuff and yet not create a log file so huge it's impossible to work with. I seem to recall seeing this feature in WineX, where you can press Alt-F12 to switch it on. Does anybody who knows the debugging/keyboard code have any particular preferences as to how this should be implemented? thanks -mike

5 8

Corrupted Wine source package on sf
by Vincent Béron Dec. 13, 2003

Dec. 13, 2003

Hi Alexandre, The 20031212 source .tar.gz on sourceforge is shorter (~400k) than the one on ibiblio, and when untarred yields an error. You probably want to reupload it. Vincent

2 1

Internally maintained end-to-end API documentation
by Joshua Walker Dec. 13, 2003

Dec. 13, 2003

Hello all, I have been a lurker, going on now a good part of three years. I have some ideas I wish to cast to the table. I am a writer, not a programmer by craft. This hindrance aside, I have kicked around my fair share of C code. I have also been known to throw gooey splatterings of VMS report data into Postgres, and somehow rationalize it into something coherent on the other side for pay. After reading Wine Weekly News Issue #200, (Congrats by the way), I stumbled across the Wine Status Pages. I particularly like how everything is grouped by major components. With a quick glance at a color-coded graph, one can see how well something has been implemented. There is one thing that really bugging the heck out of me. Most of the API documentation is possessed by MSDN. In my humble opinion, this is a very dangerous and volatile place to have it. I was once told that using the internet as a data resource is like watching The Library of Alexandria burn over and over again. Having attempted to be a code developer for Microsoft products in the past, I know how quick MSDN can be when it comes to pulling the data out from under your feet. I also know what it's like to go hunting for some bizarre functionality, only to have MSDN look at you back with nothing but a blank stare on it's face. Sometimes it's the "little things" like the deep inner workings of interprocess communication. Better yet, why on earth is my stack is being messed with after a function call. I think it's about time to take the various Windows APIs and place them onto a fishbowl for safe keeping. Having lurked here for as long as I have, I have found two constants about announcing projects on wine-devel that I'd like to share. 1) In order to have Alexandre change direction, you better have a very good reason. 2) Many ideas have been announced here with no real clear goal or steps of execution. They soon die of atrophy shortly after. As for myself, I'm thinking to taking up the mantle for documenting the Windows API, or at least setting up public facilties for myself and others to use. The problem I have is how about will it be documented? First goal is to figure out where on earth to *put* the documentation.. I'm thinking of some kind of universal data holder where API information can aggregated, parsed, and rendered to one's choosing. As I shook my magic hate-ball I asked, "What do you think about storing the API data in some kind of XMLish-thingy format?" All signs pointed to yes. This is quite tragic as my knowledge of XML is really weak. As far as I know, it's that HTML superset, isn't it? Stepping back a bit, I started thinking of tossing an SQL database on one of my machines and writing some kind of dynamic HTML front end for it. The SQL idea is nice because I can write the front end to spit out what I have in any data format I can dream of, including XML. It also allows people to come to my website, pop in an API function that wan't there, and move on with their lives. That seems plausible. The second hurtle is what to put as the actual fields. I'm really only used to seeing function rendered an a "Unix man style" format. Name, synopsis, description, return value, errors, bugs. See "man fork" for example. We will also need kind of a DLL overview, (man stdio?). What about something a little more UML compatible. Anyone have any ideas? Admittedly this is where my coherence of the project ends. There might be someone out there a little more apt at content than I am. Let me close with a story; When I was 12 my mother bought a brand new washing machine. My mother gave me the old one and a set of wrenches, and then proceeded to tell me to go nuts. In the span of five hours there was washing machine all over our front lawn. I learned more about about washing machines at the age of 12 by tearing that thing apart more than most adults know now. It's kinda what I want to do with Windows. -Joshua

2 1

More deadlocks + backtrace
by Shachar Shemesh Dec. 13, 2003

Dec. 13, 2003

I ran "spyxx" from MSVC on my deadlocking program, and everything was ok. I then quite the program itself (Microsoft Digital Image Pro was run with +relay, spy was run without any debug values). I left spy running for a while (~2 days), as I had other things to do, and I wanted the window handles it collected. At some point, the console that launched spy began showing the following: $ wine SPYXX err:font:ReadFontDir Can't open directory "/win/windows/fonts" fixme:mdi:MDIRefreshMenu partially function stub fixme:mdi:MDIRefreshMenu partially function stub err:toolbar:TOOLBAR_NotifyFormat wrong response to WM_NOTIFYFORMAT (0), assuming ANSI err:win:CreateWindowExA bad class name "msctls_updown" err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) Here are the backtraces: Wine-dbg>walk process pid threads parent executable >00000010 2 00000000 'Y:\sources\Transfer\RemoteDebug\SPYXX.EXE' Wine-dbg>walk thread process tid prio 00000010 (D) Y:\sources\Transfer\RemoteDebug\SPYXX.EXE 00000012 0 <== 00000011 0 Wine-dbg>bt 0x11 Backtrace: =>0 0x4010e8ab (NTDLL.DLL._memccpy+0x5202b in libc.so.6) (ebp=40032c60) 1 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x0, handles=0x0, flags=0x8, timeout=0x40032d10) [sync.c:578] in NTDLL.DLL) (ebp=40032cf8) 2 0x401f1edd (usr1_handler+0x4e(__signal=0xa, __context=0x8f) [signal_i386.c:1123] in NTDLL.DLL) (ebp=40032d1c) 3 0x4006e498 (NTDLL.DLL.toupper+0x6208 in libc.so.6) (ebp=4080f7e0) 4 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x1, handles=0x4080f8cc, flags=0xc, timeout=0x4080f900) [sync.c:578] in NTDLL.DLL) (ebp=4080f878) 5 0x401f40ae (NTDLL.DLL.NtWaitForMultipleObjects+0x74 in NTDLL.DLL) (ebp=4080f8a0) 6 0x401f40fe (NtWaitForSingleObject+0x42(handle=0x88, alertable=0x0, timeout=0x4080f900) [sync.c:611] in NTDLL.DLL) (ebp=4080f8c4) 7 0x401cda35 (RtlpWaitForCriticalSection+0x127(crit=0x40380d68) [critsection.c:193] in NTDLL.DLL) (ebp=4080f964) 8 0x401cdc25 (RtlEnterCriticalSection+0x51(crit=0x40380d68) [critsection.c:255] in NTDLL.DLL) (ebp=4080f97c) 9 0x404f2555 (wine_pthread_mutex_lock+0x34(mutex=0x101593c8) [pthread.c:182] in KERNEL32.DLL) (ebp=4080f98c) 10 0x0011273a (__pthread_mutex_lock+0x25(mutex=0x101593c8) [kthread.c:588] in wine-kthread) (ebp=4080f99c) 11 0x40f409ea (_end+0x75bb6 in libX11.so.6) (ebp=4080f9bc) 12 0x40f0d799 (_end+0x42965 in libX11.so.6) (ebp=4080fa1c) 13 0x40e8b39e (X11DRV_InitKeyboard+0x84(key_state_table=0x40b66880) [keyboard.c:1332] in X11DRV.DLL) (ebp=4080fadc) 14 0x40e8c1c4 (X11DRV_MappingNotify+0x35(event=0x4080fb94) [keyboard.c:1635] in X11DRV.DLL) (ebp=4080fafc) 15 0x40e83647 (.L164+0xb [event.c] in X11DRV.DLL) (ebp=4080fb7c) 16 0x40e82e65 (process_events+0x71(data=0x40380d40) [event.c:143] in X11DRV.DLL) (ebp=4080fbf8) 17 0x40e82ffa (X11DRV_MsgWaitForMultipleObjectsEx+0x17b(count=0x1, handles=0x40380c6c, timeout=0xffffffff, mask=0x0, flags=0x0) [event.c:184] in X11DRV.DLL) (ebp=4080fd38) 18 0x40ad5f96 (GetMessageW+0x287(msg=0x46becc, hwnd=0x0, first=0x0, last=0x0) [message.c:2363] in USER32.DLL) (ebp=4080fdf4) 19 0x40ad6020 (GetMessageA+0x33(msg=0x46becc, hwnd=0x0, first=0x0, last=0x0) [message.c:2380] in USER32.DLL) (ebp=4080fe14) 20 0x6c3be6e9 (MFC42.DLL.5307+0x13 in MFC42.DLL) (ebp=0046becc) 21 0x0000000f (ebp=000100d6) Wine-dbg>bt 0x12 Backtrace: =>0 0x4010e8ab (NTDLL.DLL._memccpy+0x5202b in libc.so.6) (ebp=4030fc60) 1 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x0, handles=0x0, flags=0x8, timeout=0x4030fd10) [sync.c:578] in NTDLL.DLL) (ebp=4030fcf8) 2 0x401f1edd (usr1_handler+0x4e(__signal=0xa, __context=0x8f) [signal_i386.c:1123] in NTDLL.DLL) (ebp=4030fd1c) 3 0x4006e498 (NTDLL.DLL.toupper+0x6208 in libc.so.6) (ebp=419eb450) 4 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x1, handles=0x419eb53c, flags=0xc, timeout=0x419eb530) [sync.c:578] in NTDLL.DLL) (ebp=419eb4e8) 5 0x401f40ae (NTDLL.DLL.NtWaitForMultipleObjects+0x74 in NTDLL.DLL) (ebp=419eb510) 6 0x404fcb20 (WaitForMultipleObjectsEx+0x1d5(count=0x1, handles=0x419eb670, wait_all=0x0, timeout=0x32, alertable=0x0) [sync.c:167] in KERNEL32.DLL) (ebp=419eb648) 7 0x404fc8b8 (WaitForSingleObject+0x3c(handle=0x64, timeout=0x32) [sync.c:95] in KERNEL32.DLL) (ebp=419eb668) 8 0x004232fa (SPYXX.EXE..text+0x222fa in SPYXX.EXE) (ebp=40aab4df) 9 0x0168ec81 (SPYXX.EXE..rsrc+0x1221c81 in wine-kthread) (ebp=53e58955) *** Invalid address 0x53e58955 (_end+0x121f453d) I hope this helps someone. -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/

2 3

Added support for inter-process GetWindowLong on the window extra bytes
by Phil Krylov Dec. 13, 2003

Dec. 13, 2003

Hello, This change prevents IBM Translation Manager from working correctly. It has a dialog named "Export Folder" which used to contain three buttons and a tabbed notebook with various options. After this update, the pages of the tabbed notebook are no longer displayed (and created). Hope I can provide some more details like a debug log if someone will tell me which channels should be traced. AJ> ChangeSet ID: 10222 AJ> CVSROOT: /opt/cvs-commit AJ> Module name: wine AJ> Changes by: julliard(a)wine.codeweavers.com 2003/11/26 16:15:41 AJ> Modified files: AJ> windows : win.c AJ> server : window.c trace.c protocol.def AJ> include/wine : server_protocol.h AJ> Log message: AJ> Added support for inter-process GetWindowLong on the window extra AJ> bytes. AJ> Patch: http://cvs.winehq.com/patch.py?id=10222 AJ> Old revision New revision Changes Path AJ> 1.226 1.227 +132 -111 wine/windows/win.c AJ> 1.25 1.26 +36 -4 wine/server/window.c AJ> 1.185 1.186 +7 -3 wine/server/trace.c AJ> 1.87 1.88 +6 -0 wine/server/protocol.def AJ> 1.88 1.89 +7 -1 AJ> wine/include/wine/server_protocol.h -- Best regards, Phil mailto:phil(a)newstar.rinet.ru

2 3

Core DLL's Status Section
by Tom Dec. 13, 2003

Dec. 13, 2003

Hi, Here is my first draft anyone have any comments?, constructive criticism? You will see I have wineps, x11drv, winedos listed on this page now so ill remove those sections from the Core Status page. If everything looks good ill paste the three sections together and send Brian a copy for WWN inclusion. :) And while he is doing that ill add in the remaining doc links. and then it should be ready for wine-patches. I've also got a nice new list of todo's to add to that page as well. Happy Holidays, Tom

1 0

Re: gdi: AlphaBlend constants
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Kirill Smelkov <kirr(a)landau.phys.spbu.ru> writes: > +/* AlphaBlend flags */ > +#define AC_SRC_NO_PREMULT_ALPHA 0x01 > +#define AC_SRC_NO_ALPHA 0x02 > +#define AC_DST_NO_PREMULT_ALPHA 0x10 > +#define AC_DST_NO_ALPHA 0x20 Where do these come from? I don't see them in the SDK headers or on MSDN, there's only an AC_SRC_ALPHA. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: ntdll / kernel32: #38
by Dmitry Timoshkov Dec. 12, 2003

Dec. 12, 2003

"Eric Pouech" <pouech-eric(a)wanadoo.fr> wrote: > +HANDLE WINAPI OpenConsoleW(LPCWSTR name, DWORD access, LPSECURITY_ATTRIBUTES sa, > + DWORD creation) > +{ > + static const WCHAR coninW[] = {'C','O','N','I','N','$',0}; > + static const WCHAR conoutW[] = {'C','O','N','O','U','T','$',0}; > + BOOL output; > + HANDLE ret; > + > + if (strcmpW(coninW, name) == 0) > + output = FALSE; > + else if (strcmpW(conoutW, name) == 0) > + output = TRUE; While you are moving the code around then you are probably reviewing it as well? So, the question is: shouldn't the above comparisons be case insensitive? -- Dmitry.

2 1

Re: menu: Fix for menu tracking problem version 2
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Andrew de Quincey <adq_dvb(a)lidskialf.net> writes: > I wrote a program in windows which had owner drawn menu items. Whenever I > received the WM_DRAWITEM message: > > 1) I called GetCapture(), and compared it with the hwnd of main window > containing the menu. It pops up a message box if they are different. > 2) I then called SetCapture() with the HWND of the menu item itself. > > This approximately simulates what IDA is doing. > > The message box never popped up. This shows that even though the capture was > changed in one WM_DRAWITEM, windows had reset the capture to the window > containing the menu by the time of the next one. I also checked the messages > _were_ being sent using Spy++ (in case of a programming error). That's a good start, but it's not enough to know what Windows is really doing. You should also check the capture window right after you call SetCapture; and you should use GetGUIThreadInfo and print out all the details, especially the GUI_INMENUMODE flag. My suspicion is that the capture is not allowed to change at all in menu mode. -- Alexandre Julliard julliard(a)winehq.com

2 5

Problems with transparent windows
by Juan Antonio Boscá Lloret Dec. 12, 2003

Dec. 12, 2003

Hello, I've found a probable bug in Wine when running win32 applications. Wine does not repaint windows areas that are hidden by another window over them (I think this is a behaviour by design). This behaviour is not correct when the upper window is transparent (WS_EX_TRANSPARENT style). Is it a bug? Thank you. --------------------------------------------------------------- Juan Antonio Boscá Lloret Departamento Programación CAE, S.A. jabosca(a)edicurs.com ---------------------------------------------------------------

2 1

Re: wine/dlls/kernel pthread.c
by Rein Klazes Dec. 12, 2003

Dec. 12, 2003

On Fri, 12 Dec 2003 00:19:25 -0600, you wrote: > Log message: > Return an error in wine_pthread_mutex_unlock if we don't own the > critical section, this should avoid trouble caused by a locking bug > inside Xlib. Good, the locking problem that I reported seems to be fixed by this. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: unicode & wine internals
by Mike Hearn Dec. 12, 2003

Dec. 12, 2003

No patch? On Thu, 2003-12-11 at 20:14, Eric Pouech wrote: > wine_get_unix_file_name is now a unicode function > A+

1 0

Re: shlexec: Fixes for buffer overrun problems
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Andrew de Quincey <adq_dvb(a)lidskialf.net> writes: > Hi, this is a cleanup of shell32/shlexec.c to remove potential buffer > overruns. I've also tried to make parts of the code a little easier to > follow, without affecting the functionality. It's a very inefficient mechanism, you are reallocating the same string over and over to append sometimes only a single char. The right way to avoid overflows is to compute the length of the full string first and then allocate all the needed space at once. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Janitorial: Get rid of W->A calls for shlexec (2/2)
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Marcelo Duarte <wine-devel(a)bol.com.br> writes: > Hi, > > Changelog: > Marcelo Duarte <wine-devel(a)bol.com.br> > -Janitorial: Get rid of W->A calls for shlexec > -Implementation of FindExecutableW > > Coments: > After you aplying my patch 1/2 and made corrections using sizeof, I see the > problems in the patch 2/2 and I do the corrections, and now, I think that all > is correct. No, there are still many places where the sizes are wrong. Every time you change a buffer from char[] to WCHAR[] you have to fix uses of sizeof on that buffer to count characters properly. Also there are still HeapAlloc calls that are done in bytes instead of WCHARs. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars
by Dimitrie O. Paun Dec. 12, 2003

Dec. 12, 2003

On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT when > the toolbar detects that the mouse has moved off a button and wants to > de-highlight it. Well, it probably does a InvalidateRect() call. You can try an ugly InvaldateRect(hwnd, 0, TRUE); but this will probably result in flicker. For added bonus, figure out the button's rect, and pass it in: /* figure out stuff in rect */ InvalidateRect(hwnd, &rect, TRUE); BTW, what are the parameters of WM_ERASEBKGND? -- Dimi.

2 4