December 2003 - Wine-Devel - list.winehq.org

Re: wine/dlls/kernel pthread.c
by Rein Klazes Dec. 12, 2003

Dec. 12, 2003

On Fri, 12 Dec 2003 00:19:25 -0600, you wrote: > Log message: > Return an error in wine_pthread_mutex_unlock if we don't own the > critical section, this should avoid trouble caused by a locking bug > inside Xlib. Good, the locking problem that I reported seems to be fixed by this. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: unicode & wine internals
by Mike Hearn Dec. 12, 2003

Dec. 12, 2003

No patch? On Thu, 2003-12-11 at 20:14, Eric Pouech wrote: > wine_get_unix_file_name is now a unicode function > A+

1 0

Re: shlexec: Fixes for buffer overrun problems
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Andrew de Quincey <adq_dvb(a)lidskialf.net> writes: > Hi, this is a cleanup of shell32/shlexec.c to remove potential buffer > overruns. I've also tried to make parts of the code a little easier to > follow, without affecting the functionality. It's a very inefficient mechanism, you are reallocating the same string over and over to append sometimes only a single char. The right way to avoid overflows is to compute the length of the full string first and then allocate all the needed space at once. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Janitorial: Get rid of W->A calls for shlexec (2/2)
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Marcelo Duarte <wine-devel(a)bol.com.br> writes: > Hi, > > Changelog: > Marcelo Duarte <wine-devel(a)bol.com.br> > -Janitorial: Get rid of W->A calls for shlexec > -Implementation of FindExecutableW > > Coments: > After you aplying my patch 1/2 and made corrections using sizeof, I see the > problems in the patch 2/2 and I do the corrections, and now, I think that all > is correct. No, there are still many places where the sizes are wrong. Every time you change a buffer from char[] to WCHAR[] you have to fix uses of sizeof on that buffer to count characters properly. Also there are still HeapAlloc calls that are done in bytes instead of WCHARs. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars
by Dimitrie O. Paun Dec. 12, 2003

Dec. 12, 2003

On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT when > the toolbar detects that the mouse has moved off a button and wants to > de-highlight it. Well, it probably does a InvalidateRect() call. You can try an ugly InvaldateRect(hwnd, 0, TRUE); but this will probably result in flicker. For added bonus, figure out the button's rect, and pass it in: /* figure out stuff in rect */ InvalidateRect(hwnd, &rect, TRUE); BTW, what are the parameters of WM_ERASEBKGND? -- Dimi.

2 4

bugs in d3d8.dll and msvcrt.dll
by Ivan Leo Murray-Smith Dec. 11, 2003

Dec. 11, 2003

There are 2 bugs that prevent mafia (Trial version) from working correctly, they are in d3d8.dll and msvcrt.dll, updated backtraces generated with wine-20031212 are at http://bugs.winehq.com/show_bug.cgi?id=1670 the demo is at http://www.mafia-game.com in the downloads section.

1 0

Deadlock?
by Shachar Shemesh Dec. 11, 2003

Dec. 11, 2003

When trying to run Microsoft Digital Image Pro, I occasionally get problems when loading it. The splash screen comes up, and then it hangs. This problem only happens occasionally. I have not, to date, managed to reproduce it with relay turned on. This is what I do get on screen: err:module:import_dll No implementation for USER32.dll.GetScrollBarInfo imported from L"C:\\Program Files\\Microsoft Picture It! 9\\piutil.dll", setting to 0xdeadbeef err:font:ReadFontDir Can't open directory "/win/windows/fonts" err:imagelist:ImageList_LoadImageW Error loading image! err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080deec err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080ea54 err:toolbar:ToolbarWindowProc unknown msg 2210 wp=00ca0001 lp=00010051 err:toolbar:ToolbarWindowProc unknown msg 204e wp=40c757d8 lp=4080eaa4 err:toolbar:ToolbarWindowProc unknown msg 2210 wp=57d80001 lp=00010053 fixme:toolbar:TOOLBAR_SetPadding stub - nothing done with values, cx=7, cy=9 fixme:imm:ImmAssociateContext (0x10056, (nil)): semi-stub fixme:imm:ImmAssociateContext (0x10058, (nil)): semi-stub fixme:imm:ImmAssociateContext (0x1005a, (nil)): semi-stub fixme:hook:NotifyWinEvent (32784,0x10056,-4,0)-stub! fixme:hook:NotifyWinEvent (32784,0x1005a,-4,0)-stub! fixme:hook:NotifyWinEvent (32782,0x10058,-4,0)-stub! err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080e61c fixme:imm:ImmAssociateContext (0x1009d, (nil)): semi-stub err:ntdll:RtlpWaitForCriticalSection section 0x4020fc60 "loader.c: loader_section" wait timed out in thread 0009, blocked by 000c, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7c38b208 "?" wait timed out in thread 000c, blocked by 0009, retrying (60 sec) -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/

2 4

winefile can't launch any apps!
by Dan Kegel Dec. 11, 2003

Dec. 11, 2003

Trying to launch any app, e.g. wine's notepad, by double-clicking on the .exe in 'winefile' crashes wine, like this: 0x42079c30 (NTDLL.DLL.strcpy+0x20): movzbl 0x0(%edx),%eax Wine-dbg>bt Backtrace: =>0 0x42079c30 (NTDLL.DLL.strcpy+0x20) (ebp=4072ed8c) 1 0x40778fd4 (SHELL32.DLL.FindExecutableW+0x7ec in SHELL32.DLL) (ebp=4072f840) 2 0x40779103 (SHELL32.DLL.ShellExecuteExA+0x1f in SHELL32.DLL) (ebp=4072f854) 3 0x40620515 (winefile.exe.EntryPoint+0x4515 in winefile.exe) (ebp=4072f9c4) 4 0x40620692 (winefile.exe.EntryPoint+0x4692 in winefile.exe) (ebp=4072f9f0) 5 0x40620a8c (winefile.exe.EntryPoint+0x4a8c in winefile.exe) (ebp=4072faa4) 6 0x408d0703 (USER32.DLL.EndDeferWindowPos+0x31b in USER32.DLL) (ebp=4072fac8) 7 0x408d0761 (USER32.DLL.EndDeferWindowPos+0x379 in USER32.DLL) (ebp=4072faf4) 8 0x408d4ff2 (USER32.DLL.EndDeferWindowPos+0x4c0a in USER32.DLL) (ebp=4072fb1c) 9 0x408d5645 (USER32.DLL.CallWindowProcW+0xf9 in USER32.DLL) (ebp=4072fb50) 10 0x408e50ab (USER32.DLL.IsCharAlphaW+0x2d57 in USER32.DLL) (ebp=4072fbac) 11 0x408e5e2d (USER32.DLL.SendMessageTimeoutW+0x135 in USER32.DLL) (ebp=4072fc10) 12 0x408e604d (USER32.DLL.SendMessageW+0x31 in USER32.DLL) (ebp=4072fc3c) 13 0x40895f32 (USER32.DLL.EditWndProc+0xaff6 in USER32.DLL) (ebp=4072fcd4) 14 0x40897359 (USER32.DLL.EditWndProc+0xc41d in USER32.DLL) (ebp=4072fcf8) 15 0x408d0703 (USER32.DLL.EndDeferWindowPos+0x31b in USER32.DLL) (ebp=4072fd1c) 16 0x408d0761 (USER32.DLL.EndDeferWindowPos+0x379 in USER32.DLL) (ebp=4072fd48) 17 0x408d5539 (USER32.DLL.CallWindowProcA+0xf9 in USER32.DLL) (ebp=4072fd7c) 18 0x40620d99 (winefile.exe.EntryPoint+0x4d99 in winefile.exe) (ebp=4072fda4) 19 0x408d0703 (USER32.DLL.EndDeferWindowPos+0x31b in USER32.DLL) (ebp=4072fdc8) 20 0x408d0761 (USER32.DLL.EndDeferWindowPos+0x379 in USER32.DLL) (ebp=4072fdf4) 21 0x408d5539 (USER32.DLL.CallWindowProcA+0xf9 in USER32.DLL) (ebp=4072fe28) 22 0x408b94a2 (USER32.DLL.DispatchMessageA+0x96 in USER32.DLL) (ebp=4072fe6c) 23 0x406214b9 (winefile.exe.EntryPoint+0x54b9 in winefile.exe) (ebp=4072fea4) 24 0x406214f1 (winefile.exe.EntryPoint+0x54f1 in winefile.exe) (ebp=4072febc) 25 0x4061c0a5 (winefile.exe.EntryPoint+0xa5 in winefile.exe) (ebp=4072ff2c) 26 0x4036b132 (KERNEL32.DLL.SetThreadExecutionState+0x16d6 in KERNEL32.DLL) (ebp=4072fff4) 27 0x4002df1d (_end+0x402c0f1) (ebp=00000000) This is on an SMP RH9 system running wine 20031118 compiled from source. - Dan

5 7

Low level dlls
by carlini＠dcc.ufmg.br Dec. 11, 2003

Dec. 11, 2003

Hi, what is a low level dlls in M$ windows nt? (low level dll == ddl whit access win device driver and/or hardware recourses.) They can natively be loaded? tanks Ricardo ================================ = Ricardo Carlini Sperandio = = 4! perido = = Ciencia da Computacao - UFMG = = Slack User / FreeBSD user = ================================

1 0

Re: I made a wish, wrote a letter to Santa...
by Subhobroto Sinha Dec. 11, 2003

Dec. 11, 2003

Actually Shachar, I was thinking along these lines: (1) Programs in WINE are making direct calls to internal functions (which are not really Win32, but made by us using which we can use te Win32 functions as wrappers...) and that's just possible because C functions are globally callable (the only thing you really need to keep the compiler happy is the function prototype) And that's a bad thing, because while developing tools we should really forget that we are coding fo WINE, and just write using Win32 SDK APIs... Encapsulating internal WINE functions as private, and exposing them using the correct APIs would be better engineering... Just to force lazy people like us to write protable code (you see, calling internal WINE functions are a lot easier than calling the corresponding wrappers.. (2) A few things like DirectX and COM are so very closely tied with C++ objects that implementing them in C seems an overkill to me. But after knowing they are done, I have nothing against that .... (3) C++ is VERY reusable. WINE has a lot of potential for reusablity , but by doing C where it was not needed, we are unnecessarily having to spend time finding out pieces here and there in the huge code structure. WINE is recieving more interest than ever, and we can only encourage people to join us by giving something they too can reuse, and people who really work for WINE are those types who start writing their own code if they find that tracing down a function and it's references will take more time. For example, whatever I have gone through (which is VERY little BTW..), I still feel that implementing many tools like winemenubuilder or winefile would have been better in C++ Infact, I intent to do some experimentation after Xmas (I am having my semester exams now, so ..) Hope what I said reaches you all ;) Season's greetings Subhobroto <snip> On Thu, 11 Dec 2003 Shachar Shemesh wrote : >I'm sorry, it has been YEARS since I wrote anything OLE related (my very first Windows program was an OLE server, hand coded, that did a shell extension. That was my only interaction with OLE). As such, I will not presume to decide whether that statement is correct or not. </snip snip, snip..>

2 1