March 2003 - Wine-Devel - list.winehq.org

Re: Add messaging for SB_CTL bars to scroll.c
by Dimitrie O. Paun March 6, 2003

March 6, 2003

On March 5, 2003 09:22 pm, Andrew Johnston wrote: > +/* Determine if the info is valid */ > +#define SCROLL_INFO_INVALID(info) \ > + ((info->fMask & ~(SIF_ALL | SIF_DISABLENOSCROLL)) || \ > + ((info->cbSize != sizeof(*info)) && \ > + (info->cbSize != sizeof(*info) - sizeof(info->nTrackPos)))) Please use inline functions for this sort of thing. Also, it's typically better to ask the positive question: inline static BOOL SCROLL_IsScrollBarInfoValid(SCROLLBAR_INFO *infoPtr) { /* ... */ } -- Dimi.

2 1

Re: PATCH: Inserting an item in a listview sometimes generates incorrect messages
by Dimitrie O. Paun March 6, 2003

March 6, 2003

On March 5, 2003 09:28 am, Adam Gundy wrote: > When shifting the list's indices, we must not send notify messages > if we have to refocus. Item modification handlers are not supposed > to be called here. I'm not too hot about passing that boolean around... I'd rather have a special way to avoid the notification in the case of shifting items, rather than clutter the interface that's used all over the place to pass a strange TRUE that's rather opaque. I've tried hard to not extend the interface beyond what's documented for the messages. It makes the code simpler to follow. -- Dimi.

1 0

Delphi with Wine
by S.Sistemas Informação March 6, 2003

March 6, 2003

Hi, My environment is three layers. On second layer (Applications Server), I'm not getting to run the TSimpleObjectBroker and TSocketConnection Delphi components in my application with wine. The client BD and BDE application works perfectly. Somebody can help me? Thanks. Viação Ouro Branco S/A Sistemas de Informação e Tecnologia Grimaldo Ghioti ssi(a)viacaoourobranco.com.br Fone(43)3373-2630 Fax(43)3373-2615 Brazil ______________________________________ Inflex - installed on mailserver for domain @viacaoourobranco.com.br Queries to: postmaster(a)viacaoourobranco.com.br

3 2

Re: New conformance test for user32.dll
by Duane Clark March 5, 2003

March 5, 2003

Tony Lambregts wrote: > > Ok. then > > Change Log: Clarify patch requirements. > > Files changed: documentation/patches.sgml > > Index: patches.sgml > =================================================================== > RCS file: /home/wine/wine/documentation/patches.sgml,v > retrieving revision 1.6 > diff -u -r1.6 patches.sgml > --- patches.sgml 18 Feb 2003 23:23:35 -0000 1.6 > +++ patches.sgml 5 Mar 2003 21:01:34 -0000 > @@ -48,8 +48,8 @@ > </para> > <para> > For additions: mention that you have some new files and > - include them as either separate attachments or by appending > - the <command>diff -u /dev/null /my/new/file</command> output of > them ^^^^ Which demonstrates one of the complications with inlined plain text, because generally extra effort is required to prevent undesired word wrap.

1 1

Re: winedbg b0rken on FreeBSD?
by Eric Pouech March 5, 2003

March 5, 2003

> Is there anything I can do? hard to tell from here... from the things you could do is try to do is: 1/ winedbg diablo 2/ then when winedbg seems to hang, try to attach gdb to it (to the winedbg process, not the diablo's as you did). it may tell us where it fails another option is to run with --debugmsg +server,+relay but you will get lots of traces... but it may show where things stop and the third one is to run gdb thru winedbg (run winedbg -- --gdb diablo, and see what gives) A+ -- Eric Pouech

1 0

Re: Add wineconsole FIXME
by Eric Pouech March 5, 2003

March 5, 2003

> wineconsole has problems with SetConsoleTitleA() when running with > CURSES backend. > > Document that by adding a FIXME. I think we should add it to wineconsole documentation too... once it gets written :-( > Any solution to that problem? not really. do you know what your app does after getting the window handle ? in some cases, it's used to either: - check if the app is running - or send messages (minimize/maximize, show/hide, quit) I don't see very good solutions here... curses backend is intended to be run without USER loaded... so that would break this rule... even, if we create a dummy window in wineconsole, without requiring USER to be loaded (using bare server requests), I'm not sure it'll cover all aspects of the issues (esp. what the app does once it gets the handle) BTW, XP introduced a new API to implement in a sane way this window lookup 'GetConsoleWindow' (for the console attached to the current process) (in the same type of issues, GetWindowThreadProcessId() will return bogus results) A+ -- Eric Pouech

1 0

Resources and more with Darwin
by Pierre d'Herbemont March 5, 2003

March 5, 2003

Hi all! I am trying to build wine onto Max OS X/Darwin. I am getting trouble with windres and the *.res files. I would like to know if it would be possible to have winelib running without those resources, I mean, could I build a program and link it fine without those resources? In a second time I would like to know if you plan to use wrc as the only (without windres) resource manager. I have read in the list something like that, could you give me the confirmation? Also I would like to know in which measure is the Elf file format implicated in wine (in opposition to darwin's mach-o). Thanks, Pierre

5 7

Re: Clean-up of scroll.c (1/4)
by Alexandre Julliard March 5, 2003

March 5, 2003

"Andrew M. Johnston" <johnstonam(a)logica.com> writes: > - return (info->fMask & SIF_ALL) != 0; > + > + return (info->fMask & SIF_ALL); [...] > - if (lpMin) *lpMin = infoPtr->minVal; > - if (lpMax) *lpMax = infoPtr->maxVal; > - return TRUE; > + TRACE("hwnd=%p nBar=%d lpMin=%p lpMax=%p\n", hwnd, nBar, lpMin, lpMax); > + > + if (lpMin) *lpMin = infoPtr ? infoPtr->minVal : 0; > + if (lpMax) *lpMax = infoPtr ? infoPtr->maxVal : 0; > + > + return (BOOL)infoPtr; Please don't do this kind of gratuitous changes. Boolean functions should return TRUE or FALSE, unless you have evidence that Windows does it differently. Yes, I know any non-zero value is true in C, but you can't rely on every Windows programmer to get it right. -- Alexandre Julliard julliard(a)winehq.com

3 6

Re: SystemParametersInfo patch
by Duane Clark March 5, 2003

March 5, 2003

Jon Bright wrote: > ... > (as an aside are patches preferred as MIME attachments or straight in > the mail here?) > I will just throw in a couple more comments to add to those already made. The main problem with the way you attached this is that it has modified a lot of the "special" characters, which you normally don't see because your mail reader has displays them ok. So you should do a "view source" of what you have attached. For example, it starts out: diff -u -r1.49 sysparams.c --- windows/sysparams.c 19 Feb 2003 22:04:46 -0000 1.49 +++ windows/sysparams.c 5 Mar 2003 10:39:39 -0000 @@ -1662,17 +1662,26 @@ } =20 case SPI_GETMOUSEHOVERWIDTH: /* 98 _WIN32_WINNT >=3D 0x400 || _W= IN32_WINDOW > 0x400 */ Notice the "=20", "=3D", and "=<cr>". Not only has the mailer changed some of the characters, but it has inserted line feeds. For many of us, all this is invisible. I use Mozilla, and it recreates the file correctly as long as I Save As... text. But I don't think we should assume that everyone can do that.

2 1

Spy++ messages
by Mike Hearn March 5, 2003

March 5, 2003

Hi, I tried debugging why toggling check items in the NSIS installer doesn't work (bug 1298), and thought it'd be a good idea to try running it under Spy++ on Windows, but for some reason it only seems to know about the TVM_* messages, but not TVN_* or TVS_*... is this correct, does Spy++ only show you a subset of the messages used? thanks -mike

2 1