April 2003 - Wine-Devel - list.winehq.org

Re: remove server silliniess
by John K. Hohm April 18, 2003

April 18, 2003

Thus spake "Gregory M. Turner" <gmturner007(a)ameritech.net>: > ah, the hidden powers of the preprocessor -- how it drives us to obsfucation > with it's robotic stupidity... I wonder, is cpp a turing machine? Makes me > want to implement vim as a sed script ;) I don't think so. However, the C++ compile-time template mechanism *is* a turing machine (proof omitted). That is a persuasive argument, but I'm not sure if it's for or against C++.

1 0

winecfg kickoff
by Dimitrie O. Paun April 17, 2003

April 17, 2003

Hi Alexandre, I have a little (and hopefully not too controversial :) suggesting on how to kickoff our little winecfg utility. Namely, we need to get the load/save from/to registry code going. To do so, we need the regisry key structure in place. Item C1 says "Merge configuration into the registry": http://www.dssd.ca/wine/Wine-0.9-TODO.html#conf So here's my proposal: 1. Do C1 now, but keep the current configuration in place 2. Label the conf file in CVS, to know when we merged it 3. Work on winecfg to load/save stuff properly 4. When done, compare the current version of the conf file with the labeled one, to see what's changed. 5. Adapt winecfg to the new changes 6. Drop the old config file Now, if this sounds like a plan, I was hopeing you could do (1) & (2) as it seems you have an idea where things should end up :) (and because only you can label stuff in CVS). Hopefully people will pick up on (3), if not I guess I can take a look, time permitting. -- Dimi.

2 1

Re: my dmusic and dpnhpast work, revised and resent
by Alexandre Julliard April 17, 2003

April 17, 2003

"Rok Mandeljc" <rokmandeljc(a)hotmail.com> writes: > I just found out that my dpnhpast patch doesn't apply to current cvs tree > (msvcrtd implementation changed Makefile.in and configure). This also mean > that dmusic patch I've sent won't apply either. So I'm sending it again, > this time in one patch. It *should* apply to (today's) cvs cleanly. I have applied all the new dlls, but not the dmusic stubs. I think you should try to group related interfaces in the same source file (and possibly merge some of the existing files too), we can't have 40 different source files for a stub dll. A dozen files is the maximum IMO. -- Alexandre Julliard julliard(a)winehq.com

5 8

Re: Set TZ environment variable when not set
by Rein Klazes April 17, 2003

April 17, 2003

On Wed, 16 Apr 2003 21:05:28 +0200, you wrote: > Changelog: > memory/environ.c: build_environment > Set the TZ value to GMT0, if TZ is not set > > Synplify.exe from the Quicklogic FPGA suite refused to work with the demo > license. Setting TZ to any value made it work. GMT0 should be a good > approach. > > Awaiting the "flame war" about noise level for that silent change :-) Uwe, Some programs, like Agent email/news client that I use, check the existence of TZ before attempting other timezone API call's. With your patch Agent displays all times in UTC, which is not making me happy. A correct patch should take care of the local timezone and daylight saving. Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 4

Re: Initialise tid in WIN_CreateDesktopWindow
by Alexandre Julliard April 17, 2003

April 17, 2003

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > windows/win.c: WIN_CreateDesktopWindow > Initialise pWndDesktop->tid > > This makes the Xilinx command line tools run with ttydrv This is wrong, the desktop should not be owned by the current thread. What's the problem with Xilinx? -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: wine/ files/dos_fs.c dlls/kernel/tests/file.c
by Uwe Bonnes April 17, 2003

April 17, 2003

>>>>> "Alexandre" == Alexandre Julliard <julliard(a)wine.codeweavers.com> writes: Alexandre> ChangeSet ID: 7890 CVSROOT: /opt/cvs-commit Module name: wine Alexandre> Changes by: julliard(a)wine.codeweavers.com 2003/04/16 21:10:04 Alexandre> Modified files: files : dos_fs.c dlls/kernel/tests: file.c Alexandre> Log message: Uwe Bonnes Alexandre> <bon(a)elektron.ikp.physik.tu-darmstadt.de> FindFirstFile on Alexandre> root directory should fail. Alexandre> Patch: http://cvs.winehq.com/patch.py?id=7890 @@ -1937,7 +1937,6 @@ UINT codepage; data->dwReserved0 = data->dwReserved1 = 0x0; - if (!lpFileName) return 0; if (lpFileName[0] == '\\' && lpFileName[1] == '\\') { ERR("UNC path name\n"); This first patch thunk wasn't in the patch I sent. Is this intentional? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: wine/include/msvcrt malloc.h
by Dimitrie O. Paun April 17, 2003

April 17, 2003

On Wed, 16 Apr 2003, Alexandre Julliard wrote: > Log message: > Fixed alloca handling the way mingw does it (reported by Vincent > Béron). > #ifndef USE_MSVCRT_PREFIX > -static inline void* alloca(MSVCRT(size_t) i) { return _alloca(i); } > +# ifdef __GNUC__ > +# define _alloca(x) __builtin_alloca((x)) > +# define alloca(x) __builtin_alloca((x)) > +# endif > #endif /* USE_MSVCRT_PREFIX */ If we know it's GNUC, isn't it better to use the alias feature, so we don't run into problems with the macros, like we use to? -- Dimi.

2 1

RE: What happend to the Stdole2 / Stdole32 (RESEND) patch fromRobert Shearman
by Robert Shearman April 17, 2003

April 17, 2003

> -----Original Message----- > From: Uwe Bonnes [mailto:bon(a)elektron.ikp.physik.tu-darmstadt.de] > Sent: 02 April 2003 14:40 > To: Robert Shearman > Subject: Re: What happend to the Stdole2 / Stdole32 (RESEND) patch > fromRobert Shearman > > > >>>>> "Robert" == Robert Shearman <R.J.Shearman(a)warwick.ac.uk> writes: > > >> what happend to the stdole32.tlb patch that Robert sent > around 22.1? > Robert> It was rejected on the grounds that we shouldn't have binary > Robert> files in CVS and we can't generate the .tlb files at > the moment. > > Did you generate the files from some source you wrote? Yes. > What compiler was used? MkTypLib from MS Platform SDK > What constraints are put on distributing those generated files? None, as far as I could tell. > The present need for stdole*.tlb from a windows installation is > unsatisfactory. Agreed. > Bye > > -- > Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de > > Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt > --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Hope this helps and sorry for not getting back to you sooner, Rob

1 0

Winelib MFC?
by Christopher Thielen April 17, 2003

April 17, 2003

Hello, I've written an application in MFC which runs beautifully in wine. I'd like to distribute a Winelib version, so Unix users don't need wine. Can I recompile MFC applications with Winelib? Is this possible? -- chris (chris(a)luethy.net)

3 4

wild pointers in current named pipe implementation?
by Dan Kegel April 17, 2003

April 17, 2003

I know Mike is planning to rewrite the named pipe implementation, but the current implementation could use a little love while we're waiting for the new one. So I'm looking into the recent user complaint about FlushFileBuffers and named pipes, in hopes I can find a very simple patch that will tide us over until the new named pipes code is ready (whenever that might be; Mike's busy on other things at the moment). So I added an early call to FlushFileBuffers in the named pipe regression test (see attached patch). While poking around in wineserver, I found a few places where pointers were not set to NULL after being invalidated, and after I added the missing statements to set them to NULL, wineserver started behaving badly on the regression test. A run of wineserver under valgrind showed a null pointer access, so I added a couple null pointer check asserts (see attached patch). And sure enough, they fire. So the question is -- did I screw up, or did I uncover a real issue? The answer will help me as I continue digging into the FlushFileBuffers named pipe bug report (and testing possible simple enhancements to the current named pipe implementation). Thanks, Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: server/object.c =================================================================== RCS file: /home/wine/wine/server/object.c,v retrieving revision 1.27 diff -d -u -r1.27 object.c --- server/object.c 19 Feb 2003 00:33:33 -0000 1.27 +++ server/object.c 14 Apr 2003 16:59:45 -0000 @@ -193,6 +193,7 @@ struct object *grab_object( void *ptr ) { struct object *obj = (struct object *)ptr; + assert( obj ); assert( obj->refcount < INT_MAX ); obj->refcount++; return obj; Index: server/named_pipe.c =================================================================== RCS file: /home/wine/wine/server/named_pipe.c,v retrieving revision 1.22 diff -d -u -r1.22 named_pipe.c --- server/named_pipe.c 4 Apr 2003 22:26:34 -0000 1.22 +++ server/named_pipe.c 14 Apr 2003 16:59:45 -0000 @@ -163,6 +163,7 @@ static struct fd *pipe_user_get_fd( struct object *obj ) { struct pipe_user *user = (struct pipe_user *)obj; + assert(user->fd); return (struct fd *)grab_object( user->fd ); } @@ -200,8 +201,11 @@ if (user->prev) user->prev->next = user->next; else user->pipe->users = user->next; if (user->thread) release_object(user->thread); + user->thread = NULL; release_object(user->pipe); + user->pipe = NULL; if (user->fd) release_object( user->fd ); + user->fd = NULL; } static int pipe_user_get_poll_events( struct fd *fd ) Index: dlls/kernel/tests/pipe.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/tests/pipe.c,v retrieving revision 1.2 diff -d -u -r1.2 pipe.c --- dlls/kernel/tests/pipe.c 25 Feb 2003 03:56:43 -0000 1.2 +++ dlls/kernel/tests/pipe.c 14 Apr 2003 16:59:45 -0000 @@ -86,6 +86,10 @@ /* lpSecurityAttrib */ NULL); ok(hnp != INVALID_HANDLE_VALUE, "CreateNamedPipe failed"); + if (!FlushFileBuffers(hnp)) { + /* we'll add a check here once we know how windows behaves */ + fprintf(stderr, "FlushFileBuffers on new pipe failed, err %d\n", GetLastError()); + } hFile = CreateFileA(PIPENAME, GENERIC_READ|GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, 0); todo_wine

5 14