May 2003 - Wine-Devel - list.winehq.org

Bugzilla querys
by hatky May 8, 2003

May 8, 2003

At least some of the querys at bugzilla stoped working in particilar the "bugs by me" (it really starts to bug me ;) ) A few people have confirmed but no one gave a solution... Any one has any idea? a string end (well thats an expertion in hebrew, sorry) any leads and slim direction to go by? Hatky. __________________________________ Do you Yahoo!? The New Yahoo! Search - Faster. Easier. Bingo. http://search.yahoo.com

2 2

spam protection on mailing list archives
by Jeremy Newman May 8, 2003

May 8, 2003

I configured the mailing list archives to obfuscate emails now. All new messages will have this. It is a simple form of protection at the moment. It simply changes the emails to this: jnewman_at_codeweavers.com. I don't think this may be enough protection however. I can go one step further just make the emails totally invalid. something like jnewman(a)email.domain.hidden I'm in favor of the later option. Anyone have opinions on this. Note this only affects new posts, for old posts in the archives, I will write a script that does the same. -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

4 3

UTF oddity
by Jan Sporbeck May 8, 2003

May 8, 2003

Hallo, while porting a friends windows code, i encountered the following: WideCharToMultiByte returns incorrect string length when using CP_UTF8 for conversion the following code snippet correctly sets nLen1 to 2 but sets nLen2 only to 1 int nLen1 = WideCharToMultiByte(CP_UTF8, 0, L"Ü", 1, NULL, 0, NULL, NULL); // query buffer size int nLen2 = WideCharToMultiByte(CP_UTF8, 0, L"Ü", 1, szUtf, nLen1, NULL, NULL); // do conversion I tested this with Wine <=20030408 am I missing something? /jan. -- ## Every cloud engenders not a storm. -- William Shakespeare, "Henry VI" ##

5 5

Re: wine/dlls/comctl32 listview.c
by Rein Klazes May 8, 2003

May 8, 2003

On Tue, 29 Apr 2003 19:49:44 -0500, you wrote: > Modified files: > dlls/comctl32 : listview.c > > Log message: > Dimitrie O. Paun <dpaun(a)rogers.com> > Generate custom draw notifications for ownerdraw listviews (based on a > patch by Maxime Bellengé). > Reorganize the custom draw code for better reuse. Dimitrie, This causes a regression in Newsbin. Normally when retrieving new headers they are displayed with a green background (showing that they are "new"). With the patch, I notice two things: - the first line is lacking the green the green background completely (so it is white); - following lines only the first column is painted correctly. The text in the other columns lacks the green background. Does this give you an idea what might be wrong? Rein. -- Rein Klazes rklazes(a)xs4all.nl

4 6

Re: rpc exception
by jpo234＠netscape.net May 8, 2003

May 8, 2003

Hi list, may I suggest that you have a look at http://www.hpl.hp.com/research/linux/libunwind/intro.php4 To quote the page: "The primary goal of this project is to define a portable and efficient C programming interface (API) to determine the call-chain of a program. The API additionally provides the means to manipulate the preserved (callee-saved) state of each call-frame and to resume execution at any point in the call-chain (non-local goto). The API supports both local (same-process) and remote (across-process) operation. As such, the API is useful in a number of applications. Some examples include: exception handling The libunwind API makes it trivial to implement the stack-manipulation aspects of exception handling." Might be exactly what you are all looking for. Regards Jörg __________________________________________________________________ Try AOL and get 1045 hours FREE for 45 days! http://free.aol.com/tryaolfree/index.adp?375380 Get AOL Instant Messenger 5.1 for FREE! Download Now! http://aim.aol.com/aimnew/Aim/register.adp?promo=380455

3 3

Re: Allow NtFileFlushBuffers to block
by Eric Pouech May 8, 2003

May 8, 2003

> ChangeLog: > * allow NtFileFlushBuffers to block, as flushing a named pipe requires this what I don't like in your patch is that you create an event in all cases, where according to the doc, FlushFileBuffers should only block for named pipes. maybe, it would be better to return the event handle from the flush server call and wait in kernel if this event is not NULL A+ -- Eric Pouech

2 2

Killer-App idea: Stack protection
by Johannes E. Schindelin May 8, 2003

May 8, 2003

Hi all, how about implementing the ideas from exec_shield (a linux kernel module written by Ingo Molnar to automatically protect existing programs from most buffer overflows) directly into Wine? May be a dumb idea; I don't know too much about those deep internals of Wine regarding stacks. Ciao, Dscho

1 0

Re: winsock: use iphlpapi
by Sylvain Petreolle May 8, 2003

May 8, 2003

I cant apply your winsock patch, patch says malformed at line 245: @@ -2123,127 +2100,6 @@ [Winipcfg work] In order to run winipcfg, a key must be added into registry, otherwise it (probably) says TCP/IP isnt installed, I had got a blank Msgbox with an "Ok" button. HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\VxD\MSTCP Now it works beautifully. could you include it into your reworked patch ? ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 1

Re: iphlpapi.dll (take 2)
by Alexandre Julliard May 8, 2003

May 8, 2003

Juan Lang <juan_lang(a)yahoo.com> writes: > Removed C++-style comments. > Supercedes > http://www.winehq.org/hypermail/wine-patches/2003/05/0069.html > > ChangeLog: Adds an implementation of iphlpapi.dll; > most Get* > functions introduced through Win98 are included. The implementation should use the same function names as the exported entry points, without the IPHLPAPI_ prefix, exactly the way they are declared in iphlpapi.h. For instance DWORD __stdcall IPHLPAPI_AddIPAddress(...) should really be DWORD WINAPI AddIPAddress(...) etc. Also you can't share code by putting source files in misc/. All source files must be local to the dll, and other dlls have to use the exported API exclusively. And please use diff -u to make patches. -- Alexandre Julliard julliard(a)winehq.com

2 1

solaris x86 development?
by Peter Lees May 8, 2003

May 8, 2003

hello, what is the status of WINE development for solaris x86? i'm running into some fairly fundamental build bugs & would like to know if anyone has got it working. thks p

3 2

Re: wsock32: use iphlpapi
by Dimitrie O. Paun May 7, 2003

May 7, 2003

On Tue, 6 May 2003, Juan Lang wrote: > ChangeLog: changes wsock32 to use the new iphlpapi for > interface and route enumeration in WsControl. + if (!table) + { + ERR ("Unable to allocate memory, can't enumerate interfaces\n"); + return -1; // FIXME: isn't there a better error code? + } No need to output this error here, we can't do that for every memory problem, and even if we could, I don't think it would be the right thing anyway, as it clutters the code, for little (if any) benefit. Just do: if (!table) return -1; // FIXME: isn't there a better error code? -- Dimi.

2 1

Re: spam protection on mailing list archives
by Brian Vincent (C) May 7, 2003

May 7, 2003

Found this link a few weeks ago: http://www.cdt.org/speech/spam/030319spamreport.shtml Particularly interesting were these paragraphs: "All the plaintext e-mail addresses we placed on the public web received some spam. The number of messages received seems to be related to the popularity of the web site. GetNetWise.org is a well-known online safety site that is linked to by major portals like AOL and Yahoo!, and the addresses posted there received a lot of spam, while ConsumerPrivacyGuide.org is a relatively new site, and addresses posted there received much less spam." "But none of the addresses that were obscured, whether in "human-readable" or "HTML-obscured" form, received a single piece of spam, leading us to conclude that e-mail address "harvesters" are not presently capable of collecting such addresses. While this may change as time passes and technology develops, for the time being it appears that obscuring an e-mail address is an effective means of avoiding spam." I think we're ok for now. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

Oleaut32 and Visual Basic 5
by erwin wolff May 7, 2003

May 7, 2003

I've found a way to let VB apps run on Wine without the native Oleaut32 DLL. If you set the Oleaut32 entry in the ~/.wine/config file to native without the native DLL in your system dir. The visual basic 5 setup and its generated files run for a full 100% (!). As long as you have the MSVBVM60.DLL in your sys dir. So I think it is the combination between having a fake native dll and the the real MSVBVM60.DLL (but still it isn't used by the vb5 setup). It is not a shame if you haven't got the file since it even isn't included in any standard windows installation. Anyway, grab it from www.microsoft.com. You should try this for yourself. I compiled wine cvs (latest) with ./configure --with-nptl so it might not work for everybody. I think the oleaut32 entry must always be set to "native" no matter what. ------------------------------------------- ECF Wolff erwinwolffnl(a)microformatica.com

2 1

wine not working...
by Daniel Chao May 7, 2003

May 7, 2003

Hi Everybody, I just recently download wine and installed it on my RedHat 9(which also recently upgraded from 8). I think I did everything right. But, when I try to install something or even just run wine. It gives me the following error. I checked all the configurations and they seem to be right. So, I don't know what's going on with it..... wine: lstat /root/.wine/wineserver-wingzero/socket : No such file or directory Any suggestion????

3 2

Re: rpc exception
by Gregory M. Turner May 7, 2003

May 7, 2003

On Saturday 19 April 2003 10:40 am, Ove Kaaven wrote: > I see that Greg's exception stuff is not in Wine yet. Until that's > accepted, this'll have to do. hmm, Alexandre, perhaps I should try to produce an acceptable version of those exception-handling macros which get activated iff gcc is the compiler (and otherwise we could revert to the dummy versions)? -- gmt "Democracy is the theory that holds that the common people know what they want, and deserve to get it good and hard." HL Mencken

6 22

Re: opengl32 patch to make StarTrek Elite Force II Demo work
by Lionel Ulmer May 6, 2003

May 6, 2003

On Tue, May 06, 2003 at 10:21:18PM +0200, Dr. Uwe Girlich wrote: > The patch adds the function wglGetExtensionsStringARB() in the opengl32 dll. > The Quake III Arena based game "Star Trek Elite Force II Single Player Demo" > uses this function, even if it does not exist, which results in an exception. Uwe, could you try the following patch : http://www.winehq.org/hypermail/wine-patches/2003/05/0043.html It's not comitted yet to CVS (it should be soon I hope :-) ) but it should work the same as yours (and be a bit better for some games who actually check the return value of the call). Lionel PS: I wonder why two patches for exactly the same issue (which is here for a long time) came in the space of two days :-) -- Lionel Ulmer - http://www.bbrox.org/

1 0

Re: [dx8-14] Disable some classing debug traces + fix texture size
by Michael Stefaniuc May 6, 2003

May 6, 2003

And the patch? On Tue, May 06, 2003 at 10:27:11PM +0200, Raphaël Junqueira wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > Changelog: > - Disable some 'classic' debug traces (avoid useless flood of traces while > debugging games) > - fix the texture size caps using GL_MAX_TEXTURE_SIZE > > Regards, > Raphael > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.2.1 (GNU/Linux) > > iD8DBQE+uBqfp7NA3AmQTU4RAh97AJ9ciYIXCBi0Ezy+1M9t8C/dDOzrXQCeOnCn > C/m13smI8tePbBe5x7khMWI= > =vyM/ > -----END PGP SIGNATURE----- -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: [dx8-14] Disable some classing debug traces + fix texture size
by Vincent Béron May 6, 2003

May 6, 2003

Raphaël Junqueira a écrit: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > Changelog: > - Disable some 'classic' debug traces (avoid useless flood of traces while > debugging games) > - fix the texture size caps using GL_MAX_TEXTURE_SIZE Patch maybe? Vincent

2 1

Re: [dx8-14] Disable some classing debug traces + fix texture size
by Raphaël Junqueira May 6, 2003

May 6, 2003

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le Mardi 06 Mai 2003 22:27, Raphaël Junqueira a écrit : Hi again, attaching the patch this time ... i'll take a brown paper bag Changelog: - Disable some 'classic' debug traces (avoid useless flood of traces while debugging games) - fix the texture size caps using GL_MAX_TEXTURE_SIZE Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+uBwHp7NA3AmQTU4RAuIFAKCWdwsS/Q4Fx2c/uC8XPustNas7PgCZAeT4 GhHWpOau8LYRjGWk5ERtXgY= =6pTs -----END PGP SIGNATURE-----

1 0

Winedbg generating zombies !!
by Sylvain Petreolle May 6, 2003

May 6, 2003

Updating from yesterday to today CVS, Winedbg has stopped working correctly. The behaviour I get is : - doesnt work when a program invokes it (hangs and no windebg process is here) - no prompt at all when trying to start an application with it, the app starts without 'cont' command -a zombie process is generated. Nothing changed on my station between yesterday and today. No package was updated and no modification was made to ~/.wine/config. I pasted here the output from 'winedebg winevdm': [syl(a)snoop syl]$ winedbg winevdm fixme:console:SetConsoleCtrlHandler (0x4058eee0,1) - no error checking or testing yet WineDbg starting on pid 16 Invalid address, can't set breakpoint Unable to add breakpoint, will check again any time a new DLL is loaded Loaded debug information from ELF 'wine' ((nil)) *** Invalid address 0x3c001610 (_DYNAMIC in wine) *** Invalid address 0x4002003c (_end+0x401e920) *** Invalid address 0x4009003c (_end+0x408e920) trying to add delayed A-bp f00d 0000:40029000 *** Invalid address 0x409a003c (_end+0x499e920) trying to add delayed A-bp f00d 0000:40029000 *** Invalid address 0x4096003c (_end+0x495e920) trying to add delayed A-bp f00d 0000:40029000 *** Invalid address 0x408f003c (_end+0x48ee920) trying to add delayed A-bp f00d 0000:40029000 *** Invalid address 0x407e003c (_end+0x47de920) trying to add delayed A-bp f00d 0000:40029000 *** Invalid address 0x4079003c (_end+0x478e920) trying to add delayed A-bp f00d 0000:40029000 fixme:keyboard:X11DRV_KEYBOARD_DetectLayout Your keyboard layout was not found! Using closest match instead (French keyboard layout) for scancode mapping. Please define your layout in dlls/x11drv/keyboard.c and submit them to us for inclusion into future Wine releases. See the Wine User Guide, chapter "Keyboard" for more information. *** Invalid address 0x40ab003c (_end+0x4aae920) trying to add delayed A-bp f00d 0000:40029000 fixme:keyboard:X11DRV_KEYBOARD_DetectLayout Your keyboard layout was not found! Using closest match instead (French keyboard layout) for scancode mapping. Please define your layout in dlls/x11drv/keyboard.c and submit them to us for inclusion into future Wine releases. See the Wine User Guide, chapter "Keyboard" for more information. Usage: winevdm.exe [--app-name app.exe] command line Process of pid=00000016 has terminated [syl(a)snoop syl]$ ps x |grep wine 7587 pts/0 Z 0:02 [wine <defunct>] 7733 pts/5 Z 0:02 [wine <defunct>] 7745 pts/5 Z 0:02 [wine <defunct>] 8199 pts/0 Z 0:00 [wine <defunct>] 8215 pts/5 Z 0:00 [wine <defunct>] 8218 pts/5 Z 0:00 [wine <defunct>] 8226 pts/5 S 0:00 grep wine ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: some ntdll functions (5) - part 1: functions
by Alexandre Julliard May 6, 2003

May 6, 2003

thomas.mertes(a)gmx.at writes: > + for (main_idx = 0; main_idx < main_str->Length / sizeof(WCHAR); main_idx++) { > + search_idx = 0; > + while (search_idx < search_chars->Length / sizeof(WCHAR) && > + main_str->Buffer[main_idx] != search_chars->Buffer[search_idx]) { > + search_idx++; > + } /* if */ > + if (search_idx >= search_chars->Length / sizeof(WCHAR)) { > + *pos = (main_idx + 1) * sizeof(WCHAR); > + return STATUS_SUCCESS; > + } /* if */ > + } /* if */ I'm not sure why you feel necessary to add /* if */ on every single closing brace, IMO it just adds noise to the code for no good reason. Anyway, I can live with it as long as it's actually the closing brace of an if, but adding /* if */ at the end of for and while loops is going a bit too far ;-) -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: gethostbyname patch
by Dimitrie O. Paun May 6, 2003

May 6, 2003

On Tue, 6 May 2003, Andreas Mohr wrote: > + if (name == NULL) > + { > + if (WS_gethostname(local_name, sizeof(local_name)) != 0) > + FIXME("failed to get local host name, please report!\n"); There is nothing to fix here. This is at most a WARN, but if WS_gethostname() is documented as possibly failing, that's just fine, no need for any message, just return failure: + if (WS_gethostname(local_name, sizeof(local_name))) return NULL; -- Dimi.

2 1

Re: gethostbyname patch
by Shachar Shemesh May 6, 2003

May 6, 2003

Andreas Mohr wrote: >Hi all, > >http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/wi… > >says that if name is NULL, it should retrieve information for the >local hostname. > > >Index: dlls/winsock/socket.c >=================================================================== >RCS file: /home/wine/wine/dlls/winsock/socket.c,v >retrieving revision 1.125 >diff -u -r1.125 socket.c >--- dlls/winsock/socket.c 9 Apr 2003 23:33:35 -0000 1.125 >+++ dlls/winsock/socket.c 6 May 2003 13:43:08 -0000 >@@ -3038,6 +3038,17 @@ > int ebufsize=1024; > struct hostent hostentry; > int locerr = ENOBUFS; >+ char local_name[256]; >+ >+ /* name == NULL means use the local host name */ >+ if (name == NULL) >+ { >+ if (WS_gethostname(local_name, sizeof(local_name)) != 0) >+ FIXME("failed to get local host name, please report!\n"); > Why is that a FIXME? Shouldn't a "ERR" work better here? >+ >+ name = local_name; >+ } >+ > host = NULL; > extrabuf=HeapAlloc(GetProcessHeap(),0,ebufsize) ; > while(extrabuf) { > > > -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

1 0

Re: New metabugs
by Dan Kegel May 6, 2003

May 6, 2003

Hatky wrote: > Ok so mybe the fix-me/stub/unimplemented bugs category > is a really bad idea but we are having diffrent > opinions on the more general idea of using metabugs as > categories... Hi Hatky, I appreciate the energy you're bringing to the wine project! That said, it might be a good idea for you to tread lightly at least at first in the winehq bugzilla. Like you, I just started contributing to a bugzilla (OpenOffice's), and the guys there are probably as nervous about me messing with their bugzilla as I am about you messing around in Wine's bugzilla! So I'm being cautious, and instead of creating a metabug right off the bat, I created some canned queries and links to bugs on my own web site (http://www.kegel.com/openoffice/) to try out my ideas first. And when the openoffice qa mailing list folks say "yeah, go ahead and create a metabug", I will - but one at a time, and gently. Anyway, don't let me slow you down. Just remember that bug tracking is a social issue, and you have to pay attention to how the other developers feel about it. Cheers, Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

5 18

Re: Mac OS X Support : Signals support
by Alexandre Julliard May 5, 2003

May 5, 2003

"Pierre d'Herbemont" <stegefin(a)free.fr> writes: > Hi, > This patch add in signal_powerpc.c of ntdll support for darwin signal. You should define a set of macros or inline functions to access the sigcontext structure fields, instead of duplicating the whole handler functions. For an example, check how the i386 code is doing it. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Fix oleaut32/olepicture (2)
by Alexandre Julliard May 5, 2003

May 5, 2003

Maxime Bellengé <maxime.bellenge(a)laposte.net> writes: > + i = jd.output_width*jd.output_components; > + if ((i%sizeof(DWORD))>0) { > + padding = i%sizeof(DWORD); > + i += i%sizeof(DWORD); > + } else { > + padding = 0; > + } This is still wrong I'm afraid. -- Alexandre Julliard julliard(a)winehq.com

1 0

Windows API db script
by Dave Miller May 5, 2003

May 5, 2003

I have posted an update to the script. Francois Gouget sent a patch to fix a problem handling uppercase filenames. The patched script is now available. Thanks to those who have submitted .ref files. I have five versions so far. Now it is time to think about what kind of queries we want to be able to do...

7 8

Possible optimization with X11DRV_PALETTE_ToPhysical
by Uwe Bonnes May 5, 2003

May 5, 2003

Hallo, there are several loops in wine/graphics/x11drv/dib.c that call X11DRV_PALETTE_ToPhysical inside the loop. X11DRV_PALETTE_ToPhysical always does a GDI_GetObjPtr at entry and a Release at exit. E.g. with MS pinball.exe I sees a look querying 256 entries in a row. If we do the GDI_GetObjPtr/Release outside the loop and have a ..._ToPhysical call that takes palPtr we would save a loot those Get/ReleasePtr calls. Is this worth doing? I the approach below right? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/x11drv/x11drv.h =================================================================== RCS file: /home/wine/wine/dlls/x11drv/x11drv.h,v retrieving revision 1.1 diff -u -r1.1 x11drv.h --- wine/dlls/x11drv/x11drv.h 22 Apr 2003 04:05:08 -0000 1.1 +++ wine/dlls/x11drv/x11drv.h 5 May 2003 17:43:44 -0000 @@ -43,6 +43,8 @@ #include "user.h" #include "win.h" #include "thread.h" +#include "palette.h" +#include "windef.h" #define MAX_PIXELFORMATS 8 @@ -314,6 +316,7 @@ extern COLORREF X11DRV_PALETTE_ToLogical(int pixel); extern int X11DRV_PALETTE_ToPhysical(X11DRV_PDEVICE *physDev, COLORREF color); +extern int X11DRV_PALETTEOBJ_ToPhysical( DC *dc, HPALETTE hPal, PALETTEOBJ *palPtr, COLORREF color); /* GDI escapes */ Index: wine/graphics/x11drv/dib.c =================================================================== RCS file: /home/wine/wine/graphics/x11drv/dib.c,v retrieving revision 1.108 diff -u -r1.108 dib.c --- wine/graphics/x11drv/dib.c 31 Mar 2003 01:32:47 -0000 1.108 +++ wine/graphics/x11drv/dib.c 5 May 2003 17:43:58 -0000 @@ -174,6 +174,9 @@ const void *colorPtr, int start, int end ) { int i; + DC *dc = physDev ? physDev->dc : NULL; + HPALETTE hPal = (dc)? dc->hPalette: GetStockObject(DEFAULT_PALETTE); + PALETTEOBJ* palPtr = (PALETTEOBJ *) GDI_GetObjPtr( hPal, PALETTE_MAGIC ); if (coloruse == DIB_RGB_COLORS) { @@ -191,7 +194,7 @@ rgb->rgbBlue > 255*3/2); else for (i = start; i < end; i++, rgb++) - colorMapping[i] = X11DRV_PALETTE_ToPhysical( physDev, RGB(rgb->rgbRed, + colorMapping[i] = X11DRV_PALETTEOBJ_ToPhysical( dc, hPal, palPtr, RGB(rgb->rgbRed, rgb->rgbGreen, rgb->rgbBlue)); } @@ -205,7 +208,7 @@ rgb->rgbtBlue > 255*3/2); else for (i = start; i < end; i++, rgb++) - colorMapping[i] = X11DRV_PALETTE_ToPhysical( physDev, RGB(rgb->rgbtRed, + colorMapping[i] = X11DRV_PALETTEOBJ_ToPhysical( dc, hPal, palPtr, RGB(rgb->rgbtRed, rgb->rgbtGreen, rgb->rgbtBlue)); } @@ -216,13 +219,15 @@ WORD * index = (WORD *)colorPtr; for (i = start; i < end; i++, index++) - colorMapping[i] = X11DRV_PALETTE_ToPhysical( physDev, PALETTEINDEX(*index) ); + colorMapping[i] = X11DRV_PALETTEOBJ_ToPhysical( dc, hPal, palPtr, PALETTEINDEX(*index) ); } else { for (i = start; i < end; i++) - colorMapping[i] = X11DRV_PALETTE_ToPhysical( physDev, PALETTEINDEX(i) ); + colorMapping[i] = X11DRV_PALETTEOBJ_ToPhysical( dc, hPal, palPtr, PALETTEINDEX(i) ); } } + if (palPtr) + GDI_ReleaseObj( palPtr ); return colorMapping; } @@ -3176,6 +3181,9 @@ int rShift1,gShift1,bShift1; int rShift2,gShift2,bShift2; BYTE gMask1,gMask2; + DC *dc = physDev ? physDev->dc : NULL; + HPALETTE hPal = (dc)? dc->hPalette: GetStockObject(DEFAULT_PALETTE); + PALETTEOBJ* palPtr = (PALETTEOBJ *) GDI_GetObjPtr( hPal, PALETTE_MAGIC ); /* Set color scaling values */ rShift1=16+X11DRV_DIB_MaskToShift(rSrc)-3; @@ -3214,11 +3222,13 @@ blue= ((srcval >> bShift1) & 0xf8) | ((srcval >> bShift2) & 0x07); XPutPixel(bmpImage, x, h, - X11DRV_PALETTE_ToPhysical - (physDev, RGB(red,green,blue))); + X11DRV_PALETTEOBJ_ToPhysical + (dc, hPal, palPtr, RGB(red,green,blue))); } srcbits += linebytes; } + if(palPtr) + GDI_ReleaseObj( palPtr ); } break; } @@ -3697,6 +3707,9 @@ { /* ==== rgb 888 dib -> any bmp bormat ==== */ const BYTE* srcbyte; + DC *dc = physDev ? physDev->dc : NULL; + HPALETTE hPal = (dc)? dc->hPalette: GetStockObject(DEFAULT_PALETTE); + PALETTEOBJ* palPtr = (PALETTEOBJ *) GDI_GetObjPtr( hPal, PALETTE_MAGIC ); /* Windows only supports one 24bpp DIB format: RGB888 */ srcbits+=left*3; @@ -3704,12 +3717,14 @@ srcbyte=(const BYTE*)srcbits; for (x = left; x < dstwidth+left; x++) { XPutPixel(bmpImage, x, h, - X11DRV_PALETTE_ToPhysical - (physDev, RGB(srcbyte[2], srcbyte[1], srcbyte[0]))); + X11DRV_PALETTEOBJ_ToPhysical + (dc, hPal, palPtr, RGB(srcbyte[2], srcbyte[1], srcbyte[0]))); srcbyte+=3; } srcbits += linebytes; } + if(palPtr) + GDI_ReleaseObj( palPtr ); } break; } @@ -4171,6 +4186,9 @@ /* ==== any 0888 dib -> pal 1, 4 or 8 bmp ==== */ const DWORD* srcpixel; int rShift,gShift,bShift; + DC *dc = physDev ? physDev->dc : NULL; + HPALETTE hPal = (dc)? dc->hPalette: GetStockObject(DEFAULT_PALETTE); + PALETTEOBJ* palPtr = (PALETTEOBJ *) GDI_GetObjPtr( hPal, PALETTE_MAGIC ); rShift=X11DRV_DIB_MaskToShift(rSrc); gShift=X11DRV_DIB_MaskToShift(gSrc); @@ -4185,12 +4203,14 @@ red= (srcvalue >> rShift) & 0xff; green=(srcvalue >> gShift) & 0xff; blue= (srcvalue >> bShift) & 0xff; - XPutPixel(bmpImage, x, h, X11DRV_PALETTE_ToPhysical - (physDev, RGB(red,green,blue))); + XPutPixel(bmpImage, x, h, X11DRV_PALETTEOBJ_ToPhysical + (dc, hPal, palPtr, RGB(red,green,blue))); } srcbits += linebytes; - } - } + } + if (palPtr) + GDI_ReleaseObj( palPtr ); + } break; } Index: wine/graphics/x11drv/palette.c =================================================================== RCS file: /home/wine/wine/graphics/x11drv/palette.c,v retrieving revision 1.36 diff -u -r1.36 palette.c --- wine/graphics/x11drv/palette.c 31 Oct 2002 02:38:20 -0000 1.36 +++ wine/graphics/x11drv/palette.c 5 May 2003 17:44:00 -0000 @@ -819,23 +819,32 @@ return best; } - -/*********************************************************************** - * X11DRV_PALETTE_ToPhysical - * - * Return the physical color closest to 'color'. - */ int X11DRV_PALETTE_ToPhysical( X11DRV_PDEVICE *physDev, COLORREF color ) { DC *dc = physDev ? physDev->dc : NULL; - WORD index = 0; HPALETTE hPal = (dc)? dc->hPalette: GetStockObject(DEFAULT_PALETTE); - unsigned char spec_type = color >> 24; PALETTEOBJ* palPtr = (PALETTEOBJ *) GDI_GetObjPtr( hPal, PALETTE_MAGIC ); + int ret; /* palPtr can be NULL when DC is being destroyed */ if( !palPtr ) return 0; + ret = X11DRV_PALETTEOBJ_ToPhysical(dc, hPal, palPtr, color); + GDI_ReleaseObj( hPal ); + return ret; +} + +/*********************************************************************** + * X11DRV_PALETTEOBJ_ToPhysical + * + * Return the physical color closest to 'color'. + */ +int X11DRV_PALETTEOBJ_ToPhysical( DC *dc, HPALETTE hPal, PALETTEOBJ* palPtr, COLORREF color ) +{ + WORD index = 0; + unsigned char spec_type = color >> 24; + + if (!palPtr) return 0; if ( X11DRV_PALETTE_PaletteFlags & X11DRV_PALETTE_FIXED ) { /* there is no colormap limitation; we are going to have to compute @@ -852,14 +861,12 @@ if( (idx = color & 0xffff) >= palPtr->logpalette.palNumEntries) { WARN("RGB(%lx) : idx %d is out of bounds, assuming black\n", color, idx); - GDI_ReleaseObj( hPal ); return 0; } if( palPtr->mapping ) { int ret = palPtr->mapping[idx]; - GDI_ReleaseObj( hPal ); return ret; } color = *(COLORREF*)(palPtr->logpalette.palPalEntry + idx); @@ -872,7 +879,6 @@ case 0: /* RGB */ if( dc && (dc->bitsPerPixel == 1) ) { - GDI_ReleaseObj( hPal ); return (((color >> 16) & 0xff) + ((color >> 8) & 0xff) + (color & 0xff) > 255*3/2) ? 1 : 0; } @@ -884,7 +890,6 @@ if (X11DRV_PALETTE_Graymax) { /* grayscale only; return scaled value */ - GDI_ReleaseObj( hPal ); return ( (red * 30 + green * 59 + blue * 11) * X11DRV_PALETTE_Graymax) / 25500; } else @@ -906,7 +911,6 @@ blue = blue << (X11DRV_PALETTE_PBlue.scale-8) | blue >> (16-X11DRV_PALETTE_PBlue.scale); - GDI_ReleaseObj( hPal ); return (red << X11DRV_PALETTE_PRed.shift) | (green << X11DRV_PALETTE_PGreen.shift) | (blue << X11DRV_PALETTE_PBlue.shift); } } @@ -925,7 +929,6 @@ case 0: /* RGB */ if( dc && (dc->bitsPerPixel == 1) ) { - GDI_ReleaseObj( hPal ); return (((color >> 16) & 0xff) + ((color >> 8) & 0xff) + (color & 0xff) > 255*3/2) ? 1 : 0; } @@ -955,7 +958,6 @@ } } - GDI_ReleaseObj( hPal ); return index; }

1 0

Idea: Combine libSDL with the Wine project
by erwin wolff May 5, 2003

May 5, 2003

I have an idea: Combine the SDL project with the Wine DirectX code. It is a great way to catch up with the winex project and SDL has also network code to begin working with the RASAPI32 DLL (used by various instant messengers). Since SDL is ported to every platform out there it is also good for the portability of Wine. I only hope that the license of SDL doesn't give any problems. Have a nice day ECF Wolff erwinwolffnl(a)microformatica.com

3 2

Problem using winemaker/winelib
by Neven.Luetic＠t-online.de May 5, 2003

May 5, 2003

Hello, I am currently trying to continue development of an originally Windows based project on Linux. To create a functioning Linux-executable, I have tried to use winemaker. When I specify the additional headers and libraries correctly, everything seems to be fine. At least configure and make do not show up with errors. The result of the make is a shared library, named like the executable I expected to build ("drobot.so") and a shell script "drobot". When I start this script I get: err:module:get_registry_value Invalid load order module-type L"so", ignored wine: cannot find 'drobot.exe' This seems to indicate some kind of error in the build process, because what was built is exactly a linux .so.If I change my wine config concerning DLLs from "*" = "builtin, native, so" into "*" = "builtin, native" the first message disappears. However wine is still looking for a drobot.exe (according to the generated script). The generated Makefile contains "drobot" as the executable, i.e. the shell script. What did I do wrong? Greetings -- Neven Luetic <Neven.Luetic(a)t-online.de>

2 1

x11drv
by Oliver Sampson May 5, 2003

May 5, 2003

Howdy, I was trying to do a new wine update to the latest CVS, and when cvs update gets to windows/x11drv, it just hangs. I tried deleting the windows directory and I'm using "-Pd." Is there a simple solution to this? Thanks, -- Oliver Sampson olsam(a)quickaudio.com http://www.oliversampson.com

8 8

Problem in ole32.CoCreateInstance ?
by Sylvain Petreolle May 5, 2003

May 5, 2003

Trying to run dxdiag for testing DirectPlay , get a read at 0x0 in CoCreateInstance at line 1355 (dlls/ole32/compobj.c): 1355 hres = IClassFactory_CreateInstance(lpclf, pUnkOuter, iid, ppv); This cant work since lpcf is always 0 and this function is defined as a macro in include/unknwn.h : ./include/unknwn.h:160:#define IClassFactory_CreateInstance(p,a,b,c) (p)->lpVtbl->CreateInstance(p,a,b,c) Should we rewrite this as a function or is lpclf assumed to be non NULL ? ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

3 4

Ole32 16/32 questions
by Steven Edwards May 5, 2003

May 5, 2003

Hello, I need to break some of the Win16/32 and non winapi calls apart in ole32 for our work on ReactOS and I dont know what the best method will be. Without ole32 we cant make much use of anything else so I'm going to start working on this soon. Ole16 and ole2 look like good starting points for moving code around but I would like the help of someone that has worked on this code. I will start by making a list of all of the non-win32 functions I can compile out while still leaving ole32 in a usable state, maybe this help give you a idea as to where we can move code around. Thanks Steven

1 0

MSVCRT calling convention issue
by us＠the-edmeades.demon.co.uk May 5, 2003

May 5, 2003

While debugging a game which only installs if we use the windows msvcrt, I have identified the problem but dont know how to fix it! The problem revolves around the function MSVCRT_type_info_raw_name. This is defined as stdcall, but disassembling the windows version, it clearly shows use of a calling convention I had never heard of, 'thiscall'. According to the MSDN, thiscall is stdcall BUT the 'this' pointer on x86 machines is stored in the ECX register. How can we fix this? My thought: Change the definition to not take a ptr arg, and define a local, this as being in the ECX register, but (a) I dont know how to do this, and (b) is not a solution for winelib applications. For now I can continue having put the msvcrt.dll from another machine in, but it would be nice to solve this issue. I'd also guess it affects more than just that one function. Regards, Jason

2 4

-pthread ??
by Davide Giannotti May 5, 2003

May 5, 2003

I noticed this bug (well.. not sure if it's a bug but it looks like) when compiling from current csv: the make depend command exits with an error like "-pthread unknown option" when processing the directory {wineroot}/dlls/winmm/winearts. I removed the -pthread flag from the Makefile and everything went fine. I'm using a strong customized redhat 8.0 with glibc 2.3.1. Do i miss something or is it an error? Another question: if i compile with nptl i can't get it to work fine. I have to use the LD_ASSUME_KERNEL=2.2.5 before configure and at runtime. bye -- Davide Giannotti ITS Planet s.n.c davide.giannotti(a)itsplanet.com www.itsplanet.com

1 0

Request: Using our spec files for snoop like debugging on known native DLLs
by Uwe Bonnes May 5, 2003

May 5, 2003

Hallo, snoopdebugging is a great thing, but sometimes the arguments are not found and lots of exceptions are generated while wine tries to decipher the arguments. What would it take to use our spec file and build stub dlls that could print out the arguments and then jump to the native dll entries? Any takers? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: Mac OS X Support : Signals support
by Steven Edwards May 5, 2003

May 5, 2003

--- Pierre d'Herbemont <stegefin(a)free.fr> wrote: > Hi, > This patch add in signal_powerpc.c of ntdll support for darwin signal. > Cheers, > > Pierre > > Modified files: > dlls/ntdll/signal_powerpc.c > > ChangeLog: > Add support for Darwin's signals. Please dont use C++ style comments. Thanks Steven __________________________________ Do you Yahoo!? The New Yahoo! Search - Faster. Easier. Bingo. http://search.yahoo.com

1 0

Callbacks while app is looping
by Mark Westcott May 5, 2003

May 5, 2003

Hi all, I've been working on fixing the crash in 'Gens' when trying to reassign keys. The app basically does a: while (1) { IDIRECTINPUTINTERFACE::GetDeviceState(); } Until it notices a key has been pressed. DirectInput hooks onto system keyboard events with SetWindowsHookEx(WH_KEYBOARD_LL........), but while the app is doing its nasty while(1) loop, DirectInput's callback procedure never gets called. This is as far as I can get (new to wine) - any ideas anyone? I threw a test case app that illustrates the problem (btw, the WH_KEYBOARD_LL hook has the note 'should use SendMessage instead', but I don't get what this means or know if using SendMessage instead would have anything to do with fixing this problem) -------- Mark Westcott

4 4

WinZip registry patch
by Nick Brereton May 4, 2003

May 4, 2003

Attachment is a windows registry file. Integration of this file directs WinZip to not use the Rich Edit control when displaying comments in Zip files by changing a flag that WinZip read from the registry. This means that it will work with all zip files rather than crashing out on zip files with comments. Should I post this anywhere else? eg the wine-patch list? Any comments would be appreciated. Regards, Nick Brereton

3 2

Re: How to add a new DLL?
by Gerhard W. Gruber May 4, 2003

May 4, 2003

On Sun, 4 May 2003 00:43:13 +0200, Joerg Mayer <jmayer(a)loplof.de> wrote: >So what you have to to is add the new Makefile to configure.ac - search for >AC_CONFIG_FILES([ >Then you need to run autoconf (no arguments required but we require a version >>=2.53). After that you need to rerun ./configure <options> (or >./config-status --recheck && ./config.status). Ok. So I did add it to configure.ac and ran autoconf. I could see that it was added to configure and it also created the makefile. But when I run the makefile I always get this error: make: *** No rule to make target `../../configure', needed by `Makefile'. Stop. The Makefile.in looks like this: TOPSRCDIR = @top_srcdir@ TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = w95inf32.dll IMPORTS = ALTNAMES = EXTRALIBS = $(LIBUNICODE) LDDLLFLAGS = @LDDLLFLAGS@ SYMBOLFILE = $(MODULE).tmp.o C_SRCS = w95inf32_main.c @MAKE_DLL_RULES@ ### Dependencies: ------------------------------------ I took it from lzexpand and only removed the imports and altnames. Also the C_SRCS16 because I don't have 16bit files. Or are they always needed also when it is just a 32 bit DLL? Another questions is how I can create the sources from the spec file? -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

1 0

Window opnes on other desktop
by Gerhard W. Gruber May 4, 2003

May 4, 2003

I just noticed this by accident. I closed Agent and it showed the dialog that it purges newsgroups. While it were at it I switched to another desktop and did some work and suddenly the Agent dialog popped up telling me that it now will purge the trash folder (which it does after it cleared the newsgroups). Shouldn't the wine app stay on the same desktop where I started it? I'm not sure if this is a bug or a feature, because when I start other apps in one desktop and switch to another before they open any window (i.e. Netscape takes some time) then the window will also be opened on the active desktop instead from where I launched it. -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

2 1

Assertion `!sem->obj.head' failed in release_semaphore
by Rein Klazes May 4, 2003

May 4, 2003

Hi, Starting newsbin with messages that where marked for download in a previous run ( so it will start downloading immediately at start-up) freezes after the main window is opened. The last lines of a +relay,+server trace are: | 0009:Call kernel32.ReleaseSemaphore(00000064,00000001,40732a14) ret=0041b55e | 0009: release_semaphore( handle=0x64, count=00000001 ) | wineserver: semaphore.c:96: release_semaphore: Assertion `!sem->obj.head' failed. (full 1.4 MB trace at http://www.xs4all.nl/~rklazes/temp/nb.log.bz2 ) Funny, even if the bug can be reproducebly triggered by a message that is to be downloaded ,nothing of this appears in the log: no winsock call is made. Trying with several old wines, reveals that this bug is at least 3 months old, apparently not related to the new threading code. I've searched through the trace and the server code (it must be a server bug, doesn't it?) but see nothing obviously wrong. Any suggestions? Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 2

re: current directories
by Dan Kegel May 4, 2003

May 4, 2003

Eric wrote: > - our current {Get|Set}CurrentDirectory functions behave like the win16 > implementation, and maintain a/ a default drive, b/ a default directory > on each drive That's what I expect as a user when doing "cd"'s and changing drive letters at the command.com prompt. I just verified that this is what one sees from command.com in windows me: C:\> cd d:vss C:\> d: D:\VSS> So if win32 isn't doing it, command.com is simulating it? > - Win32, on the other end, just maintains a current directory. When > using a relative path with a drive letter (like c:foo), win32 actually > uses the directory on drive c:, defined at startup (and passed into the > =c: environment variable) > - the =#: (# in [A,Z]) environment variable is never changed (even when > changing the current directory) How do you display those variables? I have a C program that iterates through envp[] and it doesn't see 'em. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

2 1

current directories
by Eric Pouech May 4, 2003

May 4, 2003

while looking at the split of kernel and ntdll, I ran into an interesting point: - our current {Get|Set}CurrentDirectory functions behave like the win16 implementation, and maintain a/ a default drive, b/ a default directory on each drive - Win32, on the other end, just maintains a current directory. When using a relative path with a drive letter (like c:foo), win32 actually uses the directory on drive c:, defined at startup (and passed into the =c: environment variable) - the =#: (# in [A,Z]) environment variable is never changed (even when changing the current directory) I checked this behavior on Win98 and Win2K. I'm surprised noone ever run into this bug before (or this is something that is known for quite some time ?) A+ -- Eric Pouech

1 0

Re: Add wglGetExtensionsStringARB to opengl
by Lionel Ulmer May 4, 2003

May 4, 2003

> this patch adds wglGetExtensionsStringARB to the opengl.dll. I don't > know if it really does all in the proper way. So somebody with more > opengl experiences should take a look at the patch before including it. Well, I think the best way would be to do something like that : Index: dlls/opengl32/opengl32.spec =================================================================== RCS file: /home/wine/wine/dlls/opengl32/opengl32.spec,v retrieving revision 1.19 diff -u -r1.19 opengl32.spec --- dlls/opengl32/opengl32.spec 20 Mar 2003 03:53:13 -0000 1.19 +++ dlls/opengl32/opengl32.spec 3 May 2003 20:41:57 -0000 @@ -6,6 +6,7 @@ @ stdcall wglGetCurrentContext() @ stdcall wglGetCurrentDC() @ stdcall wglGetExtensionsStringEXT() +@ stdcall wglGetExtensionsStringARB() wglGetExtensionsStringEXT @ stdcall wglGetLayerPaletteEntries(long long long long ptr) @ stdcall wglGetProcAddress(str) @ stdcall wglMakeCurrent(long long) Could you try if this works for you ? Basically, your patch is wrong because you return OpenGL extensions whereas this function should return WGL extensions (and as we do not support any for now, we return an empty string). Moreover, Wine already supported 'wglGetExtensionsStringEXT' (needed by some games), so I just told here that 'wglGetExtensionsStringARB' is a duplicate of the 'wglGetExtensionsStringEXT' function. Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 4

dlls/dmusic/dmusic_main.c
by Gerald Pfeifer May 4, 2003

May 4, 2003

The following change to dlls/dmusic/dmusic_main.c revision 1.3 date: 2003/05/04 02:26:03; author: julliard; state: Exp; lines: +8 -0 Rok Mandeljc <rokmandeljc(a)hotmail.com> Dmusic class factory can now create dmloader8 and dmperformance8. introduced the following warnings dmusic_main.c:74: warning: implicit declaration of function `DMUSIC_CreateDirectMusicPerformance8' dmusic_main.c:78: warning: implicit declaration of function `DMUSIC_CreateDirectMusicLoader8' Would you mind addressing this? Thanks, Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/

1 0

No console output?
by Juan Lang May 4, 2003

May 4, 2003

I'm trying to run a console program with wineconsole, and I see fixme output from the DLL I'm working on, but no output from my program. Any patches I should be applying? Wine20030408 on RH "phoebe" (8.1-ne-9 beta). FWIW, I'm working on iphlpapi.dll. I might take a crack at consolidating some duplicated code in netapi32, winsock, and wsock32 if I have time. Thanks, --Juan __________________________________ Do you Yahoo!? The New Yahoo! Search - Faster. Easier. Bingo. http://search.yahoo.com

2 3

How to add a new DLL?
by Gerhard W. Gruber May 3, 2003

May 3, 2003

I was just trying to add a new dll to wine (w95in32.dll and w95inf16.dll). In order to achieve this I looked into some other dlls and copied the Makefile and Makefile.in. The I created the specfile for the dll and adjusted the Makefile. At least that was what I think I did, but it always complains that I have to run configure. So I adjusted configure as well and rerun it, but i stil get this error. Is there somewhere an explanation so I can look how I have to configure Makefile.in. The Makefile will be generated from this through configure, right? -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

3 2

Re: Solaris Update Patch 02052003
by Dimitrie O. Paun May 3, 2003

May 3, 2003

On Fri, 2 May 2003, Robert Lunnon wrote: > OOPS forgot to attach the patch here it is This pcontext() thing is very ugly: +static void pcontext ( CONTEXT *context, int trap_code, void *cr2, int err_code){ Please do a const char *dbg_context ( CONTEXT *context ); function which converts the context to a string, and then use directly TRACEs instead of pcontext. There are examples in the code on how to do so via the wine_dbg_sprintf() function. See ./dlls/x11drv/xvidmode.c around line 460, in the _CDS_flags() function. -- Dimi.

3 2

Re: wineHQ update
by Dimitrie O. Paun May 3, 2003

May 3, 2003

On May 3, 2003 03:55 pm, erwin wolff wrote: > This patch modifies the WineHQ website at two pionts. It adds a webbased > forum who is donated by a company to the forums section and updates the > working state of borlands cc in the fun projects page according the news > issue 168. Few comments: -- Please send patches in the right format: http://winehq.org/?page=sending_patches -- I don't think I like yet another forum. It unnecessarily dilutes them. We have the newsgroup, wine-*, they should be enough. If anonymity is the only feature, people should open web-mail accounts, there are plenty around. -- Please funnel all Fun-related changes through me. I'll take care of updating the WineHQ site, otherwise changes submitted to WineHQ will most likely get lost on my next update. -- Dimi.

1 0