May 2003 - Wine-Devel - list.winehq.org

Re : Fix sound3d compile problem
by Sylvain Petreolle May 22, 2003

May 22, 2003

I dont understand why this patch fixes anything, this is a noop ? - TRACE("(%p)\n",ds3db); /* volume, at which the sound will be played after all calcs. */ D3DVALUE lVolume = 0; @@ -205,6 +204,7 @@ D3DVALUE flFreq, flBufferVel, flListenerVel; #endif + TRACE("(%p)\n",ds3db); ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

3 2

Speaking about the Putty Regression
by Carlos Lozano May 22, 2003

May 22, 2003

Hello, The line what is produccing the regression is: void X11DRV_SetWindowStyle( HWND hwnd, LONG oldStyle ) { Display *display = thread_display(); WND *wndPtr; LONG changed; if (hwnd == GetDesktopWindow()) return; if (!(wndPtr = WIN_GetPtr( hwnd ))) return; if (wndPtr == WND_OTHER_PROCESS) return; changed = wndPtr->dwStyle ^ oldStyle; if (changed & WS_VISIBLE) { if (!IsRectEmpty( &wndPtr->rectWindow ) && !is_window_top_level(wndPtr)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Before of the regression it was: if (!IsRectEmpty( &wndPtr->rectWindow )) Regards, Carlos. -- ___ _ \ | / Consulting | . |._ _ _| | ___ ___ ___ http://www.andago.com | || ' |/ . |<_> |/ . |/ . \__ GNU/Linux |_|_||_|_|\___|<___|\_. |\___/ _ \ __|\ \ / Carlos A. Lozano <___'/ | \ -_) __/\__ \ > < -_) [ carlos.lozano(a)andago.com ]\___|_| ____/ _/\_\___| [ calb(a)epsxe.com ] http://www.ePSXe.com

1 0

Re: int21 testing
by Jukka Heinonen May 22, 2003

May 22, 2003

Ferenc Wagner wrote: > is there a way to incorporate DOS interrupt testing in the > conformance testing framework? I recall that I saw some > comments that Win32 applications should not be able to call > DOS interrupts. But it should be testable at least... Now > I have separate DOS16 programs for that. Win32 application cannot call interrupts directly. You could use VWIN32 VxD to call some interrupts (int21 for example) and this should even work under Win95/Win98/WinMe. It could even be possible that this works under WinXP, if it has emulation code for supporting old applications, but I doubt it. -- Jukka Heinonen <http://www.iki.fi/jhei/>

2 3

Today's meeting
by Dimitrie O. Paun May 21, 2003

May 21, 2003

Hi guys, To clarify: -- channel is #winemeet on freenode.net (I use the asimov.freenode.net server) -- time is 3 EDT (1900 UTC) -- a few of us should log the session (BTW, how do you log a session?) I am there now, but I will not have too much time to chat until the regular meeting starts. -- Dimi.

4 5

Re: [D3D] Some execute buffers rewrites + misc fixes
by Lionel Ulmer May 21, 2003

May 21, 2003

Well, I have a comment... But it's in a part of the code that will be so rarely used that it could be completely thrown away anyway :-) Basically, you are doing the full projection (without doing the clipping though) in software... And this does not go well at all with lighting. This is why I choose in the previous code to only do the world transformation to NOT impact at all lighting (and it worked for Twist AFAIK). So I am wondering why you choose to go all the way and did not do exactly as I did (basically, only do the WORLD transform and set only the PROJ / VIEW one using the D3D7 API and set the WORLD to Identity as we already did the transform). Even better would have been to have reused fully our VertexBuffer code and our (hacky :-) ) TransformVertices code. Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

Re: dlls/ntdll/cdrom.c CDROM_ScsiPassThrough on NetBSD
by yorickhardy May 21, 2003

May 21, 2003

Alexandre, My sincerest apologies, I see it is in fact there. I think I missed something when I looked through wine-cvs and the web cvs (I looked at source.winehq.org instead of cvs.winehq.com) Thanks, Yorick. ----- Original Message ----- Date: Wed May 21, 2003 09:22 AM From: Alexandre Julliard <julliard(a)winehq.com> To: yh(a)metroweb.co.za cc: wine-devel(a)winehq.com Subject: Re: dlls/ntdll/cdrom.c CDROM_ScsiPassThrough on NetBSD yh(a)metroweb.co.za writes: > I see this patch was included > http://www.winehq.org/hypermail/wine-patches/2003/05/0258.html > http://www.winehq.org/hypermail/wine-cvs/2003/05/0312.html > > I apologise if it was not clear but the patch > http://www.winehq.org/hypermail/wine-patches/2003/05/0241.html > should be applied first, which includes the neccessary header files. I thought I applied it, what did I do wrong? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: dlls/ntdll/cdrom.c CDROM_ScsiPassThrough on NetBSD
by yh＠metroweb.co.za May 21, 2003

May 21, 2003

I see this patch was included http://www.winehq.org/hypermail/wine-patches/2003/05/0258.html http://www.winehq.org/hypermail/wine-cvs/2003/05/0312.html I apologise if it was not clear but the patch http://www.winehq.org/hypermail/wine-patches/2003/05/0241.html should be applied first, which includes the neccessary header files. Regards, Yorick Hardy. ------------------------------------------------------- This message was sent using MetroWEB's WebMail service. http://www.metroweb.co.za/ - full access for only R59

2 1

Re: Fix ListView Bugs
by Dimitrie O. Paun May 21, 2003

May 21, 2003

On May 17, 2003 06:37 am, Robert Shearman wrote: > It is the second one. The 0th subitem always seems to stay in the 0th > column and the other subitems are shifted. (Note that the column headings > are shifted normally, ie. column 0 has a new column heading). Interesting. This seems to mean that we can remove a lot of fancy code from there :) What about this patch: Index: dlls/comctl32/listview.c =================================================================== RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.351 diff -u -r1.351 listview.c --- dlls/comctl32/listview.c 13 May 2003 00:30:10 -0000 1.351 +++ dlls/comctl32/listview.c 19 May 2003 07:28:54 -0000 @@ -6242,25 +6242,10 @@ /* now we have to actually adjust the data */ if (!(infoPtr->dwStyle & LVS_OWNERDATA) && infoPtr->nItemCount > 0) { - SUBITEM_INFO *lpSubItem, *lpMainItem, **lpNewItems = 0; + SUBITEM_INFO *lpSubItem; HDPA hdpaSubItems; INT nItem, i; - /* preallocate memory, so we can fail gracefully */ - if (nNewColumn == 0) - { - lpNewItems = COMCTL32_Alloc(sizeof(SUBITEM_INFO *) * infoPtr->nItemCount); - if (!lpNewItems) goto fail; - for (i = 0; i < infoPtr->nItemCount; i++) - if (!(lpNewItems[i] = COMCTL32_Alloc(sizeof(SUBITEM_INFO)))) break; - if (i != infoPtr->nItemCount) - { - for(; i >=0; i--) COMCTL32_Free(lpNewItems[i]); - COMCTL32_Free(lpNewItems); - goto fail; - } - } - for (nItem = 0; nItem < infoPtr->nItemCount; nItem++) { hdpaSubItems = (HDPA)DPA_GetPtr(infoPtr->hdpaItems, nItem); @@ -6270,21 +6255,7 @@ if (lpSubItem->iSubItem >= nNewColumn) lpSubItem->iSubItem++; } - - /* for inserting column 0, we have to special-case the main item */ - if (nNewColumn == 0) - { - lpMainItem = (SUBITEM_INFO *)DPA_GetPtr(hdpaSubItems, 0); - lpSubItem = lpNewItems[nItem]; - lpSubItem->hdr = lpMainItem->hdr; - lpSubItem->iSubItem = 1; - ZeroMemory(&lpMainItem->hdr, sizeof(lpMainItem->hdr)); - lpMainItem->iSubItem = 0; - DPA_InsertPtr(hdpaSubItems, 1, lpSubItem); - } } - - COMCTL32_Free(lpNewItems); } /* make space for the new column */ -- Dimi.

2 1

Re: ddraw: load OpenGL at runtime
by Lionel Ulmer May 20, 2003

May 20, 2003

Alexandre, please do NOT commit this... The separation of GL calls from DDraw will be part of the D3D core work and not via the usage of funtion pointers. Basically, we will have a d3dcore library linked to OpenGL and if DDraw fails to load it (for example if GL is not present on the system), DDraw will not support D3D. Mike, next time ask on IRC before doing a big patch like this on DDraw / D3D (or ask on the wine-d3d mailing list, it will add to its activity :-) ). Lionel -- Lionel Ulmer - http://www.bbrox.org/

11 30

[FYI] SourceForge stats
by Dimitrie O. Paun May 20, 2003

May 20, 2003

Folks, For the first time we are in the first 30 downloads (position 29 :)) on SourceForge: http://sourceforge.net/top/toplist.php?type=downloads_week We need to make it to the fist 10, so we are always featured on the front page :) But we need to more than quadruple our downloads to achieve that. Alexandre, I think you need to release more often ;) -- Dimi.

4 11