June 2003 - Wine-Devel - list.winehq.org

problem with apps in desktop mode
by Rok Mandeljc Aug. 19, 2003

Aug. 19, 2003

When I try running InstallShield in windowed mode ("Desktop" = "640x480" as per default in config), window appears for a second and then dissapears printing this message: X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 12 (X_ConfigureWindow) Serial number of failed request: 93 Current serial number in output stream: 98 Did latest modifications of x11drv break anything? -- Rok Mandeljc <rok.mandeljc(a)gimb.org> "All that is gold does not glitter, Not all those who wander are lost; The old that is strong does not wither, Deep roots are not reached by the frost. >From the ashes a fire shall be woken, A light from the shadows shall spring; Renewed shall be blade that was broken, The crownless again shall be king." -- J.R.R. Tolkien

4 3

Re: WaitForMultipleObjects loops forever if passed an array of size zero
by Alexandre Julliard Aug. 5, 2003

Aug. 5, 2003

Troy Rollo <wine(a)troy.rollo.name> writes: > @@ -412,7 +412,7 @@ > { > int ret, cookie; > > - if (count > MAXIMUM_WAIT_OBJECTS) return STATUS_INVALID_PARAMETER_1; > + if (count > MAXIMUM_WAIT_OBJECTS || count <= 0) return > STATUS_INVALID_PARAMETER_1; This is wrong, 0 is a valid count, and shouldn't cause an infinite loop. You'll need to debug this some more. -- Alexandre Julliard julliard(a)winehq.com

6 12

still many warnings from Mesa
by Gerald Pfeifer July 15, 2003

July 15, 2003

As far as I can see, patches from Raphaël resolved many related warnings I used to see (Thanks!), but using XFree86 4.3 and Mesa 3.4.2 I still get the following. Could someone please have a look at addressing these? directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: comparison between pointer and integer wgl.c:334: warning: assignment makes pointer from integer without a cast opengl_norm.c:26: warning: implicit declaration of function `glActiveTextureARB' opengl_norm.c:208: warning: implicit declaration of function `glClientActiveTextureARB' opengl_norm.c:2150: warning: implicit declaration of function `glMultiTexCoord1dARB' opengl_norm.c:2160: warning: implicit declaration of function `glMultiTexCoord1dvARB' opengl_norm.c:2170: warning: implicit declaration of function `glMultiTexCoord1fARB' opengl_norm.c:2180: warning: implicit declaration of function `glMultiTexCoord1fvARB' opengl_norm.c:2190: warning: implicit declaration of function `glMultiTexCoord1iARB' opengl_norm.c:2200: warning: implicit declaration of function `glMultiTexCoord1ivARB' opengl_norm.c:2210: warning: implicit declaration of function `glMultiTexCoord1sARB' opengl_norm.c:2220: warning: implicit declaration of function `glMultiTexCoord1svARB' opengl_norm.c:2230: warning: implicit declaration of function `glMultiTexCoord2dARB' opengl_norm.c:2240: warning: implicit declaration of function `glMultiTexCoord2dvARB' opengl_norm.c:2250: warning: implicit declaration of function `glMultiTexCoord2fARB' opengl_norm.c:2260: warning: implicit declaration of function `glMultiTexCoord2fvARB' opengl_norm.c:2270: warning: implicit declaration of function `glMultiTexCoord2iARB' opengl_norm.c:2280: warning: implicit declaration of function `glMultiTexCoord2ivARB' opengl_norm.c:2290: warning: implicit declaration of function `glMultiTexCoord2sARB' opengl_norm.c:2300: warning: implicit declaration of function `glMultiTexCoord2svARB' opengl_norm.c:2310: warning: implicit declaration of function `glMultiTexCoord3dARB' opengl_norm.c:2320: warning: implicit declaration of function `glMultiTexCoord3dvARB' opengl_norm.c:2330: warning: implicit declaration of function `glMultiTexCoord3fARB' opengl_norm.c:2340: warning: implicit declaration of function `glMultiTexCoord3fvARB' opengl_norm.c:2350: warning: implicit declaration of function `glMultiTexCoord3iARB' opengl_norm.c:2360: warning: implicit declaration of function `glMultiTexCoord3ivARB' opengl_norm.c:2370: warning: implicit declaration of function `glMultiTexCoord3sARB' opengl_norm.c:2380: warning: implicit declaration of function `glMultiTexCoord3svARB' opengl_norm.c:2390: warning: implicit declaration of function `glMultiTexCoord4dARB' opengl_norm.c:2400: warning: implicit declaration of function `glMultiTexCoord4dvARB' opengl_norm.c:2410: warning: implicit declaration of function `glMultiTexCoord4fARB' opengl_norm.c:2420: warning: implicit declaration of function `glMultiTexCoord4fvARB' opengl_norm.c:2430: warning: implicit declaration of function `glMultiTexCoord4iARB' opengl_norm.c:2440: warning: implicit declaration of function `glMultiTexCoord4ivARB' opengl_norm.c:2450: warning: implicit declaration of function `glMultiTexCoord4sARB' opengl_norm.c:2460: warning: implicit declaration of function `glMultiTexCoord4svARB' Thanks, Gerald

4 15

Copy & Paste doesn't work again
by Gerhard W. Gruber July 3, 2003

July 3, 2003

The last version (CVS from about two weeks ago I guess) supported Copy & Paste from Agent to Linux apps. This doesn't work anymore. -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

4 8

Re: Don't set stacking order against unvisible windows
by Alexandre Julliard July 2, 2003

July 2, 2003

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Changelog: > dlls/x11drv/window.c: X11DRV_sync_whole_window_position > Don't specify a stacking order agains unvisible windows This will break other things. The right fix is to make the desktop option work correctly across processes. -- Alexandre Julliard julliard(a)winehq.com

3 4

About NtDelayExecution & Sleep
by Sylvain Petreolle June 30, 2003

June 30, 2003

Seems we will have a drastic performance improvement :) : Programs that used to hang into (Nt)WaitForMultipleObjects were a lot. http://www.winehq.org/hypermail/wine-cvs/2003/06/0260.html http://www.winehq.org/hypermail/wine-cvs/2003/06/0274.html ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 alias upsf='false ; while [ $? -ne 0 ] ; do cvs update -APd ; done 2>&1 |tee cvslog' "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: wine.texinfo.diff
by Alexandre Julliard June 30, 2003

June 30, 2003

Tom Wickline <twickline(a)skybest.com> writes: > Changelog > > Change Copyright from 1997,1998 to 1997-2003 There's no reason to do that, this file hasn't really changed in a long time. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Loader fix for pathes differing by extra backslashes
by Eric Pouech June 30, 2003

June 30, 2003

Mike McCormack wrote: > > Hi, > > The loader seems to have a problem with extra backslashes in module > pathnames. > > If "c:\\windows\\system\\ole32.dll" is loaded and unloaded, then > "c:\\windows\\system\\\\ole32.dll" is loaded, there will be trouble, as > the loader does not recognise these two as the same module, yet dlopen > does. Did you test what Windows does in that case ? (I also wonder where the double backslash comes from). A+ -- Eric Pouech

3 2

Re: [dx61] d3d9 guid + d3d9 header fixes
by Alexandre Julliard June 30, 2003

June 30, 2003

Raphaël Junqueira <fenix(a)club-internet.fr> writes: > Index: include/d3d9types.h > =================================================================== > RCS file: /home/wine/wine/include/d3d9types.h,v > retrieving revision 1.2 > diff -u -r1.2 d3d9types.h > --- include/d3d9types.h 24 Jun 2003 19:26:51 -0000 1.2 > +++ include/d3d9types.h 27 Jun 2003 22:14:40 -0000 > @@ -1131,8 +1131,10 @@ > typedef struct _D3DADAPTER_IDENTIFIER9 { > char Driver[MAX_DEVICE_IDENTIFIER_STRING]; > char Description[MAX_DEVICE_IDENTIFIER_STRING]; > - char DeviceName[32]; /* Device name for GDI (ex. \\.\DISPLAY1) */ > - LARGE_INTEGER DriverVersion; > + char DeviceName[32]; > + DWORD DriverVersionLowPart; > + DWORD DriverVersionHighPart; > + Isn't DriverVersionLow/HighPart supposed to be for 16-bit code? Why do you need to use that instead of DriverVersion? -- Alexandre Julliard julliard(a)winehq.com

2 3

Re: Mac OS X Support : Asm syntax support [Fixed]
by Alexandre Julliard June 30, 2003

June 30, 2003

"Pierre d'Herbemont" <stegefin(a)free.fr> writes: > +# define LD_SKIP(i) This won't work, we need to reserve space for the PE header. > +# define PPC_SYM(sym_name) "_" #sym_name This one should use __ASM_NAME. Also it would be nice if you could use fewer macros, this makes the code quite ugly. It seems the main difference is in register names, you could simply have one macro for that and leave the rest alone. -- Alexandre Julliard julliard(a)winehq.com

2 2

Memory Protection Wierdness
by Robert Lunnon June 30, 2003

June 30, 2003

I am playing with Worms II and the installer that comes with the Demo and uncovered a signal handling fault Under Solaris and some wierdness in the installer. After decompressing the application the installer executes the setup program which displays a splash screen the application then generates a Page Fault Exception. I can't give a stack trace because here is where the wierdness is. The Setup Program seems to not inherit the -debugmsg status and doesn't end up under control of the debugger (By this time there are 5 wine processes running) Anyway to cut a long story short the page fault DOES occur in a mapped region (Its in VIRTUAL_DumpViews() listing) but doesn't have a handler associated with it. This makes VirtualHandleFault fall through to the following code BYTE vprot = view->prot[((char *)addr - (char *)view->base) >> page_shift]; void *page = (void *)((UINT_PTR)addr & ~page_mask); char *stack = (char *)NtCurrentTeb()->stack_base + SIGNAL_STACK_SIZE + page_mask + 1; if (vprot & VPROT_GUARD) { VIRTUAL_SetProt( view, page, page_mask + 1, vprot & ~VPROT_GUARD ); ret = STATUS_GUARD_PAGE_VIOLATION; } /* is it inside the stack guard pages? */ if (((char *)addr >= stack) && ((char *)addr < stack + 2*(page_mask+1))) ret = STATUS_STACK_OVERFLOW; But of course this code doesn't reset the page protections to allow the access. I Doctored this code so it would always allow the access and the installer then completed OK, But worms itself will not run yet Q. Should all views have handlers ? Under What Conditions would they not ???

2 1

Re: RESUBMIT: --disable-debug -> no -gstabs+
by Alexandre Julliard June 30, 2003

June 30, 2003

Marcus Meissner <marcus(a)jet.franken.de> writes: > Changelog: > Except when we explicitly --disable-debug, add -gstabs+ > if possible. I don't see much point in doing that, --disable-debug is broken anyway (and should probably be removed). You need to tweak the CFLAGS to make it work right, and then you can just as well get rid of -gstabs+ in the CFLAGS too. -- Alexandre Julliard julliard(a)winehq.com

1 0

Official MS symbol sets
by Mike Hearn June 30, 2003

June 30, 2003

Hi, http://www.microsoft.com/whdc/ddk/debugging/symbolpkg.mspx I assume people have looked at this before - how easy are they to match up with Wine, and do people use them for debugging faults in native code? thanks -mike -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

2 1

Package setups
by Mike Hearn June 30, 2003

June 30, 2003

hi, I'm just looking at the HOWTO and want to clarify that all the Wine RPMs/packages attempt to set up a fake windows drive and configuration for the user. I'm under the impression that binary packages should work out of the box, so the user has no need to create their own config or fake windows drive. Is this right? If so, I'll amend the HOWTO to suit.

1 0

difference between delivery delays introduced by list-server and web-archive
by Saulius Krasuckas June 30, 2003

June 30, 2003

hello, newbie is testing delays. thank you for not paying your attention. good luck

1 0

regression of patch 8366
by Oleg Prokhorov June 30, 2003

June 30, 2003

Hello , This patch http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8366 Caused regression with chess.net application. (http://www.chess.net/cnfw/download/cnfw254.exe) If you click on a help button it will drop a messagebox which tells that 'No browser found', it is normal. The anomality is that it is not possible to close messagebox by clicking "ok" button with a mouse. But both pressing "enter" and clicking close window icon work. The line which produce the problem is (dlls/ole2/compobj.c) apt->win = CreateWindowA(aptWinClass, NULL, 0, 0, 0, 0, 0, 0, 0, OLE32_hInstance, NULL); -- Best regards, Oleg mailto:xolegpro(a)rbcmail.ru

1 0

Re: Known Wine ToDo's
by Shachar Shemesh June 30, 2003

June 30, 2003

Tom wrote: > Hello Shachar, > > I am going to update the ToDo page : > http://www.winehq.com/?page=status_todo > > And im wondering if you can send me a list of ToDo's that your > aware of ? > > Thanks > > Tom > The tasks I'm talking about here are long term. Not all of them have been discussed on wine-devel yet. I'm CCing wine-devel in case anyone wants to object. National Language Support - Remove "Hebrew and Arabic" - it's just part of BiDi if technology is what wer'e talking about. If interface localization is what wer'e talking about, then just add "add localization to more languages". As a subitem of keyboard support, add "allow using a keyboard with keys outside the current locale codepage". Tools - Add "perform Windows' reboot operations automatically when required". Under "Low priority" add "Windows ACL support". -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

1 0

Re: [MSRLE32] Some bugs and improvements.
by Tom June 29, 2003

June 29, 2003

Michael Günnewig wrote: >Changelog: > - Fixed interframe compression - now works for RLE4 and RLE8. > - Fixed alignment of RLE4 in absolute mode. > - Improved compression (smaller output). > > Michael Günnewig > > > >------------------------------------------------------------------------ > >Index: dlls/msvideo/msrle32/msrle32.c >=================================================================== >RCS file: /home/wine/wine/dlls/msvideo/msrle32/msrle32.c,v >retrieving revision 1.4 >diff -d -u -r1.4 msrle32.c >--- dlls/msvideo/msrle32/msrle32.c 13 Jun 2003 23:17:01 -0000 1.4 >+++ dlls/msvideo/msrle32/msrle32.c 29 Jun 2003 17:32:06 -0000 >@@ -1,5 +1,5 @@ > /* >- * Copyright 2002 Michael Günnewig >+ * Copyright 2002-2003 Michael Günnewig > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public >@@ -17,8 +17,7 @@ > */ > > /* TODO: >- * - compression of RLE4 is buggy -- see FIXME's >- * - many improvements possible >+ * - some improvements possible > * - implement DecompressSetPalette? -- does we need it for anything? > */ > >@@ -297,10 +296,13 @@ > if (ColorCmp(clr1, clr3) <= lDist && > ColorCmp(clr2, clr4) <= lDist) { > /* diff at end? -- look-ahead for atleast ?? more encodable pixel */ >- >- /* FIXME */ >- >- return count; >+ if (pos + 2 < width && ColorCmp(clr1,lpB[pos+1]) <= lDist && >+ ColorCmp(clr2,lpB[pos+2]) <= lDist) { >+ if (pos + 4 < width && ColorCmp(lpB[pos+1],lpB[pos+3]) <= lDist && >+ ColorCmp(lpB[pos+2],lpB[pos+4]) <= lDist) >+ return count - 3; /* followed by atleast 4 encodable pixels */ >+ return count - 2; >+ } > } else if (lpP != NULL && ColorCmp(lpP[pos], lpB[pos]) <= lDist) { > /* 'compare' with previous frame for end of diff */ > INT count2 = 0; >@@ -331,9 +333,11 @@ > > for (count = 0; pos < width; pos++, count++) { > if (ColorCmp(lpA[pos], lpB[pos]) <= lDist) { >- /* diff at end? -- look-ahead for atleast one more encodable pixel */ >- if (pos + 1 < width && ColorCmp(lpA[pos], lpB[pos+1]) <= lDist) >- return count; >+ /* diff at end? -- look-ahead for some more encodable pixel */ >+ if (pos + 1 < width && ColorCmp(lpB[pos], lpB[pos+1]) <= lDist) >+ return count - 1; >+ if (pos + 2 < width && ColorCmp(lpB[pos+1], lpB[pos+2]) <= lDist) >+ return count - 1; > } else if (lpP != NULL && ColorCmp(lpP[pos], lpB[pos]) <= lDist) { > /* 'compare' with previous frame for end of diff */ > INT count2 = 0; >@@ -382,6 +386,8 @@ > /* add some pixel for absoluting if possible */ > count += countDiffRLE4(lpP, lpC - 1, lpC, pos-1, lDist, lpbi->biWidth); > >+ assert(count > 0); >+ > /* check for near end of line */ > if (x + count > lpbi->biWidth) > count = lpbi->biWidth - x; >@@ -390,9 +396,11 @@ > while (count > 2) { > INT i; > INT size = min(count, 254); >- BOOL extra_byte = (size / 2) % 2 || (size % 2); >+ int bytes = ((size + 1) & (~1)) / 2; >+ BOOL extra_byte = bytes & 0x01; > >- *lpSizeImage += 2 + size/2 + (size % 2) + extra_byte; >+ *lpSizeImage += 2 + bytes + extra_byte; >+ assert(((*lpSizeImage) % 2) == 0); > count -= size; > *lpOut++ = 0; > *lpOut++ = size; >@@ -468,6 +476,8 @@ > /* add some more pixels for absoluting if possible */ > count += countDiffRLE8(lpP, lpC - 1, lpC, pos-1, lDist, lpbi->biWidth); > >+ assert(count > 0); >+ > /* check for over end of line */ > if (x + count > lpbi->biWidth) > count = lpbi->biWidth - x; >@@ -663,6 +673,10 @@ > assert(lpOut == lpOutStart + lpbiOut->biSizeImage); > } > } >+ >+ /* add EOL -- will be changed to EOI */ >+ lpbiOut->biSizeImage += 2; >+ *((LPWORD)lpOut)++ = 0; > } > > /* change EOL to EOI -- end of image */ >@@ -789,11 +803,14 @@ > if (jumpy == 0) { > /* add EOL -- end of line */ > lpbiOut->biSizeImage += 2; >- *lpOut++ = 0; >- *lpOut++ = 0; >+ *((LPDWORD)lpOut)++ = 0; > assert(lpOut == (lpOutStart + lpbiOut->biSizeImage)); > } > } >+ >+ /* add EOL -- will be changed to EOI */ >+ lpbiOut->biSizeImage += 2; >+ *((LPDWORD)lpOut)++ = 0; > } > > /* change EOL to EOI -- end of image */ >@@ -847,7 +864,7 @@ > } > break; > default: /* absolute mode */ >- extra_byte = (code1 / 2) & 0x01 || (code1 % 2); >+ extra_byte = (((code1 + 1) & (~1)) / 2) & 0x01; > > if (pixel_ptr/bytes_per_pixel + code1 > lpbi->biWidth) > return ICERR_ERROR; >@@ -1468,9 +1485,7 @@ > > if (lpic->lpbiOutput->biBitCount == 4) > MSRLE32_CompressRLE4(pi, lpic->lpbiInput, (LPBYTE)lpic->lpInput, >- lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, TRUE); >- /*MSRLE32_CompressRLE4(pi, lpic->lpbiInput, (LPBYTE)lpic->lpInput, >- lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, (lpic->dwFlags & ICCOMPRESS_KEYFRAME) != 0);*/ >+ lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, (lpic->dwFlags & ICCOMPRESS_KEYFRAME) != 0); > else > MSRLE32_CompressRLE8(pi, lpic->lpbiInput, (LPBYTE)lpic->lpInput, > lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, (lpic->dwFlags & ICCOMPRESS_KEYFRAME) != 0); > >

1 0

Re: Uninitialised variable in TASK_Create
by Saulius Krasuckas June 29, 2003

June 29, 2003

> Hi, > > There is an unintialised string (the name variable) in TASK_Create in > task.c (visible if you run almost any program with --debugmsg +task). > I would try and fix the problem but I have no idea what the correct > fix is. Is this just a case of adding *name = 0? > > Rob hello, (heh, i've lost the race.. :P) cents: i have found patch, which made my valgrind to scream bout the same issue: http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8245 Index: wine/loader/task.c diff -u wine/loader/task.c:1.132 wine/loader/task.c:1.133 --- wine/loader/task.c:1.132 Sun Jun 29 20:22:43 2003 +++ wine/loader/task.c Sun Jun 29 20:22:43 2003 <skipped> @@ -299,13 +300,16 @@ /* Copy the module name */ - GetModuleName16( pModule->self, name, sizeof(name) ); - strncpy( pTask->module_name, name, sizeof(pTask->module_name) ); + if (hModule) + { + GetModuleName16( hModule, name, sizeof(name) ); + strncpy( pTask->module_name, name, sizeof(pTask->module_name) ); + } in addition to null-initializing the "name", i'd add this at several page-downs: - pTask->compat_flags = GetProfileIntA( "Compatibility", name, 0 ); + if(name) + { + pTask->compat_flags = GetProfileIntA( "Compatibility", name, 0 ); + } IMHO we'd "save" two api-calls (GetProfileIntA() ant GetPrivateProfileIntA()) using such check.

1 0

Uninitialised variable in TASK_Create
by Robert Shearman June 29, 2003

June 29, 2003

Hi, There is an unintialised string (the name variable) in TASK_Create in task.c (visible if you run almost any program with --debugmsg +task). I would try and fix the problem but I have no idea what the correct fix is. Is this just a case of adding *name = 0? Rob

1 0

CVS Install error: version mismatch 113/109
by Moreno June 29, 2003

June 29, 2003

Hi, i download last wine source. i compiling and when i use wineinstall i have the follow error if i execute wine i have the same error wine client error:9: version mismatch 113/109. Your wine binary was not upgraded correctly, or you have an older one somewhere in your PATH. Or maybe the wrong wineserver is still running? Registry install failed. what can i do? -- Moreno <morenoca(a)freemail.it>

2 4

Re: QueryPerformanceFrequency bugfix
by Andreas Mohr June 29, 2003

June 29, 2003

Hi, On Sun, Jun 29, 2003 at 04:05:04PM +0100, Mike Hearn wrote: > This patch stops the demo of Settlers 4 crashing at startup. > > ChangeLog: > Add some traces > A Mhz is 1000Hz, not 100000 Whaaaaa!? First, it's 1000000, which is one zero more than what you wrote (and what the code used: +1000000.0). Second, one MHz *IS* 1000000Hz. So there are two possibilities: a) the code should calculate the result in units of kHz (then your observation would be correct) b) you are (completely? ;) wrong Andreas Mohr

2 1

Re: QueryPerformanceFrequency bugfix
by Tom June 29, 2003

June 29, 2003

Mike Hearn wrote: >Yes, OK, so as just pointed out to me, neither me nor my flatmate with >whom I double checked this can count :D > >On Sun, 2003-06-29 at 16:05, Mike Hearn wrote: > > >>This patch stops the demo of Settlers 4 crashing at startup. >> >>ChangeLog: >>Add some traces >>A Mhz is 1000Hz, not 100000 >> >> :) Here ya go : http://searchnetworking.techtarget.com/sDefinition/0,,sid7_gci212562,00.html Tom

1 0

Re: PATCH: more capabilities for linux/cpu flags
by Philipp Wollermann June 29, 2003

June 29, 2003

Hi, according to MSDN (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/ba se/isprocessorfeaturepresent.asp): PF_XMMI_INSTRUCTIONS_AVAILABLE The SSE instruction set is available. PF_XMMI64_INSTRUCTIONS_AVAILABLE The SSE2 instruction set is available. Philipp ----- Original Message ----- From: "Marcus Meissner" <marcus(a)jet.franken.de> To: <wine-patches(a)winehq.com> Sent: Sunday, June 29, 2003 12:35 PM Subject: PATCH: more capabilities for linux/cpu flags > Hi, > > This adds 2 more checks for PF_xxx flag CPU detection for Linux. > > Ciao, Marcus > > Changelog: > Add tests for PF_AMD3D and PF_XMMI instructions. (Not sure if > XMMI instructions are SSE or SSE2). > > Index: misc/cpu.c > =================================================================== > RCS file: /home/wine/wine/misc/cpu.c,v > retrieving revision 1.32 > diff -u -r1.32 cpu.c > --- misc/cpu.c 21 May 2003 18:24:34 -0000 1.32 > +++ misc/cpu.c 29 Jun 2003 10:32:11 -0000 > @@ -315,6 +315,13 @@ > PF[PF_MMX_INSTRUCTIONS_AVAILABLE] = TRUE; > if (strstr(value,"tsc")) > PF[PF_RDTSC_INSTRUCTION_AVAILABLE] = TRUE; > + if (strstr(value,"3dnow")) > + PF[PF_AMD3D_INSTRUCTIONS_AVAILABLE] = TRUE; > + /* Not sure if XMMI is sse2 or sse, stay on > + * the safe side. > + */ > + if (strstr(value,"sse2")) > + PF[PF_XMMI_INSTRUCTIONS_AVAILABLE] = TRUE; > > } > } >

1 0

link updates #4
by Tom Wickline June 29, 2003

June 29, 2003

Hello, With these three fixes all failed urls are fixed and there is only one issue of WWN in the past 13 weeks that has a failed url. The fixes to cvs.shtml, opengl-problems.shtml, wine-debugger.shtml are in #2 and #3. I was going to try and fix most/all the WWN links but after looking into this I see it could be a time consuming task. And i'm not sure how substantial the end benefit would really be.. Anyone have any comments about this ? If you guy's think its a good thing ill fix as many as I can.. If you think its a no win situation I will just look at the past 13 issues in the future.. Tom

1 0