August 2003 - Wine-Devel - list.winehq.org

Re: patch for non x86 specific code in BuildSpec16File.
by Alexandre Julliard Aug. 28, 2003

Aug. 28, 2003

Dave_Belanger(a)cimmetry.com writes: > (See attached file: patch_spec16_x86_specific) Why do you want to do that? It will generate a lot of functions that will never be used. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: patch for unprovided glXGetProcAddressARB function in Solaris OpenGL
by Lionel Ulmer Aug. 28, 2003

Aug. 28, 2003

> (See attached file: patch_sun_opengl) Well, which Wine release did you use for your patch ??!!? In current CVS Wine, we have the following code : p_glXGetProcAddressARB = wine_dlsym(opengl_handle, "glXGetProcAddressARB", NULL, 0); (...) local_func = p_glXGetProcAddressARB(lpszProc); So basically, the glXGetProcAddressARB function is loaded at run-time and then your patch is useless. Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

GtkPlug and GtkSocket mechanism
by Evalet Olivier Aug. 28, 2003

Aug. 28, 2003

I would like to know if it is possible to integrate the GtkSocket mechanism in wine. (To embed activex component in a gtk application.) I do not know exactly how to proceed, I need more informations: - do I must embed GtkSocket code in wine? - do I must synchronize GtkWidget and HWND? For the ActiveX, I use, with a dynamic link, the atl.dll to embed components. It is easy and It works with HTML editor and others stuffs... But I dont know if this is the right way to embed components? Olivier ------------------ www.programmers.ch

2 3

Exceptions
by flyker Aug. 28, 2003

Aug. 28, 2003

Using MSVC i can write __try { ... } __except( EXCEPTION_EXECUTE_HANDLER ) { ... } using Winelib i can write __TRY { ... } __EXCEPT( ??? ) { ... } what can i use how EXCEPTION_EXECUTE_HANDLER ? And i can't link this by using -lntdll

6 6

Re: patch for selection of "MS Sans Serif" font face
by Huw D M Davies Aug. 28, 2003

Aug. 28, 2003

Just add it as a font substitute in the registry ie [HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion\FontSubstitutes] ... "MS Sans Serif"="Microsoft Sans Serif" Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: misc fixes in splitpath
by Dimitrie O. Paun Aug. 28, 2003

Aug. 28, 2003

On Thu, 28 Aug 2003 Dave_Belanger(a)cimmetry.com wrote: > (See attached file: patch_splitpath) + if (swapSlashes && dir) { + /* convert backslashes back to slashes */ + for (ptr = (char*)dir; *ptr; ++ptr) { + if ('\\' == *ptr) { + *ptr = '/'; + } + } + + } Can you please try to use the same formatting style (indentation & bracket placement) as the one in the rest of the file? Otherwise the file becomes hard to read if we switch between the styles too freely. -- Dimi.

1 0

Re: patch for grid-fitting on Solaris
by Dimitrie O. Paun Aug. 28, 2003

Aug. 28, 2003

On Thu, 28 Aug 2003 Dave_Belanger(a)cimmetry.com wrote: > > (See attached file: patch_grid_fitting) > +#if defined(sparc) && defined(sun) + /* On Solaris/Sparc grid-fitting the outline produces gibberish + output for some font outlines with freetype-2.1.2 */ + load_flags |= FT_LOAD_NO_HINTING; +#endif This is rather ugly. Not only is it OS dependant, but it's also freetype 2.1.2 dependant. Can't we just require a fix in freetype? Or if it's worth disabling hinting in other cases as well, maybe it should be a configuration option. -- Dimi.

1 0

Re: patch for grid-fitting on Solaris
by Huw D M Davies Aug. 28, 2003

Aug. 28, 2003

This is a freetype bug, do you still have the problem with FreeType 2.1.4 ? (sorry I can't easily include your path because it's an attachment). Huw.

1 0

Re: patch for unefficient memory reallocation in WMF driver
by Dimitrie O. Paun Aug. 28, 2003

Aug. 28, 2003

On Thu, 28 Aug 2003 Dave_Belanger(a)cimmetry.com wrote: + if (len > physDev->allocatedSize){ + if (!physDev->allocatedSize) { + ERR("Unable to write record to unallocated memory\n"); + return FALSE; + } + /*expand size*/ + physDev->allocatedSize = (size_t)(1.2* physDev->allocatedSize + rlen); + mh = HeapReAlloc( GetProcessHeap(), 0, physDev->mh, physDev->allocatedSize); + if (!mh) { + ERR("Unable to Reallocate Heap memory\n"); + return FALSE; + } I would suggest to not issue ERRs in such cases, as the API is designed to handle OOM situations. I think it's enough to simply do: if (!physDev->allocatedSize) return FALSE; ... if (!mh) return FALSE; We can not have ERRs all over the code where memory allocations fail, it would clutter things way too much, and for almost no use. -- Dimi.

1 0

Re: patch for grid-fitting on Solaris
by Dimitrie O. Paun Aug. 28, 2003

Aug. 28, 2003

On Thu, 28 Aug 2003 Dave_Belanger(a)cimmetry.com wrote: > Dave Belanger > Cimmetry Systems Inc. > dave.belanger(a)cimmetry.com > (514) 735-3219 (ext. 204) > ------------------------------------ > > (See attached file: patch_grid_fitting) Can you please attach the file as text/plain, or better yet, inline them in the message? It is so inconvenient to review (and reply) to your patches... Thanks. -- Dimi.

1 0