September 2003 - Wine-Devel

Installshield GetDC/ReleaseDC regression?
by Robert Reif Sept. 5, 2003

Sept. 5, 2003

Installshield for dx8.1 sdk with win98 set in config is giving this error: err:dc:DCE_FreeWindowDCE[0x10023] GetDC() without ReleaseDC! A trace is attached.

1 0

Re: commctrl.h cleanup
by Alexandre Julliard Sept. 5, 2003

Sept. 5, 2003

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > I know, it would be nice to have an intelligent utility to > cleanup the headers, but by the looks of it, it has to be > rather smart. This is probably one of the more difficult > cleanups, and I did it all by hand, which gave me a chance > to cleanup/reorganize the includes a bit. Looks like you have been reorganizing a bit too much, config.h and wine/port.h should always be included before anything else. > All other (except > for winbase.h) are *a lot* simpler. People can do them by > hand quite easily. I'm not so sure. For instance prsht.h still includes windef.h, wingdi.h and winuser.h, and since it's included from commctrl.h in fact your patch didn't actually remove these. I think there will still be a lot of changes to make, and I'd really prefer to avoid having to fix the same C files again and again. -- Alexandre Julliard julliard(a)winehq.com

3 7

Re: [dcom 1.2] Implement dispatch variant marshalling
by Mike Hearn Sept. 4, 2003

Sept. 4, 2003

On Thu, 2003-09-04 at 20:53, Dimitrie O. Paun wrote: > I'd prefer we don't have there -- they really clutter the code, > provide a bad example to follow, and provide little, if any, > benefit. What you can do is put some strategic TRACEs that would > help someone who knows the code to identify the problem. > But I wouldn't worry about memory allocation failures... Another possibility is to have a wine convenience macro, similar to the glib g_return_if_fail() macro, that works for instance: wine_return_if_fail_hr(CoDoSomethingCOMRelated()) which expands to { HRESULT hr = CoDoSomethingCOMRelated() if (hr != S_OK) { ERR("CoDoSomethingCOMRelated() failed, hr=%ld\n", hr); return hr; } or whatever..... could be convenient, but perhaps too much magic. I'll drop the ERRs then. thanks -mike

2 1

Re: [dcom 1.2] Implement dispatch variant marshalling
by Dimitrie O. Paun Sept. 4, 2003

Sept. 4, 2003

On 4 Sep 2003, Mike Hearn wrote: > I removed the use of asserts to check the results, and replaced them > with ERRs. > + working_mem = GlobalAlloc(0, size); > + if (!working_mem) { > + ERR("failed to get a global alloc\n"); > + return oldpos; > + } I don't think this is such a good idea. If the API can fail, it should just fail. ERR should be used only to signal internal inconsistencies. Doing an ERR on very memory allocation / function call that can fail is not only useless, but harmful, as it bloats and clutters the code. The above should just be: working_mem = GlobalAlloc(0, size); if (!working_mem) return oldpos; -- Dimi.

1 0

TreeView & WM_NOTIFY
by Igor Grahek Sept. 4, 2003

Sept. 4, 2003

Hi :) My problem is very similar to bug 1227 (http://bugs.winehq.org/show_bug.cgi?id=1227) Treeview in application is sending WM_NOTIFY on double click (NM_DBLCLK) to the wrong Window handle. GetParent() function returns handle to the root window and root window is not forwarding/broadcasting that message and message is lost. Everything works fine under Windows or with --dll comctl32=n Any suggestions? Igor

2 2

Re: winres.h cleanup
by jonwil＠tpg.com.au Sept. 4, 2003

Sept. 4, 2003

I dont see the reason for this change... The real version of winres.h from microsoft includes winresrc.h

3 2

Bugzilla down?
by Dustin Navea Sept. 4, 2003

Sept. 4, 2003

Hi guys, I just tried to access Bugzilla, and it isnt responding, checked with a ping and a traceroute but both gave me request timed out, although that could be because of a firewall, I just figured someone might want to know (jeremy).. ===== Dustin Navea Minor Contributor, http://www.winehq.com Bugzilla Janitor, http://bugs.winehq.com Network Admin, irc://irc.blynk.net (down) __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

2 1

Re: stdarg.h in winbase.h
by Alexandre Julliard Sept. 4, 2003

Sept. 4, 2003

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > With this patch, we can get rid of the stdarg.h > include from winbase.h if it weren't for the > FormatMessage() functions: > > DWORD WINAPI FormatMessageA(DWORD,LPCVOID,DWORD,DWORD,LPSTR,DWORD,va_list*); > DWORD WINAPI FormatMessageW(DWORD,LPCVOID,DWORD,DWORD,LPWSTR,DWORD,va_list*); > > Alexandre, how do we handle this one? We have to include stdarg.h everywhere we include winbase.h, about 650 files at last count. That's why we need some kind of script... -- Alexandre Julliard julliard(a)winehq.com

4 6

Re: wineproc: a new wine utility
by Dimitrie O. Paun Sept. 4, 2003

Sept. 4, 2003

On September 3, 2003 03:53 pm, Eric Pouech wrote: > any comment welcomed!! This is very nice (from the comments and the code)! I will compile it soon, but I was hoping Alexandre bits me to it and commits it, so I can be lazy and just to a 'cvs up' :) > (thanks to Dimi for his quick fixies on the listview control BTW) You are most welcome, thank you for spotting the problems! -- Dimi.

1 0

Re: [gethostbyname] Set appropriate error code
by Rein Klazes Sept. 3, 2003

Sept. 3, 2003

On Wed, 3 Sep 2003 18:20:56 +0200, you wrote: > Changelog: > - Set appropriate error code for gethostbyname and WSAAsyncGetHostByName > - Restore NULL name/aq->host_name to NULL at the end of each function respectively > > Stephan > > aq->host_name = buf; > if( gethostname( buf, 100) == -1) { > - fail = WSAENOBUFS; /* appropriate ? */ > + fail = (errno == EINVAL) ? WSAEFAULT : wsaErrno(); Explanation why I arrived at WSAENOBUFS as appropriate value.. (Remember it is used as the error value for the windows code calling gethostbyname(), not gethostname();) - glibc documentation as I read it indicates that in this case the only way gethostname() may fail is an insufficient bufferlength. Clearly invalid name pointer or negative length do not apply. - WSAEFAULT means (by Microsoft): "The system detected an invalid pointer address in attempting to use a pointer argument in a call" At the vary least this will confuse somebody that does gethostbyname(NULL), thinking it is the null pointer that is causing this error. This is the one error code that I did not want to return, that is why I cannot use the wsaErrno functions. But perhaps you have found another cause where gethostname() will fail? > + if (name==buf) name=NULL; > return retval; name is an argument, passed by value. Destroyed as the function returns. No need to restore. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Various fixme's and error messages with Visual FoxPro 8
by Paul McNett Sept. 3, 2003

Sept. 3, 2003

In case it may be interesting to any of the hackers here, here is a spattering of messages that get output when running Visual FoxPro 8. If this isn't of interest, please forgive the bandwidth. The NotifyWinEvent messages fill pages of output during a typical session. The keyboard: X11DRV_ToUnicode is actually a minor problem as the key combination of Shift+Tab gets eaten instead of being passed to VFP. I've tried looking at the keyboard code to see if I can fix this, but the code is way beyond my level of comprehension. This is using the latest tarball release (Wine20030813). err:win32:_EnterSysLevel (0x409ddfc0, level 2): Holding 0x40a95de0, level 3. Expect deadlock! fixme:hook:NotifyWinEvent (32773,0x10044,1,8)-stub! err:clipboard:X11DRV_CLIPBOARD_QueryAvailableData Failed to cache text/plain;charset=utf-8 property err:keyboard:X11DRV_ToUnicode Please report: no char for keysym FE20 (ISO_Left_Tab) : err:keyboard:X11DRV_ToUnicode (virtKey=9,scanCode=F,keycode=17,state=1) -- Paul McNett

1 0

Re: listview expert required (again)
by Dimitrie O. Paun Sept. 3, 2003

Sept. 3, 2003

OK, Please give this a try -- it should fix it. Index: dlls/comctl32/listview.c =================================================================== RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.360 diff -u -r1.360 listview.c --- dlls/comctl32/listview.c 1 Sep 2003 23:55:33 -0000 1.360 +++ dlls/comctl32/listview.c 3 Sep 2003 15:32:36 -0000 @@ -5939,6 +5939,9 @@ if (nItem == -1) goto fail; infoPtr->nItemCount++; + /* shift indices first so they don't get tangled */ + LISTVIEW_ShiftIndices(infoPtr, nItem, 1); + /* set the item attributes */ if (lpLVItem->mask & (LVIF_GROUPID|LVIF_COLUMNS)) { @@ -5979,11 +5982,6 @@ } } - /* Add the subitem list to the items array. Do this last in case we go to - * fail during the above. - */ - LISTVIEW_ShiftIndices(infoPtr, nItem, 1); - /* send LVN_INSERTITEM notification */ ZeroMemory(&nmlv, sizeof(NMLISTVIEW)); nmlv.iItem = nItem; @@ -6008,6 +6006,7 @@ return nItem; undo: + LISTVIEW_ShiftIndices(infoPtr, nItem, -1); DPA_DeletePtr(infoPtr->hdpaItems, nItem); infoPtr->nItemCount--; fail: -- Dimi.

2 1

BUG in IPersistFile::Load() since Wine-20030618 !
by Subhobroto Sinha Sept. 3, 2003

Sept. 3, 2003

This is a followup of my earlied post. Recap: I was porting my program which resolved Windows shortcut files (.lnk) using WineLib (Please note that this program runs flawlessly on Windows). It used to work fine till I updated my Wine source from 20030408 to 20030813. I posted this report here and Dimitrie suggested that I do a CVS Regression test to locate the error... Now, I really could NOT do a CVS regression test as I lack the bandwidth (you know, a 28KBps modem ..), but I started afresh with the Wine-20030408 source tree and "patch-compile-tested" to version 20030618. Then I found out that from this release onwards IPersistFile::Load() had become BROKEN ! Hence I have reason to believe that ANY code which modified/touched directly/indirectly IPersistFile::Load() and made it's way into Wine-20030618.diff.gz is AT FAULT ;) And that code needs to be FIXED. So ALL Wine releases prior to 20030618 can sucessfully run my program(or for that matter, ANY program that calls IPersistFile::Load()) , and ANY Wine release after 20030618 will fail ANY application that calls IPersistFile::Load() ! Just to show that not just my program is at fault, you can also try running Mike McCormack's WineMenuBuilder which also resolves Windows shortcuts... Until IPersistFile::Load() got broken, on running my program this is the ONLY message I used to get : "fixme:shell:IShellLinkA_fnResolve (0x4039da98)->(hwnd=(nil) flags=3)" The attached file "WineTraceLog.zip"<MD5 Sum: 278b4c4a44cc445b6c0e0d8863a790cf> contains the pertinent extract of the trace log when I run my program, please go through it to see what really is happenning. (While going through this extract you can see that the shortcut has been resolves sucessfully, but yet IPersistFile::Load() returns a failure ??) I hope this gets fixed allright ;) Please let me know if I can help in any way (EXCEPT learning COM!)... Regards Subhobroto Sinha __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

1 0

Wanted to learn Wine Completely
by Sukumar .S Sept. 3, 2003

Sept. 3, 2003

Dear Developers, I'm sukumar from Chennai, India. I've one requirement for my company for which there is a need to understand wine source fully (there is a time constraint). i was a windows developer moved to Linux two years back and have good/bit of knowledge on win32 system programming (win32 api calls)..! Me myself belive that i'm good in win32 common controls (each control (i.e listview,treeview,static,edit) message hanlding) and in windows message hooking. so far i've downloaded the wine source (Wine version 20020710) and compiled it and able to run the required target applications. I've gone through the documentations (wine-{devel,user,faq}), DEVELOPER-HINTS and navigated through src tree (controls,windows) to get the feel of the file names (api calls) and to look at the coding conventions. I'm looking forward from all of you to guide/help me to start learning/understanding wine starting from running the target application to exiting the application. To start with which part of the code that i've to read in wine and how do i proceed further...? Please help me. With Regards, S. Sukumar --

3 2

listview expert required (again)
by Eric Pouech Sept. 2, 2003

Sept. 2, 2003

another bug description for listview (native listview works as expected here) configuration : - a listview in autoarrange mode - adding item one after the other - say the first item is created with the selection (LVIS_SELECTED) - some more items are inserted without the selection - in some cases, the selection will move to the newly inserted item instead of remaining on the first item (likely some internal index is not recalculated in autoarrange mode) A+ -- Eric Pouech

3 5

shlobj.h [final version]
by Martin Fuchs Sept. 2, 2003

Sept. 2, 2003

On 02.09.2003 22:33:07 Martin Fuchs wrote: On 02.09.2003 22:07:16 Alexandre Julliard wrote: > Martin Fuchs <martin-fuchs(a)gmx.net> writes: > > > Changelog: > > * define interface IDragSourceHelper > > * define interface IDropTargetHelper > > They are already defined in wine/obj_dragdrophelper.h (fortunately > your definitions are in a #if _WIN32_IE so they are not used, > otherwise you would get a compile error ;-) Well, then there may be missing a '#include "wine/obj_dragdrophelper.h"' in shlobj.h ? Unfortunatelly I can't make any further Wine patches for the next time, because my internet access in Linux has died. ;-( Martin

1 0

Re: misc fixes in ole code
by Alexandre Julliard Sept. 2, 2003

Sept. 2, 2003

Dave_Belanger(a)cimmetry.com writes: > 3. Call GetFullPathNameW on the input path before calling CreateFileW > in StgCreateDocfile and StgOpenStorage to ensure that CreateFileW > gets a DOS-style path. This shouldn't be necessary, CreateFileW is supposed to work on Unix path names too. I suspect this is a work around for an old bug that has been fixed since, could you please confirm that? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: shlobj.h [final version]
by Alexandre Julliard Sept. 2, 2003

Sept. 2, 2003

Martin Fuchs <martin-fuchs(a)gmx.net> writes: > Changelog: > * define interface IDragSourceHelper > * define interface IDropTargetHelper They are already defined in wine/obj_dragdrophelper.h (fortunately your definitions are in a #if _WIN32_IE so they are not used, otherwise you would get a compile error ;-) -- Alexandre Julliard julliard(a)winehq.com

1 0

Resource .ani support
by flyker Sept. 2, 2003

Sept. 2, 2003

resource.rc : ... /* for Modern Wait Cursor support */ IDC_CLOCK1 CURSOR "waitphar.ani" ... wrc error: Oops, segment violation When WineLib will support this ?

2 1

could someone please stabilise the list server?
by Geoff Thorpe Sept. 2, 2003

Sept. 2, 2003

Hi there, I have filters for all the wine mail lists keyed against the List-Id header and this has been serving me well up until the last couple of days. However ... It seems that some of the lists now generate their headers with the winehq.org domain instead of winehq.com, but it seems (at least) wine-cvs is still using winehq.com. Could someone please standardise on what this is going to be? I don't particularly mind what it is, but it would help if it was consistent across all the lists and didn't change without warning. Cheers, Geoff -- Geoff Thorpe geoff(a)geoffthorpe.net http://www.geoffthorpe.net/

1 0

Ooops... wine-tests-results@winehq.org
by Jakob Eriksson Sept. 2, 2003

Sept. 2, 2003

I forwarded the tests I have received so far to wine-tests-results(a)winehq.org, but at the time I was not yet subscribed... so it says they are awaiting moderation. Is anyone moderating that particular list? regards, Jakob

2 1

x11drv/INS versions in sample config
by Tom Sept. 2, 2003

Sept. 2, 2003

Hello, would adding _ins0166._mp, _ins0366._mp, _ins0433._mp, _ins5501._mp, _ins5567._mp, _ins5577._mp to /documentation/samples/config be productive? Marcus can you share your thoughts on this? Tom

2 1

Re: [ANN] Conformance testing campaign
by Vincent Béron Sept. 2, 2003

Sept. 2, 2003

Le mar 02/09/2003 à 13:19, Ferenc Wagner a écrit : > Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > > >> 1. Native build tests. As a first step, I provide a > >> collection of source/project/desktop files which I think > >> are necessary for an MSVC build. Could somebody test it > >> for me? (Get from http://afavant.elte.hu/~wferi/wine) > > > > Are those generated with tools/winapi/msvcmaker? > > Yes, those, plus the referenced source files. > > >> 2. A simple batch file could be provided to zip up the > >> results, if I knew how to use which compression program. > >> Eg. (win)zip can not be found on the XP I have access to. > >> Should I include one in the archive? Or as a separate > >> link? Ideas? Anybody? > > > > A small program using lz32 APIs maybe? > > Sounds possible, thanks. But why did you take if off the > list? Simple error on my part: "Reply" instead of "Reply to all" or "to list". I noticed before your answer, but didn't felt like just sending it to the list after. Vincent

1 0

Mailing list for tests
by Jakob Eriksson Sept. 2, 2003

Sept. 2, 2003

So, is there a mailing list I can direct the test results to? Somebody was going to create it... regards, Jakob

2 1

Conformance tests
by Ferenc Wagner Sept. 2, 2003

Sept. 2, 2003

Hello, recent discussion on the list ignited my interest again. Francois has a very nice page <http://fgouget.free.fr/wine/tests-en.shtml>, let's try to make better use of it! 1. The precompiled binaries offered here would mean a great help, were they updated regularly. 2. Maybe better, a framework could be developed which would run all the tests, pack the results up and send it back to Francois for easy integration into his page. 3. The table on the page is too big for convenient use. I do not know about much structure to see; maybe a table is not even needed. Just version, date of test, if it is up to date with the binaries on the page, and a list of failing tests as links to the error messages would be enough. If it is not, we can still embed it into the giant API database at http://24.229.94.2 (why is it not linked from WineHQ?) and have a general SQL interface! :) Hmm, some diffing capabilities might be useful indeed... 4. We could recruit people with access to the different platforms and send them mails asking for a rerun whenever the new tests are compiled. Or advertise it on the devel list only... What do you think? I am even willing to do some of the above, except for the build, as I have no constant access to Windows machines. Feri.

7 24