September 2003 - Wine-Devel

Re: Uninstaller crashed on Windows 2000
by Eric Pouech Sept. 24, 2003

Sept. 24, 2003

Pavel Roskin wrote: > Hello! > > HeapReAlloc() would crash on Windows 2000 is the original pointer is NULL. > This causes the Andreas Mohr's uninstaller to crash. there's lot of code which relies on HeapReAlloc would allocate a block if the block to reallocate is NULL (as realloc does in stdlib). this is not the case in windows, and we should fix it (and first, fix all the wine code relying on this) Dimi, may be something to add to the Janitorial list... Maybe, we could also keep a least of the most common traps in win32 API for unix programmers... A+ -- Eric Pouech

2 2

Re: Window style for winhelp not initialized
by Steven Edwards Sept. 24, 2003

Sept. 24, 2003

Hello Pavel, While you are looking at running the WINE programs under Windows can you take a look at the uninstaller program? When I build this program with Mingw or MS_VC and try to run it under Windows it crashes. It seems somehow it has a problem loading the registry entries in the uninstall key. If you run uninstaller on a clean Windows 2000 system it will function without crashing but as soon as data is in that registry branch it crashes. Thanks Steven --- Pavel Roskin <proski(a)gnu.org> wrote: > Hello! > > The style of the main winhelp window in not initialized. As a > result, the > main window has no buttons on it (both in Wine and Windows 2000). > The > patch sets win_style to WS_OVERLAPPEDWINDOW. Popup windows are not > affected. > > ChangeLog: > programs/winhelp/winhelp.c: > Initialize style of the main window to WS_OVERLAPPEDWINDOW. > > -- > Regards, > Pavel Roskin> --- programs/winhelp/winhelp.c > +++ programs/winhelp/winhelp.c > @@ -115,6 +115,7 @@ HLPFILE_WINDOWINFO* WINHELP_GetWindo > strcpy(mwi.caption, hlpfile->lpszTitle); > mwi.origin.x = mwi.origin.y = mwi.size.cx = mwi.size.cy = > CW_USEDEFAULT; > mwi.style = SW_SHOW; > + mwi.win_style = WS_OVERLAPPEDWINDOW; > mwi.sr_color = mwi.sr_color = 0xFFFFFF; > } > return &mwi; > __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

2 1

Re: interactive dsound tests fail && winealsa problem
by wine＠frotz.org Sept. 24, 2003

Sept. 24, 2003

> I'm trying to improve winealsa's sound quality, and I have found a way. And > I think I should make some checks in configure which I am totally unaware > of. If everything go smooth, the patch will be sent out within several days. A few weeks back, I got fed up with the winealsa driver not working with my app (and the OSS driver wasn't working for me at the time either), so I gutted it and rolled my own using the DMIX plugin. PCM output is about 80% complete ATM. All that's left to do there is one-shot buffers, hook up volume/panning control, and do some tidying up of the code. And then there's the input side.... I was planning to submit it as a separate driver, since its architecture differs significantly from the existing one. The main differences are: support for "hardware" secondary buffers with ALSA, not Wine, doing the mixing; and the use of the DMIX plugin, which hopefully will allow it to play friendly with other DMIX-aware linux apps (e.g. mplayer, etc.). So, what I'm wondering now is: 1) Should I bother finishing it? OSS is working fine for me again, and if someone else is going to fix the existing ALSA driver...., and 2) if the answer to question 1 is 'yes', then what is the proper protocol for submitting such a substantial code change. IMO a separate driver would be less destabilizing (don't run it if you don't want to!), but a little confusing (two ALSA drivers?).

5 4

Re: console test / even the smallest patch can be wrong
by Ivan Leo Murray-Smith Sept. 24, 2003

Sept. 24, 2003

> since 0 is a wrong console handle (in this case), we don't care about > actual c value. But this causes a problem with winetests.exe, on win2k3 when running the tests, I get a msg box saying Microsoft Visual C++ debug library Debug Error! Program: C:\(Location of kernel32_tests here) Module: C:\(Location of kernel32_tests here) File: Run Time check Failure #3 - The variable "c" is being used without being defined. (Press retry to debug the application) As a result of clicking on retry, the tests just continue normally (Still running while I'm writing this).

1 0

Re: interactive dsound tests fail && winealsa problem
by Jerry Jenkins Sept. 24, 2003

Sept. 24, 2003

> So, what I'm wondering now is: 1) Should I bother finishing it? OSS is > working fine for me again, and if someone else is going to fix the existing ALSA > driver...., and 2) if the answer to question 1 is 'yes', then what is the proper > protocol for submitting such a substantial code change. IMO a separate driver > would be less destabilizing (don't run it if you don't want to!), but a little > confusing (two ALSA drivers?). My patch will depend on alsa driver highly. Just a little change to the alsa APIs will make my patch don't work any more. That's also the reason why I want to do some checks. So I think that people (at least me) would be glad to have another choice ... if you do have some time:-). Maybe there are some more smart opinions.

1 0

Re: interactive dsound tests fail && winealsa problem
by Jerry Jenkins Sept. 24, 2003

Sept. 24, 2003

Sylvain Petreolle wrote: > Using latest CVS : > > Enabling dsound interactive tests with WINETEST_INTERACTIVE, > I get many errors like this one, always the same : > > dsound.c:1223: Test failed: MsgWaitForMultipleObjects failed: 0x102 > dsound.c: 42774 tests executed, 0 marked as todo, 80 failures. > > Im using wineoss with OSS compatibility to do these tests. > Kernel : 2.4.20-20.9 > > Using winealsa, the sound produced during the test is awful, full of > noise. I'm trying to improve winealsa's sound quality, and I have found a way. And I think I should make some checks in configure which I am totally unaware of. If everything go smooth, the patch will be sent out within several days. > I get only failed tests due to E_NOTIMPL errors like > > dsound.c:149: Test failed: Lock: 0x80004001

1 0

Re: huge download in cvs-regression.sgml
by Dimitrie O. Paun Sept. 24, 2003

Sept. 24, 2003

On September 23, 2003 01:18 pm, Richard Cohen wrote: > On dialup, the download will take 2 1/2 hrs - it is hard to see a > succession of little trips to cvs.winehq adding up to anything like > that. On broadband the situation is proportionally better, of course, > but is the cvs server really so overloaded ? > > Unless anyone objects, I'll submit a patch removing this suggestion to > make a huge download. Actually, it would be best to add a description on how to setup a local copy of the repository through cvsup, that helps a lot. We don't have it anywhere in the docs (I've sent an email some time ago describing my setup), and it seems rather relevant to this section. -- Dimi.

1 0

Re: CreateBitmap fails
by Jerry Jenkins Sept. 24, 2003

Sept. 24, 2003

> Thanks Jerry, > > your second patch solved the bug 1715 against Wine-20030911. There are still > lots of errorr messages: > err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=4 Maybe there is the same problem. Could you tell me the name of the application you are trying to run? > > but these seem harmless. > > Jarkko Lavinen >

1 0

Re: wine-devel digest, Vol 1 #2212 - 10 msgs
by Jerry Jenkins Sept. 24, 2003

Sept. 24, 2003

> Thanks Jerry, > > your second patch solved the bug 1715 against Wine-20030911. There are still > lots of errorr messages: > err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=4 Maybe there is the same problem. Could you tell me the name of the application you are trying to run? > > but these seem harmless. > > Jarkko Lavinen >

1 0

New winetests.exe
by Jakob Eriksson Sept. 24, 2003

Sept. 24, 2003

Ok people, new version. This time the tests (but not timetests.exe) are compiled with MSVC 7 instead of crosscompiled. (No agenda behind that decision - it's just that current CVS is broken when it comes to crosstest.) http://vmlinux.org/jakov/Wine/

1 0