January 2004 - Wine-Devel - list.winehq.org

Re: WWN Links are busted
by Brian Vincent (C) Jan. 13, 2004

Jan. 13, 2004

> the current link is: > <a > href="?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited">#154</a> </td> I think it should be: href="/?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited" sed -e "s/href=\"\?/href=\"\/\?/g" --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

Re: shell32 patches to be usable by ReactOS Explorer
by Alexandre Julliard Jan. 13, 2004

Jan. 13, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > This was no joke. If you say, you would accept such as reformating patch, > I can easyly create one that eliminates all tab-characters, and generates > nice and uniform indented code. > This will make it a bit easier to create the small self-contained patches > you want to see instead of the big one. As additional bonus you will get > a very better formated shell32 code base. There's no reason to reformat all of shell32. If a given function is messed up you can fix it (in a separate patch), but otherwise it doesn't really matter if all functions don't use the exact same style. -- Alexandre Julliard julliard(a)winehq.com

2 1

stray file
by Hans Leidekker Jan. 13, 2004

Jan. 13, 2004

Hi, There's a stray file, dlls/checklink.c, in Wine CVS with these contents: int main(void) { return 0; } It must be a leftover from a configure run. I suspected my own tree but but it came back after I removed it and did a cvs update. -Hans

4 4

Re: uxtheme: lots of infrastructure
by Alexandre Julliard Jan. 13, 2004

Jan. 13, 2004

Kevin Koltzau <kevin(a)plop.org> writes: > This is a ton of infrastructure for my future patches, and a full > implementation of GetThemeDocumentationProperty which I primarilly > used to test my INI file processing, and its now possible to set the > current theme through the API..not that its much use to do that yet The part about storing the string maps as resources seems unnecessarily complicated and inefficient. Why can't you store an array directly in the code? -- Alexandre Julliard julliard(a)winehq.com

2 4

[Janitorial] Remove CopyMetaFileW->A call
by Vincent Béron Jan. 13, 2004

Jan. 13, 2004

Indentation in CopyMetaFileW is a bit inconsistent (there are some tabs which I left since I didn't touch those lines). Should I redo my patch to get rid of them (adds some noise to the patch), keep them in a separate patch (limited to this very function) or leave it as is? Also, should I change MF_CreateMetaHeaderDisk to accept a LPCWSTR, even though it then needs to convert it back to Ascii, or is the proposed way sufficient? Changelog: Removed a W->A cross-call (CopyMetaFileW->CopyMetaFileA). Vincent

1 0

Re: Implemention of LockWindowUpdate
by Mike Hearn Jan. 13, 2004

Jan. 13, 2004

On Tue, 13 Jan 2004 00:10:20 +0000, Mike Hearn wrote: > This patch makes the halflife menu screen look a bit better, with less > flashing. Unfortunately it also makes it feel a bit slower, but I think > that's just an optical illusion caused by less screen activity. The > bottleneck is elsewhere. Just had a hunch, and yes, switching off XRender and antialiasing speeds things up nicely. I guess I should yell at keithp or something.... :)

1 0

Re: wine/ windows/scroll.c include/user.h dlls/x11 ...
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On Mon, 12 Jan 2004, Alexandre Julliard wrote: > Log message: > ScrollDC doesn't need to be in the graphics driver. Yay! (I submitted a similar patch some time ago, but you didn't like the {Start,End}GraphicsExposures functions. I still think they are decent GUI abstractions :)): http://www.winehq.com/hypermail/wine-patches/2002/09/0196.html Speaking of these things, I also don't think the driver should know about the caret. I see no need for the USER driver to know anything about the caret, we can just always implement it ourselves, no? http://www.winehq.com/hypermail/wine-patches/2002/09/0174.html I think there is a bug in the above patch (IIRC, I used to get some freezing in certain situations), but the idea still stands. -- Dimi.

2 1

Re: [WINEALSA] Add Midi IN support (take 3)
by Alexandre Julliard Jan. 12, 2004

Jan. 12, 2004

Christian Costa <titan.costa(a)wanadoo.fr> writes: > +static int npfd; > +static int pfd_array_size = 0; > +static struct pollfd *pfd = NULL; This isn't thread-safe. Why don't you simply allocate the array in the function and free it when you are done? -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: shell32 patches to be usable by ReactOS Explorer
by Martin Fuchs Jan. 12, 2004

Jan. 12, 2004

On 12.01.2004 01:41:45 Alexandre Julliard wrote: > "Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > > > Mhh - could you please tell me which "ugly hacks" you are speaking of? > > From a quick look at the patch, what I noticed is mostly the ifdefs > and other various disabling/commenting out of parts of the code. We had to disable some calls to internal functions, which are only exported from WINE, no real Windows OS. > There are also a number of unneeded whitespace changes that make the > patch larger than it should be. Yes, I tried to make some functions I had to alter a bit more readable. What about running a pretty printer, for example astyle (http://astyle.sourceforge.net/) on the whole code (or at least the shell32 directory) ? Some sections are currently indented with 2, some with 4 and some with 8 spaces - even mixed in the same function. Regards, Martin

1 1

Re: [Janitorial] ResetDCA->ResetDCW
by Dmitry Timoshkov Jan. 12, 2004

Jan. 12, 2004

"Vincent Beron" <vberon(a)mecano.gme.usherb.ca> wrote: > Changelog: > Get rid of a W->A crosscall (ResetDCA->ResetDCW). > -HDC WINAPI ResetDCW( HDC hdc, const DEVMODEW *devmode ) > +HDC WINAPI ResetDCA( HDC hdc, const DEVMODEA *devmode ) > { > - return ResetDCA(hdc, (const DEVMODEA*)devmode); /* FIXME */ > + DEVMODEW *devmodeW; > + HDC ret; > + > + if (devmode) devmodeW = GdiConvertToDevmodeW(devmode); > + else devmodeW = NULL; > + > + ret = ResetDCW(hdc, (const DEVMODEW*)devmode); It would be better to pass a real, newly allocated DEVMODEW* to ResetDCW(). That way you shouldn't need to cast type of a pointer. -- Dmitry.

2 1

Re: #2 - Mdi Win16/32 Split
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On January 2, 2004 10:31 am, Steven Edwards wrote: > Split up the Win16/32 MDI support a bit. Any idea what the status of the Win16/32 split is? What DLLs are still not properly split? -- Dimi.

4 11

Re: shell32 patches to be usable by ReactOS Explorer
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On January 11, 2004 08:04 am, Martin Fuchs wrote: > This patch consists of a number of changes we implemented in the ReactOS > CVS tree in order to use Wine's shell32.dll implementation for ReactOS > explorer. Please see the following changelog lists for the individual patch > descriptions: Martin, sending a bunch of patches compressed and in one message, makes them almost unreviewable but by the most die hards readers of wine-patches. It also makes it so much more difficult for Alexandre to split them up, match the ChangeLog, review them, etc. Please stick to one-(uncompressed, inlined)-patch-per-email-messsage rule, it's so much better for everybody. Here are some relevant links: http://www.winehq.org/site/sending_patches http://www.winehq.org/site/docs/wine-devel/patches -- Dimi.

4 6

Re: [Janitorial] ResetDCA->ResetDCW
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On January 11, 2004 03:43 pm, Vincent Béron wrote: > Dimi, do you prefer to keep track of progress on this yourself, or > should I send a patch for the janitorial page too? It would be great if you'd send the update to the janitorial page. I try to keep track, but it's so much easier if patch authors lend a hand. But please wait until Alexandre commits it. -- Dimi.

1 0

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)
by Ivan Leo Murray-Smith Jan. 11, 2004

Jan. 11, 2004

> With this change, we can use the 6.3 version of Quicktime > to see streamed video from Wineconf... This would break Grand Prix Legends and Nascar 2002 (Thats why the patch was written in the first place), maybe you should contact the author of the patch, a proper fix would be better, why should we chose between 2 games and quicktime? It should be possible to run all these apps. Ivan.

4 4

Re: [WINEALSA] Add Midi IN support (w/o alloca)
by Eric Pouech Jan. 11, 2004

Jan. 11, 2004

Christian Costa a écrit : > + for (wDevID = 0; wDevID < MIDM_NumDevs; wDevID++) > + if ( (ev->source.client == MidiInDev[wDevID].addr.client) && (ev->source.client == MidiInDev[wDevID].addr.client) ) > + break; Why do you do twice the same test ? A+

2 1

exception outside of stack limits
by Robert Lunnon Jan. 11, 2004

Jan. 11, 2004

There is a warning in signal_i368.c WARN( "exception outside of stack limits in thread %04lx eip %08lx esp %08lx stack %p-%p\n", GetCurrentThreadId(), EIP_sig(sigcontext), Can anyone tell me what this "means" in terms of what would have to go wrong to generate this warning ??

2 2

Correction to wineps spec file
by Vincent Béron Jan. 11, 2004

Jan. 11, 2004

Changelog: CreateDC in wineps is Unicode now, change the spec file accordingly. Vincent

1 0

Re: [WINEALSA] Add Midi IN support
by Alexandre Julliard Jan. 11, 2004

Jan. 11, 2004

Christian Costa <titan.costa(a)wanadoo.fr> writes: > + int npfd; > + struct pollfd *pfd; > + > + npfd = snd_seq_poll_descriptors_count(midiSeq, POLLIN); > + pfd = (struct pollfd *)alloca(npfd * sizeof(struct pollfd)); You should not use alloca in Wine, it's not portable enough. -- Alexandre Julliard julliard(a)winehq.com

4 3

Direct3D8 - OpenGL header problem
by Thomas Brix Larsen Jan. 11, 2004

Jan. 11, 2004

Hi list, just upgraded to 2.6.0 and the NVIDIA driver from minion.de and now I get this error when compiling wine: directx.c: In function `IDirect3D8Impl_GetDeviceCaps': directx.c:639: `GL_MAX_VERTEX_UNITS_ARB' undeclared (first use in this function) My X11/include/GL/ headers date, 2001-2002. Greetings, --Thomas _________________ My worst enemy gave me a copy of Windows...

3 2

Re: shell32 patches to be usable by ReactOS Explorer
by Martin Fuchs Jan. 11, 2004

Jan. 11, 2004

Sorry, I forgot to include the new file "shlcpanel.c" into the shell32 patch mail. Changelog: - Implementation of control panel folder in shgell namespace -- Martin Fuchs martin-fuchs(a)gmx.net

1 0

Build fails for current CVS update
by Sami Aario Jan. 11, 2004

Jan. 11, 2004

Hi, Building with tools/wineinstall fails with the latest CVS update on my system with the following: gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINE SRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-stri ct-aliasing -gstabs+ -Wpointer-arith -g -O2 -o ddraw.spec.o ddraw.spec.c {standard input}: Assembler messages: {standard input}:654: Error: no such instruction: `yes "ddraw.dll"' {standard input}:655: Error: no such instruction: `yes "DDHAL32_VidMemAlloc"' {standard input}:656: Error: no such instruction: `yes "DDHAL32_VidMemFree"' {standard input}:657: Error: no such instruction: `yes "DDInternalLock"' and so on, lots more of the same. Anyone else getting these?

3 4

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)
by Mike Hearn Jan. 11, 2004

Jan. 11, 2004

That looks familiar. In fact, the TRACE was originally a FIXME but it caused so much spew with so many apps I changed it. I couldn't see exactly what needed to be fixed given the contents of the message - it seems to be simply informing us of progress, but it's a possibility somebody knew this wasn't correct. On Sat, 10 Jan 2004 17:09:52 -0600, Jeremy White wrote: > Index: dlls/winsock/socket.c > =================================================================== > RCS file: /home/wine/wine/dlls/winsock/socket.c,v > retrieving revision 1.144 > diff -u -r1.144 socket.c > --- dlls/winsock/socket.c 2 Jan 2004 20:12:00 -0000 1.144 > +++ dlls/winsock/socket.c 10 Jan 2004 22:56:57 -0000 > @@ -1302,10 +1302,6 @@ > else > { > int on = 1; > - /* The game GrandPrixLegends binds more than one time, > but does > - * not do a SO_REUSEADDR - Stevens says this is ok */ > - TRACE( "Setting WS_SO_REUSEADDR on socket before we > bind it\n"); > - WS_setsockopt( s, WS_SOL_SOCKET, WS_SO_REUSEADDR, > (char*)&on, sizeof(on) ); > > if (bind(fd, uaddr, uaddrlen) < 0) > {

2 1

bogus patch to bind() dlls/winsock/socket.c (request removal)
by Jeremy Shaw Jan. 10, 2004

Jan. 10, 2004

As a result of this patch (which is currently applied in cvs head): http://www.winehq.com/hypermail/wine-patches/2002/12/0009.html WS_bind() currently does this before every call to bind(): WS_setsockopt( s, WS_SOL_SOCKET, WS_SO_REUSEADDR, (char*)&on, sizeof(on) ); Basically, it sets SO_REUSEADDR for every call to WS_bind(). I can't imagine this is the correct thing to do. According to MSDN, bind() should fail unless the program has explicitly set SO_REUSEADDR. See Error code WSAEADDRINUSE at: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/wi… I found that this patch causes major problems with the xten sipphone client. The xten client does not explicitly set SO_REUSEADDR and depends on bind() failing if it tries to bind to the same local address/port twice. When the sipphone client needs a socket, it starts at port 8000, and calls bind() on successive ports until bind() returns success. So normally, if the program is already using port 8000, then bind() will fail and will try port 8001. However, with the above patch in place, bind() always works. So then the sipphone client will be using port 8000 twice, which the program is not designed to handle. If I remove the call to WS_setsockopt(), the xten sipphone client works correctly. I am proposing that the portion of the patch applied to WS_bind() be removed unless someone has a convincing arguement that the patch is actually valid. Jeremy Shaw.

2 1

WWN broken
by Brian Vincent (C) Jan. 10, 2004

Jan. 10, 2004

> We scan the XMl with tidy before posting. What is odd is that tidy > reports the XML is valid, but yet PHP's XML parser barfs on it. Whatever > the case, I just patched it, so it should be fixed online soon. Whoops. Sorry about that. I was running out the door when I put it up. I did run it through tidy, but tidy kind of sucks. The only way to really catch things is to run it through xmllint. But xmllint has a terrible interface for finding malformed problems.. hence tidy. Thanks for fixing that. Also, if anyone is bored and wants to do something easy, it might be nice to change all references in the WWN issues from winehq.com to winehq.org. I've just recently switched over to trying to be consistent on the .org thing. There's about 200 issues that could be run through sed. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

2 1

Re: dsound global variable use reduction
by Eric Pouech Jan. 10, 2004

Jan. 10, 2004

Robert Reif a écrit : > Reduce the use of the dsound global variable by > passing address to functions. This is in preparation > of supporting multiple DirectSound devices. We can't > remove all uses because an mmtimer callback can be > called even after the timer is killed. Windows has an > mmtimer flag that prevents this but wine doesn't > implement it. Could you be more specific on this one ? timeKillEvent is not 100% thread safe (I'll send a patch later on), but timeKillEvent in Wine is always synchronous (ie the killer is killed when timeKillEvent returns).

2 3