January 2004 - Wine-Devel - list.winehq.org

warning to "wine on cygwin" experimenters
by Anonymous Jan. 23, 2004

Jan. 23, 2004

I got cygwin to compile wine to the point where wine-install tried to run regedit on winedefault.reg. I should have been paying closer attention. The good news is that the wine regedit.exe works like a charm. The bad news is that it overwrote my actual windows registry with the bunk values in winedefault.reg. Not gonna be very easy to roll back. So... WATCH OUT! That last step's a doozy.

2 1

Re: WWN#206
by Rein Klazes Jan. 23, 2004

Jan. 23, 2004

Hi, > Mike wondered why the end of 1998 seemed so productive. > Rein felt two factors might have had a hand it: in October > CVS mistakenly reported the same commit more than once, > however at time Corel was actively working on Wine and > there geniunely were a lot of commits. > > Note - this graph does not reflect the size of the Wine > source code. It's only the commits. Anyone want to produce > a graph of how much has been added? I think it would be > interesting to see the trend. You can find it here: http://home.wanadoo.nl/~wijn/wine/cvssize.png Notes: - All files in the cvs wine tree are included, not just the sources. - I excluded the (libs/)unicode directory. That is almost 5 MByte of mostly generated source files creating an ugly step in an otherwise smooth curve. - The trend quite accurately represents the growth in the first 3 years. The last 2 years the rate of growth is clearly increasing. - The number of cvs commits in October '98 was corrected to 258 commits. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

RE: shlwapi prototype fixes
by Ge van Geldorp Jan. 23, 2004

Jan. 23, 2004

> From: Robert Shearman > > > MLLoadLibrary was recently documented by Microsoft. > > My changes makes it conform to the now-documented prototype > > so I don't see what's wrong with it? > > Either it is different on Windows XP (my system is Windows > 2000 SP4 with IE6 SP1), or they just got it wrong. The fact > remains that I have seen an application working perfectly > well on Wine whilst using this function as it stands. Yes, you're right. Ordinals 377 and 378 (MLLoadLibraryA/MLLoadLibraryW) in both the Win2k and WinXP shlwapi.dll pop 12 bytes from the stack on return. I'll resubmit my patch for the other prototypes. Gé van Geldorp.

1 0

RE: comctl32 resources / shlwapi prototype fixes
by Robert Shearman Jan. 23, 2004

Jan. 23, 2004

> Changelog: > Sync with ReactOS 0.2 > Fix various function prototypes to conform to PSDK > > Index: dlls/shlwapi/ordinal.c > =================================================================== > RCS file: /home/wine/wine/dlls/shlwapi/ordinal.c,v > retrieving revision 1.75 > diff -u -r1.75 ordinal.c > --- dlls/shlwapi/ordinal.c 1 Oct 2003 03:10:42 -0000 1.75 > +++ dlls/shlwapi/ordinal.c 22 Jan 2004 23:41:41 -0000 > @@ -3414,7 +3414,8 @@ > * Success: A handle to the loaded module > * Failure: A NULL handle. > */ > -HMODULE WINAPI MLLoadLibraryA(LPCSTR new_mod, HMODULE inst_hwnd, > DWORD dwFlags) > +HMODULE WINAPI MLLoadLibraryA(LPCSTR new_mod, HANDLE inst_hwnd, > DWORD dwFlags, > + LPCSTR component, BOOL cross_code_page) This is wrong. Please resubmit without this change until we can discover why the prototype has 5 parameters, yet on my system the implementation only takes 3. > { > /* FIXME: Native appears to do DPA_Create and a DPA_InsertPtr for > * each call here. > @@ -3453,7 +3454,8 @@ > * > * Unicode version of MLLoadLibraryA. > */ > -HMODULE WINAPI MLLoadLibraryW(LPCWSTR new_mod, HMODULE > inst_hwnd, DWORD dwFlags) > +HMODULE WINAPI MLLoadLibraryW(LPCWSTR new_mod, HANDLE inst_hwnd, > DWORD dwFlags, > + LPCWSTR component, BOOL cross_code_page) Same again > { > WCHAR mod_path[2*MAX_PATH]; > LPWSTR ptr;

1 0

RFC on our new initiative
by Jeremy Newman Jan. 23, 2004

Jan. 23, 2004

>From the desk of Jeremy White (who is at LinuxWorld ATM). Hey folks, We've just launched a major new initiative, the CodeWeavers CrossOver Compatibility Center. You can check it out at http://www.codeweavers.com/site/compatibility/ but I think it's fair to describe it as the appdb on steroids. I wanted to announce it here to give folks a sense of what we're up to, and to apologize a bit in advance for stepping on the toes of folks that have been doing good work within the appdb. However, the #1 problem we have had over the past year or so is how to handle all the many, many requests we get for applications not on our 'supported' list. We've basically ended up sending people away, which has been pretty unsatisfying. Further, we haven't had any good way of determining what our priorities should be; we follow major paying clients, but beyond that, we mostly just follow our gut hunches in establishing priorities. We hope to end that; this new center lets our customers vote for apps, and lets non customers make pledges. We can hopefully follow those pledges to get apps running (and we'd probably be open to having wine hackers committing to support apps in exchange for a piece of the pledges, but we haven't gotten there yet). We've also, we hope, set the stage for a major new Wine related initiative - we hope to encourage lots of ISVs to certify their apps against Wine. The rationale for this is pretty simple - apps won't run on Wine as well as they do on Windows until developers start testing against Wine. They've got to start somewhere - we're trying to give them that beginning. We're obviously also hoping that this will help us to continue funding the work we've been able to do on Wine so far. As much of a struggle as it's been at times, we really feel lucky that we've been able to do so much. We hope that these initiatives will give us an extra little boost so we can help push Wine over the hump. I sincerely believe that the day when we can honestly tell people "It will most likely work nicely on Wine" is not long off. I also believe in the tooth fairy and Santa Claus, so make what you will of that <grin>. At any rate, this is a brand new initiative for us; call it an 0.1.7 release. We're very open to comments and thoughts and suggestions, so I would greatly appreciate any public or private comments you have to make. Cheers, Jeremy -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

9 18

Re: Add support for MDICREATESTRUCT conversion for 16-bit windows
by Alexandre Julliard Jan. 23, 2004

Jan. 23, 2004

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > I've got a bug report that after my MDI rewrite some 16-bit MDI app > stopped to work. That's not a surprise at all. The surprise is that > STRUCT32_xxx conversion helpers didn't cope correctly with 16-bit > hInstance and actually that caused a 16-bit app to misbehave in > the first place. I had to use GetExePtr() because MapHModuleSL checks > for NE_FFLAGS_WIN32 (why?) and bails out. Using GetExePtr is going to return the wrong instance once we get back to 16-bit code. The instance handles are actually not supposed to be converted at all, we just expand the 16-bit ones to 32-bit. What was the problem with your 16-bit app? -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Implement binary relocatability
by Alexandre Julliard Jan. 23, 2004

Jan. 23, 2004

Mike Hearn <mike(a)theoretic.com> writes: > Before Wine would not be able to find libwine nor ntdll.so, now it can. > > I hope this patch is OK, as I think this is a useful feature that far more > free software should support. The list of use cases is big. As dicussed a couple of weeks ago, this needs to be optional; you don't necessarily always want that behavior, and it conflicts with the --prefix option. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: GetCommandLine issue with Dungeon Keeper
by Frank.Schruefer＠t-online.de Jan. 23, 2004

Jan. 23, 2004

( REPOST, again: I was told that my massages need long time to appear because I'm not subscribed as frank.schruefer(a)t-online.de, ok, but my postings as wine(a)man-made.de (which I'm subscribed as) never come through. Maybe that is because mozilla only allows configuration for one outgoing mailserver which is the t-online one? Anything I could do about the situation? ) > > I'll soon come up with a win98 winnt comparison for the functions in > question. > I just have some trouble setting up *real* windows, believe it or not, > asrock > with SIS is nothing (old) windows' like! > Setting up wine is much easier LOL! > Hy, Ok, I made a simple test programm reading argv, GetCommandLineA and GetModuleFileNameA. I failed with NtCurrentTeb, even after installing microsoft sdk ... it didn't get linked. Well, I actually have very little experience if it comes to the C language but the test results I already have answer most of our questions already I think. I'd say the bottom line of the test results below is that wine almost perfectly simulates win32s behaviour but has no support for win9x be- haviour (regarding GetCommandLine* and argv). Changing the 'Windows' config parameter of wine in the [Version] sec- tion didn't make any difference to the test results from wine. That's what needs to be changed. Some of you suggested to always deliver full path but as some others said I also think that might break more programs than it'll make work so I'd oppose that idea. I think the solution is something like: if(GetVersion() & 0x80000000) /* not win32s */ { behave_as_win9x_and_modify_actual_command_line(); } else { behave_as_now(); } Basically: make the 'Windows' param in [Version] affect whether the command line is altered or not. So in my eyes it should come down to this: if(keeper_started_with_full_path() || wine_behaves_as_win9x_set_in_config()) { keeper_working = TRUE; } // woohoo! That I call programming ;-) To introduce a totally new config param to set wines behaviour here is neither necessary nor desireable. I see only one question remaining: at which place in wine should the commandline be modified if_win9x is 'set'? In GetCommandLineA? Guess no. Somewhere before CreateProces I think. But as I already menitioned c is not my mother tongue so I hope somebody else here might come up with the final solution ... Appendet here you'll find the source of a little test prog, a batch and the output the prog produced on: Windows 98, Windows NT 4.0 and Wine (on SuSE Linux 9.0). As I read it simulation of win9x behaviour needs to replace slashs by backslashs (which win32s has no probles with but 9x does) and relative paths by full paths and also the return of GetModuleFileNameA should be made to all uppercase - just to be on the safe side. ===================== TEST PROGRAM ==================== #include <windows.h> #include <stdio.h> #include <stdlib.h> int main(int argc, char** argv) { int i; char buffer[1024]; printf("+++ GetCommandLineA +++\n"); printf("%s\n", GetCommandLineA()); printf("+++ GetModuleFileNameA +++\n"); GetModuleFileNameA(0, buffer, sizeof(buffer)); printf("mfna: %s\n", buffer); printf("+++ argc & argv +++\n"); printf("argc: %i\n", argc); for(i = 0; i<argc; i++) printf("argv #%i: %s\n", i, argv[i]); getch(); } ======================================================= ===================== TEST BATCH ====================== echo %0 cmdline ======================================================= ================= WIN98: FROM EXPLORER ================ +++ GetCommandLineA +++ "C:\Eigene Dateien\WineCommandLine\CMDLINE.exe" +++ GetModuleFileNameA +++ mfna: C:\EIGENE DATEIEN\WINECOMMANDLINE\CMDLINE.EXE +++ argc & argv +++ argc: 1 argv #0: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe ======================================================= ================= WINE: FROM EXPLORER ================= (not applicable) ======================================================= =============== WINNT4.0: FROM EXPLORER =============== +++ GetCommandLineA +++ "C:\Eigene Dateien\WineCommandLine\CMDLINE.exe" +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe ======================================================= ============ WIN98: FROM SHELL, IN .exe DIR =========== C:\Eigene Dateien\WineCommandLine>cmdline +++ GetCommandLineA +++ C:\EIGENE~1\WINECO~1\CMDLINE.EXE +++ GetModuleFileNameA +++ mfna: C:\EIGENE DATEIEN\WINECOMMANDLINE\CMDLINE.EXE +++ argc & argv +++ argc: 1 argv #0: C:\EIGENE~1\WINECO~1\CMDLINE.EXE ======================================================= ============ WINE: FROM SHELL, IN .exe DIR ============ merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien/WineCommandLine> wine cmdline +++ GetCommandLineA +++ cmdline +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: cmdline ======================================================= ========== WINNT4.0: FROM SHELL, IN .exe DIR ========== C:\Eigene Dateien\WineCommandLine>cmdline +++ GetCommandLineA +++ cmdline +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: cmdline ======================================================= ========== WIN98: FROM SHELL, NOT IN .exe DIR ========= C:\Eigene Dateien>winecommandline\cmdline +++ GetCommandLineA +++ C:\EIGENE~1\WINECO~1\CMDLINE.EXE +++ GetModuleFileNameA +++ mfna: C:\EIGENE DATEIEN\WINECOMMANDLINE\CMDLINE.EXE +++ argc & argv +++ argc: 1 argv #0: C:\EIGENE~1\WINECO~1\CMDLINE.EXE ======================================================= =========== WINE: FROM SHELL, NOT IN .exe DIR ========= merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien> wine winecommandline/cmdline +++ GetCommandLineA +++ winecommandline/cmdline +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: winecommandline/cmdline ======================================================= ========= WINNT4.0: FROM SHELL, NOT IN .exe DIR ======= C:\Eigene Dateien>winecommandline\cmdline +++ GetCommandLineA +++ winecommandline\cmdline +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\winecommandline\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: winecommandline\cmdline ======================================================= ============= WIN98: FROM SHELL, FULL PATH ============ C:\Eigene Dateien>"c:\eigene dateien\winecommandline\cmdline" +++ GetCommandLineA +++ C:\EIGENE~1\WINECO~1\CMDLINE.EXE +++ GetModuleFileNameA +++ mfna: C:\EIGENE DATEIEN\WINECOMMANDLINE\CMDLINE.EXE +++ argc & argv +++ argc: 1 argv #0: C:\EIGENE~1\WINECO~1\CMDLINE.EXE C:\Eigene Dateien>"c:/eigene dateien/winecommandline/cmdline" Befehl oder Dateiname nicht gefunden C:\Eigene Dateien> ======================================================= ============== WINE: FROM SHELL, FULL PATH ============ merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien> wine "c:\\eigene dateien\\winecommandline\\cmdline" +++ GetCommandLineA +++ "c:\eigene dateien\winecommandline\cmdline" +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: c:\eigene dateien\winecommandline\cmdline merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien/WineCommandLine> wine "c:/eigene dateien/winecommandline/cmdline" +++ GetCommandLineA +++ "c:/eigene dateien/winecommandline/cmdline" +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: c:/eigene dateien/winecommandline/cmdline ======================================================= ============ WINNT4.0: FROM SHELL, FULL PATH ========== C:\Eigene Dateien>"c:\eigene dateien\winecommandline\cmdline" +++ GetCommandLineA +++ "c:\eigene dateien\winecommandline\cmdline" +++ GetModuleFileNameA +++ mfna: c:\eigene dateien\winecommandline\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: c:\eigene dateien\winecommandline\cmdline C:\Eigene Dateien>"c:/eigene dateien/winecommandline/cmdline" +++ GetCommandLineA +++ "c:/eigene dateien/winecommandline/cmdline" +++ GetModuleFileNameA +++ mfna: c:\eigene dateien\winecommandline\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: c:/eigene dateien/winecommandline/cmdline ======================================================= ============ WIN98: FROM BATCH, IN .exe DIR =========== C:\Eigene Dateien\WineCommandLine>batch C:\Eigene Dateien\WineCommandLine>echo batch batch C:\Eigene Dateien\WineCommandLine>cmdline +++ GetCommandLineA +++ C:\EIGENE~1\WINECO~1\CMDLINE.EXE +++ GetModuleFileNameA +++ mfna: C:\EIGENE DATEIEN\WINECOMMANDLINE\CMDLINE.EXE +++ argc & argv +++ argc: 1 argv #0: C:\EIGENE~1\WINECO~1\CMDLINE.EXE ======================================================= ============= WINE: FROM BATCH, IN .exe DIR =========== merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien/WineCommandLine> wine batch wine: cannot find 'batch' merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien/WineCommandLine> wine batch.bat wine: cannot determine executable type for L"C:\\Eigene Dateien\\WineCommandLine\\batch.bat" ======================================================= =========== WINNT4.0: FROM BATCH, IN .exe DIR ========= C:\Eigene Dateien\WineCommandLine>batch C:\Eigene Dateien\WineCommandLine>echo batch batch C:\Eigene Dateien\WineCommandLine>cmdline +++ GetCommandLineA +++ cmdline +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: cmdline ======================================================= ========== WIN98: FROM BATCH, NOT IN .exe DIR ========= C:\Eigene Dateien>winecommandline\batch C:\Eigene Dateien>echo winecommandline\batch winecommandline\batch C:\Eigene Dateien>cmdline Befehl oder Dateiname nicht gefunden. ======================================================= =========== WINE: FROM BATCH, NOT IN .exe DIR ========= merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien> wine WineCommandLine/batch wine: cannot find 'WineCommandLine/batch' merlin(a)Merlin:~/.wine/fake_windows/Eigene Dateien> wine winecommandline/batch.bat wine: cannot determine executable type for L"C:\\Eigene Dateien\\WineCommandLine\\batch.bat" ======================================================= ========= WINNT4.0: FROM BATCH, NOT IN .exe DIR ======= C:\Eigene Dateien>winecommandline\batch C:\Eigene Dateien>echo winecommandline\batch winecommandline\batch C:\Eigene Dateien>cmdline Der Befehl ist entweder falsch geschrieben oder konnte nicht gefunden werden. Bitte überprüfen Sie die Schreibweise und die Umgebungsvariable 'PATH'. ======================================================= ============ WIN98: FROM BATCH, BY EXPLORER =========== C:\Eigene Dateien\WineCommandLine>echo C:\EIGENE~1\WINECO~1\BATCH.BAT C:\EIGENE~1\WINECO~1\BATCH.BAT C:\Eigene Dateien\WineCommandLine>cmdline +++ GetCommandLineA +++ C:\EIGENE~1\WINECO~1\CMDLINE.EXE +++ GetModuleFileNameA +++ mfna: C:\EIGENE DATEIEN\WINECOMMANDLINE\CMDLINE.EXE +++ argc & argv +++ argc: 1 argv #0: C:\EIGENE~1\WINECO~1\CMDLINE.EXE ======================================================= ============= WINE: FROM BATCH, BY EXPLORER =========== (not applicable) ======================================================= =========== WINNT4.0: FROM BATCH, BY EXPLORER ========= C:\Eigene Dateien\WineCommandLine>echo "C:\Eigene Dateien\WineCommandLine\batch. bat" "C:\Eigene Dateien\WineCommandLine\batch.bat" C:\Eigene Dateien\WineCommandLine>cmdline +++ GetCommandLineA +++ cmdline +++ GetModuleFileNameA +++ mfna: C:\Eigene Dateien\WineCommandLine\CMDLINE.exe +++ argc & argv +++ argc: 1 argv #0: cmdline =======================================================

2 3

Re: PATCH: install more programs
by Alexandre Julliard Jan. 23, 2004

Jan. 23, 2004

Marcus Meissner <meissner(a)suse.de> writes: > I think we can install those safely. > > Ciao, Marcus > > Changelog: > Install rundll32,winemenubuilder and winevdm into the system. Why do you need these? They are not really supposed to be started directly by the user. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Wine release 20040121
by Boaz Harrosh Jan. 23, 2004

Jan. 23, 2004

Alexandre Julliard wrote: > - Better support for constructors in C++ Winelib apps. > > I follow the wine mailing list every work day. I even went back on these messages I did not read. I cannot find that patch. Alexandre Please? Elaborate a little about that fix. What do we do now? Just remove the wrapper and run? nothing to do in the Makefiles? Please also explain in a few words the technology behind it. (GCC that is). Free Life Boaz

3 3

Systray integration patch
by Martin Garton Jan. 22, 2004

Jan. 22, 2004

Hi, I realise that the systray patches as they currently stand will not be integrated and need making into a seperate program. However, in the meantime the existing systray patch Works For Me so does anyone have an updated version that applies against Wine-20040121? Regards, Martin Garton.

2 1

debugstr buffer overflow
by Stefan Leichter Jan. 22, 2004

Jan. 22, 2004

Hello, attached is a piece of a logfile that shows a buffer overflow of the debugstr. For my understanding the function should have only two parameters! is this right? What may cause this problem? Any ideas? Hints to trace the problem? Thanks Stefan For the record: logfile generated by installing mdac_type.exe (2.8) with current wine (cvs) on SuSE 9.0, "setupapi" = "native"

1 0

WineDbg didn't stop
by Fabian Cenedese Jan. 22, 2004

Jan. 22, 2004

Hi I tried to debug a program. I set a breakpoint but winedbg didn't stop though it said the breakpoint was set. Here's the output: Wine-dbg>b CIncoExpCtrl::OnCreate Unable to add breakpoint, will check again when a new DLL is loaded Wine-dbg>c ... (0x42a20000) Loaded debug information from 32bit DLL 'C:\WINDOWS\SYSTEM\INCOEXP.OCX' (0x10000000) Breakpoint 2 at 0x1001a910 (CIncoExpCtrl::OnCreate [C:\IncoExp\Src\IncoExpCtl.cpp:382] in INCOEXP.OCX) (yep, right file and right line) First chance exception: e06d7363 in 32-bit code (0x404b96f3). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:0000 EIP:404b96f3 ESP:408ce044 EBP:408ce0a0 EFLAGS:00000216( - 00 I -A-P1 ) EAX:408ce044 EBX:40574c78 ECX:00000000 EDX:0000000c ESI:408ce0e0 EDI:408ce064 Stack dump: 0x408ce044 (KERNEL32.DLL.VerSetConditionMask+0x36e206): e06d7363 00000001 00000000 404b9660 0x408ce054 (KERNEL32.DLL.VerSetConditionMask+0x36e216): 00000003 19930520 408ce10c 5f4bb5d8 0x408ce064 (KERNEL32.DLL.VerSetConditionMask+0x36e226): 00000000 42a50000 42a50000 780012b3 0x408ce074 (KERNEL32.DLL.VerSetConditionMask+0x36e236): ffffffff 408ce1fa 408ce0b8 78001385 0x408ce084 (KERNEL32.DLL.VerSetConditionMask+0x36e246): 42a50000 00000002 00000010 408ce1fa 0x408ce094 (KERNEL32.DLL.VerSetConditionMask+0x36e256): 00000000 7802ee08 408ce0e0 408ce0e0 0x408ce0a4 (KERNEL32.DLL.VerSetConditionMask+0x36e266): 0200: sel=1007 base=40018000 limit=00001f83 32-bit rw- Backtrace: =>0 0x404b96f3 (KERNEL32.DLL.RaiseException+0x93 in KERNEL32.DLL) (ebp=408ce0a0) 1 0x7800ac4e (MSVCRT.DLL._CxxThrowException+0x34 in MSVCRT.DLL) (ebp=408ce0e0) 2 0x5f47d5b1 (MFC42.DLL.1269+0x4d in MFC42.DLL) (ebp=408ce104) 3 0x5f48ceab (MFC42.DLL.2464+0x11c in MFC42.DLL) (ebp=408ce19c) 4 0x5f423445 (MFC42.DLL.4035+0x51 in MFC42.DLL) (ebp=408ce1c4) 5 0x5f42348d (MFC42.DLL.6095+0x43 in MFC42.DLL) (ebp=408ce1ec) 6 0x5f423520 (MFC42.DLL.5719+0x28 in MFC42.DLL) (ebp=408ce220) 7 0x5f42375d (MFC42.DLL.6198+0x14 in MFC42.DLL) (ebp=408ce288) 8 0x5f421996 (MFC42.DLL.6621+0x86 in MFC42.DLL) (ebp=408ce2e0) 9 0x5f42168b (MFC42.DLL.6623+0x3f in MFC42.DLL) (ebp=408ce31c) 10 0x5f421647 (MFC42.DLL.2135+0x59 in MFC42.DLL) (ebp=408ce370) 11 0x1001a9d5 (CIncoExpCtrl::OnCreate+0xc5(lpCreateStruct=0x5f401aff, cPath=0x1) [C:\IncoExp\Src\IncoExpCtl.cpp:401] in INCOEXP.OCX) (ebp=408ce470) ... What? We already passed the breakpoint? Why didn't it stop? Did I do something wrong? Thanks bye Fabi

2 1

Re: Print warning when drives of type cdrom do not contain a device field
by Mike Hearn Jan. 22, 2004

Jan. 22, 2004

OK, so I forgot the changelog entry. Apart from that, any reason this patch bounced? On Tue, 13 Jan 2004 19:11:17 +0000, Mike Hearn wrote: > I wasted half and hour tracing through the cdrom subsystem to find out why > halflife wasn't playing any music, only to find it was a config file > problem. Maybe this message can stop other people from making the same > mistake. > > Index: files/drive.c > =================================================================== > RCS file: /home/wine/wine/files/drive.c,v > retrieving revision 1.104 > diff -u -r1.104 drive.c > --- files/drive.c 25 Nov 2003 01:51:07 -0000 1.104 > +++ files/drive.c 13 Jan 2004 19:01:13 -0000 > @@ -338,7 +338,9 @@ > close(cd_fd); > } > } > - } > + } else if (drive->type == DRIVE_CDROM) { > + MESSAGE("\n* You have a CD-ROM drive defined in your configuration, but it is missing the Device key.\n* Playing CD audio and direct access will not work.\n\n"); > + } > > /* Get the FailReadOnly flag */ > RtlInitUnicodeString( &nameW, FailReadOnlyW );

3 3

Lotus Notes broken in recent CVS
by Paul R Streitman Jan. 22, 2004

Jan. 22, 2004

Hello, For the last couple days, Lotus Notes (5.0.11) has been broken under CVS Wine. Since Wine was released as a snapshot, I thought that I had better speak up because it is still broken and no one else seems to have noticed a problem with whatever recently changed.. Here is what I see: [paul: ~]wine nlnotes Warning: could not find wine config [Drive x] entry for current working directory /home/paul; starting in windows directory. fixme:reg:_nt_dump_lf unknown Win XP node id 0x686c: do we need to add support for it ? fixme:reg:_nt_dump_lf unknown Win XP node id 0x686c: do we need to add support for it ? fixme:reg:_nt_dump_lf unknown Win XP node id 0x686c: do we need to add support for it ? err:module:map_image Could not map section .rdata, file probably truncated err:module:import_dll Loading module (file) LTOUIN22.dll (which is needed by L"C:\\Lotus\\notes\\nnotesws.dll") failed (error c000007b). err:module:import_dll No implementation for LTOUIN22.dll.130 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.141 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.123 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.60 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.77 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.127 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.136 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.72 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.101 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.94 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.135 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.131 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.74 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.61 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.76 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.58 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.67 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.68 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll No implementation for LTOUIN22.dll.71 imported from L"C:\\Lotus\\notes\\nnotesws.dll", setting to 0xdeadbeef err:module:import_dll Module (file) nnotesws.dll (which is needed by L"C:\\Lotus\\notes\\nlnotes.exe") not found err:module:import_dll No implementation for nnotesws.dll.1 imported from L"C:\\Lotus\\notes\\nlnotes.exe", setting to 0xdeadbeef err:module:LdrInitializeThunk Main exe initialization for L"C:\\Lotus\\notes\\nlnotes.exe" failed, status c0000135 I do not know how to debug this, but am willing to run things if it would help (I am fairly knowledgable but not about C/C++ programming/debugging). Its a little awkward - I have to re-install an older level of Wine (I am currently running the December 12th snapshot) to send any e-mail and then install the current level to see the problem... My system is Mandrake cooker (current), with GCC 3.3.2 and the current kernel (currently 2.6.2-rc1-mm1). Notes is installed on an XP partition (FAT32), and run from there under Wine. I grab CVS every few days, and have not had any serious problems with this configuration since NPTL support was added, so I am reasonably sure that I do not have a configuration problem. Thanks, Paul z/OS core components development Internet: prs(a)us.ibm.com

3 2

SetupCreateDiskSpaceListA/W ?
by Stefan Leichter Jan. 22, 2004

Jan. 22, 2004

Hello, i am looking for informations / documents about the function SetupCreateDiskSpaceList of the SETUPAPI.DLL. I found nothing useful so far to get idea how to implement it. I used also the native dll to see the API call during the runtime of the function, but i found nothing useful. So any hints about the function are welcome Bye Stefan

1 0

cvs broken?
by Tom Jan. 22, 2004

Jan. 22, 2004

If I try to download a file from cvs I get this error. Error Error: Unexpected output from cvs co: cvs [checkout aborted]: Absolute module reference invalid: `/wine/dlls/msdmo/msdmo_main.c' Check, whether there exists a directory /home/wine/CVSROOT and the script has write-Access to the CVSROOT/history if it exists. It needs to place lock-files in the directory the file is in as well. Jer ? Tom

2 4

[leadership/opensource] invitation to online survey
by Gianluca Bosco Jan. 22, 2004

Jan. 22, 2004

Dear all, I have just put online a survey addressing the topic "good leadership in the open-source environment". Basically, my objective is to identify the personal conceptions of good leadership that reside in the minds of the contributors, in terms of leaders' _behaviors_ and _characteristics_. What is a good open-source project leader, from the contributor's point of view? To what extent, those personal believes are shared among developers? Can the contributor's national cultural belonging and level of experience in contributing to open-source projects explain such differences in their idea of what a good leader is? I would really appreciate your participation to the survey! Contribution (completely anonymous) consists in rating a list of statements that may be used to describe the behaviors of an open-source leader. It will take around ten minutes - there aren't any "time-consuming" open ended questions;) Following, the link to the survey: http://freeonlinesurveys.com/rendersurvey.asp?id=49776 If you are interested, I will not miss to email you a link to the final report, when ready ;) (approx, a couple of months from now) Thank you in advance, and don't hesitate to contact me if you have any questions or comments :) Gianluca Bosco g.bosco(a)GETRIDOFTHISinwind.it Denmark Technical University Department of manufacturing engineering and management

1 0

Still SSTab, OleAut32.dll
by Fabian Cenedese Jan. 22, 2004

Jan. 22, 2004

Hi I'm still trying to get some VB programs to run on wine (actual cvs). But I always get the error that it can't load the SSTab control from TabCtl32.ocx as described here: http://www.winehq.org/hypermail/wine-devel/2003/12/0157.html I now tried setting some dlls to native and found that it works (well, further) if I set OleAut32.dll to native, the others are still builtin. What is missing? Has this to do with the typelib or anything else? Testcase is simple: Create a new VB(6)-Project and place the tab control (from TabCtl32.ocx which has to activated first) on the empty dialog. Run the exe on wine. Any pointers? Thanks bye Fabi

1 0

Re: WM_CTLCOLOR.. will be sent to parent window. [?? Probable Spam]
by Dmitry Timoshkov Jan. 22, 2004

Jan. 22, 2004

<taro-x(a)justsystem.co.jp> wrote: > @@ -2665,12 +2665,27 @@ > static LRESULT > TREEVIEW_EraseBackground(TREEVIEW_INFO *infoPtr, HDC hDC) > { > - HBRUSH hBrush = CreateSolidBrush(infoPtr->clrBk); > - RECT rect; > + HBRUSH hBrushLocal = NULL; > + HWND hwnd = infoPtr->hwnd; > + HBRUSH hBrush = (HBRUSH)SendMessageW(GetParent(hwnd), > + IsWindowEnabled(hwnd) ? WM_CTLCOLOREDIT : WM_CTLCOLORSTATIC, > + (WPARAM)hDC, (LPARAM)hwnd); > + if (!hBrush) > + { > + hBrushLocal = CreateSolidBrush(GetBkColor(hDC)); > + hBrush = hBrushLocal; > + } 1. treeview has hwndNotify for sending notification messages, WM_CTLxxx messages can be sent to it as well. 2. In the case SendMessage(WM_CTLxxx) returns 0 (i.e. an app doesn't call DefWindowProc) you have to call DefWindowProc(WM_CTLxxx) yourself and not create an arbitrary brush. 3. Do not use C++ style comments. -- Dmitry.

1 0

Re: wine cvs notes and proposed keyboard detection fix.
by Dmitry Timoshkov Jan. 22, 2004

Jan. 22, 2004

"Shane Shields" <locutusenterprises(a)softhome.net> wrote: > "The patch is wrong, since it cures just a symptom not the problem itself. > There are two problems with current x11drv keyboard code: > 1. Very likely that Turkish keyboard layout there is incorrect. > 2. As stated before the keyboard code should be fixed to take into account > the real keyboard layout while building the keyc2vkey map, not the hardcoded > one." > > I have verified that (No. 1) the Turkish keyboard layout is correct so I am > now trying to work on No. 2. I'd expect that a correct keyboard layout should produce 0 (zero) number of mismatches... -- Dmitry.

1 0

Re: wine cvs notes and proposed keyboard detection fix.
by Dmitry Timoshkov Jan. 21, 2004

Jan. 21, 2004

"Shane Shields" <locutusenterprises(a)softhome.net> wrote: > > X11 team tends to remove more than 2 characters per keysym. See > > /etc/X11/xkb/symbols/tr. Turkish keyboard layout in Wine has more > > than 2 for some of them. Just do 'setxkbmap tr' and run Wine with > > +key,keyboard,+x11drv and look for mismatches. > > I have done that and piped the output to a logfile. Attached is an abbreviated > version with just the icelandic and turkish detection included. It seems to > be mismatching on detecting the third keysym where the key is defined > in /etc/X11/xkb/symbols/tr this could be a clue :) 15 mismatches per layout is too much. Isn't it? > TRACE_(key)("mismatch for keysym 0x%04lX, keycode %d, > > in function X11DRV_KEYBOARD_DetectLayout where it should be > > TRACE_(key)("mismatch for keysym 0x%08lX, keycode %d, 0x%04lX doesn't mean a truncation to 4 characters in format. > or my version of X11 is returning a larger value than it should. I suspect > this because of the large amount of calls to the function > KEYBOARD_MapDeadKeysym. Maybe the X11 guys have changed a short to a long > somewhere in my version of X11 (cvs 2003-11-24) or my gcc (3.2.2) has defined > them differently. If that is the case then the line > > ckey[i] = keysym & 0xFF; This piece of code gets executed only if XKB is disabled or couldn't translate keysym to a character. -- Dmitry.

2 1

Re: revised dsound mmap mapping patch
by Alexandre Julliard Jan. 21, 2004

Jan. 21, 2004

Robert Reif <reif(a)earthlink.net> writes: > Moves dsound mmap mapping info into dsound objects. This is causing a test failure for me: dsound.c:340: Test failed: SetFormat failed: 0x8878000a -- Alexandre Julliard julliard(a)winehq.com

1 0

Stack limit error in newest release (not in olders)
by Anssi Hannula Jan. 21, 2004

Jan. 21, 2004

When I run mircstats.exe, I get the following error: err:seh:EXC_DefaultHandling Exception frame is not in stack limits => unable to dispatch exception. This didn't happen on older releases. What does this error message mean? The newest release also segfaulted, before I turned overcommit on. -- Anssi

1 0

control/numeric pad/alt keys
by Vik Jan. 21, 2004

Jan. 21, 2004

Hi, Just noticed that control + whatever keycombination stopped working in head. Numeric Pad and Alt key combinations seems to be dead as well. Wondering if it's just me with my jp106 keyboard, or if anybody else has the same problem... Cheers Vik Here's the trace of --debugmsg +key notepad.exe when I pressed "ctrl + o". Instead of opening the file open dialog, it just outputs 'o' in the notepad window. trace:key:X11DRV_KeyEvent type 2, window 3400006, state 0x0004, keycode 0x0020 trace:key:X11DRV_KeyEvent state = 4 nbyte = 1, status 0x4 trace:key:X11DRV_KeyEvent KeyPress : keysym=6F (o), # of chars=1 / 0x0f / '^O' trace:key:EVENT_event_to_vkey e->keycode = 20 trace:key:X11DRV_KeyEvent keycode 0x20 converted to vkey 0x4f trace:key:X11DRV_KeyEvent bScan = 0x18. trace:key:queue_kbd_event wParam=004f, lParam=00180001, InputKeyState=81 trace:key:TranslateMessage (WM_KEYDOWN, 004F, 00180001) trace:key:TranslateMessage Translating key VK_O (004f), scancode 18 trace:key:X11DRV_ToUnicodeEx (004F, 0018) : faked state = 0x0000 trace:key:EVENT_event_to_vkey e->keycode = 20 trace:key:X11DRV_ToUnicodeEx type 2, window 3400006, state 0x0000, keycode 0x0020 trace:key:X11DRV_ToUnicodeEx Translating char 0x6f to unicode trace:key:X11DRV_ToUnicodeEx ToUnicode about to return 1 with char 6f trace:key:TranslateMessage 1 -> PostMessageW(0x10022,WM_CHAR,006f,00180001) trace:key:TranslateMessage (WM_CHAR, 006F, 00180001) trace:key:X11DRV_KeyEvent type 3, window 3400006, state 0x0004, keycode 0x0020 trace:key:X11DRV_KeyEvent state = 4 nbyte = 0, status 0x1 trace:key:X11DRV_KeyEvent KeyRelease : keysym=0 (No Name), # of chars=0 / 0x00 / '' trace:key:EVENT_event_to_vkey e->keycode = 20 trace:key:X11DRV_KeyEvent keycode 0x20 converted to vkey 0x4f trace:key:X11DRV_KeyEvent bScan = 0x18. trace:key:queue_kbd_event wParam=004f, lParam=c0180001, InputKeyState=1 trace:key:TranslateMessage (WM_KEYUP, 004F, C0180001) trace:key:X11DRV_KeyEvent type 3, window 3400006, state 0x0004, keycode 0x0042 trace:key:X11DRV_KeyEvent state = 4 nbyte = 0, status 0x1 trace:key:X11DRV_KeyEvent KeyRelease : keysym=0 (No Name), # of chars=0 / 0x00 / '' trace:key:EVENT_event_to_vkey e->keycode = 42 trace:key:X11DRV_KeyEvent keycode 0x42 converted to vkey 0x11 trace:key:X11DRV_KeyEvent bScan = 0x1d. trace:key:queue_kbd_event wParam=0011, lParam=c01d0001, InputKeyState=0 trace:key:TranslateMessage (WM_KEYUP, 0011, C01D0001) -- ------------ Vikram Kumar vik(a)zone81.com "Let the dogs bark, Sancho, it's a sign we're going in the right direction." -- Don Quixote

1 1

charset related compilation errors in authors.c
by Mike Hearn Jan. 21, 2004

Jan. 21, 2004

Hi, I've carbon copied this to wine-devel. This looks like some charset/toolchain issue, but I'm not sure how to diagnose it. This is on Fedora Core 1 yes? What is the output of echo $LANG at the command prompt? Maybe one of our charset experts (hi dmitry! :) knows what's up. thanks -mike On Tue, 2004-01-20 at 20:17, jds wrote: > Hi Mike: > > Iam try the compile source the wine20031212, both have the problems in compiled. > > try with manual and ./tools/wineinstall, recive is the same errors: > > make[2]: Leaving directory `/home/jds/wine-20031212/dlls/setupapi' > make[2]: Entering directory `/home/jds/wine-20031212/dlls/shell32' > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SHELL32_ > -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -mpreferred-stack-boundary=2 > -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o authors.o authors.c > authors.c:19: error: stray '\366' in program > authors.c:20: error: `m' undeclared here (not in a function) > authors.c:20: error: initializer element is not constant > authors.c:20: error: (near initialization for `SHELL_Authors[18]') > authors.c:20: error: syntax error before string constant > authors.c:37: error: stray '\351' in program > authors.c:46: error: stray '\366' in program > authors.c:47: error: `rklund' undeclared here (not in a function) > authors.c:47: error: initializer element is not constant > authors.c:47: error: (near initialization for `SHELL_Authors[45]') > authors.c:47: error: syntax error before string constant > authors.c:53: error: stray '\370' in program > authors.c:71: error: stray '\351' in program > authors.c:72: error: `ron' undeclared here (not in a function) > authors.c:72: error: initializer element is not constant > authors.c:72: error: (near initialization for `SHELL_Authors[70]') > authors.c:72: error: syntax error before string constant > authors.c:73: error: stray '\363' in program > authors.c:73: error: `pez' undeclared here (not in a function) > authors.c:73: error: initializer element is not constant > authors.c:73: error: (near initialization for `SHELL_Authors[72]') > authors.c:73: error: syntax error before "Caravaca" > authors.c:172: error: stray '\347' in program > authors.c:172: error: `ois' undeclared here (not in a function) > authors.c:172: error: initializer element is not constant > authors.c:172: error: (near initialization for `SHELL_Authors[171]') > authors.c:172: error: syntax error before "Gouget" > authors.c:183: error: stray '\374' in program > authors.c:184: error: `nnewig' undeclared here (not in a function) > authors.c:184: error: initializer element is not constant > authors.c:184: error: (near initialization for `SHELL_Authors[182]') > authors.c:184: error: syntax error before string constant > authors.c:240: error: stray '\366' in program > authors.c:240:13: warning: multi-character character constant > authors.c:240: error: `rgy' undeclared here (not in a function) > authors.c:240: error: initializer element is not constant > authors.c:240: error: (near initialization for `SHELL_Authors[239]') > authors.c:240: error: syntax error before '\x4e6f67' > authors.c:245: error: stray '\351' in program > authors.c:246: error: `nez' undeclared here (not in a function) > authors.c:246: error: initializer element is not constant > authors.c:246: error: (near initialization for `SHELL_Authors[244]') > authors.c:246: error: syntax error before string constant > authors.c:248: error: stray '\351' in program > authors.c:249: error: `Johansen' undeclared here (not in a function) > authors.c:249: error: initializer element is not constant > authors.c:249: error: (near initialization for `SHELL_Authors[247]') > authors.c:249: error: syntax error before string constant > authors.c:288: error: stray '\345' in program > authors.c:289: error: `ven' undeclared here (not in a function) > authors.c:289: error: initializer element is not constant > authors.c:289: error: (near initialization for `SHELL_Authors[287]') > authors.c:289: error: syntax error before string constant > authors.c:315: error: stray '\366' in program > authors.c:316: error: `m' undeclared here (not in a function) > authors.c:316: error: initializer element is not constant > authors.c:316: error: (near initialization for `SHELL_Authors[314]') > authors.c:316: error: syntax error before string constant > authors.c:323: error: stray '\374' in program > authors.c:324: error: `hl' undeclared here (not in a function) > authors.c:324: error: initializer element is not constant > authors.c:324: error: (near initialization for `SHELL_Authors[322]') > authors.c:324: error: syntax error before string constant > authors.c:330: error: stray '\351' in program > authors.c:330: error: `Marcos' undeclared here (not in a function) > authors.c:330: error: initializer element is not constant > authors.c:330: error: (near initialization for `SHELL_Authors[329]') > authors.c:330: error: syntax error before "L" > authors.c:330: error: stray '\363' in program > authors.c:402: error: stray '\345' in program > authors.c:403: error: `rd' undeclared here (not in a function) > authors.c:403: error: initializer element is not constant > authors.c:403: error: (near initialization for `SHELL_Authors[401]') > authors.c:403: error: syntax error before string constant > authors.c:408: error: stray '\351' in program > authors.c:408: error: `Manuel' undeclared here (not in a function) > authors.c:408: error: initializer element is not constant > authors.c:408: error: (near initialization for `SHELL_Authors[407]') > authors.c:408: error: syntax error before "Ferrer" > authors.c:482: error: stray '\374' in program > authors.c:483: error: `ter' undeclared here (not in a function) > authors.c:483: error: initializer element is not constant > authors.c:483: error: (near initialization for `SHELL_Authors[481]') > authors.c:483: error: syntax error before string constant > authors.c:613: error: stray '\305' in program > authors.c:613: error: stray '\366' in program > authors.c:613: error: `ngstr' undeclared here (not in a function) > authors.c:613: error: initializer element is not constant > authors.c:613: error: (near initialization for `SHELL_Authors[612]') > authors.c:613: error: syntax error before "m" > make[2]: *** [authors.o] Error 1 > make[2]: Leaving directory `/home/jds/wine-20031212/dlls/shell32' > make[1]: *** [shell32] Error 2 > make[1]: Leaving directory `/home/jds/wine-20031212/dlls' > make: *** [dlls] Error 2 > > Compilation failed, aborting install. > > Helpme please. > > Regards > > > > ---------- Original Message ----------- > From: Mike Hearn <mike(a)theoretic.com> > To: jds <jds(a)soltis.cc> > Sent: Mon, 19 Jan 2004 09:05:11 +0000 > Subject: Re: install problems IE with fresh winehq > wine-20031212-1fc1winehq.i686.rpm > > > On Sun, 2004-01-18 at 17:35, jds wrote: > > > Hi Mike: > > > I try the intall IE with you script install-ie6.sh in Fedora 1, fresh > intall > > > wine-20031212-1fc1winehq.i686, kernel 2.4.22-1.2149 > > > > > > The process no finish, pause in 72% in recive this errors: > > > > This is a known problem. For now please install Wine from WineHQ > > sources. I'm working on fixing this but the problem is a subtle one. > > > > thanks -mike > ------- End of Original Message ------- >

3 4

UXTHEME regression [was Re: install problems IE with fresh winehq wine-20031212-1fc1winehq.i686.rpm]
by Mike Hearn Jan. 21, 2004

Jan. 21, 2004

On Wed, 2004-01-21 at 06:57, jds wrote: > 0x40fc2453 (UXTHEME.DLL.GetThemeSysString+0x4e3 in UXTHEME.DLL): incl 0x0(%esi) > Wine-dbg>quit A large UXTHEME update was committed in the last few days. It appears this causes the IE installer to crash. I'm currently bogged down with exams, it'll go on my list of regressions to track down and nail, but may take a few days or weeks, depending on how things go here. For now I'd suggest using 20031212, CVS is highly unstable and iesetup regresses all the time at the moment. I've copied this one to wine-devel as well so Kevin can see the crash. thanks -mike

1 0

Re: Variant tests
by Sylvain Petreolle Jan. 21, 2004

Jan. 21, 2004

Jon, > Sylvain, can you apply the attached patch and send me the full output of > running the 2 tests? I can't duplicate the failures you are seeing with any > oleaut32 version here, but testing with a really really old version lead to > some changes that may help. These failures were given by the current oleaut32 CVS. (not by a real Windows box!) Now with this patch applied (updating CVS), I get : - no failure for vartest - 24 failures for vartype. (logs attached) ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "You believe it's the year 1984, when in fact, its closer to 2184"1984 / Matrix _________________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: Variant tests
by Dmitry Timoshkov Jan. 21, 2004

Jan. 21, 2004

"Jon Griffiths" <jon_p_griffiths(a)yahoo.com> wrote: > Dmitry, this should fix the test failing on your Win2K box also. If > it doesn't please let me know. A failure I reported is fixed now. Thanks! -- Dmitry.

1 0

winapi_test chokes on TITLEBARINFO
by Francois Gouget Jan. 21, 2004

Jan. 21, 2004

When I run ./tools/winapi/winapi_test it chokes on the TITLEBARINFO declaration in winuser.h: typedef struct tagTITLEBARINFO { DWORD cbSize; RECT rcTitleBar; DWORD rgstate[CCHILDREN_TITLEBAR+1]; } TITLEBARINFO, *PTITLEBARINFO, *LPTITLEBARINFO; include/winuser.h: DWORD[CCHILDREN_TITLEBAR+1]: can't parse type ('DWORD') ('CCHILDREN_TITLEBAR+1') Can't use string ("4") as a SCALAR ref while "strict refs" in use at tools/winapi/c_type.pm line 283. I believe this is because it does not know how to compute the value of 'CCHILDREN_TITLEBAR+1'. Though I'm not sure the second error is really related to the first one. I had a look but I'm pretty lost in the winapi code. Does anyone know how to fix this problem? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 4

Re: Fix dashed/solid line in Postscript output
by Alexandre Julliard Jan. 21, 2004

Jan. 21, 2004

Blake Leverett <bleverett(a)att.net> writes: > Index: dlls/wineps/ps.c > =================================================================== > RCS file: /home/wine/wine/dlls/wineps/ps.c,v > retrieving revision 1.23 > diff -u -r1.23 ps.c > --- dlls/wineps/ps.c 8 Dec 2003 21:40:27 -0000 1.23 > +++ dlls/wineps/ps.c 16 Jan 2004 05:26:55 -0000 > @@ -508,6 +508,7 @@ > BOOL PSDRV_WriteSetPen(PSDRV_PDEVICE *physDev) > { > char buf[256]; > + static char *last_dash = NULL; You can't use a static variable here, this would need to be stored in the device structure. But it's probably easier to always set the dash style unconditionally. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: wine cvs notes and proposed keyboard detection fix.
by Dmitry Timoshkov Jan. 20, 2004

Jan. 20, 2004

"Shane Shields" <locutusenterprises(a)softhome.net> wrote: > > There are two problems with current x11drv keyboard code: > > 1. Very likely that Turkish keyboard layout there is incorrect. > > AFAICT The Turkish keyboard layout is correct. X11 team tends to remove more than 2 characters per keysym. See /etc/X11/xkb/symbols/tr. Turkish keyboard layout in Wine has more than 2 for some of them. Just do 'setxkbmap tr' and run Wine with +key,keyboard,+x11drv and look for mismatches. > The original code doesnt get as > far as looking at the turkish definition. From what I could determine it > stopped searching when it got a wrong keysymb and if that combination > satisfied the selection that keyboard was chosen. That shouldn't happen. Keyboard detection code always does a full round of comparisons with every keyboard table in x11drv. > It didnt matter if it was > the right keyboard or not. This was not completely verified through testing > as I only have one keyboard :) > > 2. As stated before the keyboard code should be fixed to take into account > > the real keyboard layout while building the keyc2vkey map, not the > > hardcoded one. > > That would be a more elegant and portable fix. How do the other programs do it > (read window managers)? Other programs have no constrains implied by implementing Win32 APIs on the top of X11. -- Dmitry.

3 3

shell32 patch 10
by Martin Fuchs Jan. 20, 2004

Jan. 20, 2004

Changelog: - implemented SHGetRealIDL() Index: pidl.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/pidl.c,v retrieving revision 1.96 diff -u -p -d -r1.96 pidl.c --- pidl.c 18 Jan 2004 22:08:46 -0000 1.96 +++ pidl.c 20 Jan 2004 21:32:24 -0000 @@ -688,6 +688,7 @@ LPITEMIDLIST WINAPI ILCombine(LPCITEMIDL /* TRACE(pidl,"--new pidl=%p\n",pidlNew);*/ return pidlNew; } + /************************************************************************* * SHGetRealIDL [SHELL32.98] * @@ -695,10 +696,37 @@ LPITEMIDLIST WINAPI ILCombine(LPCITEMIDL */ HRESULT WINAPI SHGetRealIDL(LPSHELLFOLDER lpsf, LPCITEMIDLIST pidlSimple, LPITEMIDLIST *pidlReal) { - FIXME("sf=%p pidlSimple=%p pidlReal=%p\n", lpsf, pidlSimple, pidlReal); + UINT cfShellIDList = RegisterClipboardFormatA(CFSTR_SHELLIDLIST); - pdump (pidlSimple); - return 0; + STGMEDIUM medium = {0, {0}, 0}; + FORMATETC fmt = {cfShellIDList, 0, DVASPECT_CONTENT, -1, TYMED_HGLOBAL}; + + IDataObject* pDataObj; + HRESULT hr = IShellFolder_GetUIObjectOf(lpsf, 0, 1, &pidlSimple, &IID_IDataObject, 0, (LPVOID*)&pDataObj); + + if (SUCCEEDED(hr)) { + hr = IDataObject_GetData(pDataObj, &fmt, &medium); + + IDataObject_Release(pDataObj); + + if (SUCCEEDED(hr)) { + /*assert(pida->cidl==1);*/ + LPIDA pida = (LPIDA)GlobalLock(medium.hGlobal); + + LPCITEMIDLIST pidl_folder = (LPCITEMIDLIST) ((LPBYTE)pida+pida->aoffset[0]); + LPCITEMIDLIST pidl_child = (LPCITEMIDLIST) ((LPBYTE)pida+pida->aoffset[1]); + + *pidlReal = ILCombine(pidl_folder, pidl_child); + + if (!*pidlReal) + hr = E_OUTOFMEMORY; + + GlobalUnlock(medium.hGlobal); + GlobalFree(medium.hGlobal); + } + } + + return hr; } /*************************************************************************

1 0

Re: DPA_Create/Search may be missing
by Alexandre Julliard Jan. 20, 2004

Jan. 20, 2004

Francois Gouget <fgouget(a)free.fr> writes: > On NT4 (or is that on Internet Explorer <=5?), comctl32 is missing entry > points for DPA_Create and DPA_Search. So we need to link them > dynamically if we want the rest of the tests to run. What version of comctl32 is that? -- Alexandre Julliard julliard(a)winehq.com

7 18

Re: Oleaut32 tests fail
by Jon Griffiths Jan. 20, 2004

Jan. 20, 2004

Hi, >Running the oleaut32 tests shows that vartype and vartest are >failing. >Has someone an idea about these ? Your (presumably early) version of oleaut32.dll doesn't support the VT_DECIMAL type. I'll update the tests shortly. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes http://hotjobs.sweepstakes.yahoo.com/signingbonus

2 2

Unicode and CP_SYMBOL question.
by Rein Klazes Jan. 20, 2004

Jan. 20, 2004

Hi, Trying to fix a problem with Win2K's charmap.exe, I have a question for the unicode experts. If I convert character code's 32 to 255 using codepage SYMBOL on a Win2K system, like in this snippet: char c;WCHAR w; for( c = 32; c; c++) MultiByteToWideChar(CP_SYMBOL,0,&c,1,&w,1); I get that w == c + 0xf000 ( codes 0-31 are unchanged, any flag setting makes the function fail). Wine's implementation of MultiByteToWideChar() does something quite complicated based on standard unicode tables and returns Unicode characters in all kind of ranges. The loop above is basically what Win2K's charmap.exe does. Of course it does not properly display symbol fonts like "Symbol". Is there any reason why in this case MultiByteToWideChar should not do w = c + 0xf000 ? Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 5

Re: Need help debugging ... Ddraw issue
by Jason Edmeades Jan. 19, 2004

Jan. 19, 2004

Andreas Rosenberg: >If somebody could provide me the problematic exe of DK and the address >where the crash occurs I will put it through IDA pro. This might help lifting the >mystery. If IDA pro detects which compiler suite has been used to link the EXE, >it should be "easy" to detect where the string came from http://ftp.sunet.se/pub/pc/games/pcgameworld/demos/dkdemo.zip Unzip it, run KDDATA -d, and keeper95 is the executable From my notes (I dont have Linux to hand just now): Trap occurs ar 0x43d4e2 At this point in time the path/exe is in 0x552150 On windows: This was copied from 0x12fe20 (Was already filled in at a breakpoint at 0x43d4ba) which in turn came from 0x141ee0 when the pgm is very first loaded (windbg or msdev prior to executing any code). Jason

3 2

Re: Typo fix in type names
by Peter Hunnisett Jan. 19, 2004

Jan. 19, 2004

They are correct as is and yes MS makes spelling mistakes. Francois Gouget wrote: >In dlls/dplayx/lobbysp.h I found types and a field with a typo: > SPDATA_BUILDPARENTALHEIRARCHY > LPSPDATA_BUILDPARENTALHEIRARCHY > LPSP_BUILDPARENTALHEIRARCHY > BuildParentalHeirarchy > >I checked in the latest Microsoft SDK and in the DirectX 9.0a SDK and >couldn't find any type with a spelling of 'HEIRARCHY'. I also searched >on Google and could not find them here either. However I did not find >these types with the correct spelling either. > >That may be because these are internal types (they are defined in an >internal header after all), or because they are badly documented. > > This is the case. They're from a not really often distributed SDK. Ciao, Peter

3 2

Re: Fix dplayx initialisation
by Alexandre Julliard Jan. 19, 2004

Jan. 19, 2004

Sylvain Petreolle <spetreolle(a)yahoo.fr> writes: > Trying to load dplayx returns error 487 (ERROR_INVALID_ADDRESS) for > now. > > The following change lets wine determine a memory space by itself. This won't work, the code needs the address to be the same in all processes. This has to be fixed first. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: readme 2
by Alexandre Julliard Jan. 19, 2004

Jan. 19, 2004

"Ivan Leo Murray-Smith" <puoti(a)inwind.it> writes: > OK, it uses winehq.org this time, and hopefully doesn't mess up the readme.fr There's no reason to change these URLs at all, the existing ones work just fine. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Hi (virus alert)
by Rolf Kalbermatter Jan. 19, 2004

Jan. 19, 2004

Joshua Walker <halkun2002(a)yahoo.com> wrote: >3) If Microsoft just removed the ability to run >executables from Outlook, and made it so the user >would have to "activate" it via a executable >permission (Chmod 755 wsmktvxhew.exe) 99% of these >things won't even propgate. They actually did!! I seem not to be able to even extraxt an exe or other executable file attachment from any mail in Outlook 2000 at all. Even if I know for sure it is safe I can't get at it and had to ask the sender to resend it in ZIP format in the past. Didn't try to hard to find a config option 15 levels deep in some configuration settings though, but just decided they had overdone themselves ;-) Rolf Kalbermatter

1 0

Re: wine cvs notes and proposed keyboard detection fix.
by Dmitry Timoshkov Jan. 19, 2004

Jan. 19, 2004

"Sylvain Petreolle" <spetreolle(a)yahoo.fr> wrote: > Forwarded fom wine-users. > The keyboard detection when starting wine does not detect my turkish keyboard > and choses a scandinavion keyboard instead. I had a look at the keyboard.c > and there is a turkish keyboard defined. I found in the > X11DRV_KEYBOARD_DetectLayout function that the keysym detection loop exited > at the first wrong match which resulted in an incorrect match for the > keyboard. Attached is a patch that appears (for me) to solve this problem. > This problem has been evident since before cvs 2003-12-13. Wine still states > that it is unable to find the correct keyboard but it at least loads and uses > the correct definition although some keys don't work correctly. The patch is wrong, since it cures just a symptom not the problem itself. There are two problems with current x11drv keyboard code: 1. Very likely that Turkish keyboard layout there is incorrect. 2. As stated before the keyboard code should be fixed to take into account the real keyboard layout while building the keyc2vkey map, not the hardcoded one. Regarging Office 97 and Quicken problems: it's better to start with simple +relay trace and search for MessageBox and the first occurence of the wrongly formatted date respectively. Or just find a patch which caused a regression for Office97. -- Dmitry.

2 1

/dlls/gdi/freetype.c breakage
by Gerald Pfeifer Jan. 19, 2004

Jan. 19, 2004

The following patch to dlls/gdi/freetype.c revision 1.52 date: 2004/01/18 23:35:13; author: julliard; state: Exp; lines: +3 -4 Use the exported FONTENUMPROCW as parameter in the EnumDeviceFonts driver function instead of defining a private function type. breaks compilation freetype.c:2521: error: syntax error before "DEVICEFONTENUMPROC" freetype.c: In function `WineEngEnumFonts': freetype.c:2522: error: number of arguments doesn't match prototype gdi_private.h:220: error: prototype declaration on a system with FreeType 2.1.4 and XFree86 4.3.0. The problem seems that DEVICEFONTENUMPROC is not defined, though on some of my other test boxes with slightly different versions of FreeType, I did not see this problem. http://www.rtp.freebsd.org/~gerald/config.h contains the config.h file from autoconf. Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 1

Re: Re: cvs documentation not in sync with website?
by chmorgan＠charter.net Jan. 19, 2004

Jan. 19, 2004

Well documentation/documentation.sgml 1.12->1.13 was when the change was made in cvs, and that looks like it was 3+ months ago. Chris > > From: Jeremy Newman <jnewman(a)codeweavers.com> > Date: 2004/01/19 Mon AM 10:52:47 EST > To: Chris Morgan <cmorgan(a)alum.WPI.EDU> > CC: wine-devel(a)winehq.com > Subject: Re: cvs documentation not in sync with website? > > The docs build when Alexandre runs the wine_release script in the tools > cvs. http://cvs.winehq.org/cvsweb/tools/wine_release > > wine_release calls make_winehq also found in the tools cvs. If the docs > are out of date, it would be an error found in one of these two scripts. > > > On Sun, 2004-01-18 at 21:54, Chris Morgan wrote: > > I noticed this snippet from the online docs in the documentation section: > > http://winehq.com/site/docs/wine-devel/wine-docbook > > > > Run ./configure (or make distclean && ./configure) > > Switch to the documentation/ directory > > run ./make_winehq <----------- This line has changed > > View wine-doc/index.html in your favorite browser > > > > make_winehq has apparently been obsoleted, replaced by 'make html'. I was > > wondering why the web documentation wasn't in sync with the html docs. > > Shouldn't we be pulling the web documentation pages directly from the cvs > > pages at some scheduled interval? > > > > Thanks, > > Chris > -- > Jeremy Newman <jnewman(a)codeweavers.com> > CodeWeavers, Inc. > > >

1 0

cvs documentation not in sync with website?
by Chris Morgan Jan. 19, 2004

Jan. 19, 2004

I noticed this snippet from the online docs in the documentation section: http://winehq.com/site/docs/wine-devel/wine-docbook Run ./configure (or make distclean && ./configure) Switch to the documentation/ directory run ./make_winehq <----------- This line has changed View wine-doc/index.html in your favorite browser make_winehq has apparently been obsoleted, replaced by 'make html'. I was wondering why the web documentation wasn't in sync with the html docs. Shouldn't we be pulling the web documentation pages directly from the cvs pages at some scheduled interval? Thanks, Chris

2 1

Hi
by jsheets＠codeweavers.com Jan. 19, 2004

Jan. 19, 2004

Test =) jxbvitmuqfjiwe -- Test, yep.

6 5

Re: Re: [winecfg] - audio tab w/autodetection, misc
by chmorgan＠charter.net Jan. 19, 2004

Jan. 19, 2004

If other people think it makes sense then yes, I think we should probably move the autodetection code to run at wine startup. The code thus far is very much non-portable so while it should work under linux I'm not sure about other os's. I've considered also trying to dynamically load the sound libraries and use their library calls to detect the sound libraries. Any improvments or suggestions are more than welcome. The autodetection works well for me though so I'd imagine it would work for most linux end-users. Chris > > From: Mike Hearn <mike(a)theoretic.com> > Date: 2004/01/19 Mon AM 09:00:48 EST > To: wine-devel(a)winehq.com > Subject: Re: [winecfg] - audio tab w/autodetection, misc > > On Sun, 18 Jan 2004 18:08:30 -0500, Chris Morgan wrote: > > err:winecfg:setConfigValue Unable to set configuration key Drivers in section > > Winmm to winejack.drv, res=1021 > > > > Is this expected as changing this option would require the registry functions > > to modify the config file, something they can't do? > > Yes, that's normal. The config file is loaded as a read-only branch. To > fully test patches change the constant in the winecfg.h file so it points > to a new branch (ie a writable one). > > > Chris Morgan <cmorgan(a)alum.wpi.edu> > > Add audio tab with first pass at autodetection of audio driver. Double > > clicking a drive entry brings up drive edit window. > > One thing I'd ask is should the autodetection code be in Wine itself, > rather than the config utility? > > The patch looks good! :) > > thanks -mike > > > >

1 0

Re: [winecfg] - audio tab w/autodetection, misc
by Mike Hearn Jan. 19, 2004

Jan. 19, 2004

On Sun, 18 Jan 2004 18:08:30 -0500, Chris Morgan wrote: > err:winecfg:setConfigValue Unable to set configuration key Drivers in section > Winmm to winejack.drv, res=1021 > > Is this expected as changing this option would require the registry functions > to modify the config file, something they can't do? Yes, that's normal. The config file is loaded as a read-only branch. To fully test patches change the constant in the winecfg.h file so it points to a new branch (ie a writable one). > Chris Morgan <cmorgan(a)alum.wpi.edu> > Add audio tab with first pass at autodetection of audio driver. Double > clicking a drive entry brings up drive edit window. One thing I'd ask is should the autodetection code be in Wine itself, rather than the config utility? The patch looks good! :) thanks -mike

1 0

shell32: Implement PathGetShortPathA/W
by Rolf Kalbermatter Jan. 19, 2004

Jan. 19, 2004

Changelog - include/shlobj.h Add declaration for PathGetShortPath - dlls/shell32/undocshell.h Change prototype of PathGetShortPathAW to match MSDN - dlls/shell32/shellpath.c Implement PathGetShortPathA/W and change it's prototype to match the documentation on MSDN. Tests show that at least under W2K SP4 the return value actually seems to be the buffer pointer on success or NULL otherwise, but that might be rather a side effect of the function than intended behaviour. One thing I'm not entirely sure is how to declare the prototype in shlobj.h correctly. This is one of those functions shell32 exports as Unicode/ANSI depending on the Windows version, without the normal A and W exports as well. So shlobj.h needs to declare a function name without the A or W ending. The normal WINELIB_AW macros won't work here as the decision about A/W is not made on compile time of the application but instead on compile time of the library. What I don't like about this approach is the fact that there are basically two declarations for the same exported function in two different places GetShortPathAW in dlls/shell32/undocshell.h and GetShortPath in include/shlobj.h. License: X11/LGPL Rolf Kalbermatter Index: include/shlobj.h =================================================================== RCS file: /home/wine/wine/include/shlobj.h,v retrieving revision 1.80 diff -u -r1.80 shlobj.h --- include/shlobj.h 8 Jan 2004 00:39:21 -0000 1.80 +++ include/shlobj.h 19 Jan 2004 11:21:45 -0000 @@ -841,6 +841,11 @@ DECL_WINELIB_TYPE_AW(FILEGROUPDESCRIPTOR) DECL_WINELIB_TYPE_AW(LPFILEGROUPDESCRIPTOR) +/**************************************************************************** + * Path Manipulation Routines + */ +VOID WINAPI PathGetShortPath(LPVOID pszPath); + #include <poppack.h> /***************************************************************************** Index: dlls/shell32/undocshell.h =================================================================== RCS file: /home/wine/wine/dlls/shell32/undocshell.h,v retrieving revision 1.19 diff -u -r1.19 undocshell.h --- dlls/shell32/undocshell.h 16 Jan 2004 23:04:41 -0000 1.19 +++ dlls/shell32/undocshell.h 19 Jan 2004 11:51:43 -0000 @@ -544,7 +544,7 @@ BOOL WINAPI PathRemoveFileSpecAW(LPVOID lpszPath); -LPVOID WINAPI PathGetShortPathAW(LPVOID lpszPath); +VOID WINAPI PathGetShortPathAW(LPVOID lpszPath); void WINAPI PathRemoveBlanksAW(LPVOID lpszPath); Index: dlls/shell32/shellpath.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shellpath.c,v retrieving revision 1.77 diff -u -r1.77 shellpath.c --- dlls/shell32/shellpath.c 16 Jan 2004 23:04:41 -0000 1.77 +++ dlls/shell32/shellpath.c 19 Jan 2004 11:25:29 -0000 @@ -22,7 +22,6 @@ * Many of these functions are in SHLWAPI.DLL also * */ - #include "config.h" #include "wine/port.h" @@ -236,29 +235,41 @@ /************************************************************************* * PathGetShortPathA [internal] */ -LPSTR WINAPI PathGetShortPathA(LPSTR lpszPath) +VOID WINAPI PathGetShortPathA(LPSTR pszPath) { - FIXME("%s stub\n", lpszPath); - return NULL; + CHAR path[MAX_PATH]; + + TRACE("%s\n", pszPath); + + if (GetShortPathNameA(pszPath, path, MAX_PATH)) + { + lstrcpyA(pszPath, path); + } } /************************************************************************* * PathGetShortPathW [internal] */ -LPWSTR WINAPI PathGetShortPathW(LPWSTR lpszPath) +VOID WINAPI PathGetShortPathW(LPWSTR pszPath) { - FIXME("%s stub\n", debugstr_w(lpszPath)); - return NULL; + WCHAR path[MAX_PATH]; + + TRACE("%s\n", debugstr_w(pszPath)); + + if (GetShortPathNameW(pszPath, path, MAX_PATH)) + { + lstrcpyW(pszPath, path); + } } /************************************************************************* * PathGetShortPath [SHELL32.92] */ -LPVOID WINAPI PathGetShortPathAW(LPVOID lpszPath) +VOID WINAPI PathGetShortPathAW(LPVOID pszPath) { if(SHELL_OsIsUnicode()) - return PathGetShortPathW(lpszPath); - return PathGetShortPathA(lpszPath); + PathGetShortPathW(pszPath); + PathGetShortPathA(pszPath); } /*************************************************************************

1 0

Re: shlwapi: Implement PathFileExistsAndAttributesA/W
by Dmitry Timoshkov Jan. 19, 2004

Jan. 19, 2004

"Rolf Kalbermatter" <rolf.kalbermatter(a)citeng.com> wrote: > + iPrevErrMode = SetErrorMode(1); Please use a symbolic name (SEM_FAILCRITICALERRORS in this case), not just an arbitrary constant. Same for both A and W APIs. -- Dmitry.

1 0