January 2004 - Wine-Devel - list.winehq.org

Re: Hi (virus alert)
by Rolf Kalbermatter Jan. 19, 2004

Jan. 19, 2004

Joshua Walker <halkun2002(a)yahoo.com> wrote: >3) If Microsoft just removed the ability to run >executables from Outlook, and made it so the user >would have to "activate" it via a executable >permission (Chmod 755 wsmktvxhew.exe) 99% of these >things won't even propgate. They actually did!! I seem not to be able to even extraxt an exe or other executable file attachment from any mail in Outlook 2000 at all. Even if I know for sure it is safe I can't get at it and had to ask the sender to resend it in ZIP format in the past. Didn't try to hard to find a config option 15 levels deep in some configuration settings though, but just decided they had overdone themselves ;-) Rolf Kalbermatter

1 0

Re: wine cvs notes and proposed keyboard detection fix.
by Dmitry Timoshkov Jan. 19, 2004

Jan. 19, 2004

"Sylvain Petreolle" <spetreolle(a)yahoo.fr> wrote: > Forwarded fom wine-users. > The keyboard detection when starting wine does not detect my turkish keyboard > and choses a scandinavion keyboard instead. I had a look at the keyboard.c > and there is a turkish keyboard defined. I found in the > X11DRV_KEYBOARD_DetectLayout function that the keysym detection loop exited > at the first wrong match which resulted in an incorrect match for the > keyboard. Attached is a patch that appears (for me) to solve this problem. > This problem has been evident since before cvs 2003-12-13. Wine still states > that it is unable to find the correct keyboard but it at least loads and uses > the correct definition although some keys don't work correctly. The patch is wrong, since it cures just a symptom not the problem itself. There are two problems with current x11drv keyboard code: 1. Very likely that Turkish keyboard layout there is incorrect. 2. As stated before the keyboard code should be fixed to take into account the real keyboard layout while building the keyc2vkey map, not the hardcoded one. Regarging Office 97 and Quicken problems: it's better to start with simple +relay trace and search for MessageBox and the first occurence of the wrongly formatted date respectively. Or just find a patch which caused a regression for Office97. -- Dmitry.

2 1

/dlls/gdi/freetype.c breakage
by Gerald Pfeifer Jan. 19, 2004

Jan. 19, 2004

The following patch to dlls/gdi/freetype.c revision 1.52 date: 2004/01/18 23:35:13; author: julliard; state: Exp; lines: +3 -4 Use the exported FONTENUMPROCW as parameter in the EnumDeviceFonts driver function instead of defining a private function type. breaks compilation freetype.c:2521: error: syntax error before "DEVICEFONTENUMPROC" freetype.c: In function `WineEngEnumFonts': freetype.c:2522: error: number of arguments doesn't match prototype gdi_private.h:220: error: prototype declaration on a system with FreeType 2.1.4 and XFree86 4.3.0. The problem seems that DEVICEFONTENUMPROC is not defined, though on some of my other test boxes with slightly different versions of FreeType, I did not see this problem. http://www.rtp.freebsd.org/~gerald/config.h contains the config.h file from autoconf. Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 1

Re: Re: cvs documentation not in sync with website?
by chmorgan＠charter.net Jan. 19, 2004

Jan. 19, 2004

Well documentation/documentation.sgml 1.12->1.13 was when the change was made in cvs, and that looks like it was 3+ months ago. Chris > > From: Jeremy Newman <jnewman(a)codeweavers.com> > Date: 2004/01/19 Mon AM 10:52:47 EST > To: Chris Morgan <cmorgan(a)alum.WPI.EDU> > CC: wine-devel(a)winehq.com > Subject: Re: cvs documentation not in sync with website? > > The docs build when Alexandre runs the wine_release script in the tools > cvs. http://cvs.winehq.org/cvsweb/tools/wine_release > > wine_release calls make_winehq also found in the tools cvs. If the docs > are out of date, it would be an error found in one of these two scripts. > > > On Sun, 2004-01-18 at 21:54, Chris Morgan wrote: > > I noticed this snippet from the online docs in the documentation section: > > http://winehq.com/site/docs/wine-devel/wine-docbook > > > > Run ./configure (or make distclean && ./configure) > > Switch to the documentation/ directory > > run ./make_winehq <----------- This line has changed > > View wine-doc/index.html in your favorite browser > > > > make_winehq has apparently been obsoleted, replaced by 'make html'. I was > > wondering why the web documentation wasn't in sync with the html docs. > > Shouldn't we be pulling the web documentation pages directly from the cvs > > pages at some scheduled interval? > > > > Thanks, > > Chris > -- > Jeremy Newman <jnewman(a)codeweavers.com> > CodeWeavers, Inc. > > >

1 0

cvs documentation not in sync with website?
by Chris Morgan Jan. 19, 2004

Jan. 19, 2004

I noticed this snippet from the online docs in the documentation section: http://winehq.com/site/docs/wine-devel/wine-docbook Run ./configure (or make distclean && ./configure) Switch to the documentation/ directory run ./make_winehq <----------- This line has changed View wine-doc/index.html in your favorite browser make_winehq has apparently been obsoleted, replaced by 'make html'. I was wondering why the web documentation wasn't in sync with the html docs. Shouldn't we be pulling the web documentation pages directly from the cvs pages at some scheduled interval? Thanks, Chris

2 1

Hi
by jsheets＠codeweavers.com Jan. 19, 2004

Jan. 19, 2004

Test =) jxbvitmuqfjiwe -- Test, yep.

6 5

Re: Re: [winecfg] - audio tab w/autodetection, misc
by chmorgan＠charter.net Jan. 19, 2004

Jan. 19, 2004

If other people think it makes sense then yes, I think we should probably move the autodetection code to run at wine startup. The code thus far is very much non-portable so while it should work under linux I'm not sure about other os's. I've considered also trying to dynamically load the sound libraries and use their library calls to detect the sound libraries. Any improvments or suggestions are more than welcome. The autodetection works well for me though so I'd imagine it would work for most linux end-users. Chris > > From: Mike Hearn <mike(a)theoretic.com> > Date: 2004/01/19 Mon AM 09:00:48 EST > To: wine-devel(a)winehq.com > Subject: Re: [winecfg] - audio tab w/autodetection, misc > > On Sun, 18 Jan 2004 18:08:30 -0500, Chris Morgan wrote: > > err:winecfg:setConfigValue Unable to set configuration key Drivers in section > > Winmm to winejack.drv, res=1021 > > > > Is this expected as changing this option would require the registry functions > > to modify the config file, something they can't do? > > Yes, that's normal. The config file is loaded as a read-only branch. To > fully test patches change the constant in the winecfg.h file so it points > to a new branch (ie a writable one). > > > Chris Morgan <cmorgan(a)alum.wpi.edu> > > Add audio tab with first pass at autodetection of audio driver. Double > > clicking a drive entry brings up drive edit window. > > One thing I'd ask is should the autodetection code be in Wine itself, > rather than the config utility? > > The patch looks good! :) > > thanks -mike > > > >

1 0

Re: [winecfg] - audio tab w/autodetection, misc
by Mike Hearn Jan. 19, 2004

Jan. 19, 2004

On Sun, 18 Jan 2004 18:08:30 -0500, Chris Morgan wrote: > err:winecfg:setConfigValue Unable to set configuration key Drivers in section > Winmm to winejack.drv, res=1021 > > Is this expected as changing this option would require the registry functions > to modify the config file, something they can't do? Yes, that's normal. The config file is loaded as a read-only branch. To fully test patches change the constant in the winecfg.h file so it points to a new branch (ie a writable one). > Chris Morgan <cmorgan(a)alum.wpi.edu> > Add audio tab with first pass at autodetection of audio driver. Double > clicking a drive entry brings up drive edit window. One thing I'd ask is should the autodetection code be in Wine itself, rather than the config utility? The patch looks good! :) thanks -mike

1 0

shell32: Implement PathGetShortPathA/W
by Rolf Kalbermatter Jan. 19, 2004

Jan. 19, 2004

Changelog - include/shlobj.h Add declaration for PathGetShortPath - dlls/shell32/undocshell.h Change prototype of PathGetShortPathAW to match MSDN - dlls/shell32/shellpath.c Implement PathGetShortPathA/W and change it's prototype to match the documentation on MSDN. Tests show that at least under W2K SP4 the return value actually seems to be the buffer pointer on success or NULL otherwise, but that might be rather a side effect of the function than intended behaviour. One thing I'm not entirely sure is how to declare the prototype in shlobj.h correctly. This is one of those functions shell32 exports as Unicode/ANSI depending on the Windows version, without the normal A and W exports as well. So shlobj.h needs to declare a function name without the A or W ending. The normal WINELIB_AW macros won't work here as the decision about A/W is not made on compile time of the application but instead on compile time of the library. What I don't like about this approach is the fact that there are basically two declarations for the same exported function in two different places GetShortPathAW in dlls/shell32/undocshell.h and GetShortPath in include/shlobj.h. License: X11/LGPL Rolf Kalbermatter Index: include/shlobj.h =================================================================== RCS file: /home/wine/wine/include/shlobj.h,v retrieving revision 1.80 diff -u -r1.80 shlobj.h --- include/shlobj.h 8 Jan 2004 00:39:21 -0000 1.80 +++ include/shlobj.h 19 Jan 2004 11:21:45 -0000 @@ -841,6 +841,11 @@ DECL_WINELIB_TYPE_AW(FILEGROUPDESCRIPTOR) DECL_WINELIB_TYPE_AW(LPFILEGROUPDESCRIPTOR) +/**************************************************************************** + * Path Manipulation Routines + */ +VOID WINAPI PathGetShortPath(LPVOID pszPath); + #include <poppack.h> /***************************************************************************** Index: dlls/shell32/undocshell.h =================================================================== RCS file: /home/wine/wine/dlls/shell32/undocshell.h,v retrieving revision 1.19 diff -u -r1.19 undocshell.h --- dlls/shell32/undocshell.h 16 Jan 2004 23:04:41 -0000 1.19 +++ dlls/shell32/undocshell.h 19 Jan 2004 11:51:43 -0000 @@ -544,7 +544,7 @@ BOOL WINAPI PathRemoveFileSpecAW(LPVOID lpszPath); -LPVOID WINAPI PathGetShortPathAW(LPVOID lpszPath); +VOID WINAPI PathGetShortPathAW(LPVOID lpszPath); void WINAPI PathRemoveBlanksAW(LPVOID lpszPath); Index: dlls/shell32/shellpath.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shellpath.c,v retrieving revision 1.77 diff -u -r1.77 shellpath.c --- dlls/shell32/shellpath.c 16 Jan 2004 23:04:41 -0000 1.77 +++ dlls/shell32/shellpath.c 19 Jan 2004 11:25:29 -0000 @@ -22,7 +22,6 @@ * Many of these functions are in SHLWAPI.DLL also * */ - #include "config.h" #include "wine/port.h" @@ -236,29 +235,41 @@ /************************************************************************* * PathGetShortPathA [internal] */ -LPSTR WINAPI PathGetShortPathA(LPSTR lpszPath) +VOID WINAPI PathGetShortPathA(LPSTR pszPath) { - FIXME("%s stub\n", lpszPath); - return NULL; + CHAR path[MAX_PATH]; + + TRACE("%s\n", pszPath); + + if (GetShortPathNameA(pszPath, path, MAX_PATH)) + { + lstrcpyA(pszPath, path); + } } /************************************************************************* * PathGetShortPathW [internal] */ -LPWSTR WINAPI PathGetShortPathW(LPWSTR lpszPath) +VOID WINAPI PathGetShortPathW(LPWSTR pszPath) { - FIXME("%s stub\n", debugstr_w(lpszPath)); - return NULL; + WCHAR path[MAX_PATH]; + + TRACE("%s\n", debugstr_w(pszPath)); + + if (GetShortPathNameW(pszPath, path, MAX_PATH)) + { + lstrcpyW(pszPath, path); + } } /************************************************************************* * PathGetShortPath [SHELL32.92] */ -LPVOID WINAPI PathGetShortPathAW(LPVOID lpszPath) +VOID WINAPI PathGetShortPathAW(LPVOID pszPath) { if(SHELL_OsIsUnicode()) - return PathGetShortPathW(lpszPath); - return PathGetShortPathA(lpszPath); + PathGetShortPathW(pszPath); + PathGetShortPathA(pszPath); } /*************************************************************************

1 0

Re: shlwapi: Implement PathFileExistsAndAttributesA/W
by Dmitry Timoshkov Jan. 19, 2004

Jan. 19, 2004

"Rolf Kalbermatter" <rolf.kalbermatter(a)citeng.com> wrote: > + iPrevErrMode = SetErrorMode(1); Please use a symbolic name (SEM_FAILCRITICALERRORS in this case), not just an arbitrary constant. Same for both A and W APIs. -- Dmitry.

1 0