October 2004 - Wine-Devel - list.winehq.org

Re: Add list for monitoring Appdb
by Jeremy Newman Oct. 22, 2004

Oct. 22, 2004

I'm holding off on this patch until I get more comments on why we should or shouldn't create yet another mailing list. My personal opinion is that we don't need a mailing list for this. The change emails can go straight to the app owners themselves, and possibly to the appdb admins. I know I wouldn't care seeing update emails for apps I don't maintain. Just my opinion. I will create this list if there is enough interest in it. On Wed, 2004-10-13 at 10:38 -0700, Tony Lambregts wrote: > I am working on a series of changes that will let changes to the appdb > be emailed to administrators, application owners and other users. > > This will be similar to how bugzilla does it. > > When someone changes an application an email listing the changes gets > sent to the following > > - Appdb administrators. > - Application owners. > - Aplication monitors. > > One of the things that I think is a repository the way wine-bugs(a)winehq.org > does for bugzilla > > I need Jeremy to set up the email account and the mailman account. > > Change log: Add link for monitoring changes to application database > > files changed: lostwages/templates/en/forums.template > > > Tony Lambregts > > Index: forums.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/forums.template,v > retrieving revision 1.16 > diff -u -r1.16 forums.template > --- forums.template 15 Sep 2004 20:05:31 -0000 1.16 > +++ forums.template 13 Oct 2004 15:46:24 -0000 > @@ -97,6 +97,13 @@ > <a href="http://bugs.winehq.org/">Bug Tracking Database</a>. > > <li> > + [<a href="http://www.winehq.org/mailman/listinfo/wine-appdb">(Un-)Subscribe</a>] > + [<a href="http://www.winehq.org/hypermail/wine-appdb/">Archive </a>] > + <a href="mailto:wine-appdb(a)winehq.org">wine-appdb(a)winehq.org</a> > + A low traffic (2/day) read-only list for monitoring submissions to the > + <a href="http://appdb.winehq.org/">Application Database</a>. > + > + <li> > [<a href="http://www.winehq.org/mailman/listinfo/wine-tests-results">(Un-)Subscribe</a>] > [<a href="http://www.winehq.org/hypermail/wine-tests-results/">Archive</a>] > <a href="mailto:wine-tests-results(a)winehq.org">wine-tests-results(a)winehq.org</a> > > >

3 2

Re: shellpath.c: Avoid copying invalid data on error
by Alexandre Julliard Oct. 22, 2004

Oct. 22, 2004

Juan Lang <juan_lang(a)yahoo.com> writes: > The following is a better patch, I think, in that > - it doesn't add a break statement to the default case > (some compilers warn on this) I seriously doubt that, what compiler does this for you? It's much better practice to always add break to all cases, otherwise when someone adds some code at the end of the switch they will forget to add a break to the previous case. > - WCHAR szBuildPath[MAX_PATH], szTemp[MAX_PATH]; > + WCHAR szBuildPath[MAX_PATH], szTemp[MAX_PATH] = { 0 }; This fills the whole buffer with zeroes, that's not really needed. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dlls/shlwapi PathIsValidChar
by Alexandre Julliard Oct. 22, 2004

Oct. 22, 2004

Ge van Geldorp <gvg(a)reactos.com> writes: > Did this patch: http://www.winehq.org/hypermail/wine-patches/2004/09/0446.html > fall through the cracks or is it not acceptable? I think a lookup table would be more elegant (and faster...) -- Alexandre Julliard julliard(a)winehq.org

1 0

unaligned access bug in winspool on sparc
by Eric Frias Oct. 22, 2004

Oct. 22, 2004

I just ran across an evil little bug in the WINSPOOL_GetPrinter_2 function. It looks like this type of bug could be hiding in other API functions too. It causes a segmentation fault because of an unaligned access on Solaris (sparc). This function packs a PRINTER_INFO_2 structure and all of its variable-length fields into one contiguous block of memory. The structure is first, then several strings, and then a DEVMODE structure. The problem is that because the strings can be any length, the DEVMODE structure itself could be placed at an unaligned (odd) address. So on our system, wine runs correctly if we only have printers with an even number of letters in their name in the printcap file, but it crashes if any have an odd number of letters in their name. I put in a quick hack that aligns it to a 4-byte boundary. I think a two-byte boundary would suffice, but I decided to err on the safe side since I wasn't sure. I inserted the following block near line 1822 in info.c: ------ { int bytesOfPadding = (4 - (*pcbNeeded % 4)) % 4; if (space && bytesOfPadding <= left) { ptr += bytesOfPadding; left -= bytesOfPadding; } else space = FALSE; *pcbNeeded += bytesOfPadding; } ------ right before the line: ------ if(WINSPOOL_GetDevModeFromReg(hkeyPrinter, Default_DevModeW, ptr, left, &size, unicode)) { ----- What is the correct way to align this structure? Are there any macros that specify the necessary alignment for each architecture? I'm also wondering if there are any other functions that are likely to contain the same bug. Thanks, Eric

1 0

Re: msdn: d3drs_wrapn[0-7] ???
by Devils Cry Oct. 22, 2004

Oct. 22, 2004

Well, i aplied the changes raphael suggested and although i dont understand what they do they work :D @David Welch Yeah, already found that out, but thx anyway, i think i understand it a bit better now :) /Me moving on for validateshaders... lets see what that gets :D Cheers Nikolas

1 0

Re: Add function prototypes to wineconf
by Chris Morgan Oct. 22, 2004

Oct. 22, 2004

I think the idea is that we should move the functionality of wineconf into winecfg so winecfg should be able to autodetect and import the configurations from existing windows installs. Wineconf hasn't been well maintained lately so maybe now is a good time to encourage people to implement that functionality in winecfg by removing it ;-) Chris > > From: Francois Gouget <fgouget(a)free.fr> > Date: 2004/10/22 Fri PM 12:21:32 EDT > To: wine-patches(a)winehq.org > Subject: Add function prototypes to wineconf > > > This tool generates a Wine configuration containing [Drive] sections! > In other words it's pretty outdated. It was last updated almost 18 > months ago! > > Is it even worth keeping? Maybe the best thing to do is to do a cvs > delete on it? > > In case we want to keep it I added function prototypes. However I did > not change its behavior any further. On my machine it runs but perl > issues a couple of warnings... the same one it was issuing before I ever > touched it. > > > Changelog: > > * tools/wineconf > > Add function prototypes. > Change the way functions are called and their declaration order so > perl can check the prototypes. > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > "Lotto: A tax on people who are bad at math." -- unknown > "Windows: Microsoft's tax on computer illiterates." -- WE7U >

1 0

modal message box fixme
by Ivan Leo Puoti Oct. 22, 2004

Oct. 22, 2004

I've written an app that calls a modal message box, if the uType parameter passed to MessageBox is MB_TASKMODAL or MB_SYSTEMMODAL a fixme is printed, but if it's MB_APPLMODA wine doesn't print a fixme. Is the attached fix correct (It works for me)? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Using Microsoft C++ Toolkit with Wine
by Dan Kegel Oct. 22, 2004

Oct. 22, 2004

I've posted about this before, but never really tied things up in a neat package, so: Here's a document that describes how to use Microsoft C++ Toolkit on Linux to build Windows programs: http://www.kegel.com/wine/cl-howto.html I hope that helps a few people. I certainly find it convenient when writing Wine conformance tests. To build a Wine conformance test standalone, I start the test off with the lines #include <stdarg.h> #include <windef.h> #include <winbase.h> #ifndef STANDALONE #include "wine/test.h" #define ok2 ok #else #include <assert.h> #include <stdio.h> #define START_TEST(name) main(int argc, char **argv) #define ok(condition, msg) \ do { \ if(!(condition)) \ { \ fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__); \ exit(0); \ } \ } while(0) #define ok2(condition, msg, arg) \ do { \ if(!(condition)) \ { \ fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__, arg); \ exit(0); \ } \ } while(0) #define todo_wine #endif #include <winerror.h> and use ok2 for those calls to ok that have one argument after the format string. That .c file should be fine for either normal or standalone use. (I haven't tested ok2 yet under the normal wine build, but I think #define ok2 ok should work.) Then I can compile with cl -DSTANDALONE -D_X86_ myfile.c and get a quickie Windows executable for just that test file. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: Cleanup config
by Alexandre Julliard Oct. 22, 2004

Oct. 22, 2004

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > [wine] > -"Windows" = "c:\\windows" > -"System" = "c:\\windows\\system" > -"Temp" = "e:\\" > -"Path" = "c:\\windows;c:\\windows\\system;e:\\;e:\\test;f:\\" > -"Profile" = "c:\\windows\\Profiles\\Administrator" This is OK except for the windows dir, that one is still being used by the registry code. -- Alexandre Julliard julliard(a)winehq.org

2 2

wine 1019 build fails at wine_marlett.sfd
by sean Oct. 22, 2004

Oct. 22, 2004

I'm trying to buid wine-10192004. I've installed fontforge-10142004. The wine build fails here: fontforge -script ../fonts/genttf.ff wine_marlett.sfd Copyright (c) 2000-2004 by George Williams. Executable based on sources from 10:52 14-Oct-2004. FontForge used to be named PfaEdit. make[1]: *** [wine_marlett.ttf] Segmentation fault This not a machine error. The sigsegv happens if I execute this command in the build directory. Before that i get: fontforge -script ../fonts/genttf.ff wine_courier.sfd Copyright (c) 2000-2004 by George Williams. Executable based on sources from 10:52 14-Oct-2004. FontForge used to be named PfaEdit. LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt wine_courier.ttf 13 1252 96 128 ../tools/fnt2fon wine_courier-1252-96-13.fnt wine_coure.fon Wine Courier 10 pts 96x96 dpi LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt wine_courier.ttf 13 1250 96 128 ../tools/fnt2fon wine_courier-1250-96-13.fnt wine_couree.fon Wine Courier 10 pts 96x96 dpi LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt wine_courier.ttf 13 1251 96 128 Missing glyph for char 0402 Missing glyph for char 0403 Missing glyph for char 0453 Missing glyph for char 0409 Missing glyph for char 040a Thanks for any help. sean

1 0