October 2004 - Wine-Devel - list.winehq.org

Re: small fix
by Mike Hearn Oct. 4, 2004

Oct. 4, 2004

Hi, >Hi! >Here is a small patch for wine-20040914. >Summary: tool window with a caption are not managed. > This doesn't seem quite right - WS_EX_TOOLWINDOW & WS_CAPTION should be managed as we set the EWMH hints for this style later on in the code. What WM are you using Sergey? thanks -mike

1 0

Re: ez-cdda sleep
by Dan Kegel Oct. 3, 2004

Oct. 3, 2004

Eric Pouech (pouech-eric(a)wanadoo.fr) wrote: > ... > But, the address we get in GetThreadContext is the one from where the > thread waits on the server (hence the 0xffffe410 address), not the > address it was suspended from (as it's supposed to be) > > I don't think it will be easy to fix. > > Possible ideas: > ... > - storing context in server while entering USR1 signal handler (to be > done without races, which will require some more work, as the server > doesn't synchronize with the USR1 handler) This one seems most natural. Maybe the server should wait for the context to be stored before returning from SuspendThread. I bet on Windows, the target thread is really suspended before SuspendThread returns, and this would ensure that behavior. Maybe if we do this right, we can get rid of the racy looking loop at the top of test_SuspendThread() in dlls/kernel/tests/thread.c ... or is that loop needed on Windows, too? - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

2 1

Re: systemparamatersw question
by Ivan Leo Puoti Oct. 3, 2004

Oct. 3, 2004

>Write a program looping through the SPI values, then use regmon >to find the keys it accesses. Thanks, I'll give this a go. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Regression to Get IE Help to Work after September Snapshot
by Dan McGhee Oct. 3, 2004

Oct. 3, 2004

I could not get IE Help, or any application based on it, to work after the September snapshot. I did a regression and identified the commit of 20040824 16:00:16 CDT as causing the problem. This commit edits this patch: http://cvs.winehq.org/patch.py?id=13475 Among other things this patch changes wine/dlls/Makefile.in wine/configure.ac wine/configure I discovered during the regression that if I use ./tools/wineinstall and let wine set up my fake windows and .wine/config file I couldn't get IE Help to work. However, I used the September snapshot to test this, if I do "./configure, make depend && make" followed by install" and used a .wine generated by wine before the commit I identified, IE Help works. I also noticed when I found the patch that it was edited today to change the files that I noted above, but I can't tell if the changes address the subject of this post. I'm a real rookie when it comes to reading this patches and can suppy only information to this list. If it will help, I will be more than happy to create "diff" files from the "before and after" wine versions to help close in on the situation. Dan

2 5

Re: [Wine] Edit Windows XP registry with wines regedit?
by Saulius Krasuckas Oct. 3, 2004

Oct. 3, 2004

On Sat, 2 Oct 2004, Martin Bammer wrote: > When I remove the Enum-key under hkey_local_machine then Windows redetects all > hardware. So a reinstall would not be needed. Wine has a regedit. But I don't > know how to tell wine that it uses the registry from the installed windows. For sure it would not be needed, but as for Wines regedit I am not sure. AFAIK, it can only read NT-system registry, but not write it. > Would be a nice "recovery" feature for Linux to be able to edit windows > registries, because a defective registry is often a problem in windows... You can always try using Offline NT Password & Registry Editor. It uses console UI and is more of command line editing, but whatever [1]. BTW, you or someone else can try merging both the ntreg library [1] and Wine registry editor code to make a GUI tool to suffice your needs. I hope there would be no license [2] collisions. [1] http://home.eunet.no/~pnordahl/ntpasswd/ [2] http://home.eunet.no/~pnordahl/ntpasswd/COPYING.txt

2 1

systemparamatersw question
by Ivan Leo Puoti Oct. 3, 2004

Oct. 3, 2004

Are all SPI values in windows/sysparams.c,SystemInformationW() stored in the registry somewhere? If yes, is there a not to difficult way to find which registry key it is for a given SPI value? I have a few win boxes available to find this out. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

TIME_GetTZAsStr problem with "UTC"
by Jacek Caban Oct. 2, 2004

Oct. 2, 2004

Hi. I got this communicat: fixme:ntdll:TIME_GetTZAsStr Can't match system time zone name "UTC" to an entry in TZ_INFO fixme:ntdll:TIME_GetTZAsStr Please add appropriate entry to TZ_INFO and submit as patch to wine-patches so I wanted to send patch, but "UTC" is time convencion, not Local Time Zone. I've checked my Linux configuration: $ date sob paź 2 23:06:33 UTC 2004 It seems to be bad Linux configuration, but it's my default configuration (I use Fedora Core 2, my Local Time Zone is CEST). I think Wine should do something in this this case, but I don't know what. Any idea? Thanks, Jacek

2 1

Re: Tab control update
by Vitaliy Margolen Oct. 2, 2004

Oct. 2, 2004

Looks ok to me with few exceptions: It would be really nice to separate formatting changes from other changes. It's hard to see what's got changed and what not. >+#define MIN_ICONTAB_WIDTH 54 /* Magic number, but it works */ >+ if (icon_width > MIN_ICONTAB_WIDTH) >+ curr->rect.right += icon_width; >+ else >+ curr->rect.right += MIN_ICONTAB_WIDTH; This is wrong (see below). >"Only create a scroll control when/if we need one (like native)" Nothing got changed. It's being created when needed, and hidden when not longed used. Is there something else I missed? > Combine all Unicode/Ascii calls together I'm not sure here, but should it be based on the unicode state of the whole control rather which message got sent to it? I can see how you can send ASCII message first and then send UNICODE message which will screw things up. >+/* Since items are variable sized, cannot directly access them */ >+#define TAB_GetItem(info,i) \ >+ ((TAB_ITEM*)((LPBYTE)info->items + (i) * TAB_ITEM_SIZE(info))) If this is the case we need to store pointers in array of pointers. >+ hwTab = create_tabcontrol(0, TCIF_TEXT|TCIF_IMAGE); >+ >+ trace_tab ("Testing non fixed width no imagelist...\n"); You missed insert items with text part inside create_tabcontrol. Besides as is it's failing for me. When I change text of the first tab "Tab 123" it's changing returned width. The reason why I didn't test this is because the width of the tab depends on it's text width. Which is kind of hard to test (different fonts, different font sizes etc.). Vitaliy Margolen Friday, October 1, 2004, 8:58:23 AM, Vitaliy Margolen wrote: > Hi, > A fairly large update to the tab control. This makes it work as per > native in my app. > Regards, > Jon > +dlls/comctl32/tab.c dlls/comctl32/tests/tab.c > Items can be variable sized; use an accessor to retrieve them > Send WM_NOTIFYFORMAT/WM_QUERYUISTATE to match native messages > Only create a scroll control when/if we need one (like native) > Dump tab extra data when tracing > Pass infoPtr around instead of fetching it multiple times, store > hwnd and focus state in it too. > Calculate correct tab widths when TCS_FIXEDWIDTH is not given > Code simplifications/const correctness/formatting fixes > Add some new combinations to tests for correct tab sizes > ===== > "Don't wait for the seas to part, or messiahs to come; > Don't you sit around and waste this chance..." - Live > jon_p_griffiths(a)yahoo.com > __________________________________ > Do you Yahoo!? > Yahoo! Mail Address AutoComplete - You start. We finish. > http://promotions.yahoo.com/new_mail

1 0

Re: Tab control update
by Dimitrie O. Paun Oct. 1, 2004

Oct. 1, 2004

On Fri, Oct 01, 2004 at 07:58:23AM -0700, Jon Griffiths wrote: > Hi, > > A fairly large update to the tab control. This makes it work as per > native in my app. Nice. While you're at it (and have it fresh in your mind), can you please also provide an audit (and a list of TODOs) as per comctl 6.0? We're getting closer to having a full audit of the controls, and this one has not been audited: http://winehq.org/site/status_ui TIA, Dimi.

2 1

Re: COBJMACROS patch 3
by Dmitry Timoshkov Oct. 1, 2004

Oct. 1, 2004

"Francois Gouget" <fgouget(a)free.fr> wrote: > COBJMACROS is very C unfriendly as it requires the caller to define it > if it wants to use COM objects. The following check is much better as > it does the right thing automagically: > > #if !defined (__cplusplus) || defined(CINTERFACE) > > So for internal interface, let's use the C friendly check instead of > COBJMACROS. This way we'll have fewer '#define COBJMACROS' to sprinkle > through the code. But that change makes Wine code not compilable with SDK and Mingw headers, I don't think it's an acceptable change. -- Dmitry.

2 3