November 2004 - Wine-Devel - list.winehq.org

Is it time to delete wineinstall?
by Dan Kegel Nov. 18, 2004

Nov. 18, 2004

Is wineinstall needed anymore? README seems to indicate you can install Wine just fine without it. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

11 21

Re: dialogex resource loading on sparc
by Dmitry Timoshkov Nov. 18, 2004

Nov. 18, 2004

"Eric Frias" <efrias(a)syncad.com> wrote: > --- windows/dialog.c (.../vendor/wine/current) (revision 29312) > +++ windows/dialog.c (.../branches/wine/2004.11.16-cvs-update) (revision 29312) > @@ -378,8 +378,10 @@ > { > const WORD *p = (const WORD *)template; > > - result->style = GET_DWORD(p); p += 2; > - if (result->style == 0xffff0001) /* DIALOGEX resource */ > + WORD signature = GET_WORD(p); p++; > + WORD dlgver = GET_WORD(p); p++; This won't compile with older C compilers, you are mixing data declarations with code. -- Dmitry.

2 1

replace a wrong fixme in dlls/winmm/playsound.c
by Rémi Assailly Nov. 18, 2004

Nov. 18, 2004

I tested a software ( a monopoly game ) and the error was that a sound was still playing so I think that is not a wine bug. Before submitting this patch to wine-patches I would like to know what do you think about it, what should be WARN, FIXME, if choosing ERR to all is correct or if some cases are useless.

1 0

Re: Is it time to delete wineinstall?
by Ivan Leo Puoti Nov. 17, 2004

Nov. 17, 2004

> Besides, on the wine-users alias, new users who > install RPMs have no idea there is a config file > because the RPMs don't create it for them. The config file is meant to go ASAP, so that is a good thing. Most users use RPMs and are quite happy with them, and it causes less support hassle. > It may be a redundant feature, but "configure/ make/ > make install" is definately not a replacement for > "ease of use." ;) Then as other have said wineinstall should just contain ./configure && make && su -c 'make install' Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

profiling GTA4. question about polling
by Brian Gunlogson Nov. 17, 2004

Nov. 17, 2004

GTA4 (Grand Theft Auto: Vice City) runs on Wine with no additional tinkering! Albeit horribly slow. A profile of GTA shows that only one D3D function (drawStridedSlow) needs major optimization. According to the oprofile results, polling seems to be the major bottleneck. (the top of a flat profile generated with oprofile) samples % image name app name symbol name 2177620 14.0147 d3d8.dll.so wine-preloader drawStridedSlow 1681661 10.8228 vmlinux vmlinux do_pollfd 1025198 6.5980 vmlinux vmlinux pipe_poll 515461 3.3174 vmlinux vmlinux add_wait_queue 423342 2.7245 vmlinux vmlinux poll_freewait 423185 2.7235 vmlinux vmlinux __pollwait 354490 2.2814 vmlinux vmlinux fput 285473 1.8372 vmlinux vmlinux sys_poll I'd like to optimize this. Any hints? Brian G __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

1 0

wineprefixcreate hang
by Olive Esseret Nov. 17, 2004

Nov. 17, 2004

I do not know if this question is appropriate here; so please excuse me if it is not (I have not had any answer elsewhere) On Mdk10.1 the following command (which is called by wineprefixcreate and so also by wineinstall) never terminate. wine rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf Although this happens most of the time, it does not appears every time and did not appeard on Mdk10.0. If it is not possible to make it works, anyone has an idea on how to do the things by hands? Olive

2 3

Supported Apps
by Tom Nov. 17, 2004

Nov. 17, 2004

Hello All, Would anyone reject to the idea of changing "Tucows top" to "License" and listing the licence on the supported page? I was looking over this page and the Tucows rankings have changed, and some of the apps that we have listed are no longer in the top 100 ranking at Tucows. Tom

1 0

incomplete relay when accessed from winedbg
by Bill Medland Nov. 17, 2004

Nov. 17, 2004

Guys Any chance of help on this? I am trying to figure out why some numbers are misformatted through Crystal Reports ToText function. (e.g. 6..0 instead of 599.95) I tried to turn +relay on from within winedbg so that I could see just what functions got called. All that relay gave me was "window proc", "hook proc" and wineps calls; no ntdll or anything else. Any idea why it isn't giving me everything? (wine 20040914) -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

access PE headers in winelib shared library
by Jia L Wu Nov. 17, 2004

Nov. 17, 2004

Hi, Can somebody provide some example or information on how to access PE headers(e.g. PIMAGE_DOS_HEADER, PIMAGE_NT_HEADER) wrapped in winelib shared library(e.g. winelib dll)? Thanks a lot! Wu

3 2

appdb linux links
by James Hawkins Nov. 17, 2004

Nov. 17, 2004

One of my conceptions of wine is as a stepping stone for users switching over to linux from windows that still only feel comfortable with windows apps or those that don't know what linux apps are available. What do you think about adding a 'Similar Linux Application' link or section to each windows app where applicable that would point them in the direction of the linux equivalent of the windows app and thus help with the transition process? They might not necessarily use the app, but at least they'll be more aware. What are some ideas about this? -- James Hawkins

4 7

wineprefixcreate (and so wineinstall) hang
by Olive Esseret Nov. 17, 2004

Nov. 17, 2004

I do not know if this question is appropriate here; so please excuse me if it is not (I have not had any answer elsewhere) On Mdk10.1 and with wine-20041019 the following command (which is called by wineprefixcreate and so also by wineinstall) never terminate. wine rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf Although this happens most of the time, it does not appears every time and did not appeard on Mdk10.0 (although there does not seems to be essential differences between the two distributions) If it is not possible to make it works, anyone has an idea on how to do the things by hands? If you need more informations about my system configuration, please let me know (I have no idea what is appropriate...) Olive P.S. Please excuse if this message apperas twice; I had posted it two hours ago and it has still not appeared. __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

1 0

Winetest questions
by Dan Kegel Nov. 17, 2004

Nov. 17, 2004

1. Why are all the archived posts to wine-test-results empty? See http://www.winehq.org/hypermail/wine-tests-results/2004/11 Every message body is empty! What's up with that? 2. The URL http://test.winehq.org/data/ appears to contain digests of all winetest results received by the server, but this information is not documented anywhere I could find at www.winehq.org. Seems like a top level page is in order. 3. winetest.exe currently assumes you're running under Windows. See main.c line 577: (putenv ("WINETEST_PLATFORM=windows") || Wouldn't it be useful to allow Linux results to be computed and reported via winetest, too? Presumably it could detect that it's running on Linux somehow. (perhaps by running uname -a...) - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 5

Install OCX over wine
by Francisco Nauber Bernardo Gois Nov. 17, 2004

Nov. 17, 2004

I need install ocx file using wine.How i can do thist? Francisco Nauber Bernardo Gois Unidade de Relacionamento com Clientes Administração Financeira (SUNAF) Serviço Federal de Processamento de Dados (SERPRO) Fone: (85) 88443794

2 1

Could someone look at this simple code and explain why it doesnt work?
by luis lenders Nov. 16, 2004

Nov. 16, 2004

Hi, i found this very simple app which just pops up a window: #include <windows.h> LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) { switch (msg) { case WM_DESTROY: PostQuitMessage(0); return 0; default: return DefWindowProc(hwnd, msg, wparam, lparam); } } int WINAPI WinMain(HINSTANCE instance, HINSTANCE prev, LPSTR cmdLine, int cmdShow) { WNDCLASSEX class; MSG msg; HWND window; /* this stuff is just boilerplate */ memset(&class, 0, sizeof(WNDCLASSEX)); class.cbSize = sizeof(WNDCLASSEX); class.hInstance = instance; class.lpszClassName = "MainWnd"; class.lpfnWndProc = WndProc; class.hbrBackground = (HBRUSH) COLOR_WINDOW + 1; if (!RegisterClassEx(&class)) { MessageBox(NULL, "Could not register window class", "", MB_OK | MB_ICONERROR); return 1; } window = CreateWindowEx(0, "MainWnd", "Main Window", WS_OVERLAPPEDWINDOW & ~WS_MAXIMIZEBOX, CW_USEDEFAULT, CW_USEDEFAULT, 200, 150, NULL, NULL, instance, NULL); ShowWindow(window, cmdShow); /* Every thread that creates a window must pump the message loop */ while (GetMessage(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessage(&msg); } return 0; } Now i tried to implement this in a dll (avicap32.dll) in capCreatecapturewindow like this: /*********************************************************************** * capCreateCaptureWindowW (AVICAP32.@) */ HWND VFWAPI capCreateCaptureWindowW(LPCWSTR lpszWindowName, DWORD dwStyle, INT x, INT y, INT nWidth, INT nHeight, HWND hWnd, INT nID) { HWND ret; HINSTANCE dummy; LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) { switch (msg) { case WM_DESTROY: PostQuitMessage(0); return 0; default: return DefWindowProcW(hwnd, msg, wparam, lparam); } } int WINAPI Try(HINSTANCE instance, HINSTANCE prev, LPSTR cmdLine, int cmdShow) { WNDCLASSEXW class; MSG msg; HWND window; /* this stuff is just boilerplate */ memset(&class, 0, sizeof(WNDCLASSEXW)); class.cbSize = sizeof(WNDCLASSEXW); class.hInstance = instance; dummy=instance; class.lpszClassName = "MainWnd"; class.lpfnWndProc = WndProc; class.hbrBackground = (HBRUSH) COLOR_WINDOW + 1; if (!RegisterClassExW(&class)) { MessageBoxW(NULL, "Could not register window class", "", MB_OK | MB_ICONERROR); return 1; } window = CreateWindowExW(0, "MainWnd", "Main Window", WS_OVERLAPPEDWINDOW & ~WS_MAXIMIZEBOX, CW_USEDEFAULT, CW_USEDEFAULT, 200, 150, NULL, NULL, instance, NULL); ret=window; ShowWindow(window, cmdShow); /* Every thread that creates a window must pump the message loop */ while (GetMessageW(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessageW(&msg);} return 0; } Try(dummy,NULL,NULL,0); return ret; } Now when capcreatecapturewindow is called no window shows up at all. What did i do wrong? Greetings Robbert : ___________________________________________________________ Moving house? Beach bar in Thailand? New Wardrobe? Win £10k with Yahoo! Mail to make your dream a reality. Get Yahoo! Mail www.yahoo.co.uk/10k

2 1

GradientFill revisited
by Arjen Nienhuis Nov. 16, 2004

Nov. 16, 2004

I created a patch! Hooray! http://www.nienhuisbeheer.nl/~arjen/gradientfill.patch Does anyone have a test for this function. What is the best way to create a program to test these things? I've never written a windows program from scratch. Does anyone have a simple app, where I can insert some calls to GradientFill?

1 0

Re: Kernel 2.6.9 - Issue Found
by Dan Kegel Nov. 16, 2004

Nov. 16, 2004

I couldn't find the patch at either of the two links Jesse posted, but I did see something similar here: http://marc.theaimsgroup.com/?l=bk-commits-head&m=110048429304053&w=2 -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Re: Kernel 2.6.9 - Issue Found
by Paul Rupe Nov. 16, 2004

Nov. 16, 2004

> It doesn't seem to fix the copy protection problem. So I'm wondering a few > things. Does wine need to be patched? This new patch seems to be related to > a chunk of code added in patch #2 mentioned in the original posting. I've > tried 2.6.10-rc2 with patch #1 reversed and patch 1+3 reversed. No difference > this time. No luck with Remedy either. I tried reversing all three patches and also tried 2.6.10-rc2. Same crash as before. -- Paul Rupe <prupe(a)myrealbox.com>

2 1

Developer Cheatsheet formatting...
by Dan Kegel Nov. 15, 2004

Nov. 15, 2004

http://www.winehq.com/site/developer-cheatsheet is 1.5 times as wide as my screen in Firefox and Mozilla. Seems like it needs a bit of adjustment... -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

4 5

WINELIB Use References
by Dagan Shai Nov. 15, 2004

Nov. 15, 2004

Hi, I'm new to WINE / WINELIB. We're considering using WINELIB in order to port a commercial telephony application (service node). I would appreciate some information from someone with experience porting commercial server-side applications with WINELIB regarding the problems that arise, resources used and recommendations. Anyone that can provide such information please contact me privately. Thanks, Shai Dagan

1 0

rsaenh.dll
by Michael Jung Nov. 15, 2004

Nov. 15, 2004

Hi, the attached patch incorporates code from the public domain library LibTomCrypt (http://libtomcrypt.org) into rsaenh.dll. This allows us to get rid of the compile and run-time dependencies on OpenSSL, and - as far as I understand it - might solve some license problems for ReactOS (http://www.reactos.com:8080/pipermail/ros-general/2004-February/000706.html) It would be nice to get some comments on what remains to be done before I submit the patch to wine-patches. I renamed the implossl.[ch] (OpenSSL glue logic) files to the more neutral implglue.[ch]. How to I get diff to produce a patch that reflects this change? Greetings, Michael

1 0

How to port c++ program to linux using winelib
by Jia L Wu Nov. 15, 2004

Nov. 15, 2004

Hi, I have a win32 program written in C++. I am trying to port it to linux using winelib. The software contanis one exe file and several dll files. I would like to keep this structure when moving them to linux. That is, I still would like to generate several corresponding shared libraries (instead of statically linking all files together) in llinux and they will be loaded at the runtime. However using winelib tools(winemaker, configure, make) for shared library generation, I get unresolved symbols error. It seems that I have to write a spec file for each dll to import(and export) functions provide by other dlls. However, since they all written in c++ and what need to be imported can either be class or class method, and parameters can be class either. SO I don't know how to handle this in spec file. Beside each dll file exports many functions or classes. It would be tedious to write a lengthy spec file manually. My question is that if it is possible that linking is not invoked during shared library generation under wine (but during the runtime)? How should I do it? Thanks. Wu

4 8

"Software Engineering with Wine" tutorial
by Dan Kegel Nov. 15, 2004

Nov. 15, 2004

I'm putting together a mini-lab course on "Software Engineering with Wine". So far, it only shows how to build wine and run the conformance test, and troubleshoot common problems (in particular, the ones that caused hundreds of test failures when I ran them a couple weeks ago). It's at http://kegel.com/wine/sweng/ Comments welcome. (In particular, are there any other test suite gotchas I should tell the students about?) - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: Kernel 2.6.9
by Jerry Jenkins Nov. 15, 2004

Nov. 15, 2004

Paul Rupe wrote: > On Friday November 12 2004 11:48 am, Michael Stefaniuc wrote: > > >>Btw. does wine crash only with Remedy or does winemine crash too? > > > Most apps (winemine included) are ok. When I get home I'll try to find a > downloadable app that reproduces the problem consistently. > > Usually wine just hangs until I kill -9 everything, but this time I managed > to get a stack trace. It looks like a recursive loop: > =>1 0x7759b155 cxx_frame_handler+0x401 in msvcrt (0x77927f90) > 2 0x7759b5c3 in msvcrt (+0xb5c3) (0x77927fb4) > 3 0x77ee7be1 __wine_call_from_32_regs+0xb5 in ntdll (0x7792831c) > 4 0x7759ac79 __CxxFrameHandler+0x5 in msvcrt (0x77928358) > 5 0x77ec63b8 EXC_RtlRaiseException+0x18c in ntdll (0x779283ec) > 6 0x77edf32b raise_segv_exception+0x2f in ntdll (0x77928408) > 7 0x77ee7c50 __wine_call_from_32_restore_regs+0x0 in ntdll (0x779287d4) > ... > 90 0x77edf32b raise_segv_exception+0x2f in ntdll (0x7792f7d8) > Frames 2-7 repeat all the way down to 90. This is after a 'make clean' and > a full rebuild of Wine, btw. > > Does increasing stack size help? For example: Index: dlls/kernel/process.c =================================================================== RCS file: /var/cvs/wine/dlls/kernel/process.c,v retrieving revision 1.80 diff -u -r1.80 process.c --- dlls/kernel/process.c 30 Oct 2004 02:11:33 -0000 1.80 +++ dlls/kernel/process.c 15 Nov 2004 11:36:47 -0000 @@ -1183,7 +1183,7 @@ set_library_wargv( __wine_main_argv ); if (!build_command_line( __wine_main_wargv )) goto error; - stack_size = RtlImageNtHeader(peb->ImageBaseAddress)->OptionalHeader.SizeOfStackReserve; + stack_size = 10 * 1024 * 1024; /* allocate main thread stack */ if (!THREAD_InitStack( NtCurrentTeb(), stack_size )) goto error; __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Last-chance deactivation of MDI Child before destruction
by Dmitry Timoshkov Nov. 15, 2004

Nov. 15, 2004

"Zach Gorman" <zach(a)archetypeauction.com> wrote: > Changelog: > If, during destruction of an MDI child frame, the application > re-activates the window that is about to be destroyed, de-activate > it one last time. > > Background: > This resolves an obscure problem caused by a difference in Windows > and Wine behavior. I have an MDI MFC app in which one of the MDI > child frames forces itself to stay at the back of the Z-order by > responding to MDI Activate messages, and re-activating the old > window (yes I know this is nasty). When Wine tries to switch the > active MDI child during the active child's destruction, this causes > the about-to-be-destroyed window to become active again. Windows > will issue one last WM_MDIACTIVATE to deactivate the window that > will be destroyed in this case, but Wine won't. This patch corrects > that difference in behavior. What happens if that additional WM_MDIACTIVATE won't deactivate an MDI child either, or an app doesn't allow deactivation for some reason? Anyway, please add another MDI message test case showing what Windows does in that case because your change is not obvious at all. -- Dmitry.

2 1

Kernel 2.6.9 - Issue Found
by Jesse Allen Nov. 15, 2004

Nov. 15, 2004

Hi, For the past two weeks I've been tracking an issue that I found with kernels greater than 2.6.8 / 2.6.8.1 and wine. Starting with kernel 2.6.9-rc1, Warcraft III copy protection would not work -- ie please insert disc. I found changes to the cdrom driver in rc1. Reversing them did not work. For a while I was lost to what could have changed. Then I had an idea: search for changes that could affect the way processes run. That led me to reverse changes related to ptrace, and I found a series of patches that break Warcraft III copy protection code. Patch 1: ptrace single-stepping fix Included in 2.6.9-rc1 By Davide Libenzi? http://linux.bkbits.net:8080/linux-2.6/cset(a)1.1803.1803.144.55 This change includes a note that it could break debuggers. Reversing this change would allow War3 to work in rc1, but kernels greater than rc1 would still not work. Patch 2: make single-step into signal delivery stop in handler Included in 2.6.9-rc2 By Roland McGrath http://linux.bkbits.net:8080/linux-2.6/cset(a)1.1832.59.196 The next patch may depend on patch #2 because it is a bug-fix based on 2. Patch 3: Fix PTRACE_CONT after single-step into signal delivery Also 2.6.9-rc2 By Roland McGrath http://linux.bkbits.net:8080/linux-2.6/cset(a)1.1847 Reversing patches 1, 2, and 3 in kernels 2.6.9-rc2 and greater (through 2.6.10-rc1) will allow War3 to work. I tried 1 & 3 without 2, but it failed leading me to believe that 1 & 2 are required. I didn't try 1 & 2 alone because I think reversing 2 would require 3 reversed. All the patch changes seem to be on ptrace single-stepping. However, there is at least one ptrace single-stepping patch that seems to make no difference at all: http://linux.bkbits.net:8080/linux-2.6/cset(a)1.1803.144.70 There are other single-stepping patches for different non-i386 architectures but I have no idea on these because I don't run the others. They are meaningless for wine anyways. Now that I've identified a problem, I'm curious where else it's cropping up. Paul Rupe, could you try reversing these patches to see if this fixes your crashing problem? And how about those people having trouble with debugging? Then I guess the next step is to find out if this is a wine bug or not. If it's not, then it may be a kernel bug and we should report it to the kernel devs. Jesse

4 5

"Crystallography programs under Wine"
by Dan Kegel Nov. 15, 2004

Nov. 15, 2004

I just ran into http://www.ccp14.ac.uk/solution/wine/ which lists about ten free Windows apps used for crystalography, and how to run them under Wine. I guess these deserve an appdb entry; they don't seem to have one yet. That page describes workarounds needed to run with Wine as of about three years ago. Things may have progressed since then. For instance, the "you must rename files to have lower case" workaround no longer seems neccessary for the INDX program. I wrote the maintainer about that, haven't heard back from him yet. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: taskmodal messagebox implementation, take 3
by Ivan Leo Puoti Nov. 14, 2004

Nov. 14, 2004

> No problem. I'll give a lengthy reply in the hope it can help other folks > dealing with this sort of thing too. Well, your code works, and I've made it into a patch. I've also removed what I beleive is a useless if check from MSGBOX_OnInit(). Due to my lame webmail client you code arrived with no indentation, so in the future please attach any code you send to me. If you think the attached patch is OK I'll forward it to wine-patches. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: [D3D] Some surfaces related fixes
by Christian Costa Nov. 14, 2004

Nov. 14, 2004

Mike Hearn wrote: >On Sun, 14 Nov 2004 13:40:15 +0000, Christian Costa wrote: > > >>+ if ((pDDSD->dwFlags & DDSD_LPSURFACE) && (pDDSD->lpSurface == NULL)) { >>+ /* Frank Herbert's Dune specifies a null pointer for the surface, ignore the LPSURFACE field */ >>+ FIXME("Null surface pointer specified, ignore it!\n"); >>+ pDDSD->dwFlags &= ~DDSD_LPSURFACE; >>+ } >>+ >> >> > >Apps passing in bogus data should normally be a trace or warn at most, >unles there is actually something to fix here it doesn't make sense to use >a fixme as it'll inevitably get users asking about it .... > >thanks -mike > > > > > Your're right, Mike. :-) I will resend a patch for that. Thanks. Christian

1 0

Re: taskmodal messagebox implementation, take 3
by Juan Lang Nov. 14, 2004

Nov. 14, 2004

Hi Ivan. --- Ivan Leo Puoti <puoti(a)inwind.it> wrote: > Please consider I'm no programming wiz and I'm learning as I go along. No problem. I'll give a lengthy reply in the hope it can help other folks dealing with this sort of thing too. > Now, I don't see how else I could get MSGBOX_EnumProc() to remember the > values > of those that now are static variables, apart from using the heap for > everything, that seems a bit inefficent as we know how much data we want > to > store, or global variables, do you think I should use global ones > instead? > If not suggestions are welcome. Globals are also not thread-safe. Generally for thread safety, I'd suggest the following: declare a structure that has all the data you want to modify in MSGBOX_EnumProc, something like: struct MsgBoxEnumProcParams { int pass; int counter1; int counter2; int heapcheck; HWND *handles; }; In MessageBoxIndirectW, create one of these and pass its address as the LPARAM value to EnumThreadWindows(). However, this ignores style issues. I have problems with names like "counter1" and "counter2"; they don't tell me what they mean. Also, I don't like the magic values 0, 1, 2, 3, 4 for the LPARAM value; at the least these should be symbolic constants. Pass 3 doesn't modify the parameters at all, so it really should get its own callback function. It looks like heapcheck's purpose is to see whether handles has in fact been allocated. You could instead make sure to set handles to NULL when it isn't allocated. Also, there's the possibility of a memory leak in pass 4. I'd suggest the caller should be responsible for memory allocation. With these suggestions, I've come up with the following changes. I haven't checked whether this code works (or even compiles), it's just my attempt at rewriting what you're trying to do: struct ThreadWindows { UINT numHandles; UINT handlesLen; HWND *handles; }; BOOL CALLBACK MSGBOX_CountDisabledThreadWindows(HWND hwnd, LPARAM lParam) { if (!lParam) return FALSE; if (!IsWindowEnabled(hwnd)) *(UINT *)lParam++; return TRUE; } BOOL CALLBACK MSGBOX_EnumDisabledThreadWindows(HWND hwnd, LPARAM lParam) { if (!lParam) return FALSE; if (!IsWindowEnabled(hwnd)) { struct ThreadWindows *threadWindows = (struct ThreadWindows *)lParam; if (threadWindows->numHandles < threadWindows->handlesLen) threadWindows->handles[threadWindows->numHandles++] = hwnd; } return TRUE; } INT WINAPI MessageBoxIndirectW( LPMSGBOXPARAMSW msgbox ) { LPVOID tmplate; HRSRC hRes; int ret; UINT i; struct ThreadWindows threadWindows = { 0, 0, 0 }; static const WCHAR msg_box_res_nameW[] = { 'M','S','G','B','O','X',0 }; if (!(hRes = FindResourceExW(user32_module, (LPWSTR)RT_DIALOG, msg_box_res_nameW, msgbox->dwLanguageId))) return 0; if (!(tmplate = (LPVOID)LoadResource(user32_module, hRes))) return 0; /*handle task modal message boxes*/ if ((msgbox->dwStyle & MB_TASKMODAL) && (msgbox->hwndOwner==NULL)) { EnumThreadWindows(GetCurrentThreadId(), MSGBOX_CountDisabledThreadWindows, (LPARAM)&threadWindows.numHandles); if (threadWindows.numHandles) { threadWindows.handles = (HWND *)HeapAlloc(GetProcessHeap(), 0, threadWindows.numHandles * sizeof(HWND)); if (threadWindows.handles) threadWindows.handlesLen = threadWindows.numHandles; threadWindows.numHandles = 0; } EnumThreadWindows(GetCurrentThreadId(), MSGBOX_EnumDisabledThreadWindows, (LPARAM)&threadWindows); for (i = 0; i < threadWindows.numHandles; i++) DIALOG_DisableOwner(threadWindows.handles[i]); } ret=DialogBoxIndirectParamW(msgbox->hInstance, tmplate, msgbox->hwndOwner, MSGBOX_DlgProc, (LPARAM)msgbox); if ((msgbox->dwStyle & MB_TASKMODAL) && (msgbox->hwndOwner==NULL)) { for (i = 0; i < threadWindows.numHandles; i++) DIALOG_EnableOwner(threadWindows.handles[i]); if (threadWindows.handles) HeapFree(GetProcessHeap(), 0, threadWindows.handles); } return ret; } The changes I've made: I've renamed counter1 and counter2 to numHandles and handlesLen. handlesLen is the allocated number of handles, while numHandles is the number of handles actually stored. (Your code already dealt with the possibility of their being different: well done!) I've also used handles as its own guard; if it's NULL, it's not allocated. Otherwise it is. Like I suggested, I pass a pointer as an LPARAM to the two EnumThreadWindows callback functions. It seems two calls to EnumThreadWindows were unnecessary, since we already knew the window handles, so I just iterate over the values in handles rather than calling EnumThreadWindows again. If I'm incorrect in my understanding, of course change it. And, the caller is always responsible for memory allocation and freeing. I think this is safer than having the callback function do it. > >Any reason you aren't using HeapAlloc instead? > As this heap is only used by MSGBOX_EnumProc(), is there any reason why > I should > use HeapAlloc? It's sometimes easier to debug memory problems with the Windows heaps than with the libc ones. --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

winzip 9 doesn't run under wine :-(
by Dan Kegel Nov. 14, 2004

Nov. 14, 2004

While putting together a tutorial on how to contribute test cases to Wine (http://kegel.com/wine/sweng/) I noticed that the current version 9 of WinZip doesn't install under vanilla Wine; it aborts with the message WinZip was unable to locate a recent version of the Windows HTML help viewer, which is required to display WinZip help. ... Seems like a bit of a showstopper. What's the plan for addressing this? Is it a 0.9 feature? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 8

ListView DrawText Flags
by Zach Gorman Nov. 14, 2004

Nov. 14, 2004

Dimitrie - You have a patch back in 2002 that cleans up the listview DrawText() code in comctl32. When calling DrawText from a single-line edit control, you don't pass DT_NOPREFIX. Is this intentional, or just an oversight? My testing on Windows shows that & characters do not get converted to _ even in the single-line edit control case (indicating that DT_NOPREFIX should be passed). Thanks, Zach

2 1

Missing file names in WINEDBG
by lats Nov. 14, 2004

Nov. 14, 2004

In the last week WINEDBG has stopped outputting the file/path and linenumber of entries in the backtrace. Does anyone know what happened? Jeff

3 3

Re: taskmodal messagebox implementation, take 3
by Juan Lang Nov. 14, 2004

Nov. 14, 2004

Ivan, a couple comments on this. You wrote: +BOOL CALLBACK MSGBOX_EnumProc(HWND hwnd, LPARAM lParam) +{ + static int counter1, counter2, heapcheck=0; + static HWND *handles; static variables aren't thread safe. Two threads attempting to do task modal dialogs (yes, this is probably strange) could result in weird failures. + handles=(HWND*)malloc(counter1*sizeof(HWND)); Any reason you aren't using HeapAlloc instead? --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

dlls/commdlg/fontdlg.c regression
by Gerald Pfeifer Nov. 13, 2004

Nov. 13, 2004

The following change to dlls/commdlg/fontdlg.c revision 1.70 date: 2004/08/14 00:42:35; author: julliard; state: Exp; lines: +2 -5 Jacek Caban <jack(a)itma.pwr.wroc.pl> Fix a bug in passing parameters to CFn_WMInitDialog and CFn_WMCommand in FormatCharDlgProcW. causes the following warning with GCC 3.3.2 on FreeBSD 4.10: fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from incompatible pointer type Would you mind fixing this? Thanks, Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 3

Using a DIB to reduce number of calls to X
by Arjen Nienhuis Nov. 13, 2004

Nov. 13, 2004

GradientFill can be implemented by drawing to a DIB, and then blting that DIB to the screen. This will reduce the number of calls to X from O(n) to O(1). 1. Is that a good idea? Any caveats? 2. Can that method be used elsewhere? I'll try to implement it right away. P.S. We do implement the alpha part of GradientFill the same as Windows. The comments might sugest otherwise.

2 1

For the appdb hackers
by Ivan Leo Puoti Nov. 13, 2004

Nov. 13, 2004

It would be great if I could delete/approve apps and go to the next one without having to go back to adminAppQueue.php Thanks for the work you're doing, it was badly needed. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Kernel 2.6.9
by Paul Rupe Nov. 13, 2004

Nov. 13, 2004

Has anyone tried Wine with Linux kernel 2.6.9? I'm getting crashes with this version that don't happen when I reboot back to 2.6.8.1. I haven't had much luck debugging it so far, but each time, ps shows a <defunct> wine-preloader process and wineserver still running. -- Paul Rupe <prupe(a)myrealbox.com>

7 10

Re: ws2tcpip.h: Define socklen_t
by felix.nawothnig＠t-online.de Nov. 13, 2004

Nov. 13, 2004

On 11/13/2004 02:22:18 AM, I wrote: > We don't have socklen_t defined anywhere and that's the place where > it's defined in the official headers so... WASTE compiles fine now... > (I'm sure there is a reason why it isn't defined but I can't see it - > so tell me why this will be rejected... err... if it will be... :-) Ooops... WINE doesn't build anymore, I guess that's a good reason. :) Sorry... Anyway, what's the correct way to get socklen_t then? Would it make sense to do... #ifndef __socklen_t_defined typedef int socklen_t; # define __socklen_t_defined #endif ...or prefix it with WS() maybe? Or should I just include unistd.h in winelib apps? (Not sure if that's possible even since I'm using MSVCRT...) -flx

1 0

enhmfdrv: ExtSelectClipRgn
by Jon Griffiths Nov. 13, 2004

Nov. 13, 2004

Hi, My app gives me a FIXME from dlls/gdi/enhmetafile.c at line 1144 complaining that ExtSelectClipRgn is not implemented (and then proceeds to draw rather corrupted looking pictures). Looking at the code there is an implementation, but its been #ifdef'd out. removing the #if 0 doesn't produce any noticable change in my app. Does any one have any idea why this was removed, or what is needed to make it work? Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Checking up header files ( take 2 : mmsystem.h )
by Eric Pouech Nov. 13, 2004

Nov. 13, 2004

Rémi Assailly a écrit : > Changelog: > * set MAXERRORLENGTH to 256 > * set MMSYSERR_LASTERROR to (MMSYSERR_BASE + 20) > * set MIDIERR_LASTERROR to (MIDIERR_BASE + 7) > * add some structure tags I think it's worthless bumping the LASTERROR values if you don't add the missing error values in the .h file A+

1 0

Re: Toolbar: Cleanup Patch
by Dimitrie O. Paun Nov. 13, 2004

Nov. 13, 2004

On Mon, Nov 08, 2004 at 11:27:44AM -0600, Robert Shearman wrote: > Changelog: > - bNtfUnicode is a dup' of bUnicode so remove it and fix the few places > where it was used. bUnicode is a bad name for this flag, bNtfUnicode would be better, as bUnicode is sometimes use to denote how the text is stored in the control, which is different from how notifications should be sent. -- Dimi.

2 2

Re: Kernel 2.6.9
by Ivan Leo Puoti Nov. 13, 2004

Nov. 13, 2004

>What could possibly be different between our systems that would cause >this problem? Anything but wine and the kernel, could you try this binary package and see if it works? Like this you can find out if it's a runtime or compile time problem. http://prdownloads.sourceforge.net/wine/wine-20041019-mdk.i586.rpm?download Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Re: just a little thing in dlls/winmm/lolvldrv.c
by Bill Medland Nov. 12, 2004

Nov. 12, 2004

On November 12, 2004 12:17 pm, Rémi Assailly wrote: > Changelog: > * just replace all (sizeof(MM_MLDrvs) / sizeof(MM_MLDrvs[0]) by > MAX_MM_MLDRVS to be more readable. ( I think it is ) I think it isn't. (sizeof(a)/sizeof(a[0]) or (sizeof(a)/sizeof(*a)) is a standard statement that means "the number of elements in a". Some people make a macro such as COUNTOF(a) to make it more readable but the expanded version is quite standard. The altered version is less readable because one then has to go back to the definition of MAX_MM_MLDRVS and its uses to see that indeed it is (or at least is supposed to be) the number of elements in the array that the statements are protecting. -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

1 0

Re: Kernel 2.6.9
by Ivan Leo Puoti Nov. 12, 2004

Nov. 12, 2004

> I forgot to mention that I'm using latest wine CVS. So am I and wine works fine, on mdk 10.1 kernel 2.6.8.1-12mdk. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: Dbghelp: enhance PDB support
by Dimitrie O. Paun Nov. 12, 2004

Nov. 12, 2004

On Thu, Nov 11, 2004 at 09:25:46PM +0100, Eric Pouech wrote: > This (huge) patch does: > - apart from restructuring the code (COFF handling goes to new coff.c > file, Codeview and PDB defines and types to new mscvpdb.h file) ^^^^^^^^^ Shouldn't this be named msvcpdb.h? -- Dimi.

3 2

Tables For Standard Caption Buttons' Metrics?
by William Poetra Yoga H Nov. 12, 2004

Nov. 12, 2004

In windows/nonclient.c, the captions on caption buttons are calculated (according to the button size, which is determined by some system metrics). This is due to the fact that we don't have a replacement for the Marlett font used in Windows. But simple formulae can't reproduce the captions correctly. I've taken some screenshots of the caption buttons in Windows XP (with the classic theme, so I think the results can be reproduced in earlier versions). I think we can reproduce Windows' behavior with a table. For every value of SM_CYCAPTION, we have one table entry. This way, we can save space (the table is a lot smaller than a table of bitmaps) and still reproduce correct behavior. Anyone has comments on this? __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

2 3

Enabling gcov patch not accepted
by Aaron Arvey Nov. 12, 2004

Nov. 12, 2004

Hi, I recently sent in a patch concerning enabling gcov in wine (http://www.winehq.org/hypermail/wine-patches/2004/11/0136.html) and it doesn't seem to have been incorporated in the main cvs branch :(. I have never contributed to wine before so I'm not sure how to get feedback on my patch in order to improve it so that it is accepted. If either Alexandre or anyone else believes they know why my patch wasn't accepted, please let me know. I personally have found gcov to be very helpful and I think other developers may find that to be true too. If you would like to know more about gcov, please read the documentation included in my patch (url above). Thank you, Aaron

3 2

shreg tests on xp vs 95/98
by James Hawkins Nov. 12, 2004

Nov. 12, 2004

I've been working on figuring out the behaviour of SHQueryValueEx using XP for testing. I know that on XP SHQueryValueEx just calls SHRegGetValue, so any results from testing SHQueryValueEx match those documented about SHRegGetValue and even those not documented. What I'm wondering is if SHQueryValueEx behaves the same on other platforms ie 95/98/NT etc. If you'd like to test it, run the attached test on your platform and report the results back. Thankyou for taking the time to help figure this one out. BTW you can ignore this error for now (I'll look into it after this): shreg.c:270: Test failed: didn't open copy -- James Hawkins

1 0

Cxbx
by Dimitrie O. Paun Nov. 12, 2004

Nov. 12, 2004

Hi Folks, Willie Sippel suggested I port the Bxbx Xbox emulator to Winelib. And I did, patch attached. It seems like we need a multimon.h, any takers? More on the emulator: Home: http://www.caustik.com/cxbx/ http://sourceforge.net/projects/cxbx/ -- Dimi.

1 0

ODBC - MSSQL
by Pablo Szuster Nov. 11, 2004

Nov. 11, 2004

Hi, i´m trying to access a MSSQL server (in a windows machine in the network) from a Visual Basic Application running under wine, using an ODBC driver. Since there aren´t any MSSQL drivers for linux i decided to use de native ones, so i installed mdac_typ.exe . Then i configured the DSN using odbcad32.exe but when i tested the connection (configured using tcp/ip) an error message appeared ("[Microsoft][ODBC SQL Server Driver][TCP/IP Sockets] General network error. Check your network documentation"). Do i have to install some network drivers for wine?? Has anyone been able to connect to a MSSQL server remotely using odbc under wine?? __________________________________________________ Todavía no tenés tu Ciudad Internet Mail? Obtenelo ahora! - http://webmail.ciudad.com.ar Descargá Gratis el nuevo Internet Explorer 6.0, el mejor software para actualizar tu PC. http://www.ciudad.com.ar/ar/servicios/ie/

2 1

How difficult would it be to make the equivalent of Windows Terminal Server with Wine?
by Andrew Quigley Nov. 11, 2004

Nov. 11, 2004

What I would like to be able to deploy would be a system which runs multiple Win32 compatible desktops and multiple logins on a server, with the clients accessing the desktops via RDP or ICA protocols. How many of the pieces required to accomplish that already exist, and what pieces have yet to be built? A quick search on freshmeat shows me a few different rdp clients, so it looks like the protocol spec is known. What would be involved in creating a RDP server that shows up as a video driver as far as the win32 programs are concerned?

7 9

wine notes & /etc/resolv.conf
by Grant Williamson Nov. 11, 2004

Nov. 11, 2004

Hi, is there a patch anywhere, which will allow wine to reread the /etc/resolv.conf file. i.e. application lotus notes a) start notes whilst connected to home network. /etc/resolv.conf gets populated by home dhcp server b) start vpn connection to work /etc/resolv.conf gets populated with extra name servers c) try and connect to work notes, server fails, as it cannot resolve named address If you start notes after the vpn connection is started, then /etc/resolv if correctly populated and the problem does not occur. Same issue happens when u suspend your machine and start in a different location. Does anyone have a patch or know how to get wine to reread /etc/resolv.conf periodically? Grant.

4 3

Re: Fix For Window Caption
by William Poetra Yoga H Nov. 11, 2004

Nov. 11, 2004

--- William Poetra Yoga H <williampoetra(a)yahoo.com> wrote: > This fixes the bounding rectangle of the window caption. > > William > > Same as the one for the caption buttons, what needs to be improved for this patch? I meant to make the caption (text) bounding box smaller a bit so the text doesn't overflow over the caption buttons. And, this patch is somewhat related to the caption buttons patch, though not so closely, so I sent it as a separate patch. __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Fix For Caption Buttons
by William Poetra Yoga H Nov. 11, 2004

Nov. 11, 2004

--- William Poetra Yoga H <williampoetra(a)yahoo.com> wrote: > This patch fixes the size and position of caption buttons (they were too > big). > > William > This patch wasn't committed. Anyone would like to point out to me something wrong with the patch? __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Fix For Menu Bar (resend)
by Alexandre Julliard Nov. 11, 2004

Nov. 11, 2004

William Poetra Yoga H <williampoetra(a)yahoo.com> writes: > Index: dlls/user/menu.c > =================================================================== > RCS file: /home/wine/wine/dlls/user/menu.c,v > retrieving revision 1.8 > diff -u -r1.8 menu.c > --- dlls/user/menu.c 8 Nov 2004 22:12:42 -0000 1.8 > +++ dlls/user/menu.c 9 Nov 2004 14:26:09 -0000 > @@ -1441,8 +1441,6 @@ > if (lppop->Height == 0) > MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd); > > - lprect->bottom = lprect->top + lppop->Height; > - This doesn't look right at all, you cannot simply ignore the computed size of the menu bar, this is going to break owner drawn menus. -- Alexandre Julliard julliard(a)winehq.org

4 4

re: Latent memory corruption bug in widl, with workaround
by Dan Kegel Nov. 11, 2004

Nov. 11, 2004

Here's the exact workaround, in case anyone runs into that crash again. I dare the author of widl to run it under valgrind :-) diff -Naur wine.orig/tools/widl/parser.l wine/tools/widl/parser.l --- wine.orig/tools/widl/parser.l Mon Oct 4 19:14:54 2004 +++ wine/tools/widl/parser.l Wed Nov 10 00:28:37 2004 @@ -123,7 +123,7 @@ yyerror("Malformed '#...' line-directive; missing terminating \""); *cptr = '\0'; line_number = lineno - 1; /* We didn't read the newline */ - free( input_name ); + //free( input_name ); input_name = xstrdup(fname); } \" yy_push_state(QUOTE); cbufidx = 0; -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: Fix For Menu Bar (resend)
by Ivan Leo Puoti Nov. 11, 2004

Nov. 11, 2004

> I know this sounds a bit unethical (maybe impolite would be a better word), but > for practical reasons I think this is permittable. Or maybe I should > specifically state (at wine-patches) that I "allow anyone else to fix the patch > should it contain errors, and resubmit it"? If you licence the patch for inclusion with wine, you licence it under the LGPL, that does allow this, as it's free software. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Ekush
by Ivan Leo Puoti Nov. 11, 2004

Nov. 11, 2004

> Ekush (http://www.ekush.com) published some binaries. At time of writing the hoster has taken them down. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: [AppDB] apidb_fullurl() does not act as expected...
by Jeremy Newman Nov. 10, 2004

Nov. 10, 2004

No this will not work. You need to keep the paths relative. Do not use full URLs as then if you have a development/test server running, it will take you back to the production site. If you look at index.php, there is an include("path.php"), which defines the static BASE. If you always inclide path.php from the cwd, your scripts will get BASE, and you can use that for the relative path. On Tue, 2004-11-09 at 19:33 -0700, Tony Lambregts wrote: > apidb_fullurl() does not give the Full URL go figure.. > > Change log: fix up the notify for add and delete comment so it gives a proper back link > > files changed: addcomment.php > deletecomment.php > include/incl.php > > Index: addcomment.php > =================================================================== > RCS file: /home/wine/appdb/addcomment.php,v > retrieving revision 1.2 > diff -u -r1.2 addcomment.php > --- addcomment.php 9 Nov 2004 22:42:12 -0000 1.2 > +++ addcomment.php 10 Nov 2004 02:15:50 -0000 > @@ -49,7 +49,7 @@ > if($email) > { > $fullAppName = "Application: ".lookupAppName($appId)." Version: ".lookupVersionName($appId, $versionId); > - $ms .= apidb_fullurl("appview.php?appId=$appId&versionId=$versionId")."\n"; > + $ms .= APPDB_ROOT."appview.php?appId=$appId&versionId=$versionId"."\n"; > $ms .= "\n"; > $ms .= ($current->username ? $current->username : "Anonymous")." added comment to ".$fullAppName."\n"; > $ms .= "\n"; > Index: deletecomment.php > =================================================================== > RCS file: /home/wine/appdb/deletecomment.php,v > retrieving revision 1.3 > diff -u -r1.3 deletecomment.php > --- deletecomment.php 9 Nov 2004 22:42:12 -0000 1.3 > +++ deletecomment.php 10 Nov 2004 02:15:50 -0000 > @@ -65,7 +65,7 @@ > if($email) > { > $fullAppName = "Application: ".lookupAppName($appId)." Version: ".lookupVersionName($appId, $versionId); > - $ms .= apidb_fullurl("appview.php?appId=$appId&versionId=$versionId")."\n"; > + $ms .= APPDB_ROOT."appview.php?appId=$appId&versionId=$versionId"."\n"; > $ms .= "\n"; > $ms .= ($current->username ? $current->username : "Anonymous")." deleted comment from ".$fullAppName."\n"; > $ms .= "\n"; > Index: include/incl.php > =================================================================== > RCS file: /home/wine/appdb/include/incl.php,v > retrieving revision 1.3 > diff -u -r1.3 incl.php > --- include/incl.php 9 Nov 2004 22:42:13 -0000 1.3 > +++ include/incl.php 10 Nov 2004 02:15:51 -0000 > @@ -241,6 +241,7 @@ > define("STANDARD_NOTIFY_FOOTER","------- You are receiving this mail because: -------\n". > "You are an maintainer of this app or an appdb administrator\n". > "to change your preverences go to: http://appdb.winehq.org/preferences.php\n"); > +define("APPDB_ROOT", "http://appdb.winehq.org/"); > > > ?> > >

2 1

FW: [dx9-12 next try] SetStreamSource changes
by Ann and Jason Edmeades Nov. 10, 2004

Nov. 10, 2004

Was there a problem with this one - Its really holding me up with progress, so I need to ensure I resolve any issues asap. Thanks Jason -----Original Message----- From: Ann and Jason Edmeades [mailto:us(a)the-edmeades.demon.co.uk] Sent: 06 November 2004 21:52 To: 'wine-patches(a)winehq.org' Subject: [dx9-12 next try] SetStreamSource changes This makes the change as per my previous note - Any better? >When I call addref the wined3dvb interface, I addref on the d3dvb >interface, and similarly on release, I release the d3d interface >from release on the wined3dvb? Let me know if there are any problems Changelog - Implement SetStreamSource - Ensure wined3d objects maintain a reference count of at least that of the d3dx version Jason

1 0

[setupx_main.c] SETUPX_CreateStandardLDDs: question about a FIXME
by Fabrice Ménard Nov. 10, 2004

Nov. 10, 2004

Hi, In setupapi/setupx_main.c, function SETUPX_CreateStandardLDDs: There is a FIXME("LDID_SRCPATH: what exactly do we have to do here ?\n"). It concerns the registry value: SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Setup\\SourcePath. AFAIK, this value defines the location where the setup of windows was done. As we don't have a real windows installation, this key is naturally not set. I'm wondering if it will hurt to set it to a fallback string (maybe the most common one: "D:\\") and get rid of this FIXME. I think if a windows application need this value and don't find what it wants, it justs throw a message box asking for the correct CD (in fact it is very common to have this value set to a wrong path when you have more than one CD device). I know it is not so important, but I really enjoy having one less FIXME :-)) If you're ok with that, I'll send a tiny patch Fabrice Ménard menard.fabrice(a)wanadoo.fr

1 0

Ekush
by Ge van Geldorp Nov. 10, 2004

Nov. 10, 2004

> From: Ge van Geldorp > > Ekush (http://www.ekush.com) published some binaries. > Surprise, surprise, it looks like ReactOS very much (Check > e.g. the radio buttons on the "Accept License" screen during > 2nd stage setup). > Some string searching in their binaries reveals: > > $ strings -a ver.dll | grep ReactOS > OS2 Images not supported under ReactOS at this time. Shortly after I sent this email to ros-dev yesterday the Ekush website went down. Today they are back, with a slightly changed set of binaries. The strings I reported yesterday are gone now (well, except for the CcRosInitializeFileCache and CcRosReleaseFileCache exports from NTOSKRNL, maybe changing the name of an exported symbol was too difficult???). There's still plenty of other evidence of the ReactOS heritage though. I guess since I only reported about ReactOS they forgot to remove the references to Wine (except ofcourse the copyright notices, those are gone). This pisses me off bigtime. I can only explain it as a deliberate attempt to use the work of Qemu, FreeType, Wine and ReactOS without giving credit. Gé van Geldorp.

2 1

Latent memory corruption bug in widl, with workaround
by Dan Kegel Nov. 10, 2004

Nov. 10, 2004

I ran into the error Oops, segment violation while running make to build wine from cvs. It failed on the command ../tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include -h -H ocidl.h ../../wine/include/ocidl.idl Turning on logging showed that it happened while processing an import statement. Running under valgrind yielded output like this: ==10699== Invalid read of size 1 ==10699== at 0x4002273E: strlen (mac_replace_strmem.c:164) ==10699== by 0x805E0D1: pp_xstrdup (../../../wine/libs/wpp/preproc.c:108) ==10699== by 0x805E7B2: pp_add_define (../../../wine/libs/wpp/preproc.c:231) ==10699== by 0x805FB21: add_cmdline_defines (../../../wine/libs/wpp/wpp.c:48) ==10699== Address 0x41233334 is 0 bytes inside a block of size 29 free'd ==10699== at 0x40029961: free (vg_replace_malloc.c:231) ==10699== by 0x805B9B6: yylex (../../../wine/tools/widl/parser.l:126) ==10699== by 0x80548B3: yyparse (/usr/share/bison/bison.simple:573) ==10699== by 0x8054295: main (../../../wine/tools/widl/widl.c:265) Commenting out the free on line 126 of widl/parser.l solved the problem. Uncommenting it and building again, I couldn't reproduce the original crash, but running under valgrind revealed the problem was still there, just hidden. I tried tracing through why the free on line 126 of widl/parser.l was bad, but it was too late, and I was too tired. Can somebody else have a look? It was quite annoying to be dead in the water, unable to build wine... Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [lostwages] developer cheatsheet
by Jeremy Newman Nov. 10, 2004

Nov. 10, 2004

Added this. The text in the <code> tag on line 78 is long. It needs a line break or something. And I fixed the url in documentation template. Otherwise it looks fine to me. On Fri, 2004-11-05 at 19:00 +0000, Mike Hearn wrote: > Add a developer getting started guide to the website. Hack to your > satisfaction, I probably did it totally wrong ;)

1 0

Thanks
by Frank v Waveren Nov. 9, 2004

Nov. 9, 2004

I felt nostalgic for starcraft today, so for fun and kicks decided to see if wine was up to the task. Not only did it run, it worked perfectly, using RandR and everything. Very impressive, thanks for the wonderful work everyone! -- Frank v Waveren Fingerprint: 9106 FD0D fvw(a)[var.cx|stack.nl] ICQ#10074100 D6D9 3E7D FAF0 92D1 Public key: hkp://wwwkeys.pgp.net/8D54EB90 3931 90D6 8D54 EB90

1 0

Re: dlls/rsaenh/rsaenh.c
by Alexandre Julliard Nov. 9, 2004

Nov. 9, 2004

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > Changelog: > CPAcquireContext: Set last error to ERROR_SUCCESS in case of success. There are very few functions that set last error on success, do you have a test demonstrating that Windows does it in this case? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: drive detection and driveui rewrite
by Alexandre Julliard Nov. 9, 2004

Nov. 9, 2004

Mike Hearn <mike(a)navi.cx> writes: > final part of winecfg work from september > > - Add drive detection and clean up the drive configuration code/UI It doesn't build, you probably forgot some files. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: implement dbghelp's C++ name undecoration on top of msvcrt's
by Eric Pouech Nov. 9, 2004

Nov. 9, 2004

Eric Pouech a écrit : > see Changelog for the details > A+ with the patch this time. A+

2 1

Re: Convert the COLORREF to a real colour for ExtTextOut
by Alexandre Julliard Nov. 9, 2004

Nov. 9, 2004

Glenn Wurster <gwurster(a)scs.carleton.ca> writes: > Index: dlls/x11drv/xrender.c > =================================================================== > RCS file: /home/wine/wine/dlls/x11drv/xrender.c,v > retrieving revision 1.48 > diff -u -r1.48 xrender.c > --- dlls/x11drv/xrender.c 27 Oct 2004 00:43:50 -0000 1.48 > +++ dlls/x11drv/xrender.c 8 Nov 2004 03:54:51 -0000 > @@ -1019,6 +1019,11 @@ > UINT align = GetTextAlign( hdc ); > COLORREF textColor = GetTextColor( hdc ); > > + textColor = X11DRV_PALETTE_ToPhysical( physDev, textColor ); > + textColor = ((textColor & 0xFF0000) >> 16) | > + (textColor & 0xFF00) | > + ((textColor & 0xFF) << 16); > + That color swapping looks very suspicious, you shouldn't need anything like that. And actually it seems to me you should simply be able to use physDev->textPixel instead, but maybe I'm missing something. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: fix delete_key in shlwapi/shreg test
by Bill Medland Nov. 9, 2004

Nov. 9, 2004

On November 9, 2004 12:10 am, James Hawkins wrote: > oops one-letter typo. This is the correct version. > > On Tue, 9 Nov 2004 01:46:50 -0500, James Hawkins <truiken(a)gmail.com> wrote: > > the previous implementation of delete_key only deleted subkeys of a > > requested key to delete. this fixes that and also fixes test failures > > that crop up in advapi32/registry because of extraneous keys in > > Software\Wine\Test. > > > > Changelog > > * fix implementation of delete_key for shreg test Alternatively couldn't we just call SHDeleteKey, now it has been fixed. > > > > -- > > James Hawkins

3 4

[rsaenh] compilation problem
by Fabrice Ménard Nov. 9, 2004

Nov. 9, 2004

Hi, I'd like to know wich version of openssl is used for rsaenh.dll. With openssl 0.9.6g, I can't compile rsaenh because of name clashs. For example where "DES_*" is used I've got "des_*"equivalent. Moreover, I don't have for example RSAPrivateKey_dup. If it's really a version problem, I think we should check that with autoconf. regards, -- Fabrice Ménard menard.fabrice(a)wanadoo.fr

2 1

Miscellaneous UI Fixes
by William Poetra Yoga H Nov. 9, 2004

Nov. 9, 2004

OK, this is the first time I'm sending a patch as plaintext (I figured out I have to use .txt as the extension, otherwise it's sent as a normal attachment). I don't know if this method of sending works correctly so please try it and let me know. This patch fixes a number of things: 1. System menu icon (fix size and position) 2. Caption buttons (fix size and position) 3. Window caption (fix bounding rectangle) 4. Menu bar (fix size) 5. Popup menu (fix distance) By the way, I have this kind of code in my patch (I wrote this code, the original one doesn't look like this): rect.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; Is it OK to write so? What I mean by the code is, the size of the button is (GetSystemMetrics(SM_CXSIZE) - 2), and there's a 2-pixel space to the right of the button. Or should I just write: rect.right -= GetSystemMetrics(SM_CXSIZE); Which doesn't deliver the message clearly but is simpler. I have tested the patch against theForger's tutorial (I compared the screenshots to the actual apps running on my machine) and it doesn't generate new errors, although some things aren't fixed yet: 1. Popup menu items are still a bit (one pixel) taller than those in Windows. For this one I think I really need help. 2. Caption buttons' captions are still the old ones. I'll try to fix these after this patch is committed. 3. Caption bar is still single-color. I'll fix this after this patch, because it will intersect with this patch and possibly make an unclean patch, in the end the two gets messy and never gets committed. I haven't sent this to wine-patches yet. How should I do it? I mean, should I send it all at once (the two files), or one file per message, or one file per item (of the 5 items fixed, above)? I'm not sure (I've read the docs). Reasons for sending the patch: 1. all at once: the patches are a group of related fixes (as said in the website). 2. one file per message: I don't know :-P 3. one file per item: it's one fix per patch (as said in the website) I prefer #1, but is it OK actually? Comments, Alexandre? Guys? Gals? __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com Index: dlls/user/menu.c =================================================================== RCS file: /home/wine/wine/dlls/user/menu.c,v retrieving revision 1.7 diff -u -r1.7 menu.c --- dlls/user/menu.c 19 Oct 2004 21:10:17 -0000 1.7 +++ dlls/user/menu.c 7 Nov 2004 04:47:47 -0000 @@ -978,7 +978,7 @@ { lpitem = &lppop->items[start]; orgX = maxX; - orgY = 2; + orgY = 3; maxTab = maxTabWidth = 0; @@ -1043,7 +1043,7 @@ lprect->left, lprect->top, lprect->right, lprect->bottom); lppop->Width = lprect->right - lprect->left; lppop->Height = 0; - maxY = lprect->top+1; + maxY = lprect->top; start = 0; helpPos = -1; while (start < lppop->nItems) @@ -1077,7 +1077,7 @@ while (start < i) lppop->items[start++].rect.bottom = maxY; } - lprect->bottom = maxY; + lprect->bottom = maxY + 1; lppop->Height = lprect->bottom - lprect->top; /* Flush right all items between the MF_RIGHTJUSTIFY and */ @@ -1431,7 +1431,7 @@ lppop = MENU_GetMenu( hMenu ); if (lppop == NULL || lprect == NULL) { - return GetSystemMetrics(SM_CYMENU); + return GetSystemMetrics(SM_CYMENU) + 1; } if (suppress_draw) @@ -1441,8 +1441,6 @@ if (lppop->Height == 0) MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd); - lprect->bottom = lprect->top + lppop->Height; - if (hfontOld) SelectObject( hDC, hfontOld); return lppop->Height; } @@ -3765,7 +3763,7 @@ lppop = MENU_GetMenu( hMenu ); if (lppop == NULL || lprect == NULL) { - retvalue = GetSystemMetrics(SM_CYMENU); + retvalue = GetSystemMetrics(SM_CYMENU) + 1; goto END; } @@ -3776,17 +3774,17 @@ if (lppop->Height == 0) MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd); - lprect->bottom = lprect->top + lppop->Height; - FillRect(hDC, lprect, GetSysColorBrush(COLOR_MENU) ); +#if 0 SelectObject( hDC, SYSCOLOR_GetPen(COLOR_3DFACE)); MoveToEx( hDC, lprect->left, lprect->bottom, NULL ); LineTo( hDC, lprect->right, lprect->bottom ); +#endif if (lppop->nItems == 0) { - retvalue = GetSystemMetrics(SM_CYMENU); + retvalue = GetSystemMetrics(SM_CYMENU) + 1; goto END; } Index: windows/nonclient.c =================================================================== RCS file: /home/wine/wine/windows/nonclient.c,v retrieving revision 1.126 diff -u -r1.126 nonclient.c --- windows/nonclient.c 19 Oct 2004 22:54:24 -0000 1.126 +++ windows/nonclient.c 7 Nov 2004 04:56:16 -0000 @@ -400,7 +400,7 @@ winRect->top += MENU_GetMenuBarHeight( hwnd, winRect->right - winRect->left, - -tmpRect.left, -tmpRect.top ) + 1; + -tmpRect.left, -tmpRect.top ); } SetRect(&tmpRect, 0, 0, 0, 0); @@ -655,9 +655,9 @@ { RECT rect; NC_GetInsideRect( hwnd, &rect ); - DrawIconEx (hdc, rect.left + 1, rect.top + 1, hIcon, - GetSystemMetrics(SM_CXSIZE) - 1, - GetSystemMetrics(SM_CYSIZE) - 1, 0, 0, DI_NORMAL); + DrawIconEx (hdc, rect.left + 2, rect.top + 1, hIcon, + GetSystemMetrics(SM_CXSMICON), + GetSystemMetrics(SM_CYSMICON), 0, 0, DI_NORMAL); } return (hIcon != 0); } @@ -682,21 +682,21 @@ /* A tool window has a smaller Close button */ if (GetWindowLongA( hwnd, GWL_EXSTYLE ) & WS_EX_TOOLWINDOW) { - INT iBmpHeight = 11; /* Windows does not use SM_CXSMSIZE and SM_CYSMSIZE */ - INT iBmpWidth = 11; /* it uses 11x11 for the close button in tool window */ - INT iCaptionHeight = GetSystemMetrics(SM_CYSMCAPTION); + INT iCaptionHeight = GetSystemMetrics(SM_CYSMCAPTION) - 1; + INT iBmpHeight = iCaptionHeight - 4; + INT iBmpWidth = iCaptionHeight - 5; - rect.top = rect.top + (iCaptionHeight - 1 - iBmpHeight) / 2; - rect.left = rect.right - (iCaptionHeight + 1 + iBmpWidth) / 2; + rect.top += 2; + rect.right -= 2; rect.bottom = rect.top + iBmpHeight; - rect.right = rect.left + iBmpWidth; + rect.left = rect.right - iBmpWidth; } else { - rect.left = rect.right - GetSystemMetrics(SM_CXSIZE) - 1; - rect.bottom = rect.top + GetSystemMetrics(SM_CYSIZE) - 1; rect.top += 2; rect.right -= 2; + rect.bottom = rect.top + (GetSystemMetrics(SM_CYSIZE) - 4); + rect.left = rect.right - (GetSystemMetrics(SM_CXSIZE) - 2); } DrawFrameControl( hdc, &rect, DFC_CAPTION, (DFCS_CAPTIONCLOSE | @@ -722,12 +722,12 @@ flags = IsZoomed(hwnd) ? DFCS_CAPTIONRESTORE : DFCS_CAPTIONMAX; NC_GetInsideRect( hwnd, &rect ); - if (GetWindowLongA( hwnd, GWL_STYLE) & WS_SYSMENU) - rect.right -= GetSystemMetrics(SM_CXSIZE) + 1; - rect.left = rect.right - GetSystemMetrics(SM_CXSIZE); - rect.bottom = rect.top + GetSystemMetrics(SM_CYSIZE) - 1; rect.top += 2; + if (GetWindowLongA( hwnd, GWL_STYLE) & WS_SYSMENU) + rect.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; rect.right -= 2; + rect.bottom = rect.top + (GetSystemMetrics(SM_CYSIZE) - 4); + rect.left = rect.right - (GetSystemMetrics(SM_CXSIZE) - 2); if (down) flags |= DFCS_PUSHED; if (bGrayed) flags |= DFCS_INACTIVE; DrawFrameControl( hdc, &rect, DFC_CAPTION, flags ); @@ -750,14 +750,14 @@ return; NC_GetInsideRect( hwnd, &rect ); + rect.top += 2; if (style & WS_SYSMENU) - rect.right -= GetSystemMetrics(SM_CXSIZE) + 1; + rect.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; + rect.right -= 2; if (style & (WS_MAXIMIZEBOX|WS_MINIMIZEBOX)) rect.right -= GetSystemMetrics(SM_CXSIZE) - 2; - rect.left = rect.right - GetSystemMetrics(SM_CXSIZE); - rect.bottom = rect.top + GetSystemMetrics(SM_CYSIZE) - 1; - rect.top += 2; - rect.right -= 2; + rect.left = rect.right - (GetSystemMetrics(SM_CXSIZE) - 2); + rect.bottom = rect.top + (GetSystemMetrics(SM_CYSIZE) - 4); if (down) flags |= DFCS_PUSHED; if (bGrayed) flags |= DFCS_INACTIVE; DrawFrameControl( hdc, &rect, DFC_CAPTION, flags ); @@ -871,7 +871,7 @@ if ((style & WS_SYSMENU) && !(exStyle & WS_EX_TOOLWINDOW)) { if (NC_DrawSysButton (hwnd, hdc, FALSE)) - r.left += GetSystemMetrics(SM_CYCAPTION) - 1; + r.left += GetSystemMetrics(SM_CXSMICON) + 2; } if (style & WS_SYSMENU) @@ -885,18 +885,22 @@ /* Draw a grayed close button if disabled and a normal one if SC_CLOSE is not there */ NC_DrawCloseButton (hwnd, hdc, FALSE, ((((state & MF_DISABLED) || (state & MF_GRAYED))) && (state != 0xFFFFFFFF))); - r.right -= GetSystemMetrics(SM_CYCAPTION) - 1; + r.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; if ((style & WS_MAXIMIZEBOX) || (style & WS_MINIMIZEBOX)) { + /* There's a 2-pixel space between Maximize and Close buttons */ + + r.right -= 2; + /* In win95 the two buttons are always there */ /* But if the menu item is not in the menu they're disabled*/ NC_DrawMaxButton( hwnd, hdc, FALSE, (!(style & WS_MAXIMIZEBOX))); - r.right -= GetSystemMetrics(SM_CXSIZE) + 1; + r.right -= GetSystemMetrics(SM_CXSIZE) - 2; NC_DrawMinButton( hwnd, hdc, FALSE, (!(style & WS_MINIMIZEBOX))); - r.right -= GetSystemMetrics(SM_CXSIZE) + 1; + r.right -= GetSystemMetrics(SM_CXSIZE) - 2; } } @@ -915,6 +919,7 @@ else SetTextColor( hdc, GetSysColor( COLOR_INACTIVECAPTIONTEXT ) ); SetBkMode( hdc, TRANSPARENT ); r.left += 2; + r.right -= 2; DrawTextW( hdc, buffer, -1, &r, DT_SINGLELINE | DT_VCENTER | DT_NOPREFIX | DT_LEFT ); DeleteObject (SelectObject (hdc, hOldFont)); @@ -1010,12 +1015,12 @@ { RECT r = rect; if (dwExStyle & WS_EX_TOOLWINDOW) { - r.bottom = rect.top + GetSystemMetrics(SM_CYSMCAPTION); rect.top += GetSystemMetrics(SM_CYSMCAPTION); + r.bottom = rect.top; } else { - r.bottom = rect.top + GetSystemMetrics(SM_CYCAPTION); rect.top += GetSystemMetrics(SM_CYCAPTION); + r.bottom = rect.top; } if( !clip || IntersectRect( &rfuzz, &r, &rectClip ) ) NC_DrawCaption(hdc, &r, hwnd, dwStyle, dwExStyle, active); @@ -1029,7 +1034,7 @@ TRACE("Calling DrawMenuBar with rect (%ld, %ld)-(%ld, %ld)\n", r.left, r.top, r.right, r.bottom); - rect.top += MENU_DrawMenuBar( hdc, &r, hwnd, suppress_menupaint ) + 1; + rect.top += MENU_DrawMenuBar( hdc, &r, hwnd, suppress_menupaint ); } TRACE("After MenuBar, rect is (%ld, %ld)-(%ld, %ld).\n",

5 8

Re: [shellpath.c] Taking into account the profile value set in wine config file
by Juan Lang Nov. 9, 2004

Nov. 9, 2004

You've exposed some softness in my thinking in this patch. Like I mentioned in the comments for it, _SHExpandEnvironmentVariables exists because the environment isn't actually set up during wine install time. I didn't think to look up the values in the registry. I also didn't register some of the "environment" variables that I use, and probably should have. You might rewrite it just to look at the registry. You probably want to look in HKLM\System\Current Control Set\Session Manager\Environment if the value you're looking for isn't in HKCU, and some variables should probably not be overridable in HKCU either (SystemRoot, for example). --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

3 5

Re: [Fwd: Re: dlls/winmm/tests/capture.c - yes, we can open a device in 2MHz...]
by Robert Reif Nov. 9, 2004

Nov. 9, 2004

> > > How about this? > > > > regards, > Jakob > How about starting a blacklist framework. You could have a table with the function that fails and some caps info that identifies the driver. I would suspect that there is more than one buggy driver out there. You could then just add it's info to the table when it is found. You could then do: if (!inBlacklist(WAVE_IN_OPEN, &capsA)) { // do the test ... } else trace("blacklisted ..... \n"); There are modems that do strange things and the Remote Desktop Protocol driver and other third party sound rerouting pseudo drivers also do strange things. These will need to be added someday also. This could become a real maintenance nightmare if not done properly from the start.

2 1

Blocking automatic debugger launch
by Kenneth Porter Nov. 9, 2004

Nov. 9, 2004

I've got an app that seems to be crashing during shutdown. (Tribes Vengeance dedicated server) I'm running it detached inside a screen session, and I don't want the debugger to automatically launch when the app crashes. I just want the thing to die when I send it a "quit" command. Currently I've hacked the registry setting and changed the debugger name to "true". Is there a cleaner way to accomplish this?

4 4

Re: dlls/winmm/tests/capture.c - yes, we can open a device in 2MHz...
by Robert Reif Nov. 9, 2004

Nov. 9, 2004

Jakob Eriksson wrote: > > > As shown by: > http://test.winehq.org/data/200411021000/2000_IDWASEMPTY_1/winmm:capture.txt > > > capture.c:571:found 1 WaveIn devices > capture.c:302: 0: "Avance AC'97 Audio" > (\\?\pci#ven_1106&dev_3059&subsys_00000000&rev_10#3&61aaa01&0&8d#{6994ad04-93ef-11d0-a3cc-00a0c9223196}\wave) > 5.0 (1:101) > capture.c:305: channels=65535 formats=00fff > capture.c:364: Test failed: waveInOpen(0): opening the device with 2 > MHz sample rate should fail: rc=MMSYSERR_NOERROR(The specified > command was carried out.) That's a driver bug.

5 9

Update to flymake patch
by Mike Hearn Nov. 8, 2004

Nov. 8, 2004

This adds support for the lovely flymake-mode, which compiles C as you write it in the background and highlights errors and warnings. It's an update to the patch I sent in about a year ago. Since then GNU Emacs has changed (in cvs) so I've attached the version of flymake-mode you need to make it all work. Not expecting this to get merged so it goes to wine-devel.

1 0

registry test incorrect for xp
by James Hawkins Nov. 8, 2004

Nov. 8, 2004

I just completed building the wine conformance tests with Visual Studio .NET. When I ran the advapi32/security tests, there were 28 failures (compiled and tested on XP). The first error I looked at is: registry.c:93: Test failed: data_count set to 24 instead of 7 Looking at registry.c, this test calls RegEnumValue with an output data buffer that is too small, LONG RegEnumValue( HKEY hKey, DWORD dwIndex, LPTSTR lpValueName, LPDWORD lpcValueName, LPDWORD lpReserved, LPDWORD lpType, LPBYTE lpData, LPDWORD lpcbData ); so the lpcbData should contain the required size of the buffer on return. hKey is initialized to HKCU\Software\Wine\Test and dwIndex is 0, so we're reading this: Name: Test1 Type: REG_EXPAND_SZ Data: %LONGSYSTEMVAR%\subdir1 The current test expects RegEnumValue to expand the environment variable %LONGSYSTEMVAR%, leaving nothing since the variable doesn't exist. If this were the case then lpcbData would return the length of 'subdir1' which is 7, which is what the test expects, but testing shows that even though the type is REG_EXPAND_SZ, RegEnumValue does not expand the environment variable, so lpcbData contains the length of %LONGSYSTEMVAR%\subdir1 which is 24, and which is what is returned when called with XP. This is further clarified by msdn docs, "Your application should call ExpandEnvironmentStrings before attempting to read the value of a REG_EXPAND_SZ registry data type." http://msdn.microsoft.com/library/default.asp?url=/library/en-us/apcompat/a… While it never says that RegEnumValue doesn't expand REG_EXPAND_SZ, this evidence shows that this is the case. If anyone has any thoughts on this, please let me know. Otherwise I will be sending a patch that fixes this test and then checking the test in wine to see if our RegEnumValue needs to be fixed as well. -- James Hawkins

1 1

150 test failures. advapi32 test crashes.
by Dan Kegel Nov. 8, 2004

Nov. 8, 2004

Hey folks, I pulled down sources from CVS this morning, and tried running the regression tests. There are about 150 failures. Here's a summary: $ grep "Test failed" log | sed 's/:.*//' | uniq -c | sort 1 filtergraph.c 1 rsaenh.c 1 shelllink.c 1 shreg.c 2 typelib.c 4 capture.c 4 wave.c 6 dsound8.c 6 dsound.c 7 vartype.c 8 path.c 15 crypt.c 43 metafile.c 51 shellpath.c Is this unusual? How many failures are most people seeing? For what it's worth, this is a Red Hat 9.0 system with two processors, and this was done with no pre-existing .wine directory. Also, there was a crash during the test. Here's that part of the log: ../../../../wine/tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so ../../../../wine/dlls/advapi32/tests/crypt.c && touch crypt.ok crypt.c:104: Test failed: -2146893799 crypt.c:117: Test failed: 0/-2146893799 crypt.c:126: Test failed: 0/-2146893801 crypt.c:457: Test failed: expected 234, got -2146893801 crypt.c:464: Test failed: expected 0, got 0 crypt.c:471: Test failed: expected (null), got crypt.c:472: Test failed: expected 0, got 0 crypt.c:491: Test failed: -2146893805 crypt.c:494: Test failed: -2146893805 crypt.c:502: Test failed: expected Microsoft Base Cryptographic Provider v1.0, got crypt.c:503: Test failed: expected 43, got 0 crypt.c:491: Test failed: -2146893805 crypt.c:494: Test failed: -2146893805 crypt.c:502: Test failed: expected Microsoft Base Cryptographic Provider v1.0, got crypt.c:503: Test failed: expected 43, got 0 wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x8dbe4073 in 32-bit code (0x403602e2). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:003b GS:0033 EIP:403602e2 ESP:4073f9d2 EBP:4073fa5e EFLAGS:00010202( - 00 - -RI1) EAX:8dbe4073 EBX:404174c8 ECX:40053500 EDX:401f0b20 ESI:4073fe26 EDI:77f01330 Stack dump: 0x4073f9d2: 00004001 00000000 00000000 d14c0000 0x4073f9e2: 0c884001 13304020 fa3477f0 020f4073 0x4073f9f2: fa340000 a5864073 fa644001 009b4073 0x4073fa02: d8940000 00004002 00000001 6c644008 0x4073fa12: ffff4041 e384ffff fa2c400c 68114073 0x4073fa22: 6c644008 74c84041 fa544041 e3844073 Backtrace: =>1 0x403602e2 INSTR_EmulateInstruction+0xda(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/kernel/instr.c:449] in kernel32 (0x4073fa5e) 2 0x403a441e vectored_handler+0x5e(ptrs=0x4073fa8e) [../../../wine/dlls/kernel/wowthunk.c:358] in kernel32 (0x4073fa7e) 3 0x4008bf89 call_vectored_handlers+0x5a(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/exception.c:196] in ntdll (0x4073faa2) 4 0x4008c30d EXC_RtlRaiseException+0x239(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/exception.c:252] in ntdll (0x4073fb2a) 5 0x400abe12 raise_segv_exception+0x8b(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/signal_i386.c:888] in ntdll (0x4073fb46) 0x403602e2 INSTR_EmulateInstruction+0xda [../../../wine/dlls/kernel/instr.c:449] in kernel32: movzbl 0x0(%eax),%eax Unable to open file ../../../wine/dlls/kernel/instr.c Modules: Module Address Debug info Name (17 modules) ELF 0x40000000-40016000 Deferred ld-linux.so.2 ELF 0x40017000-40030000 Deferred libwine.so.1 ELF 0x40032000-4003e000 Deferred libnss_files.so.2 ELF 0x40043000-40050000 Deferred libpthread.so.0 ELF 0x40050000-40053000 Deferred libdl.so.2 ELF 0x40054000-400d1000 Stabs ntdll<elf> \-PE 0x40070000-400d1000 \ ntdll ELF 0x400d1000-401c5000 Deferred libwine_unicode.so.1 ELF 0x401c5000-401e7000 Deferred libm.so.6 ELF 0x40300000-40419000 Stabs kernel32<elf> \-PE 0x40330000-40419000 \ kernel32 ELF 0x40621000-4063c000 Deferred advapi32_test<elf> \-PE 0x40630000-4063c000 \ advapi32_test ELF 0x40740000-4077b000 Deferred advapi32<elf> \-PE 0x40750000-4077b000 \ advapi32 ELF 0x42000000-42133000 Deferred libc.so.6 ELF 0x77f00000-77f03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\dank\demo\build\dlls\advapi32\tests\advapi32_test.exe 00000009 0 <== WineDbg terminated on pid 0x8 -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

5 11

Re: signaling unix threads
by Jukka Heinonen Nov. 8, 2004

Nov. 8, 2004

Markus Amsler wrote: > There's a fundamental bug in winedos/dosvm. c[1]. SIGUSR2 is sent to the > current process, but it should be sent to the dosvm thread. This causes > various ugly bugs. > I found no way signaling a unix thread, without modifing the wineserver. > I have implemented a thread_kill command in the wineserver, this solves > my problem, but i'm quite sure it won't get applied. > > I'm really not a wineserver/threading expert. Have I missed something? Yep. If using Linux 2.6 kernel and recent pthread library, threads share the same pid and they must be signalled using tkill and not kill. The only place which knows how to correctly signal threads is send_thread_signal function in server/ptrace.c. So, the easy way to fix signalling is to use Windows thread identifier for identifying dosvm thread instead of pids (which don't work anyway) and add to wineserver a handler that just calls send_thread_signal, which I guess is what you have been doing, anyway. Now, I have tried this approach and it seems to work. I have some prototype implementation lying around but I was thinking about doing something more complicated at the time, like using SIGUSR2 handler for doing Win32 remote operations discussed earlier on wine-devel, because signal handler is probably running in the correct context for doing this kind of things but I guess locking issues are going to be pretty complicated so it is probably better to just fix dosvm issues with a simple mechanism and not worry about anything else. So, feel free to submit a patch, if it is simple enough it should get accepted or at least you should get some suggestions how to change the patch in order for it to get accepted. -- Jukka Heinonen <http://www.iki.fi/jhei>

4 5

Re: Fix DLL loader regression
by Mike Hearn Nov. 8, 2004

Nov. 8, 2004

Any problem with this one Alexandre? On Thu, 04 Nov 2004 01:00:37 +0000, Mike Hearn wrote: > - Always add .dll extension when loading modules > > > Index: loader.c > =================================================================== > RCS file: /home/wine/wine/dlls/ntdll/loader.c,v > retrieving revision 1.78 > diff -u -p -r1.78 loader.c > --- loader.c 11 Oct 2004 20:59:06 -0000 1.78 > +++ loader.c 4 Nov 2004 00:56:48 -0000 > @@ -1432,12 +1432,18 @@ static NTSTATUS find_dll_file( const WCH > len = nt_name.Length - 4*sizeof(WCHAR); /* for \??\ prefix */ > if (len >= *size) goto overflow; > memcpy( filename, nt_name.Buffer + 4, len + sizeof(WCHAR) ); > + > + /* do we need to add the .dll extension? */ > if (file_part && !strchrW( file_part, '.' )) > { > len += sizeof(dllW) - sizeof(WCHAR); > if (len >= *size) goto overflow; > strcatW( filename, dllW ); > + RtlFreeUnicodeString( &nt_name ); > + if (!RtlDosPathNameToNtPathName_U( filename, &nt_name, &file_part, NULL )) > + return STATUS_NO_MEMORY; > } > + > if (!(*pwm = find_fullname_module( filename ))) > { > attr.Length = sizeof(attr);

2 1

Scrollbars
by Nicolai Kuntze Nov. 8, 2004

Nov. 8, 2004

Hi, I have played with my continuing bug (#2302) but I have some problems understanding the meaning of the output: fixme:win:GetWindowModuleFileNameA GetWindowModuleFileNameA(hwnd 0x40032, lpszFileName 0x40670548, cchFileNameMax 80) stub! trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=1 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=1 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=2 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=2 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=3 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=3 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 If my blue bar in the list disappears pos Value counts how many lines under the window I am. I have added a little debug to follow the source ... From the developer I got the following snipplet: int SViewLow::ViewSetScrollY( int PPos, int PMax, int PPage) { SCROLLINFO Scroll; memset( &Scroll, 0, sizeof( Scroll)); Scroll.cbSize= sizeof( SCROLLINFO); Scroll.fMask= 0; if (PPos!=-1) Scroll.fMask|= SIF_POS; if (PMax!=-1) Scroll.fMask|= SIF_RANGE; if (PPage!=-1) Scroll.fMask|= SIF_PAGE; Scroll.nPos= PPos; Scroll.nPage= PPage; Scroll.nMax= PMax-1; return SetScrollInfo( (HWND)ViewGetHWND(), SB_VERT, &Scroll, TRUE); } Does anyone has an idea what this could be? Yours, Nicolai

2 1

Re: Re: Winetest questions
by Chris Morgan Nov. 8, 2004

Nov. 8, 2004

> On Sun, Nov 07, 2004 at 02:01:13PM -0800, Dan Kegel wrote: > > 1. Why are all the archived posts to wine-test-results empty? > > See http://www.winehq.org/hypermail/wine-tests-results/2004/11 > > Every message body is empty! What's up with that? > > That's a good question. Chris, what's going on? > I suspect these are clients that have issues connecting to the net to upgrade their version of winrash since there are relatively few error reports compared to the number of test result submissions. We should really have the script ignore empty requests like this as they don't tell us anything and simply spam the mailing list every day. Chris

1 0

Re: Fix for metafile test
by Dan Kegel Nov. 8, 2004

Nov. 8, 2004

jakov(a)vmlinux.org wrote: > This is from when I ran winetest.exe from the desktop: > > http://test.winehq.org/data/200411021000/2000/gdi32:metafile.txt : > > metafile.c:126:hdcDisplay 76010815 > metafile.c:154:hdcMetafile 202107C1 > metafile.c:40:hdc 76010815, emr->iType 1, emr->nSize 108, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 82, emr->nSize 368, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 40, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 14, emr->nSize 20, param 0022FB58 > metafile: 151 tests executed, 0 marked as todo, 0 failures. Here's what I get when I run 'make test' on Wine: ../../../../wine/tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so ../../../../wine/dlls/gdi/tests/metafile.c && touch metafile.ok metafile.c:91: Test failed: pass 0: dx[0] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[1] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[2] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[3] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[4] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[5] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[6] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[7] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[8] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[9] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[10] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[11] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[12] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[13] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[14] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[15] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[16] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[17] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[18] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[19] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[20] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[21] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[22] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[23] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[24] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[25] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[26] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[27] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[28] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[29] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[30] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[31] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[32] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[33] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[34] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[35] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[36] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[37] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[38] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[39] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[40] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[41] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[42] (1081735508) didn't match 4 make[3]: *** [metafile.ok] Error 43 Is the metafile test supposed to be broken like this under Wine? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 2

Re: wine/ tools/wine.inf include/config.h.in dlls/ ...
by Vincent Béron Nov. 8, 2004

Nov. 8, 2004

Le jeu 04/11/2004 à 16:15, Alexandre Julliard a écrit : > Log message: > Michael Jung <mjung(a)iss.tu-darmstadt.de> > Implemented a substantial part of rsaenh.dll. > > Patch: http://cvs.winehq.org/patch.py?id=14412 The committed patch doesn't compile on RH8. OpenSSL doesn't use the same name for some datatypes/functions as the version used by Michael (actually the prototype is different as well). OpenSSL 0.9.7a (as found on FC1) will use OPENSSL_ENABLE_OLD_DES_SUPPORT by default which will #define the old names to the new ones for the DES functions. RSAPrivateKey_dup is only defined in x509.h in OpenSSL 0.9.6b, not in rsa.h. But pulling in x509.h also includes md4.h, md5.h and sha.h (via evp.h), which redefine MD4_CTX (and MD5 and SHA _CTX also) with an incompatible definition if the NO_MD4, etc. are not defined. Changelog: Allow rsaenh compilation with older (0.9.6b) OpenSSL version. Remove a cast from const to not-const. Vincent

2 1

Do we need one of those on our docs?
by Shachar Shemesh Nov. 8, 2004

Nov. 8, 2004

From the samba developer's guide, http://us1.samba.org/samba/devel/ > *Important:* In order to avoid any potential licensing issues we > also ask that anyone who has signed the Microsoft CIFS Royalty > Free Agreement > <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cifs/proto…> > not submit patches to Samba, nor base patches on the referenced > specification. We ask, too, that patches submitted to Samba not > infringe on any known patents. Finally, as with all GPL work, the > submitter should ensure that submitted patches do not conflict > with any third-party copyright. > > Do we need to put in something like that too? I'm not a lawyer (but I can probably get one). My understanding is that the "protocols" Microsoft policy don't really affect us. What may affect us is the wider and wider distribution of the Windows source code (Shared Source). We should not be highly affected by trade secrets: anyone publishing a trade secret is nullifying the secretness of it, and is the one bearing the responsibility for this action. However, copyright problems may be a problem for us. If someone takes a significant amount of code from MS and submits it, we may have some backtracking to do. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: signaling unix threads
by Dan Kegel Nov. 8, 2004

Nov. 8, 2004

Mike Hearn wrote: > I quite liked Michaels idea of the RT signals. Is there some reason we > can't use them? I didn't see Michael's proposal. Can you point to it? Now, I don't pretend to understand the issues here, but reading your patch, http://www.winehq.org/hypermail/wine-patches/2004/11/att-0041/01-patch__cha… I see the comment * ... there is a race with SuspendThread(): the app * can call SuspendThread() then GetThreadContext() whilst the * target is processing SIGUSR1 but before it's been able to * override the thread context, ie the context returned would be * meaningless to the app (internals of Wine itself). I understand similar races are present in real Windows, too. e.g. http://blogs.msdn.com/cbrumme/archive/2003/08/20/51504.aspx says "[with SuspendThread,] there’s a significant risk of leaving a thread suspended at a “bad” spot. If you call SuspendThread while a thread is inside the OS heap lock, you better not try to allocate or free from that same heap. In a similar fashion, if you call SuspendThread while a thread holds the OS loader lock (e.g. while the thread is executing inside DllMain) then you better not call LoadLibrary, GetProcAddress, GetModuleHandle, or any of the other OS services that require that same lock. Even worse, if you call SuspendThread on a thread that is in the middle of exception dispatching inside the kernel, a subsequent GetThreadContext or SetThreadContext can actually produce a blend of the register state at the point of the suspension and the register state that was captured when the exception was triggered. If we attempt to modify a thread’s context (perhaps bashing the EIP – on X86 – to redirect the thread’s execution to somewhere it will synchronize with the GC or other managed suspension), our update to EIP might quietly get lost." I guess we just need to have races no worse than in Windows :-) About RT signals - I would tread carefully here. RT signals are a precious resource. The queue is not very deep, and it's *per system* on Linux IIRC. When I used RT signals for I/O, they overflowed the queue all the time -- and if any program in the system is doing that, it affects your program, since the queue is shared. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

wine under cygwin
by James Hawkins Nov. 7, 2004

Nov. 7, 2004

I'm trying to compile wine under cygwin, but I am getting this error: Entering directory `/home/James Hawkins/wine/dlls/dsound/tests' gcc capture.o ds3d.o ds3d8.o dsound.o dsound8.o propset.o testlist.o -o dsound_test.exe -ldsound -lole32 -luser32 -lkernel32 -ldxguid -luuid -ldxerr8 /usr/lib/w32api/libdxguid.a(dxguid.o)(.rdata+0x1f20):dxguid.c: multiple definition of `_DSPROPSETID_DirectSoundDevice' propset.o(.rdata+0x10):/home/James Hawkins/wine/dlls/dsound/tests/propset.c:62: first defined here /usr/lib/w32api/libdxguid.a(dxguid.o)(.rdata+0x1f30):dxguid.c: multiple definition of `_CLSID_DirectSoundPrivate' propset.o(.rdata+0x0):/home/James Hawkins/wine/dlls/dsound/tests/propset.c:61: first defined here collect2: ld returned 1 exit status make[3]: *** [dsound_test.exe] Error 1 make[3]: Leaving directory `/home/James Hawkins/wine/dlls/dsound/tests' make[2]: *** [tests] Error 2 make[2]: Leaving directory `/home/James Hawkins/wine/dlls/dsound' make[1]: *** [dsound] Error 2 make[1]: Leaving directory `/home/James Hawkins/wine/dlls' make: *** [dlls] Error 2 Has anyone successfully compiled wine under cygwin, or does anyone have an idea of what the problem is? -- James Hawkins

1 0

winipcfg.exe issues
by Saulius Krasuckas Nov. 7, 2004

Nov. 7, 2004

[s2(a)katleriai antras]$ /sbin/ifconfig | grep ^[^\ ] eth0 Link encap:Ethernet HWaddr 00:50:22:80:F0:49 lo Link encap:Local Loopback ppp0 Link encap:Point-to-Point Protocol If run winipcfg with Wine, it lets me to change the adapter I want to inspect by selecting its name in combox (as usually). But if I hold the down-key pressed down for some seconds, Wine terminates the application: [s2(a)katleriai antras]$ wine /home/s2/cc/Program\ Files/winipcfg.exe wine client error:21: no fd received for handle 88 While the key is pressed, adapter info is being periodically refreshed. Does that means the app leaks some handle? Or is this a bug in Wine? What debug channel would you recommend to use to see more details on this?

1 0

SetupComm insize 1600 outsize 1600
by MediaHost (TM) Nov. 7, 2004

Nov. 7, 2004

Hi Wine Developers, Question: I need to use a Win app on Linux and everything seams fine, except that the communication with the serialport doesn't work. Well, also here, everything seams fine to me, so I want to get your advice. The only thing I could see is the unimplemented stub for "SetupComm insize outsize". Can I set it by my own (setserial) or what's the meaning of it anyway? The output below seams to me pretty good...: fixme:comm:SetupComm insize 1600 outsize 1600 unimplemented stub trace:comm:GetCommState handle 0x54, ptr 0x778ef948 trace:comm:GetCommState OK trace:comm:GetCommState bytesize 8 baudrate 2400 fParity 0 Parity 0 stopbits 1 trace:comm:GetCommState ~IXON ~IXOFF trace:comm:GetCommState fOutxCtsFlow 0 fRtsControl 1 trace:comm:GetCommState fOutxDsrFlow 0 fDtrControl1 trace:comm:GetCommState ~CRTSCTS trace:comm:SetCommState handle 0x54, ptr 0x778ef948 trace:comm:SetCommState bytesize 8 baudrate 1200 fParity 0 Parity 0 stopbits 1 trace:comm:SetCommState ~IXON ~IXOFF trace:comm:SetCommState fOutxCtsFlow 0 fRtsControl 1 trace:comm:SetCommState fOutxDsrFlow 0 fDtrControl1 trace:comm:EscapeCommFunction handle 0x54, function=5 trace:comm:EscapeCommFunction SETDTR trace:comm:EscapeCommFunction handle 0x54, function=4 trace:comm:EscapeCommFunction CLRRTS trace:comm:SetCommTimeouts (0x54,0x778ef934) trace:comm:PurgeComm handle 0x54, flags 4 trace:comm:PurgeComm handle 0x54, flags 8 ]# cat /proc/tty/driver/serial serinfo:1.0 driver:5.05c revision:2001-07-08 0: uart:16550A port:3F8 irq:4 baud:2400 tx:11 rx:0 RTS Best Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org MediaHostT at www.mediahost.org Skype: startcom

2 2

Scrollbars
by Nicolai Kuntze Nov. 7, 2004

Nov. 7, 2004

Hi, I have played with my continuing bug (#2302) but I have some problems understanding the meaning of the output: fixme:win:GetWindowModuleFileNameA GetWindowModuleFileNameA(hwnd 0x40032, lpszFileName 0x40670548, cchFileNameMax 80) stub! trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=1 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=1 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=2 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=2 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=3 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=3 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 If my blue bar in the list disappears pos Value counts how many lines under the window I am. I have added a little debug to follow the source ... From the developer I got the following snipplet: int SViewLow::ViewSetScrollY( int PPos, int PMax, int PPage) { SCROLLINFO Scroll; memset( &Scroll, 0, sizeof( Scroll)); Scroll.cbSize= sizeof( SCROLLINFO); Scroll.fMask= 0; if (PPos!=-1) Scroll.fMask|= SIF_POS; if (PMax!=-1) Scroll.fMask|= SIF_RANGE; if (PPage!=-1) Scroll.fMask|= SIF_PAGE; Scroll.nPos= PPos; Scroll.nPage= PPage; Scroll.nMax= PMax-1; return SetScrollInfo( (HWND)ViewGetHWND(), SB_VERT, &Scroll, TRUE); } Does anyone has an idea what this could be? Yours, Nicolai

1 0

Re: D3D8
by Ann and Jason Edmeades Nov. 7, 2004

Nov. 7, 2004

All I can say is any assistance with the d3d8/9 stuff is very gratefully accepted! If you have any questions or want help, feel free to drop me a note or post on wine-devel, and I'll try to respond. As per Lionel's note, I'm trying to move all the code into wined3d and make d3d8 and d3d9 call it, effectively making only one place to maintain so there is a lot of churn at the moment. It should settle in a couple of months (Once I get my latest patch in, things will move faster as well, once I know the way to solve certain problems). If you want suggestions as to what to work on, there's enough areas :-) - One I would say needs doing at some point is to take eg. 3dMark2002se, and get figures for it (I'd be interested if someone has a dual boot windows/linux machine to get comparisons on time), and try some profiling to work out where the time is spent and speed things up! - Apart from that, pick a game, and get the graphics right! - Or search the web for d3d8 (or 9, when it's there) demos which don't work and you have the source as well to, as you then know where to target in Jason

1 0

STL with WINE problems
by Dagan Shai Nov. 7, 2004

Nov. 7, 2004

Hi, I'm trying to compile a C++ file using WINE. The file includes STL's map. I am using STLPort with WINE. I get a long list of errors starting with: /starhome/iu/wine/include/wine/msvcrt/cstdlib:97: `div' not declared /starhome/iu/wine/include/wine/msvcrt/cstdlib:102: `ldiv' not declared /starhome/iu/wine/include/wine/msvcrt/cstdlib: In function `ldiv_t std::div(long int, long int)': /starhome/iu/wine/include/wine/msvcrt/cstdlib:122: `ldiv' undeclared (first use this function) /starhome/iu/wine/include/wine/msvcrt/cstdlib:122: (Each undeclared identifier is reported only once for each function it appears in.) /starhome/iu/wine/include/wine/msvcrt/cstdlib: At global scope: /starhome/iu/wine/include/wine/msvcrt/cstdlib:138: `lldiv_t' not declared /starhome/iu/wine/include/wine/msvcrt/cstdlib:139: `_Exit' not declared ... I'm using msvcrt as the C library. I saw a previous posting with the same problem, and I've tried the various solutions suggested (toggling -mno-cygwin, using STLPort) but that did not work. Suggestions welcome. Thanks, Shai Dagan

1 0

D3D8
by Joel Konkle-Parker Nov. 7, 2004

Nov. 7, 2004

In trying to get Guild Wars to work, I've come across the lack of D3D8 support in Wine. I'd like to try to help on this front, but I'm not sure who to talk to or where to start. Cedega has D3D8 support, but I'm presuming that if I contribute there, my code won't migrate back to base Wine. Can anyone lead me in the right direction here? -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

4 4

Re: Frame and Button Edges
by Dan Kegel Nov. 7, 2004

Nov. 7, 2004

williampoetra(a)yahoo.com wrote: > Patch submitted to wine-cvs. Hope it gets committed :) I hope you meant wine-patches. wine-cvs is only for things that have already been committed, I think... - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

Countering arguments against Wine
by Dan Kegel Nov. 7, 2004

Nov. 7, 2004

I've run into people several times who dislike the fact that I advocate or even work on the Wine project, because they feel that it takes focus away from working on the Linux desktop. I beg to differ, but I've never had a really snappy comeback for them. It happened again today, and this time it occurred to me I should write a page on the topic to organize my thoughts. Here it is: http://www.kegel.com/wine/why.html Comments welcome. Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

6 11

Re: MSIEXEC: Make installation of InstMsiA.exe possible
by Dmitry Timoshkov Nov. 6, 2004

Nov. 6, 2004

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > @@ -523,6 +524,11 @@ > { > InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_PROGRESSONLY; > } > + else if(!strcasecmp(argv[i]+2, "b+!")) Please use lstrcmpiA instead of strcasecmp. A difference between unix system locale and current ANSI code page in Wine might lead to undesired side effects. -- Dmitry.

2 1

Re: MSIEXEC: Make installation of InstMsiA.exe possible
by Tobias Burnus Nov. 6, 2004

Nov. 6, 2004

Hello, Hans Leidekker wrote: > I have an InstMsiA.exe that uses two undocumented msiexec command line > parameters: /m and /D and uses an undocumented modifier (!) with the /q > parameter. Our msiexec fails when it encounters these and responds with > a usage message. For /m I found the following, don't know whether it helps. Tobias According to http://safariexamples.informit.com/0321133455/ExecutiveSoftware/Diskeeper/D… msiexec /m MIF /qn /I DKMSI INSTALLDIR="C:\MyDir" Where MIF represents the Management Information File -- 8 characters maximum.

1 0

Re: keyboard: ISO_Left_Tab
by Andreas Mohr Nov. 6, 2004

Nov. 6, 2004

Hi, On Sat, Nov 06, 2004 at 07:30:20AM -0800, Walt Ogburn wrote: > + /* Special case: X turns shift-tab into ISO_Left_Tab. */ > + /* Here we change it back. */ > + if ((ret == 0) && (keysym == XK_ISO_Left_Tab)) > + { > + ret = 1; > + lpChar[0] = 0x09; > + } > + > if (ret == 0) > { > BYTE dead_char; Two comments: a) A return value of 0 probably is much more common than the XK_ISO_Left_Tab keysym, so the XK_ISO_Left_Tab check should be first to not have to check both conditions in the event that ret is 0. (the compiler might do reordering according to check probability, though, but OTOH I doubt that it knows which one is more likely) b) there's another if (ret == 0) *right below*, so why not add the XK_ISO_Left_Tab check there? Again useless waste of resources... Thanks for this patch! Andreas Mohr

2 1

Re: winuser.h : remove a fixme and "add" some things
by Dmitry Timoshkov Nov. 6, 2004

Nov. 6, 2004

"Rémi Assailly" <remi.assailly(a)free.fr> wrote: > Excuse me, > I did not want to write that ULONG_PTR is 32 in Win32 _and_ Win64, but I > wanted to write that ULONG_PTR and DWORD were the same. I was wrong here > : DWORD is always 32bits, no ? Right, DWORD is a 32-bit entity in both Win32 and Win64. > So, why there are a lot of ULONG_PTR instead of DWORD if it is not to be > ported in Win64 ? That's there exactly for that purpose - to be portable to Win64. That's a variable that can potentially hold a pointer or a handle value. Win64 is not binary compatible with Win32, but is aimed to be source compatible. Read some docs about porting to Win64 for further details. -- Dmitry.

1 0