November 2004 - Wine-Devel - list.winehq.org

Re: Fix for metafile test
by Dmitry Timoshkov Nov. 3, 2004

Nov. 3, 2004

"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > Seems the test fails in non-interactive mode without this patch. No, the problem seems to be related to a window's visibility. Windows does not play EMF records if the DC was created for a not visible window. A lot of other tests fail due to exactly that problem: user32/win.c and user32/msg.c are the examples. The question is what makes the tests create invisible windows? Does winetest run as a service on a not visible desktop? Anything else? -- Dmitry.

4 5

Re: The Return of IE6 Problems
by Mike Hearn Nov. 3, 2004

Nov. 3, 2004

> The common denominator for this situation is that these patches modified > some of the same files. Patch 13475 implemented itss.dll and modified > wine/dlls/Makefile.in, wine/configure.ac and wine/configure. A partial > implementation of advpack.RegInstall, Patch 13938 also modified > wine/dlls/Makefile.in, wine/configure.ac and wine/configure in addition > to adding /wine/dlls/advpack/reg.c. Although IE6 would still > initialize, patch 13937 added advpack to the repository. Hi Dan, Great work on the regression search! This is exactly the sort of information we need. ITSS was implemented by Mike - as it's a component of IE I guess it should at least work with it so I'm CCing him. It may be that he implemented it for some other app rather than IE and he doesn't have time to bring it up to scratch for IE right now. I'm not sure. The second patch suggests that we got RegInstall wrong. That needs to be fixed, but for now you can probably get IE back to a working state again by overriding both these DLLs as native (itss, advpack). If you look at the script I wrote back in January, quite a lot of what it does is simply overriding various incomplete DLLs. I no longer maintain that script (buy CrossOver! :) but if you want to take over maintenance by all means do so, I'd be happy to help you get up to speed. thanks -mike

2 1

RE: Test Drive failure
by Dagan Shai Nov. 3, 2004

Nov. 3, 2004

This results in a helloworld executable. When I execute it I get lots of output lines, here's a sample: fixme:ttydrv:TTYDRV_GetBitmapBits (0x3bc, 0x77cafa7c, 32): stub fixme:ttydrv:TTYDRV_GetBitmapBits (0x3b8, 0x77cafa9c, 32): stub err:imagelist:ImageList_ReplaceIcon no color! fixme:ttydrv:TTYDRV_DC_StretchBlt (0x94, 288, 0, 16, 16, 0x3c4, 0, 0, 16, 32, 13 369376): stub fixme:ttydrv:TTYDRV_DC_StretchBlt (0x98, 288, 0, 16, 16, 0x3c4, 0, 0, 16, 32, 13 369376): stub fixme:ttydrv:TTYDRV_GetBitmapBits (0x3cc, 0x77cafa7c, 128): stub fixme:ttydrv:TTYDRV_GetBitmapBits (0x3c8, 0x77cafafc, 128): stub err:imagelist:ImageList_ReplaceIcon no color! fixme:ttydrv:TTYDRV_DC_StretchBlt (0xb0, 576, 0, 32, 32, 0x3d4, 0, 0, 32, 64, 13 369376): stub fixme:ttydrv:TTYDRV_DC_StretchBlt (0xb4, 576, 0, 32, 32, 0x3d4, 0, 0, 32, 64, 13 369376): stub These are all functions that helloworld does not use, so I don't understand the problem here. Regards, Shai Dagan -----Original Message----- From: Dimitrie O. Paun [mailto:dpaun(a)rogers.com] Sent: Tuesday, November 02, 2004 6:57 PM To: Dagan Shai Cc: Dimitrie O. Paun; wine-devel(a)winehq.org Subject: Re: Test Drive failure On Tue, Nov 02, 2004 at 06:40:57PM +0200, Dagan Shai wrote: > Thanks. > > Here they are. Winemaker is buggy, the generated Makefile has a small problem. Here's the fix: --- Makefile.orig 2004-11-02 09:52:59.000000000 -0500 +++ Makefile 2004-11-02 11:52:57.451738280 -0500 @@ -58,7 +58,7 @@ ### Generic targets -all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES:%=%.so) +all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES) ### Build rules @@ -106,7 +106,7 @@ $(helloworld_exe_MODULE).dbg.c: $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) $(WINEBUILD) -o $@ --debug -C$(SRCDIR) $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) -$(helloworld_exe_MODULE).so: $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) +$(helloworld_exe_MODULE): $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) $(CXX) $(helloworld_exe_LDFLAGS) -o $@ $(helloworld_exe_OBJS) $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_LIBRARY_PATH) $(LIBRARY_PATH) $(helloworld_exe_DLLS:%=-l%) $(helloworld_exe_LIBRARIES:%=-l%) -- Dimi. ______________________________________________________________________ This email message has been scanned by PineApp Mail-Secure and has been found clean.

1 0

Re: EnumDateFormatsA: Add ru_RU locale and default DATE format
by Dmitry Timoshkov Nov. 2, 2004

Nov. 2, 2004

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changelog: > EnumDateFormatsA: > - Add ru_RU locale (0x419) That's a completely broken implementation, please do not extend it. It should retrieve the data from the kernel32 locale database (have a look at dlls/kernel/nls). > - Use DATE_SHORTDATE when dwFlags is 0 > - Ignore LOCALE_USE_CP_ACP bit in dwFlags (I can't find a difference in > Windows behavior with this flag) It would be nice to see a test case for that. Also please use a common indent 4 spaces as (almost) everywhere in Wine. -- Dmitry.

2 2

dinput - mouse
by Vitaliy Margolen Nov. 2, 2004

Nov. 2, 2004

Is there are anyone working on it? It seems like there are some strange problem with mouse input, and I can't find it! I trying to get Descent 3 running. So far so good. It installs, and runs. But mouse does not work. It's not like it doesn't work at all. It does, but it moves erratically and mostly left-right. Could it be that it can't switch to full screen mode and fails because of it? Dome could be downloaded from here: http://www.descent3.com/4_downloads.html#d3_demos P.S. I know there is Linux version of it. Too bad I don't have it. It cost $$ and have to by purchased separately. Vitaliy Here is what dinput log looks like: trace:dinput:dinput_mouse_hook msg 200 pt 320 240 (W=0) trace:dinput:dinput_mouse_hook (X: 0 - Y: 0 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook msg 200 pt 320 240 (W=0) trace:dinput:dinput_mouse_hook (X: 0 - Y: 0 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 46 / size 64) trace:dinput:dinput_mouse_hook queueing 8 at offset 4 (queue head 47 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 318 248 (W=1) trace:dinput:dinput_mouse_hook (X: -2 - Y: 8 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 48 / size 64) trace:dinput:dinput_mouse_hook queueing 6 at offset 4 (queue head 49 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 316 254 (W=1) trace:dinput:dinput_mouse_hook (X: -4 - Y: 14 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 50 / size 64) trace:dinput:dinput_mouse_hook queueing 6 at offset 4 (queue head 51 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 314 260 (W=1) trace:dinput:dinput_mouse_hook (X: -6 - Y: 20 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 52 / size 64) trace:dinput:dinput_mouse_hook queueing 8 at offset 4 (queue head 53 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 312 268 (W=1) trace:dinput:dinput_mouse_hook (X: -8 - Y: 28 L: 00 M: 00 R: 00) trace:msg:MSG_peek_message got type 7 msg 200 (WM_MOUSEMOVE) hwnd 0x10022 wp 0 lp 0 trace:dinput:SysMouseAImpl_GetDeviceData (0x4036bd48)->(dods=16,entries=64,fl=0x00000000) trace:dinput:SysMouseAImpl_GetDeviceData Application retrieving 12 event(s). trace:dinput:SysMouseAImpl_GetDeviceData Warping mouse to 320 - 240

1 0

WSARecv not calling CompletionRoutine on socket close
by Geoff K. Hart Nov. 2, 2004

Nov. 2, 2004

I've tried to search the mailing list archives (is their a searchable archive someplace?) for some reference to this problem. but found none. Forgive me if I didn't search hard enough. The Problem: we register a callback (lpCompletionRoutine) in our WSARecv call. This callback works fine for normal incoming messages. However, on socketclose, it does NOT get called. This behavior doesn't match what we see on Windows. Is there some configuration option we are missing? We see this same behavior for .exe's built on Windows and run under Wine - and with source code brought to Linux and built with WineLib. thanks, Geoff

1 0

[shellpath.c]: minor fix to Rolf's patch
by Rolf Kalbermatter Nov. 2, 2004

Nov. 2, 2004

<menard.fabrice(a)wanadoo.fr> wrote: >The latest patch from Rolf Kalbermatter on shellpath.c was breaking the installation of wine.inf. > > wine rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 d:\\wine.inf > >was returning errors about being unable to create some dirs. In facts these errors was concerning >already existing directories in SHGetFolderPathW. I believe this patch is not fully correct. I noticed these errors too after the patch was applied, but did a little more investigation. SHCreateDirectoryEx should never be called if the directory already exists since this is explicitedly tested before the call to the function with PathFileExistsW(). Also inside the SHCreateDirectoryEx function I saw that the first call to CreateDirectory fails since intermediate directories are missing and then in the recursive call to CreateDirectory every single call returns ERROR_ALREAY_EXISTS on my system in spite of that it actually creates the last two or three directories in there. My investigations showed that in spite of that some of the the top level directories do not exist, the function NtCreateFile() which is ultimately called does seem to return an according NT status when called from SHGetFolderPath() but does create the directory nevertheless. Strange thing is that I can't reproduce this behaviour when calling SHCreateDirectoryEx() with many different parameters from an extended test in tests/shfileop.c So I believe the root cause really seems somewhere else, namely NTCreateFile or maybe wineserver itself, but I hadn't time to further go into details. >I think it is not necessary to care about that in this function so I added a check on the >type of error returned by SHCreateDirectoryExW. ShCreateDirectory should fail with that error if the directory really already existed. Rolf Kalbermatter

2 2

Can't debug mingw compiled program
by Vitaly Lipatov Nov. 2, 2004

Nov. 2, 2004

During program debugging I have some trouble with winedbg use. Simple test program with error on write access to constant: #include <string.h> int main(int argc, char **argv) { char * str = "test"; _strupr(str); return (0); } I try debug it: $ winedbg 3.exe Can't attach process 3: error 87 WineDbg starting on pid 0xa In 32 bit mode. Wine-dbg>c First chance exception: page fault on write access to 0x00404000 in 32-bit code (0x00935d20). ... Backtrace: =>1 0x00935d20 _memccpy+0x595 in msvcrt (0x0090fec8) 2 0x00401330wine-kthread: stabs.c:246: stabs_find_ref: Assertion `filenr <= cu_include_stk_idx' failed. I see some bug in stubs handling. Versions: i386-mingw32msvc-gcc-3.3.3 wine from last CVS Any suggestions? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

RFC: yield on Waits
by Jeremy White Nov. 2, 2004

Nov. 2, 2004

Hi folks, Due to my new found belief that all of the flaws in Wine are timing problems, I have found what appears to be a gaping hole in Wine's timing behavior. Specifically, it appears as though any style of Waitxxx is supposed to yield the processor. This seems a bit difficult for me to believe, even though we had earlier discovered that Wine was never yielding on a Sleep(0). I've attached the test program I used to discover this. If you run sleep2 -1 0w the program will start 2 threads, one which spin loops (-1), and one which does a wait on an object for 0 seconds. You'll see in the results that the Wait(...,0) thread gets far fewer loops, and thus must be yielding. Further, changing that to a 0ws (or even 5ws), which means we're waiting on a signalled object, doesn't change the behavior. This leads me to suggest the attached patch. I would appreciate review from other folks, because this seems like a drastic change to me, and it strikes me as equally likely that I've done something stupid. Cheers, Jeremy

1 1

Re: Test Drive failure
by Dimitrie O. Paun Nov. 2, 2004

Nov. 2, 2004

On Tue, Nov 02, 2004 at 06:40:57PM +0200, Dagan Shai wrote: > Thanks. > > Here they are. Winemaker is buggy, the generated Makefile has a small problem. Here's the fix: --- Makefile.orig 2004-11-02 09:52:59.000000000 -0500 +++ Makefile 2004-11-02 11:52:57.451738280 -0500 @@ -58,7 +58,7 @@ ### Generic targets -all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES:%=%.so) +all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES) ### Build rules @@ -106,7 +106,7 @@ $(helloworld_exe_MODULE).dbg.c: $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) $(WINEBUILD) -o $@ --debug -C$(SRCDIR) $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) -$(helloworld_exe_MODULE).so: $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) +$(helloworld_exe_MODULE): $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) $(CXX) $(helloworld_exe_LDFLAGS) -o $@ $(helloworld_exe_OBJS) $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_LIBRARY_PATH) $(LIBRARY_PATH) $(helloworld_exe_DLLS:%=-l%) $(helloworld_exe_LIBRARIES:%=-l%) -- Dimi.

1 0

Correct time stamps on x11 events
by Jeremy White Nov. 2, 2004

Nov. 2, 2004

Log message: Fix x11 event timing so that we correctly correlate x11 timing and Wine timing and dynamically adjust it as we go.

1 0

RE: Test Drive failure
by Dagan Shai Nov. 2, 2004

Nov. 2, 2004

It only generated the helloworld.exe.so file, and no others. This is the only file defined in the makefile generated by winemaker. It is listed as part of the EXES macro and not the DLLS, which is why I thought it to be an executable. Could there be some reason that no executable is generated? Shai Dagan -----Original Message----- From: Dimitrie O. Paun [mailto:dpaun(a)rogers.com] Sent: Tuesday, November 02, 2004 6:14 PM To: Dagan Shai Cc: wine-devel(a)winehq.org Subject: Re: Test Drive failure On Tue, Nov 02, 2004 at 05:53:11PM +0200, Dagan Shai wrote: > Hi, > I'm new to WINELIB. As a test drive I tried to port the Hello World > application, just to see that the environment is functioning. > I called: > winemaker --console --lower-uppercase . > In the source directory. Then I called: > make > A helloworld.exe.so file was successfully created as a result (no errors > or warnings). It should have also generated a helloworld executable file, and you should be running it as: # ./helloworld -- Dimi. ______________________________________________________________________ This email message has been scanned by PineApp Mail-Secure and has been found clean.

3 2

Re: Fix for metafile test
by Juan Lang Nov. 2, 2004

Nov. 2, 2004

Dmitry wrote: > The question is what makes the tests create invisible windows? Does > winetest run as a service on a not visible desktop? Anything else? I believe this is the reason. The shellpath tests fail on WinXP, I believe because HKCU doesn't exist because the service doesn't interact with the desktop. --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: COM / InstallShield status
by Mike Hearn Nov. 2, 2004

Nov. 2, 2004

> Likewise, what's the current status of Installshield support, > and how much work would it be to fully support > Installshield-based installers? I don't see any > open Installshield bug reports, maybe I should file > one against the apps I have that don't install at > the moment. (Or would that be overkill?) Rob and I did some work on InstallShield for iTunes a few months ago, since then AFAIK no work has been done. Status back then was that the InstallShield 7/MSI hybrid installers worked pretty well, the bug I chased for nearly a week was refcounting related (the backend wasn't shutting down) and since that was fixed I believe it works pretty well. The other main problems I'm aware of are: - needs stdole32.tlb, we have a program to generate this in CrossOver and it needs to be pulled upstream as previously discussed. - Painting problems. I've not investigated this deeply but I'm 99% sure I know what the problem is. I've even written a patch to fix it as part of investigating iTunes, but I never tried the patch with an InstallShield that shows the issue. Apart from those two there are mostly just generic issues - InstallShield contains its own scripting language which heavily exercises the variant APIs, so it sometimes shows up problems with them. I believe Marcus found an issue with them thanks to InstallShield recently. In other words, InstallShield *should* work though it might not be pretty. There may be installers out there which don't work, I'd like to start nailing them once I get back to Wine hacking. I don't know if I'll get time however. Also, Murphy continues to smack me down w.r.t internet connection, the ISP sent me the wrong type of modem and yesterday I discovered the phone socket I was going to connect the modem to doesn't actually work :( thanks -mike

1 0

Re: wineps: better pattern brushes
by Jakob Eriksson Nov. 2, 2004

Nov. 2, 2004

Isn't 300 a bit low? Almost all lasers do 600 dpi. Huw D M Davies wrote: > Huw Davies <huw(a)codeweavers.com> > Scale the patterns so that they're rendered at 300dpi > Create the image dictionary once, rather than every time the PaintProc > is called - should speed printing up somewhat. > > >

2 1

Test Drive failure
by Dagan Shai Nov. 2, 2004

Nov. 2, 2004

Hi, I'm new to WINELIB. As a test drive I tried to port the Hello World application, just to see that the environment is functioning. I called: winemaker --console --lower-uppercase . In the source directory. Then I called: make A helloworld.exe.so file was successfully created as a result (no errors or warnings). However, when I execute this file I immediately get a segmentation fault. I tried to run it using gdb, in order to figure out what happens, and I get: Program received signal SIGSEGV, Segmentation fault. 0x00000001 in ?? () I'm sure I'm missing something simple. Can someone please point me in the right direction? Thanks, Shai Dagan

2 1

The Return of IE6 Problems
by Dan McGhee Nov. 2, 2004

Nov. 2, 2004

Hopefully, this time I have generated more specific and relevant information. I have done regressions to identify the patches that may be causing the symptoms. I have duplicated these results by using ./tools/wineinstall, make && make depends and wineprefixcreate. Although I was not able to get the help engine functional, I duplicated the IE6 not running symptom by installing IE6 manually. Additionally these symptoms are current as of a wine compiled from cvs the morning of October 30, 2004. Statement of symptoms: 1. Until the commit of 20040824 16:00:16 CDT, patch 13475, IE6, when installed using Mike Hearn's script ran and the help engine was functional. After the patch, the help engine was not functional. 2. With the commit of 20040927 15:39:42 CDT, patch 13938, IE6, installed using the script or manually, would not initialize. If I substitute system.reg and user.reg from a version of wine compiled before patch 13475 for the files of the same names in a version of wine compiled from cvs updated on the morning of 20041030, IE6 runs and the help engine is functional. The common denominator for this situation is that these patches modified some of the same files. Patch 13475 implemented itss.dll and modified wine/dlls/Makefile.in, wine/configure.ac and wine/configure. A partial implementation of advpack.RegInstall, Patch 13938 also modified wine/dlls/Makefile.in, wine/configure.ac and wine/configure in addition to adding /wine/dlls/advpack/reg.c. Although IE6 would still initialize, patch 13937 added advpack to the repository. I do not have the ability to read the changes and try to interpret them. I can only supply information that I think is relevant or for which someone specifically asks me. I have logs of installing and running IE6 before and after the patches. I have the system.reg and user.reg files also. In addtion I have diff files of the befores and afters. This is the difference between system.reg-before-patch-13475 and system.reg-after-patch-13938. This file was "egrepped" for itss|advpack: > -@="C:\\windows\\system\\itss.dll" > -@="C:\\windows\\system\\itss.dll" > -@="C:\\windows\\system\\itss.dll" > -@="C:\\windows\\system\\itss.dll" > -@="C:\\windows\\system\\itss.dll,0" > "StubPath"="rundll32.exe advpack.dll,LaunchINFSectionEx > c:\\windows\\inf\\icw.inf,PerUserStub,,36" > +"050"="rundll32.exe advpack.dll,DelNodeRunDLL32 > c:\\windows\\system\\dacui.dll" > +"054"="rundll32.exe advpack.dll,DelNodeRunDLL32 > c:\\windows\\Catroot\\icatalog.mdb" > "000"="rundll32.exe advpack.dll,LaunchINFSectionEx > c:\\windows\\system\\ieuinit.inf,BackupCryptoKeys.Win,,36" > "QuietUninstallString"="Rundll32 advpack.dll,LaunchINFSectionEx > c:\\windows\\inf\\iedom.inf,,,256" > "QuietUninstallString"="rundll32 advpack.dll,LaunchINFSectionEx > c:\\windows\\inf\\hhupdcab.inf,,,256" > "QuietUninstallString"="RunDll32 advpack.dll,LaunchINFSectionEx > c:\\windows\\inf\\icw.inf,,,256" > "QuietUninstallString"="rundll32 advpack.dll,LaunchINFSectionEx > c:\\windows\\inf\\unie5bak.inf,,,256" > "QuietUninstallString"="rundll32 advpack.dll,LaunchINFSectionEx > c:\\windows\\inf\\iereadme.inf,,,256" This is an excerpt from the difference between user.reg before and after. The whole file is 21k and I will be more than happy to supply it if someone wants the whole thing. > --- user.reg.before-13475 2004-10-25 15:56:16.000000000 -0500 > +++ user.reg.after-13938 2004-10-26 20:29:16.000000000 -0500 ................... > -[Environment] 1098735476 > +[Environment] 1098839302 > +"PATH"="c:\\windows;c:\\windows\\system;e:\\;e:\\test;f:\\" > +"Systemroot"="c:\\windows" > +"TEMP"="e:\\" > +"TMP"="e:\\" > +"USERPROFILE"="c:\\windows\\Profiles\\Administrator" > +"windir"="c:\\windows" > +"winsysdir"="c:\\windows\\system" ........................ I didn't use this section from any stance of relevance, but only to demonstrate the difference in the number strings in the [Environment] lines. 10987xxxxx changed to 10988yyyyy is typical both in the system.reg and user.reg files. This section is typical of numbers of lines either present with patch 13938 or absent with it. There are very mand "dword=.............." that are present before patch 13475 and gone after 13938. I have also attached the output of winedbg when running IE6 after patch 13938 and with the system.reg and user.reg files created from the recent version of wine. I thought that this situation could be the results of the changes in wine between now and the time that Mike Hearn wrote his script. However, I was able to duplicate the systems by installing IE6 using Method 2 from Frank's Corner. If anyone has any "hacking" they want me to try, I will be more than happy to do it. Also, if someone wants more information, I will be happy to send what I already have or generate more. Thanks, Dan

1 0

Re: Add time zone to TZ_Info
by Duane Clark Nov. 2, 2004

Nov. 2, 2004

Roger Olson wrote: > RCS file: /home/wine/wine/dlls/ntdll/time.c,v > retrieving revision 1.51 > diff -u -u -r1.51 time.c > --- dlls/ntdll/time.c 22 Oct 2004 19:54:17 -0000 1.51 > +++ dlls/ntdll/time.c 31 Oct 2004 21:18:46 -0000 > @@ -105,6 +105,9 @@ > {"AKDT", > {'A','l','a','s','k','a','n',' ','S','t','a','n','d','a','r','d',' ','T', > 'i','m','e','\0'}, 480, 1}, > + {"PST", > + {'P','a','c','i','f','i','c',' ','S','t','a','n','d','a','r','d',' ','T', > + 'i','m','e','\0'}, 480, 0}, > {"PDT", > {'P','a','c','i','f','i','c',' ','S','t','a','n','d','a','r','d',' ','T', > 'i','m','e','\0'}, 420, 1}, Hmm... I don't know if anything actually uses the names, but I doubt these are right. PDT would normally be referred to as Pacific Daylight Time. Any chance of getting you to add some tests for these?

4 4

Re: Ok, trying again
by Markus Amsler Nov. 1, 2004

Nov. 1, 2004

Hi, This patch doesn't aplly smoothly, because you did the cvs diff not from the wine-root directory. do: at ~/src/wine$ cvs diff -u dlls/msvrt/tests/file.c You can test if your patch apllies with $ patch -p0 < file.diff from the wine root. If there are no error messages the format is fine. To remove the patch do $ patch -p0 -R <file.diff I hope this helps Markus Jakob Eriksson wrote: > *src/wine/dlls/msvcrt/tests > > > * > jakov(a)toto:~/src/wine/dlls/msvcrt/tests$ cvs diff -u file.c > Index: file.c > =================================================================== > RCS file: /home/wine/wine/dlls/msvcrt/tests/file.c,v > retrieving revision 1.10 > diff -u -r1.10 file.c > --- file.c 3 Sep 2004 01:05:30 -0000 1.10 > +++ file.c 1 Nov 2004 16:24:06 -0000 > @@ -306,7 +306,25 @@ > ok(res[strlen(res)-1] != '.', "second call - last character is a > dot\n"); > } > > +static void test_access( void ) > +{ > + FILE *fp; > + > + const char filename[] = "tmpfile.tst"; > + ok(-1 == _access(filename, 0), "This file should not exist yet.\n"); > + ok(ENOENT == errno, "and errno should be ENOENT but it is %d.\n", > errno); > + > + fp = fopen(filename, "w"); > + if (NULL == fp) return; > + fclose(fp); > > + ok(0 == _access(filename, 0), "Now the file should exist.\n"); > + ok(0 == _access(filename, 2), "We should have write permission, > after all I created it. errno=%d\n", errno); > + ok(0 == _access(filename, 4), "We should have read permission. > errno=%d\n", errno); > + ok(0 == _access(filename, 6), "We should also be able to check > for read and write permission. errno=%d\n", errno); > + > + _unlink(filename); > +} > > START_TEST(file) > { > @@ -321,6 +339,7 @@ > return; > } > > + test_access(); > test_fdopen(); > test_fileops(); > test_fgetwc(); > > >

1 0

Re: Edit - wants all keys when multiline
by Dmitry Timoshkov Nov. 1, 2004

Nov. 1, 2004

"Vitaliy Margolen" <wine-patch(a)kievinfo.com> wrote: > @@ -761,6 +761,12 @@ > > case WM_GETDLGCODE: > result = DLGC_HASSETSEL | DLGC_WANTCHARS | DLGC_WANTARROWS; > + > + if (GetWindowLongW( hwnd, GWL_STYLE ) & ES_MULTILINE) > + { > + result |= DLGC_WANTALLKEYS; EDITSTATE structure already has the 'style' member for the optimization sake, so please use it instead of GetWindowLong(GWL_STYLE). > + r = SendMessage(hwEdit, WM_GETDLGCODE, 0, (LPARAM) &msMessage); > + ok(r==0x89, "Expected DLGC_WANTCHARS | DLGC_HASSETSEL | DLGC_WANTARROWS got %x\n", r); Do not use 0x89 and similar cryptic values in the test, use appropriate symbolic constants instead. And please merge your test into existing win.c tests. -- Dmitry.

3 2

Listview notify_dispinfoT Messageformat
by Thorsten Kani Nov. 1, 2004

Nov. 1, 2004

Hello, Testing showed that the current implementation of notify_dispinfoT doesnt work with W2K. (or at least not with SP4 (: ) The attached patch corrects that our Listview doesnt display anything on native. Following assumption proved to be wrong for the Message LVN_GETDISPINFOW: /* With testing on Windows 2000 it looks like the notify format has nothing to do with this message. It ALWAYS seems to be in ansi format. */ This time, only LVN_*ETDISPINFOW is patched, anything else is untouched. -Anybody please tell me if you see problems with this Fix since i dont want to break things.- Tho

3 8

Re: COM / Installshield status?
by Tony Lambregts Nov. 1, 2004

Nov. 1, 2004

Dan Kegel wrote: >Likewise, what's the current status of Installshield support, >and how much work would it be to fully support >Installshield-based installers? I don't see any >open Installshield bug reports, maybe I should file >one against the apps I have that don't install at >the moment. (Or would that be overkill?) > There are lots of bugs against installshield. http://appdb.winehq.org/bugs.php?appId=995. There are 7 that are open and 1 that is marked as later. -- Tony Lambregts

1 0

COM / Installshield status?
by Dan Kegel Oct. 31, 2004

Oct. 31, 2004

What's the current status on bug 423 (http://bugs.winehq.com/show_bug.cgi?id=423) "Out-of-process COM support"? There hasn't been anything added to that bugzilla entry for two years, and presumably there has been some progress. Perhaps someone in the know could update that bug report. Likewise, what's the current status of Installshield support, and how much work would it be to fully support Installshield-based installers? I don't see any open Installshield bug reports, maybe I should file one against the apps I have that don't install at the moment. (Or would that be overkill?) Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0