November 2004 - Wine-Devel - list.winehq.org

"Crystallography programs under Wine"
by Dan Kegel Nov. 14, 2004

Nov. 14, 2004

I just ran into http://www.ccp14.ac.uk/solution/wine/ which lists about ten free Windows apps used for crystalography, and how to run them under Wine. I guess these deserve an appdb entry; they don't seem to have one yet. That page describes workarounds needed to run with Wine as of about three years ago. Things may have progressed since then. For instance, the "you must rename files to have lower case" workaround no longer seems neccessary for the INDX program. I wrote the maintainer about that, haven't heard back from him yet. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: taskmodal messagebox implementation, take 3
by Ivan Leo Puoti Nov. 14, 2004

Nov. 14, 2004

> No problem. I'll give a lengthy reply in the hope it can help other folks > dealing with this sort of thing too. Well, your code works, and I've made it into a patch. I've also removed what I beleive is a useless if check from MSGBOX_OnInit(). Due to my lame webmail client you code arrived with no indentation, so in the future please attach any code you send to me. If you think the attached patch is OK I'll forward it to wine-patches. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: [D3D] Some surfaces related fixes
by Christian Costa Nov. 14, 2004

Nov. 14, 2004

Mike Hearn wrote: >On Sun, 14 Nov 2004 13:40:15 +0000, Christian Costa wrote: > > >>+ if ((pDDSD->dwFlags & DDSD_LPSURFACE) && (pDDSD->lpSurface == NULL)) { >>+ /* Frank Herbert's Dune specifies a null pointer for the surface, ignore the LPSURFACE field */ >>+ FIXME("Null surface pointer specified, ignore it!\n"); >>+ pDDSD->dwFlags &= ~DDSD_LPSURFACE; >>+ } >>+ >> >> > >Apps passing in bogus data should normally be a trace or warn at most, >unles there is actually something to fix here it doesn't make sense to use >a fixme as it'll inevitably get users asking about it .... > >thanks -mike > > > > > Your're right, Mike. :-) I will resend a patch for that. Thanks. Christian

1 0

Re: taskmodal messagebox implementation, take 3
by Juan Lang Nov. 14, 2004

Nov. 14, 2004

Hi Ivan. --- Ivan Leo Puoti <puoti(a)inwind.it> wrote: > Please consider I'm no programming wiz and I'm learning as I go along. No problem. I'll give a lengthy reply in the hope it can help other folks dealing with this sort of thing too. > Now, I don't see how else I could get MSGBOX_EnumProc() to remember the > values > of those that now are static variables, apart from using the heap for > everything, that seems a bit inefficent as we know how much data we want > to > store, or global variables, do you think I should use global ones > instead? > If not suggestions are welcome. Globals are also not thread-safe. Generally for thread safety, I'd suggest the following: declare a structure that has all the data you want to modify in MSGBOX_EnumProc, something like: struct MsgBoxEnumProcParams { int pass; int counter1; int counter2; int heapcheck; HWND *handles; }; In MessageBoxIndirectW, create one of these and pass its address as the LPARAM value to EnumThreadWindows(). However, this ignores style issues. I have problems with names like "counter1" and "counter2"; they don't tell me what they mean. Also, I don't like the magic values 0, 1, 2, 3, 4 for the LPARAM value; at the least these should be symbolic constants. Pass 3 doesn't modify the parameters at all, so it really should get its own callback function. It looks like heapcheck's purpose is to see whether handles has in fact been allocated. You could instead make sure to set handles to NULL when it isn't allocated. Also, there's the possibility of a memory leak in pass 4. I'd suggest the caller should be responsible for memory allocation. With these suggestions, I've come up with the following changes. I haven't checked whether this code works (or even compiles), it's just my attempt at rewriting what you're trying to do: struct ThreadWindows { UINT numHandles; UINT handlesLen; HWND *handles; }; BOOL CALLBACK MSGBOX_CountDisabledThreadWindows(HWND hwnd, LPARAM lParam) { if (!lParam) return FALSE; if (!IsWindowEnabled(hwnd)) *(UINT *)lParam++; return TRUE; } BOOL CALLBACK MSGBOX_EnumDisabledThreadWindows(HWND hwnd, LPARAM lParam) { if (!lParam) return FALSE; if (!IsWindowEnabled(hwnd)) { struct ThreadWindows *threadWindows = (struct ThreadWindows *)lParam; if (threadWindows->numHandles < threadWindows->handlesLen) threadWindows->handles[threadWindows->numHandles++] = hwnd; } return TRUE; } INT WINAPI MessageBoxIndirectW( LPMSGBOXPARAMSW msgbox ) { LPVOID tmplate; HRSRC hRes; int ret; UINT i; struct ThreadWindows threadWindows = { 0, 0, 0 }; static const WCHAR msg_box_res_nameW[] = { 'M','S','G','B','O','X',0 }; if (!(hRes = FindResourceExW(user32_module, (LPWSTR)RT_DIALOG, msg_box_res_nameW, msgbox->dwLanguageId))) return 0; if (!(tmplate = (LPVOID)LoadResource(user32_module, hRes))) return 0; /*handle task modal message boxes*/ if ((msgbox->dwStyle & MB_TASKMODAL) && (msgbox->hwndOwner==NULL)) { EnumThreadWindows(GetCurrentThreadId(), MSGBOX_CountDisabledThreadWindows, (LPARAM)&threadWindows.numHandles); if (threadWindows.numHandles) { threadWindows.handles = (HWND *)HeapAlloc(GetProcessHeap(), 0, threadWindows.numHandles * sizeof(HWND)); if (threadWindows.handles) threadWindows.handlesLen = threadWindows.numHandles; threadWindows.numHandles = 0; } EnumThreadWindows(GetCurrentThreadId(), MSGBOX_EnumDisabledThreadWindows, (LPARAM)&threadWindows); for (i = 0; i < threadWindows.numHandles; i++) DIALOG_DisableOwner(threadWindows.handles[i]); } ret=DialogBoxIndirectParamW(msgbox->hInstance, tmplate, msgbox->hwndOwner, MSGBOX_DlgProc, (LPARAM)msgbox); if ((msgbox->dwStyle & MB_TASKMODAL) && (msgbox->hwndOwner==NULL)) { for (i = 0; i < threadWindows.numHandles; i++) DIALOG_EnableOwner(threadWindows.handles[i]); if (threadWindows.handles) HeapFree(GetProcessHeap(), 0, threadWindows.handles); } return ret; } The changes I've made: I've renamed counter1 and counter2 to numHandles and handlesLen. handlesLen is the allocated number of handles, while numHandles is the number of handles actually stored. (Your code already dealt with the possibility of their being different: well done!) I've also used handles as its own guard; if it's NULL, it's not allocated. Otherwise it is. Like I suggested, I pass a pointer as an LPARAM to the two EnumThreadWindows callback functions. It seems two calls to EnumThreadWindows were unnecessary, since we already knew the window handles, so I just iterate over the values in handles rather than calling EnumThreadWindows again. If I'm incorrect in my understanding, of course change it. And, the caller is always responsible for memory allocation and freeing. I think this is safer than having the callback function do it. > >Any reason you aren't using HeapAlloc instead? > As this heap is only used by MSGBOX_EnumProc(), is there any reason why > I should > use HeapAlloc? It's sometimes easier to debug memory problems with the Windows heaps than with the libc ones. --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

winzip 9 doesn't run under wine :-(
by Dan Kegel Nov. 14, 2004

Nov. 14, 2004

While putting together a tutorial on how to contribute test cases to Wine (http://kegel.com/wine/sweng/) I noticed that the current version 9 of WinZip doesn't install under vanilla Wine; it aborts with the message WinZip was unable to locate a recent version of the Windows HTML help viewer, which is required to display WinZip help. ... Seems like a bit of a showstopper. What's the plan for addressing this? Is it a 0.9 feature? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 8

ListView DrawText Flags
by Zach Gorman Nov. 14, 2004

Nov. 14, 2004

Dimitrie - You have a patch back in 2002 that cleans up the listview DrawText() code in comctl32. When calling DrawText from a single-line edit control, you don't pass DT_NOPREFIX. Is this intentional, or just an oversight? My testing on Windows shows that & characters do not get converted to _ even in the single-line edit control case (indicating that DT_NOPREFIX should be passed). Thanks, Zach

2 1

Missing file names in WINEDBG
by lats Nov. 14, 2004

Nov. 14, 2004

In the last week WINEDBG has stopped outputting the file/path and linenumber of entries in the backtrace. Does anyone know what happened? Jeff

3 3

Re: taskmodal messagebox implementation, take 3
by Juan Lang Nov. 13, 2004

Nov. 13, 2004

Ivan, a couple comments on this. You wrote: +BOOL CALLBACK MSGBOX_EnumProc(HWND hwnd, LPARAM lParam) +{ + static int counter1, counter2, heapcheck=0; + static HWND *handles; static variables aren't thread safe. Two threads attempting to do task modal dialogs (yes, this is probably strange) could result in weird failures. + handles=(HWND*)malloc(counter1*sizeof(HWND)); Any reason you aren't using HeapAlloc instead? --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

dlls/commdlg/fontdlg.c regression
by Gerald Pfeifer Nov. 13, 2004

Nov. 13, 2004

The following change to dlls/commdlg/fontdlg.c revision 1.70 date: 2004/08/14 00:42:35; author: julliard; state: Exp; lines: +2 -5 Jacek Caban <jack(a)itma.pwr.wroc.pl> Fix a bug in passing parameters to CFn_WMInitDialog and CFn_WMCommand in FormatCharDlgProcW. causes the following warning with GCC 3.3.2 on FreeBSD 4.10: fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from incompatible pointer type Would you mind fixing this? Thanks, Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 3

Using a DIB to reduce number of calls to X
by Arjen Nienhuis Nov. 13, 2004

Nov. 13, 2004

GradientFill can be implemented by drawing to a DIB, and then blting that DIB to the screen. This will reduce the number of calls to X from O(n) to O(1). 1. Is that a good idea? Any caveats? 2. Can that method be used elsewhere? I'll try to implement it right away. P.S. We do implement the alpha part of GradientFill the same as Windows. The comments might sugest otherwise.

2 1

For the appdb hackers
by Ivan Leo Puoti Nov. 13, 2004

Nov. 13, 2004

It would be great if I could delete/approve apps and go to the next one without having to go back to adminAppQueue.php Thanks for the work you're doing, it was badly needed. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Kernel 2.6.9
by Paul Rupe Nov. 13, 2004

Nov. 13, 2004

Has anyone tried Wine with Linux kernel 2.6.9? I'm getting crashes with this version that don't happen when I reboot back to 2.6.8.1. I haven't had much luck debugging it so far, but each time, ps shows a <defunct> wine-preloader process and wineserver still running. -- Paul Rupe <prupe(a)myrealbox.com>

7 10

Re: ws2tcpip.h: Define socklen_t
by felix.nawothnig＠t-online.de Nov. 13, 2004

Nov. 13, 2004

On 11/13/2004 02:22:18 AM, I wrote: > We don't have socklen_t defined anywhere and that's the place where > it's defined in the official headers so... WASTE compiles fine now... > (I'm sure there is a reason why it isn't defined but I can't see it - > so tell me why this will be rejected... err... if it will be... :-) Ooops... WINE doesn't build anymore, I guess that's a good reason. :) Sorry... Anyway, what's the correct way to get socklen_t then? Would it make sense to do... #ifndef __socklen_t_defined typedef int socklen_t; # define __socklen_t_defined #endif ...or prefix it with WS() maybe? Or should I just include unistd.h in winelib apps? (Not sure if that's possible even since I'm using MSVCRT...) -flx

1 0

enhmfdrv: ExtSelectClipRgn
by Jon Griffiths Nov. 13, 2004

Nov. 13, 2004

Hi, My app gives me a FIXME from dlls/gdi/enhmetafile.c at line 1144 complaining that ExtSelectClipRgn is not implemented (and then proceeds to draw rather corrupted looking pictures). Looking at the code there is an implementation, but its been #ifdef'd out. removing the #if 0 doesn't produce any noticable change in my app. Does any one have any idea why this was removed, or what is needed to make it work? Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Checking up header files ( take 2 : mmsystem.h )
by Eric Pouech Nov. 13, 2004

Nov. 13, 2004

Rémi Assailly a écrit : > Changelog: > * set MAXERRORLENGTH to 256 > * set MMSYSERR_LASTERROR to (MMSYSERR_BASE + 20) > * set MIDIERR_LASTERROR to (MIDIERR_BASE + 7) > * add some structure tags I think it's worthless bumping the LASTERROR values if you don't add the missing error values in the .h file A+

1 0

Re: Toolbar: Cleanup Patch
by Dimitrie O. Paun Nov. 12, 2004

Nov. 12, 2004

On Mon, Nov 08, 2004 at 11:27:44AM -0600, Robert Shearman wrote: > Changelog: > - bNtfUnicode is a dup' of bUnicode so remove it and fix the few places > where it was used. bUnicode is a bad name for this flag, bNtfUnicode would be better, as bUnicode is sometimes use to denote how the text is stored in the control, which is different from how notifications should be sent. -- Dimi.

2 2

Re: Kernel 2.6.9
by Ivan Leo Puoti Nov. 12, 2004

Nov. 12, 2004

>What could possibly be different between our systems that would cause >this problem? Anything but wine and the kernel, could you try this binary package and see if it works? Like this you can find out if it's a runtime or compile time problem. http://prdownloads.sourceforge.net/wine/wine-20041019-mdk.i586.rpm?download Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Re: just a little thing in dlls/winmm/lolvldrv.c
by Bill Medland Nov. 12, 2004

Nov. 12, 2004

On November 12, 2004 12:17 pm, Rémi Assailly wrote: > Changelog: > * just replace all (sizeof(MM_MLDrvs) / sizeof(MM_MLDrvs[0]) by > MAX_MM_MLDRVS to be more readable. ( I think it is ) I think it isn't. (sizeof(a)/sizeof(a[0]) or (sizeof(a)/sizeof(*a)) is a standard statement that means "the number of elements in a". Some people make a macro such as COUNTOF(a) to make it more readable but the expanded version is quite standard. The altered version is less readable because one then has to go back to the definition of MAX_MM_MLDRVS and its uses to see that indeed it is (or at least is supposed to be) the number of elements in the array that the statements are protecting. -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

1 0

Re: Kernel 2.6.9
by Ivan Leo Puoti Nov. 12, 2004

Nov. 12, 2004

> I forgot to mention that I'm using latest wine CVS. So am I and wine works fine, on mdk 10.1 kernel 2.6.8.1-12mdk. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: Dbghelp: enhance PDB support
by Dimitrie O. Paun Nov. 12, 2004

Nov. 12, 2004

On Thu, Nov 11, 2004 at 09:25:46PM +0100, Eric Pouech wrote: > This (huge) patch does: > - apart from restructuring the code (COFF handling goes to new coff.c > file, Codeview and PDB defines and types to new mscvpdb.h file) ^^^^^^^^^ Shouldn't this be named msvcpdb.h? -- Dimi.

3 2

Tables For Standard Caption Buttons' Metrics?
by William Poetra Yoga H Nov. 12, 2004

Nov. 12, 2004

In windows/nonclient.c, the captions on caption buttons are calculated (according to the button size, which is determined by some system metrics). This is due to the fact that we don't have a replacement for the Marlett font used in Windows. But simple formulae can't reproduce the captions correctly. I've taken some screenshots of the caption buttons in Windows XP (with the classic theme, so I think the results can be reproduced in earlier versions). I think we can reproduce Windows' behavior with a table. For every value of SM_CYCAPTION, we have one table entry. This way, we can save space (the table is a lot smaller than a table of bitmaps) and still reproduce correct behavior. Anyone has comments on this? __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

2 3

Enabling gcov patch not accepted
by Aaron Arvey Nov. 11, 2004

Nov. 11, 2004

Hi, I recently sent in a patch concerning enabling gcov in wine (http://www.winehq.org/hypermail/wine-patches/2004/11/0136.html) and it doesn't seem to have been incorporated in the main cvs branch :(. I have never contributed to wine before so I'm not sure how to get feedback on my patch in order to improve it so that it is accepted. If either Alexandre or anyone else believes they know why my patch wasn't accepted, please let me know. I personally have found gcov to be very helpful and I think other developers may find that to be true too. If you would like to know more about gcov, please read the documentation included in my patch (url above). Thank you, Aaron

3 2

shreg tests on xp vs 95/98
by James Hawkins Nov. 11, 2004

Nov. 11, 2004

I've been working on figuring out the behaviour of SHQueryValueEx using XP for testing. I know that on XP SHQueryValueEx just calls SHRegGetValue, so any results from testing SHQueryValueEx match those documented about SHRegGetValue and even those not documented. What I'm wondering is if SHQueryValueEx behaves the same on other platforms ie 95/98/NT etc. If you'd like to test it, run the attached test on your platform and report the results back. Thankyou for taking the time to help figure this one out. BTW you can ignore this error for now (I'll look into it after this): shreg.c:270: Test failed: didn't open copy -- James Hawkins

1 0

Cxbx
by Dimitrie O. Paun Nov. 11, 2004

Nov. 11, 2004

Hi Folks, Willie Sippel suggested I port the Bxbx Xbox emulator to Winelib. And I did, patch attached. It seems like we need a multimon.h, any takers? More on the emulator: Home: http://www.caustik.com/cxbx/ http://sourceforge.net/projects/cxbx/ -- Dimi.

1 0

ODBC - MSSQL
by Pablo Szuster Nov. 11, 2004

Nov. 11, 2004

Hi, i´m trying to access a MSSQL server (in a windows machine in the network) from a Visual Basic Application running under wine, using an ODBC driver. Since there aren´t any MSSQL drivers for linux i decided to use de native ones, so i installed mdac_typ.exe . Then i configured the DSN using odbcad32.exe but when i tested the connection (configured using tcp/ip) an error message appeared ("[Microsoft][ODBC SQL Server Driver][TCP/IP Sockets] General network error. Check your network documentation"). Do i have to install some network drivers for wine?? Has anyone been able to connect to a MSSQL server remotely using odbc under wine?? __________________________________________________ Todavía no tenés tu Ciudad Internet Mail? Obtenelo ahora! - http://webmail.ciudad.com.ar Descargá Gratis el nuevo Internet Explorer 6.0, el mejor software para actualizar tu PC. http://www.ciudad.com.ar/ar/servicios/ie/

2 1