November 2004 - Wine-Devel - list.winehq.org

Re: Fix DLL loader regression
by Mike Hearn Nov. 8, 2004

Nov. 8, 2004

Any problem with this one Alexandre? On Thu, 04 Nov 2004 01:00:37 +0000, Mike Hearn wrote: > - Always add .dll extension when loading modules > > > Index: loader.c > =================================================================== > RCS file: /home/wine/wine/dlls/ntdll/loader.c,v > retrieving revision 1.78 > diff -u -p -r1.78 loader.c > --- loader.c 11 Oct 2004 20:59:06 -0000 1.78 > +++ loader.c 4 Nov 2004 00:56:48 -0000 > @@ -1432,12 +1432,18 @@ static NTSTATUS find_dll_file( const WCH > len = nt_name.Length - 4*sizeof(WCHAR); /* for \??\ prefix */ > if (len >= *size) goto overflow; > memcpy( filename, nt_name.Buffer + 4, len + sizeof(WCHAR) ); > + > + /* do we need to add the .dll extension? */ > if (file_part && !strchrW( file_part, '.' )) > { > len += sizeof(dllW) - sizeof(WCHAR); > if (len >= *size) goto overflow; > strcatW( filename, dllW ); > + RtlFreeUnicodeString( &nt_name ); > + if (!RtlDosPathNameToNtPathName_U( filename, &nt_name, &file_part, NULL )) > + return STATUS_NO_MEMORY; > } > + > if (!(*pwm = find_fullname_module( filename ))) > { > attr.Length = sizeof(attr);

2 1

Scrollbars
by Nicolai Kuntze Nov. 8, 2004

Nov. 8, 2004

Hi, I have played with my continuing bug (#2302) but I have some problems understanding the meaning of the output: fixme:win:GetWindowModuleFileNameA GetWindowModuleFileNameA(hwnd 0x40032, lpszFileName 0x40670548, cchFileNameMax 80) stub! trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=1 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=1 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=2 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=2 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=3 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=3 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 If my blue bar in the list disappears pos Value counts how many lines under the window I am. I have added a little debug to follow the source ... From the developer I got the following snipplet: int SViewLow::ViewSetScrollY( int PPos, int PMax, int PPage) { SCROLLINFO Scroll; memset( &Scroll, 0, sizeof( Scroll)); Scroll.cbSize= sizeof( SCROLLINFO); Scroll.fMask= 0; if (PPos!=-1) Scroll.fMask|= SIF_POS; if (PMax!=-1) Scroll.fMask|= SIF_RANGE; if (PPage!=-1) Scroll.fMask|= SIF_PAGE; Scroll.nPos= PPos; Scroll.nPage= PPage; Scroll.nMax= PMax-1; return SetScrollInfo( (HWND)ViewGetHWND(), SB_VERT, &Scroll, TRUE); } Does anyone has an idea what this could be? Yours, Nicolai

2 1

Re: Re: Winetest questions
by Chris Morgan Nov. 8, 2004

Nov. 8, 2004

> On Sun, Nov 07, 2004 at 02:01:13PM -0800, Dan Kegel wrote: > > 1. Why are all the archived posts to wine-test-results empty? > > See http://www.winehq.org/hypermail/wine-tests-results/2004/11 > > Every message body is empty! What's up with that? > > That's a good question. Chris, what's going on? > I suspect these are clients that have issues connecting to the net to upgrade their version of winrash since there are relatively few error reports compared to the number of test result submissions. We should really have the script ignore empty requests like this as they don't tell us anything and simply spam the mailing list every day. Chris

1 0

Re: Fix for metafile test
by Dan Kegel Nov. 8, 2004

Nov. 8, 2004

jakov(a)vmlinux.org wrote: > This is from when I ran winetest.exe from the desktop: > > http://test.winehq.org/data/200411021000/2000/gdi32:metafile.txt : > > metafile.c:126:hdcDisplay 76010815 > metafile.c:154:hdcMetafile 202107C1 > metafile.c:40:hdc 76010815, emr->iType 1, emr->nSize 108, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 82, emr->nSize 368, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 40, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 14, emr->nSize 20, param 0022FB58 > metafile: 151 tests executed, 0 marked as todo, 0 failures. Here's what I get when I run 'make test' on Wine: ../../../../wine/tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so ../../../../wine/dlls/gdi/tests/metafile.c && touch metafile.ok metafile.c:91: Test failed: pass 0: dx[0] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[1] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[2] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[3] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[4] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[5] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[6] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[7] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[8] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[9] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[10] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[11] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[12] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[13] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[14] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[15] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[16] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[17] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[18] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[19] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[20] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[21] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[22] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[23] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[24] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[25] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[26] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[27] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[28] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[29] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[30] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[31] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[32] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[33] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[34] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[35] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[36] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[37] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[38] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[39] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[40] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[41] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[42] (1081735508) didn't match 4 make[3]: *** [metafile.ok] Error 43 Is the metafile test supposed to be broken like this under Wine? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 2

Re: wine/ tools/wine.inf include/config.h.in dlls/ ...
by Vincent Béron Nov. 8, 2004

Nov. 8, 2004

Le jeu 04/11/2004 à 16:15, Alexandre Julliard a écrit : > Log message: > Michael Jung <mjung(a)iss.tu-darmstadt.de> > Implemented a substantial part of rsaenh.dll. > > Patch: http://cvs.winehq.org/patch.py?id=14412 The committed patch doesn't compile on RH8. OpenSSL doesn't use the same name for some datatypes/functions as the version used by Michael (actually the prototype is different as well). OpenSSL 0.9.7a (as found on FC1) will use OPENSSL_ENABLE_OLD_DES_SUPPORT by default which will #define the old names to the new ones for the DES functions. RSAPrivateKey_dup is only defined in x509.h in OpenSSL 0.9.6b, not in rsa.h. But pulling in x509.h also includes md4.h, md5.h and sha.h (via evp.h), which redefine MD4_CTX (and MD5 and SHA _CTX also) with an incompatible definition if the NO_MD4, etc. are not defined. Changelog: Allow rsaenh compilation with older (0.9.6b) OpenSSL version. Remove a cast from const to not-const. Vincent

2 1

Do we need one of those on our docs?
by Shachar Shemesh Nov. 8, 2004

Nov. 8, 2004

From the samba developer's guide, http://us1.samba.org/samba/devel/ > *Important:* In order to avoid any potential licensing issues we > also ask that anyone who has signed the Microsoft CIFS Royalty > Free Agreement > <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cifs/proto…> > not submit patches to Samba, nor base patches on the referenced > specification. We ask, too, that patches submitted to Samba not > infringe on any known patents. Finally, as with all GPL work, the > submitter should ensure that submitted patches do not conflict > with any third-party copyright. > > Do we need to put in something like that too? I'm not a lawyer (but I can probably get one). My understanding is that the "protocols" Microsoft policy don't really affect us. What may affect us is the wider and wider distribution of the Windows source code (Shared Source). We should not be highly affected by trade secrets: anyone publishing a trade secret is nullifying the secretness of it, and is the one bearing the responsibility for this action. However, copyright problems may be a problem for us. If someone takes a significant amount of code from MS and submits it, we may have some backtracking to do. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: signaling unix threads
by Dan Kegel Nov. 8, 2004

Nov. 8, 2004

Mike Hearn wrote: > I quite liked Michaels idea of the RT signals. Is there some reason we > can't use them? I didn't see Michael's proposal. Can you point to it? Now, I don't pretend to understand the issues here, but reading your patch, http://www.winehq.org/hypermail/wine-patches/2004/11/att-0041/01-patch__cha… I see the comment * ... there is a race with SuspendThread(): the app * can call SuspendThread() then GetThreadContext() whilst the * target is processing SIGUSR1 but before it's been able to * override the thread context, ie the context returned would be * meaningless to the app (internals of Wine itself). I understand similar races are present in real Windows, too. e.g. http://blogs.msdn.com/cbrumme/archive/2003/08/20/51504.aspx says "[with SuspendThread,] there’s a significant risk of leaving a thread suspended at a “bad” spot. If you call SuspendThread while a thread is inside the OS heap lock, you better not try to allocate or free from that same heap. In a similar fashion, if you call SuspendThread while a thread holds the OS loader lock (e.g. while the thread is executing inside DllMain) then you better not call LoadLibrary, GetProcAddress, GetModuleHandle, or any of the other OS services that require that same lock. Even worse, if you call SuspendThread on a thread that is in the middle of exception dispatching inside the kernel, a subsequent GetThreadContext or SetThreadContext can actually produce a blend of the register state at the point of the suspension and the register state that was captured when the exception was triggered. If we attempt to modify a thread’s context (perhaps bashing the EIP – on X86 – to redirect the thread’s execution to somewhere it will synchronize with the GC or other managed suspension), our update to EIP might quietly get lost." I guess we just need to have races no worse than in Windows :-) About RT signals - I would tread carefully here. RT signals are a precious resource. The queue is not very deep, and it's *per system* on Linux IIRC. When I used RT signals for I/O, they overflowed the queue all the time -- and if any program in the system is doing that, it affects your program, since the queue is shared. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

wine under cygwin
by James Hawkins Nov. 7, 2004

Nov. 7, 2004

I'm trying to compile wine under cygwin, but I am getting this error: Entering directory `/home/James Hawkins/wine/dlls/dsound/tests' gcc capture.o ds3d.o ds3d8.o dsound.o dsound8.o propset.o testlist.o -o dsound_test.exe -ldsound -lole32 -luser32 -lkernel32 -ldxguid -luuid -ldxerr8 /usr/lib/w32api/libdxguid.a(dxguid.o)(.rdata+0x1f20):dxguid.c: multiple definition of `_DSPROPSETID_DirectSoundDevice' propset.o(.rdata+0x10):/home/James Hawkins/wine/dlls/dsound/tests/propset.c:62: first defined here /usr/lib/w32api/libdxguid.a(dxguid.o)(.rdata+0x1f30):dxguid.c: multiple definition of `_CLSID_DirectSoundPrivate' propset.o(.rdata+0x0):/home/James Hawkins/wine/dlls/dsound/tests/propset.c:61: first defined here collect2: ld returned 1 exit status make[3]: *** [dsound_test.exe] Error 1 make[3]: Leaving directory `/home/James Hawkins/wine/dlls/dsound/tests' make[2]: *** [tests] Error 2 make[2]: Leaving directory `/home/James Hawkins/wine/dlls/dsound' make[1]: *** [dsound] Error 2 make[1]: Leaving directory `/home/James Hawkins/wine/dlls' make: *** [dlls] Error 2 Has anyone successfully compiled wine under cygwin, or does anyone have an idea of what the problem is? -- James Hawkins

1 0

winipcfg.exe issues
by Saulius Krasuckas Nov. 7, 2004

Nov. 7, 2004

[s2(a)katleriai antras]$ /sbin/ifconfig | grep ^[^\ ] eth0 Link encap:Ethernet HWaddr 00:50:22:80:F0:49 lo Link encap:Local Loopback ppp0 Link encap:Point-to-Point Protocol If run winipcfg with Wine, it lets me to change the adapter I want to inspect by selecting its name in combox (as usually). But if I hold the down-key pressed down for some seconds, Wine terminates the application: [s2(a)katleriai antras]$ wine /home/s2/cc/Program\ Files/winipcfg.exe wine client error:21: no fd received for handle 88 While the key is pressed, adapter info is being periodically refreshed. Does that means the app leaks some handle? Or is this a bug in Wine? What debug channel would you recommend to use to see more details on this?

1 0

SetupComm insize 1600 outsize 1600
by MediaHost (TM) Nov. 7, 2004

Nov. 7, 2004

Hi Wine Developers, Question: I need to use a Win app on Linux and everything seams fine, except that the communication with the serialport doesn't work. Well, also here, everything seams fine to me, so I want to get your advice. The only thing I could see is the unimplemented stub for "SetupComm insize outsize". Can I set it by my own (setserial) or what's the meaning of it anyway? The output below seams to me pretty good...: fixme:comm:SetupComm insize 1600 outsize 1600 unimplemented stub trace:comm:GetCommState handle 0x54, ptr 0x778ef948 trace:comm:GetCommState OK trace:comm:GetCommState bytesize 8 baudrate 2400 fParity 0 Parity 0 stopbits 1 trace:comm:GetCommState ~IXON ~IXOFF trace:comm:GetCommState fOutxCtsFlow 0 fRtsControl 1 trace:comm:GetCommState fOutxDsrFlow 0 fDtrControl1 trace:comm:GetCommState ~CRTSCTS trace:comm:SetCommState handle 0x54, ptr 0x778ef948 trace:comm:SetCommState bytesize 8 baudrate 1200 fParity 0 Parity 0 stopbits 1 trace:comm:SetCommState ~IXON ~IXOFF trace:comm:SetCommState fOutxCtsFlow 0 fRtsControl 1 trace:comm:SetCommState fOutxDsrFlow 0 fDtrControl1 trace:comm:EscapeCommFunction handle 0x54, function=5 trace:comm:EscapeCommFunction SETDTR trace:comm:EscapeCommFunction handle 0x54, function=4 trace:comm:EscapeCommFunction CLRRTS trace:comm:SetCommTimeouts (0x54,0x778ef934) trace:comm:PurgeComm handle 0x54, flags 4 trace:comm:PurgeComm handle 0x54, flags 8 ]# cat /proc/tty/driver/serial serinfo:1.0 driver:5.05c revision:2001-07-08 0: uart:16550A port:3F8 irq:4 baud:2400 tx:11 rx:0 RTS Best Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org MediaHostT at www.mediahost.org Skype: startcom

2 2