November 2004 - Wine-Devel - list.winehq.org

Re: misc. crypt test mem leak fixes
by Dmitry Timoshkov Nov. 30, 2004

Nov. 30, 2004

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * misc. crypt test mem leak fixes Apparently lines with LocalAlloc were added by mistake instead of LocalFree. -- Dmitry.

2 1

Problem with file dialog
by Stefan Dösinger Nov. 30, 2004

Nov. 30, 2004

Hello, This patch breakes the file open/save dialog for me: http://www.winehq.org/hypermail/wine-cvs/2004/11/0086.html The 5 buttons(go up one folder, go to desktop, new folder, ...) appear above the directory selektor and have a height of only a few pixels, so the icons are not visible and it's hard to click the buttons(see the attached screenshot). Reversing lines 89-96 of the patch solves the problem. I don't send a patch, because I don't think simply reversing the lines is the correct solution. What is a correct fix for this? Cheers, Stefan

2 2

Porting SmartWin a Windows API GUI library...
by Thomas Hansen Nov. 30, 2004

Nov. 30, 2004

I'm the admin of http://smartwin.sourceforge.net and I've been thinking that if this library (SmartWin) could be ported to WineLib that would be really awesome... I would definitely take it right into the CVS (unless it breaks everything) and I'd make it a definitely focus trying to keep the compatibility towards WineLib in later releases... I assume it would be a nice project to do too. (not too much code, only about 15 000 lines with LOTS of comments) Not to mention the benefit it would give the community having a Windows API library being ported to Wine... Comments sombody...? Thomas Hansen -- http://smartwin.sourceforge.net THE template based C++ Windows API GUI Abstraction Library

2 1

Re: icmstream mem leak fix
by Mike McCormack Nov. 30, 2004

Nov. 30, 2004

Hi James, That looks kind of wrong, both the before and after... Interfaces should be released, not free'd... Secondly, freeing the interface if the Query works is almost definitely wrong, because ppv will likely point to the same memory as pstream. Mike James Hawkins wrote: > hr = IAVIStream_QueryInterface((IAVIStream*)pstream, riid, ppv); > - if (FAILED(hr)) > - LocalFree((HLOCAL)pstream); > + > + LocalFree((HLOCAL)pstream); > > return hr; > }

2 4

Re: Systray rewrite
by Grant Williamson Nov. 30, 2004

Nov. 30, 2004

Hi Mike, patching is clean on 20041019, however .. fails with make[2]: Entering directory `/tmp/wine-20041019/dlls/shell32' ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./shell32.spec shell.spec.o shell.o authors.o autocomplete.o brsfolder.o changenotify.o classes.o clipboard.o control.o cpanelfolder.o dataobject.o debughlp.o dialogs.o dragdrophelper.o enumidlist.o folders.o iconcache.o memorystream.o pidl.o regsvr.o shell32_main.o shelllink.o shellole.o shellord.o shellpath.o shellreg.o shellstring.o shfldr_desktop.o shfldr_fs.o shfldr_mycomp.o shlexec.o shlfileop.o shlfolder.o shlfsbind.o shlmenu.o shlview.o shpolicy.o shv_bg_cmenu.o shv_item_cmenu.o systray.o shell32.dll.dbg.o shres.res version.res -o shell32.dll.so -L../../dlls -Wb,-dole32 -lshlwapi -lcomctl32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -L../../libs/wine -lwine -luuid -L../../libs/unicode -lwine_unicode -L../../libs/port -lwine_port shell32_main.o(.text+0x23c6): In function `DllMain': /usr/src/redhat/BUILD/wine-20041019/dlls/shell32/shell32_main.c:962: undefined reference to `SYSTRAY_Init' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [shell32.dll.so] Error 2 make[2]: Leaving directory `/tmp/wine-20041019/dlls/shell32' make[1]: *** [shell32] Error 2 make[1]: Leaving directory `/tmp/wine-20041019/dlls' make: *** [dlls] Error 2 Mike Hearn wrote: >Here it is, at last, just what the doctor ordered. All in a separate >wineshell process, and with cleaner code to boot. No thread safety >needed. Hopefully this is now satisfactory and can go in. > >The intention is that wineshell becomes a generic explorer-alike process >in terms of responsibility. For now, I have it being started >automatically by shell32 (to avoid the startup penalty), and shutting >down a few seconds after the last icon is gone like the wineserver. If >we start putting more stuff in there like a DDE server, we may have to >rethink that strategy. > >ChangeLog: >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > > >

1 0

Re: working together on stdole.tlb and a end to dcom9x
by Sam Lauber Nov. 30, 2004

Nov. 30, 2004

Sure, send me both. The precompiled one would be useful to test OLE, and the source would be useful to test OLE, Winelib, and the Wine DLLs. Also, a few months ago, I did a web search for the OLE problem, and turned up an old thread on the Wine mailing list that actually had stdole32.odl. The URL is http://www.winehq.org/hypermail/wine-devel/2003/01/0858.html. I tried it with MS mktyplib (with Wine DLLs). Strangly, it produced the exact same FIXMEs that the C program generated, but generated a diffrent typelib. And more then two bytes differed. The two typelibs are attached. I'll try it with InstallShield. Samuel Lauber ----- Original Message ----- From: "Boaz Harrosh" <boaz(a)moeg.org> To: "Sam Lauber" <sam124(a)operamail.com> Subject: Re: working together on stdole.tlb and a end to dcom9x Date: Mon, 29 Nov 2004 10:18:43 +0200 > > Sam Lauber wrote: > > > Someone should develop a Wine testcase that tests typelibs. Does anyone know of a typelib testcase? > > > > > > > Last I checked wine with native ole would crash on any simple WTL > project hosting an OCX. It would crash at the point it was trying to > query for the typelibs and interface info inside the typelib. So first > thing I'd do is Just compile a simple WTL app hosting any OCX. > > Do you need that I send you one? Compiled on VC6 on windows? What OCX > can one use that would work with native ole? > Is source OK? or you also need a compiled exe with debug info (.pdb)? > > Free Life > Boaz > -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

2 1

Changed IE6 install script to run IE6 completely out-of-box
by Hajime Segawa Nov. 30, 2004

Nov. 30, 2004

As mentioned in WWN #250 : >If you dissect the script you'll notice a lot of what it does is install some proprietary DLL's. Specifically, DCOM98, MFC 4.0, >and Microsoft Installer. So yes, it's cheating and Wine isn't running these completely out of the box. However, you can run them. I changed the install script a bit and it does not depend on DCOM98, MFC4.0, etc... anymore. So, you can run IE6 completely out-of-box. New script is here : http://sidenet.ddo.jp/winetips/files/wine-config-sidenet-1.5.3.tgz

3 6

Re: Moved dll list from DEVELOPERS-HINTS into separated file
by Jon Griffiths Nov. 29, 2004

Nov. 29, 2004

Hi, >I personally don't think it's really useful without more detailed >information on each dll, but in any case this belongs to one of the >sgml documents, not a stand-alone ASCII file. c2man.pl will generate a blurb for each dll in the source tree when building API docs, if one of the dlls source files contain a supplimental comment named after the dll. IMHO this is the best place to put a description of the dll. It appears in the generated docs above the list of exported functions and makes a natural lead-in to the dlls documentation page. The info is then also available by "man dllname" if the generated docs are installed. See the top comment in dlls/shlwapi/shlwapi_main.c for an example. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com

1 0

Re: Translate dir names into Spanish
by Juan Lang Nov. 29, 2004

Nov. 29, 2004

Joaqu�n wrote: > I have some programs in spanish for windows but when i install it i have > problems with dir names, for example "Program Files" is "Archivos de > programa", "Common Files" is "Archivos comunes", and so. > > Can i translate this names in source and compiling without problem?? > which files i need update?? Yes, you can. You need to modify the file dlls/shell32/shell32_Es.rc. Look at dlls/shell32/shell32_En.rc. The end of the file as a stringtable with the comment /* shell folder path default values */. Copy this stringtable to shell32_Es.rc, and translate the names appropriately. Recompile and reinstall. Please send a patch with the updated translations to wine-patches(a)winehq.org, too. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

1 0

Re: working together on stdole.tlb and a end to dcom9x
by Sam Lauber Nov. 29, 2004

Nov. 29, 2004

No. I used the InstallShield program for Flash MX, and it didn't work. Without stdole32.tlb, it whined like a baby about OLE. With stdole32.tlb, it (not the whole system) froze up during the "preparing" stage when it hit 100% and left a phantom window that was blank when and after I quit Wine. I think, for InstallShield, someone has to implement a special trap(s) for OLE calls. Also, a stdole32.tlb copied from a real Windows system didn't work. Clearly, it isn't a hole in InstallShield, but in Wine's typelib support. Someone should develop a Wine testcase that tests typelibs. Does anyone know of a typelib testcase? Samuel Lauber ----- Original Message ----- From: "Steven Edwards" <steven_ed4153(a)yahoo.com> To: "Vincent "Béron"" <vberon(a)mecano.gme.usherb.ca>, "Filip Navara" <xnavara(a)volny.cz> Subject: Re: working together on stdole.tlb and a end to dcom9x Date: Sun, 28 Nov 2004 17:54:48 -0800 (PST) > > Hi Vincent, > > --- Vincent Béron <vberon(a)mecano.gme.usherb.ca> wrote: > > Was the resulting stdole32.tlb file (generated on Wine) a suitable > > replacement for Microsoft's? IE, does InstallShield works better with > > this file than without any stdole32.tlb file? > > I think it will work. One thing we have discussed in ReactOS was using > the tools as part of our stage2 setup. If there is not a easy way to > implement these tools in WIDL like Alexandre wanted maybe making them > tools that are run via wineprefixcreate on first run is a acceptable > solution? > > Thanks > Steven > > > > > __________________________________ > Do you Yahoo!? > Read only the mail you want - Yahoo! Mail SpamGuard. > http://promotions.yahoo.com/new_mail > > -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

2 1