December 2004 - Wine-Devel - list.winehq.org

ownerdraw paint recursion in listbox
by Alexander Yaworsky Aug. 4, 2005

Aug. 4, 2005

Hello, recently i tried to install some application and it hung when i tried to select options. It uses listbox with ownerdraw items with checkboxes. When listbox is initially painted everything is ok. But when i try to select other item, an extra WM_PAINT is sent to listbox when application draws item. This causes infinite recursion. I've been implemented a simple workaround adding boolean to listbox structure but i have doubts. I briefly looked at some other controls and had not noticed similar countermeasures. Have somebody ever seen such behaviour? It would be interesting to test other controls sending WM_PAINT from ownerdraw handler but i'm short of time to do it soon. Should this workaround implemented in this way or something is wrong deeper with WM_PAINT handling? Thanks.

2 7

rpcrt4.dll NdrGetUserMarshalInfo() problem
by J. Grant July 2, 2005

July 2, 2005

Hello, I am getting the attached error when running an install of Overnet v0.52. Basically it cannot find NdrGetUserMarshalInfo(), despite it being in the dll at entry point: 77d43452h, order 199. Any ideas what this problem could be? I'm expecting this to be the symptom of some wider problem. Any help appreciated. Kind regards JG p.s. Is there any way to get these mangled function names to be displayed un-mangled please? c:\opt\overnet_0_52>overnet c:\opt\overnet_0_52>err:module:import_dll No implementation for MSVCRT.dll.??_U(a)YAPAXI@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V(a)YAXPAX@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

3 3

lotus notes regression
by Paul R Streitman June 25, 2005

June 25, 2005

Patch 14725, applied 2004/12/07 11:31:53, breaks lotus notes. The symptom is a hang with the CPU at 100%, and it happens immediately if you try to click on a notes 'bookmark', or shortly after you try to do much of anything else if you try to avoid the 'bookmarks'. Sorry that it took me so long to report this, when I decided that it wasn't just a temporary instability I eventually had to iteratively compile (many) CVS snapshots to narrow down when the problem was introduced because I found it impossible to untangle the various patches that went in around that time frame. I also ran afoul of the jack problems near the end. I do not know how to narrow the problem down further. I tried running winedbg (at CVS level a couple of days ago), and that seems to be broken too -- it wanted to run things from the wine build tree? There are no unusual console messages or anything when the problem happens. Thanks, Paul z/OS core components development Internet: prs(a)us.ibm.com

7 8

Support for IDvdInfo2::GetDiscID
by James Courtier-Dutton March 25, 2005

March 25, 2005

The Windows api method uses the function call IDvdInfo2::GetDiscID http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… This returns a unique 64bit ID for a DVD. Has anyone found out what exactly it does to create this 64bit ID. It would be nice to get linux DVD players to be able to use the same method. Cheers James

2 2

Re: edit control
by Robert Shearman March 9, 2005

March 9, 2005

Ulrich Czekalla wrote: >Running some tests under WinXP I noticed that if the edit control doesn't >have WS_EX_CLIENTEDGE it looses the WS_BORDER style and it handles painting >the border. This also has the side effect that it's non-client area goes to >zero. > >ChangeLog: > Ulrich Czekalla <ulrich(a)codeweavers.com> > Handle painting the border if WS_EX_CLIENTEDGE is not set > > This changelog doesn't really seem to match the patch. Are you sure it's right? >------------------------------------------------------------------------ > >Index: dlls/user/edit.c >=================================================================== >RCS file: /home/wine/wine/dlls/user/edit.c,v >retrieving revision 1.2 >diff -u -r1.2 edit.c >--- dlls/user/edit.c 9 Sep 2004 19:18:40 -0000 1.2 >+++ dlls/user/edit.c 15 Sep 2004 16:30:50 -0000 >@@ -4423,13 +4423,18 @@ > /* > * In Win95 look and feel, the WS_BORDER style is replaced by the > * WS_EX_CLIENTEDGE style for the edit control. This gives the edit >- * control a non client area. Not always. This coordinates in some >- * way with the window creation code in dialog.c When making >- * modifications please ensure that the code still works for edit >- * controls created directly with style 0x50800000, exStyle 0 ( >- * which should have a single pixel border) >+ * control a nonclient area so we don't need to draw the border. >+ * If WS_BORDER without WS_EX_CLIENTEDGE is specified we shouldn't have >+ * a nonclient area and we should handle painting the border ourselves. >+ * >+ * When making modifications please ensure that the code still works >+ * for edit controls created directly with style 0x50800000, exStyle 0 >+ * (which should have a single pixel border) > */ >- es->style &= ~WS_BORDER; >+ if (lpcs->dwExStyle & WS_EX_CLIENTEDGE) >+ es->style &= ~WS_BORDER; >+ else if (es->style & WS_BORDER) >+ SetWindowLongW(hwnd, GWL_STYLE, es->style & ~WS_BORDER); > > This doesn't seem right at all. The new code should be exactly the same as the old, barring any side effects from SetWindowLong (which shouldn't affect the control anyway since this the function changed is the handler for WM_NCCREATE). Rob

3 3

text edit box not painting text ( on form startup )
by Doug Herbert March 9, 2005

March 9, 2005

( I have posted a similiar question in wine-users, don't flame me for doing so, just thinking about this some more, perhaps it may be more a developer question ) Ok, I have a windows app, that runs under wine fine - not quite. This app has a form, with many text field edit boxes on. Quite often these edit boxes already have text values, ie. they are not empty - there is a database behind the form. Anyway, the form shows on the screen, but the text within the edit fields is invisible, until you activate each edit box component. When you leave one edit box to the next, the text remains visible. It seems like the repainting is not working, on initial startup of the form. As a way to debug this database app ( I don't have the source code for it ) I wrote a real basic form app in Visual Studio, with two edit boxes, with data in each. Now this basic app shows the text values immediately on startup. So there must be something different that the database app is not doing. I then ran wine using 'wine --debugmsg +edit programname' for both app's. I see both logging 'Creating ANSI edit control, style = xxxxx' but the style reference is different between apps - I am not sure if this the cause or not. The problem app reports style = 54011104 and the basic app shows style = 50010080. Can somebody explain what this style reference means and how do I force an app to use a certain style of edit box ? What other wine class debugmsg types should I use to narrow down the source of this problem ? Is there anyway I can check to see how the database app is repainting text within the text edit components ? Regards Doug Herbert. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

3 4

Re: ptrace single-stepping change breaks Wine
by Eric Pouech Jan. 29, 2005

Jan. 29, 2005

> Btw, does wine ever _use_ PTRACE_SINGLESTEP for any of the things it does? > > If it does, then that woulc certainly explain why my "fix" made no > difference: my fix _only_ handles the case where the ptracer never > actually asks for single-stepping, and single-stepping was started > entirely by the program being run (ie by setting TF in eflags from within > the program itself). > > But if wine ends up using PTRACE_SINGESTEP because wine actually wants to > single-step over some instructions, then the kernel will set the PT_DTRACE > bit, and start tracing through signal handlers too. The way Wine doesn't > want.. wine mixes both approches, we have (to control what's generated inside the various exception) to ptrace from our NT-kernel-like process (the ptracer) to get the context of the exception. Restart from the ptracer is done with PTRACE_SINGLESTEP. (BTW: I also CC:ed wine-devel ML, that might be of interest to them too) A+

14 85

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]
by Mike Hearn Jan. 17, 2005

Jan. 17, 2005

>>Well, apparently we don't use sched_yield, so the problem must >>> lie somewhere else. Maybe Con can help us out here? Alexandre says he >>> doesn't know what the issue is either and somebody needs to investigate. I >>> guess we do need to concern ourselves over the details :) > > > Interesting. Probably the most valuable information is that it seems to > work fine if we artificially limit the threads to exactly the same > timeslice _or_ we put them at such a low priority that they are forced > to be guaranteed to round robin one task at a time. This is the way 2.4 > used to work which is why with the new 2.6 schedulers which do far more > out-of-order rescheduling some applications have a problem; particularly > under load. I suspect it's actually the latter issue. Locking between > threads should prevent that being a problem, though. You already > mentioned that you dont use sched_yield() and I couldn't even begin to > look at the wine code myself so perhaps you know something more. Hi Con, One thought that occurred to me, and this is just a random theory, is that maybe the issue is not with the Wine code but the Win32 code run on top of it. Do you know how 2.6 scheduling compares with 2.4 and Windows (NT) scheduling? Could it be that some apps are written to expect Windows-style scheduling and fail to work if they don't get it? In case you hadn't noticed, I'm afraid I only have first-year CS knowledge of scheduling :/ thanks -mike

17 43

Fwd: Foobar2000 audio player Regression
by Nick Hornback Jan. 10, 2005

Jan. 10, 2005

I originally posted this to the -users list, but I was contacted by Robbert Xerox, who had the exact same issue, and thus far nobody has replyed in the users list, so maybe it will get more attention here. > Foobar2000 worked virtually perfectly in the 20041019 > release (aside from some comctrl32 repainting issues > -- which native comctrl32.dll fixed), but in 20041201 > it is completely unuseable. Two major problems: > 1) The toolbars are completely gone. They are sort-of > displayed when they get activity via mouse-press or > whatever, but they do not repaint correctly at all. > See this screenshot for details: > http://img20.exs.cx/my.php?loc=img20&image=w1ifoobar.gif > 2) It takes 100% cpu. In the 20041021 release, it > hovered around 5% cpu (on my athlon 64 3200+), which > was excellent because that beat most native linux > audio players. > The console log is as follows (no errors or warnings): > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,2)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002a,-4,0)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002c,-4,0)-stub! > fixme:win:SetWindowTextA cannot set text "" of other > process window (nil) > Does anyone know what is going on here? I have since found out that if you use a the builtin comctrl32.dll, none of the window repaints at all. In previous wine releases, using the builtin comctrl32.dll would just create minor glitches (ex. the status bar wouldn't update). __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail

4 6

another build problem on current cvs
by Joris Huizer Jan. 9, 2005

Jan. 9, 2005

Hello, For the past week or so, building from cvs on a debian/stable system w/ alsa installed (using a custom kernel Linux debian 2.4.18.041216) breaks on alsa-specific code in wine; I attached the log; note that I did a `cvs update -dPA` and `make distclean` so this can't be any problem with the source I have Any ideas? Maybe you can point me to a place where I can read how to fix this properly (I never worked on alsa-specific code before...) or something like that regards, Joris

4 7

Should we get rid of the wine-license list?
by Scott Ritchie Jan. 3, 2005

Jan. 3, 2005

Looking at the archives it appears that wine-license has had very little traffic, to the point where a lot of it is probably not being read when it comes up, since people like me are not subscribed to that list. It seems like a lot of the stuff being sent there should instead go to wine-devel. Thoughts? Scott Ritchie

7 7

Hyperthreading and SMP
by Kenneth Porter Jan. 3, 2005

Jan. 3, 2005

Does WINE have any problem with either Hyperthreading or SMP? I've found that locking the Tribes Vengeance dedicated server to a single logical CPU seems to give me better performance as the server fills with players. CPU usage seems significantly lower (45% versus 65%). Is this likely to be a WINE issue or a TV issue? (TV is based on the Unreal Tournament engine, with the Havok physics engine integrated to handle vehicle. Alas, unlike UT2004, there's no native Linux server for TV.) More here: <http://lists.matureasskickers.net/pipermail/tvservers/2004-December/000186.…> I want to try disabling HT or setting affinity on my co-admin's Win2003 server to see if he sees the same boost.

2 4

Approving of the WINEprobe initiative
by David Gümbel Jan. 2, 2005

Jan. 2, 2005

Hello everybody, - as my colleague Stefan Munz has already pointed out recently[1] on this list, Wirtschaftsförderung Region Stutgart GmbH (WRS) and us (ITOMIG) are launching an initiative called WINEprobe[2]. Its goal is to make local software vendors aware of the potential bussiness opportunity in a WINE-based port or a WINE/Linux version of their software. WRS is quite committed as far as Open Source is concerned[3], and is pushing OSS in the region since quite a time. It has co-organized, among others, the KDE World Summit 2004 in Ludwigsburg near Stuttgart[4]. The Perlworkshop 6.0 , GUADEC6 (GNOME Conference) [5], ApacheCon Europe and more than 40 other Open Source Events in the Stuttgart Region are organized or supported by the WRS as well. (You can find a description of WRS at the bottom of this mail.) In order to make the WINEprobe initiative beneficial for the WINE project as much as possible, three things are in the making: 1) At the option of the respective software vendor whose product we'll be analyzing for WINE compatibility, Application Database Entries will be maintained by us once a software product has been analyzed for its compatibility with WINE. 2) Reports of successful porting or migration projects will be given back to the community as success stories. My colleage is already working on merging some success stories supplied by third parties (see [6]). 3) WRS has offered to help out in hosting the WINE developers conference Wineconf in 2005 in the Stuttgart area[7]. Mr. Schmid from WRS has asked me (please see the mail below) to provide some information about this initiative to the WINE community. He thinks (and I agree ;) that it would help us a great deal in making the campaign a success if the WINE community somehow "officially" (as official as a community can be :) approved of this initiative. So my question, on behalf of Mr. Schmid, is simply if there are objections against us saying that this initiative is approved of by the WINE community? As an important sidenote, I permit myself to emphasize that all of our above mentioned efforts (1-3) to support the WINE project and its community are fully independent of the answer of this question. Most particularily, the hosting offer stands, and the commitment there won't be lowered if the WINEprobe is not approved of by the community. However, I feel that a successful WINEprobe will be a benefit for the WINE project as well. If there are any questions open, please feel free to ask. Cheers, David ---------- Forwarded Message ---------- Subject: AW: Update on WRS offer & Stuttgart University Date: Montag 20 Dezember 2004 14:46 From: "Hans-Ulrich Schmid" <hans-ulrich.schmid(a)region-stuttgart.de> To: David Gümbel <david.guembel(a)itomig.de> Dear Mr. Gümbel, as you know, ITOMIG and Stuttgart Region is planning to start a new initiative for small and medium software companies called "WINEprobe". "WINEprobe" will help these companies to learn more about the WINE-compatibility of their software products. It would be very helpful, if you can ask the WINE-community to support this new initiative officially. The hosting offer of the Stuttgart Region will not be affected by any way of the decision of the community in the point of supporting the "WINEprobe" or not. Can you please forward this mail to the community and tell them some more about the background of "WINEprobe" Best regards Hans-Ulrich Schmid Wirtschaftsförderung Region Stuttgart GmbH Stuttgart Region Economic Development Corporation FIR_st - Forum IT-Region Stuttgart Friedrichstr. 10 70174 Stuttgart www.first.region-stuttgart.de www.opensource.region-stuttgart.de www.competenzatlas.de www.region-stuttgart.de Tel ++49.711.22835 - 27 Tel mobil ++49.172.7310463 Fax ++49.711.22835 - 55 ------------------------------------------------------- ------------------------------------------------------- WRS description: The Stuttgart Region Economic Development Corporation (WRS) is - founded to provide services to industry and communities in the field of economic development - a subsidiary of the administrative body of the larger Stuttgart Region - provides marketing for the Stuttgart Region - assists in cluster management of specific industries - advises and assists companies during the search for available sites and buildings In the context of our initiative "Open Source Region Stuttgart" http://opensource.region-stuttgart.de the WRS supports conferences and meetings of Open Source projects of various aspects when held in the Stuttgart Region. For example the WRS is co-organizer of the KDE Community World Summit 2004 in Ludwigsburg near Stuttgart http://conference2004.kde.org/ . The Perlworkshop 6.0 , GUADEC6 (GNOME Conference) http://2005.guadec.org/papers.html , ApacheCon Europe and more than 40 other Open Source Events in the Stuttgart Region are organized or supported by the WRS as well. ------------------------------------------------------- [1] http://www.mail-archive.com/wine-devel%40winehq.org/msg11549.html [2] WINEprobe means be something like WINEtasting in english an maybe "degustation de WINE" in french. [3] See http://opensource.region-stuttgart.de/ (.de only, sorry) [4] http://conference2004.kde.org/ [5] http://2005.guadec.org/papers.html [6] http://www.mail-archive.com/wine-devel%40winehq.org/msg11630.html [7] http://www.winehq.org/hypermail/wine-devel/2004/11/0647.html

8 14

Re: Remove heap.h
by Filip Navara Dec. 31, 2004

Dec. 31, 2004

Jon Griffiths wrote: >+ docA.lpszDocName = WtoA( doc->lpszDocName ); >+ docA.lpszOutput = WtoA( doc->lpszOutput ); >+ docA.lpszDatatype = WtoA( doc->lpszDatatype; > Isn't there a missing parenthesis?

1 0

Re: ITSS: DllCanUnloadNow implementation
by Robert Shearman Dec. 31, 2004

Dec. 31, 2004

Jacek Caban wrote: > Changelog: > Implemented DllCanUnloadNow > > BOOL WINAPI ITSS_DllCanUnloadNow(void) > { >- FIXME("\n"); >- >- return FALSE; >+ TRACE("dll_count = %lu\n", dll_count); >+ return !dll_count; > > This function should return an HRESULT, not a BOOL. This error would have been caught if it weren't for the silly ITSS_ prefix. Consequently, the return value should be either S_OK or S_FALSE depending on whether there are no or some remaining references respectively. Rob

1 0

Looking for Software which uses the MS Crypto API
by Michael Jung Dec. 30, 2004

Dec. 30, 2004

Hello, In order to test rsaenh.dll, I'm looking for software, which applies the Microsoft Crypto-API. Any suggestions? It would be ideal, if the source is available. Ciao, Michael

3 3

Re: Remove heap.h
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 07:57:31AM -0800, Jon Griffiths wrote: > Hi, > > After applying, include/heap.h can be removed from cvs. To be honest, I'm not too happy with this patch, HEAP_strdupWtoA was a good marker for code that needed fixing, this patch just makes those places harder to find. -- Dimi.

2 2

Re: Get rid of DPRINTF in x11drv/opengl.c
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:04:23PM +0100, Diego 'Flameeyes' Pettenò wrote: > I had some spare time, and I wanted to do some mostly non-designing code, so I > took the time to look at wine's janitorial projects, and I took a look at the > DPRINTF -> TRACE conversion. > > The attached patch removes DPRINTFs from x11drv/opengl.c (which is the only > file in x11drv which uses them), and replacing the 6 different following > calls with a single call for bits and buffer counters. This is a good project to work on, but the reason it's not done yet it's because it is not a simple replacement of DPRINTF with TRACE. Doing stuff like: + TRACE(" - size / version : %d / %d\n", ppfd->nSize, ppfd->nVersion); + TRACE(" - dwFlags : "); Will not work correctly in a multitreaded environment, where the lines may get intertwinded on output with statements from other threads. The way to do it is to prepare the output in a memory buffer, and output it at once. This can be done with the wine_dbg_sprintf() function. In cases where you need logic to construct the output (like testing for flags, etc), you can do it by first printing to a local buffer, and then printing the content of the buffer to a debug buffer via wine_dbg_sprintf(). A simple example of this technique can be found in the dlls/kernel/locale.c file, in the debugstr_lang() function. -- Dimi. -- Dimi.

2 1

Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation
by Jonathan Gevaryahu Dec. 30, 2004

Dec. 30, 2004

Eric Pouech <pouech-eric(a)wanadoo.fr> wrote: >To: Anish Mistry <mistry.7(a)osu.edu> >Cc: wine-devel(a)winehq.org >Subject: Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total > Annihilation > >and if you remove the entire line (if (!is_version_nt()) access = >TIMER_ALL_ACCESS;)? >A+ > > >--__--__-- > That doesn't fix the problem here. Still the same trace response... I haven't run it enough times to see if it will still occasionally work with that line altered or removed... I know it does work (without any changes from the version in CVS) about 5% of the time. Jonathan Gevaryahu lord_nightmare(a)users.sf.net

6 6

Re: Get rid of DPRINTF in wininet
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:33:52PM +0100, Diego 'Flameeyes' Pettenò wrote: > I hope only my usual karma is not here this time or I'll make everybody lost > time ^^ I'm afraid it is <g>. This is a case where the wine_dbg_sprintf() business is in order. -- Dimi.

2 1

Re: Get rid of DPRINTF in opengl32
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:37:12PM +0100, Diego 'Flameeyes' Pettenò wrote: > Hi, > this time is a very small patch, it simply replace DPRINTF with TRACE without > oher changes. Once again, a job for wine_dbg_sprintf(). -- Dimi.

1 0

Re: Get rid of DPRINTF in winedos
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:22:18PM +0100, Diego 'Flameeyes' Pettenò wrote: > Hi, > The attached patch replaces DPRINTF -> TRACE in winedos dll, joining the near > DPRINTF used to tace dos interrupts. This looks good, but do we still need the explicit 'if (TRACE_ON(relay))'? I think we can use the explicit one from TRACE(), no? -- Dimi.

1 0

NLS/IME functions
by Diego 'Flameeyes' Pettenò Dec. 30, 2004

Dec. 30, 2004

Hi, I'm still trying to figure out how nls/ime functions are placed in windows systems to fix up the patch I sent some days ago. I haven't had the time to find out if YuGiOh calls GetProcAddress (because isn't mine, it's of a friend of mine which is trying to get it working, so I need him to test), so I'm fooling around checking for a way to fix this up. At least Win98's and Win2k's user32.dll have the functions defined into winnls32.h, also if they are defined as compatibility with winnt3. At the moment on wine these functions are commented out also as stubs so they are completely missing. On Windows I'm not able to find a winnls32.dll which is instead present on wine, and seems to define similar functions (but they are quite all spec-stubs, but three functions which are defined (stubbing), without a STUB trace. How should be this done? Implement stub-functions for every nls/ime function? Or simply ignore them for now? Thanks for the time, -- Diego "Flameeyes" Pettenò flameeyes(a)users.berlios.de - http://flameeyes.web.ctonet.it/

1 0

build problem on current cvs
by Stefan Leichter Dec. 29, 2004

Dec. 29, 2004

Hello, i hope you all had nice Christmas. Now back to business :-) trying to build current cvs (~7:45 AM UTC) i get the error: make[1]: Entering directory `/usr/src/wine/wine-build/include' ../tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include -h -H oaidl.h ../../wine/include/oaidl.idl ../../wine/include/wtypes.idl:1: Oops, segment violation make[1]: *** [oaidl.h] Abgebrochen make[1]: *** Datei »oaidl.h« wird gelöscht make[1]: Leaving directory `/usr/src/wine/wine-build/include' make: *** [include] Fehler 2 My system is still SuSE 9.0. I am doing 'out of tree' builds. Bye Stefan

3 7

Re: clean-up
by Eric Blade Dec. 29, 2004

Dec. 29, 2004

My apologies for not responding, I had attempted to sign up for the list, and that had failed. Oops! Now, here I am. :) Paul van Schayck said, about the <<br />> .. oops, that was a mistake in my search/replace.. I thought I had fixed all of those occurences that I made. Also, for the !loggedin() || !have_priv(admin) .. i just copied that code from another module, that had used it in that exact same spot.. the file had a comment that said "// check for admin access here" .. :P no, i don't think it should be !loggedin() && !have_priv(admin) .. that wouldn't make sense, if it were &&.. that needs to be an || . Re: Johnathan Ernst: As I said, I had just copied the code from the other places in the admin/* files that used it. Before I changed that, the code simply said: if(!loggedin()) .. which meant anyone logged in could access that admin function. It does make sense that if not logged in you couldn't have admin privs, so I could change all the files to check that instead. So, my next question.. do you have to have admin priv to be a maintainer? Becauses some of the files check for loggedin, havepriv(admin) and maintainer flags. Should admin/adminCommentView.php be protected? I realise it's in the admin category, but it doesn't look like anyone can get into any mischief with that.. could almost be handy for users. --- anyway, i've fixed those issues, merged it to latest CVS, and will be re-sending it off in just a minute. Thanks :) __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: [AppDB] Small appbrowse cleanup
by Chris Morgan Dec. 29, 2004

Dec. 29, 2004

Please, no tabs :-P Chris On Wednesday 29 December 2004 7:10 am, Paul van Schayck wrote: > weird

1 0

Re: [QUARTZ] Some stuff to start the graph
by Robert Shearman Dec. 29, 2004

Dec. 29, 2004

Christian Costa wrote: > Hi, > > Changelog: > Implemented IMediaControl_Run that explores the graph, counts > renderers and starts filters. > Better implementation of IBaseFilter_Run for AVI SPlitter and AVI > Decompressor. > Use the standard memory allocator when an output pin does not provide > any allocator. > Set allocator properties for AVI Decompressor output pin and update > the buffers size at connection time. > > Christian Costa titan.costa(a)wanadoo.fr > >------------------------------------------------------------------------ > >Index: dlls/quartz/avidec.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/avidec.c,v >retrieving revision 1.12 >diff -u -r1.12 avidec.c >--- dlls/quartz/avidec.c 27 Dec 2004 17:15:58 -0000 1.12 >+++ dlls/quartz/avidec.c 29 Dec 2004 09:06:24 -0000 >@@ -235,6 +235,9 @@ > pAVIDec->pBihOut->biCompression = 0; > pAVIDec->pBihOut->biSizeImage = pAVIDec->pBihOut->biWidth * pAVIDec->pBihOut->biHeight * pAVIDec->pBihOut->biBitCount / 8; > >+ /* Update buffer size of media samples in output */ >+ ((OutputPin*)pAVIDec->ppPins[1])->allocProps.cbBuffer = pAVIDec->pBihOut->biSizeImage; >+ > pAVIDec->init = 1; > TRACE("Connection accepted\n"); > return S_OK; >@@ -354,7 +357,13 @@ > > if (SUCCEEDED(hr)) > { >- hr = AVIDec_OutputPin_Construct(&piOutput, NULL, NULL, AVIDec_Output_QueryAccept, &pAVIDec->csFilter, &pAVIDec->ppPins[1]); >+ ALLOCATOR_PROPERTIES props; >+ props.cbAlign = 1; >+ props.cbPrefix = 0; >+ props.cbBuffer = 0; /* Will be updated at connection time */ >+ props.cBuffers = 2; >+ >+ hr = AVIDec_OutputPin_Construct(&piOutput, &props, NULL, AVIDec_Output_QueryAccept, &pAVIDec->csFilter, &pAVIDec->ppPins[1]); > > if (FAILED(hr)) > ERR("Cannot create output pin (%lx)\n", hr); >@@ -502,6 +511,8 @@ > This->state = State_Running; > } > LeaveCriticalSection(&This->csFilter); >+ >+ OutputPin_CommitAllocator((OutputPin *)This->ppPins[1]); > > This needs to be inside the critical section. > > return hr; > } >Index: dlls/quartz/avisplit.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/avisplit.c,v >retrieving revision 1.10 >diff -u -r1.10 avisplit.c >--- dlls/quartz/avisplit.c 27 Dec 2004 17:15:58 -0000 1.10 >+++ dlls/quartz/avisplit.c 29 Dec 2004 09:06:26 -0000 >@@ -327,6 +327,7 @@ > { > HRESULT hr = S_OK; > AVISplitter *This = (AVISplitter *)iface; >+ int i; > > TRACE("(%s)\n", wine_dbgstr_longlong(tStart)); > >@@ -337,6 +338,17 @@ > } > LeaveCriticalSection(&This->csFilter); > >+ hr = PullPin_InitProcessing(This->pInputPin); >+ >+ if (SUCCEEDED(hr)) >+ { >+ for (i = 1; i < This->cStreams + 1; i++) >+ { >+ OutputPin_CommitAllocator((OutputPin *)This->ppPins[i]); >+ } >+ hr = PullPin_StartProcessing(This->pInputPin); >+ } >+ > return hr; > } > > And so does this. ... > /*** IMediaControl methods ***/ > static HRESULT WINAPI Mediacontrol_Run(IMediaControl *iface) { > ICOM_THIS_MULTI(IFilterGraphImpl, IMediaControl_vtbl, iface); >+ int i; >+ IBaseFilter* pfilter; >+ IEnumPins* pEnum; >+ HRESULT hr; >+ IPin* pPin; >+ LONG dummy; >+ PIN_DIRECTION dir; > >- TRACE("(%p/%p)->(): stub !!!\n", This, iface); >+ TRACE("(%p/%p)->()\n", This, iface); > >+ if (This->state == State_Running) >+ return S_OK; >+ >+ /* Explorer the graph from source filters to renderers, determine renderers number and >+ * run filters from renderers to source filters */ >+ This->nRenderers = 0; > ResetEvent(This->hEventCompletion); > >+ for(i = 0; i < This->nFilters; i++) >+ { >+ BOOL source = TRUE; >+ pfilter = This->ppFiltersInGraph[i]; >+ hr = IBaseFilter_EnumPins(pfilter, &pEnum); >+ if (hr != S_OK) >+ { >+ ERR("Enum pins failed %lx\n", hr); >+ continue; >+ } >+ /* Check if it is a source filter */ >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ IPin_QueryDirection(pPin, &dir); >+ if (dir == PINDIR_INPUT) >+ { >+ source = FALSE; >+ break; >+ } >+ } >+ if (source == TRUE) >+ { >+ TRACE("Found a source filter\n"); >+ IEnumPins_Reset(pEnum); >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ /* Explore the graph downstream from this pin */ >+ ExploreGraph(This, pPin, 0); >+ } >+ IBaseFilter_Run(pfilter, 0); >+ } >+ IEnumPins_Release(pEnum); >+ } >+ >+ This->state = State_Running; >+ > return S_FALSE; > } > > And this all needs to be protected by a critical section too. > >@@ -1191,7 +1287,9 @@ > OAFilterState *pfs) { > ICOM_THIS_MULTI(IFilterGraphImpl, IMediaControl_vtbl, iface); > >- TRACE("(%p/%p)->(%ld, %p): stub !!!\n", This, iface, msTimeout, pfs); >+ TRACE("(%p/%p)->(%ld, %p): semi-stub !!!\n", This, iface, msTimeout, pfs); >+ >+ *pfs = This->state; > > > This probably needs protection too. Rob

2 3

Re: [QUARTZ] Some stuff to start the graph (take 2)
by Robert Shearman Dec. 29, 2004

Dec. 29, 2004

Christian Costa wrote: > Hi, > > This time with more thread safety. Looking better, but one more change needed. In addition, most of the code in filtergraph.c isn't thread safe. Thread safety is particularly important in DirectShow where threads are heavily used. Debugging random crashes is not fun. ... > /*** IMediaControl methods ***/ > static HRESULT WINAPI Mediacontrol_Run(IMediaControl *iface) { > ICOM_THIS_MULTI(IFilterGraphImpl, IMediaControl_vtbl, iface); >+ int i; >+ IBaseFilter* pfilter; >+ IEnumPins* pEnum; >+ HRESULT hr; >+ IPin* pPin; >+ LONG dummy; >+ PIN_DIRECTION dir; > >- TRACE("(%p/%p)->(): stub !!!\n", This, iface); >+ TRACE("(%p/%p)->()\n", This, iface); >+ >+ if (This->state == State_Running) >+ return S_OK; > > > This should be inside the critical section, being careful, of course, not to return without calling LeaveCriticalSection. >+ EnterCriticalSection(&This->cs); >+ >+ /* Explorer the graph from source filters to renderers, determine renderers number and >+ * run filters from renderers to source filters */ >+ This->nRenderers = 0; > ResetEvent(This->hEventCompletion); > >+ for(i = 0; i < This->nFilters; i++) >+ { >+ BOOL source = TRUE; >+ pfilter = This->ppFiltersInGraph[i]; >+ hr = IBaseFilter_EnumPins(pfilter, &pEnum); >+ if (hr != S_OK) >+ { >+ ERR("Enum pins failed %lx\n", hr); >+ continue; >+ } >+ /* Check if it is a source filter */ >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ IPin_QueryDirection(pPin, &dir); >+ if (dir == PINDIR_INPUT) >+ { >+ source = FALSE; >+ break; >+ } >+ } >+ if (source == TRUE) >+ { >+ TRACE("Found a source filter\n"); >+ IEnumPins_Reset(pEnum); >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ /* Explore the graph downstream from this pin */ >+ ExploreGraph(This, pPin, 0); >+ } >+ IBaseFilter_Run(pfilter, 0); >+ } >+ IEnumPins_Release(pEnum); >+ } >+ >+ This->state = State_Running; >+ >+ LeaveCriticalSection(&This->cs); >+ > return S_FALSE; > } > > Rob

2 1

Re: UNICOWS: stub implementations
by Stefan Leichter Dec. 29, 2004

Dec. 29, 2004

Am Dienstag, 28. Dezember 2004 13:16 schrieb Hans Leidekker: > This one removes most remaining spec file stubs from unicows. It depends > on my previous patches to winspool, kernel, user, gdi, rasapi and shell. > > -Hans > > Changelog: > Stub implementations for AddMonitorW, AddPortW, AddPrintProcessorW, > AddPrintProvidorW, AdvancedDocumentPropertiesW, ConfigurePortW, > DeleteMonitorW, DeletePortW, DeletePrinterDriverW,DeletePrintProcessorW, > DeletePrintProvidorW, EnumDateFormatsExW, EnumPortsW, > EnumPrintProcessorDatatypesW, GetAltTabInfoW, GetICMProfileW, GetJobW, > GetLogColorSpaceW, GetPrintProcessorDirectoryW, > RasConnectionNotificationW, RasCreatePhonebookEntryW, RasDeleteSubEntryW, > RasDialW, RasEditPhonebookEntryW, RasGetConnectStatusW, > RasGetEntryDialParamsW RasGetEntryPropertiesW, RasGetErrorStringW, > RasGetProjectionInfoW, RasHangUpW, RasRenameEntryW, RasSetEntryDialParamsW, > RasSetSubEntryPropertiesW, SHGetNewLinkInfoW, SetICMProfileW, > UpdateICMRegKeyW. Hello Hans, you missed to send the implementations of the stubs! Bye Stefan

2 2

Re: Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

I see that the file .wine/user.reg has a line in it that reads "USERPROFILE"="c:\\Windows\\Profiles\\Administrator" but my Windows directory has no Profiles subdirectory in it: mark(a)gandalf Windows $ ls -al total 40 drwxr-xr-x 9 mark users 4096 Dec 28 10:46 . drwxr-xr-x 4 mark users 4096 Dec 28 10:46 .. -rw-r--r-- 1 mark users 0 Dec 28 10:46 .keep drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Desktop drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Favorites drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Fonts drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Inf drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Recent drwxr-xr-x 3 mark users 4096 Dec 28 10:46 Start Menu drwxr-xr-x 2 mark users 4096 Dec 28 10:46 System -rw-r--r-- 1 mark users 481 Dec 28 10:54 win.ini mark(a)gandalf Windows $ Possibly this is part of the problem??? Thanks, Mark On Tue, 28 Dec 2004 14:46:58 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > --On Tuesday, December 28, 2004 2:39 PM -0800 Mark Knecht > <markknecht(a)gmail.com> wrote: > > > I'm guessing this means WIne is compiled on this machine in a way that > > doesn't output debug information? > > > > If so (please let me know) then I'll have to look up how to compile > > to include this output. > > I installed my copy on Fedora Core 2 by building an RPM, and WINE is pretty > chatty, so the default configure options in the RPM spec file must be what > you need. > >

1 0

Re: Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

On Tue, 28 Dec 2004 14:46:58 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > --On Tuesday, December 28, 2004 2:39 PM -0800 Mark Knecht > <markknecht(a)gmail.com> wrote: > > > I'm guessing this means WIne is compiled on this machine in a way that > > doesn't output debug information? > > > > If so (please let me know) then I'll have to look up how to compile > > to include this output. > > I installed my copy on Fedora Core 2 by building an RPM, and WINE is pretty > chatty, so the default configure options in the RPM spec file must be what > you need. > I'm on Gentoo. It sticks in my mind that there is a configure option that turns this on. It's not on by default. I'm doing this on a relative's Gentoo box right now. On my Gentoo system at home I have debugging turned on so I'll wait until I get there in a couple of days and try again with debugging turned on. My though, having poked around a bit, is that there is a registry entry for each user that says whether the user has admin rights. I think that's not turned on, but I don't know if I turn it on whether it will actually work. This is all guessing. Again, Wine is not bombing out at all. I'm just getting a Windows dialog telling me that I need to be an administrator. - Mark

1 0

Re: Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

Kenneth, There are no messages when I run Wine like this: WINEDEBUG=+all wine setup.exe I'm guessing this means WIne is compiled on this machine in a way that doesn't output debug information? If so (please let me know) then I'll have to look up how to compile to include this output. - Mark On Tue, 28 Dec 2004 14:21:32 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > --On Tuesday, December 28, 2004 11:12 AM -0800 Mark Knecht > <markknecht(a)gmail.com> wrote: > > > How can I tell Wine to trick an install program into thinking the user > > has administrator rights under Windows XP? I've switched the windows > > type in the config file to winxp but the install program for Autocad > > 2005 tells me to log in again as an administrator. > > My guess is that it's either unable to write to a system directory or it's > looking for a certain group membership. Try tracing the installer and see > if it's doing something like that. > >

2 1

Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

Hi - Sorry for cross posting to both winde-devel and wine-users but I need to try and get an answer today on this. I'm at my dad's house and using Wine on his computer. How can I tell Wine to trick an install program into thinking the user has administrator rights under Windows XP? I've switched the windows type in the config file to winxp but the install program for Autocad 2005 tells me to log in again as an administrator. Thanks in advance, Mark

2 1

ptrace + Warcraft 3 issues remain (2.6.10)
by Jesse Allen Dec. 28, 2004

Dec. 28, 2004

Last I reported on Warcraft 3 with the ptrace changes in 2.6.10-rc3 is that it made some improvement, but still doesn't work. I'll will describe in detail what I know now. Since the changes in 2.6.10-rc3, Linus made a very good clean up of ptrace.c and signal.c in arch/i386/kernel. I don't want to necessarily reverse all these changes because they are good changes (ie easier to understand and hack now). So I hacked the kernel to change what is necessary to make the game run again. I have attached the patch against 2.6.10 to show the required changes. Comments on what I have learned about the 3 ptrace changes (see my original report): #1 ptrace.c In set_singlestep() and clear_singlestep(), the flag TIF_SINGLESTEP is now set and cleared. In the header file in include/asm-i386/thread_info.h, it seems to indicate to me that it is an internal flag to remember to re enable single-stepping for a thread on returning to the program. While speaking to my brother on this, we believe that this change was done correctly. But this change alone will break the game. I have looked in both wine for PTRACE_SINGLESTEP to see what it does and in the kernel for TIF_SINGLESTEP. Since set/clear TIF_SINGLESTEP causes the problem, I really need more information on everything about TIF_SINGLESTEP. #2 signal.c - Not single-stepping into signal handlers unless the tracer requests it Previous to 2.6.9-rc2, my understanding is that a call to setup_frame() would clear the trap flag in preparation for a signal delivery. Roland made a slight tweak to it and an example of it is this: if (regs->eflags & TF_MASK) { if (current->ptrace & PT_PTRACED) { ptrace_notify(SIGTRAP); } else { regs->eflags &= ~TF_MASK; } } Linus later changed it to: /* * Clear TF when entering the signal handler, but * notify any tracer that was single-stepping it. * The tracer may want to single-step inside the * handler too. */ if (regs->eflags & TF_MASK) { regs->eflags &= ~TF_MASK; if (current->ptrace & PT_DTRACE) ptrace_notify(SIGTRAP); } In 2.6.10, this new piece of code actually works with Warcraft III. I no longer have to reverse this change. The result is obvious because it makes it so you don't automatically single step into the handler, which wine doesn't really want. #3 signal.c - Clearing the trap flag if being traced by debugger in setup_sigcontext() For some reason, Warcraft III doesn't work if it is cleared here. I have no idea if this TF clear is really necessary. However, everything I've read on this seems to indicate to me that this change is important, so I need to find out what this causes to the game. I captured a log of the seh debug messages because I think this is may be where to look. I also hacked in to display trace messages in wine's dlls/ntdll/signal_i386.c showing eflags and whether TF is cleared in trap_handler() and raise_trap_exception(). I ran the game under 2.6.10 and the modded 2.6.10, to capture the working version, and the failing version. The results are fairly nonrandom and comparable and you can identify differences. Unfortunately, I cannot upload them at the moment because my connection is slow and the files are large. I'll upload it another time. Jesse

1 0

Re: [OLE #16] Comment out an assert, as we don't yet implement IRemUnknown
by Andreas Mohr Dec. 28, 2004

Dec. 28, 2004

Hi, On Tue, Dec 28, 2004 at 03:37:17PM +0000, Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Comment out an assert, as we don't yet implement IRemUnknown > > --- dlls/ole32/stubmanager.c (revision 9) > +++ dlls/ole32/stubmanager.c (local) > @@ -171,8 +175,10 @@ int stub_manager_unref(struct stub_manag > EnterCriticalSection(&m->lock); > if (!list_empty(&m->ifstubs)) > { > - ERR("PANIC: Stub manager is being destroyed with outstanding interface stubs\n"); > - assert( FALSE ); > + ERR("PANIC: Stub manager %s is being destroyed with outstanding interface stubs\n", wine_dbgstr_longlong(m->oid)); > + > + /* assert( FALSE ); */ > + /* fixme: this will happen sometimes until we do proper lifecycle management via IRemUnknown */ > } > > /* fixme: the lifecycle of table-weak marshals is not $ find|xargs grep FIXME|wc -l 11011 $ find|xargs grep fixme|wc -l 83 Might be good to keep it that way... Andreas Mohr

3 3

[AppDB] Get rid of value fillers in appSubmit.php for a new version
by Paul van Schayck Dec. 28, 2004

Dec. 28, 2004

Those value fillers are not used. We never send users back to the page when errors are found (maybe we should). Changelog: Remove registered globals from the new-version submit. They are not used.

3 4

wine: could not load kernel32.dll, status c000007b
by Serge S. Spiridonoff Dec. 28, 2004

Dec. 28, 2004

Hi, I've compiled a Win32 GUI app under Linux using WineLib but it fails to start. Any ideas what's wrong with the program? [test]WINEDEBUG=+loaddll ./dlg1 trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\msvcrt.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\advapi32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\gdi32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\user32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\winspool.drv" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\comctl32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\iphlpapi.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\rpcrt4.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\ole32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shlwapi.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shell32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\comdlg32.dll" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "krnl386.exe" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "system.drv" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "GDI.EXE" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "USER.EXE" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\x11drv.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\imm32.dll" : builtin wine: could not load kernel32.dll, status c000007b Thanks in advance, Serge

1 0

Re: MSI: free allocated buffers
by Joris Huizer Dec. 28, 2004

Dec. 28, 2004

Mike McCormack wrote: > > ChangeLog: > <aric(a)codeweavers.com> > * free allocated buffers > > The other daty I saw a lot of patches changing things like if (buffer) HeapFree(GetProcessHeap(),0,buffer); To HeapFree(GetProcessHeap(),0,buffer); Why are you adding new code with the if() statement in place again? Just curious regards, Joris

3 2

Re: Unicodify System Metrics
by Mike Hearn Dec. 28, 2004

Dec. 28, 2004

On Tue, 28 Dec 2004 00:26:36 -0500, jchevrier wrote: > --- sysparams.c.orig 2004-12-27 20:09:20.000000000 -0500 > +++ sysparams.c 2004-12-27 21:45:02.674627072 -0500 Hi, The patch looks OK at a first glance but in future please diff from the source root, preferably against CVS. thanks -mike

1 0

[AppDB] naming convention
by Jonathan Ernst Dec. 28, 2004

Dec. 28, 2004

As discussed with Chris and others on IRC we'd like to use a new variable naming convention in AppDB code. The proposed scheme is the following ("hungarian notation"): handles: $hSomeHandle integer: $iSomeInteger objects: $oSomeObject arrays: $aSomeArray strings: $sSomeString and so on. constants will still be uppercase without prefix. Do someone object this ? Jonathan

2 2

Re: free allocated buffers
by Dmitry Timoshkov Dec. 28, 2004

Dec. 28, 2004

"Mike McCormack" <mike(a)codeweavers.com> wrote: > Index: dlls/msi/action.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/action.c,v > retrieving revision 1.55 > diff -u -r1.55 action.c > --- dlls/msi/action.c 27 Dec 2004 19:12:35 -0000 1.55 > +++ dlls/msi/action.c 28 Dec 2004 06:47:04 -0000 > @@ -423,6 +423,59 @@ > } > } > > +/* Called when the package is being closed */ > +extern void ACTION_free_package_structures( MSIPACKAGE* package) > +{ > + INT i; The "extern" above should be removed. -- Dmitry.

1 0

Re: clean-up
by Chris Morgan Dec. 28, 2004

Dec. 28, 2004

Can you post a new version with the fixes that people replied with? I think the rest of the patch looks good. Chris On Thursday 23 December 2004 4:38 am, Eric Blade wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. > > > > > > __________________________________ > Do you Yahoo!? > Send a seasonal email greeting and help others. Do good. > http://celebrity.mail.yahoo.com

1 0

Re: clean-up
by Paul van Schayck Dec. 27, 2004

Dec. 27, 2004

Hey Eric, On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <ekdikeo4(a)yahoo.com> wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. What's this supposed to do: if(!$tempResult) { - echo "$query <br>\n"; + echo "$query <<br />>\n"; echo "An error occurred: ".mysql_error()."<p>"; exit; } @@ -68,7 +68,7 @@ if(debugging()) { echo $query; - echo "<br><br>"; + echo "<<br />><<br />>"; } And: -if(!loggedin()) +if(!loggedin() || (!havepriv("admin")) Shouldn't this be if(!loggedin() AND (!havepriv("admin")) Rest looks good. Kind regards, Paul

3 2

public domain code from lkcl
by Brian Vincent Dec. 27, 2004

Dec. 27, 2004

I'm not sure if this is useful to anyone, but I thought I remembered licensing being an issue with this once before: http://www.advogato.org/article/814.html "I really really AM relinquishing all copyright of all Samba-related source code that i have ever written, and am placing all that code into the Public Domain." "Specifically, but not limited to, that includes the code in samba which made its way into nmbd (dating right back to 1.9.15.p6 and before, and also including the nmbd_multiworkgroup version), all modifications of smbd that made their way into versions of 1.9.15 and up, all versions known as samba_ntdom _and_ Samba TNG, the code that i cut/paste over to FreeDCE to integrate a NamedPipe Interface plugin and also the FreeDCE NTLMSSP authentication plugin i worked on." -Brian

1 0

WINEPS and AFM
by Vitaly Lipatov Dec. 27, 2004

Dec. 27, 2004

There is a strange code in dlls/wineps/init.c file: if(!pi->Fonts) { MESSAGE("To use WINEPS you need to install some AFM files.\n"); return FALSE; } It returns FALSE if we have not any fonts described in PPD file (buildin printer). Will I remove this section at all? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

safedisc update
by Ivan Leo Puoti Dec. 26, 2004

Dec. 26, 2004

Hello geeks, I've got safedisc and ntoskrnl to load, unfortunately safedisc throws an exception as soon as it starts, so I'll be learning x86 assembly (cool!) soon to try and work this out. I've got ntoskrnl with all the correct prototypes for safedisc, and I've added some definitions to our include/winternl.h so ntoskrnl can build. Unfortunately quite a few structs are needed to compile one of the functions (IofCompleteRequest), so as I don't have time to add them right now it's commented out. These patches are strictly work in progress, but as I'll be away for a few days I'm posting them here just in case someone wants to play with them, I would also like to know if I'm adding the definitions to the winternl.h stuct correctly (For example, is it OK to have all the structs for ntoskrnl in the same place?). If anyone feels the temptation to fix the header so IofCompleteRequest compiles, please go ahead and do it. Comments/suggestions/whatever highly welcome. http://spazioinwind.libero.it/nonsolomicrosoft/header.diff http://spazioinwind.libero.it/nonsolomicrosoft/ntoskrnl.diff Ivan.

1 0

Re: AppDB update (refactoring and new ideas)
by Paul van Schayck Dec. 26, 2004

Dec. 26, 2004

Hey, On Sat, 18 Dec 2004 23:53:34 +0100, Jonathan Ernst <Jonathan(a)ernstfamily.ch> wrote: > I think we shouldn't have more than two images (one screenshot and one > thumbnail) per screenshot (having to click on a thumbnail to get a > medium sized screenshot and having an extra link to get an even bigger > screenshot is not user friendly). However you are right 1600x1400 shots > are maybe overkill so we should define two new constants in the config: It's done. It's doing exactly this. Running examples with source and the source of the class itself can be found here: http://meosource.com/firefox/wine Class is just doing image handeling and could be used right away in for example lostwages. If there are no comments I'll submit a patch and we can start using it. Paul

1 0

Re: user32: stub implementations for WINNLS* functions
by Dmitry Timoshkov Dec. 26, 2004

Dec. 26, 2004

"Diego 'Flameeyes' PettenР" <flameeyes(a)users.berlios.de> wrote: > diff -Npaur wine-orig/dlls/user/winnls.c wine/dlls/user/winnls.c > --- wine-orig/dlls/user/winnls.c 1970-01-01 01:00:00.000000000 +0100 > +++ wine/dlls/user/winnls.c 2004-12-24 17:21:24.566402048 +0100 ... > +UINT WINAPI WINNLSGetIMEHotkey(HWND hUnknown1) ... > +BOOL WINAPI WINNLSEnableIME(HWND hUnknown1, BOOL bUnknown2) ... > +BOOL WINAPI WINNLSGetEnableStatus(HWND hUnknown1) Since these APIs are IME related it would be more natural to name the file ime.c. > diff -Npaur wine-orig/include/winnls.h wine/include/winnls.h > --- wine-orig/include/winnls.h 2004-12-24 16:11:18.499482264 +0100 > +++ wine/include/winnls.h 2004-12-24 15:49:59.905643096 +0100 > @@ -757,6 +757,11 @@ BOOL WINAPI SetThreadLocale(LCID) > BOOL WINAPI SetUserGeoID(GEOID); > INT WINAPI WideCharToMultiByte(UINT,DWORD,LPCWSTR,INT,LPSTR,INT,LPCSTR,LPBOOL); > > +UINT WINAPI WINNLSGetIMEHotkey(HWND); > +BOOL WINAPI WINNLSEnableIME(HWND, BOOL); > +BOOL WINAPI WINNLSGetEnableStatus(HWND); Platform SDK has these APIs in winnls32.h file and marks them as old NT 3.x compatible. -- Dmitry.

2 4

Re: user32: stub implementations for WINNLS* functions
by Diego 'Flameeyes' Pettenò Dec. 26, 2004

Dec. 26, 2004

On Sunday 26 December 2004 01:57, Mike Hearn wrote: > They were commented out, which implies some software does a GetProcAddress > on them. Adding these sorts of stubs can break apps: have you found a > program or DLL that actually needs them? Yu Gi Oh Power of Chaos refuses to execute without them. It also seems not to call them, at least not before crash for other reasons. I thought that the spec-stubs was the ones which breaks things, for this I tried to have implementation-stubs. Regards, -- Diego "Flameeyes" Pettenò flameeyes(a)users.berlios.de - http://flameeyes.web.ctonet.it/

1 0

Determining the color depth of X?
by d13f00l Dec. 25, 2004

Dec. 25, 2004

Hey. I've been trying to iron out a couple bugs running some programs in wine. Running ZSNES reports that ZSNES cannot run in 24 bit depth mode. I'm also running an old game that uses dibs, I took a profiler to wine. We repeatedly call convert_888_to_0888_asis on a surface per blit. The game determines the color depth by what depth you're running windows at. Basicaly, where/how does wine determine your bit depth? Isn't 24 actually 3 significacant bytes + a worthless one in X? XRGB. I didn't see any code determining the bit depth trying to follow what happens when you CreateCompatibleDC(0). Anyone have any ideas? This could be potential for a nice speedup. Thanks. -Dylan

1 0

is WIDL a sutable replacement for microsoft MIDL?
by Jonathan Wilson Dec. 24, 2004

Dec. 24, 2004

Could WIDL be used alongside MingW to generate IDL files on windows? What changes, if any, would be needed to WIDL to get it working on win32 and compiling IDL files in a way that MingW can use? Does MingW have enough of the OLE header files for WIDL to work? Having an IDL compiler for MingW would be a very usefull thing for those doing COM development IMO.

2 1

Wine Bug Busters @ 7pm GMT
by Brian Vincent Dec. 24, 2004

Dec. 24, 2004

The first ever Wine Bug Busters hacking session is coming up in an hour - 7pm GMT or 2pm EST for you North American folks. A few people are already sitting in irc. If you want to join, fire up your favorite IRC and log into irc.freenode.net, channel #winehackers. -Brian

5 5

Re: [QUARTZ] Some fixes
by Robert Shearman Dec. 24, 2004

Dec. 24, 2004

Christian Costa wrote: > Hi, > > With this patch, the indeo codec feels a little better. > > Changelog: > Initialize the COM libraries for the newly created worker thread in > the AVI splitter. > Fixed some returned error codes. > Show refcount in the AddRef/Release traces in filter. > Added 24 bits source in the video renderer. > > Christian Costa titan.costa(a)wanadoo.fr > >------------------------------------------------------------------------ > >Index: avidec.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/avidec.c,v >retrieving revision 1.11 >diff -u -r1.11 avidec.c >--- avidec.c 20 Dec 2004 17:07:17 -0000 1.11 >+++ avidec.c 24 Dec 2004 13:31:39 -0000 > > Why make things difficult for Alexandre? It is Christmas after all. Provide a diff relative to the root of the wine tree. ... >Index: pin.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/pin.c,v >retrieving revision 1.9 >diff -u -r1.9 pin.c >--- pin.c 16 Dec 2004 14:25:15 -0000 1.9 >+++ pin.c 24 Dec 2004 13:31:52 -0000 >@@ -1134,6 +1134,8 @@ > REFERENCE_TIME rtCurrent; > ALLOCATOR_PROPERTIES allocProps; > >+ CoInitialize(NULL); >+ > SetEvent(This->hEventStateChanged); > > hr = IMemAllocator_GetProperties(This->pAlloc, &allocProps); > > Good catch, but it would probably be better to use CoInitializeEx(NULL, COINIT_MULTITHREADED). This seems to be what Microsoft uses for the pull thread. Rob

3 5

Re: [MSVCRT] Fix get/set pos (fixes Supreme Snowboarding demo).
by Dmitry Timoshkov Dec. 24, 2004

Dec. 24, 2004

"Lionel Ulmer" <lionel.ulmer(a)free.fr> wrote: > Basically, there was two issues: the first is that the 'fpos_t' is 64 bits > in Windows (Mike M. checked on VC++ and I checked on MinGW and both > confirmed this). The situation with fpos_t is even worse. Both VC++ (Win32) and Platform SDK (Win64 part) define it as follows (stdio.h): #ifndef _FPOS_T_DEFINED #undef _FPOSOFF #if defined (_POSIX_) typedef long fpos_t; #define _FPOSOFF(fp) ((long)(fp)) #else /* _POSIX_ */ #if !__STDC__ && _INTEGRAL_MAX_BITS >= 64 typedef __int64 fpos_t; #define _FPOSOFF(fp) ((long)(fp)) #else typedef struct fpos_t { unsigned int lopart; int hipart; } fpos_t; #define _FPOSOFF(fp) ((long)(fp).lopart) #endif #endif /* _POSIX_ */ #define _FPOS_T_DEFINED #endif -- Dmitry.

2 1

Re: [MSVCRT] Fix get/set pos (fixes Supreme Snowboarding demo).
by Mike Hearn Dec. 24, 2004

Dec. 24, 2004

On Fri, 24 Dec 2004 15:42:30 +0100, Lionel Ulmer wrote: > With the help of Mike (M.) on IRC to point me to the right direction, I > finally managed to nail down the problem that was plaguing TD's snowboarding > game demo (oh well, it's better doing it in real life but well, if you are > blocked in England it's better than nothing :-) ). YAY! Great work guys, wonderful Christmas present :) Now I suppose I should fix the launcher creation problem. Then the only one left is the black sky bug but like you said, it's likely to be a driver issue. thanks -mike

1 0

Re: wine/dlls shell32/shlfileop.c shell32/shlexec. ...
by Christian Costa Dec. 24, 2004

Dec. 24, 2004

Hi Michael, This is typically the kind of patches that breaks everything. The code you find useless, is often use in lazy allocation or error handling. I doubt the current wine code is so bad designed even if there is some cases where the test is useless. For example in memallocator.c, this is wrong because you can release the allocator even before allocating the memory with the SetProperties method. Looking at your other patches, there is some changes that seems suspect to me (in winmm and directx). I think, this kind of cleanup should be done very carefully by understanding what the code really does. Morever, sending large patches that involves several dll makes it appears as obvious cleanups which they are not. Bye, Christian PS: Alexandre, please, could you remove all theses patches ? Alexandre Julliard wrote: >ChangeSet ID: 15010 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2004/12/23 11:12:07 > >Modified files: > dlls/shell32 : shlfileop.c shlexec.c shelllink.c > shell32_main.c pidl.c brsfolder.c > autocomplete.c > dlls/setupapi : setupx_main.c parser.c > dlls/serialui : confdlg.c > dlls/rsaenh : rsaenh.c handle.c > dlls/rpcrt4 : rpc_server.c rpc_message.c rpc_binding.c > dlls/richedit : reader.c > dlls/quartz : memallocator.c > >Log message: > Michael Stefaniuc <mstefani(a)redhat.de> > Do not check for non NULL pointer before HeapFree'ing it. It's > redundant. > >Patch: http://cvs.winehq.org/patch.py?id=15010 > >Old revision New revision Changes Path > 1.49 1.50 +1 -2 wine/dlls/shell32/shlfileop.c > 1.58 1.59 +1 -1 wine/dlls/shell32/shlexec.c > 1.79 1.80 +17 -40 wine/dlls/shell32/shelllink.c > 1.141 1.142 +2 -2 wine/dlls/shell32/shell32_main.c > 1.123 1.124 +1 -1 wine/dlls/shell32/pidl.c > 1.53 1.54 +1 -4 wine/dlls/shell32/brsfolder.c > 1.11 1.12 +2 -4 wine/dlls/shell32/autocomplete.c > 1.29 1.30 +3 -3 wine/dlls/setupapi/setupx_main.c > 1.14 1.15 +1 -2 wine/dlls/setupapi/parser.c > 1.19 1.20 +1 -2 wine/dlls/serialui/confdlg.c > 1.7 1.8 +4 -4 wine/dlls/rsaenh/rsaenh.c > 1.2 1.3 +1 -2 wine/dlls/rsaenh/handle.c > 1.33 1.34 +1 -1 wine/dlls/rpcrt4/rpc_server.c > 1.11 1.12 +2 -5 wine/dlls/rpcrt4/rpc_message.c > 1.29 1.30 +1 -1 wine/dlls/rpcrt4/rpc_binding.c > 1.18 1.19 +1 -2 wine/dlls/richedit/reader.c > 1.5 1.6 +1 -2 wine/dlls/quartz/memallocator.c > > > > > >

2 2

gmail invitation
by Ivan Leo Puoti Dec. 24, 2004

Dec. 24, 2004

I have 6 gmail invitations, I'm giving them out to Wine developers only. If you want one drop me a line, first come first served. Ivan.

4 3

Re: Systray patch but explorified
by Mike Hearn Dec. 24, 2004

Dec. 24, 2004

On Mon, 13 Dec 2004 21:58:07 +0000, Mike Hearn wrote: > - Use freedesktop.org system tray protocol, remove legacy KDE support > - Introduce new Explorer process > - Rewrite system tray handling to be out of process Hi Alexandre, What needs doing next for this patch? thanks -mike

2 5

Interface for working directories/launchers
by Mike Hearn Dec. 24, 2004

Dec. 24, 2004

Hi, Wine currently creates launchers (.desktop files) with an Exec line like this: Exec=wine 'c:\games\supreme\supreme.exe' But, some games expects to be run from its working directory. As working directory typically doesn't matter to UNIX apps, some desktop environments like GNOME don't let you set it. Really, this is a Wine specific issue. So I'm wondering how we should fix this. The most obvious is a way to tell Wine to change the working directory to the path of the EXE file before running it, but we can't introduce command line switches any more and an environment variable for this doesn't make much sense. My proposal is to have a new winelib app "winemenulauncher" which simply takes the working directory, program and arguments, and runs the program but switching current directory first, ie the menu entry would look like: Exec=wine winemenulauncher c:\games\supreme supreme.exe Hopefully this should let us fix the case of games like Dungeon Keeper which actually crash when run from their install directory. Does this sound sensible? thanks -mike

3 3

Re: [AppDB] CODING_STANDARD
by Paul van Schayck Dec. 24, 2004

Dec. 24, 2004

Jonathan, On Fri, 24 Dec 2004 10:43:45 +0100, Jonathan Ernst <Jonathan(a)ernstfamily.ch> wrote: > This patch sets variable naming convention that should be used in the > appDB code. Why would we change it. I think it just clutters up the source without adding value. PHP is a variable-type decleration less language. We often just change string in booleans without thinking about it. And I think I'm just lazy. I don't like typing more characters. What are your argument for it? Paul

2 1

AppDB Templates
by Stefan Pflüger Dec. 24, 2004

Dec. 24, 2004

Hello, I attached my really simple template class that mainly replaces special tags in template files by some reasonable text. The file should go to appdb/include/template.php. I already rewrote most of index.php to use the template class, I'll submit a seperate patch for that when finished. The same then needs to be done for every PHP file in appdb/ and appdb/admin as well as some files in include/, for example include/menu.php. In the end, the whole design will be changeable by editing some HTML-like template files in appdb/template/. Stefan

1 0

Re: tests: add more listbox tests
by Mike Hearn Dec. 24, 2004

Dec. 24, 2004

On Thu, 23 Dec 2004 17:01:09 +0200, Lauri Tulmin wrote: > Add tests for LBS_EXTENDEDSE and LBS_EXTENDEDSEL | LBS_MULTIPLESEL > listboxes. Some of these test don't pass on wine. Thanks for the tests! If they don't pass in Wine though you need to surround them in todo_wine {} blocks, or ideally fix them. thanks -mike

2 1

Patch to README
by Stefan Pflüger Dec. 23, 2004

Dec. 23, 2004

This patch adds the default admin account data (user: admin, password: testing) to the README file. The account data was mentioned nowhere before, only in tables/user_list.sql Stefan Pflüger Index: README =================================================================== RCS file: /home/wine/appdb/README,v retrieving revision 1.4 diff -u -r1.4 README --- README 13 Dec 2004 03:50:11 -0000 1.4 +++ README 23 Dec 2004 20:23:33 -0000 @@ -32,6 +32,12 @@ 'magic_quotes_gpc = Off' (you would end up with \ everywhere) 'session.bug_compat_42' = On' (Problem with auto-globals and session variables) +# An AppDB admin user has been automatically created while running + the create_tables script + username: admin + password: testing + You should change the password as soon as possible! + #------------------------------------------------------------------------# You can create ether set up a real bugzilla database or a fake one

1 0

Re: Correct use of the ok function in user/tests and kernel/tests
by Jakob Eriksson Dec. 23, 2004

Dec. 23, 2004

Aren't arguments always evaluated left to right? Rein Klazes wrote: >Hi, > >82 cases, most a variation of: > >ok( !Foo(), "Foo failed, error %ld\n", GetLastError()); > >Changelog: > dlls/kernel/tests : change.c, file.c, process.c, > thread.c, time.c > dlls/user/tests : clipboard.c, msg.c, text.c win.c > > Correct cases where arguments of ok() calls depend on the order > in which they are evaluated. > > >

3 2

Re: Implemented CreateUrlCacheEntryW and DeleteUrlCacheEntryW
by Robert Shearman Dec. 23, 2004

Dec. 23, 2004

Jacek Caban wrote: > Changelog: > Implemented CreateUrlCacheEntryW and DeleteUrlCacheEntryW > >------------------------------------------------------------------------ > >Index: dlls/wininet/urlcache.c >=================================================================== >RCS file: /home/wine/wine/dlls/wininet/urlcache.c,v >retrieving revision 1.22 >diff -u -p -r1.22 urlcache.c >--- dlls/wininet/urlcache.c 3 Sep 2004 18:30:28 -0000 1.22 >+++ dlls/wininet/urlcache.c 23 Dec 2004 11:08:39 -0000 >@@ -616,14 +616,14 @@ static BOOL URLCache_DeleteEntry(CACHEFI > static BOOL URLCache_LocalFileNameToPathW( > const URLCACHECONTAINER * pContainer, > LPCURLCACHE_HEADER pHeader, >- LPCSTR szLocalFileName, >+ LPCWSTR szLocalFileName, > BYTE Directory, > LPWSTR wszPath, > LPLONG lpBufferSize) > { > LONG nRequired; > int path_len = strlenW(pContainer->path); >- int file_name_len = MultiByteToWideChar(CP_ACP, 0, szLocalFileName, -1, NULL, 0); >+ int file_name_len = lstrlenW(szLocalFileName); > > MultiByteWideChar returns the number of characters, including the NULL terminator. lstrlenW does not. Also, since the local file name can only ever be stored in ANSI, there is very little benefit in converting that function to Unicode. In fact, there is very little benefit in making the ANSI API functions convert everything to Unicode strings, only for them to be immediately converted back to ANSI for storage on disk. > if (Directory >= pHeader->DirectoryCount) > { > *lpBufferSize = 0; >@@ -638,7 +638,7 @@ static BOOL URLCache_LocalFileNameToPath > memcpy(wszPath, pContainer->path, path_len * sizeof(WCHAR)); > dir_len = MultiByteToWideChar(CP_ACP, 0, pHeader->directory_data[Directory].filename, DIR_LENGTH, wszPath + path_len, DIR_LENGTH); > wszPath[dir_len + path_len] = '\\'; >- MultiByteToWideChar(CP_ACP, 0, szLocalFileName, -1, wszPath + dir_len + path_len + 1, file_name_len); >+ memcpy(wszPath + dir_len + path_len + 1, szLocalFileName, file_name_len*sizeof(WCHAR)); > *lpBufferSize = nRequired; > return TRUE; > } >@@ -762,9 +762,18 @@ static BOOL URLCache_CopyEntry( > LPSTR lpszLocalFileName; > lpszLocalFileName = (LPSTR)lpCacheEntryInfo + dwRequiredSize; > nLocalFilePathSize = *lpdwBufferSize - dwRequiredSize; >- if ((bUnicode && URLCache_LocalFileNameToPathW(pContainer, pHeader, (LPCSTR)pUrlEntry + pUrlEntry->dwOffsetLocalName, pUrlEntry->CacheDir, (LPWSTR)lpszLocalFileName, &nLocalFilePathSize)) || >- URLCache_LocalFileNameToPathA(pContainer, pHeader, (LPCSTR)pUrlEntry + pUrlEntry->dwOffsetLocalName, pUrlEntry->CacheDir, lpszLocalFileName, &nLocalFilePathSize)) >- { >+ if (bUnicode) { >+ LPWSTR tmpstrw; >+ int len = MultiByteToWideChar(CP_ACP, 0, (LPCSTR)pUrlEntry + pUrlEntry->dwOffsetLocalName, -1, NULL, 0); >+ tmpstrw = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); >+ MultiByteToWideChar(CP_ACP, 0, (LPCSTR)pUrlEntry + pUrlEntry->dwOffsetLocalName, -1, tmpstrw, len); >+ if(URLCache_LocalFileNameToPathW(pContainer, pHeader, tmpstrw, pUrlEntry->CacheDir, >+ (LPWSTR)lpszLocalFileName, &nLocalFilePathSize)) { >+ lpCacheEntryInfo->lpszLocalFileName = lpszLocalFileName; >+ } >+ HeapFree(GetProcessHeap(), 0, tmpstrw); >+ }else if(URLCache_LocalFileNameToPathA(pContainer, pHeader, (LPCSTR)pUrlEntry + pUrlEntry->dwOffsetLocalName, >+ pUrlEntry->CacheDir, lpszLocalFileName, &nLocalFilePathSize)) { > lpCacheEntryInfo->lpszLocalFileName = lpszLocalFileName; > } > dwRequiredSize += nLocalFilePathSize; >@@ -1550,36 +1559,38 @@ BOOL WINAPI UnlockUrlCacheEntryFileA( > } > > /*********************************************************************** >- * CreateUrlCacheEntryA (WININET.@) >+ * CreateUrlCacheEntryW (WININET.@) > * > */ >-BOOL WINAPI CreateUrlCacheEntryA( >- IN LPCSTR lpszUrlName, >+BOOL WINAPI CreateUrlCacheEntryW( >+ IN LPCWSTR lpszUrlName, > IN DWORD dwExpectedFileSize, >- IN LPCSTR lpszFileExtension, >- OUT LPSTR lpszFileName, >+ IN LPCWSTR lpszFileExtension, >+ OUT LPWSTR lpszFileName, > IN DWORD dwReserved > ) > { > URLCACHECONTAINER * pContainer; > LPURLCACHE_HEADER pHeader; >- CHAR szFile[MAX_PATH]; >- CHAR szExtension[MAX_PATH]; >- LPCSTR lpszUrlPart; >- LPCSTR lpszUrlEnd; >- LPCSTR lpszFileNameExtension; >- LPSTR lpszFileNameNoPath; >+ WCHAR szFile[MAX_PATH]; >+ WCHAR szExtension[MAX_PATH]; >+ LPCWSTR lpszUrlPart; >+ LPCWSTR lpszUrlEnd; >+ LPCWSTR lpszFileNameExtension; >+ LPWSTR lpszFileNameNoPath; > int i; > int countnoextension; > BYTE CacheDir; > LONG lBufferSize; > BOOL bFound = FALSE; > int count; >+ static const WCHAR strWWW[] = {'w','w','w',0}; >+ static const WCHAR strFormat[] = {'[','%','u',']','%','s',0}; > > No need to pollute an already congested function header with something that can be put into the appropriate block below. Also, "wsz" is the prefix usually used for Wide Character string constants. > > TRACE("(%s, 0x%08lx, %s, %p, 0x%08lx)\n", >- debugstr_a(lpszUrlName), >+ debugstr_w(lpszUrlName), > dwExpectedFileSize, >- debugstr_a(lpszFileExtension), >+ debugstr_w(lpszFileExtension), > lpszFileName, > dwReserved); > >@@ -1607,16 +1618,14 @@ BOOL WINAPI CreateUrlCacheEntryA( > break; > } > } >- if (!strcmp(lpszUrlPart, "www")) >- { >- lpszUrlPart += strlen("www"); >- } >+ if (!lstrcmpW(lpszUrlPart, strWWW)) >+ lpszUrlPart += sizeof(strWWW)/sizeof(WCHAR) -1; > > count = lpszUrlEnd - lpszUrlPart; > > if (bFound && (count < MAX_PATH)) > { >- memcpy(szFile, lpszUrlPart, count * sizeof(CHAR)); >+ memcpy(szFile, lpszUrlPart, count * sizeof(WCHAR)); > szFile[count] = '\0'; > /* FIXME: get rid of illegal characters like \, / and : */ > } >@@ -1625,9 +1634,9 @@ BOOL WINAPI CreateUrlCacheEntryA( > FIXME("need to generate a random filename\n"); > } > >- TRACE("File name: %s\n", szFile); >+ TRACE("File name: %s\n", debugstr_w(szFile)); > >- if (!URLCacheContainers_FindContainerA(lpszUrlName, &pContainer)) >+ if (!URLCacheContainers_FindContainerW(lpszUrlName, &pContainer)) > return FALSE; > > if (!URLCacheContainer_OpenIndex(pContainer)) >@@ -1638,32 +1647,33 @@ BOOL WINAPI CreateUrlCacheEntryA( > > CacheDir = (BYTE)(rand() % pHeader->DirectoryCount); > >- lBufferSize = MAX_PATH * sizeof(CHAR); >- URLCache_LocalFileNameToPathA(pContainer, pHeader, szFile, CacheDir, lpszFileName, &lBufferSize); >+ lBufferSize = MAX_PATH * sizeof(WCHAR); >+ URLCache_LocalFileNameToPathW(pContainer, pHeader, szFile, CacheDir, lpszFileName, &lBufferSize); > > URLCacheContainer_UnlockIndex(pContainer, pHeader); > >- lpszFileNameNoPath = lpszFileName + lBufferSize / sizeof(CHAR) + DIR_LENGTH + 1; >+ lpszFileNameNoPath = lpszFileName + lBufferSize / sizeof(WCHAR) + DIR_LENGTH + 1; > >- countnoextension = strlen(lpszFileNameNoPath); >- lpszFileNameExtension = PathFindExtensionA(lpszFileNameNoPath); >+ countnoextension = lstrlenW(lpszFileNameNoPath); >+ lpszFileNameExtension = PathFindExtensionW(lpszFileNameNoPath); > if (lpszFileNameExtension) >- countnoextension -= strlen(lpszFileNameExtension); >+ countnoextension -= lstrlenW(lpszFileNameExtension); > *szExtension = '\0'; > > if (lpszFileExtension) > { > szExtension[0] = '.'; >- strcpy(szExtension+1, lpszFileExtension); >+ lstrcpyW(szExtension+1, lpszFileExtension); > } > > for (i = 0; i < 255; i++) > { > HANDLE hFile; >- strncpy(lpszFileNameNoPath, szFile, countnoextension); >- sprintf(lpszFileNameNoPath + countnoextension, "[%u]%s", i, szExtension); >- TRACE("Trying: %s\n", lpszFileName); >- hFile = CreateFileA(lpszFileName, GENERIC_READ, 0, NULL, CREATE_NEW, 0, NULL); >+ int len = lstrlenW(szFile)+1; >+ memcpy(lpszFileNameNoPath, szFile, (len<countnoextension ? len : countnoextension)*sizeof(WCHAR)); > > The strncpyW function exists for a reason. Also, it is better to use strlenW than lstrlenW. >+ wsprintfW(lpszFileNameNoPath + countnoextension, strFormat, i, szExtension); >+ TRACE("Trying: %s\n", debugstr_w(lpszFileName)); >+ hFile = CreateFileW(lpszFileName, GENERIC_READ, 0, NULL, CREATE_NEW, 0, NULL); > if (hFile != INVALID_HANDLE_VALUE) > { > CloseHandle(hFile); >@@ -1674,6 +1684,45 @@ BOOL WINAPI CreateUrlCacheEntryA( > return FALSE; > } > >+ >+/*********************************************************************** >+ * CreateUrlCacheEntryA (WININET.@) >+ * >+ */ >+BOOL WINAPI CreateUrlCacheEntryA( >+ IN LPCSTR lpszUrlName, >+ IN DWORD dwExpectedFileSize, >+ IN LPCSTR lpszFileExtension, >+ OUT LPSTR lpszFileName, >+ IN DWORD dwReserved >+) >+{ >+ int len; >+ BOOL ret; >+ LPWSTR lpszUrlNamew = NULL; >+ LPWSTR lpszFileExtensionw = NULL; >+ WCHAR lpszFileNamew[MAX_PATH+1]; >+ >+ if(lpszUrlName) { >+ len = MultiByteToWideChar(CP_ACP, 0, lpszUrlName, -1, NULL, 0); >+ lpszUrlNamew = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); >+ MultiByteToWideChar(CP_ACP, 0, lpszUrlName, -1, lpszUrlNamew, len); >+ } >+ >+ if(lpszFileExtension) { >+ len = MultiByteToWideChar(CP_ACP, 0, lpszFileExtension, -1, NULL, 0); >+ lpszFileExtensionw = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); >+ MultiByteToWideChar(CP_ACP, 0, lpszFileExtension, -1, lpszFileExtensionw, len); >+ } >+ >+ ret = CreateUrlCacheEntryW(lpszUrlNamew, dwExpectedFileSize, lpszFileExtensionw, lpszFileNamew, 0); >+ >+ WideCharToMultiByte(CP_ACP, 0, lpszFileNamew, -1, lpszFileName, -1, 0, 0); >+ HeapFree(GetProcessHeap(), 0, lpszUrlNamew); >+ HeapFree(GetProcessHeap(), 0, lpszFileExtensionw); >+ return ret; >+} >+ > /*********************************************************************** > * CommitUrlCacheEntryA (WININET.@) > * >@@ -1999,12 +2048,11 @@ BOOL WINAPI UnlockUrlCacheEntryStream( > return TRUE; > } > >- > /*********************************************************************** >- * DeleteUrlCacheEntryA (WININET.@) >+ * DeleteUrlCacheEntryAW (internal) > > Bad name for the function. This convention is used in shell32 to indicate a function that is implemented as ANSI only on Win9x and Unicode on WinNT. > * > */ >-BOOL WINAPI DeleteUrlCacheEntryA(LPCSTR lpszUrlName) >+BOOL WINAPI DeleteUrlCacheEntryAW(LPCWSTR lpszUrlName, BOOL bUnicode) > { > URLCACHECONTAINER * pContainer; > LPURLCACHE_HEADER pHeader; >@@ -2012,11 +2060,15 @@ BOOL WINAPI DeleteUrlCacheEntryA(LPCSTR > DWORD dwStartBlock; > DWORD dwBlock; > BYTE * AllocationTable; >+ LPSTR lpszUrlNamea = NULL; > >- TRACE("(%s)\n", debugstr_a(lpszUrlName)); >- >- if (!URLCacheContainers_FindContainerA(lpszUrlName, &pContainer)) >- return FALSE; >+ if(bUnicode) { >+ if (!URLCacheContainers_FindContainerW(lpszUrlName, &pContainer)) >+ return FALSE; >+ } else { >+ if (!URLCacheContainers_FindContainerA((LPSTR)lpszUrlName, &pContainer)) >+ return FALSE; >+ } > > if (!URLCacheContainer_OpenIndex(pContainer)) > return FALSE; >@@ -2024,11 +2076,20 @@ BOOL WINAPI DeleteUrlCacheEntryA(LPCSTR > if (!(pHeader = URLCacheContainer_LockIndex(pContainer))) > return FALSE; > >- if (!URLCache_FindEntryInHash(pHeader, lpszUrlName, &pEntry)) >+ if(bUnicode) { >+ lpszUrlNamea = (LPSTR)lpszUrlName; >+ } else { >+ int len = WideCharToMultiByte(CP_ACP, 0, lpszUrlName, -1, NULL, -1, 0, 0); >+ WideCharToMultiByte(CP_ACP, 0, lpszUrlName, -1, lpszUrlNamea, len, 0, 0); >+ } >+ >+ if (!URLCache_FindEntryInHash(pHeader, lpszUrlNamea, &pEntry)) > { > URLCacheContainer_UnlockIndex(pContainer, pHeader); >- TRACE("entry %s not found!\n", lpszUrlName); >+ TRACE("entry not found!\n"); > SetLastError(ERROR_FILE_NOT_FOUND); >+ if(bUnicode) >+ HeapFree(GetProcessHeap(), 0, lpszUrlNamea); > return FALSE; > } > >@@ -2041,11 +2102,34 @@ BOOL WINAPI DeleteUrlCacheEntryA(LPCSTR > > URLCache_DeleteEntry(pEntry); > >- URLCache_DeleteEntryFromHash(pHeader, lpszUrlName); >+ URLCache_DeleteEntryFromHash(pHeader, lpszUrlNamea); > > URLCacheContainer_UnlockIndex(pContainer, pHeader); > >+ if(bUnicode) >+ HeapFree(GetProcessHeap(), 0, lpszUrlNamea); >+ > return TRUE; >+} >+ >+/*********************************************************************** >+ * DeleteUrlCacheEntryA (WININET.@) >+ * >+ */ >+BOOL WINAPI DeleteUrlCacheEntryA(LPCSTR lpszUrlName) >+{ >+ TRACE("(%s)\n", debugstr_a(lpszUrlName)); >+ return DeleteUrlCacheEntryAW((LPCWSTR)lpszUrlName, FALSE); >+} >+ >+/*********************************************************************** >+ * DeleteUrlCacheEntryW (WININET.@) >+ * >+ */ >+BOOL WINAPI DeleteUrlCacheEntryW(LPCWSTR lpszUrlName) >+{ >+ TRACE("(%s)\n", debugstr_w(lpszUrlName)); >+ return DeleteUrlCacheEntryAW(lpszUrlName, TRUE); > } > > /*********************************************************************** > > Rob

2 1

Re: Moved some strings to resources
by Juan Lang Dec. 23, 2004

Dec. 23, 2004

Hi Jacek, small suggestion: > @@ -1391,8 +1393,11 @@ static LRESULT FILEDLG95_InitControls(HW > /* change Open to Save FIXME: use resources */ > if (fodInfos->DlgInfos.dwDlgProp & FODPROP_SAVEDLG) > { The comment is out of date, you did use resources. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250

1 0

winetest failing on Windows 2000, VIA AC 97 audio
by Jakob Eriksson Dec. 23, 2004

Dec. 23, 2004

http://test.winehq.org/data/200412231000/2000_MarcelHekman/winmm:wave.txt Can we blacklist this driver somehow? AFAIK I submitted a black list patch before for this driver but it was silently dropped. regards, Jakob

1 0

MSVCRT, OpenGL bugs to look at (and a WM rewrite regression?)
by Mike Hearn Dec. 23, 2004

Dec. 23, 2004

Hi ho, Every so often I try out my favourite game to see how well it runs in Wine. This time, I found the demo (I have the full game but the demo is easier to debug) was working well! The following snowboarding game: http://www.housemarque.com/games/supremesb/ssb_demo.exe is not only a lot of fun but also Very Nearly There in Wine. There are only two problems preventing it from running perfectly: 1) There seems to be a bug in our msvcrt file reading APIs. I've chased this one before and got nowhere, but maybe somebody more familiar with the code can find it. We seem to pass back corrupt data: with builtin msvcrt the demo complains with a nicely detailed assertion that it can't find a file marker it's looking for. Native MSVCRT from WinXP makes it work (once you set winver=winxp) 2) When racing, the sky is black. An OpenGL bug perhaps? Weirdly when it's showing the pre-recorded demos the sky is just fine. The rest of the graphics are perfect. Finally if you put it in desktop mode, an X protocol error occurs initialising OpenGL. The XGetWindowAttributes call complains of a bad window. I debugged this for a bit and got nowhere, it wasn't as straightforward as it looked. Suffice to say that at the point it died opengl32.dll had been initialised several times already with the same value for root_window, and it worked each time previously (yes sync was enabled). I think this definitely used to work, so it feels like some WM rewrite regression to me. I could well be wrong though. This seems to affect all OpenGL+desktop mode apps. To make the game let you choose OpenGL in the setup program it has to be run in win2k/winxp mode. I do not know why. If you get it going, see if you can beat my best time (when playing on Linux) of 2:02. Have fun! :) thanks -mike

3 5

MSVCRT, OpenGL bugs to look at (and a WM rewrite regression?)
by Jesse Allen Dec. 23, 2004

Dec. 23, 2004

On Thu, 23 Dec 2004 00:43:20 +0000, Mike Hearn <mh(a)codeweavers.com> wrote: > > 2) When racing, the sky is black. An OpenGL bug perhaps? Weirdly when it's > showing the pre-recorded demos the sky is just fine. The rest of the > graphics are perfect. What graphics card and driver do you use? This is important. I use a Radeon 9200 and DRI. In Warcraft III+opengl under wine, things would "disappear", but then re-appear under different conditions. I have screen shots I can upload that shows this in action. I used to use an nvidia card with the official driver. Comparatively, the nvidia graphics setup rendered everything perfectly. > > Finally if you put it in desktop mode, an X protocol error occurs > initialising OpenGL. The XGetWindowAttributes call complains of a bad > window. I debugged this for a bit and got nowhere, it wasn't as > straightforward as it looked. Suffice to say that at the point it died > opengl32.dll had been initialised several times already with the same > value for root_window, and it worked each time previously (yes sync was > enabled). > > I think this definitely used to work, so it feels like some WM rewrite > regression to me. I could well be wrong though. > > This seems to affect all OpenGL+desktop mode apps. You are correct, it used to work. I just tried it yesterday and it didn't work for me either. > > To make the game let you choose OpenGL in the setup program it has to be > run in win2k/winxp mode. I do not know why. > > If you get it going, see if you can beat my best time (when playing on > Linux) of 2:02. Have fun! :) > > thanks -mike > > Unfortunately I can't try your game at the moment cause it will take me too long to download -- 2 KB/s down only =( Jesse

2 1

Re: MSI: First go at thread safety for MSI records
by Alexandre Julliard Dec. 23, 2004

Dec. 23, 2004

Mike McCormack <mike(a)codeweavers.com> writes: > Index: dlls/msi/msipriv.h > =================================================================== > RCS file: /home/wine/wine/dlls/msi/msipriv.h,v > retrieving revision 1.32 > diff -u -r1.32 msipriv.h > --- dlls/msi/msipriv.h 22 Dec 2004 15:05:07 -0000 1.32 > +++ dlls/msi/msipriv.h 23 Dec 2004 01:43:40 -0000 > @@ -54,6 +54,7 @@ > UINT magic; > UINT type; > UINT refcount; > + CRITICAL_SECTION cs; > msihandledestructor destructor; Do you really need a separate critical section for every single MSI object? That seems a bit overkill to me. -- Alexandre Julliard julliard(a)winehq.org

4 3

Going forward with fixing up tests failing because not run on visible desktop.
by Jakob Eriksson Dec. 23, 2004

Dec. 23, 2004

Followup on tests failing because they are run as an invisible service on Windows: ---------------------------------------------------------------------------------- Now that we have bRunningOnVisibleDesktop=0 in the report, how do we make use of it? Do we mark on the server side which tests fail because of it, or should we add a flag to the ok() macro? I would like to have the information stored in the test code somehow. It would document implicitly which functions only work in visible mode. If we had a global variable named "running_on_visible_desktop", we would have code like this in the tests: if (running_on_visible_desktop) { ok(EnumEnhMetaFile(hdcDisplay, hMetafile, emf_enum_proc, dx, &rc), "EnumEnhMetaFile error %ld\n", GetLastError()); } Or we could mark them like this: expect_to_fail_if_running_on_visible_desktop { ok(EnumEnhMetaFile(hdcDisplay, hMetafile, emf_enum_proc, dx, &rc), "EnumEnhMetaFile error %ld\n", GetLastError()); } Where expect_to_fail_if.... should do some magic... regards, Jakob

1 0

Re: [OLE #10] Make out of process COM work with OXID based marshal ids
by Robert Shearman Dec. 23, 2004

Dec. 23, 2004

Mike Hearn wrote: >This patch makes InstallShield work again, and should let you get >further Bill. > >- Ensure all intermediate threads join the original apartment >- Make the listener thread fully apartment scoped (one per apt not per > process) >- Improve "already have mid" error message >- Rename _StubReaderThread to stub_dispatch_thread >- Improve tracing > > Can you submit this patch again, but without the local server changes? You have persuaded me that this is the only way to keep things working for the moment. I'll submit a seperate patch for the local server problem, if that's ok with you. Rob

1 0

Looking for a Wine consultant
by Raetus Egli Dec. 23, 2004

Dec. 23, 2004

I am sending this message for a friend of mine. I am the head of a company that is trying to migrate a VB6 system on WinNT to Linux. We would like to use this application under Debian Sarge using Wine. If you have experience in porting VB6 applications using Wine and have some free time to consult with an in-house developer it would be greatly appreciated. We would like to get the project up and running as soon as possible. If you are interested please get back to me at pyadegar(a)honeymae.com as soon as possible. Thanks.

1 0

Re: Add ntoskrnl.exe.so
by Mike Hearn Dec. 23, 2004

Dec. 23, 2004

On Wed, 22 Dec 2004 13:29:35 -0800, Steven Edwards wrote: > kernel32 can't be a dependancy on ntoskrnl. We are going to need to redesign Wine if we are going > to have a ntoskrnl implementation. Why not? This isn't ReactOS, ntoskrnl is just another DLL from the SafeDisc perspective. Its implementation details shouldn't matter.

3 5

Re: AppDB TODO update: Templates
by Stefan Pflüger Dec. 23, 2004

Dec. 23, 2004

> Search engines don't like dynamic pages. So using the lostwages way > would really be preferred. > And we're trying to get rid of the tables and use CSS positioning. So > don't count on those. Al tough it won't change the main idea I think. > > Paul > > Well one could easily ship around the search engine problem by a) Using mod_rewrite or b) Setting a var and including index.php from those files I'd prefer getting any HTML code out of appdb into the templates to make it easy to fully change the design without touching any line of PHP code. Changes in the design won't change anything in the concept. Stefan

1 0

Looking for a Wine consultant.
by Pouya Yadegar Dec. 22, 2004

Dec. 22, 2004

I am the head of a company that is trying to migrate a VB6 system on WinNT and would like to use that application under Debian Sarge using Wine. If you have experience in porting VB6 applications using Wine and have some free time to consult an in house developer it would be appreciated. We would like to get the project up and running as soon as possible. If your interested please get back to me at pyadegar(a)honeymae.com as soon as possible. Thanks.

1 0

Re: My "Helping Applications Work" Guide
by Dan Kegel Dec. 22, 2004

Dec. 22, 2004

Mike Hearn wrote: > This quote: "An alternative option, perhaps more effective and expensive, is to pay wine > developers for their work on your application, either directly through a > negotiated contract or indirectly by posting a bounty" ... could it have a > link to CodeWeavers please? I think it's fair to say that we're the number > one provider of these sorts of services by a long way, but currently we're > still quite dependent on people being able to find us, so additional links > and publicity is needed. Yeah, a link to http://codeweavers.com would be appropriate. You might want to link to a list of vendors who are willing to help update Wine to work with particular apps and contribute the fixes back to the winehq tree per the LGPL, e.g. http://codeweavers.com http://www.macadamian.com http://www.itomig.de Itomig's a newcomer, but what the heck, they seem to be interested in helping the Wine community. (Also maybe Transgaming, but I don't know if they're willing to work on the winehq tree anyore). - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [OLE #10] Make out of process COM work with OXID based marshal ids
by Robert Shearman Dec. 22, 2004

Dec. 22, 2004

Mike Hearn wrote: >This patch makes InstallShield work again, and should let you get >further Bill. > >- Ensure all intermediate threads join the original apartment >- Make the listener thread fully apartment scoped (one per apt not per > process) >- Improve "already have mid" error message >- Rename _StubReaderThread to stub_dispatch_thread >- Improve tracing > > Sorry Mike, but we want to *remove* the current hacks for the RPC-runtime emulating named pipe code, not adding more. The correct approach for the crash in _LocalServerThread is to use table-strong marshaling once and then copy the contents of the stream to the pipe for each iteration in the loop, instead of marshaling each time. The correct approach for the crash in _StubReaderThread is to make it execute in the correct apartment - either by sending a window message to the STA window or by joining the MTA. I believe you had a patch for this in July or August when we last worked on this. Rob

4 12

Re: Add ntoskrnl.exe.so
by Steven Edwards Dec. 22, 2004

Dec. 22, 2004

Hi, --- Ivan Leo Puoti <ivanleo(a)gmail.com> wrote: > Add ntoskrnl, only a few stub functions for now, so we have something to > work on. > All the functions needed by safedisc are in the spec, we can't implement > them all > as stubs ATM because for two of them we need defines from the ddk, > I'll be sending a patch to add ntddk.h in the near future. Check the ReactOS or w32api DDK. Its public domain. > +MODULE = ntoskrnl.exe > +IMPORTS = kernel32 > +DLLMODE = native kernel32 can't be a dependancy on ntoskrnl. We are going to need to redesign Wine if we are going to have a ntoskrnl implementation. > +BOOLEAN WINAPI PsGetVersion(PULONG MajorVersion OPTIONAL, PULONG MinorVersion OPTIONAL, > + PULONG BuildNumber OPTIONAL, PUNICODE_STRING CSDVersion > + OSVERSIONINFOA version; > + version.dwOSVersionInfoSize=sizeof(OSVERSIONINFOA); > + GetVersionExA(&version); We need to either duplicate or move the version code in to ntoskrnl.exe. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

1 0

Re: Re: AppDB TODO update: Templates
by Chris Morgan Dec. 22, 2004

Dec. 22, 2004

I think you are covering the appropriate mailing lists. If you'd like to chat in real-time about hacking appdb, channel #winehackers on irc.freenode.net is a good place. Tony, Jon and myself are frequently there and chat at least every other day about appdb related things. About the templates, is this what Jeremy did in the lostwages archive(www.winehq.org/cvsweb/lostwages)? I wasn't too familiar with the changes he made and thought it would be good to discuss things prior to making such large changes to the appdb code. Anything that improves the design is more than welcome. Chris > > From: Stefan Pflüger <stefan(a)homepage4us.de> > Date: 2004/12/22 Wed PM 02:33:18 EST > To: wine-devel(a)winehq.org > CC: cmorgan(a)alum.WPI.EDU, appdb(a)winehq.org > Subject: Re: AppDB TODO update: Templates > > Basically, I'll implement a class that is able to read a template file > and that can assign content to special tags in there. > > The index.php would create an object of this class using a "main > template" that includes all parts of the page that are static (header, > footer, the main html tables). Depending on a GET variable, the > index.php calls a function whose returned data will be used as the main > content, it would be for example index.php?action=browseapps to get to > the "Browse Apps" page. > > The content of the sidebar, the banner ad etc. would also be created by > a function like it's already done (see banner_display() in > include/banner.php), but instead of just echo-ing this somewhere in the > right place, it would also be fed into the template engine that again > replaces the corresponding tags in the main template. Those functions > might also use the template class to implement their own sub-templates. > > In the end, the template class object in index.php should have the > complete output ready for sending it to the user. > > Hopefully, my short explanation was good enough to illustrate the concept. > > > Stefan > > PS.: What's the correct list/address to send mails concerning this > discussion to? I'm sending them to the wine-devel list atm, CCing to > Chris Morgan and appdb(a)winehq.org... > >

2 1

Re: AppDB TODO update: Templates
by Chris Morgan Dec. 22, 2004

Dec. 22, 2004

Cool, thanks for claiming this so we don't have people stepping on each others toes. Would you mind showing a little bit of what you planned on changing? It would be nice to have agreement that this was the direction we wanted to go before a big patch was submitted. Chris > > From: Stefan Pflüger <stefan(a)homepage4us.de> > Date: 2004/12/22 Wed PM 01:05:06 EST > To: wine-devel(a)winehq.org > CC: appdb(a)winehq.org > Subject: AppDB TODO update: Templates > > Hello, > > the last update added > > +# incorporate templates into appdb to simplify code, Jeremy says we can > +borrow from lostwages(winehq.org/cvsweb/lostwages) for this > > to the TODO file. > > At the moment, I'm trying to use AppDB for another project and I already > planned on implementing templates. > If nobody else wants to do the job, I'll go ahead and send you a patch > as soon as I'm finished. > > Stefan Pflüger > >

2 1

Writing an app. using existing dll
by Per Arnold Blåsmo Dec. 22, 2004

Dec. 22, 2004

Hi, I have a windows-dll and wants to make an app that runs on Linux under wine using this dll. I have the API description for this dll, but not the source code. I there any possibility for that using i.e. winelib and is there any howto to get me started. PerA.

2 1

AppDB TODO update: Templates
by Stefan Pflüger Dec. 22, 2004

Dec. 22, 2004

Hello, the last update added +# incorporate templates into appdb to simplify code, Jeremy says we can +borrow from lostwages(winehq.org/cvsweb/lostwages) for this to the TODO file. At the moment, I'm trying to use AppDB for another project and I already planned on implementing templates. If nobody else wants to do the job, I'll go ahead and send you a patch as soon as I'm finished. Stefan Pflüger

2 1

Re: Implement DceErrorInqText
by Dmitry Timoshkov Dec. 22, 2004

Dec. 22, 2004

"Bill Medland" <billmedland(a)mercuryspeed.com> wrote: > +RPC_STATUS RPC_ENTRY DceErrorInqTextW (unsigned long e, unsigned short *b) > +{ > + DWORD count; > + if (acceptable_rpc_code (e)) It would be much more natural to make FormatMessageW to decide whether a passed error code is valid or not, i.e. if it exists in the system message table. > + { > + count = FormatMessageW (FORMAT_MESSAGE_FROM_SYSTEM | > + FORMAT_MESSAGE_IGNORE_INSERTS, > + NULL, e, 0, b, /* I don't know!!! */ 65535, NULL); 256 (or 1024) is a reasonable margin I believe, at least messages in Wine are much shorter of even 256. > + } > + else > + count = 0; > + if (!count) > + { > + MultiByteToWideChar(CP_ACP, 0, cszInvalidCode, -1, b, 65535 /* ??? */); A message about invalid code should be localizable as well, so it should be either loaded by LoadString or even by FormatMessage for consistency IMO. winerror.h from PlatformSDK has the following definition which matches your error text ("The error specified is not a valid Windows RPC error code.\r\n"): // // MessageId: RPC_S_NOT_RPC_ERROR // // MessageText: // // The error specified is not a valid Windows RPC error code. // #define RPC_S_NOT_RPC_ERROR 1823L -- Dmitry.

3 5

Re: wine/dlls/cabinet cabextract.c
by Andreas Mohr Dec. 22, 2004

Dec. 22, 2004

Hi, On Wed, Dec 22, 2004 at 11:11:32AM -0600, Alexandre Julliard wrote: > ChangeSet ID: 14986 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/12/22 11:11:32 > > Modified files: > dlls/cabinet : cabextract.c > > Log message: > Revert previous patch, that's not a leak. Nice, but... ;-) [get ready to read my usual "not commented" complaint] Why isn't there a comment nearby? 8 weeks later Joe Janitor 2's source code analyzer tool will strike gold again, and then you'll have fun with another patch "correcting" things that turn(ed) out shouldn't be corrected... Andreas Mohr

1 0

Re: Getting rid of async.h
by Alexandre Julliard Dec. 22, 2004

Dec. 22, 2004

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > - we maintain on the client side whether there's still some pending > async op on the current thread (this is needed in optimizing some wait > operations) That part doesn't look right, you clear the flag when removing the last async operation on an fd, but this bears no relation to the number of async operations in the current thread. It seems to me this could instead be done entirely on the client side, since we need to allocate and free an async structure for each operation we should be able to maintain a counter of them on the client side. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll / kernel32: #52
by Alexandre Julliard Dec. 22, 2004

Dec. 22, 2004

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > +/* FIXME: 0xFFFFFFFF is our shortcut for global table > + * we could also tweak init_atom_table request to get a handle to the > + * global table in wineserver > + */ > +#define GLOBAL_ATOM_TABLE ((void*)0xFFFFFFFF) Yes, you need to get a valid handle here, 0xffffffff is the current process pseudo-handle and we don't want to overload that meaning. Also your local table allocation is not thread-safe, it can potentially leak an atom table. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: test.h: problem with ok's argument evaluation order
by Alexandre Julliard Dec. 22, 2004

Dec. 22, 2004

Rein Klazes <wijn(a)wanadoo.nl> writes: > --- wine/include/wine/test.h 2004-05-04 08:10:39.000000000 +0200 > +++ mywine/include/wine/test.h 2004-12-20 15:29:39.000000000 +0100 > @@ -53,7 +53,8 @@ extern void winetest_trace( const char * > > #endif /* __GNUC__ */ > > -#define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok > +#define winetest_ok_(cond, args...) (cond) ? winetest_ok(TRUE, args) : winetest_ok(FALSE, args) > +#define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok_ Unfortunately varargs macros are not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Merging the AppDB Documentation and the WineHQ documentation pages
by Scott Ritchie Dec. 21, 2004

Dec. 21, 2004

Mike said this about my new "helping applications work" page: >Looks great! I'd suggest putting it in the Documentation section, and >then linking to it from the appdb page. This then prompted me to wonder "which documentation section?" This is kind of confusing: I click on documentation at the main wine page, and I get some useful stuff. I wander into the AppDB page, click on documentation, and I get some different stuff. Methinks we should just dump them all into one page. This has the added benefit of informing people without the wherewithal to click "Applications" that there is, in fact, an AppDB. On another note, it looks like the AppDB documentation is in PHP, rather than the normal template format like the rest of the website. Is this a good idea? Thanks, Scott Ritchie

1 0

Re: wine/dlls/cabinet cabextract.c
by Mike McCormack Dec. 21, 2004

Dec. 21, 2004

This patch breaks IE6 install. Mike Alexandre Julliard wrote: > ChangeSet ID: 14647 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/12/02 11:55:41 > > Modified files: > dlls/cabinet : cabextract.c > > Log message: > James Hawkins <truiken(a)gmail.com> > Fix cabextract memory leak. > > Patch: http://cvs.winehq.org/patch.py?id=14647 > > Old revision New revision Changes Path > 1.15 1.16 +2 -0 wine/dlls/cabinet/cabextract.c

1 0

Some performance stats
by Dmitry Timoshkov Dec. 21, 2004

Dec. 21, 2004

Hello all, while debugging one of applications I'm working on I noticed a lot of GetPrivateProfileString calls with the same file name but in different case causes profile code to open and parse system.ini again. I sent a patch which helps to find a cached file in that case and do not parse it again. I had a thought that another speed improvement might be to use FindFirstFileW instead of CreateFileW/GetFileTime to retrieve last modification time of a file. I wrote a test under Windows to see which of FindFirstFileW or CreateFileW is faster. The test is attached. Here are the results (for 10000 loops) running the same binaries in Wine and Windows 2000 SP4 (hard disks are the same in both systems): =================================================================== Win2k SP4/NTFS volume: test_CreateFileW: P3/1GHz time elapsed 363 ms test_FindFirstFileW: P3/1GHz time elapsed 547 ms Wine/ext3 volume: test_CreateFileW: P3/1GHz time elapsed 543 ms test_FindFirstFileW: P3/1GHz time elapsed 1650 ms =================================================================== CreateFileW is only 1.5 times slower in Wine than in Windows, that's really not bad (especially taking into account Wine boot time), but still there is a possibility for an improvement. FindFirstFileW is 3 times slower in Wine than CreateFileW, while it's only 1.5 times slower in Windows. This needs to be optimized. -- Dmitry.

1 0

wine-alsa gives compile errors
by Joris Huizer Dec. 21, 2004

Dec. 21, 2004

Hello, I'm not sure where to post this, so posting to wine-users and wine-devel; I got wine sources from cvs and tried compiling it -- something seems to be wrong in the alsa code - it gives compile errors about functions getting too many arguments (I attached an error log) Hopefully this is fixed soon regards, Joris

1 0

Re: [OLE #3] Tests For COM Functions (Try 2)
by Dmitry Timoshkov Dec. 21, 2004

Dec. 21, 2004

"Robert Shearman" <rob(a)codeweavers.com> wrote: > This differs from the previous send of this patch by not using some > functions that are not present on Win9x and without DCOM95 and by > disabling the out-of-process COM tests, which seems to need more work, > but is useful for me testing locally. Dmitry, you reported to me before > that Win95 w/o DCOM95 does not export CoResumeClassObjects, but MSDN > claims that it does. Is MSDN wrong? Just checked Win95 OSR2 again: ole32.dll does not export CoResumeClassObjects. That's a clean system, without MS Office, DCOM95 or something like that. -- Dmitry.

1 0

My "Helping Applications Work" Guide
by Scott Ritchie Dec. 21, 2004

Dec. 21, 2004

I've recently finished up my "helping applications work" guide. It's meant to be something an end user with a problem application can read, and if he has the will to learn how to help. However, I'm not exactly sure where to put it on the winehq website. Perhaps it should be linked from the main page of the applications database, or from the support tab, or something. Anyway, I'm posting it here for peer review. I've also sent it to wine-patches, but as I said nothing yet links to it. Thanks, Scott Ritchie ----helping_applications.template---- <h1>How to help get applications working in Wine</h1> <p>If you want to help get an application working in Wine, the first thing you should do is register yourself in the applications database and use one of your votes to indicate that you'd like more effort to be spent on the application. Every once in a while, a wine developer will finish a project and look for something to do - combing through the higher voted apps to find one that people need work on is a great way to spend one's time and fill up a todo list.</p> <p>If the application that you want working is not listed in the applications database, there is an easy to use form available for you to add it.  If the application is in the database, but lacks a maintainer you should consider becoming one. If you are familiar with wine and have a desire to test the application and help get or keep it working, please apply by clicking the link in the application's page. Each application should have a supermaintainer, and, if different versions of the application are substantially different (such as in Internet Explorer), each subversion should have a maintainer. Please don't feel deterred by the need to apply to become a maintainer - the application form is largely a formality to prevent abuse and we can virtually guarantee your acceptance.</p> <p>If you are the developer or publisher of the application, you obviously have a very big incentive to help get your application working under wine. Fortunately, there are many options available to you other than reporting bugs and hoping someone will fix them. By far the easiest way is to simply send free copies of your software to wine developers and hope they'll take an interest in getting it working. You'd be amazed how effective this approach can be, particularly for games. An alternative option, perhaps more effective and expensive, is to pay wine developers for their work on your application, either directly through a negotiated contract or indirectly by posting a bounty. The most direct method, however, is to help develop wine itself and contribute code directly, which is exactly what Corel did for WordPerfect several years ago. In any case, making a post on the wine developers <a href="http://www.winehq.org/site/forums">email list</a> can go a long way. <h2>If your application doesn't work:</h2> <p>If your application experiences problems in a particular area, or fails to even run at all, there are a number of steps you can take to help us. The most important thing is to find out where exactly the application is failing. To diagnose application problems, the first step is to run the program from the console using wine, rather than from a gui shortcut. This will allow wine to output error messages to the console, the understanding of which are key to solving the problem and getting the application to work.</p> <p>An application may not work because Wine doesn't yet fully implement one of the DLL files the application is trying to use. If you encounter a DLL not found error, or see a lot of "FixMe:" messages while running the application in wine, this is likely the case. When this occurs, you can try using native (non-wine) DLL files in place of Wine's builtin ones. Check the application database page for the program. There may be special configuration options or instructions for installing native DLL files there that you can try to get the application working. For further configuration help, please see the <a href="http://www.winehq.org/site/docs/wine-user/running">Running Wine</a> section of the User Guide.</p> <p>If the application still doesn't work, it's probably due to a bug or deficiency in Wine and we'd like to hear about it. Please see the <a href="http://bugs.winehq.org/">reporting bugs</a> page for instructions on how to best report bugs with applications.</p> <h2>If your application does work, but with some difficulty:</h2> <p>Sometimes, applications run under wine but they don't function quite as smoothly as they do in windows. They may have display errors, a feature may be broken, or they may run unusually slow. These applications should receive a lower rating from their maintainers of between 2 and 4 stars in the Application's Database, depending on the degree of difficulty encountered.</p>  <p>If you have found a way to make an application work that is more complicated than simply installing it, please share that information by posting on the application's page in the database. If you are the maintainer for the application, please post the instructions in a "howto," which will appear inside green bars at the top of the application's page.</p> <h2>If your application used to work, but has since broken in a new version of wine:</h2> <p>Wine is a large and complex project, composed of many files written by different authors. Sometimes, an attempt to change a file and expand support for one application will unexpectedly cause another application to stop functioning. These changes are known as "regressions", and they are unfortunately sometimes found in the wine source code because the author of a patch that causes a regression is quite simply unaware of it. Since the wine developers can't possibly test every application with every patch, we have to rely on the community to inform us of when regressions occur so that the problem can be easily identified and ultimately fixed. Without community involvement, regressions can go unfixed for potentially very long periods of time.</p> <p>If your application has experienced a regression, please try and provide us with as much information as you can about when and how it broke. This allows us to isolate the exact thing we screwed up in the code and provide a fix. Please provide as much as you know about which version of wine worked, and which version didn't, including the version number and how you installed it (from source, binary packages, etc.) Finally, please post these things in the Application Database page for the app.</p> <p>If you wish to be extremely helpful, you can try to isolate the exact patch which broke your application. This takes quite a bit of time and effort, but it is quite simply the best way to get your application working again. When it comes to fixing regressions, the only thing more helpful to the wine developers than knowing exactly which patch caused a regression is receiving a fix for the patch itself. For help with isolating problem patches, please see the documentation on <a href="http://www.winehq.org/site/docs/wine-devel/x1375">regression testing</a>.</p>

2 1

Re: [LOSTWAGES]New short About blurb on the Front Page
by Scott Ritchie Dec. 21, 2004

Dec. 21, 2004

http://www.winehq.org/hypermail/wine-patches/2004/12/0343.html Is there a reason why this little update hasn't been committed? I think it makes the front page a bit more user-friendly, as well as updating some of the links. Thanks, Scott Ritchie

1 0

Re: Make winetest.exe detect if it is running on a visible desktop. Now without the linewrap.
by Ferenc Wagner Dec. 20, 2004

Dec. 20, 2004

Jakob Eriksson <jakov(a)vmlinux.org> writes: > Now without the linewrap. I hate to say this, but it's still wrapped... :( -- Feri.

1 0

Janitorial: HeapFree of NULL
by Michael Stefaniuc Dec. 20, 2004

Dec. 20, 2004

Hello, there is a lot (my attached smatch script found 234 occurences) of code like if (this) HeapFree(GetProcessHeap(), 0, this); HeapFree(GetProcessHeap(), 0, that); which is redundant because after Win2000 (if i can trust the comment in RtlFreeHeap) freeing a NULL pointer isn't an error. I've checked it Win2000 and can confirm that. I've also checked Win95 and Win98 and both don't crash when HeapFree'ing a NULL but they return an error and SetLastError to 212 "ERROR_LOCKED". In the above code the return code of HeapFree isn't checked so this wouldn't matter if somebody would run the Wine code on that Win versions. So i propose to shorten that code to HeapFree(GetProcessHeap(), 0, this); HeapFree(GetProcessHeap(), 0, that); I've done this already for the wininet dll (see patch to wine-patches) and if it gets accepted i'll take care of the rest. Advantages: - less (redundant) code - more pleasant to the eye - for the wininet.dll it saves 1.1kB (FC2, gcc-3.3.3-7) in the generated code (ok, the wininet.dll.so is 1.6 MB but still) Disadvantages: - if the pointer is NULL it takes longer for that code path. But i don't think it matters cause this happens mostly only on the (unlikely) error path. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: OpenSCManager() bug
by Ivan Leo Puoti Dec. 20, 2004

Dec. 20, 2004

>Hello, > >initially i tested this stuff under XP and it raised exception if lpDatabaseName >is invalid pointer. But after you noticed the bug i run the test under 2000 and >it has been returned ERROR_NOACCESS. > >Both versions return ERROR_INVALID_NAME if lpDatabaseName is empty string. > >I think the patch should look like this: In Age of Empires 2 lpDatabaseName is just an empty string, so I've sent a patch to wine-patches that allows the database name to be '\0'. Ivan.

1 0

Re: TopLevelWindow Maximize
by Dmitry Timoshkov Dec. 20, 2004

Dec. 20, 2004

"Katia Maculan" <katia.maculan(a)isis-papyrus.com> wrote: > + switch (message) > + { > + case WM_SHOWWINDOW: > + case WM_SIZE: > + DefWindowProc(hWnd, message, wParam, lParam); > + PostMessage (hWnd, WM_PAINT, 0, 0); If you wish to schedule a WM_PAINT message you have to invalidate a window. -- Dmitry.

2 1

Re: OpenSCManager() bug
by Alexander Yaworsky Dec. 20, 2004

Dec. 20, 2004

Hello, initially i tested this stuff under XP and it raised exception if lpDatabaseName is invalid pointer. But after you noticed the bug i run the test under 2000 and it has been returned ERROR_NOACCESS. Both versions return ERROR_INVALID_NAME if lpDatabaseName is empty string. I think the patch should look like this: @@ -750,6 +750,11 @@ if( lpDatabaseName ) { + if( IsBadStringPtrW( lpDatabaseName, -1 ) ) + { + SetLastError( ERROR_NOACCESS ); + return NULL; + } if( strcmpiW( lpDatabaseName, SERVICES_ACTIVE_DATABASEW ) == 0 ) { /* noop, all right */ On the other hand i think that all this stuff is a kind of masturbation. When i implemented this, i used some tests (i'm going to put them into shape of unit tests) to investigate the real behaviour. The last patch establishes that behaviour replacing fixme that was an eyesore, but in reality the database name is not used and IMO will never be used. Ivan Leo Puoti wrote: > This patch http://cvs.winehq.org/patch.py?id=14769 had caused a problem with Age > of Empires. The game uses a copy protection system that is installed as a > service, before your patch, the service tried to load the copy protection driver > (This fails, but that's another story), after your patch wine goes straight to > the debugger after calling OpenSCManager. I added a trace and found that this > code is executed > { > FIXME("ERROR_INVALID_NAME"); > return NULL; > } > and causes the crash. The value of lpDatabaseName that AoE passes to the > function is 1; also according to MSDN > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/ba… > lpDatabaseName can be NULL, and in this case SERVICES_ACTIVE_DATABASE is opened. > As it's late here the only idea I get at the moment is to print the value as a > FIXME or ERR or whatever, and not return NULL, as this doesn't appear to be the > correct behavior. As you've implemented this stuff and I don't know much about > it I would like to know what you think.

1 0