December 2004 - Wine-Devel - list.winehq.org

Wine CVS still broken
by Florian Goth Dec. 8, 2004

Dec. 8, 2004

I deleted my wine - folder and did a full cvs checkout today(23:00 CET ) But there's still a problem in winejack: The previously reported errors seem to be away gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -O2 -march=athlon-xp -m32 -mmmx -m3dnow -msse -ftracer -funroll-loops -fpeel-loops -funswitch-loops -fweb -funit-at-a-time -o winejack.drv.dbg.o winejack.drv.dbg.c ../../../tools/winegcc/winegcc -B../../../tools/winebuild -shared ./winejack.drv.spec audio.o jack.o winejack.drv.dbg.o -o winejack.drv.so -L../../../dlls -lwinmm -luser32 -lkernel32 -L../../../libs/wine -lwine -ldxguid -luuid -L../../../libs/port -lwine_port audio.o(.text+0x22fe): In function `JACK_WaveInit': /home/sifff/wine/dlls/winmm/winejack/audio.c:935: undefined reference to `strcpyW' audio.o(.text+0x23de):/home/sifff/wine/dlls/winmm/winejack/audio.c:969: undefined reference to `strcpyW' collect2: ld gab 1 als Ende-Status zurück winegcc: gcc failed. make[2]: *** [winejack.drv.so] Fehler 2 make[2]: Leaving directory `/home/sifff/wine/dlls/winmm/winejack' make[1]: *** [winmm/winejack] Fehler 2 make[1]: Leaving directory `/home/sifff/wine/dlls' make: *** [dlls] Fehler 2

2 1

Re: windows/win.c : add missing styles
by Dmitry Timoshkov Dec. 8, 2004

Dec. 8, 2004

"Rémi Assailly" <remi.assailly(a)free.fr> wrote: > --- windows/win.c~ 2004-11-29 18:35:46.000000000 +0100 > +++ windows/win.c 2004-12-07 18:04:02.135332008 +0100 > @@ -872,7 +872,6 @@ > if(style & WS_MINIMIZEBOX) TRACE(" WS_MINIMIZEBOX"); > if(style & WS_MAXIMIZEBOX) TRACE(" WS_MAXIMIZEBOX"); > > - /* FIXME: Add dumping of BS_/ES_/SBS_/LBS_/CBS_/DS_/etc. styles */ Don't remove this line, your patch doesn't add dumping of those styles. > #define DUMPED_STYLES \ > (WS_POPUP | \ > WS_CHILD | \ > @@ -882,6 +881,7 @@ > WS_CLIPSIBLINGS | \ > WS_CLIPCHILDREN | \ > WS_MAXIMIZE | \ > + WS_CAPTION | \ This isn't a style you want to add here. > WS_BORDER | \ > WS_DLGFRAME | \ > WS_VSCROLL | \ > @@ -891,7 +891,94 @@ > WS_GROUP | \ > WS_TABSTOP | \ > WS_MINIMIZEBOX | \ > - WS_MAXIMIZEBOX) > + WS_MAXIMIZEBOX | \ > + BS_DEFPUSHBUTTON | \ > + BS_CHECKBOX | \ > + BS_AUTOCHECKBOX | \ > + BS_AUTOCHECKBOX | \ > + BS_3STATE | \ > + BS_AUTO3STATE | \ > + BS_GROUPBOX | \ > + BS_USERBUTTON | \ > + BS_AUTORADIOBUTTON | \ > + BS_OWNERDRAW | \ > + BS_LEFTTEXT | \ > + BS_ICON | \ > + BS_BITMAP | \ > + BS_LEFT | \ > + BS_RIGHT | \ > + BS_CENTER | \ > + BS_TOP | \ > + BS_BOTTOM | \ > + BS_VCENTER | \ > + BS_PUSHLIKE | \ > + BS_MULTILINE | \ > + BS_NOTIFY | \ > + BS_FLAT | \ > + ES_CENTER | \ > + ES_RIGHT | \ > + ES_MULTILINE | \ > + ES_UPPERCASE | \ > + ES_LOWERCASE | \ > + ES_PASSWORD | \ > + ES_AUTOVSCROLL | \ > + ES_AUTOHSCROLL | \ > + ES_NOHIDESEL | \ > + ES_COMBO | \ > + ES_OEMCONVERT | \ > + ES_READONLY | \ > + ES_WANTRETURN | \ > + ES_NUMBER | \ > + SBS_VERT | \ > + SBS_TOPALIGN | \ > + SBS_LEFTALIGN | \ > + SBS_BOTTOMALIGN | \ > + SBS_RIGHTALIGN | \ > + SBS_SIZEBOXTOPLEFTALIGN | \ > + SBS_SIZEBOXBOTTOMRIGHTALIGN | \ > + SBS_SIZEBOX | \ > + SBS_SIZEGRIP | \ > + LBS_NOSEL | \ > + LBS_COMBOBOX | \ > + LBS_STANDARD | \ > + CBS_SIMPLE | \ > + CBS_DROPDOWN | \ > + CBS_DROPDOWNLIST | \ > + CBS_OWNERDRAWFIXED | \ > + CBS_OWNERDRAWVARIABLE | \ > + CBS_AUTOHSCROLL | \ > + CBS_OEMCONVERT | \ > + CBS_SORT | \ > + CBS_HASSTRINGS | \ > + CBS_NOINTEGRALHEIGHT | \ > + CBS_DISABLENOSCROLL | \ > + CBS_UPPERCASE | \ > + CBS_LOWERCASE | \ > + DS_ABSALIGN | \ > + DS_SYSMODAL | \ > + DS_3DLOOK | \ > + DS_FIXEDSYS | \ > + DS_NOFAILCREATE | \ > + DS_LOCALEDIT | \ > + DS_SETFONT | \ > + DS_MODALFRAME | \ > + DS_NOIDLEMSG | \ > + DS_SETFOREGROUND | \ > + DS_CONTROL | \ > + DS_CENTER | \ > + DS_CENTERMOUSE | \ > + DS_CONTEXTHELP | \ > + SS_USERITEM | \ > + SS_LEFTNOWORDWRAP | \ > + SS_OWNERDRAW | \ > + SS_BITMAP | \ > + SS_ENHMETAFILE | \ > + SS_ETCHEDHORZ | \ > + SS_ETCHEDVERT | \ > + SS_ETCHEDFRAME | \ > + SS_TYPEMASK | \ > + SS_WORDELLIPSIS | \ > + SS_ELLIPSISMASK) And where do you dump all the above listed styles? (Just a hint: you can't dump them without looking at the class name, and it won't work for superclassed windows). -- Dmitry.

1 0

Feedback on user manual
by Ross Boylan Dec. 8, 2004

Dec. 8, 2004

The manual lamented the lack of feedback, so I thought I'd give you some. 1.1.1 says "It tries to target both the new Wine user, by offering a step by step approach, and the experienced Wine user, by offering the reference material mentioned above." Ordinarily, I would expect the novice stuff, followed by reference material. But, judging from the table of contents, this isn't what you've done. It would be good to say how the stuff is arranged. Assuming the novice and expert stuff is interspersed, it might be better to separate them. Yes, I realize that's probably a lot of work. That's why this is only a though :) You might also want to put a date and version number on the documentation; at least on Debian, looking at the html, I don't see it. I'm using wine-doc 0.0.20040716-1.3. Thanks for your work on wine. -- Ross Boylan wk: (415) 502-4031 530 Parnassus Avenue (Library) rm 115-4 ross(a)biostat.ucsf.edu Dept of Epidemiology and Biostatistics fax: (415) 476-9856 University of California, San Francisco San Francisco, CA 94143-0840 hm: (415) 550-1062

3 3

Compiling wine fails
by Florian Goth Dec. 7, 2004

Dec. 7, 2004

Patch: http://cvs.winehq.org/patch.py?id=14706 breaks compiling on my system(kernel-2.6.9; gcc 3.4.2 ) Reverting the patch fixes compiling. The patch produces the following Errors: make[2]: Entering directory `/home/sifff/wine/dlls/winmm/winejack' gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -O2 -march=athlon-xp -m32 -mmmx -m3dnow -msse -ftracer -funroll-loops -fpeel-loops -funswitch-loops -fweb -funit-at-a-time -o audio.o audio.c audio.c: In function `JACK_WaveInit': audio.c:902: Warnung: implizite Deklaration der Funktion »wine_dlsym« audio.c:902: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:903: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:904: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:905: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:906: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:907: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:908: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:909: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:910: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:911: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:912: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:913: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:914: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:915: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:916: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:934: Warnung: implizite Deklaration der Funktion »strcpyW« audio.c:998: Warnung: implizite Deklaration der Funktion »wine_dlclose« audio.c: In function `wodDevInterfaceSize': audio.c:1682: Warnung: implizite Deklaration der Funktion »MultiByteToWideChar« audio.c:1682: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) audio.c:1682: Fehler: (Jeder nicht deklarierte Bezeichner wird nur einmal aufgeführt audio.c:1682: Fehler: für jede Funktion in der er auftritt.) audio.c: In function `wodDevInterface': audio.c:1692: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) audio.c: In function `widDevInterfaceSize': audio.c:2428: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) audio.c: In function `widDevInterface': audio.c:2438: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) make[2]: *** [audio.o] Fehler 1 make[2]: Leaving directory `/home/sifff/wine/dlls/winmm/winejack' make[1]: *** [winmm/winejack] Fehler 2 make[1]: Leaving directory `/home/sifff/wine/dlls' make: *** [dlls] Fehler 2

3 2

Fwd:[Fwd: [AppDB] Status Report]
by Ivan Leo Puoti Dec. 7, 2004

Dec. 7, 2004

Can someone working on appdb fix this? Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: No more winrash?
by Ferenc Wagner Dec. 7, 2004

Dec. 7, 2004

Jakob Eriksson <jakov(a)vmlinux.org> writes: > Do you agree, should we stop using winrash? > > "Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > >> "Jakob Eriksson" <jakov(a)vmlinux.org> wrote: >> >>> Well, I tried now marking the service as interactive, >>> but that didn't make any difference. >>> >>> So, what follows, deprecate Winrash? >> >> If it really breaks the tests then definitely yes. I think it does provide much useful information which would be largely lost if we resorted to manual testing. What's more, winetest is not really up to that, as it doesn't ask for a tag but relies on a command line option which people would tend to forget. What I propose: make winetest detect whether it's running on an interactive desktop or not, and include this info in the header just like bRunningUnderWine. Meanwhile add the tag dialog to winetest and separate or mark the different reports on the webpage for easier reference. That would bring us the best of both worlds. Or possibly tweak the sensitive tests (how many are there?) to make clear in the output that they were not run for this reason... That would probably require a new field in the final report (ie. success-failure-todo-skipped or similar). This could also signal WINETEST_INTERACTIVE tests so that they aren't forgotten about... That said, I don't know much of this desktop business, so I'm not sure how to put the detection logic in. The rest should not be hard, I hope I'll find the time for them if we decide to go this way. -- Feri.

4 3

Re: Shell about box
by Dmitry Timoshkov Dec. 7, 2004

Dec. 7, 2004

"Ge van Geldorp" <gvg(a)reactos.com> wrote: > Changelog: > Klemens Friedl <frik85(a)hotmail.com> > - Design Shell About dialog more Windows-like The patch will not apply since it's utf-8 encoded. -- Dmitry.

1 0

Re: Implemented CreateAsyncBindCtx
by Alexandre Julliard Dec. 7, 2004

Dec. 7, 2004

Jacek Caban <jack(a)itma.pwr.wroc.pl> writes: > It's my tiny bug. RegsterObjectParam can fail only with E_OUTOFMEMORY > here, so checking it's return is > really not important, but to be correct at all, hres should be just > returned. No, that's worse than before, now you return an error while still allocating the object. You need to cleanup the allocated context when returning a failure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Help with some strange debugging.
by Jon Griffiths Dec. 7, 2004

Dec. 7, 2004

Hi Oliver, >I've also got a little patch for oleaut/varient.c to >allow number-string comparisons. There are a couple of >undocumented assumptions I've made,like what to return >for an empty of if the string isn't a number, and the >only thing I've been able to test with is 1 vb >application as I don't have windows, should I post it >to this list or to patch? If you need to test how the native dll works, please write a unit test case for the comparasons you are interested in (there are a _huge_ number of variant tests already defined in the dlls/oleaut32/tests directory). Run the tests manually from the tests directory as: WINEDLLOVERRIDES="oleaut32=n" wine ./oleaut32test.exe.so <testname> To check out the native versions behaviour (of course you will need a native oleaut32.dll in your fake c:\windows\system dir). for the builtin version run: WINETEST_PLATFORM="wine" WINEDLLOVERRIDES="oleaut32=b" wine ./oleaut32test.exe.so <testname> This will catch any regressions from your patch and ensure that future changes don't break your changes in any way. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Re: Providing success stories
by Dan Kegel Dec. 7, 2004

Dec. 7, 2004

Stefan Munz wrote: > In order to push the use of Open Source Software we plan a project with the > "Wirtschaftsförderung Region Stuttgart GmbH" ... to > find software producers who pay us for a wine compatibility test of their > software. ... What's the URL, by the way? Is it http://opensource.region-stuttgart.de/ ? > This project is starting at the moment. I thought a good idea to give > something back to the community is to provide some success stories i.e. for > use on winehq.com. Is this interesting? Yes. I don't see anything on winehq.com like that, but http://www.codeweavers.com/site/products/case_studies seems to be along the lines you're thinking of, maybe? Try just writing up a first draft of a success story on a web page somewhere, and post a link to wine-devel so we can see what you're thinking of. Then I'm sure getting it onto winehq.org will be easy. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

gdi/metafile tests
by Walt Ogburn Dec. 7, 2004

Dec. 7, 2004

To Dmitry Timoshkov - I have started working on some tests (attached here) for metafile functions in gdi. If these seem reasonable, should I add them to your metafile.c test code, or move yours to enhmetafile.c and start a new metafile.h? Thanks, Walter

2 1

Re: msvcrt: implement _dup (take 2)
by Dmitry Timoshkov Dec. 7, 2004

Dec. 7, 2004

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > + if (DuplicateHandle(GetCurrentProcess(), MSVCRT_fdesc[od].handle, > + GetCurrentProcess(), &handle, 0, > + !(MSVCRT_fdesc[od].wxflag & WX_DONTINHERIT), DUPLICATE_SAME_ACCESS)) > + { > + ret = msvcrt_alloc_fd(handle, MSVCRT_fdesc[od].wxflag); > + if (ret == -1) > + *MSVCRT__errno() = MSVCRT_EMFILE; > + } You need to close duplicated handle in the case of msvcrt_alloc_fd failure. -- Dmitry.

2 1

Re: stub implementation for GetLastInputInfo and SetLayeredWindowAttributes
by Dmitry Timoshkov Dec. 7, 2004

Dec. 7, 2004

"Mike McCormack" <mike(a)codeweavers.com> wrote: > +BOOL WINAPI GetLastInputInfo(PLASTINPUTINFO); ... > diff -u -r1.90 user32.spec > --- dlls/user/user32.spec 19 Oct 2004 21:10:17 -0000 1.90 > +++ dlls/user/user32.spec 6 Dec 2004 18:01:17 -0000 > @@ -263,6 +263,7 @@ > @ stdcall GetKeyboardState(ptr) > @ stdcall GetKeyboardType(long) > @ stdcall GetLastActivePopup(long) > +@ stdcall GetLastInputInfo() Number of parameters in header and spec files mismatch and there is no stub implementation of GetLastInputInfo at all. -- Dmitry.

1 0

Fedora Core 2 VM layout
by Kenneth Porter Dec. 7, 2004

Dec. 7, 2004

There's a thread going on the fedora-devel list about exec-shield, legacy_va_layout, and WINE: <https://www.redhat.com/archives/fedora-devel-list/2004-December/msg00132.ht…> Some WINE experts might want to weigh in over there. Are these still issues with the current WINE release?

2 1

[Regression] "Moved visible region calculation to the server" patch broked apllication
by Paul van Schayck Dec. 6, 2004

Dec. 6, 2004

Hey everyone, Since the 23th of July the main opengl window of this application has been broken. It's not being drawn. You can find the application (MSI installer) here: http://www.meosource.com/firefox/asrc11.zip The patch that broked it can be found here: http://cvs.winehq.org/patch.py?id=12703 The CVS log entry can be found here: http://www.winehq.org/hypermail/wine-cvs/2004/06/0196.html Right after that patch nothing was being drawn. With current cvs checkouts the top menu is vissible again. Kind regards, Paul van Schayck

1 0

Re: [dx9-16] Basetexture support
by Robert Shearman Dec. 6, 2004

Dec. 6, 2004

Ann and Jason Edmeades wrote: >This patch adds a parent class to the various types of textures > >Changelog > >Add BaseTexture class support, call from d3d9. > >Jason > >Note: This adds a new file, basetexture.c which is also part of the patch > > The ref-counting in this patch looks a bit suspicious. Does This->resource.parent point to an object that holds a ref-count on the IWineD3DBaseTextureImpl object? If so, then that would lead to a circular ref-count where neither object would be freed. Rob

2 1

Re: Another systray patch
by Grant Williamson Dec. 6, 2004

Dec. 6, 2004

Mike, I tried saving the patch in various ways, maybe its me, but it would appear its corrupted, can u resend as attachment, thanks. [root(a)trax wine-20041201]# patch -p0 -i /usr/src/redhat/SOURCES/systray-20041206.patch patching file dlls/x11drv/event.c patching file dlls/x11drv/window.c patching file dlls/x11drv/x11drv.h patching file programs/wineshell/Makefile.in patching file programs/wineshell/wineshell.c patching file programs/wineshell/wineshell.h patching file programs/wineshell/systray.c patch: **** malformed patch at line 485:

1 0

Re: wine/dlls/ntdll directory.c
by Mike Hearn Dec. 6, 2004

Dec. 6, 2004

On Mon, 06 Dec 2004 10:48:16 -0600, Alexandre Julliard wrote: > Log message: > Use a direct getdents syscall on Linux to avoid relying on > implementation details of seekdir/telldir. > > Patch: http://cvs.winehq.org/patch.py?id=14699 Does this fix the hang on Reiser4 by any chance? thanks -mike

2 1

Re: Turn off Antialiasing for Rendering with Palette - Take 2
by Dmitry Timoshkov Dec. 6, 2004

Dec. 6, 2004

"Glenn Wurster" <glenn(a)electric.ath.cx> wrote: > ret = dc->funcs->pExtTextOut(dc->physDev,x,y,flags|ETO_IGNORELANGUAGE, > - lprect,lpReorderedString,count,lpDx,dc->breakExtra); > + lprect,lpReorderedString,count,lpDx,dc->breakExtra,antialias); I think that it should be the ExtTextOut's backend responsibility whether to use antialiasing or not, taking into account ANTIALIASED_QUALITY and CLEARTYPE_QUALITY value of the LOGFONT.lfQuality field. -- Dmitry.

2 1

Wine failed during HEAP_CreateSystemHeap
by Tobias Grosser Dec. 6, 2004

Dec. 6, 2004

Hi, i tried to use the new FreeBSD Wine port und FreeBSD 5.3. And I am able to start wine, but while executing "wine ie6setup.exe" an error during CreateSystemHeap shows up. Unfortunately I am not able to solve this problem by myself, and need some advice how to debug this correct. Here the output, after which wine exits: fixme:file:get_default_drive_device auto detection of DOS devices not supported on this platform fixme:ntdll:NtQueryVolumeInformationFile device info not properly supported on this platform err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not availablefixme:ntdll:NtQueryVolumeInformationFile device info not properly supported on this platform err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not availableerr:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not availableerr:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! I tried to change SYSTEM_HEAP_BASE to 0xC0000000 for testing, but this shows an equal output. If I open wine in gdb I am not able to set a breakpoint at line 96 "if(!(base = MapViewOfFileEx( map, FILE_MAP_ALL_ACCESS, 0, 0, 0, SYSTEM_HEAP_BASE )))" to start debugging. Starting at the beginning of the function throws me into inline assambler and some "valgrind" code, but nothing i can deal with. It would be great to give me some debugging advice. Thanks in advance Tobias

2 1

needing some help...
by MyComputer Store Dec. 6, 2004

Dec. 6, 2004

Hey... I am just getting into this whole wine thing and I have already run into a problem. I am working on switching my Media Matrix servers over to linux, but the software that I need to run is still windows based. Here is the link to the software. http://mm.peavey.com/downloads/mware335.exe when I try to run this file with wine (20041201) it locks up before the installer has finished loading... any advise?? Caleb Miller

1 0

Re: mdi.c/MDI_ChildActivate query
by Jeremy White Dec. 6, 2004

Dec. 6, 2004

Works nicely; thank you (and my schools chess club, soon to have a tourney, thanks you <grin>). Cheers, Jeremy Dmitry Timoshkov wrote: > "Jeremy White" <jwhite(a)codeweavers.com> wrote: > > >>When trying to run 'Swiss Perfect' (www.swissperfect.com, >>free download available), the app crashes and burns while >>processing a WM_MDIACTIVATE message when the prevWnd is 0. > > > This is due to a long standing hack in X11DRV_ShowWindow which > forces MDI child activation. > > Attached patch adds a couple of new MDI message tests using existing > message sequences for ordinary child windows and confirms that > ShowWindow does the same job for MDI children in respect to activation. > > This fixes a crash in Swiss Perfect. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > ShowWindow activates only a being maximized child window, > add a couple of message tests for MDI child activation. >

1 0

Kernel 2.6.10... and amd64
by Jose Alberto Reguero Dec. 6, 2004

Dec. 6, 2004

I can't use wine with kernels 2.6.10-rc2.... With kernel 2.6.9 it works. My system is an amd64 linux. Thanks. Jose Alberto

1 2

IME question
by Ivan Leo Puoti Dec. 5, 2004

Dec. 5, 2004

According to MSDN, windows creates an IME window and an input context for every thread, should wine do the same? Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Implemented CreateAsyncBindCtx
by Mike Hearn Dec. 5, 2004

Dec. 5, 2004

On Fri, 03 Dec 2004 23:01:36 -0500, Jacek Caban wrote: > + hres = IBindCtx_RegisterObjectParam(bctx, (LPOLESTR)BSCBHolder, (IUnknown*)callback); > + > + *pbind = bctx; > + > + return S_OK; > } You don't do anything with hres here, is that intentional? Can RegisterObjectParam fail? thanks -mike

2 1

mdi.c/MDI_ChildActivate query
by Jeremy White Dec. 5, 2004

Dec. 5, 2004

Hi, When trying to run 'Swiss Perfect' (www.swissperfect.com, free download available), the app crashes and burns while processing a WM_MDIACTIVATE message when the prevWnd is 0. If I modify the code as in the attached patch, everything works. I can't determine if the app is flawed or if this is a good change to Wine; I'm hoping an MDI expert can kibitz. Cheers, Jeremy

1 0

Wrapper for Winelib
by Sam Lauber Dec. 5, 2004

Dec. 5, 2004

I *think* I've figured out a way to make regular Unix programs with winelib. My idea is, make winemaker generate a C file called "winelib-wrap.c" that contains: #include <stddef.h> int main(void) { return (int) WinMain(NULL, NULL, NULL, NULL); } Then link it with the EXE encapusulated in a .so, and it SHOULD work. I'll try it on the 01-stdole32.c. It gave me a SIGSEGV, but maybe someone would fix it. Samuel Lauber -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

2 1

Re: msvcrt: set mode bits in _fstati64
by Dmitry Timoshkov Dec. 5, 2004

Dec. 5, 2004

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > + buf->st_mode = S_IFREG; > + if (!(hfi.dwFileAttributes & (FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM))) > + { > + buf->st_mode |= S_IREAD; > + if (!(hfi.dwFileAttributes & FILE_ATTRIBUTE_READONLY)) > + buf->st_mode |= S_IWRITE; > + } Why do you take into account (FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM) at all? They have nothing to do with an ability to read/write files. What you probably need to consider is a type of a file passed in. -- Dmitry.

2 5

questions dlls/d3d8/shader.c
by Eric Pouech Dec. 5, 2004

Dec. 5, 2004

while toying with Intel compiler on Wine source, I came across a couple of interesting stuff. To whom it may concern. in dlls/d3d8/shader.c: vshader_m4x3 (and vsharer_m3x4) don't use correctly row & columns with respect to the matrice definition. I let the D3D folks decide whether the matrix definition, or the implementation is to blame IDirect3DVertexShaderImpl_ExecuteSW: you miss one in size of p_send (and likely p) in windows/sys_params.c SystemParametersInfoW, for the case SPI_GETLOWPOWERACTIVE, this index is out of the bounds of spi_loaded in dlls/shell32/shlview.c ShellView_OnNotify, case LVN_BEGINDRAG and LVN_BEGINRDRAG, the dwEffect value is not initialized before calling DoDragDrop !!! A+

2 1

Re: Mirroring support take 1
by Juan Lang Dec. 5, 2004

Dec. 5, 2004

This doesn't look right: @@ -2071,6 +2077,7 @@ WIN_ReleasePtr( wndPtr ); return retval; } + break; /* fall through */ If the break is missing, why does the comment say fall through? I think it was intentional. If the break should be there, please remove the comment as well. --Juan __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

Re: Janitorial: WinMM conversion of 32 bit low level drivers to Unicode interface
by Eric Pouech Dec. 5, 2004

Dec. 5, 2004

Eric Pouech a écrit : > This patch is based on work by Filip Navara from ReactOS. > He did the Winmm part (+wave & midi mapper), I did the rest (+ 16 > message mapping) > A+ well, another take (I forgot a couple of places...) I also removed the SB related code. What's missing it's the proper registry settings when a device is chosen, and we'd better do it either in winecfg or wine.inf, but not in the drivers themselves A+

1 0

Problem to draw a bitmap
by Rémi Assailly Dec. 5, 2004

Dec. 5, 2004

I tested a program ( an other one, with source code this time ) On my Windows XP system I have no problem. When I use Wine I just get a window. ( where is my bitmap ? ) Then I tried this : "WINEDEBUG=gdi wine progtest" and as Wine is slower I could see my bitmap, which disappeared as fast as it appeared... Here the source code : > #include <windows.h> > #include <wingdi.h> > > void PrintBmp(HWND hWnd, char *filename) > { > HBITMAP hBmp; > HDC hDC; > hBmp=(HBITMAP)LoadImage(NULL,filename,IMAGE_BITMAP,0,0,LR_LOADFROMFILE); > hDC=GetDC(hWnd); > DrawState(hDC,NULL,NULL,(LPARAM)hBmp,NULL,0,0,0,0,DST_BITMAP); > DeleteObject(hBmp); > ReleaseDC(hWnd,hDC); > } > > /* Declare Windows procedure */ > LRESULT CALLBACK WindowProcedure (HWND, UINT, WPARAM, LPARAM); > > /* Make the class name into a global variable */ > char szClassName[ ] = "WindowsApp"; > > > int WINAPI > WinMain (HINSTANCE hThisInstance, > HINSTANCE hPrevInstance, > LPSTR lpszArgument, > int nFunsterStil) > > { > HWND hwnd; /* This is the handle for our window */ > MSG messages; /* Here messages to the application are saved */ > WNDCLASSEX wincl; /* Data structure for the windowclass */ > > /* The Window structure */ > wincl.hInstance = hThisInstance; > wincl.lpszClassName = szClassName; > wincl.lpfnWndProc = WindowProcedure; /* This function is called by windows */ > wincl.style = CS_DBLCLKS; /* Catch double-clicks */ > wincl.cbSize = sizeof (WNDCLASSEX); > > /* Use default icon and mouse-pointer */ > wincl.hIcon = LoadIcon (NULL, IDI_APPLICATION); > wincl.hIconSm = LoadIcon (NULL, IDI_APPLICATION); > wincl.hCursor = LoadCursor (NULL, IDC_ARROW); > wincl.lpszMenuName = NULL; /* No menu */ > wincl.cbClsExtra = 0; /* No extra bytes after the window class */ > wincl.cbWndExtra = 0; /* structure or the window instance */ > /* Use Windows's default color as the background of the window */ > wincl.hbrBackground = (HBRUSH) COLOR_BACKGROUND; > > /* Register the window class, and if it fails quit the program */ > if (!RegisterClassEx (&wincl)) > return 0; > > /* The class is registered, let's create the program*/ > hwnd = CreateWindowEx ( > 0, /* Extended possibilites for variation */ > szClassName, /* Classname */ > "Windows App", /* Title Text */ > WS_OVERLAPPEDWINDOW, /* default window */ > CW_USEDEFAULT, /* Windows decides the position */ > CW_USEDEFAULT, /* where the window ends up on the screen */ > 544, /* The programs width */ > 375, /* and height in pixels */ > HWND_DESKTOP, /* The window is a child-window to desktop */ > NULL, /* No menu */ > hThisInstance, /* Program Instance handler */ > NULL /* No Window Creation data */ > ); > > > /* Make the window visible on the screen */ > ShowWindow (hwnd, nFunsterStil); > PrintBmp(hwnd, "BOARD.bmp"); > /* Run the message loop. It will run until GetMessage() returns 0 */ > while (GetMessage (&messages, NULL, 0, 0)) > { > /* Translate virtual-key messages into character messages */ > TranslateMessage(&messages); > /* Send message to WindowProcedure */ > DispatchMessage(&messages); > } > > /* The program return-value is 0 - The value that PostQuitMessage() gave */ > return messages.wParam; > } > > > /* This function is called by the Windows function DispatchMessage() */ > > LRESULT CALLBACK > WindowProcedure (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam) > { > switch (message) /* handle the messages */ > { > case WM_DESTROY: > PostQuitMessage (0); /* send a WM_QUIT to the message queue */ > break; > default: /* for messages that we don't deal with */ > return DefWindowProc (hwnd, message, wParam, lParam); > } > > return 0; > }

3 4

RFC: Use editline in winedbg
by Jeremy White Dec. 5, 2004

Dec. 5, 2004

Hi folks, The attached patch dynamically detects and uses the BSD licensed editline library (a pretty close replacement for readline), if it's available. This gives winedbg command line recall. This gets around readline's license requirements. I'm nervous because I wasn't sure if that was the only issue with readline, or if there were further issues. Wack me with a clue bat if this is wrong, otw, I'll submit it. Cheers, Jeremy

5 6

Re: Janitorial: WinMM conversion of 32 bit low level drivers to Unicode interface
by Steven Edwards Dec. 5, 2004

Dec. 5, 2004

--- Eric Pouech <pouech-eric(a)wanadoo.fr> wrote: > This patch is based on work by Filip Navara from ReactOS. > He did the Winmm part (+wave & midi mapper), I did the rest (+ 16 message mapping) > A+ Eric I just want you to know you are my personal hero. Someday they will write songs about you that I will listen to under ReactOS <g>. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Re: Fix for winedbg; disassemble range was flawed
by Jeremy White Dec. 5, 2004

Dec. 5, 2004

This updated version prevents an infinite loop in the (currently impossible) case of a poorly specified disassembly range. Truth is, this functions interface is a bit awkward. Jeremy White wrote: > Changelog: > Properly respect a disassemble x,y command > (prior behavior would do y-x instructions, no matter > how wide each instruction was) > > > ------------------------------------------------------------------------ > > Index: programs/winedbg/debugger.h > =================================================================== > RCS file: /cvstrees/crossover/office/wine/programs/winedbg/debugger.h,v > retrieving revision 1.17 > diff -u -r1.17 debugger.h > --- programs/winedbg/debugger.h 28 Nov 2004 16:23:50 -0000 1.17 > +++ programs/winedbg/debugger.h 5 Dec 2004 04:30:24 -0000 > @@ -317,7 +317,7 @@ > extern BOOL memory_get_current_frame(ADDRESS* address); > extern BOOL memory_get_string(HANDLE hp, void* addr, BOOL in_debuggee, BOOL unicode, char* buffer, int size); > extern BOOL memory_get_string_indirect(HANDLE hp, void* addr, BOOL unicode, char* buffer, int size); > -extern void memory_disassemble(const struct dbg_lvalue*, const struct dbg_lvalue*, int offset); > +extern void memory_disassemble(const struct dbg_lvalue*, const struct dbg_lvalue*, int instruction_count); > extern BOOL memory_disasm_one_insn(ADDRESS* addr); > extern void print_bare_address(const ADDRESS* addr); > extern void print_address(const ADDRESS* addr, BOOLEAN with_line); > Index: programs/winedbg/memory.c > =================================================================== > RCS file: /cvstrees/crossover/office/wine/programs/winedbg/memory.c,v > retrieving revision 1.1.1.13 > diff -u -r1.1.1.13 memory.c > --- programs/winedbg/memory.c 28 Nov 2004 15:36:39 -0000 1.1.1.13 > +++ programs/winedbg/memory.c 5 Dec 2004 04:30:24 -0000 > @@ -598,9 +598,11 @@ > } > > void memory_disassemble(const struct dbg_lvalue* xstart, > - const struct dbg_lvalue* xend, int offset) > + const struct dbg_lvalue* xend, int instruction_count) > { > static ADDRESS last = {0,0,0}; > + int stop = 0; > + int i; > > if (!xstart && !xend) > { > @@ -613,7 +615,10 @@ > last.Mode = AddrModeFlat; > last.Offset = types_extract_as_integer(xstart); > } > - if (xend) offset = types_extract_as_integer(xend) - last.Offset + 1; > + if (xend) > + stop = types_extract_as_integer(xend); > } > - while (offset-- > 0 && memory_disasm_one_insn(&last)); > + for (i = 0; (instruction_count == 0 || i < instruction_count) && > + (stop == 0 || last.Offset <= stop); i++) > + memory_disasm_one_insn(&last); > }

1 0

Re: COMCTL32: Minor corrections
by Robert Shearman Dec. 5, 2004

Dec. 5, 2004

Filip Navara wrote: > Changelog: > - Tooltip icons must be destroyed with DestroyIcon and not with > DeleteObject. > - Don't use DrawEdge with NULL device context, it's invalid call and > sets last error. > >------------------------------------------------------------------------ > >Index: lib/comctl32/datetime.c >=================================================================== >RCS file: /CVS/ReactOS/reactos/lib/comctl32/datetime.c,v >retrieving revision 1.5 >diff -u -r1.5 datetime.c >--- lib/comctl32/datetime.c 19 Sep 2004 09:50:06 -0000 1.5 >+++ lib/comctl32/datetime.c 4 Dec 2004 22:59:42 -0000 >@@ -1170,10 +1170,10 @@ > > TRACE("Height=%ld, Width=%ld\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); > >- /* use DrawEdge to adjust the size of rcEdge to get rcDraw */ > memcpy((&infoPtr->rcDraw), (&infoPtr->rcClient), sizeof(infoPtr->rcDraw)); > >- DrawEdge(NULL, &(infoPtr->rcDraw), EDGE_SUNKEN, BF_RECT | BF_ADJUST); >+ /* subract the size of the edge drawn by DrawEdge */ >+ InflateRect(&infoPtr->rcDraw, -2, -2); > > Please use GetSystemMetrics(SM_CXEDGE) and GetSystemMetrics(SM_CYEDGE). > > /* set the size of the button that drops the calendar down */ > /* FIXME: account for style that allows button on left side */ >Index: lib/comctl32/tooltips.c >=================================================================== >RCS file: /CVS/ReactOS/reactos/lib/comctl32/tooltips.c,v >retrieving revision 1.9 >diff -u -r1.9 tooltips.c >--- lib/comctl32/tooltips.c 20 Oct 2004 08:36:55 -0000 1.9 >+++ lib/comctl32/tooltips.c 4 Dec 2004 23:18:56 -0000 >@@ -2818,7 +2818,7 @@ > TOOLTIPS_Unregister (void) > { > int i; >- for (i = 0; i < TTI_ERROR+1; i++) >- DeleteObject(hTooltipIcons[i]); >+ for (i = TTI_INFO; i <= TTI_ERROR; i++) >+ DestroyIcon(hTooltipIcons[i]); > UnregisterClassW (TOOLTIPS_CLASSW, NULL); > } > > Someone already sent a patch for this (and it is my buggy code, sorry). Not sure why it didn't go in, but it should. Rob

3 2

Re: implement DllCanUnloadNow for dmusic
by Robert Shearman Dec. 4, 2004

Dec. 4, 2004

James Hawkins wrote: >Changelog > * properly implement DllCanUnloadNow ref counting > > > Sorry, still isn't correct. Please see my comments below. >------------------------------------------------------------------------ > >Index: dlls/dmusic/buffer.c >=================================================================== >RCS file: /home/wine/wine/dlls/dmusic/buffer.c,v >retrieving revision 1.8 >diff -u -r1.8 buffer.c >--- dlls/dmusic/buffer.c 6 Sep 2004 21:34:25 -0000 1.8 >+++ dlls/dmusic/buffer.c 4 Dec 2004 20:52:16 -0000 >@@ -38,6 +38,9 @@ > ULONG WINAPI IDirectMusicBufferImpl_AddRef (LPDIRECTMUSICBUFFER iface) { > IDirectMusicBufferImpl *This = (IDirectMusicBufferImpl *)iface; > TRACE("(%p): AddRef from %ld\n", This, This->ref); >+ >+ DMUSIC_LockModule(); >+ > return ++(This->ref); > } > >@@ -45,9 +48,13 @@ > IDirectMusicBufferImpl *This = (IDirectMusicBufferImpl *)iface; > ULONG ref = --This->ref; > TRACE("(%p): ReleaseRef to %ld\n", This, This->ref); >+ > if (ref == 0) { > HeapFree(GetProcessHeap(), 0, This); > } >+ >+ DMUSIC_UnlockModule(); >+ > return ref; > } > >@@ -160,6 +167,8 @@ > } > dmbuff->lpVtbl = &DirectMusicBuffer_Vtbl; > dmbuff->ref = 0; /* will be inited by QueryInterface */ >+ >+ DMUSIC_LockModule(); > > return IDirectMusicBufferImpl_QueryInterface ((LPDIRECTMUSICBUFFER)dmbuff, lpcGUID, ppobj); > } > > Ok, think about this sequence of events that should leave the DLL ref count at 0: 1. Create an IDirectMusicBufferImpl object. 1a. Calls LockModule. 1b. Calls QueryInterface which calls LockModule. 2. Call Release, which calls LockModule. The solution is to either remove the LockModule from the constructor, or to remove the LockModule from the AddRef and only call UnlockModule in the destructor part of Release. This issue is also present in the other files in your patch (not quoted here). I should have thought about this before when I commented on your last patch. I guess I need to put some tests together for this feature. Rob

2 2

DInput has been broken for about 6 months now
by Scott Ritchie Dec. 4, 2004

Dec. 4, 2004

Well, one of my favorite games, Fallout 2, didn't work when I tried it. This is strange though, as it was working about 3 years ago. Looking through the AppDB page, http://appdb.winehq.org/appview.php?appId=194&versionId=319 - it looks like it's been broken since June. Specifically, here's the symptoms: "DXGRAB" = "Y" will cause the app to completely takeover and lockup the system, except no input into the app (mouse or keyboard) works. I have to ctrl-alt-f2 and killall -9 wine-preloader to get back to work. Turning off DXGRAB causes the app to respond to keyboard input, but the mouse still doesn't work. Some very strange things happened in gnome when I brought my email window in front of the app (the mouse would skip from the edge of the gnome window past the app, making it impossible to click on, and other wierdness. However, none of this translated into the in-game cursor moving) I'm running the app in Desktop=640x480 mode. Furthermore, it appears that some of the old problems listed in the AppsDB page are still there - the game is very slow at certain points (well, the loading and unloading I can do with the keyboard...), and I'm running a computer roughly 10 times as fast as was designed for the game. After asking about on the channel a bit, the finger was pointed at DINPUT. I think some of the problems with DINPUT would make a fairly good candidate for something to tackle on Sunday, although doing a >6 month regression test could be annoying. I personally know about 3 people I could get to switch to Wine entirely if we could get this working :) I haven't filed a bugzilla report yet, but if it helps I will. Thoughts? -Scott Ritchie

1 0

Re: New Canadian keyboard layout
by Dmitry Timoshkov Dec. 4, 2004

Dec. 4, 2004

"Jean-Michel Dault" <jmdault(a)revolutionlinux.com> wrote: > I'm doing a pilot project for the Quebec government, and we have one > major problem: they have a keyboard layout that's unsupported by Wine, > though it was commited to XFree about 3 years ago. What do you mean by "unsupported by Wine", is that just a warning that you see? What exactly doesn't work without this patch? -- Dmitry.

4 4

Making the Documentation into help files
by Scott Ritchie Dec. 4, 2004

Dec. 4, 2004

While making the Debian package, I had to do a special hack to compile wine's documentation because it's made seperately. This isn't a really big deal, but what I did realize is that Wine's documentation doesn't get installed to the help menu now coming standard on systems. When I select Applications->Help from the menu in Ubuntu, there's a whole list of documentation for available installed applications. I managed to get the install script to copy txt versions of the stuff in the documentation folder to the standard /usr/share/doc/wine, but this place remains bereft of wine documentation. So, how is this done? I presume there's a freedesktop.org standard for these things, as both Gnome and KDE have them in the same way, but currently we're not converting the documentation sgml files into these help files. Coincidentally, this might tie in very well to the desktop integration tasks suggested this week. Perhaps we should create a desktop integration tasklist or even append it onto the 1.0 todo? Trying to further improve usability, Scott Ritchie

3 2

Wine book
by Brian Vincent Dec. 4, 2004

Dec. 4, 2004

Just wanted to give everyone a heads up.. I followed up with Jeremy's email a few months ago about a publisher wanting to put together a book on Wine. Yep, I have no life and 400 pages can't be that hard to write. Well, we started the ball rolling and now it looks like it's going to happen. I should be signing the contract in a few days. There's lots of details I thought you guys might be interested in. You'll find the chapter outlines[1] at the bottom of this email. This book is oriented at users and Winelib developers. It's not a book about how to hack Wine internals. One thing I'll try to keep in mind as I'm writing is how to entice people to get involved with development. I think it's important to try to get people involved in the community. I'm not going to be writing this alone. Ira Krakow, a Boston native, will be writing the Winelib parts. I didn't feel comfortable doing those and Ira had approached the publisher separately about doing a book on porting Windows apps. We've chatted a few times and I'm confident that given his experience he'll do well. I'm cc:ing him on this email by way of introduction and I'm sure at some point in the future he'll have a question or two (or 50.) The publisher is Prentice-Hall. Thus far they've been excellent to work with and they really seem to just "get it" when it comes to open source projects. Specifically, this book will fall into their Bruce Perens' Open Source Series [2]. After the book is published, it will be available for a short time only in a dead tree version. After a few months it will be available under the Open Publication License [3]. It's a good license and contains many things I think are important. Also, I'd like to thank everyone who reviewed the initial proposal. That process happened really fast and I wasn't even aware it had been sent out for review until after you guys got the emails. There was lots of good feedback in there and I incorporated a lot of it in the final proposal that got approved (you may even notice some changes in the chapters below as a result.) Some other things you guys mentioned aren't specifically in this chapter outline, but I made some notes as to what needs to be addressed. Thanks again. Anyone who didn't see that proposal, you didn't miss much. It was lots of marketspeak. The key is the chapter outline below, so if you have any comments about what I'm overlooking, _please_ let me know. [1] Chapter outlines: Title: "Wine: Running Windows Applications on Linux" [4] 1. Wine Introduction[15 pages] What is Wine? How Can Wine Help You? An Introduction to Windows Components Overview of Wine's Components Recent Changes to Wine A History of the Wine Project How Can You Get Wine? 2. Installing Wine [20 pages] System Requirements Bundled Versions Downloading Packaged Versions Accessing CVS Compiling and Installing Wine Uninstalling Wine 3. Configuring Wine [35 pages] Introduction to Winecfg Windows Versions Libraries: Native vs. Builtin Application Settings Drive Configuration Serial and Parallel Ports Network Shares Fonts Printing Database Access 4. Installing Applications [35 pages] Basic Installation Common Installation Pitfalls Resources to Help With Installation Adding Native Libraries Installing Games Copy Protection Pitfalls Using Native DirectX 5. Installing Common Programs [35 pages] Microsoft Office Adobe Photoshop File Utilities Peer-to-Peer Applications Further Help: The Wine Application Database 6. Linux, Wine, and Windows Integration [40 pages] Integrating with Desktop Environments KDE and GNOME Integration Wine Tools Introduction Wineshelllink Wineprefixcreate Regedit Understanding the Wine Registry Changing the Registry Importing an Existing Registry Using an Existing Windows Partition 7. Enterprise Deployment [30 pages] Licensing Considerations Understanding Windows and Wine Security Automating Deployment of Applications Scripting Wine Citrix Killer: Wine and the Linux Terminal Server Project Performance Tweaks Reporting Bugs and Working with Developers 8. Commercial Alternatives: CodeWeaver's CrossOver Office [25 pages] Introduction to CrossOver Office Downloading and Installing CrossOver Configuring CrossOver Installing Applications with CrossOver 9. Commercial Alternatives: TransGaming's Cedega [25 pages] Introduction to Cedega Downloading and Installing Cedega Configuring Cedega Installing Games with Cedega 10. Introduction to Winelib [20 pages] Introduction to Winelib Licensing Considerations Portability Considerations Getting Started Understanding the Winelib toolkit A Roadmap for Porting Installation of the MinGW Compiler 11. Using Winelib for Porting [45 pages] Installation of the MinGW compiler Moving From Visual Studio to MinGW Tips and Tricks for Changing Compilers Moving Development to Linux Using Winemaker Using the Wine Resource Compiler Using the Wine Message Compiler Linking it Together: winegcc Debugging with the Wine debugger 12. Case Study: Porting a To-Be-Determined Application [30 pages] 13. Advanced Porting Techniques [25 pages] C++ Problems Working with Microsoft Foundation Classes Working with Templates Moving From Visual Studio to MinGW 14. dvanced Library Techniques [20 pages] Getting Started: Why Share Libraries? Using Linux Libraries with Winelib Applications Using Windows Libraries with Winelib Applications Why Wine is not a Shared Library [2] Peren's Open Source Series info: http://phptr.com/promotion/1484?redir=1 [3] OPL license: http://www.opencontent.org/openpub/ a good discussion of it: http://lwn.net/Articles/108250/ [4] With regards to the title, I'll be sure to mention in Wine runs on other operating systems. PS. This still leaves the door open for someone to write an O'Reilly book. PPS. I'd like to think this won't affect WWN because I really have no life. However, that's not too realistic. Hopefully WWN won't suffer too much. - Brian Vincent

7 9

Re: [resend] shell32 tests
by Rolf Kalbermatter Dec. 4, 2004

Dec. 4, 2004

>+static HMODULE hshell32; >+static int (WINAPI *pSHCreateDirectoryExA)(HWND, LPCSTR, LPSECURITY_ATTRIBUTES); >+ >+static void InitFunctionPointers(void) >+{ >+ hshell32 = GetModuleHandleA("shell32.dll"); >+ >+ if(hshell32) >+ pSHCreateDirectoryExA = (void*)GetProcAddress(hshell32, "SHCreateDirectoryExA"); >+} >+ > /* creates a file with the specified name for tests */ > void createTestFile(CHAR *name) > { >@@ -398,17 +409,19 @@ > int ret; > > set_curr_dir_path(path, "testdir2\\test4.txt\0"); >- ret = SHCreateDirectoryExA(NULL, path, NULL); >+ ret = pSHCreateDirectoryExA(NULL, path, NULL); I think this is not right. Implementing dynamic loading of functions in tests is supposedly because that function may not be available on some systems. But here you invoke the (maybe uninitialized, or NULL assigned) function pointer nevertheless without protecting for this. As such your patch does only allow loading the test on such systems but will create a nice crash when run. Rolf Kalbermatter

1 0

2nd attemp at DllCanUnloadNow
by James Hawkins Dec. 3, 2004

Dec. 3, 2004

This time I respect heap-based objects, leaving there internal ref counts and respective HeapFree's. I also took Alexandre's suggestions and changed Un/LockServer to DMCOMPOS_LockServer etc and change cLocks to refCount. Let me know if this is any closer to what it needs to be. Thanks. -- James Hawkins

2 1

Re: Wine book
by Ivan Leo Puoti Dec. 3, 2004

Dec. 3, 2004

> The 'high level' parts (like d3drm) should work too, No program or sdk sample I know of and uses this dll currently works on wine. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Register IME class at startup?
by Ivan Leo Puoti Dec. 3, 2004

Dec. 3, 2004

On windows xp/2k the IME window class appears to be always registered, even if a program doesn't link to nor loads imm32, the class is registered. How should this be handled in wine, should the class be registered at startup? Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: wine-preloader defunct
by James Hawkins Dec. 3, 2004

Dec. 3, 2004

On Thu, 02 Dec 2004 20:01:48 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > I've now got several instances of "[wine-preloader] <defunct>" in my ps > listing from a game server that's died in some strange way. Anyone have > experience in clearing these short of bouncing the whole box? They're > holding onto a couple of TCP ports that I'd like to use. The ports are > stuck in CLOSE_WAIT, because the processes are stuck in memory so the > sockets can't close. > > Does 'kill -9 processnum' not work? -- James Hawkins

6 10

Re: Implement GetLayout
by Shachar Shemesh Dec. 3, 2004

Dec. 3, 2004

Rémi Assailly wrote: > I added some things to my previous patch. > Please tell me if something seems incorrect or is missing > Thanks ;) > > Changelog: > * implement GetLayout Thanks for spotting another one for my growing heap of BiDi TODOs.... http://bugs.winehq.org/show_bug.cgi?id=2584 Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: rsaenh/implglue.c: Added missing break
by Marcus Meissner Dec. 3, 2004

Dec. 3, 2004

On Fri, Dec 03, 2004 at 11:49:22AM +0100, Michael Jung wrote: > Greetings, > Michael > > Changelog: > Added a missing break in encrypt_block_impl > > Index: dlls/rsaenh/implglue.c JFYI, we (Novell) are now working on reapproving WINE for US export due to your cryptographic library import. I will keep you posted, but I expect approval. Actually, in the closest meaning of the export regulations, I am not even allowed to build RPMs for SourceForge anymore here at SUSE/Novell :( Fun without end, I had hoped we keep openssl dynamic linking ;) Ciao, Marcus

2 2

Providing success stories
by Stefan Munz Dec. 3, 2004

Dec. 3, 2004

Hi, I already mailed with some developers a few days ago. Basicly wether and in which way the wine logo can be used to communicate wine compatibility for software producers (this is already solved). For those who didn't read it, i copied a passage of the orig. mail: --- In order to push the use of Open Source Software we plan a project with the "Wirtschaftsförderung Region Stuttgart GmbH" (I don't know whats the equivalent in english but its a public organization that promotes OSS and assists companies that resident in Stuttgart). Within this project we want to find software producers who pay us for a wine compatibility test of their software. --- This project is starting at the moment. I thought a good idea to give something back to the community is to provide some success stories i.e. for use on winehq.com. Is this interesting? If the answer is yes, who is responsible for something of the kind. Regards, Stefan Munz

1 0

Preliminary Darwine SDK Released
by Sanjay Connare Dec. 3, 2004

Dec. 3, 2004

Hello All, I have released a preliminary version of the Darwine SDK version 0.1. Many people are interested in getting Darwine up and running so they can compile programs on OS X and this release should satisfy their curiosity. The SDK features the following: -source code for the current Darwine binary 20040820 -source code for WineHelper -Xcode Integration -Xcode Template -Updated Uninstaller The Xcode integration allows for a user to compile windows source code from within the Xcode IDE using the wine tools. Users may want to note that there are some changes to the way Darwine is installed and functions. Due to limitations in Xcode, the wine source tools such as winegcc, winemaker, winebuild are installed in the /usr/bin directory and not the /Library/Darwine/bin directory. This may be changed in a future release but was necessary so Xcode integration would work correctly. As a result there is an updated uninstaller as well. The uninstaller will remove everything except for the Xcode project template folder, which is moved to the trash and needs to be removed manually. To start a new Darwine project, simply launch Xcode, select new project, and select Darwine (Windows) Application. Currently in Xcode the "Build and Run" does not work, it will build the program but not launch. However, the Build button works as expected. When compiling a Darwine application for the first time Xcode may give the error: "ld: table of contents for archive: /Library/Darwine/lib/wine/lib<name>.a is out of date; rerun ranlib(1) (can't load from it)" Open a terminal and type the following command: "sudo ranlib /Library/Darwine/lib/wine/lib<name>.a" <name> being replaced by the name of the library whose table of contents is out of date. The source code should then compile fine. There are many examples of source in the wine source code "programs" folder which is located in the root of the source directory. Simple programs should compile fine. However, bigger programs that depend on more of the windows headers will probably not compile due to header incompatabitlies between the wine and OS X headers. You can download the preliminary release here http://prdownloads.sourceforge.net/darwine/Darwine_SDK0.1.dmg?download or through the Darwine web site http://darwine.opendarwin.org Post any comments, questions or concerns to the Darwine Mailing List "darwine-devel(a)lists.sourceforge.net" . Remember this is a preliminary release and there are many bugs and issues that need to be worked out and features that need to be implemented. More information will be posted on the Darwine website in the near feature. Last but not least enjoy. Sanjay Connare

1 0

wine-preloader defunct
by Kenneth Porter Dec. 3, 2004

Dec. 3, 2004

I've now got several instances of "[wine-preloader] <defunct>" in my ps listing from a game server that's died in some strange way. Anyone have experience in clearing these short of bouncing the whole box? They're holding onto a couple of TCP ports that I'd like to use. The ports are stuck in CLOSE_WAIT, because the processes are stuck in memory so the sockets can't close.

1 0

Suggestions for fixing test?
by Jakob Eriksson Dec. 3, 2004

Dec. 3, 2004

http://test.winehq.org/data/200412011000/xp_IDWASEMPTY/gdi32:metafile.txt Any suggestions for fixing this? regards, Jakob

2 5

Re: shell32: reduce version to win2k
by Dmitry Timoshkov Dec. 3, 2004

Dec. 3, 2004

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > I hope this removes the IE6 regression. No, it doesn't. It turned out that it's something different that causes a regression, lowering down version of shell32 changes nothing. It seems that a better solution is to add missing images to shell32. We need at least the following bitmaps to make IE display images on toolbars: id 230/231 - they are the same with different brightness, 20x20 1 image id 227/228 - they are the same with different brightness, 24x24 6 images id 204/205 - they are the same with different brightness, 24x24 16 images id 214/215 - they are the same with different brightness, 24x24 47 images id 240 - 22x22 50 vertical images (animated windows logo) -- Dmitry.

1 0

RE: Treeview +/-
by Ge van Geldorp Dec. 2, 2004

Dec. 2, 2004

> From: Jon Griffiths > > >Maybe the height/width at which to switch to the Rectangle drawing > >algorithm needs a bit of tuning? > > Ge, Can you confirm this fixes the size for you? It works for > me if I change my system font to a larger one... Yes, this works for me. Thanks. Ge van Geldorp.

1 0

automatic tests screwed up again
by Ivan Leo Puoti Dec. 2, 2004

Dec. 2, 2004

In the reports page the link to the tests points to http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-200411251000… and this is probably what the server tells winrash to download, but it returns a 404. The test actually is at http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-200411251000… can someone please fix this? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow
by Dmitry Timoshkov Dec. 2, 2004

Dec. 2, 2004

"Robert Shearman" <rob(a)codeweavers.com> wrote: > -DWORD dll_ref = 0; > +LONG cLocks; ... > +/********************************************************************** > + * Dll lifetime tracking declaration > + */ > +void LockModule() > +{ > + InterlockedIncrement(&cLocks); > +} > + > +void UnlockModule() > +{ > + InterlockedDecrement(&cLocks); > +} Perhaps it would be better to prefix both a variable and lock/unlock interfaces with a module name, in this case "DEVENUM_" since they are global and externally visible. -- Dmitry.

4 5

Re: IME window class update
by Ivan Leo Puoti Dec. 2, 2004

Dec. 2, 2004

> You mean 65535, in which case it'd be 0xffff? Nope, just doubled checked and with the value is 65553, or 0x10011. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: IME window class update
by Andreas Mohr Dec. 2, 2004

Dec. 2, 2004

Hi, On Thu, Dec 02, 2004 at 04:38:39PM +0100, Ivan Leo Puoti wrote: > This patch is based on the IME window class implemented in windows 2000 and xp. > On both OSes hCursor is 65553, but I don't know what that is, maybe it's a > custom IME cursor? You mean 65535, in which case it'd be 0xffff? No idea what kind of cursor that is, but it looks like an invalid/unused one... Andreas Mohr

1 0

attemp at implementing DllCanUnload now for dcompos
by James Hawkins Dec. 2, 2004

Dec. 2, 2004

Hey all, It would really help me out if you could look over this patch and see if I've incorrectly implemented ref-counting and DllCanUnloadNow for dcompos. I used suggestions from Rob and a sample implementation written by him. The only concern I have is that I'm not sure if all of these classes are non-heap based. -- James Hawkins

3 3

Re: systray rewrite part 2
by Grant Williamson Dec. 2, 2004

Dec. 2, 2004

Mike, ok the rewrite, applies & compiles cleanly on 20041019, however, running SIP Phone-lite, it does not show on the systray, the older patch did. I am running gnome-2.8 on rhel4, what program do you want us to test with it. Mike Hearn wrote: >Clearly, I need to figure out a system for generating patches. This time >with (hopefully) all the files in the patch. > >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > >------------------------------------------------------------------------ > > > >

2 3

SHBrowseForFolder
by Robert van Herk Dec. 2, 2004

Dec. 2, 2004

Hi all, I am trying to implement the Browse button in the winecfg application, that would allow people to browse for a directory to use as their virtual c drive. In order to do so, I though I'd use the SHBrowseForFolder function from shlobj.h (see http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…) However, when I tried this in Wine, I get a compiler warning: In driveui.c I did: case IDC_BUTTON_BROWSE_PATH: SHBrowseForFolder(0); //MessageBox(dialog, "", "Write me!", MB_OK); break; Then, at compile time I get: driveui.c:589: warning: undefined reference to `SHBrowseForFolderA' I made sure that there is a line that says: #include <shlobj.h> When I try to launch the app, I get ./winecfg wine: could not load L"Z:\\home\\robert\\Documents\\devel\\wine\\programs\\winecfg\\winecfg.exe.so": /home/robert/.wine/dosdevices/z:/home/robert/Documents/devel/wine/programs/winecfg/winecfg.exe.so: undefined symbol: SHBrowseForFolderA Does this mean that the SHBrowseForFolder thing is not implemented? Probably it is, because I checked Wine's shlobj.h. What am I doing wrong? Thanks, Robert

9 33

Re: Implement GetLayout
by Shachar Shemesh Dec. 2, 2004

Dec. 2, 2004

Rémi Assailly wrote: > Shachar Shemesh wrote : > >> Thanks for spotting another one for my growing heap of BiDi TODOs.... >> >> http://bugs.winehq.org/show_bug.cgi?id=2584 >> >> Shachar >> > I know that there is no effect... I'm sorry if I came off cynical. There was no cynicism in that comment. I opened 2584 as a result of seeing your patch. I was not aware of this particular missing functionality. I'm aiming for http://bugs.winehq.org/show_bug.cgi?id=609 to be the ultimate documentation of all BiDi APIs in Windows. Opening 2584 is a good thing, as it documents things that are still to be done. > What is wrong ? It seems that this flag reverses the meaning of several common conventions (left/right etc.). The idea is probably so that applications that are natively right to left not have to change their design too much. I can't tell you exactly what it means, however, as I don't know myself. It will probably be a matter of comparing behaviors to the real Windows. I have some doubts about whether anyone is even using this flag at all. Maybe on localized Hebrew Windows, where the whole window decorations are reversed (Ughh. My GF has localized XP Home installed. This thing is horrible, but I didn't spot any non-Windows native applications that were affected by it). > Tell me and I will help you, if you want... I'll gladly accept all the help I can get. Basically, this particular unimplemented bit requires writing small test programs on Windows, and then running them on Wine until they produce the same results. The idea is that you read the MSDN page for the function (linked from the bug). That page also links to http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/wi…, which gives more details on what this flag is supposed to mean. If you check out 2584 again, you will see I added this new information there. The steps one takes is to read all the relevant manuals, and try to understand what this means. Next, you write a small test program that does stuff with and without this flag, showing where this flag takes effect on Windows. Next, you move this test program to Wine and start tweaking Wine until it behaves the same there. There is also a last step, which is to make this program into a test suite, returning success or failure. I'm not sure, however, how that is supposed to be done for programs where success and failure are measured with graphical output. Hope this helps you help me help everyone..... :-) Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: [OLE #3] Tests For COM Functions
by Dmitry Timoshkov Dec. 2, 2004

Dec. 2, 2004

"Robert Shearman" <rob(a)codeweavers.com> wrote: > I have only tried these tests on WinXP SP2. Please report > if they fail on Win9x. In order compile the tests with Platform SDK I applied the attached patch. Under win2k SP4 I got: marshal.c:898: Test failed: CoGetClassObject should have returned CO_E_SERVER_STOPPING instead of 0x80040154 Under Win95 the tests don't run due to missing APIs CoResumeClassObjects and CoInitializeEx. -- Dmitry.

1 1

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory;
by Rolf Kalbermatter Dec. 1, 2004

Dec. 1, 2004

Robert van Herk wrote: >-LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) >+static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode aBrowseMode) >+{ >+ INT_PTR ret; >+ >+ browseMode = aBrowseMode; ^^^^^^^^^^ I may miss something here but this looks like a global variable and that would make these function theoretically thread unsafe. As long as only winecfg is going to use this functionality for the unix case it seems not a problem as there is probably not any chance that the native Windows version is called at that moment but this may of course change in the future. Rolf Kalbermatter

3 5

MAP_ANON support on HPUX
by Warren_Baird/CSI＠cimmetry.com Dec. 1, 2004

Dec. 1, 2004

Hi All, I've just discovered that HP-UX's mmap implementation doesn't define MAP_ANON, it only defines MAP_ANONYMOUS. linux defined both, as does solaris (and solaris's manpage actually states that MAP_ANON is deprecated), but MacOS X seems to only define MAP_ANON MAP_ANON is only used in two source files: libs/wine/mmap.c and loader/preloader.c. My proposed patch involves slightly different changes in both places : in mmap.c, I just add a new #elif to handle the case, and in preloader.c I add a #ifdef block at the top to define MAP_ANON to be MAP_ANONYMOUS if MAP_ANON is undefined, but MAP_ANONYMOUS is defined. The other possible solution would be to put the #ifdef block from preloader.c into a common header... It's not obvious to me where to put it, though, which is why I'm proposing this patch. Should I rework it to use a common header? If so - any suggestions as to which header would be appropriate? Thanks, Warren

1 0

Bugzilla in CVS
by Jeremy Newman Dec. 1, 2004

Dec. 1, 2004

http://cvs.winehq.org/cvsweb/bugzilla/ I have imported our buzilla into CVS for anyone to start submitting patches on. If I remember correctly, it is a fairly straight branch of version 2.17.4. All I modified was the templates in: /template/en/default/global Enjoy!

2 1

Fwd: Re: Bug Busters
by Peter Hartshorn Dec. 1, 2004

Dec. 1, 2004

May I suggest that the times given are GMT and at least one days notice so everyone who wants to join in can, no matter where they are on the planet. On Wed, 1 Dec 2004 04:10 pm, James Hawkins wrote: > On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <adam(a)nemesys.ca> wrote: > > James Hawkins wrote: > > > I have a totally non-original idea for sessions called Bug Busters > > > where, at a designated time, a group of wine developers would get > > > together on #winehackers (or some other channel). We would pick a bug > > > (or maybe more) from wine's bug tracker and work together to fix the > > > bug(s). This would serve several good purposed. First, we would be > > > giving more attention to wine's bugzilla and getting rid of a lot of > > > those bugs. Second, many newcomers can witness and take part in the > > > wine development process. I'm sure everyone can remember how daunting > > > it is to jump into wine development. Anyway, if anyone has any ideas > > > or would like to take part in this, let me know and we'll get this > > > started. > > > > This is a good idea, same idea as Gentoo Bug Days, and those have been > > extremely successful. > > Awesome, I think it could be really successful with wine too. -------------------------------------------------------

1 0

Re: Resend [AppDB] show total number of maintainers and applications in the appMaintainers table
by Jeremy Newman Dec. 1, 2004

Dec. 1, 2004

This patch fails to apply to the tip. Update and resend. On Sun, 2004-11-21 at 09:50 -0700, Tony Lambregts wrote: > There was a bug in last one, use this instead. > > Change Log: Show the total number of maintainers and applications in the > appMaintainers table in the admin menu > > Files Changed: include/sidebar_admin.php include/util.php > > > Index: include/sidebar_admin.php > =================================================================== > RCS file: /home/wine/appdb/include/sidebar_admin.php,v > retrieving revision 1.4 > diff -u -r1.4 sidebar_admin.php > --- include/sidebar_admin.php 10 Nov 2004 16:36:25 -0000 1.4 > +++ include/sidebar_admin.php 21 Nov 2004 07:50:43 -0000 > @@ -19,7 +19,7 @@ > $g->add("List Users", $apidb_root."admin/"); > $g->add("View App Queue (".getQueuedAppCount().")", $apidb_root."admin/adminAppQueue.php"); > $g->add("View Maintainer Queue (".getQueuedMaintainerCount().")", $apidb_root."admin/adminMaintainerQueue.php"); > - $g->add("View Maintainers", $apidb_root."admin/adminMaintainers.php"); > + $g->add("View Maintainers (".getMaintainerCount().")", $apidb_root."admin/adminMaintainers.php"); > $g->done(); > > } > Index: include/util.php > =================================================================== > RCS file: /home/wine/appdb/include/util.php,v > retrieving revision 1.4 > diff -u -r1.4 util.php > --- include/util.php 9 Nov 2004 22:51:38 -0000 1.4 > +++ include/util.php 21 Nov 2004 07:50:43 -0000 > @@ -189,4 +189,13 @@ > return $ob->queued_maintainers; > } > > +/* get the total number of maintainers and applications in the appMaintainers table */ > +function getMaintainerCount() > +{ > + $qstring = "SELECT count(*) as maintainers FROM appMaintainers"; > + $result = mysql_query($qstring); > + $ob = mysql_fetch_object($result); > + return $ob->maintainers; > +} > + > ?> > > > >

1 0

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does
by pvriens＠xs4all.nl Dec. 1, 2004

Dec. 1, 2004

Hi, just wanted to mention the fact that after this fix, my ZooTycoon demo installs like a charm. It doesn't run yet, but I will look into this and hopefully come up with some answers/patches. I guess several Microsoft Game Installers will work as well now. Good stuff. Cheers, Paul Vriens.

1 0

Re: gdi/mfdrv BS_PATTERN brushes
by Huw D M Davies Dec. 1, 2004

Dec. 1, 2004

On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote: > > This fixes the problem that Emanuele Gisi reported last month in the Aloha > problem. With this patch BS_PATTERN brushes get created correctly and > don't cause a locking problem. > > Changelog: > Fix creation of BS_PATTERN brushes in mfdrv > > > Index: dlls/gdi/mfdrv/objects.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v > retrieving revision 1.14 > diff -u -r1.14 objects.c > --- dlls/gdi/mfdrv/objects.c 22 Nov 2004 18:19:59 -0000 1.14 > +++ dlls/gdi/mfdrv/objects.c 30 Nov 2004 06:10:03 -0000 > - mr->rdFunction = META_DIBCREATEPATTERNBRUSH; > + mr->rdFunction = META_CREATEPATTERNBRUSH; Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record under Windows? Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Bug Busters
by James Hawkins Dec. 1, 2004

Dec. 1, 2004

I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel). We would pick a bug (or maybe more) from wine's bug tracker and work together to fix the bug(s). This would serve several good purposed. First, we would be giving more attention to wine's bugzilla and getting rid of a lot of those bugs. Second, many newcomers can witness and take part in the wine development process. I'm sure everyone can remember how daunting it is to jump into wine development. Anyway, if anyone has any ideas or would like to take part in this, let me know and we'll get this started. -- James Hawkins

7 18

which classes support aggregation?
by James Hawkins Dec. 1, 2004

Dec. 1, 2004

IClassFactory->CreateInstance aggregation check: "The CreateInstance method of IClassFactory takes pUnkOuter as the second member. This parameter must be null unless the class supports aggregation, which many don't." Where can I find out which classes support aggregation? -- James Hawkins

3 2

implementing DllCanUnloadNow questions
by James Hawkins Dec. 1, 2004

Dec. 1, 2004

I sent this message a couple months ago, but I got no response so I'll try again. I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. Is LockServer(TRUE/FALSE) the same as this example? static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { IClassFactoryImpl *This = (IClassFactoryImpl *)iface; FIXME("(%p)->(%d),stub!\n",This,dolock); return S_OK; } If they are the same, what is needed to complete this stub? I would think that there would be a refCount variable that is incremented if dolock is true and decremented if dolock is false. Also, should the LockServer functions be listed in the spec files of the dlls? After implementing LockServer, it should be an easy matter to do a check for refCount == 0 to see if the dll can be unloaded or not. Am I heading in the right direction? -- James Hawkins

3 4

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does
by Robert Shearman Dec. 1, 2004

Dec. 1, 2004

Dmitry Timoshkov wrote: >Hello, > >there is at least one application which crashes in CreateThread due >to a race between a creating thread and a newly created one. The problem >is that the tid address passed to CreateThread resides in the memory >block allocated with VirtualAlloc which gets freed once the newly created >thread starts running, and when CreateThread code attempts to store thread >id it crashes. > >It appears that Windows always creates suspended threads in CreateThread >and a created thread gets resumed later. Here is a snippet of the log >running a simple test program under NT strace (the test app just creates >a thread): > >hThread = CreateThread(NULL, 0, thread_proc, NULL, 0, &tid); >CloseHandle(hThread); > >... >117 796 792 NtCreateThread (0x1f03ff, 0x0, -1, 1243704, 1244568, 1, ... 60, {796, 800}, ) == 0x0 >118 796 792 NtRequestWaitReplyPort (40, {28, 52, new_msg, 0, 2013529912, 2147348480, 902, 2086471576} "\0\0\0\0\1\0\1\0x\1\23\0\320<\23\0<\0\0\0\34\3\0\0 \3\0\0" ... {28, 52, reply, 0, 796, 792, 2138, 0} "\0\0\0\0\1\0\1\0\0\0\0\0\320<\23\0<\0\0\0\34\3\0\0 \3\0\0" ) == 0x0 >119 796 792 NtResumeThread (60, ... 1, ) == 0x0 >120 796 792 NtClose (60, ... ) == 0x0 >... > >Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Always create a suspended thread in CreateThread and resume it > if CREATE_SUSPENDED flag is not set as Windows does. > >--- cvs/hq/wine/dlls/kernel/thread.c 2004-09-22 16:48:59.000000000 +0900 >+++ wine/dlls/kernel/thread.c 2004-12-01 18:04:52.000000000 +0800 >@@ -164,7 +164,7 @@ HANDLE WINAPI CreateRemoteThread( HANDLE > if (flags & STACK_SIZE_PARAM_IS_A_RESERVATION) stack_reserve = stack; > else stack_commit = stack; > >- status = RtlCreateUserThread( hProcess, NULL, (flags & CREATE_SUSPENDED) != 0, >+ status = RtlCreateUserThread( hProcess, NULL, TRUE, > NULL, stack_reserve, stack_commit, > THREAD_Start, info, &handle, &client_id ); > if (status == STATUS_SUCCESS) >@@ -172,6 +172,19 @@ HANDLE WINAPI CreateRemoteThread( HANDLE > if (id) *id = (DWORD)client_id.UniqueThread; > if (sa && (sa->nLength >= sizeof(*sa)) && sa->bInheritHandle) > SetHandleInformation( handle, HANDLE_FLAG_INHERIT, HANDLE_FLAG_INHERIT ); >+ if (!(flags & CREATE_SUSPENDED)) >+ { >+ DWORD ret; >+ >+ status = NtResumeThread( handle, &ret ); >+ if (status) >+ { >+ NtTerminateThread( handle, -1 ); >+ RtlFreeHeap( GetProcessHeap(), 0, info ); >+ SetLastError( RtlNtStatusToDosError(status) ); >+ handle = 0; >+ } >+ } > } > else > > I think you should close the thread handle in the error case, otherwise it will be leaked. Rob

1 0

Debian Packages Almost Ready
by Scott Ritchie Dec. 1, 2004

Dec. 1, 2004

Debian packages are almost done. I have them up for testing. Add the following to /etc/apt/sources.list deb http://tuzakey.com/~scott/ binary/ deb-src http://tuzakey.com/~scott/ source/ My friend's webserver can't handle the huge bandwidth permanent hosting of packages like this will require, so if there's a way we could put them up on winehq it would be nice. I'd like to have an apt repository here, so installing the latest debian wine package would be as simple as adding something like the above line to sources.list and then doing things as normal. What would be ideal, of course, is if the package could be included in the Debian distribution itself. I've yet to hear back from Ove (the current maintainer of the package), and unless he's disappeared entirely there's really nothing that can be done until he decides to update the package or orphan it, as Debian maintainers have total control over their packages. Ubuntu is a different matter, however, and I may be able to get an Ubuntu version included much quicker. If you're a Debian/Ubuntu user, test out the packages and tell me if I left anything out. Thanks, Scott Ritchie

1 0

Small WinMM janitorial project
by Steven Edwards Dec. 1, 2004

Dec. 1, 2004

Hi, With this patch it is possible to use a few Windows sound drivers under ReactOS but I have only submitted patches for one small part of this because its going to require a bit of rework of the existing WinMM code. This should fix 2 of the existing W->A CrossCall issues # dlls/winmm/winmm.c: winmm: waveInGetDevCapsW: illegal call to waveInGetDevCapsA # dlls/winmm/winmm.c: winmm: waveOutGetDevCapsW: illegal call to waveOutGetDevCapsA but before it can be merged we have to rewrite the Wine drivers to accept Unicode. I am planing on adding this as a subproject to the Janitorial page. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0