December 2004 - Wine-Devel - list.winehq.org

ownerdraw paint recursion in listbox
by Alexander Yaworsky Aug. 4, 2005

Aug. 4, 2005

Hello, recently i tried to install some application and it hung when i tried to select options. It uses listbox with ownerdraw items with checkboxes. When listbox is initially painted everything is ok. But when i try to select other item, an extra WM_PAINT is sent to listbox when application draws item. This causes infinite recursion. I've been implemented a simple workaround adding boolean to listbox structure but i have doubts. I briefly looked at some other controls and had not noticed similar countermeasures. Have somebody ever seen such behaviour? It would be interesting to test other controls sending WM_PAINT from ownerdraw handler but i'm short of time to do it soon. Should this workaround implemented in this way or something is wrong deeper with WM_PAINT handling? Thanks.

2 7

rpcrt4.dll NdrGetUserMarshalInfo() problem
by J. Grant July 2, 2005

July 2, 2005

Hello, I am getting the attached error when running an install of Overnet v0.52. Basically it cannot find NdrGetUserMarshalInfo(), despite it being in the dll at entry point: 77d43452h, order 199. Any ideas what this problem could be? I'm expecting this to be the symptom of some wider problem. Any help appreciated. Kind regards JG p.s. Is there any way to get these mangled function names to be displayed un-mangled please? c:\opt\overnet_0_52>overnet c:\opt\overnet_0_52>err:module:import_dll No implementation for MSVCRT.dll.??_U(a)YAPAXI@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V(a)YAXPAX@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

3 3

lotus notes regression
by Paul R Streitman June 25, 2005

June 25, 2005

Patch 14725, applied 2004/12/07 11:31:53, breaks lotus notes. The symptom is a hang with the CPU at 100%, and it happens immediately if you try to click on a notes 'bookmark', or shortly after you try to do much of anything else if you try to avoid the 'bookmarks'. Sorry that it took me so long to report this, when I decided that it wasn't just a temporary instability I eventually had to iteratively compile (many) CVS snapshots to narrow down when the problem was introduced because I found it impossible to untangle the various patches that went in around that time frame. I also ran afoul of the jack problems near the end. I do not know how to narrow the problem down further. I tried running winedbg (at CVS level a couple of days ago), and that seems to be broken too -- it wanted to run things from the wine build tree? There are no unusual console messages or anything when the problem happens. Thanks, Paul z/OS core components development Internet: prs(a)us.ibm.com

7 8

Support for IDvdInfo2::GetDiscID
by James Courtier-Dutton March 25, 2005

March 25, 2005

The Windows api method uses the function call IDvdInfo2::GetDiscID http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… This returns a unique 64bit ID for a DVD. Has anyone found out what exactly it does to create this 64bit ID. It would be nice to get linux DVD players to be able to use the same method. Cheers James

2 2

Re: edit control
by Robert Shearman March 9, 2005

March 9, 2005

Ulrich Czekalla wrote: >Running some tests under WinXP I noticed that if the edit control doesn't >have WS_EX_CLIENTEDGE it looses the WS_BORDER style and it handles painting >the border. This also has the side effect that it's non-client area goes to >zero. > >ChangeLog: > Ulrich Czekalla <ulrich(a)codeweavers.com> > Handle painting the border if WS_EX_CLIENTEDGE is not set > > This changelog doesn't really seem to match the patch. Are you sure it's right? >------------------------------------------------------------------------ > >Index: dlls/user/edit.c >=================================================================== >RCS file: /home/wine/wine/dlls/user/edit.c,v >retrieving revision 1.2 >diff -u -r1.2 edit.c >--- dlls/user/edit.c 9 Sep 2004 19:18:40 -0000 1.2 >+++ dlls/user/edit.c 15 Sep 2004 16:30:50 -0000 >@@ -4423,13 +4423,18 @@ > /* > * In Win95 look and feel, the WS_BORDER style is replaced by the > * WS_EX_CLIENTEDGE style for the edit control. This gives the edit >- * control a non client area. Not always. This coordinates in some >- * way with the window creation code in dialog.c When making >- * modifications please ensure that the code still works for edit >- * controls created directly with style 0x50800000, exStyle 0 ( >- * which should have a single pixel border) >+ * control a nonclient area so we don't need to draw the border. >+ * If WS_BORDER without WS_EX_CLIENTEDGE is specified we shouldn't have >+ * a nonclient area and we should handle painting the border ourselves. >+ * >+ * When making modifications please ensure that the code still works >+ * for edit controls created directly with style 0x50800000, exStyle 0 >+ * (which should have a single pixel border) > */ >- es->style &= ~WS_BORDER; >+ if (lpcs->dwExStyle & WS_EX_CLIENTEDGE) >+ es->style &= ~WS_BORDER; >+ else if (es->style & WS_BORDER) >+ SetWindowLongW(hwnd, GWL_STYLE, es->style & ~WS_BORDER); > > This doesn't seem right at all. The new code should be exactly the same as the old, barring any side effects from SetWindowLong (which shouldn't affect the control anyway since this the function changed is the handler for WM_NCCREATE). Rob

3 3

text edit box not painting text ( on form startup )
by Doug Herbert March 9, 2005

March 9, 2005

( I have posted a similiar question in wine-users, don't flame me for doing so, just thinking about this some more, perhaps it may be more a developer question ) Ok, I have a windows app, that runs under wine fine - not quite. This app has a form, with many text field edit boxes on. Quite often these edit boxes already have text values, ie. they are not empty - there is a database behind the form. Anyway, the form shows on the screen, but the text within the edit fields is invisible, until you activate each edit box component. When you leave one edit box to the next, the text remains visible. It seems like the repainting is not working, on initial startup of the form. As a way to debug this database app ( I don't have the source code for it ) I wrote a real basic form app in Visual Studio, with two edit boxes, with data in each. Now this basic app shows the text values immediately on startup. So there must be something different that the database app is not doing. I then ran wine using 'wine --debugmsg +edit programname' for both app's. I see both logging 'Creating ANSI edit control, style = xxxxx' but the style reference is different between apps - I am not sure if this the cause or not. The problem app reports style = 54011104 and the basic app shows style = 50010080. Can somebody explain what this style reference means and how do I force an app to use a certain style of edit box ? What other wine class debugmsg types should I use to narrow down the source of this problem ? Is there anyway I can check to see how the database app is repainting text within the text edit components ? Regards Doug Herbert. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

3 4

Re: ptrace single-stepping change breaks Wine
by Eric Pouech Jan. 29, 2005

Jan. 29, 2005

> Btw, does wine ever _use_ PTRACE_SINGLESTEP for any of the things it does? > > If it does, then that woulc certainly explain why my "fix" made no > difference: my fix _only_ handles the case where the ptracer never > actually asks for single-stepping, and single-stepping was started > entirely by the program being run (ie by setting TF in eflags from within > the program itself). > > But if wine ends up using PTRACE_SINGESTEP because wine actually wants to > single-step over some instructions, then the kernel will set the PT_DTRACE > bit, and start tracing through signal handlers too. The way Wine doesn't > want.. wine mixes both approches, we have (to control what's generated inside the various exception) to ptrace from our NT-kernel-like process (the ptracer) to get the context of the exception. Restart from the ptracer is done with PTRACE_SINGLESTEP. (BTW: I also CC:ed wine-devel ML, that might be of interest to them too) A+

14 85

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]
by Mike Hearn Jan. 17, 2005

Jan. 17, 2005

>>Well, apparently we don't use sched_yield, so the problem must >>> lie somewhere else. Maybe Con can help us out here? Alexandre says he >>> doesn't know what the issue is either and somebody needs to investigate. I >>> guess we do need to concern ourselves over the details :) > > > Interesting. Probably the most valuable information is that it seems to > work fine if we artificially limit the threads to exactly the same > timeslice _or_ we put them at such a low priority that they are forced > to be guaranteed to round robin one task at a time. This is the way 2.4 > used to work which is why with the new 2.6 schedulers which do far more > out-of-order rescheduling some applications have a problem; particularly > under load. I suspect it's actually the latter issue. Locking between > threads should prevent that being a problem, though. You already > mentioned that you dont use sched_yield() and I couldn't even begin to > look at the wine code myself so perhaps you know something more. Hi Con, One thought that occurred to me, and this is just a random theory, is that maybe the issue is not with the Wine code but the Win32 code run on top of it. Do you know how 2.6 scheduling compares with 2.4 and Windows (NT) scheduling? Could it be that some apps are written to expect Windows-style scheduling and fail to work if they don't get it? In case you hadn't noticed, I'm afraid I only have first-year CS knowledge of scheduling :/ thanks -mike

17 43

Fwd: Foobar2000 audio player Regression
by Nick Hornback Jan. 10, 2005

Jan. 10, 2005

I originally posted this to the -users list, but I was contacted by Robbert Xerox, who had the exact same issue, and thus far nobody has replyed in the users list, so maybe it will get more attention here. > Foobar2000 worked virtually perfectly in the 20041019 > release (aside from some comctrl32 repainting issues > -- which native comctrl32.dll fixed), but in 20041201 > it is completely unuseable. Two major problems: > 1) The toolbars are completely gone. They are sort-of > displayed when they get activity via mouse-press or > whatever, but they do not repaint correctly at all. > See this screenshot for details: > http://img20.exs.cx/my.php?loc=img20&image=w1ifoobar.gif > 2) It takes 100% cpu. In the 20041021 release, it > hovered around 5% cpu (on my athlon 64 3200+), which > was excellent because that beat most native linux > audio players. > The console log is as follows (no errors or warnings): > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,2)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002a,-4,0)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002c,-4,0)-stub! > fixme:win:SetWindowTextA cannot set text "" of other > process window (nil) > Does anyone know what is going on here? I have since found out that if you use a the builtin comctrl32.dll, none of the window repaints at all. In previous wine releases, using the builtin comctrl32.dll would just create minor glitches (ex. the status bar wouldn't update). __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail

4 6

another build problem on current cvs
by Joris Huizer Jan. 9, 2005

Jan. 9, 2005

Hello, For the past week or so, building from cvs on a debian/stable system w/ alsa installed (using a custom kernel Linux debian 2.4.18.041216) breaks on alsa-specific code in wine; I attached the log; note that I did a `cvs update -dPA` and `make distclean` so this can't be any problem with the source I have Any ideas? Maybe you can point me to a place where I can read how to fix this properly (I never worked on alsa-specific code before...) or something like that regards, Joris

4 7

Should we get rid of the wine-license list?
by Scott Ritchie Jan. 3, 2005

Jan. 3, 2005

Looking at the archives it appears that wine-license has had very little traffic, to the point where a lot of it is probably not being read when it comes up, since people like me are not subscribed to that list. It seems like a lot of the stuff being sent there should instead go to wine-devel. Thoughts? Scott Ritchie

7 7

Hyperthreading and SMP
by Kenneth Porter Jan. 3, 2005

Jan. 3, 2005

Does WINE have any problem with either Hyperthreading or SMP? I've found that locking the Tribes Vengeance dedicated server to a single logical CPU seems to give me better performance as the server fills with players. CPU usage seems significantly lower (45% versus 65%). Is this likely to be a WINE issue or a TV issue? (TV is based on the Unreal Tournament engine, with the Havok physics engine integrated to handle vehicle. Alas, unlike UT2004, there's no native Linux server for TV.) More here: <http://lists.matureasskickers.net/pipermail/tvservers/2004-December/000186.…> I want to try disabling HT or setting affinity on my co-admin's Win2003 server to see if he sees the same boost.

2 4

Approving of the WINEprobe initiative
by David Gümbel Jan. 2, 2005

Jan. 2, 2005

Hello everybody, - as my colleague Stefan Munz has already pointed out recently[1] on this list, Wirtschaftsförderung Region Stutgart GmbH (WRS) and us (ITOMIG) are launching an initiative called WINEprobe[2]. Its goal is to make local software vendors aware of the potential bussiness opportunity in a WINE-based port or a WINE/Linux version of their software. WRS is quite committed as far as Open Source is concerned[3], and is pushing OSS in the region since quite a time. It has co-organized, among others, the KDE World Summit 2004 in Ludwigsburg near Stuttgart[4]. The Perlworkshop 6.0 , GUADEC6 (GNOME Conference) [5], ApacheCon Europe and more than 40 other Open Source Events in the Stuttgart Region are organized or supported by the WRS as well. (You can find a description of WRS at the bottom of this mail.) In order to make the WINEprobe initiative beneficial for the WINE project as much as possible, three things are in the making: 1) At the option of the respective software vendor whose product we'll be analyzing for WINE compatibility, Application Database Entries will be maintained by us once a software product has been analyzed for its compatibility with WINE. 2) Reports of successful porting or migration projects will be given back to the community as success stories. My colleage is already working on merging some success stories supplied by third parties (see [6]). 3) WRS has offered to help out in hosting the WINE developers conference Wineconf in 2005 in the Stuttgart area[7]. Mr. Schmid from WRS has asked me (please see the mail below) to provide some information about this initiative to the WINE community. He thinks (and I agree ;) that it would help us a great deal in making the campaign a success if the WINE community somehow "officially" (as official as a community can be :) approved of this initiative. So my question, on behalf of Mr. Schmid, is simply if there are objections against us saying that this initiative is approved of by the WINE community? As an important sidenote, I permit myself to emphasize that all of our above mentioned efforts (1-3) to support the WINE project and its community are fully independent of the answer of this question. Most particularily, the hosting offer stands, and the commitment there won't be lowered if the WINEprobe is not approved of by the community. However, I feel that a successful WINEprobe will be a benefit for the WINE project as well. If there are any questions open, please feel free to ask. Cheers, David ---------- Forwarded Message ---------- Subject: AW: Update on WRS offer & Stuttgart University Date: Montag 20 Dezember 2004 14:46 From: "Hans-Ulrich Schmid" <hans-ulrich.schmid(a)region-stuttgart.de> To: David Gümbel <david.guembel(a)itomig.de> Dear Mr. Gümbel, as you know, ITOMIG and Stuttgart Region is planning to start a new initiative for small and medium software companies called "WINEprobe". "WINEprobe" will help these companies to learn more about the WINE-compatibility of their software products. It would be very helpful, if you can ask the WINE-community to support this new initiative officially. The hosting offer of the Stuttgart Region will not be affected by any way of the decision of the community in the point of supporting the "WINEprobe" or not. Can you please forward this mail to the community and tell them some more about the background of "WINEprobe" Best regards Hans-Ulrich Schmid Wirtschaftsförderung Region Stuttgart GmbH Stuttgart Region Economic Development Corporation FIR_st - Forum IT-Region Stuttgart Friedrichstr. 10 70174 Stuttgart www.first.region-stuttgart.de www.opensource.region-stuttgart.de www.competenzatlas.de www.region-stuttgart.de Tel ++49.711.22835 - 27 Tel mobil ++49.172.7310463 Fax ++49.711.22835 - 55 ------------------------------------------------------- ------------------------------------------------------- WRS description: The Stuttgart Region Economic Development Corporation (WRS) is - founded to provide services to industry and communities in the field of economic development - a subsidiary of the administrative body of the larger Stuttgart Region - provides marketing for the Stuttgart Region - assists in cluster management of specific industries - advises and assists companies during the search for available sites and buildings In the context of our initiative "Open Source Region Stuttgart" http://opensource.region-stuttgart.de the WRS supports conferences and meetings of Open Source projects of various aspects when held in the Stuttgart Region. For example the WRS is co-organizer of the KDE Community World Summit 2004 in Ludwigsburg near Stuttgart http://conference2004.kde.org/ . The Perlworkshop 6.0 , GUADEC6 (GNOME Conference) http://2005.guadec.org/papers.html , ApacheCon Europe and more than 40 other Open Source Events in the Stuttgart Region are organized or supported by the WRS as well. ------------------------------------------------------- [1] http://www.mail-archive.com/wine-devel%40winehq.org/msg11549.html [2] WINEprobe means be something like WINEtasting in english an maybe "degustation de WINE" in french. [3] See http://opensource.region-stuttgart.de/ (.de only, sorry) [4] http://conference2004.kde.org/ [5] http://2005.guadec.org/papers.html [6] http://www.mail-archive.com/wine-devel%40winehq.org/msg11630.html [7] http://www.winehq.org/hypermail/wine-devel/2004/11/0647.html

8 14

Re: Remove heap.h
by Filip Navara Dec. 31, 2004

Dec. 31, 2004

Jon Griffiths wrote: >+ docA.lpszDocName = WtoA( doc->lpszDocName ); >+ docA.lpszOutput = WtoA( doc->lpszOutput ); >+ docA.lpszDatatype = WtoA( doc->lpszDatatype; > Isn't there a missing parenthesis?

1 0

Re: ITSS: DllCanUnloadNow implementation
by Robert Shearman Dec. 31, 2004

Dec. 31, 2004

Jacek Caban wrote: > Changelog: > Implemented DllCanUnloadNow > > BOOL WINAPI ITSS_DllCanUnloadNow(void) > { >- FIXME("\n"); >- >- return FALSE; >+ TRACE("dll_count = %lu\n", dll_count); >+ return !dll_count; > > This function should return an HRESULT, not a BOOL. This error would have been caught if it weren't for the silly ITSS_ prefix. Consequently, the return value should be either S_OK or S_FALSE depending on whether there are no or some remaining references respectively. Rob

1 0

Looking for Software which uses the MS Crypto API
by Michael Jung Dec. 30, 2004

Dec. 30, 2004

Hello, In order to test rsaenh.dll, I'm looking for software, which applies the Microsoft Crypto-API. Any suggestions? It would be ideal, if the source is available. Ciao, Michael

3 3

Re: Remove heap.h
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 07:57:31AM -0800, Jon Griffiths wrote: > Hi, > > After applying, include/heap.h can be removed from cvs. To be honest, I'm not too happy with this patch, HEAP_strdupWtoA was a good marker for code that needed fixing, this patch just makes those places harder to find. -- Dimi.

2 2

Re: Get rid of DPRINTF in x11drv/opengl.c
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:04:23PM +0100, Diego 'Flameeyes' Pettenò wrote: > I had some spare time, and I wanted to do some mostly non-designing code, so I > took the time to look at wine's janitorial projects, and I took a look at the > DPRINTF -> TRACE conversion. > > The attached patch removes DPRINTFs from x11drv/opengl.c (which is the only > file in x11drv which uses them), and replacing the 6 different following > calls with a single call for bits and buffer counters. This is a good project to work on, but the reason it's not done yet it's because it is not a simple replacement of DPRINTF with TRACE. Doing stuff like: + TRACE(" - size / version : %d / %d\n", ppfd->nSize, ppfd->nVersion); + TRACE(" - dwFlags : "); Will not work correctly in a multitreaded environment, where the lines may get intertwinded on output with statements from other threads. The way to do it is to prepare the output in a memory buffer, and output it at once. This can be done with the wine_dbg_sprintf() function. In cases where you need logic to construct the output (like testing for flags, etc), you can do it by first printing to a local buffer, and then printing the content of the buffer to a debug buffer via wine_dbg_sprintf(). A simple example of this technique can be found in the dlls/kernel/locale.c file, in the debugstr_lang() function. -- Dimi. -- Dimi.

2 1

Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation
by Jonathan Gevaryahu Dec. 30, 2004

Dec. 30, 2004

Eric Pouech <pouech-eric(a)wanadoo.fr> wrote: >To: Anish Mistry <mistry.7(a)osu.edu> >Cc: wine-devel(a)winehq.org >Subject: Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total > Annihilation > >and if you remove the entire line (if (!is_version_nt()) access = >TIMER_ALL_ACCESS;)? >A+ > > >--__--__-- > That doesn't fix the problem here. Still the same trace response... I haven't run it enough times to see if it will still occasionally work with that line altered or removed... I know it does work (without any changes from the version in CVS) about 5% of the time. Jonathan Gevaryahu lord_nightmare(a)users.sf.net

6 6

Re: Get rid of DPRINTF in wininet
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:33:52PM +0100, Diego 'Flameeyes' Pettenò wrote: > I hope only my usual karma is not here this time or I'll make everybody lost > time ^^ I'm afraid it is <g>. This is a case where the wine_dbg_sprintf() business is in order. -- Dimi.

2 1

Re: Get rid of DPRINTF in opengl32
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:37:12PM +0100, Diego 'Flameeyes' Pettenò wrote: > Hi, > this time is a very small patch, it simply replace DPRINTF with TRACE without > oher changes. Once again, a job for wine_dbg_sprintf(). -- Dimi.

1 0

Re: Get rid of DPRINTF in winedos
by Dimitrie O. Paun Dec. 30, 2004

Dec. 30, 2004

On Thu, Dec 30, 2004 at 12:22:18PM +0100, Diego 'Flameeyes' Pettenò wrote: > Hi, > The attached patch replaces DPRINTF -> TRACE in winedos dll, joining the near > DPRINTF used to tace dos interrupts. This looks good, but do we still need the explicit 'if (TRACE_ON(relay))'? I think we can use the explicit one from TRACE(), no? -- Dimi.

1 0

NLS/IME functions
by Diego 'Flameeyes' Pettenò Dec. 30, 2004

Dec. 30, 2004

Hi, I'm still trying to figure out how nls/ime functions are placed in windows systems to fix up the patch I sent some days ago. I haven't had the time to find out if YuGiOh calls GetProcAddress (because isn't mine, it's of a friend of mine which is trying to get it working, so I need him to test), so I'm fooling around checking for a way to fix this up. At least Win98's and Win2k's user32.dll have the functions defined into winnls32.h, also if they are defined as compatibility with winnt3. At the moment on wine these functions are commented out also as stubs so they are completely missing. On Windows I'm not able to find a winnls32.dll which is instead present on wine, and seems to define similar functions (but they are quite all spec-stubs, but three functions which are defined (stubbing), without a STUB trace. How should be this done? Implement stub-functions for every nls/ime function? Or simply ignore them for now? Thanks for the time, -- Diego "Flameeyes" Pettenò flameeyes(a)users.berlios.de - http://flameeyes.web.ctonet.it/

1 0

build problem on current cvs
by Stefan Leichter Dec. 29, 2004

Dec. 29, 2004

Hello, i hope you all had nice Christmas. Now back to business :-) trying to build current cvs (~7:45 AM UTC) i get the error: make[1]: Entering directory `/usr/src/wine/wine-build/include' ../tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include -h -H oaidl.h ../../wine/include/oaidl.idl ../../wine/include/wtypes.idl:1: Oops, segment violation make[1]: *** [oaidl.h] Abgebrochen make[1]: *** Datei »oaidl.h« wird gelöscht make[1]: Leaving directory `/usr/src/wine/wine-build/include' make: *** [include] Fehler 2 My system is still SuSE 9.0. I am doing 'out of tree' builds. Bye Stefan

3 7

Re: clean-up
by Eric Blade Dec. 29, 2004

Dec. 29, 2004

My apologies for not responding, I had attempted to sign up for the list, and that had failed. Oops! Now, here I am. :) Paul van Schayck said, about the <<br />> .. oops, that was a mistake in my search/replace.. I thought I had fixed all of those occurences that I made. Also, for the !loggedin() || !have_priv(admin) .. i just copied that code from another module, that had used it in that exact same spot.. the file had a comment that said "// check for admin access here" .. :P no, i don't think it should be !loggedin() && !have_priv(admin) .. that wouldn't make sense, if it were &&.. that needs to be an || . Re: Johnathan Ernst: As I said, I had just copied the code from the other places in the admin/* files that used it. Before I changed that, the code simply said: if(!loggedin()) .. which meant anyone logged in could access that admin function. It does make sense that if not logged in you couldn't have admin privs, so I could change all the files to check that instead. So, my next question.. do you have to have admin priv to be a maintainer? Becauses some of the files check for loggedin, havepriv(admin) and maintainer flags. Should admin/adminCommentView.php be protected? I realise it's in the admin category, but it doesn't look like anyone can get into any mischief with that.. could almost be handy for users. --- anyway, i've fixed those issues, merged it to latest CVS, and will be re-sending it off in just a minute. Thanks :) __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0