December 2004 - Wine-Devel - list.winehq.org

Re: [AppDB] Small appbrowse cleanup
by Chris Morgan Dec. 29, 2004

Dec. 29, 2004

Please, no tabs :-P Chris On Wednesday 29 December 2004 7:10 am, Paul van Schayck wrote: > weird

1 0

Re: [QUARTZ] Some stuff to start the graph
by Robert Shearman Dec. 29, 2004

Dec. 29, 2004

Christian Costa wrote: > Hi, > > Changelog: > Implemented IMediaControl_Run that explores the graph, counts > renderers and starts filters. > Better implementation of IBaseFilter_Run for AVI SPlitter and AVI > Decompressor. > Use the standard memory allocator when an output pin does not provide > any allocator. > Set allocator properties for AVI Decompressor output pin and update > the buffers size at connection time. > > Christian Costa titan.costa(a)wanadoo.fr > >------------------------------------------------------------------------ > >Index: dlls/quartz/avidec.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/avidec.c,v >retrieving revision 1.12 >diff -u -r1.12 avidec.c >--- dlls/quartz/avidec.c 27 Dec 2004 17:15:58 -0000 1.12 >+++ dlls/quartz/avidec.c 29 Dec 2004 09:06:24 -0000 >@@ -235,6 +235,9 @@ > pAVIDec->pBihOut->biCompression = 0; > pAVIDec->pBihOut->biSizeImage = pAVIDec->pBihOut->biWidth * pAVIDec->pBihOut->biHeight * pAVIDec->pBihOut->biBitCount / 8; > >+ /* Update buffer size of media samples in output */ >+ ((OutputPin*)pAVIDec->ppPins[1])->allocProps.cbBuffer = pAVIDec->pBihOut->biSizeImage; >+ > pAVIDec->init = 1; > TRACE("Connection accepted\n"); > return S_OK; >@@ -354,7 +357,13 @@ > > if (SUCCEEDED(hr)) > { >- hr = AVIDec_OutputPin_Construct(&piOutput, NULL, NULL, AVIDec_Output_QueryAccept, &pAVIDec->csFilter, &pAVIDec->ppPins[1]); >+ ALLOCATOR_PROPERTIES props; >+ props.cbAlign = 1; >+ props.cbPrefix = 0; >+ props.cbBuffer = 0; /* Will be updated at connection time */ >+ props.cBuffers = 2; >+ >+ hr = AVIDec_OutputPin_Construct(&piOutput, &props, NULL, AVIDec_Output_QueryAccept, &pAVIDec->csFilter, &pAVIDec->ppPins[1]); > > if (FAILED(hr)) > ERR("Cannot create output pin (%lx)\n", hr); >@@ -502,6 +511,8 @@ > This->state = State_Running; > } > LeaveCriticalSection(&This->csFilter); >+ >+ OutputPin_CommitAllocator((OutputPin *)This->ppPins[1]); > > This needs to be inside the critical section. > > return hr; > } >Index: dlls/quartz/avisplit.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/avisplit.c,v >retrieving revision 1.10 >diff -u -r1.10 avisplit.c >--- dlls/quartz/avisplit.c 27 Dec 2004 17:15:58 -0000 1.10 >+++ dlls/quartz/avisplit.c 29 Dec 2004 09:06:26 -0000 >@@ -327,6 +327,7 @@ > { > HRESULT hr = S_OK; > AVISplitter *This = (AVISplitter *)iface; >+ int i; > > TRACE("(%s)\n", wine_dbgstr_longlong(tStart)); > >@@ -337,6 +338,17 @@ > } > LeaveCriticalSection(&This->csFilter); > >+ hr = PullPin_InitProcessing(This->pInputPin); >+ >+ if (SUCCEEDED(hr)) >+ { >+ for (i = 1; i < This->cStreams + 1; i++) >+ { >+ OutputPin_CommitAllocator((OutputPin *)This->ppPins[i]); >+ } >+ hr = PullPin_StartProcessing(This->pInputPin); >+ } >+ > return hr; > } > > And so does this. ... > /*** IMediaControl methods ***/ > static HRESULT WINAPI Mediacontrol_Run(IMediaControl *iface) { > ICOM_THIS_MULTI(IFilterGraphImpl, IMediaControl_vtbl, iface); >+ int i; >+ IBaseFilter* pfilter; >+ IEnumPins* pEnum; >+ HRESULT hr; >+ IPin* pPin; >+ LONG dummy; >+ PIN_DIRECTION dir; > >- TRACE("(%p/%p)->(): stub !!!\n", This, iface); >+ TRACE("(%p/%p)->()\n", This, iface); > >+ if (This->state == State_Running) >+ return S_OK; >+ >+ /* Explorer the graph from source filters to renderers, determine renderers number and >+ * run filters from renderers to source filters */ >+ This->nRenderers = 0; > ResetEvent(This->hEventCompletion); > >+ for(i = 0; i < This->nFilters; i++) >+ { >+ BOOL source = TRUE; >+ pfilter = This->ppFiltersInGraph[i]; >+ hr = IBaseFilter_EnumPins(pfilter, &pEnum); >+ if (hr != S_OK) >+ { >+ ERR("Enum pins failed %lx\n", hr); >+ continue; >+ } >+ /* Check if it is a source filter */ >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ IPin_QueryDirection(pPin, &dir); >+ if (dir == PINDIR_INPUT) >+ { >+ source = FALSE; >+ break; >+ } >+ } >+ if (source == TRUE) >+ { >+ TRACE("Found a source filter\n"); >+ IEnumPins_Reset(pEnum); >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ /* Explore the graph downstream from this pin */ >+ ExploreGraph(This, pPin, 0); >+ } >+ IBaseFilter_Run(pfilter, 0); >+ } >+ IEnumPins_Release(pEnum); >+ } >+ >+ This->state = State_Running; >+ > return S_FALSE; > } > > And this all needs to be protected by a critical section too. > >@@ -1191,7 +1287,9 @@ > OAFilterState *pfs) { > ICOM_THIS_MULTI(IFilterGraphImpl, IMediaControl_vtbl, iface); > >- TRACE("(%p/%p)->(%ld, %p): stub !!!\n", This, iface, msTimeout, pfs); >+ TRACE("(%p/%p)->(%ld, %p): semi-stub !!!\n", This, iface, msTimeout, pfs); >+ >+ *pfs = This->state; > > > This probably needs protection too. Rob

2 3

Re: [QUARTZ] Some stuff to start the graph (take 2)
by Robert Shearman Dec. 29, 2004

Dec. 29, 2004

Christian Costa wrote: > Hi, > > This time with more thread safety. Looking better, but one more change needed. In addition, most of the code in filtergraph.c isn't thread safe. Thread safety is particularly important in DirectShow where threads are heavily used. Debugging random crashes is not fun. ... > /*** IMediaControl methods ***/ > static HRESULT WINAPI Mediacontrol_Run(IMediaControl *iface) { > ICOM_THIS_MULTI(IFilterGraphImpl, IMediaControl_vtbl, iface); >+ int i; >+ IBaseFilter* pfilter; >+ IEnumPins* pEnum; >+ HRESULT hr; >+ IPin* pPin; >+ LONG dummy; >+ PIN_DIRECTION dir; > >- TRACE("(%p/%p)->(): stub !!!\n", This, iface); >+ TRACE("(%p/%p)->()\n", This, iface); >+ >+ if (This->state == State_Running) >+ return S_OK; > > > This should be inside the critical section, being careful, of course, not to return without calling LeaveCriticalSection. >+ EnterCriticalSection(&This->cs); >+ >+ /* Explorer the graph from source filters to renderers, determine renderers number and >+ * run filters from renderers to source filters */ >+ This->nRenderers = 0; > ResetEvent(This->hEventCompletion); > >+ for(i = 0; i < This->nFilters; i++) >+ { >+ BOOL source = TRUE; >+ pfilter = This->ppFiltersInGraph[i]; >+ hr = IBaseFilter_EnumPins(pfilter, &pEnum); >+ if (hr != S_OK) >+ { >+ ERR("Enum pins failed %lx\n", hr); >+ continue; >+ } >+ /* Check if it is a source filter */ >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ IPin_QueryDirection(pPin, &dir); >+ if (dir == PINDIR_INPUT) >+ { >+ source = FALSE; >+ break; >+ } >+ } >+ if (source == TRUE) >+ { >+ TRACE("Found a source filter\n"); >+ IEnumPins_Reset(pEnum); >+ while(IEnumPins_Next(pEnum, 1, &pPin, &dummy) == S_OK) >+ { >+ /* Explore the graph downstream from this pin */ >+ ExploreGraph(This, pPin, 0); >+ } >+ IBaseFilter_Run(pfilter, 0); >+ } >+ IEnumPins_Release(pEnum); >+ } >+ >+ This->state = State_Running; >+ >+ LeaveCriticalSection(&This->cs); >+ > return S_FALSE; > } > > Rob

2 1

Re: UNICOWS: stub implementations
by Stefan Leichter Dec. 29, 2004

Dec. 29, 2004

Am Dienstag, 28. Dezember 2004 13:16 schrieb Hans Leidekker: > This one removes most remaining spec file stubs from unicows. It depends > on my previous patches to winspool, kernel, user, gdi, rasapi and shell. > > -Hans > > Changelog: > Stub implementations for AddMonitorW, AddPortW, AddPrintProcessorW, > AddPrintProvidorW, AdvancedDocumentPropertiesW, ConfigurePortW, > DeleteMonitorW, DeletePortW, DeletePrinterDriverW,DeletePrintProcessorW, > DeletePrintProvidorW, EnumDateFormatsExW, EnumPortsW, > EnumPrintProcessorDatatypesW, GetAltTabInfoW, GetICMProfileW, GetJobW, > GetLogColorSpaceW, GetPrintProcessorDirectoryW, > RasConnectionNotificationW, RasCreatePhonebookEntryW, RasDeleteSubEntryW, > RasDialW, RasEditPhonebookEntryW, RasGetConnectStatusW, > RasGetEntryDialParamsW RasGetEntryPropertiesW, RasGetErrorStringW, > RasGetProjectionInfoW, RasHangUpW, RasRenameEntryW, RasSetEntryDialParamsW, > RasSetSubEntryPropertiesW, SHGetNewLinkInfoW, SetICMProfileW, > UpdateICMRegKeyW. Hello Hans, you missed to send the implementations of the stubs! Bye Stefan

2 2

Re: Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

I see that the file .wine/user.reg has a line in it that reads "USERPROFILE"="c:\\Windows\\Profiles\\Administrator" but my Windows directory has no Profiles subdirectory in it: mark(a)gandalf Windows $ ls -al total 40 drwxr-xr-x 9 mark users 4096 Dec 28 10:46 . drwxr-xr-x 4 mark users 4096 Dec 28 10:46 .. -rw-r--r-- 1 mark users 0 Dec 28 10:46 .keep drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Desktop drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Favorites drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Fonts drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Inf drwxr-xr-x 2 mark users 4096 Dec 28 10:46 Recent drwxr-xr-x 3 mark users 4096 Dec 28 10:46 Start Menu drwxr-xr-x 2 mark users 4096 Dec 28 10:46 System -rw-r--r-- 1 mark users 481 Dec 28 10:54 win.ini mark(a)gandalf Windows $ Possibly this is part of the problem??? Thanks, Mark On Tue, 28 Dec 2004 14:46:58 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > --On Tuesday, December 28, 2004 2:39 PM -0800 Mark Knecht > <markknecht(a)gmail.com> wrote: > > > I'm guessing this means WIne is compiled on this machine in a way that > > doesn't output debug information? > > > > If so (please let me know) then I'll have to look up how to compile > > to include this output. > > I installed my copy on Fedora Core 2 by building an RPM, and WINE is pretty > chatty, so the default configure options in the RPM spec file must be what > you need. > >

1 0

Re: Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

On Tue, 28 Dec 2004 14:46:58 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > --On Tuesday, December 28, 2004 2:39 PM -0800 Mark Knecht > <markknecht(a)gmail.com> wrote: > > > I'm guessing this means WIne is compiled on this machine in a way that > > doesn't output debug information? > > > > If so (please let me know) then I'll have to look up how to compile > > to include this output. > > I installed my copy on Fedora Core 2 by building an RPM, and WINE is pretty > chatty, so the default configure options in the RPM spec file must be what > you need. > I'm on Gentoo. It sticks in my mind that there is a configure option that turns this on. It's not on by default. I'm doing this on a relative's Gentoo box right now. On my Gentoo system at home I have debugging turned on so I'll wait until I get there in a couple of days and try again with debugging turned on. My though, having poked around a bit, is that there is a registry entry for each user that says whether the user has admin rights. I think that's not turned on, but I don't know if I turn it on whether it will actually work. This is all guessing. Again, Wine is not bombing out at all. I'm just getting a Windows dialog telling me that I need to be an administrator. - Mark

1 0

Re: Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

Kenneth, There are no messages when I run Wine like this: WINEDEBUG=+all wine setup.exe I'm guessing this means WIne is compiled on this machine in a way that doesn't output debug information? If so (please let me know) then I'll have to look up how to compile to include this output. - Mark On Tue, 28 Dec 2004 14:21:32 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > --On Tuesday, December 28, 2004 11:12 AM -0800 Mark Knecht > <markknecht(a)gmail.com> wrote: > > > How can I tell Wine to trick an install program into thinking the user > > has administrator rights under Windows XP? I've switched the windows > > type in the config file to winxp but the install program for Autocad > > 2005 tells me to log in again as an administrator. > > My guess is that it's either unable to write to a system directory or it's > looking for a certain group membership. Try tracing the installer and see > if it's doing something like that. > >

2 1

Windows Admionistrator Rights
by Mark Knecht Dec. 28, 2004

Dec. 28, 2004

Hi - Sorry for cross posting to both winde-devel and wine-users but I need to try and get an answer today on this. I'm at my dad's house and using Wine on his computer. How can I tell Wine to trick an install program into thinking the user has administrator rights under Windows XP? I've switched the windows type in the config file to winxp but the install program for Autocad 2005 tells me to log in again as an administrator. Thanks in advance, Mark

2 1

ptrace + Warcraft 3 issues remain (2.6.10)
by Jesse Allen Dec. 28, 2004

Dec. 28, 2004

Last I reported on Warcraft 3 with the ptrace changes in 2.6.10-rc3 is that it made some improvement, but still doesn't work. I'll will describe in detail what I know now. Since the changes in 2.6.10-rc3, Linus made a very good clean up of ptrace.c and signal.c in arch/i386/kernel. I don't want to necessarily reverse all these changes because they are good changes (ie easier to understand and hack now). So I hacked the kernel to change what is necessary to make the game run again. I have attached the patch against 2.6.10 to show the required changes. Comments on what I have learned about the 3 ptrace changes (see my original report): #1 ptrace.c In set_singlestep() and clear_singlestep(), the flag TIF_SINGLESTEP is now set and cleared. In the header file in include/asm-i386/thread_info.h, it seems to indicate to me that it is an internal flag to remember to re enable single-stepping for a thread on returning to the program. While speaking to my brother on this, we believe that this change was done correctly. But this change alone will break the game. I have looked in both wine for PTRACE_SINGLESTEP to see what it does and in the kernel for TIF_SINGLESTEP. Since set/clear TIF_SINGLESTEP causes the problem, I really need more information on everything about TIF_SINGLESTEP. #2 signal.c - Not single-stepping into signal handlers unless the tracer requests it Previous to 2.6.9-rc2, my understanding is that a call to setup_frame() would clear the trap flag in preparation for a signal delivery. Roland made a slight tweak to it and an example of it is this: if (regs->eflags & TF_MASK) { if (current->ptrace & PT_PTRACED) { ptrace_notify(SIGTRAP); } else { regs->eflags &= ~TF_MASK; } } Linus later changed it to: /* * Clear TF when entering the signal handler, but * notify any tracer that was single-stepping it. * The tracer may want to single-step inside the * handler too. */ if (regs->eflags & TF_MASK) { regs->eflags &= ~TF_MASK; if (current->ptrace & PT_DTRACE) ptrace_notify(SIGTRAP); } In 2.6.10, this new piece of code actually works with Warcraft III. I no longer have to reverse this change. The result is obvious because it makes it so you don't automatically single step into the handler, which wine doesn't really want. #3 signal.c - Clearing the trap flag if being traced by debugger in setup_sigcontext() For some reason, Warcraft III doesn't work if it is cleared here. I have no idea if this TF clear is really necessary. However, everything I've read on this seems to indicate to me that this change is important, so I need to find out what this causes to the game. I captured a log of the seh debug messages because I think this is may be where to look. I also hacked in to display trace messages in wine's dlls/ntdll/signal_i386.c showing eflags and whether TF is cleared in trap_handler() and raise_trap_exception(). I ran the game under 2.6.10 and the modded 2.6.10, to capture the working version, and the failing version. The results are fairly nonrandom and comparable and you can identify differences. Unfortunately, I cannot upload them at the moment because my connection is slow and the files are large. I'll upload it another time. Jesse

1 0

Re: [OLE #16] Comment out an assert, as we don't yet implement IRemUnknown
by Andreas Mohr Dec. 28, 2004

Dec. 28, 2004

Hi, On Tue, Dec 28, 2004 at 03:37:17PM +0000, Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Comment out an assert, as we don't yet implement IRemUnknown > > --- dlls/ole32/stubmanager.c (revision 9) > +++ dlls/ole32/stubmanager.c (local) > @@ -171,8 +175,10 @@ int stub_manager_unref(struct stub_manag > EnterCriticalSection(&m->lock); > if (!list_empty(&m->ifstubs)) > { > - ERR("PANIC: Stub manager is being destroyed with outstanding interface stubs\n"); > - assert( FALSE ); > + ERR("PANIC: Stub manager %s is being destroyed with outstanding interface stubs\n", wine_dbgstr_longlong(m->oid)); > + > + /* assert( FALSE ); */ > + /* fixme: this will happen sometimes until we do proper lifecycle management via IRemUnknown */ > } > > /* fixme: the lifecycle of table-weak marshals is not $ find|xargs grep FIXME|wc -l 11011 $ find|xargs grep fixme|wc -l 83 Might be good to keep it that way... Andreas Mohr

3 3

[AppDB] Get rid of value fillers in appSubmit.php for a new version
by Paul van Schayck Dec. 28, 2004

Dec. 28, 2004

Those value fillers are not used. We never send users back to the page when errors are found (maybe we should). Changelog: Remove registered globals from the new-version submit. They are not used.

3 4

wine: could not load kernel32.dll, status c000007b
by Serge S. Spiridonoff Dec. 28, 2004

Dec. 28, 2004

Hi, I've compiled a Win32 GUI app under Linux using WineLib but it fails to start. Any ideas what's wrong with the program? [test]WINEDEBUG=+loaddll ./dlg1 trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\msvcrt.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\advapi32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\gdi32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\user32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\winspool.drv" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\comctl32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\iphlpapi.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\rpcrt4.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\ole32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shlwapi.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shell32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\comdlg32.dll" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "krnl386.exe" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "system.drv" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "GDI.EXE" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "USER.EXE" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\x11drv.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\imm32.dll" : builtin wine: could not load kernel32.dll, status c000007b Thanks in advance, Serge

1 0

Re: MSI: free allocated buffers
by Joris Huizer Dec. 28, 2004

Dec. 28, 2004

Mike McCormack wrote: > > ChangeLog: > <aric(a)codeweavers.com> > * free allocated buffers > > The other daty I saw a lot of patches changing things like if (buffer) HeapFree(GetProcessHeap(),0,buffer); To HeapFree(GetProcessHeap(),0,buffer); Why are you adding new code with the if() statement in place again? Just curious regards, Joris

3 2

Re: Unicodify System Metrics
by Mike Hearn Dec. 28, 2004

Dec. 28, 2004

On Tue, 28 Dec 2004 00:26:36 -0500, jchevrier wrote: > --- sysparams.c.orig 2004-12-27 20:09:20.000000000 -0500 > +++ sysparams.c 2004-12-27 21:45:02.674627072 -0500 Hi, The patch looks OK at a first glance but in future please diff from the source root, preferably against CVS. thanks -mike

1 0

[AppDB] naming convention
by Jonathan Ernst Dec. 28, 2004

Dec. 28, 2004

As discussed with Chris and others on IRC we'd like to use a new variable naming convention in AppDB code. The proposed scheme is the following ("hungarian notation"): handles: $hSomeHandle integer: $iSomeInteger objects: $oSomeObject arrays: $aSomeArray strings: $sSomeString and so on. constants will still be uppercase without prefix. Do someone object this ? Jonathan

2 2

Re: free allocated buffers
by Dmitry Timoshkov Dec. 28, 2004

Dec. 28, 2004

"Mike McCormack" <mike(a)codeweavers.com> wrote: > Index: dlls/msi/action.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/action.c,v > retrieving revision 1.55 > diff -u -r1.55 action.c > --- dlls/msi/action.c 27 Dec 2004 19:12:35 -0000 1.55 > +++ dlls/msi/action.c 28 Dec 2004 06:47:04 -0000 > @@ -423,6 +423,59 @@ > } > } > > +/* Called when the package is being closed */ > +extern void ACTION_free_package_structures( MSIPACKAGE* package) > +{ > + INT i; The "extern" above should be removed. -- Dmitry.

1 0

Re: clean-up
by Chris Morgan Dec. 28, 2004

Dec. 28, 2004

Can you post a new version with the fixes that people replied with? I think the rest of the patch looks good. Chris On Thursday 23 December 2004 4:38 am, Eric Blade wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. > > > > > > __________________________________ > Do you Yahoo!? > Send a seasonal email greeting and help others. Do good. > http://celebrity.mail.yahoo.com

1 0

Re: clean-up
by Paul van Schayck Dec. 27, 2004

Dec. 27, 2004

Hey Eric, On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <ekdikeo4(a)yahoo.com> wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. What's this supposed to do: if(!$tempResult) { - echo "$query \n"; + echo "$query < >\n"; echo "An error occurred: ".mysql_error().""; exit; } @@ -68,7 +68,7 @@ if(debugging()) { echo $query; - echo " "; + echo "< >< >"; } And: -if(!loggedin()) +if(!loggedin() || (!havepriv("admin")) Shouldn't this be if(!loggedin() AND (!havepriv("admin")) Rest looks good. Kind regards, Paul

3 2

public domain code from lkcl
by Brian Vincent Dec. 27, 2004

Dec. 27, 2004

I'm not sure if this is useful to anyone, but I thought I remembered licensing being an issue with this once before: http://www.advogato.org/article/814.html "I really really AM relinquishing all copyright of all Samba-related source code that i have ever written, and am placing all that code into the Public Domain." "Specifically, but not limited to, that includes the code in samba which made its way into nmbd (dating right back to 1.9.15.p6 and before, and also including the nmbd_multiworkgroup version), all modifications of smbd that made their way into versions of 1.9.15 and up, all versions known as samba_ntdom _and_ Samba TNG, the code that i cut/paste over to FreeDCE to integrate a NamedPipe Interface plugin and also the FreeDCE NTLMSSP authentication plugin i worked on." -Brian

1 0

WINEPS and AFM
by Vitaly Lipatov Dec. 27, 2004

Dec. 27, 2004

There is a strange code in dlls/wineps/init.c file: if(!pi->Fonts) { MESSAGE("To use WINEPS you need to install some AFM files.\n"); return FALSE; } It returns FALSE if we have not any fonts described in PPD file (buildin printer). Will I remove this section at all? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

safedisc update
by Ivan Leo Puoti Dec. 26, 2004

Dec. 26, 2004

Hello geeks, I've got safedisc and ntoskrnl to load, unfortunately safedisc throws an exception as soon as it starts, so I'll be learning x86 assembly (cool!) soon to try and work this out. I've got ntoskrnl with all the correct prototypes for safedisc, and I've added some definitions to our include/winternl.h so ntoskrnl can build. Unfortunately quite a few structs are needed to compile one of the functions (IofCompleteRequest), so as I don't have time to add them right now it's commented out. These patches are strictly work in progress, but as I'll be away for a few days I'm posting them here just in case someone wants to play with them, I would also like to know if I'm adding the definitions to the winternl.h stuct correctly (For example, is it OK to have all the structs for ntoskrnl in the same place?). If anyone feels the temptation to fix the header so IofCompleteRequest compiles, please go ahead and do it. Comments/suggestions/whatever highly welcome. http://spazioinwind.libero.it/nonsolomicrosoft/header.diff http://spazioinwind.libero.it/nonsolomicrosoft/ntoskrnl.diff Ivan.

1 0

Re: AppDB update (refactoring and new ideas)
by Paul van Schayck Dec. 26, 2004

Dec. 26, 2004

Hey, On Sat, 18 Dec 2004 23:53:34 +0100, Jonathan Ernst <Jonathan(a)ernstfamily.ch> wrote: > I think we shouldn't have more than two images (one screenshot and one > thumbnail) per screenshot (having to click on a thumbnail to get a > medium sized screenshot and having an extra link to get an even bigger > screenshot is not user friendly). However you are right 1600x1400 shots > are maybe overkill so we should define two new constants in the config: It's done. It's doing exactly this. Running examples with source and the source of the class itself can be found here: http://meosource.com/firefox/wine Class is just doing image handeling and could be used right away in for example lostwages. If there are no comments I'll submit a patch and we can start using it. Paul

1 0

Re: user32: stub implementations for WINNLS* functions
by Dmitry Timoshkov Dec. 26, 2004

Dec. 26, 2004

"Diego 'Flameeyes' PettenР" <flameeyes(a)users.berlios.de> wrote: > diff -Npaur wine-orig/dlls/user/winnls.c wine/dlls/user/winnls.c > --- wine-orig/dlls/user/winnls.c 1970-01-01 01:00:00.000000000 +0100 > +++ wine/dlls/user/winnls.c 2004-12-24 17:21:24.566402048 +0100 ... > +UINT WINAPI WINNLSGetIMEHotkey(HWND hUnknown1) ... > +BOOL WINAPI WINNLSEnableIME(HWND hUnknown1, BOOL bUnknown2) ... > +BOOL WINAPI WINNLSGetEnableStatus(HWND hUnknown1) Since these APIs are IME related it would be more natural to name the file ime.c. > diff -Npaur wine-orig/include/winnls.h wine/include/winnls.h > --- wine-orig/include/winnls.h 2004-12-24 16:11:18.499482264 +0100 > +++ wine/include/winnls.h 2004-12-24 15:49:59.905643096 +0100 > @@ -757,6 +757,11 @@ BOOL WINAPI SetThreadLocale(LCID) > BOOL WINAPI SetUserGeoID(GEOID); > INT WINAPI WideCharToMultiByte(UINT,DWORD,LPCWSTR,INT,LPSTR,INT,LPCSTR,LPBOOL); > > +UINT WINAPI WINNLSGetIMEHotkey(HWND); > +BOOL WINAPI WINNLSEnableIME(HWND, BOOL); > +BOOL WINAPI WINNLSGetEnableStatus(HWND); Platform SDK has these APIs in winnls32.h file and marks them as old NT 3.x compatible. -- Dmitry.

2 4

Re: user32: stub implementations for WINNLS* functions
by Diego 'Flameeyes' Pettenò Dec. 26, 2004

Dec. 26, 2004

On Sunday 26 December 2004 01:57, Mike Hearn wrote: > They were commented out, which implies some software does a GetProcAddress > on them. Adding these sorts of stubs can break apps: have you found a > program or DLL that actually needs them? Yu Gi Oh Power of Chaos refuses to execute without them. It also seems not to call them, at least not before crash for other reasons. I thought that the spec-stubs was the ones which breaks things, for this I tried to have implementation-stubs. Regards, -- Diego "Flameeyes" Pettenò flameeyes(a)users.berlios.de - http://flameeyes.web.ctonet.it/

1 0

Determining the color depth of X?
by d13f00l Dec. 25, 2004

Dec. 25, 2004

Hey. I've been trying to iron out a couple bugs running some programs in wine. Running ZSNES reports that ZSNES cannot run in 24 bit depth mode. I'm also running an old game that uses dibs, I took a profiler to wine. We repeatedly call convert_888_to_0888_asis on a surface per blit. The game determines the color depth by what depth you're running windows at. Basicaly, where/how does wine determine your bit depth? Isn't 24 actually 3 significacant bytes + a worthless one in X? XRGB. I didn't see any code determining the bit depth trying to follow what happens when you CreateCompatibleDC(0). Anyone have any ideas? This could be potential for a nice speedup. Thanks. -Dylan

1 0