December 2004 - Wine-Devel - list.winehq.org

Re: [AppDB] php config
by Jonathan Ernst Dec. 13, 2004

Dec. 13, 2004

I forgot to mention that it should be checked if the used config.php file is using short tags (<?) if it is, it has to be replaced with longtags (<?php). thanks, -- Jonathan Ernst <Jonathan(a)ErnstFamily.ch>

2 1

Re: VERSION_GetLinkedDllVersion bug fix
by Andreas Mohr Dec. 13, 2004

Dec. 13, 2004

On Mon, Dec 13, 2004 at 03:09:29PM +0100, Ivan Leo Puoti wrote: > > I fixed a bug in ntdll's VERSION_GetLinkedDllVersion which caused it to > > not be able to return any Windows version higher than WIN98. It has now been > > extended for WIN2K, WINXP, and WIN2K3. This function would eventually be > > called any time that kernel's GetVersionEx was called, which is a problem > > for any software requiring a version higher than WIN98, like Visual Basic > > .NET. > If MajorSubsystemVersion is 4 then the OS can never be win2k or higher, so your > patch can't be correct. > The attached patch should fix the bug you found. Compile tested only. Where's the FIXME message for the default case? ;) (things like this are the prime reason this version issue wasn't uncovered for such a long time!) Andreas Mohr

1 0

(LPVOID) NULL: unnecessary cast?
by Francois Gouget Dec. 13, 2004

Dec. 13, 2004

I have noticed a lot of constructs of the form: HRESULT WINAPI DMUSIC_CreateDirectMusicScriptImpl (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) { IDirectMusicScriptImpl* obj; obj = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicScriptImpl)); if (NULL == obj) { *ppobj = (LPVOID) NULL; return E_OUTOFMEMORY; } What's the point of casting NULL to (LPVOID)? Isn't it already a void* anyway? Is it to fix a warning issued by ultra-recent gcc versions? (gcc 3.4.2 does not complain here) Similarly there are a lot of casts like this: *ppobj = (LPVOID)&This->UnknownVtbl; Again I thought any kind of pointer could be assigned to a void* pointer so is this cast really necessary? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

2 1

Re: Includes [4] shlwapi
by Juan Lang Dec. 13, 2004

Dec. 13, 2004

Jon, are you sure about removing the winnls.h includes? This patch looks suspect: > diff -ur wine/dlls/shlwapi/url.c wine-develop/dlls/shlwapi/url.c > --- wine/dlls/shlwapi/url.c 2004-12-03 23:27:08.000000000 -0500 > +++ wine-develop/dlls/shlwapi/url.c 2004-12-06 15:42:34.000000000 -0500 > @@ -25,8 +25,6 @@ > #include <stdlib.h> > #include "windef.h" > #include "winbase.h" > -#include "winnls.h" > -#include "winerror.h" > #include "wine/unicode.h" > #include "wininet.h" > #include "winreg.h" > @@ -1416,7 +1414,7 @@ > * return the same digests for the same URL. > */ > WideCharToMultiByte(0, 0, pszUrl, -1, szUrl, MAX_PATH, 0, 0); > - HashData((PBYTE)szUrl, (int)strlen(szUrl), lpDest, nDestLen); > + HashData((const BYTE*)szUrl, (int)strlen(szUrl), lpDest, nDestLen); > return S_OK; > } winnls.h declares WideCharToMultiByte, and we just saw a compilation error on some systems because it was missing [1]. I haven't checked others, but this caught my eye. [1] http://www.winehq.org/hypermail/wine-cvs/2004/12/0091.html --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - Find what you need with new enhanced search. http://info.mail.yahoo.com/mail_250

3 9

Re: winsock:WS_setsockopt
by Rein Klazes Dec. 13, 2004

Dec. 13, 2004

On Sun, 12 Dec 2004 12:42:55 +0200, you wrote: > It's a little bit...embracing :-) > > But the program is "Lanwatch". A nice little app, which makes a lot of > noise (if configured correctly) when the Internet connection goes down. > I used it for years, but now we've got rid of the last Windows here.... > > I have other network monitoring tools, but it's just the acoustical > waring, for which I used it...I'll just attach it to the mail, OK? > > It would be great, if there could be a fix for this....Also I contacted > the writer of the little app, but didn't got a answer... > > I think, that it just tries to open a socket (with correct or wrong > parameters), and than gets a back a error and reports (wrongly) that the > Internet connection is down...It might be easy to fix (or hack > workaround) for it, just if you can lead me to the solution? | fixme:winsock:convert_sockopt Unimplemented or unknown socket level | err:winsock:WS_setsockopt Invalid level (65407) or optname (128) | fixme:mpr:WNetGetUniversalNameA ("K:\\", 0x00000001, 0x779cf98c, 0x779cfd98): stub | fixme:winsock:convert_sockopt Unimplemented or unknown socket level | err:winsock:WS_setsockopt Invalid level (65407) or optname (128) | fixme:winsock:convert_sockopt Unknown SOL_SOCKET optname 0xff7f | err:winsock:WS_setsockopt Invalid level (1) or optname (65407) The same output as Space Empires 4. The unknown optname 65407 or 0xff7f, is suspiciously looking like the option SO_DONT_LINGER, 0xffffff7f, with the high bits chopped off. Both these calls fail under Windows (win2K). It is a good idea to ask the programmer, to see what he is trying to accomplish here. Also note that these errors may not be fatal at all if the program is just ignoring them. Letting the program going through I see a fair bit of data exchange, so communications seems to work, at least partly. Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 2

Re: Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation
by Jonathan Gevaryahu Dec. 12, 2004

Dec. 12, 2004

On Sunday 12 December 2004 02:54 pm, Eric Pouech wrote: > Jonathan Gevaryahu a écrit : > does this help? > A+ > > Index: sync.c > =================================================================== > RCS file: /home/cvs/cvsroot/wine/wine/dlls/kernel/sync.c,v > retrieving revision 1.64 > diff -u -u -r1.64 sync.c > --- sync.c 7 Dec 2004 14:23:03 -0000 1.64 > +++ sync.c 12 Dec 2004 19:53:14 -0000 > @@ -893,7 +893,7 @@ > OBJECT_ATTRIBUTES attr; > NTSTATUS status; > > - if (!is_version_nt()) access = SEMAPHORE_ALL_ACCESS; > + if (!is_version_nt()) access = TIMER_ALL_ACCESS; > > attr.Length = sizeof(attr); > attr.RootDirectory = 0; Unfortunately, your patch doesn't fix the problem. But I noticed something disturbing: in CVS (without your patch) occasionally Total Annihilation will run fine (it did ONCE), but almost all of the time it will not work, and give the previously mentioned trace result. Sometimes, it will give a different trace result: ... 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units\\CORDEV1.OVR" not found in /home/jon athan/.wine/dosdevices/g:/cavedog/totala/units warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units\\CORDEV1.OVR" not fou nd (c000003a) warn:file:CreateFileW Unable to create file L"units\\CORDEV1.OVR" (status c00000 3a) trace:ntdll:NtCreateFile handle=0x4087f7a4 access=80000000 name=L"\\??\\G:\\cave dog\\totala\\units-english\\CORDOOM.FBI" objattr=00000042 root=(nil) sec=(nil) i o=0x4087f7a8 alloc_size=(nil) attr=00000080 sharing=00000003 disp=1 options=00000050 ea=(nil).0x00000000 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.834956 (+0.003836) , handles={0x110} ) 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units-english\\CORDOOM.FBI" not found in / home/jonathan/.wine/dosdevices/g:/cavedog/totala warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units-english\\CORDOOM.FBI" not found (c000003a) warn:file:CreateFileW Unable to create file L"units-english\\CORDOOM.FBI" (statu s c000003a) trace:ntdll:NtCreateFile handle=0x4087f7c8 access=80000000 name=L"\\??\\G:\\cave dog\\totala\\units\\CORDOOM.FBI" objattr=00000042 root=(nil) sec=(nil) io=0x4087 f7cc alloc_size=(nil) attr=00000080 sharing=00000003 disp=1 options=00000050 ea=(nil).0x00000000 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.844670 (+0.005838) , handles={0x110} ) 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units\\CORDOOM.FBI" not found in /home/jon athan/.wine/dosdevices/g:/cavedog/totala/units warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units\\CORDOOM.FBI" not fou nd (c000003a) 000a: event_op( handle=0xc0, op=1 ) 000a: event_op() = 0 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.854135 (+0.007851) , handles={0x110} ) 000d: select() = PENDING warn:file:CreateFileW Unable to create file L"units\\CORDOOM.FBI" (status c00000 3a) 0009: get_handle_fd( handle=0xec, access=00000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f80c,0x44404668,0x00000200, (nil),(nil)),partial stub! 0009: get_handle_fd( handle=0xec, access=80000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.864331 (+0.009845) , handles={0x110} ) 000d: select() = PENDING trace:ntdll:NtReadFile = 0x00000000 0009: get_handle_fd( handle=0xec, access=00000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f414,0x4506cf40,0x00000200, (nil),(nil)),partial stub! 0009: get_handle_fd( handle=0xec, access=80000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile = 0x00000000 trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f404,0x44404668,0x00000200, (nil),(nil)),partial stub! ... And that trace means that it was actually working. If I hadn't Control-C terminated that trace, it would have run the game. Jonathan Gevaryahu lord_nightmare(a)users.sf.net

1 0

Baldur's Gate 2 randomly crashes ("Runtime error") with Wine-20041201
by Michal Kepien Dec. 12, 2004

Dec. 12, 2004

Hi there, I've recently compiled Wine-20041201 and I'm trying to get Baldur's Gate II running. The installation sequence is fine, so is the main menu, character creation etc. The problem is, once inside the actual game, the application randomly crashes giving me: Runtime error c:\bg2\BGMain.exe abnormal program termination This happens often enough to render the gameplay quite unnerving. Especially when it happens 15 minutes after the last quicksave ;-) I haven't found out what makes the game crash. I'm quite sure it isn't a sound problem - I've turned sound off both in ~/.wine/config and in BGConfig.exe - not better at all. The only clue I've got is the message which appears in the system console after the game quits: err:ntdll:RtlpWaitForCriticalSection section 0x40689020 "?" wait timed out in thread 000f, blocked by 0009, retrying (60 sec) Whatever it means ;-) The same thing happened in Wine-20041019. I'd be grateful for any clues as right now I'm quite fed up with restarting the game every 3 minutes (or even worse). If you need any more debug messages, just ask. System specification: Toshiba Satellite Pro 4270 - Celeron 500, Savage/IX (8 MB), Yamaha sound card, 320 MB RAM. Slackware 10.0, kernel 2.4.27. X.org - 6.8.1.99 (CVS), CVS Savage driver. ALSA sound driver, using OSS emulation. Window manager: Fluxbox v0.9.10. Thanks in advance for any support, Michal Kepien

1 0

Re: winsock:WS_setsockopt
by Dan Kegel Dec. 12, 2004

Dec. 12, 2004

You wrote: >>... the program is "Lanwatch". A nice little app, which makes a lot of >>noise (if configured correctly) when the Internet connection goes down. >>I used it for years, but now we've got rid of the last Windows here.... >> >>I have other network monitoring tools, but it's just the acoustical >>waring, for which I used it...I'll just attach it to the mail, OK? Do you have a URL for lanwatch, or a few more details that would let us identify it (e.g. vendor name, version number)? (There may be several programs by that name.) Is there a free demo download? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

[AppDB] login problem
by Jonathan Ernst Dec. 12, 2004

Dec. 12, 2004

Hi guys, It's nearly 2 o'clock and I have to wake up early "tomorrow". I made a very big patch that cleans up a lot of code (thousands of tabs, bad indentation, etc. and follows the CODING_STANDARD we wrote together. Of course I didn't had time to clean up every single line of code (I didn't wanted to use any automated mean to do the cleanup to avoid problems). As for the login problem I re-read most of the code and I runned it with all compatibility options turned off and all warnigns turned on and it works very well on my local system. I think there is still one $current occurence somewhere but the problem doesn't come from here. As for the online version that doesn't work, I think that first thing would be to put a test page on the server with phpinfo() in it to know exactly what version of php and what options we are using. Then we have to understand why in function cmd_do_login() of file account.php we have something like: if($result == null) { $_SESSION['current'] = $user; addmsg("You are successfully logged in as '$user->username'.", "green"); redirect(apidb_fullurl("index.php")); } else { retry("login","Login failed ($result)"); $_SESSION['current'] = ""; } And when providing a wrong password we get the error message and when providing a good password we get no message at all ! The reason why it's buggy online and works locally using the latest cvs versions is still to be found... Finally there are still some register_globals to clean up and when we are done we can turn off the following options in php.ini: short_open_tag = Off session.bug_compat_42 = 0 register_globals = Off register_long_arrays = Off P.S. I send a copy to wine-devel in case someone finds out the solution before us.

2 3

Re: ntdll / kernel32: #52
by Robert Shearman Dec. 12, 2004

Dec. 12, 2004

Eric Pouech wrote: > Moving atom implementation to: > - dlls/kernel32/atom16.c for the 16 bit part > - dlls/ntdll/ntdll.c for the 32 bit part > > A+ > >------------------------------------------------------------------------ > >Name: ntkrnl_52 >ChangeLog: > - moved 16 bit atom support in (16bit) dlls/kernel/atom16.c > - added atom support to NTDLL > - made 32 bit atom support in kernel32 call ntdll's brand new one > - copied the atom tests for global atom so that we can test local atoms too >License: X11 >GenDate: 2004/12/11 12:59:19 UTC >ModifiedFiles: dlls/kernel/Makefile.in dlls/kernel/atom.c dlls/kernel/tests/atom.c dlls/ntdll/Makefile.in dlls/ntdll/ntdll.spec include/winternl.h server/protocol.def server/atom.c >AddedFiles: dlls/kernel/atom16.c dlls/ntdll/atom.c > > ... >--- /dev/null 1970-01-01 01:00:00.000000000 +0100 >+++ dlls/ntdll/atom.c 2004-12-04 15:31:03.000000000 +0100 >@@ -0,0 +1,331 @@ >+/* >+ * Atom table functions >+ * >+ * Copyright 1993, 1994, 1995 Alexandre Julliard >+ * Copyright 2004 Eric Pouech >+ * >+ * This library is free software; you can redistribute it and/or >+ * modify it under the terms of the GNU Lesser General Public >+ * License as published by the Free Software Foundation; either >+ * version 2.1 of the License, or (at your option) any later version. >+ * >+ * This library is distributed in the hope that it will be useful, >+ * but WITHOUT ANY WARRANTY; without even the implied warranty of >+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >+ * Lesser General Public License for more details. >+ * >+ * You should have received a copy of the GNU Lesser General Public >+ * License along with this library; if not, write to the Free Software >+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA >+ */ >+ >+#include "config.h" >+#include "wine/port.h" >+ >+#include <stdlib.h> >+#include <stdarg.h> >+#include <stdio.h> >+#include <string.h> >+#include <ctype.h> >+ >+#include "windef.h" >+#include "winbase.h" >+#include "ntstatus.h" >+ >+#include "wine/server.h" >+#include "wine/unicode.h" >+ >+#include "wine/debug.h" >+ >+WINE_DEFAULT_DEBUG_CHANNEL(atom); >+ >+#define DEFAULT_ATOMTABLE_SIZE 37 >+#define MAX_ATOM_LEN 255 >+ >+/****************************************************************** >+ * is_integral_atom >+ * Returns STATUS_SUCCESS if integral atom and 'pAtom' is filled >+ * STATUS_INVALID_PARAMETER if 'atomstr' is too long >+ * STATUS_MORE_ENTRIES otherwise >+ */ >+static NTSTATUS is_integral_atom( LPCWSTR atomstr, ATOM* pAtom ) >+{ >+ ATOM atom; >+ >+ if (HIWORD( atomstr )) >+ { >+ const WCHAR* ptr = atomstr; >+ if (*ptr++ == '#') >+ { >+ atom = 0; >+ while (*ptr >= '0' && *ptr <= '9') >+ { >+ atom = atom * 10 + *ptr++ - '0'; >+ } >+ if (ptr > atomstr + 1 && !*ptr) goto done; >+ } >+ if (strlenW( atomstr ) > MAX_ATOM_LEN) return STATUS_INVALID_PARAMETER; >+ return STATUS_MORE_ENTRIES; >+ } >+ else atom = LOWORD( atomstr ); >+done: >+ if (atom >= MAXINTATOM) return STATUS_INVALID_PARAMETER; >+ *pAtom = atom; >+ return STATUS_SUCCESS; >+} >+ >+/****************************************************************** >+ * RtlDeleteAtomFromAtomTable (NTDLL.@) >+ */ >+NTSTATUS WINAPI RtlDeleteAtomFromAtomTable( void* table, ATOM atom ) >+{ >+ NTSTATUS status; >+ >+ TRACE( "%p %x\n", table, atom ); >+ SERVER_START_REQ( delete_atom ) >+ { >+ req->atom = atom; >+ req->table = table; >+ status = wine_server_call( req ); >+ } >+ SERVER_END_REQ; >+ return status; >+} > > Rtl* functions should generally avoid doing server calls. You should implement the Rtl* functions on top of the Nt* functions, not the other way around. ... >+/****************************************************************** >+ * NtDeleteAtom (NTDLL.@) >+ */ >+NTSTATUS WINAPI NtDeleteAtom(ATOM atom) >+{ >+ return RtlDeleteAtomFromAtomTable( GLOBAL_ATOM_TABLE, atom ); >+} > > Rob

3 5

winsock:WS_setsockopt
by MediaHost (TM) Dec. 12, 2004

Dec. 12, 2004

Hi Wine-Devel, Is here anybody which knows what the following function is supposed to do and what needs to get implemented? I'm referring to this: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) Many thanks.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/>

2 1

Re: msacm: pcm compatibility patch
by Christian Costa Dec. 11, 2004

Dec. 11, 2004

Hi Robert, Robert Reif wrote: > Makes the PCM conversion routines of msacm produce identical results > to the native dll. > Allow any PCM to PCM conversion, not just advertised ones. > > The algorithms used by Microsoft in this dll are very crude and > produce an output of much poorer quality than what is currently > in wine. This is unfortunate but unavoidable if we are to be compatible. I don't see how improving the quality of the conversion could cause problems. Is there an app out there that refuses to run or crashes because of that? The algorithms may have slightly changed across all versions of this dll. And if we can do better job than Microsoft, I think we should do it. > > I have a test program that was used to verify compatibility and can > make it available by request. I hope to integrate some of it into > the regression tests someday. > Bye, Christian

4 4

BeginPaint not called on WM_PAINT
by James Hawkins Dec. 11, 2004

Dec. 11, 2004

I'm trying to get a program running called BZEdit. Under the latest cvs, the program shows a scrambled mess over the whole screen (I think that is a result of this patch http://cvs.winehq.org/patch.py?id=14725) but when I went back in time to 2004-10-12, the only part of the screen I cant see is the part of the screen where the map you're editing is shown. See http://www.artemisgames.com/BZEdit/ for screenshots. This is the error output I'm getting. err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 0x1002a! This message happens every time the editor needs a repaint like when it gets covered by another window. Any ideas about what's going on here? -- James Hawkins

4 7

Re: include file cleanup : another step
by Robert Shearman Dec. 11, 2004

Dec. 11, 2004

Rémi Assailly wrote: > I moved some defines, ttydrv will not use gdi.h any longer. > I notice that some headers are declared twice, I removed useless > declarations. > > Changelog: > * moved some defines from gdi.h > >------------------------------------------------------------------------ > >--- dlls/gdi/palette.c~ 2004-10-18 23:18:58.000000000 +0200 >+++ dlls/gdi/palette.c 2004-12-09 14:14:52.000000000 +0100 >@@ -37,6 +37,11 @@ > #include "wine/debug.h" > #include "winerror.h" > >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >+ > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > static INT PALETTE_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > >--- include/gdi.h~ 2004-03-04 21:41:13.000000000 +0100 >+++ include/gdi.h 2004-12-09 19:01:20.154559672 +0100 >@@ -83,14 +83,6 @@ > SEGPTR segptr_bits; /* segptr to DIB bits */ > } BITMAPOBJ; > >-/* palette object */ >- >-#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >- >-#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >-#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ >-#define PC_SYS_MAPPED 0x10 /* logical palentry is a direct alias for system palentry */ >- > typedef struct tagPALETTEOBJ > { > GDIOBJHDR header; > >--- dlls/ttydrv/palette.c~ 2004-12-09 18:57:42.835597176 +0100 >+++ dlls/ttydrv/palette.c 2004-12-09 14:27:48.000000000 +0100 >@@ -22,10 +22,14 @@ > > #include <stdlib.h> > >-#include "gdi.h" >-#include "winbase.h" > #include "ttydrv.h" > #include "wine/debug.h" >+#include "wine/wingdi16.h" >+ >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > > WINE_DEFAULT_DEBUG_CHANNEL(ttydrv); > >--- dlls/x11drv/palette.c~ 2004-12-01 12:32:11.000000000 +0100 >+++ dlls/x11drv/palette.c 2004-12-09 19:03:03.933782832 +0100 >@@ -24,11 +24,16 @@ > #include <string.h> > > #include "gdi.h" >-#include "windef.h" > #include "winreg.h" > #include "x11drv.h" > #include "wine/debug.h" > >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >+#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ >+ > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > /* Palette indexed mode: > > Nice try, but I don't think we want three copies of the same defines. That's just asking for trouble with them getting out of sync. Rob

2 1

questionable code
by Eric Pouech Dec. 11, 2004

Dec. 11, 2004

still toying with various compilers, here's two new questions (to whom it may concern): **** dlls/gdi/freetype.c line 1467 the test for "(offset < 0)" is always false. I'm not sure changing it into "offset == -1" is the right solution. *** dlls/ole32/hglobalstream.c line 602 the test "if (newPosition.QuadPart < 0)" is always false as QuadPart is unsigned A+

2 2

Re: [AppDB] TODO patch
by tony_lambregts＠telusplanet.net Dec. 11, 2004

Dec. 11, 2004

Jonathan Ernst wrote: [snip] > Index: CODING_STANDARD > =================================================================== > RCS file: /home/wine/appdb/CODING_STANDARD,v > retrieving revision 1.1 > diff -u -r1.1 CODING_STANDARD > --- CODING_STANDARD 11 Dec 2004 03:42:43 -0000 1.1 > +++ CODING_STANDARD 11 Dec 2004 18:56:07 -0000 > @@ -62,4 +62,11 @@ > } > } > > +- use long php tags (<?php ?>) instead of short ones (<? ?>) as : > + 1) it could be removed from future versions of php > + 2) if conflicts with tags like <?xml version=1.0 ?> that are used in xhtml [snip] Should be it not if oops//: + 2) it conflicts with tags like <?xml version=1.0 ?> that are used in xhtml

1 0

Re: IME fixes
by Aric Stewart Dec. 11, 2004

Dec. 11, 2004

You have a few places where variable declaration has moved from the top of the function to under your block. That should be fixed. It is hard to read through the whitespace changes for me. I though general convention was that you did not change whitespace (i seems to remember a small war over that) other than that things look ok. Have you tested this by setting your locale to ja_JP or zh_CN or ko_KR to make sure the fixme come back and such? thanks -aric Ivan Leo Puoti wrote: > We have 2 space, 4 space and 5 space indentation in ime.c, so fix that. > Also behave like windows if we're on a locale that doesn't support, by returning 0 > after setting last error to 120. > > Ivan.

3 2

Re: Includes [1] ntdll
by Andreas Mohr Dec. 11, 2004

Dec. 11, 2004

Hi, On Tue, Dec 07, 2004 at 06:15:39AM -0800, Jon Griffiths wrote: > Hi, > > On the suspicion that my hacking on header files was causing too many > files to be rebuilt, I whipped up a quick perl script to identify > unneeded header files. This series of patches is the result. Nice stuff, but... where is it? The most important part, I mean: the perl script ;-) Note that some removed include files might be needed for different systems, so some breakage might/may/will follow this patch. (Gerald Pfeifer will *love* your "nice" work, I'm sure ;-) But I'd still vote strongly for including it, since it will remove lots of cruft. Thanks, Andreas Mohr

6 8

[AppDB] First step to integrating the AppDB with Bugzilla
by Tony Lambregts Dec. 11, 2004

Dec. 11, 2004

Over two years ago this was disccused and the concensus at the time was that integrating the AppDB and Bugzilla would be a Good Idea (TM). This patch is my attempt to get it started. I am submitting this to wine devel first because I KNOW this patch can be controversial. I have tried to make this patch as small as possible but it still covers quite a few files. I am useing Globals and that should be improved. and I am sure there are other things that are wrong with it. ;^) Also the code in preferences.php does not do anything except show that this works. Finally in order for it to work Jeremy Newman will need to set up the include/config.php in the appdb directory. Please try it out and get back to me.. Change Log: Integrate AppDB with Bugzilla to use the versions table from Buzilla. Files changed: preferences.php include/config.php.sample include/util.php Files Added: tables/bugzilla_tables.sql tables/create_bugzilla_tables Index: preferences.php =================================================================== RCS file: /home/wine/appdb/preferences.php,v retrieving revision 1.2 diff -u -r1.2 preferences.php --- preferences.php 10 Dec 2004 01:07:45 -0000 1.2 +++ preferences.php 11 Dec 2004 04:45:44 -0000 @@ -50,6 +50,16 @@ $ext_email = $user->lookup_email($_SESSION['current']->userid); include(BASE."include/"."form_edit.php"); + $version = "unspecified"; + echo "<tr><td>  wine version </td><td>"; + make_bugzilla_version_list("version", $version); + echo "</td></tr>"; +/* <tr> + <td>   Email Address </td> + <td> <input type="text" name="ext_email" value="<?=$ext_email;?>"> </td> + </tr> +*/ + } if($HTTP_POST_VARS) Index: include/config.php.sample =================================================================== RCS file: /home/wine/appdb/include/config.php.sample,v retrieving revision 1.2 diff -u -r1.2 config.php.sample --- include/config.php.sample 24 Mar 2004 15:51:49 -0000 1.2 +++ include/config.php.sample 11 Dec 2004 04:45:45 -0000 @@ -24,4 +24,14 @@ $userdb_dbhost = "localhost"; $userdb_db = "apidb"; +/* + * Bugzilla database info + */ +$bugzilla_dbuser = "root"; +$bugzilla_dbpass = ""; +$bugzilla_dbhost = "localhost"; +$bugzilla_db = "bugs"; +/* $bugzilla_db_port = 3306; is this needed? I dont think so.*/ +$bugzilla_product_id = 1; + ?> Index: include/util.php =================================================================== RCS file: /home/wine/appdb/include/util.php,v retrieving revision 1.7 diff -u -r1.7 util.php --- include/util.php 10 Dec 2004 01:07:45 -0000 1.7 +++ include/util.php 11 Dec 2004 04:45:45 -0000 @@ -171,6 +171,69 @@ } } +/* bugzilla functions */ + +function openbugzilladb() +{ + global $bugzilla_dbuser, $bugzilla_dbpass, $bugzilla_dbhost, $bugzilla_db, $bugzilla_product_id; + global $dbcon, $dbref; + + $dbref++; + + if($dbcon) + return $dbcon; + + $dbcon = mysql_connect($bugzilla_dbhost, $bugzilla_dbuser, $bugzilla_dbpass); + if(!$dbcon) + { + echo "An error occurred: ".mysql_error()."<p>\n"; + exit; + } + mysql_select_db($bugzilla_db); + return $dbcon; +} + +function closebugzilladb() +{ + global $dbcon, $dbref; + + if(--$dbref) + return; + + mysql_close($adbcon); +} + +function make_bugzilla_version_list($varname, $cvalue) +{ + global $bugzilla_db, $bugzilla_product_id; + + $table = $bugzilla_db.".versions"; + $where = "WHERE product_id=".$bugzilla_product_id; + $query = "SELECT value FROM $table $where ORDER BY value"; + + openbugzilladb(); + + $result = mysql_query($query); + + if(!$result) + { + closebugzilladb(); + + return; // Oops + } + echo "<select name='$varname'>\n"; + echo "<option value=0>Choose ...</option>\n"; + while(list($value) = mysql_fetch_row($result)) + { + if($id == $cvalue) + echo "<option value=$value selected>$value\n"; + else + echo "<option value=$value>$value\n"; + } + echo "</select>\n"; + closebugzilladb(); +} + /* get the number of applications in the appQueue table */ function getQueuedAppCount() { --- /dev/null 2003-01-30 03:24:37.000000000 -0700 +++ tables/create_bugzilla_tables 2004-12-10 13:41:28.000000000 -0700 @@ -0,0 +1,4 @@ +#! /bin/sh + +echo Creating fake Bugzilla tables +mysql -u root < bugzilla_tables.sql --- /dev/null 2003-01-30 03:24:37.000000000 -0700 +++ tables/bugzilla_tables.sql 2004-12-10 14:10:49.000000000 -0700 @@ -0,0 +1,62 @@ +create database if not exists bugs; + +use bugs; + +drop table if exists versions; + + +/* + * versions information + */ +create table versions ( + value tinytext, + product_id smallint not null +); + +INSERT INTO versions VALUES ('unspecified', 1 ); +INSERT INTO versions VALUES ('20010112', 1 ); +INSERT INTO versions VALUES ('20010216', 1 ); +INSERT INTO versions VALUES ('20010305', 1 ); +INSERT INTO versions VALUES ('20010326', 1 ); +INSERT INTO versions VALUES ('20010418', 1 ); +INSERT INTO versions VALUES ('20010510', 1 ); +INSERT INTO versions VALUES ('20010629', 1 ); +INSERT INTO versions VALUES ('20010824', 1 ); +INSERT INTO versions VALUES ('20011004', 1 ); +INSERT INTO versions VALUES ('20011108', 1 ); +INSERT INTO versions VALUES ('20020228', 1 ); +INSERT INTO versions VALUES ('20020310', 1 ); +INSERT INTO versions VALUES ('20020411', 1 ); +INSERT INTO versions VALUES ('20020509', 1 ); +INSERT INTO versions VALUES ('20020605', 1 ); +INSERT INTO versions VALUES ('20020710', 1 ); +INSERT INTO versions VALUES ('20020804', 1 ); +INSERT INTO versions VALUES ('20020904', 1 ); +INSERT INTO versions VALUES ('20021007', 1 ); +INSERT INTO versions VALUES ('20021031', 1 ); +INSERT INTO versions VALUES ('20021125', 1 ); +INSERT INTO versions VALUES ('20021219', 1 ); +INSERT INTO versions VALUES ('20030115', 1 ); +INSERT INTO versions VALUES ('20030219', 1 ); +INSERT INTO versions VALUES ('20030318', 1 ); +INSERT INTO versions VALUES ('20030408', 1 ); +INSERT INTO versions VALUES ('20030508', 1 ); +INSERT INTO versions VALUES ('20030618', 1 ); +INSERT INTO versions VALUES ('20030709', 1 ); +INSERT INTO versions VALUES ('20030813', 1 ); +INSERT INTO versions VALUES ('20030911', 1 ); +INSERT INTO versions VALUES ('20031016', 1 ); +INSERT INTO versions VALUES ('20031118', 1 ); +INSERT INTO versions VALUES ('20031212', 1 ); +INSERT INTO versions VALUES ('20040121', 1 ); +INSERT INTO versions VALUES ('20040213', 1 ); +INSERT INTO versions VALUES ('20040309', 1 ); +INSERT INTO versions VALUES ('20040408', 1 ); +INSERT INTO versions VALUES ('20040505', 1 ); +INSERT INTO versions VALUES ('20040615', 1 ); +INSERT INTO versions VALUES ('20040716', 1 ); +INSERT INTO versions VALUES ('20040813', 1 ); +INSERT INTO versions VALUES ('20040914', 1 ); +INSERT INTO versions VALUES ('20041019', 1 ); +INSERT INTO versions VALUES ('20041201', 1 ); +INSERT INTO versions VALUES ('CVS', 1 ); Index: README =================================================================== RCS file: /home/wine/appdb/README,v retrieving revision 1.3 diff -u -r1.3 README --- README 25 Mar 2004 16:29:47 -0000 1.3 +++ README 11 Dec 2004 05:10:49 -0000 @@ -1,32 +1,70 @@ -WineHQ Application Database ------------------------------------------------------------------------- -Authors: - Jeremy Newman <jnewman(a)codeweavers.com> - Charles Leop <charles(a)codeweavers.com> - -Contributors: - Paul van Schayck <info(a)wwwdesign.tmfweb.nl> - Chris Morgan <cmorgan(a)alum.wpi.edu> +WineHQ Application Database +------------------------------------------------------------------------ +Authors: + Jeremy Newman <jnewman(a)codeweavers.com> + Charles Leop <charles(a)codeweavers.com> + +Contributors: + Paul van Schayck <info(a)wwwdesign.tmfweb.nl> + Chris Morgan <cmorgan(a)alum.wpi.edu> + + +To install locally for testing/hacking: +------------------------------------------------------------------------ + +- Symlink from /var/www to the appdb directory + +- Copy include/config.php.sample to include/config.php + +- Edit include/config.php as you see fit, the default name of the database + used in the table creation step below is "apidb", you'll have to modify + these files if you change this in config.php + +- cd tables, run ./create_tables to create the database tables + +- Try to open up localhost/appdb, if you get a directory listing + Edit your /etc/apache/httpd.conf "DirectoryIndex" to include index.php + so apache will open index.php after not finding index.html/index.htm etc + +- Check your /etc/php/php.ini to ensure that + 'register_globals = On' (variables won't get passed) + 'magic_quotes_gpc = Off' (you would end up with \ everywhere) + 'session.bug_compat_42' = On' (Problem with auto-globals and session variables) +------------------------------------------------------------------------ +You can create ether set up a real bugzilla database or a fake one + +- cd tables, run ./create_bugzilla_tables to create the fake bugzilla tables -To install locally for testing/hacking: ------------------------------------------------------------------------- +- installing a real bugzilla database (hope this helps) -- Symlink from /var/www to the appdb directory +# download buzilla (password for cvs is cvs) -- Copy include/config.php.sample to include/config.php +cd /var/www/html +export CVSROOT=:pserver:cvs(a)cvs.winehq.org:/home/wine +cvs login +cvs -z 0 checkout bugzilla -- Edit include/config.php as you see fit, the default name of the database - used in the table creation step below is "apidb", you'll have to modify - these files if you change this in config.php +# change directory to bugzilla and change the group ownership to apache. -- cd tables, run ./create_tables to create the database tables +cd bugzilla +chgrp -R apache . +chmod -R g+rX . -- Try to open up localhost/appdb, if you get a directory listing - Edit your /etc/apache/httpd.conf "DirectoryIndex" to include index.php - so apache will open index.php after not finding index.html/index.htm etc -- Check your /etc/php/php.ini to ensure that - 'register_globals = On' (variables won't get passed) - 'magic_quotes_gpc = Off' (you would end up with \ everywhere) - 'session.bug_compat_42' = On' (Problem with auto-globals and session variables) +# change to su and run ./checksetup.pl and fix up what it finds wrong. +# this may take several runs + +su +./checksetup.pl + +# in the /etc/httpd/conf/hppt.conf file find "AddHandler cgi-script .cgi" and add the following. + +<Directory "/var/www/html/bugzilla"> +Options ExecCGI +AllowOverride Limit +Order allow,deny +Allow from all +</Directory> + +# edit local config as nessary to allow access.

3 2

Re: Allow output in winedbg to be redirected to a file
by Eric Pouech Dec. 11, 2004

Dec. 11, 2004

Jeremy White a écrit : > Changelog: > Allow > and >> output redirection on winedbg commands to capture > output to a file. again (it's my bad day for Jer), I think we should stick to gdb commands: see 'set logging' and friends. A+

2 2

some description for ExtTextOut
by Vitaly Lipatov Dec. 11, 2004

Dec. 11, 2004

This patch adds description for ExtTextOut and missed constants. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

winsock:WS_setsockopt
by StartCom Ltd. Dec. 11, 2004

Dec. 11, 2004

Hi Wine-Devel, Is here anybody which knows what the following function is supposed to do and what needs to get implemented? I'm referring to this: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) Many thanks.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/>

1 0

Problems using WineDbg
by Bodo Thiesen Dec. 10, 2004

Dec. 10, 2004

Ok, I'm trying to use winedbg to check, why a game doesn't work, but: $ /cd_autorun Zeus Using /cdimages/mnt/Zeus/AUTORUN.INF as Autorun.Inf Using Z:\autorun.exe as Autorun.Exe Setting WINEPREFIX to /.wine-Zeus Starting Z:\autorun.exe using cmdline /bin/wine Z:\autorun.exe Xlib: extension "GLX" missing on display "localhost:0.0". fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x40359328)->(0002002e,00000013) fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x40359328)->(0002002e,00000008) fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x40359328)->(0002002e,00000013) fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or DDBLT_ASYNC: can't handle right now. wine: Unhandled exception (thread 000f), starting debugger... WineDbg starting on pid 0xe Unhandled exception: page fault on read access to 0x5a202d28 in 32-bit code (0x21113913). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:007f EIP:21113913 ESP:4067f8b8 EBP:4067fcdc EFLAGS:00010206( - 00 - RIP1) EAX:00000000 EBX:41a54f80 ECX:5a202d28 EDX:00737565 ESI:403ae428 EDI:41a552e8 Stack dump: 0x4067f8b8: 41a55228 21103fa6 403ae428 41a55228 0x4067f8c8: 10029005 403ae428 0000ac44 00000000 0x4067f8d8: 100086c8 41a55228 0000ac44 00000010 0x4067f8e8: 00000002 08000000 41a54f80 4067fe0c 0x4067f8f8: 00000000 4051d10c 00000280 000001e0 0x4067f908: 00000e85 00000000 00000000 0000001e 0200: sel=1007 base=40016000 limit=00001f97 32-bit rw- Backtrace: =>1 0x21113913 in mss32 (+0x13913) (0x4067fcdc) 2 0x0042300b in zeus (+0x2300b) (0x4067fdbc) 3 0x00603f1f in zeus (+0x203f1f) (0x4067fe94) 4 0x0060f8ae EntryPoint+0xce in zeus (0x4067ff20) 5 0x40481a65 start_process+0x135(arg=0x0) [/wine/dlls/kernel/process.c:1046] in kernel32 (0x4067fff4) 6 0x4001d361 wine_pthread_abort_thread+0x31(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x21113913: cmpl $1,0x0(%ecx) Wine-dbg>info registers{PRESSED ENTER} Register dump: CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:007f EIP:21113913 ESP:4067f8b8 EBP:4067fcdc EFLAGS:00010206( - 00 - RIP1) EAX:00000000 EBX:41a54f80 ECX:5a202d28 EDX:00737565 ESI:403ae428 EDI:41a552e8 Wine-dbg>bt{PRESSED ENTER} Backtrace: =>1 0x21113913 in mss32 (+0x13913) (0x4067fcdc) 2 0x0042300b in zeus (+0x2300b) (0x4067fdbc) 3 0x00603f1f in zeus (+0x203f1f) (0x4067fe94) 4 0x0060f8ae EntryPoint+0xce in zeus (0x4067ff20) 5 0x40481a65 start_process+0x135(arg=0x0) [/wine/dlls/kernel/process.c:1046] in kernel32 (0x4067fff4) 6 0x4001d361 wine_pthread_abort_thread+0x31(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) Wine-dbg>${PRESSED ENTER} )Syntax Error ( Wine-dbg>WineDbg terminated on pid 0xe {PRESSED ENTER} $ So, in the very first seconds, I still can interact with winedbg, but then it suddenly disappears, and I get back my shell. No chance to investigate the problem using winedbg this way. There are some other strage missbehaviors, like printing 10000 times 'Wine-dbg>' before being killed using kill -kill <wine-pids>, or even not printing the register dump + back trace in the first place like shown above (same application, startup phase). So not even every time I try winedbg, everything happens identical. I'm using wine-cvs just checked out and rebuild using command line: $ cvs up && ./configure -C --prefix=/ && make depend && make && make install Regards, Bodo

2 1

Re: [AppDB] remove blahblahblah from /include/comments.php
by Chris Morgan Dec. 10, 2004

Dec. 10, 2004

Hahah. Oops.... Chris > > From: tony_lambregts(a)telusplanet.net > Date: 2004/12/10 Fri AM 01:09:35 EST > To: wine-patches(a)winehq.org > Subject: [AppDB] remove blahblahblah from /include/comments.php > > Change log: remove blahblahblah from /include/comments.php > > Files Changed: /include/comments.php > > > Index: include/comments.php =================================================================== RCS file: /home/wine/appdb/include/comments.php,v retrieving revision 1.7 diff -u -r1.7 comments.php --- include/comments.php 10 Dec 2004 01:07:45 -0000 1.7 +++ include/comments.php 10 Dec 2004 06:58:22 -0000 @@ -75,7 +75,6 @@ echo "<input type=hidden name='commentId' value=$ob->commentId>"; echo "<input type=hidden name='appId' value=$ob->appId>"; echo "<input type=hidden name='versionId' value=$ob->versionId></form></td>","\n"; - echo "blahblahblah $apidb_root"; echo "</td></tr>"; }

1 0

Patch to support VT_BYREF | VT_I4 in typelib.c _copy_arg
by Erich Hoover Dec. 10, 2004

Dec. 10, 2004

dlls/oleaut32/typelib.c does not currently support VT_BYREF | VT_I4 in _copy_arg, this causes InstallShield to crash when attempting to install the demo for "Prince of Persia: Warrior Within" (and probably other InstallShield programs as well). Installation can complete with this fix under Win9x w/ Desktop (2K and XP options still fail due to "unimplemented function imagehlp.dll.StackWalk64" and non-Desktop fails for unknown reason).

3 2

current CVS broken.
by Ivan Leo Puoti Dec. 9, 2004

Dec. 9, 2004

I believe this patch http://www.winehq.com/hypermail/wine-cvs/2004/12/0081.html is causing this compile error on my system. make[2]: Entering directory `/path/to/wine/source/dlls/winmm/winejack' gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o audio.o audio.c audio.c: In function `JACK_WaveInit': audio.c:902: warning: implicit declaration of function `wine_dlsym' audio.c:902: warning: assignment makes pointer from integer without a cast audio.c:903: warning: assignment makes pointer from integer without a cast audio.c:904: warning: assignment makes pointer from integer without a cast audio.c:905: warning: assignment makes pointer from integer without a cast audio.c:906: warning: assignment makes pointer from integer without a cast audio.c:907: warning: assignment makes pointer from integer without a cast audio.c:908: warning: assignment makes pointer from integer without a cast audio.c:909: warning: assignment makes pointer from integer without a cast audio.c:910: warning: assignment makes pointer from integer without a cast audio.c:911: warning: assignment makes pointer from integer without a cast audio.c:912: warning: assignment makes pointer from integer without a cast audio.c:913: warning: assignment makes pointer from integer without a cast audio.c:914: warning: assignment makes pointer from integer without a cast audio.c:915: warning: assignment makes pointer from integer without a cast audio.c:916: warning: assignment makes pointer from integer without a cast audio.c:934: warning: implicit declaration of function `strcpyW' audio.c:998: warning: implicit declaration of function `wine_dlclose' audio.c: In function `wodDevInterfaceSize': audio.c:1682: warning: implicit declaration of function `MultiByteToWideChar' audio.c:1682: error: `CP_ACP' undeclared (first use in this function) audio.c:1682: error: (Each undeclared identifier is reported only once audio.c:1682: error: for each function it appears in.) audio.c: In function `wodDevInterface': audio.c:1692: error: `CP_ACP' undeclared (first use in this function) audio.c: In function `widDevInterfaceSize': audio.c:2428: error: `CP_ACP' undeclared (first use in this function) audio.c: In function `widDevInterface': audio.c:2438: error: `CP_ACP' undeclared (first use in this function) make[2]: *** [audio.o] Error 1 make[2]: Leaving directory `/path/to/wine/source/wine/dlls/winmm/winejack' make[1]: *** [winmm/winejack] Error 2 make[1]: Leaving directory `/path/to/wine/source/wine/dlls' make: *** [dlls] Error 2 ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

3 6

Office2K and current Wine
by Igor Shmukler Dec. 9, 2004

Dec. 9, 2004

Hello, We have problems running most programs including Office with latest wine (20041201) we built from sources on RH9. Following error message appears when running installer: $ fixme:msi:MsiEnableLogA 00000516 "c:\\windows\\temp\\Office 2000 SR-1 Premium Setup(0006)_MsiExec.txt" 00000000 fixme:msi:MsiInstallProductW L"Z:\\home\\ser\\.wine\\office\\data1.msi" L"" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"AppSearch" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"ResolveSource" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting wine: Unhandled exception (thread 000b), starting debugger... Is this a known issue? Any pointers would be most welcome. Thank you in advance, Igor.

1 0

tools/wineinstall
by Christian Britz Dec. 9, 2004

Dec. 9, 2004

Dear all, the script tools/wineinstall suggest to uninstall wine first if you update an existing installation. This makes senses but it is uncomfortable that the script doesn't offer the option to do that for the user. You always have to su before installing a new version Thx Christian

2 2

Re: include file cleanup : another step
by Vincent Béron Dec. 9, 2004

Dec. 9, 2004

Le jeu 09/12/2004 à 15:47, Rémi Assailly a écrit : > I moved some defines, ttydrv will not use gdi.h any longer. > I notice that some headers are declared twice, I removed useless > declarations. > > Changelog: > * moved some defines from gdi.h > ---- > > --- dlls/gdi/palette.c~ 2004-10-18 23:18:58.000000000 +0200 > +++ dlls/gdi/palette.c 2004-12-09 14:14:52.000000000 +0100 > @@ -37,6 +37,11 @@ > #include "wine/debug.h" > #include "winerror.h" > > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > + > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > static INT PALETTE_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > > --- include/gdi.h~ 2004-03-04 21:41:13.000000000 +0100 > +++ include/gdi.h 2004-12-09 19:01:20.154559672 +0100 > @@ -83,14 +83,6 @@ > SEGPTR segptr_bits; /* segptr to DIB bits */ > } BITMAPOBJ; > > -/* palette object */ > - > -#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > - > -#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > -#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ > -#define PC_SYS_MAPPED 0x10 /* logical palentry is a direct alias for system palentry */ > - > typedef struct tagPALETTEOBJ > { > GDIOBJHDR header; > > --- dlls/ttydrv/palette.c~ 2004-12-09 18:57:42.835597176 +0100 > +++ dlls/ttydrv/palette.c 2004-12-09 14:27:48.000000000 +0100 > @@ -22,10 +22,14 @@ > > #include <stdlib.h> > > -#include "gdi.h" > -#include "winbase.h" > #include "ttydrv.h" > #include "wine/debug.h" > +#include "wine/wingdi16.h" > + > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > > WINE_DEFAULT_DEBUG_CHANNEL(ttydrv); > > --- dlls/x11drv/palette.c~ 2004-12-01 12:32:11.000000000 +0100 > +++ dlls/x11drv/palette.c 2004-12-09 19:03:03.933782832 +0100 > @@ -24,11 +24,16 @@ > #include <string.h> > > #include "gdi.h" > -#include "windef.h" > #include "winreg.h" > #include "x11drv.h" > #include "wine/debug.h" > > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > +#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ > + > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > /* Palette indexed mode: Defining the same thing in multiple files is a clear indication an #include is needed. Vincent

1 0

Re: Visual studio 6 build fix.
by Juan Lang Dec. 9, 2004

Dec. 9, 2004

> MS Visual C++ v6, when invoking the compiler and other build tools does > the following: > > create anonymous pipe; > duplicate the pipes write handle; > open's the file NUL > The attached patch makes this work properly. Ahh, cool, that might help with MinGW's windres.exe, too. It uses _popen, which I've implemented to do basically the same as above. _popen works for a silly little test program I wrote, but windres.exe isn't getting its output. I'll check it out. Thanks, --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250

1 0

Re: visual studio 6 not happy?
by Dan Kegel Dec. 9, 2004

Dec. 9, 2004

Jerry Geis wrote: > I am trying to use wine 12-01-04 release with Visual Studio. > I am getting the vcspawn error. Have you ever found a solution to that? > [http://www.winehq.com/hypermail/wine-devel/2003/02/0335.html] Nope. I didn't look very hard, though. > If not I am trying to use the command line nmake. I can export the make file > but how do I build it after that. I know 'wine nmake /f project.mak > CFG="project - Win32 Release"' but that > doesnt exactly do it. From what directory do you execute that? I did it > in the release directory. Have you read http://codingstyle.com/articles/using-ms-vcpp-with-gnu-wine.html ? It might explain that. I haven't really used nmake much, so I've forgotten how I ran it. I usually ignore the .mak file and just build things by hand, as described in http://kegel.com/wine/cl-howto.html, because I do such small things (Wine unit tests, mostly). - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

winelib problems
by Joris Huizer Dec. 9, 2004

Dec. 9, 2004

Hello, I tried winemaker (just the notepad example explained at the page) but it doesn't work: - I had to comment out 'use strict' - otherwise winemaker would complain; - still no notepad2 executable is generated... Is it under active development, or is winemaker having bigger problems? regards, Joris

1 0

EnumCalendarInfo
by Vitaly Lipatov Dec. 9, 2004

Dec. 9, 2004

Some months ago Ken Belleau done some implementation of EnumCalendarInfo. http://www.winehq.org/hypermail/wine-patches/2004/04/0170.html I can't find any discussion of this patch. It is possible to review it and apply now? I would like to write some tests for this functions later. P.S. Sorry for patches I send this list. Have I to resend it in wine-patches or not? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Another systray patch
by Alexandre Julliard Dec. 9, 2004

Dec. 9, 2004

Mike Hearn <mike(a)navi.cx> writes: > There was a crash in the previous patch, here is a fixed version. > > - Add a new wineshell process, and put system tray handling in there > - Rewrite the shell32 systray handling to be out of process > - Support the freedesktop.org XEMBED protocol It would be nice to do the XEMBED stuff as a separate patch. Also I was hoping you would get rid of WS_EX_TRAYWINDOW instead of adding even more uses of it... > + /* we can't intern this with the rest as it depends on the screen we are connecting to */ > + systray_buffer = HeapAlloc(GetProcessHeap(), 0, sizeof(char)*20); > + sprintf(systray_buffer, "_NET_SYSTEM_TRAY_S%d", DefaultScreen(display)); The screen will be 0 in 99.9% of the cases, you should preallocate that one. > +void *xmalloc(unsigned int size) > +{ > + void *p = HeapAlloc(GetProcessHeap(), 0, size); > + > + if (!p) > + { > + fprintf(stderr, "wineshell: virtual memory exhausted\n"); > + exit(1); > + } > + > + ZeroMemory(p, size); exit(1) is not acceptable here, you should handle allocation failures properly. Also malloc doesn't clear the buffer so xmalloc shouldn't either, otherwise it's very confusing. > +struct request { > + NOTIFYICONDATAA ansi; > + NOTIFYICONDATAW wide; > + BOOL unicode; > + BYTE *copydata; Inter-process data should always be sent in Unicode. -- Alexandre Julliard julliard(a)winehq.org

2 2

add GetGlobalFontLinkObject in mlang
by Vitaly Lipatov Dec. 9, 2004

Dec. 9, 2004

Changes stub to FIXME for GetGlobalFontLinkObject in mlang DLL The patch is attached. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: Another systray patch
by Mike Hearn Dec. 9, 2004

Dec. 9, 2004

> Mike, > I tried saving the patch in various ways, maybe its me, but it would > appear its corrupted, can u resend as attachment, thanks. That's very strange. That was the first time I have tried sending a patch via the builtin emacs sendmail facility, it would be annoying if that mangles it somehow. I checked the web archive and my own inbox, and the patch *looked* fine. I wonder what is up with it. Still, here it is again as an attachment this time. - Add a new wineshell process, and put system tray handling in there - Rewrite the shell32 systray handling to be out of process - Support the freedesktop.org XEMBED protocol

1 1

problem reading dir's with fix
by Rein Klazes Dec. 9, 2004

Dec. 9, 2004

hi, Since the change from readdir to getdents64 I cannot access certain files and dir's (including the one used for saving wine patches) with the common file dialog's. | 0009:Call ntdll.NtQueryDirectoryFile(00000010,00000000,00000000,00000000,77a6a070,77cc6b24,00002000,00000003,00000000,77cc6b10,00000000) ret=77b26174 | trace:file:NtQueryDirectoryFile (0x10 (nil) (nil) (nil) 0x77a6a070 0x77cc6b24 0x00002000 0x00000003 0x00000000 L"diffs" 0x00000000 | trace:file:append_entry long L"."... short L""... mask L"diffs" | trace:file:match_filename (L"."..., L"diffs") | trace:file:append_entry long L".."... short L""... mask L"diffs" | trace:file:match_filename (L".."..., L"diffs") [some 200 entries snipped] | trace:file:append_entry long L"freecell.ICO"... short L""... mask L"diffs" | trace:file:match_filename (L"freecell.ICO"..., L"diffs") | trace:file:NtQueryDirectoryFile => 80000006 (0) | 0009:Ret ntdll.NtQueryDirectoryFile() retval=80000006 ret=77b26174 | 0009:Call ntdll.RtlNtStatusToDosError(80000006) ret=77b261e1 | 0009:Ret ntdll.RtlNtStatusToDosError() retval=00000012 ret=77b261e1 | trace:file:FindFirstFileExW L"H:\\diffs" not found H:\ contains almost 400 entries, so it is clear not all are read. Looking through the code I notice that getdents64 is called only once, where readdir was called several times. Here is my solution that fixes the problem for me. Changelog: dlls/ntdll : directory.c If needed, keep calling getdents64() until no more entries are returned. Rein.

1 0

Re: wine/ windows/winproc.c programs/uninstaller/m ...
by Dimitrie O. Paun Dec. 9, 2004

Dec. 9, 2004

On Thu, Dec 09, 2004 at 08:08:00AM -0600, Alexandre Julliard wrote: > Log message: > Janitorial: C booleans must not be compared against TRUE. Thank you! -- Dimi.

1 0

Re: Build also 20 ppem font size for wine_sserifee.fon
by Huw D M Davies Dec. 9, 2004

Dec. 9, 2004

On Thu, Dec 09, 2004 at 05:33:01PM +0800, Dmitry Timoshkov wrote: > Hello, > > it seems that 20 ppem size for wine_sserifee was simply overlooked. > No, it's a different face than the 20 ppem for cp1251 and cp1252 and is actually the same face as one of the 120dpi ones. I believe this is a mistake by MS, but we have to follow suit. The good news is that I've already drawn such a beast, it just requires a little hack to sfnttofnt to distinguish it from the existing 20 ppem face. I'll try to post a patch soon. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

winedbg problems
by Michael Lin Dec. 8, 2004

Dec. 8, 2004

Hi all, I am having problem with winedbg and a winelib application I am trying to debug. In the debugger it produce the following output when exception occured: Wine-dbg>cont First chance exception: page fault on read access to 0x00000000 in 32-bit code ( 0x401d4316). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:401d4316 ESP:41e4f7d4 EBP:41e4f7d4 EFLAGS:00210212( - 00 - RIA1) EAX:0000000a EBX:4059aee4 ECX:00000000 EDX:41e4fa3a ESI:00000104 EDI:41e4fa24 Stack dump: 0x41e4f7d4: 41e4fc40 405067c5 00000000 00000104 0x41e4f7e4: 403b67c4 00000001 0000001d 0000004c 0x41e4f7f4: 00000001 00000048 00690057 0065006e 0x41e4f804: 00500020 0073006f 00000000 00000000 0x41e4f814: 00700069 00200074 00720044 00760069 0x41e4f824: 00720065 00000000 4194e425 0000007a Backtrace: =>1 0x401d4316 RtlDetermineDosPathNameType_U+0x6(path=0x0) [/home/mlin/wine/dlls/ntdll/path.c:193] in ntdll (0x41e4f7d4) 2 0x405067c5 PROFILE_Open+0xf5(filename=0x0) [/home/mlin/wine/dlls/kernel/profile.c:751] in kernel32 (0x41e4fc40) 3 0x405087c6 WritePrivateProfileStringW+0x46(section=0x403c2998, entry=0x0, string=0x0, filename=0x0) [/home/mlin/wine/dlls/kernel/profile.c:1415] in kernel32 (0x41e4fc80) 4 0x4050897d WritePrivateProfileStringA+0xbd(section=0x4194ead8, entry=0x0, string=0x0, filename=0x0) [/home/mlin/wine/dlls/kernel/profile.c:1455] in kernel32 (0x41e4fcd0) 5 0x40aaf21ferr:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch PtrArrayWalker <> PtrArray_FIXME<Page> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Node <> ValList<String> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Node <> ValList<Forecasting err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch ConstIterator <> ValList<String> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Iterator <> ValList<String> ..................... err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Iterator <> ValList<String> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch ConstIterator <> ValList<Forecasting err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Iterator <> ValList<Forecasting Exception c0000005 Wine-dbg> Jon Griffiths reported a similar problem on Jun 21 2004. Does anyone else seen this problem? It seems like winedbg have some problem parsing stabs debug information on C++ templates. Any help would be really appreciated. Thanks, Michael

1 0

Re: shlwapi - forward SHSetTimerQueueTimer to kernel32.CreateTimerQueueTimer
by Robert Shearman Dec. 8, 2004

Dec. 8, 2004

Steven Edwards wrote: >Hi, > >Msdn documents quite a bit about shlwapi functions that are wrappers around other functions: >http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… > >But at the moment the application I am testing only depends on this function. > >Changelog: >Foward Shlwapi.SHSetTimerQueueTimer to kernel32.CreateTimerQueueTimer > > Then the application will crash and die in horrible ways with this patch. The function signature of SHSetTimerQueueTimer is not the same as CreateTimerQueueTimer. However, as the MSDN docs say, they are compatible. So, you just need to create an implementation of SHSetTimerQueueTimer that converts the parameters appropriately and calls CreateTimerQueueTimer. Note that this function is still a FIXME stub at the moment, although I plan on implementing this and the thread pooling functions because they will be useful for the COM work. Rob

1 0

Re: Genrate stdole32.tlb file, and install generated files
by Huw D M Davies Dec. 8, 2004

Dec. 8, 2004

On Sat, Dec 04, 2004 at 01:38:59PM -0500, Vincent Béron wrote: > stdole32-generator.c file from Huw. > Invocation from wineprefixcreate from me. > > Changelog: > Automatically create c:\windows\system\stdole32.tlb. > > Vincent The native version of stdole32.tlb is actually a resource only dll that contains the typelib itself as TYPELIB resource #1. I think we probably want to do likewise. Huw. -- Huw Davies huw(a)codeweavers.com

5 6

Re: fix crash in painting.c
by Steven Edwards Dec. 8, 2004

Dec. 8, 2004

Hi, --- Rein Klazes <wijn(a)wanadoo.nl> wrote: > Several app's crash with the re-organized region code. > > Changelog: > dlls/user : painting.c > GetUpdateRect can be called with rect is NULL. Just tested here and this does fix the IE6 regressions I was seeing. Thanks Steven __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

tooltips problem with server side update region handling
by Rein Klazes Dec. 8, 2004

Dec. 8, 2004

Hi, There are now 4 little tooltips windows sticking on top of all windows and following me to every desktop I go :-(((. The problem seems to be that the call: SetWindowPos (hwnd, HWND_TOP, 0, 0, 0, 0, SWP_NOZORDER | SWP_HIDEWINDOW | SWP_NOACTIVATE); in TOOLTIPS_Hide() is ineffective (does not hide the tooltip). Here is a +tooltip,+win,+x11drv trace of the situation before: | trace:tooltips:TOOLTIPS_Hide Hide tooltip 5! (0x10042) | trace:win:SetWindowPos hwnd 0x10042, after (nil), 0,0 (0x0), flags 00000094 | trace:win:dump_winpos_flags flags: SWP_NOZORDER SWP_NOACTIVATE SWP_HIDEWINDOW | trace:x11drv:X11DRV_SetWindowPos hwnd 0x10042, after (nil), swp 0,0 0x0 flags 00000094 | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=46 wparam=0 lParam=77a6f514 | trace:x11drv:X11DRV_SetWindowPos current (187,92)-(324,112), style 94800000 | warn:x11drv:SWP_DoOwnedPopups (0x10042) hInsertAfter = (nil) | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=83 wparam=1 lParam=77a6f478 | trace:x11drv:SWP_DoNCCalcSize (1,1)-(1,1) | trace:x11drv:X11DRV_set_window_rectangles win 0x10042 window (0,0)-(0,0) client (1,1)-(1,1) | trace:win:RedrawWindow 0x10042 ((nil)) NULL 0,0-0,0 (nil) flags=08b8 | trace:win:dump_rdw_flags flags: RDW_VALIDATE RDW_NOINTERNALPAINT RDW_NOERASE RDW_ALLCHILDREN RDW_NOFRAME | trace:win:RDW_UpdateRgns hwnd 0x10042 [(nil)] -> hrgn [0x1], flags [08b8] compared to the situation after, with added some of the +server trace. | race:tooltips:TOOLTIPS_Hide Hide tooltip 5! (0x10042) | trace:win:SetWindowPos hwnd 0x10042, after (nil), 0,0 (0x0), flags 00000094 | trace:win:dump_winpos_flags flags: SWP_NOZORDER SWP_NOACTIVATE SWP_HIDEWINDOW | trace:x11drv:X11DRV_SetWindowPos hwnd 0x10042, after (nil), swp 0,0 0x0 flags 00000094 | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=46 wparam=0 lParam=77a6f514 | trace:x11drv:SWP_DoWinPosChanging hwnd 0x10042, after (nil), swp 0,0 0x0 flags 00001894 | trace:x11drv:SWP_DoWinPosChanging current (178,78)-(315,98) style 94800000 new (0,0)-(0,0) | warn:x11drv:SWP_DoOwnedPopups (0x10042) hInsertAfter = (nil) | 0009: get_window_children( parent=0x10020, atom=0000, tid=0000 ) | 0009: get_window_children() = 0 { count=7, children={0x10042,0x1002c,0x10044,0x10034,0x10022,0x10028,0x10026} } | 0009: start_hook_chain( id=4 ) | 0009: start_hook_chain() = 0 { handle=(nil), pid=0000, tid=0000, proc=(nil), unicode=0, module=L"" } | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=83 wparam=1 lParam=77a6f498 | 0009: start_hook_chain( id=12 ) | 0009: start_hook_chain() = 0 { handle=(nil), pid=0000, tid=0000, proc=(nil), unicode=0, module=L"" } | trace:x11drv:SWP_DoNCCalcSize (1,1)-(1,1) | 0009: set_window_pos( handle=0x10042, top_win=0x10042, previous=(nil), flags=00000094, redraw_flags=00000000, window={0,0;0,0}, client={1,1;1,1} ) | 0009: set_window_pos() = INVALID_PARAMETER { new_style=00000000 } where it all ends. The INVALID_PARAMETER is, I think, the result of a failure of server function validate_window_rectangles(), choking on a window with size 0,0-0,0 and client 1,1-1,1. I guess the validation is too strict, right? Rein.

1 0

Re: [RESEND] Unicodified fontdlg (next try)
by Alexandre Julliard Dec. 8, 2004

Dec. 8, 2004

Jacek Caban <jack(a)itma.pwr.wroc.pl> writes: > -INT_PTR CALLBACK FormatCharDlgProcA(HWND hDlg, UINT uMsg, WPARAM wParam, > +INT_PTR CALLBACK FormatCharDlgProc(HWND hDlg, UINT uMsg, WPARAM wParam, > LPARAM lParam) > { > - LPCHOOSEFONTA lpcf; > + LPCHOOSEFONTW lpcf; > INT_PTR res = FALSE; > > if (uMsg!=WM_INITDIALOG) > { > - lpcf=(LPCHOOSEFONTA)GetPropA(hDlg, WINE_FONTDATA); > - if (!lpcf && uMsg != WM_MEASUREITEM) > + lpcf=(LPCHOOSEFONTW)GetPropW(hDlg, strWineFontData); > + if (!lpcf) > return FALSE; > if (CFn_HookCallChk32(lpcf)) > - res=CallWindowProcA((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); > + res=CallWindowProcW((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); You cannot use the same dialog procedure for A and W here, since it will cause the hook to always be called with a W message, even if the app originally called ChooseFontA. You really need to keep both dialog procedures. -- Alexandre Julliard julliard(a)winehq.org

1 0

IMM_Register and Flight Simulator 98
by Robert Reif Dec. 8, 2004

Dec. 8, 2004

Just tried to install Flight Simulator 98 with latest CVS and got this: [wine(a)dell cdrom1]$ wine setup.exe wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x000004d0 in 32-bit code (0x40e42e67). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0033 GS:004f EIP:40e42e67 ESP:4081f394 EBP:4081f3bc EFLAGS:00010212( - 00 - RIA1) EAX:00000000 EBX:40f0b1e4 ECX:40502a9f EDX:00000000 ESI:40e15a98 EDI:40322f50 Stack dump: 0x4081f394: 4081f3bc 409816e0 000000be 00000000 0x4081f3a4: 00000000 00000000 40e42e5b 40e11220 0x4081f3b4: 40e15a98 40322f50 4081f3e0 40dd85e3 0x4081f3c4: 00000000 000000b6 00000000 00000000 0x4081f3d4: 40997614 40322c28 40322e10 4081f67c 0x4081f3e4: 4095a025 0000004c 40322e28 4081f410 Backtrace: =>1 0x40e42e67 ?? +0x17 in libx11.so.6 (0x4081f3bc) 2 0x40dd85e3 X11DRV_CreateDC+0x87(hdc=0x4c, pdev=0x40322e28, driver=0x4081f410, device=0x0, output=0x0, initData=0x0) [/home/wine/wine/dlls/x11drv/init.c:153] in x11drv (0x4081f3e0) 3 0x4095a025 CreateDCW+0xed(driver=0x408d2f50, device=0x0, output=0x0, initData=0x0) [/home/wine/wine/dlls/gdi/dc.c:609] in gdi32 (0x4081f67c) 4 0x40861503 CURSORICON_CreateFromResource+0x65f(hModule=0x0, hObj=0x0, bits=0x408c5740, cbSize=0x134, bIcon=0x0, dwVersion=0x30000, width=0x20, height=0x20, loadflags=0x8040) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:711] in user32 (0x4081f70c) 5 0x408616eb CURSORICON_Load+0x12f(hInstance=0x0, name=0x7f00, width=0x0, height=0x0, colors=0x1, fCursor=0x1, loadflags=0x8040) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:971] in user32 (0x4081f75c) 6 0x4086390f LoadImageW+0x8b(hinst=0x0, name=0x7f00, type=0x2, desiredx=0x0, desiredy=0x0, loadflags=0x8040) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:2272] in user32 (0x4081f790) 7 0x40862a5e LoadCursorW+0x26(hInstance=0x0, name=0x7f00) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:1715] in user32 (0x4081f7b4) 8 0x41747762 IMM_Register+0x5a [/home/wine/wine/dlls/imm32/imm.c:107] in imm32 (0x4081f800) 9 0x417478d8 DllMain+0x78(hInstDLL=0x41740000, fdwReason=0x1, lpReserved=0x0) [/home/wine/wine/dlls/imm32/imm.c:146] in imm32 (0x4081f814) 10 0x41746f88 __wine_dll_main+0x60 in imm32 (0x4081f844) 11 0x401a2cee call_dll_entry_point+0x12 in ntdll (0x4081f85c) 12 0x401a3d07 MODULE_InitDLL+0xe3(wm=0x40322b80, reason=0x1, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:741] in ntdll (0x4081f8cc) 13 0x401a3ee4 process_attach+0xf8(wm=0x40322b80, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:814] in ntdll (0x4081f8f0) 14 0x401a56e0 LdrLoadDll+0x84(path_name=0x40322ab8, flags=0x0, libname=0x4081f954, hModule=0x4081f934) [/home/wine/wine/dlls/ntdll/loader.c:1565] in ntdll (0x4081f914) 15 0x40466d73 load_library+0x4b(libname=0x4081f954, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:671] in kernel32 (0x4081f944) 16 0x40466e3a LoadLibraryExW+0x2e(libnameW=0x40014c00, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:726] in kernel32 (0x4081f964) 17 0x40466dfe LoadLibraryExA+0x2e(libname=0x40e0bfc4, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:707] in kernel32 (0x4081f97c) 18 0x40466e70 LoadLibraryA+0x1c(libname=0x40e0bfc4) [/home/wine/wine/dlls/kernel/module.c:746] in kernel32 (0x4081f994) 19 0x40df2064 LoadImmDll+0x1c [xim.c:78] in x11drv (0x4081f9a4) 20 0x40df29bb X11DRV_SetupXIM+0x127(display=0x7801c0b8, input_style=0x40e15978) [/home/wine/wine/dlls/x11drv/xim.c:440] in x11drv (0x4081f9d4) 21 0x40deb656 x11drv_init_thread_data+0x11a [/home/wine/wine/dlls/x11drv/x11drv_main.c:502] in x11drv (0x4081f9f0) 22 0x40dc41d1 X11DRV_create_desktop+0x289(desktop_vi=0x0, geometry=0x78020580) [/home/wine/wine/dlls/x11drv/desktop.c:251] in x11drv (0x4081fa78) 23 0x40deb3ac process_attach+0x150 [/home/wine/wine/dlls/x11drv/x11drv_main.c:395] in x11drv (0x4081fa9c) 24 0x40deb761 DllMain+0x39(hinst=0x40db0000, reason=0x1, reserved=0x0) [/home/wine/wine/dlls/x11drv/x11drv_main.c:524] in x11drv (0x4081faa8) 25 0x40dbb6d4 __wine_dll_main+0x60 in x11drv (0x4081fad8) 26 0x401a2cee call_dll_entry_point+0x12 in ntdll (0x4081faf0) 27 0x401a3d07 MODULE_InitDLL+0xe3(wm=0x40322978, reason=0x1, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:741] in ntdll (0x4081fb60) 28 0x401a3ee4 process_attach+0xf8(wm=0x40322978, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:814] in ntdll (0x4081fb84) 29 0x401a56e0 LdrLoadDll+0x84(path_name=0x403228a8, flags=0x0, libname=0x4081fbe8, hModule=0x4081fbc8) [/home/wine/wine/dlls/ntdll/loader.c:1565] in ntdll (0x4081fba8) 30 0x40466d73 load_library+0x4b(libname=0x4081fbe8, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:671] in kernel32 (0x4081fbd8) 31 0x40466e3a LoadLibraryExW+0x2e(libnameW=0x40014c00, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:726] in kernel32 (0x4081fbf8) 32 0x40466dfe LoadLibraryExA+0x2e(libname=0x4081fc44, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:707] in kernel32 (0x4081fc10) 33 0x40466e70 LoadLibraryA+0x1c(libname=0x4081fc44) [/home/wine/wine/dlls/kernel/module.c:746] in kernel32 (0x4081fc28) 34 0x408c2c42 load_driver+0x7a [user_main.c:75] in user32 (0x4081fd60) 35 0x408c321f process_attach+0x47 [/home/wine/wine/dlls/user/user_main.c:180] in user32 (0x4081fd70) 36 0x408c33cc DllMain+0x50(inst=0x40840000, reason=0x1, reserved=0x1) [/home/wine/wine/dlls/user/user_main.c:260] in user32 (0x4081fd80) 37 0x40851218 __wine_dll_main+0x60 in user32 (0x4081fdb0) 38 0x401a2cee call_dll_entry_point+0x12 in ntdll (0x4081fdc8) 39 0x401a3d07 MODULE_InitDLL+0xe3(wm=0x402f0908, reason=0x1, lpReserved=0x1) [/home/wine/wine/dlls/ntdll/loader.c:741] in ntdll (0x4081fe38) 40 0x401a3ee4 process_attach+0xf8(wm=0x402f0908, lpReserved=0x1) [/home/wine/wine/dlls/ntdll/loader.c:814] in ntdll (0x4081fe5c) 41 0x401a3f13 process_attach+0x127(wm=0x402f07c8, lpReserved=0x1) [/home/wine/wine/dlls/ntdll/loader.c:806] in ntdll (0x4081fe7c) 42 0x401a5fe6 LdrInitializeThunk+0x1f2(main_file=0x0, unknown2=0x0, unknown3=0x0, unknown4=0x0) [/home/wine/wine/dlls/ntdll/loader.c:1902] in ntdll (0x4081ff20) 43 0x40471433 start_process+0x9b(arg=0x0) [/home/wine/wine/dlls/kernel/process.c:1036] in kernel32 (0x4081fff4) 44 0x400298f5 wine_pthread_abort_thread+0x29(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x40e42e67 ?? +0x17 in libx11.so.6: movl 0x4d0(%edx),%eax Wine-dbg>

2 1

Re: msvcrt: implement _pipe
by Alexandre Julliard Dec. 8, 2004

Dec. 8, 2004

Juan Lang <juan_lang(a)yahoo.com> writes: > + fd = msvcrt_alloc_fd(readHandle, wxflags); > + if (fd != -1) > + { > + pfds[0] = fd; > + fd = msvcrt_alloc_fd(writeHandle, wxflags); > + if (fd != -1) > + pfds[1] = fd; > + } > + if (fd == -1) > + { > + CloseHandle(readHandle); > + CloseHandle(writeHandle); > + *MSVCRT__errno() = MSVCRT_EMFILE; > + ret = -1; > + } You need to free pfds[0] on failure if it was allocated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Problems with Managed Mode
by pvriens＠xs4all.nl Dec. 8, 2004

Dec. 8, 2004

Hi, just compiled wine (CVS from yesterday 12/7/2004). Started with a clean wine environment. Running 'wine notepad.exe' works fine. Running the same command when the config-file shows: [AppDefaults\\notepad.exe\\x11drv] "Desktop" = "800x600" gives: wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 fixme:dbghelp:SymLoadModule should have successfully loaded some debug information for image C:\windows\notepad.exe Unhandled exception: page fault on read access to 0x000004d0 in 32-bit code (0x1028dc07). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:1028dc07 ESP:2d89f304 EBP:2d89f32c EFLAGS:00010202( - 00 - -RI1) EAX:00000000 EBX:1033d58c ECX:352ca5c3 EDX:00000000 ESI:6d98fdb4 EDI:77e13110 Stack dump: 0x2d89f304: 2d89f32c 3b843d0c 000000be 00000000 0x2d89f314: 00000000 00000000 6aa2d799 6d9895cc 0x2d89f324: 6d98fdb4 77e13110 2d89f350 6d958e1b 0x2d89f334: 00000000 00000060 00000000 00000000 0x2d89f344: 3b8522cc 0000004c 77e12fd0 2d89f5f0 0x2d89f354: 3b81ce89 0000004c 77e12fe8 2d89f384 Backtrace: =>1 0x1028dc07 (0x2d89f32c) 2 0x6d958e1b X11DRV_CreateDC+0x87(hdc=0x4c, pdev=0x77e12fe8, driver=0x2d89f384, device=0x0, output=0x0, initData=0x0) [/data/install/linux/wine-src/wine/dlls/x11drv/init.c:153] in x11drv (0x2d89f350) 3 0x3b81ce89 CreateDCW+0xed(driver=0x3b13e410, device=0x0, output=0x0, initData=0x0) [/data/install/linux/wine-src/wine/dlls/gdi/dc.c:609] in gdi32 (0x2d89f5f0) 4 0x3b0cf0aa CURSORICON_CreateFromResource+0x62e(hModule=0x0, hObj=0x0, bits=0x3b130e00, cbSize=0x134, bIcon=0x0, dwVersion=0x30000, width=0x20, height=0x20, loadflags=0x8040) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:711] in user32 (0x2d89f67c) 5 0x3b0cf290 CURSORICON_Load+0x134(hInstance=0x3b0b0000, name=0x7f00, width=0x0, height=0x0, colors=0x1, fCursor=0x1, loadflags=0x8040) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:971] in user32 (0x2d89f6c8) 6 0x3b0d1411 LoadImageW+0x91(hinst=0x0, name=0x7f00, type=0x2, desiredx=0x0, desiredy=0x0, loadflags=0x8040) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:2272] in user32 (0x2d89f6fc) 7 0x3b0d05b6 LoadCursorW+0x26(hInstance=0x0, name=0x7f00) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:1715] in user32 (0x2d89f720) 8 0x12a2175b IMM_Register+0x57 [/data/install/linux/wine-src/wine/dlls/imm32/imm.c:107] in imm32 (0x2d89f76c) 9 0x12a218cc DllMain+0x74(hInstDLL=0x12a10000, fdwReason=0x1, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/imm32/imm.c:146] in imm32 (0x2d89f780) 10 0x12a20f88 __wine_dll_main+0x60 in imm32 (0x2d89f7b0) 11 0x6aa37676 call_dll_entry_point+0x12 in ntdll (0x2d89f7c8) 12 0x6aa38673 MODULE_InitDLL+0xdf(wm=0x77e12d40, reason=0x1, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:741] in ntdll (0x2d89f838) 13 0x6aa387cd process_attach+0x81(wm=0x77e12d40, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:814] in ntdll (0x2d89f85c) 14 0x6aa39fb8 LdrLoadDll+0x84(path_name=0x77e12c68, flags=0x0, libname=0x2d89f8c4, hModule=0x2d89f8a4) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:1565] in ntdll (0x2d89f884) 15 0x35230e5b load_library+0x4b(libname=0x2d89f8c4, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:671] in kernel32 (0x2d89f8b4) 16 0x35230f1a LoadLibraryExW+0x2e(libnameW=0x385ccc00, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:726] in kernel32 (0x2d89f8d4) 17 0x35230ede LoadLibraryExA+0x2e(libname=0x6d985ff4, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:707] in kernel32 (0x2d89f8ec) 18 0x35230f50 LoadLibraryA+0x1c(libname=0x6d985ff4) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:746] in kernel32 (0x2d89f904) 19 0x6d972078 LoadImmDll+0x1c [xim.c:78] in x11drv (0x2d89f914) 20 0x6d972972 X11DRV_SetupXIM+0x102(display=0x7974c260, input_style=0x6d98fc50) [/data/install/linux/wine-src/wine/dlls/x11drv/xim.c:440] in x11drv (0x2d89f944) 21 0x6d96b806 x11drv_init_thread_data+0x11a [/data/install/linux/wine-src/wine/dlls/x11drv/x11drv_main.c:502] in x11drv (0x2d89f960) 22 0x6d944f11 X11DRV_create_desktop+0x291(desktop_vi=0x0, geometry=0x7973a9b8) [/data/install/linux/wine-src/wine/dlls/x11drv/desktop.c:251] in x11drv (0x2d89f9ec) 23 0x6d96b54c process_attach+0x148 [/data/install/linux/wine-src/wine/dlls/x11drv/x11drv_main.c:395] in x11drv (0x2d89fa14) 24 0x6d96b905 DllMain+0x35(hinst=0x6d930000, reason=0x1, reserved=0x0) [/data/install/linux/wine-src/wine/dlls/x11drv/x11drv_main.c:524] in x11drv (0x2d89fa20) 25 0x6d93c6d4 __wine_dll_main+0x60 in x11drv (0x2d89fa50) 26 0x6aa37676 call_dll_entry_point+0x12 in ntdll (0x2d89fa68) 27 0x6aa38673 MODULE_InitDLL+0xdf(wm=0x77e12ba0, reason=0x1, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:741] in ntdll (0x2d89fad8) 28 0x6aa387cd process_attach+0x81(wm=0x77e12ba0, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:814] in ntdll (0x2d89fafc) 29 0x6aa39fb8 LdrLoadDll+0x84(path_name=0x77e12ac0, flags=0x0, libname=0x2d89fb64, hModule=0x2d89fb44) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:1565] in ntdll (0x2d89fb24) 30 0x35230e5b load_library+0x4b(libname=0x2d89fb64, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:671] in kernel32 (0x2d89fb54) 31 0x35230f1a LoadLibraryExW+0x2e(libnameW=0x385ccc00, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:726] in kernel32 (0x2d89fb74) 32 0x35230ede LoadLibraryExA+0x2e(libname=0x2d89fbc0, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:707] in kernel32 (0x2d89fb8c) 33 0x35230f50 LoadLibraryA+0x1c(libname=0x2d89fbc0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:746] in kernel32 (0x2d89fba4) 34 0x3b12e326 load_driver+0x76 [user_main.c:75] in user32 (0x2d89fcdc) 35 0x3b12e8fb process_attach+0x47 [/data/install/linux/wine-src/wine/dlls/user/user_main.c:180] in user32 (0x2d89fcec) 36 0x3b12eaa0 DllMain+0x4c(inst=0x3b0b0000, reason=0x1, reserved=0x1) [/data/install/linux/wine-src/wine/dlls/user/user_main.c:260] in user32 (0x2d89fcfc) 37 0x3b0bf218 __wine_dll_main+0x60 in user32 (0x2d89fd2c) 38 0x6aa37676 call_dll_entry_point+0x12 in ntdll (0x2d89fd44) 39 0x6aa38673 MODULE_InitDLL+0xdf(wm=0x77de0b60, reason=0x1, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:741] in ntdll (0x2d89fdb4) 40 0x6aa387cd process_attach+0x81(wm=0x77de0b60, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:814] in ntdll (0x2d89fdd8) 41 0x6aa38867 process_attach+0x11b(wm=0x77de09e0, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fdf8) 42 0x6aa38867 process_attach+0x11b(wm=0x77de0940, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe18) 43 0x6aa38867 process_attach+0x11b(wm=0x77de0858, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe38) 44 0x6aa38867 process_attach+0x11b(wm=0x77de0770, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe58) 45 0x6aa38867 process_attach+0x11b(wm=0x77de0678, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe78) 46 0x6aa3a87a LdrInitializeThunk+0x1ea(main_file=0x0, unknown2=0x0, unknown3=0x0, unknown4=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:1902] in ntdll (0x2d89ff20) 47 0x3523b109 start_process+0x99(arg=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/process.c:1036] in kernel32 (0x2d89fff4) 48 0x100046a5 wine_pthread_abort_thread+0x29(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x1028dc07: movl 0x4d0(%edx),%eax Wine-dbg> Any idea what to do/try next ? Cheers, Paul Vriens.

1 0

Searching for an existing Windows installation
by Christian Britz Dec. 8, 2004

Dec. 8, 2004

Dear all, because this step during the installation takes very long, I would suggest to make it optional. Mit freundlichen Grüßen Christian

4 3

Re: wine/ windows/win.c windows/painting.c server/ ...
by Dimitrie O. Paun Dec. 8, 2004

Dec. 8, 2004

On Tue, Dec 07, 2004 at 11:31:53AM -0600, Alexandre Julliard wrote: > Log message: > Moved update region handling to the server. > > Patch: http://cvs.winehq.org/patch.py?id=14725 Cool stuff! Way to go Alexandre, this is really, really good news! -- Dimi.

3 3