December 2004 - Wine-Devel - list.winehq.org

Re: [winelib] Can't figure out a Winemaker error
by Michael Jung Dec. 15, 2004

Dec. 15, 2004

Scott, On Wednesday 15 December 2004 06:32, Scott Ritchie wrote: > Global symbol "%directories" requires explicit package name > at /usr/bin/winemaker line 423. > Global symbol "%directories" requires explicit package name > at /usr/bin/winemaker line 441. > Execution of /usr/bin/winemaker aborted due to compilation errors. > > What's going on here? Did I screw something up, or was this broken in > that release? This is with the December release. This is a problem, which seems to have been introduced in the december release and which is already fixed in cvs. If you don't want to use cvs you can just patch the winemaker script: Move the "my %directories" global variable declaration (somewhere around line 1060) above the "get_directory_contents" function declaration (ca. line 400). Ciao, Michael

1 0

[winelib] Can't figure out a Winemaker error
by Scott Ritchie Dec. 15, 2004

Dec. 15, 2004

As part of my effort to create a successful demonstration of how to port something, I tried out winelib. Unfortunately, I can't seem to get it working at all. I get this error whenever I run winemaker: Global symbol "%directories" requires explicit package name at /usr/bin/winemaker line 423. Global symbol "%directories" requires explicit package name at /usr/bin/winemaker line 441. Execution of /usr/bin/winemaker aborted due to compilation errors. What's going on here? Did I screw something up, or was this broken in that release? This is with the December release. Thanks, Scott Ritchie

2 1

Re: PATCH: revive FreeBSD support
by Alexandre Julliard Dec. 14, 2004

Dec. 14, 2004

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > --- dlls/ntdll/virtual.c 11 Oct 2004 20:59:06 -0000 1.41 > +++ dlls/ntdll/virtual.c 3 Dec 2004 04:06:42 -0000 > @@ -119,6 +119,12 @@ static CRITICAL_SECTION csVirtual = { &c > /* Note: these are Windows limits, you cannot change them. */ > # define ADDRESS_SPACE_LIMIT ((void *)0xc0000000) /* top of the total available address space */ > # define USER_SPACE_LIMIT ((void *)0x80000000) /* top of the user address space */ > +# ifdef __FreeBSD__ > +# define LOW_SPACE_LIMIT ((void *)0x110000) /* lower address space limit */ > +# else > +# define LOW_SPACE_LIMIT NULL > +# endif > + > #else > static UINT page_shift; > static UINT page_mask; > @@ -600,7 +606,7 @@ static NTSTATUS map_view( struct file_vi > > for (;;) > { > - if ((ptr = wine_anon_mmap( NULL, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) > + if ((ptr = wine_anon_mmap( LOW_SPACE_LIMIT, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) Looks OK, but this is a job for wine_anon_mmap, it's supposed to abstract these sorts of platform dependencies so that the callers don't have to worry about it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Includes: x11drv
by Rémi Assailly Dec. 14, 2004

Dec. 14, 2004

Jon Griffiths wrote : >Hi, > >x11drv: 8 includes removed. > >Cheers, >Jon > > +dlls/x11drv/text.c dlls/x11drv/window.c dlls/x11drv/winpos.c > dlls/x11drv/x11ddraw.c > Remove uneeded headers to reduce uneeded rebuilds. > > Hi Jon, As I am working on x11drv I can tell you some things : win.h is declared in x11drv.h so if you want to remove it, remove it from all files. But I think it is not a good idea : win.h is one of the header files which need to be moved so I think it is better to keep #include "win.h" where it is needed. It will be easier to find files which need definitions in win.h. For example you removed win.h from window.c which use the structure WND. I also noticed that you removed wingdi.h from x11ddraw.c. wingdi.h is declared in gdi.h which is a header file which need to be moved too ! So when we get rid of gdi.h we'll must redeclare wingdi.h in x11ddraw.c Regards Rémi

1 0

Re: Stubs in PE build
by Alexandre Julliard Dec. 14, 2004

Dec. 14, 2004

Ge van Geldorp <gvg(a)reactos.com> writes: > Send for review to wine-devel: http://www.winehq.org/hypermail/wine-devel/2004/11/0658.html (no comments) > Submitted to wine-patch: http://www.winehq.org/hypermail/wine-patches/2004/11/0327.html > Resubmitting against current CVS > > Changelog: > Ge van Geldorp <gvg(a)reactos.com> > - Generate and export stubs specified in .spec files for PE builds I don't think we want to add a special mode just for stubs; they should really be replaced by proper functions (even if the functions are stubs themselves, at least they can print the parameters and try to return something meaningful instead of killing the app). You can view the lack of stubs support on PE as an encouragement to help us remove them from the spec files ;-) -- Alexandre Julliard julliard(a)winehq.org

7 13

Re: [AppDB] Remove borders=0 from img
by tony_lambregts＠telusplanet.net Dec. 14, 2004

Dec. 14, 2004

Paul van Schayck wrote: > Ok, since we have img{border: 0;} in our stylesheet we can now remove > border=0 from all img elements. > > Changelog: > Remove border=0 from img tags > > A patch would be nice.. ;-) -- Tony Lambregts

1 0

"Debugging" a password dialog
by David Gümbel Dec. 14, 2004

Dec. 14, 2004

Hi everybody, I am trying to get an application to run under Wine that requires a login with a username and a password. The program runs all fine, however I can't login with data that should work (and AFAIK works under Windows). Having entered the password, in the corresponding part of the dialog I only see "*****" (which is correct). However, when I change focus to some other part of that dialog afterwards, the password field shows "*************" (way more asterisks than before). The previous (i.e. correct) length of ****s is restored when setting the focus back onto the password field. I have reason to believe that the password I entered is not correctly passed on to the login procedure of the program. However, I am sort of badly lacking a nice idea how to efficiently debug this thingy and verify (falsify ;) that I'm right. So, does anybody have an idea? Bye, David

5 7

wineprefixcreate and config file
by Raul Dias Dec. 14, 2004

Dec. 14, 2004

Hi, Shouldn't tools/wineprefixcreate copy a sample config file? Right now it does all the job to create a standalone wine environment, but with no config. I would suggest copying documentation/samples/config to tools/config, installing it at $(SRCDIR) and them just copying it during wineprefixcreate call. I can do that if no one disagrees with the change. Some rpms in the sourceforge does not even have the sample config file in it. -- Raul Dias

2 1

Dodgy NetBSD code in dlls/kernel/cpu.c?
by Jon Griffiths Dec. 14, 2004

Dec. 14, 2004

Hi, in dlls/kernel/cpu.c, around line 430, is the following code for NetBSD: { int mib[2]; int value[2]; ... if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) if (value) PF[PF_FLOATING_POINT_EMULATED] = FALSE; else PF[PF_FLOATING_POINT_EMULATED] = TRUE; This looks dodgy, the "if (value)" test will always be true. I gather it should be "if (value[0])" or "if (value)[1]", but I'm no NetBSD guru. Also, there should be not need to set values to FALSE, since the flag array is cleared to 0 at the start of this function. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Visual studio 6 build fix.
by Rein Klazes Dec. 14, 2004

Dec. 14, 2004

Hi, MS Visual C++ v6, when invoking the compiler and other build tools does the following: create anonymous pipe; duplicate the pipes write handle; open's the file NUL calls CreateProcess starting vcspawn.exe with: startup info iohandles set to the 3 handles obtained above; the startup info flag STARTF_USESTDHANDLES set; create flag CREATE_NEW_CONSOLE set. the parent process reads from the pipe, and analyses the compiler and other messages that are obtained that way. Wine's console startup code is not really expecting this and insists on creating new stdio handles instead of inheriting them. The attached patch makes this work properly. Changelog: server : process.c dlls/kernel : console.c A starting process must obey the STARTF_USESTDHANDLES flag, even it is starting a new console. Rein. -- Rein Klazes rklazes(a)xs4all.nl

3 5