December 2004 - Wine-Devel - list.winehq.org

Re: free allocated buffers
by Dmitry Timoshkov Dec. 28, 2004

Dec. 28, 2004

"Mike McCormack" <mike(a)codeweavers.com> wrote: > Index: dlls/msi/action.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/action.c,v > retrieving revision 1.55 > diff -u -r1.55 action.c > --- dlls/msi/action.c 27 Dec 2004 19:12:35 -0000 1.55 > +++ dlls/msi/action.c 28 Dec 2004 06:47:04 -0000 > @@ -423,6 +423,59 @@ > } > } > > +/* Called when the package is being closed */ > +extern void ACTION_free_package_structures( MSIPACKAGE* package) > +{ > + INT i; The "extern" above should be removed. -- Dmitry.

1 0

Re: clean-up
by Chris Morgan Dec. 28, 2004

Dec. 28, 2004

Can you post a new version with the fixes that people replied with? I think the rest of the patch looks good. Chris On Thursday 23 December 2004 4:38 am, Eric Blade wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. > > > > > > __________________________________ > Do you Yahoo!? > Send a seasonal email greeting and help others. Do good. > http://celebrity.mail.yahoo.com

1 0

Re: clean-up
by Paul van Schayck Dec. 27, 2004

Dec. 27, 2004

Hey Eric, On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <ekdikeo4(a)yahoo.com> wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. What's this supposed to do: if(!$tempResult) { - echo "$query \n"; + echo "$query < >\n"; echo "An error occurred: ".mysql_error().""; exit; } @@ -68,7 +68,7 @@ if(debugging()) { echo $query; - echo " "; + echo "< >< >"; } And: -if(!loggedin()) +if(!loggedin() || (!havepriv("admin")) Shouldn't this be if(!loggedin() AND (!havepriv("admin")) Rest looks good. Kind regards, Paul

3 2

public domain code from lkcl
by Brian Vincent Dec. 27, 2004

Dec. 27, 2004

I'm not sure if this is useful to anyone, but I thought I remembered licensing being an issue with this once before: http://www.advogato.org/article/814.html "I really really AM relinquishing all copyright of all Samba-related source code that i have ever written, and am placing all that code into the Public Domain." "Specifically, but not limited to, that includes the code in samba which made its way into nmbd (dating right back to 1.9.15.p6 and before, and also including the nmbd_multiworkgroup version), all modifications of smbd that made their way into versions of 1.9.15 and up, all versions known as samba_ntdom _and_ Samba TNG, the code that i cut/paste over to FreeDCE to integrate a NamedPipe Interface plugin and also the FreeDCE NTLMSSP authentication plugin i worked on." -Brian

1 0

WINEPS and AFM
by Vitaly Lipatov Dec. 27, 2004

Dec. 27, 2004

There is a strange code in dlls/wineps/init.c file: if(!pi->Fonts) { MESSAGE("To use WINEPS you need to install some AFM files.\n"); return FALSE; } It returns FALSE if we have not any fonts described in PPD file (buildin printer). Will I remove this section at all? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

safedisc update
by Ivan Leo Puoti Dec. 26, 2004

Dec. 26, 2004

Hello geeks, I've got safedisc and ntoskrnl to load, unfortunately safedisc throws an exception as soon as it starts, so I'll be learning x86 assembly (cool!) soon to try and work this out. I've got ntoskrnl with all the correct prototypes for safedisc, and I've added some definitions to our include/winternl.h so ntoskrnl can build. Unfortunately quite a few structs are needed to compile one of the functions (IofCompleteRequest), so as I don't have time to add them right now it's commented out. These patches are strictly work in progress, but as I'll be away for a few days I'm posting them here just in case someone wants to play with them, I would also like to know if I'm adding the definitions to the winternl.h stuct correctly (For example, is it OK to have all the structs for ntoskrnl in the same place?). If anyone feels the temptation to fix the header so IofCompleteRequest compiles, please go ahead and do it. Comments/suggestions/whatever highly welcome. http://spazioinwind.libero.it/nonsolomicrosoft/header.diff http://spazioinwind.libero.it/nonsolomicrosoft/ntoskrnl.diff Ivan.

1 0

Re: AppDB update (refactoring and new ideas)
by Paul van Schayck Dec. 26, 2004

Dec. 26, 2004

Hey, On Sat, 18 Dec 2004 23:53:34 +0100, Jonathan Ernst <Jonathan(a)ernstfamily.ch> wrote: > I think we shouldn't have more than two images (one screenshot and one > thumbnail) per screenshot (having to click on a thumbnail to get a > medium sized screenshot and having an extra link to get an even bigger > screenshot is not user friendly). However you are right 1600x1400 shots > are maybe overkill so we should define two new constants in the config: It's done. It's doing exactly this. Running examples with source and the source of the class itself can be found here: http://meosource.com/firefox/wine Class is just doing image handeling and could be used right away in for example lostwages. If there are no comments I'll submit a patch and we can start using it. Paul

1 0

Re: user32: stub implementations for WINNLS* functions
by Dmitry Timoshkov Dec. 26, 2004

Dec. 26, 2004

"Diego 'Flameeyes' PettenР" <flameeyes(a)users.berlios.de> wrote: > diff -Npaur wine-orig/dlls/user/winnls.c wine/dlls/user/winnls.c > --- wine-orig/dlls/user/winnls.c 1970-01-01 01:00:00.000000000 +0100 > +++ wine/dlls/user/winnls.c 2004-12-24 17:21:24.566402048 +0100 ... > +UINT WINAPI WINNLSGetIMEHotkey(HWND hUnknown1) ... > +BOOL WINAPI WINNLSEnableIME(HWND hUnknown1, BOOL bUnknown2) ... > +BOOL WINAPI WINNLSGetEnableStatus(HWND hUnknown1) Since these APIs are IME related it would be more natural to name the file ime.c. > diff -Npaur wine-orig/include/winnls.h wine/include/winnls.h > --- wine-orig/include/winnls.h 2004-12-24 16:11:18.499482264 +0100 > +++ wine/include/winnls.h 2004-12-24 15:49:59.905643096 +0100 > @@ -757,6 +757,11 @@ BOOL WINAPI SetThreadLocale(LCID) > BOOL WINAPI SetUserGeoID(GEOID); > INT WINAPI WideCharToMultiByte(UINT,DWORD,LPCWSTR,INT,LPSTR,INT,LPCSTR,LPBOOL); > > +UINT WINAPI WINNLSGetIMEHotkey(HWND); > +BOOL WINAPI WINNLSEnableIME(HWND, BOOL); > +BOOL WINAPI WINNLSGetEnableStatus(HWND); Platform SDK has these APIs in winnls32.h file and marks them as old NT 3.x compatible. -- Dmitry.

2 4

Re: user32: stub implementations for WINNLS* functions
by Diego 'Flameeyes' Pettenò Dec. 26, 2004

Dec. 26, 2004

On Sunday 26 December 2004 01:57, Mike Hearn wrote: > They were commented out, which implies some software does a GetProcAddress > on them. Adding these sorts of stubs can break apps: have you found a > program or DLL that actually needs them? Yu Gi Oh Power of Chaos refuses to execute without them. It also seems not to call them, at least not before crash for other reasons. I thought that the spec-stubs was the ones which breaks things, for this I tried to have implementation-stubs. Regards, -- Diego "Flameeyes" Pettenò flameeyes(a)users.berlios.de - http://flameeyes.web.ctonet.it/

1 0

Determining the color depth of X?
by d13f00l Dec. 25, 2004

Dec. 25, 2004

Hey. I've been trying to iron out a couple bugs running some programs in wine. Running ZSNES reports that ZSNES cannot run in 24 bit depth mode. I'm also running an old game that uses dibs, I took a profiler to wine. We repeatedly call convert_888_to_0888_asis on a surface per blit. The game determines the color depth by what depth you're running windows at. Basicaly, where/how does wine determine your bit depth? Isn't 24 actually 3 significacant bytes + a worthless one in X? XRGB. I didn't see any code determining the bit depth trying to follow what happens when you CreateCompatibleDC(0). Anyone have any ideas? This could be potential for a nice speedup. Thanks. -Dylan

1 0