December 2004 - Wine-Devel - list.winehq.org

Re: AppDB TODO update: Templates
by Chris Morgan Dec. 22, 2004

Dec. 22, 2004

Cool, thanks for claiming this so we don't have people stepping on each others toes. Would you mind showing a little bit of what you planned on changing? It would be nice to have agreement that this was the direction we wanted to go before a big patch was submitted. Chris > > From: Stefan Pflüger <stefan(a)homepage4us.de> > Date: 2004/12/22 Wed PM 01:05:06 EST > To: wine-devel(a)winehq.org > CC: appdb(a)winehq.org > Subject: AppDB TODO update: Templates > > Hello, > > the last update added > > +# incorporate templates into appdb to simplify code, Jeremy says we can > +borrow from lostwages(winehq.org/cvsweb/lostwages) for this > > to the TODO file. > > At the moment, I'm trying to use AppDB for another project and I already > planned on implementing templates. > If nobody else wants to do the job, I'll go ahead and send you a patch > as soon as I'm finished. > > Stefan Pflüger > >

2 1

Writing an app. using existing dll
by Per Arnold Blåsmo Dec. 22, 2004

Dec. 22, 2004

Hi, I have a windows-dll and wants to make an app that runs on Linux under wine using this dll. I have the API description for this dll, but not the source code. I there any possibility for that using i.e. winelib and is there any howto to get me started. PerA.

2 1

AppDB TODO update: Templates
by Stefan Pflüger Dec. 22, 2004

Dec. 22, 2004

Hello, the last update added +# incorporate templates into appdb to simplify code, Jeremy says we can +borrow from lostwages(winehq.org/cvsweb/lostwages) for this to the TODO file. At the moment, I'm trying to use AppDB for another project and I already planned on implementing templates. If nobody else wants to do the job, I'll go ahead and send you a patch as soon as I'm finished. Stefan Pflüger

2 1

Re: Implement DceErrorInqText
by Dmitry Timoshkov Dec. 22, 2004

Dec. 22, 2004

"Bill Medland" <billmedland(a)mercuryspeed.com> wrote: > +RPC_STATUS RPC_ENTRY DceErrorInqTextW (unsigned long e, unsigned short *b) > +{ > + DWORD count; > + if (acceptable_rpc_code (e)) It would be much more natural to make FormatMessageW to decide whether a passed error code is valid or not, i.e. if it exists in the system message table. > + { > + count = FormatMessageW (FORMAT_MESSAGE_FROM_SYSTEM | > + FORMAT_MESSAGE_IGNORE_INSERTS, > + NULL, e, 0, b, /* I don't know!!! */ 65535, NULL); 256 (or 1024) is a reasonable margin I believe, at least messages in Wine are much shorter of even 256. > + } > + else > + count = 0; > + if (!count) > + { > + MultiByteToWideChar(CP_ACP, 0, cszInvalidCode, -1, b, 65535 /* ??? */); A message about invalid code should be localizable as well, so it should be either loaded by LoadString or even by FormatMessage for consistency IMO. winerror.h from PlatformSDK has the following definition which matches your error text ("The error specified is not a valid Windows RPC error code.\r\n"): // // MessageId: RPC_S_NOT_RPC_ERROR // // MessageText: // // The error specified is not a valid Windows RPC error code. // #define RPC_S_NOT_RPC_ERROR 1823L -- Dmitry.

3 5

Re: wine/dlls/cabinet cabextract.c
by Andreas Mohr Dec. 22, 2004

Dec. 22, 2004

Hi, On Wed, Dec 22, 2004 at 11:11:32AM -0600, Alexandre Julliard wrote: > ChangeSet ID: 14986 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/12/22 11:11:32 > > Modified files: > dlls/cabinet : cabextract.c > > Log message: > Revert previous patch, that's not a leak. Nice, but... ;-) [get ready to read my usual "not commented" complaint] Why isn't there a comment nearby? 8 weeks later Joe Janitor 2's source code analyzer tool will strike gold again, and then you'll have fun with another patch "correcting" things that turn(ed) out shouldn't be corrected... Andreas Mohr

1 0

Re: Getting rid of async.h
by Alexandre Julliard Dec. 22, 2004

Dec. 22, 2004

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > - we maintain on the client side whether there's still some pending > async op on the current thread (this is needed in optimizing some wait > operations) That part doesn't look right, you clear the flag when removing the last async operation on an fd, but this bears no relation to the number of async operations in the current thread. It seems to me this could instead be done entirely on the client side, since we need to allocate and free an async structure for each operation we should be able to maintain a counter of them on the client side. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll / kernel32: #52
by Alexandre Julliard Dec. 22, 2004

Dec. 22, 2004

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > +/* FIXME: 0xFFFFFFFF is our shortcut for global table > + * we could also tweak init_atom_table request to get a handle to the > + * global table in wineserver > + */ > +#define GLOBAL_ATOM_TABLE ((void*)0xFFFFFFFF) Yes, you need to get a valid handle here, 0xffffffff is the current process pseudo-handle and we don't want to overload that meaning. Also your local table allocation is not thread-safe, it can potentially leak an atom table. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: test.h: problem with ok's argument evaluation order
by Alexandre Julliard Dec. 22, 2004

Dec. 22, 2004

Rein Klazes <wijn(a)wanadoo.nl> writes: > --- wine/include/wine/test.h 2004-05-04 08:10:39.000000000 +0200 > +++ mywine/include/wine/test.h 2004-12-20 15:29:39.000000000 +0100 > @@ -53,7 +53,8 @@ extern void winetest_trace( const char * > > #endif /* __GNUC__ */ > > -#define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok > +#define winetest_ok_(cond, args...) (cond) ? winetest_ok(TRUE, args) : winetest_ok(FALSE, args) > +#define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok_ Unfortunately varargs macros are not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Merging the AppDB Documentation and the WineHQ documentation pages
by Scott Ritchie Dec. 21, 2004

Dec. 21, 2004

Mike said this about my new "helping applications work" page: >Looks great! I'd suggest putting it in the Documentation section, and >then linking to it from the appdb page. This then prompted me to wonder "which documentation section?" This is kind of confusing: I click on documentation at the main wine page, and I get some useful stuff. I wander into the AppDB page, click on documentation, and I get some different stuff. Methinks we should just dump them all into one page. This has the added benefit of informing people without the wherewithal to click "Applications" that there is, in fact, an AppDB. On another note, it looks like the AppDB documentation is in PHP, rather than the normal template format like the rest of the website. Is this a good idea? Thanks, Scott Ritchie

1 0

Re: wine/dlls/cabinet cabextract.c
by Mike McCormack Dec. 21, 2004

Dec. 21, 2004

This patch breaks IE6 install. Mike Alexandre Julliard wrote: > ChangeSet ID: 14647 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/12/02 11:55:41 > > Modified files: > dlls/cabinet : cabextract.c > > Log message: > James Hawkins <truiken(a)gmail.com> > Fix cabextract memory leak. > > Patch: http://cvs.winehq.org/patch.py?id=14647 > > Old revision New revision Changes Path > 1.15 1.16 +2 -0 wine/dlls/cabinet/cabextract.c

1 0