March 2004 - Wine-Devel - list.winehq.org

Cards.dll improvements
by Sam March 28, 2004

March 28, 2004

> On Sat, 27 Mar 2004 14:22:44 -0500, Sam wrote: > > This patch implements invisibleghost, deckx and decko > > drawing modes, and improves ghost drawing mode. > > It also includes graphics needed by these drawing modes. > > Hi, I'm sure you're doing the right thing but given the number of dodgy > attempts we've had at this DLL could you please state where you're getting > the artwork from? If you have already said this please forgive me, I don't > read everything on wine-devel :) Hi, for the artwork sent earlier, I already mentioned the source: http://www.jfitz.com/cards/index.html. For the three card images sent in the latest patch, I made them. > thanks -mike Regards, Sami Nopanen, xasmx(a)optonline.net

1 0

[Fwd: i810 audio fixes 1/2]
by Robert Reif March 28, 2004

March 28, 2004

sorry, forgot to reply all.

2 4

Re: [Fwd: i810 audio fixes 1/2]
by Ivan Leo Murray-Smith March 28, 2004

March 28, 2004

> Argh, this is confusing. How do you know what the next generation > of Windows (longhorn?!) will do in this regard, has it been published > anywhere? Yes, first longhorn, after that, blackcomb. You can ask Microsoft for a License, from the http://www.windowsbeta.microsoft.com web site You can also get it few with a MSDN universal subscription, that costs various thousands of dollars a year. lots of info about it at http://www.msdn.com/longhorn/ Ivan.

1 0

WINE on bug isolation monitor
by Charlie Lopez March 28, 2004

March 28, 2004

Good Afternoon, I will like to congratulate you on such a fine job with WINE. I love this program. I was just able to run quicktime on my RH9 machine!!! I wanted to bring to your attention a idea I had. I installed on my machine a Bug Isolation Monitor by Berkeley University (http://www.cs.berkeley.edu/~liblit/sampler/learn-more/) Currently it tracks all bugs and errors with Ximian Evolution, GAIM Gnumeric, Nautilus and Rhythmbox. I though that perhaps WINE could get some kind of update software which will automatically send application feedback to your server. I will be willing to test this feature. Let me know what you think. Regards, Juan Lopez WebIT @email The information being send thru this e-mail is intended only for the person, persons and/or group/entity to which it is addressed to and may contain confidential and/or privileged content. Any retransmission, review, propagation or other use of this information by people or entities other than the intended recipient or recipients is prohibited and may be unlawful. If you received this email in error, please contact the sender and delete the email from any computer in which it was received.

2 1

Re: unicodify CreateMetaFile
by Dmitry Timoshkov March 28, 2004

March 28, 2004

"Mike McCormack" <mike(a)codeweavers.com> wrote: > -HDC WINAPI CreateMetaFileW(LPCWSTR filename) > +HDC WINAPI CreateMetaFileA(LPCSTR filename) > { > - LPSTR filenameA; > + LPWSTR filenameW; > DWORD len; > HDC hReturnDC; > > - if (!filename) return CreateMetaFileA(NULL); > + if (!filename) return CreateMetaFileW(NULL); > > - len = WideCharToMultiByte( CP_ACP, 0, filename, -1, NULL, 0, NULL, NULL ); > - filenameA = HeapAlloc( GetProcessHeap(), 0, len ); > - WideCharToMultiByte( CP_ACP, 0, filename, -1, filenameA, len, NULL, NULL ); > + len = MultiByteToWideChar( CP_ACP, 0, filename, -1, NULL, 0 ); > + filenameW = HeapAlloc( GetProcessHeap(), 0, len ); > + MultiByteToWideChar( CP_ACP, 0, filename, -1, filenameW, len ); MultiByteToWideChar returns number of characters, not bytes. You have to allocate len * sizeof(WCHAR) bytes. -- Dmitry.

1 0

Appdb - Vendor list for user and vendor matching for admin
by Chris Morgan March 27, 2004

March 27, 2004

This look alright? I'm still trying to learn php ;-) account.php, appsubmit.php, admin/adminAppQueue.php Chris Morgan <cmorgan(a)alum.wpi.edu> Add a dropdown list of vendors to the app submit page. Automatch the dropdown vendor selection on the admin side of there is an exact or partial name match. Clear out the vendor field if a match is found. Display username when logging in to the db. Chris

1 1

CVS release of wine's Bugzilla?
by tony_lambregts＠telusplanet.net March 27, 2004

March 27, 2004

Judging from the success of releasing the source for the main website and the AppDB, I propose that we also release the source for our bugzilla database via CVS. -- Tony Lambregts

1 0

winetests.exe
by Jakob Eriksson March 27, 2004

March 27, 2004

Mostly for fun I compiled another winetests.exe from Wine CVS 2004-03-28. http://vmlinux.org/jakov/Wine/ http://vmlinux.org/jakov/Wine/regrtest.exe I am unpatiently waiting for the Windows Testing Service, but wanted to see how the tests have developed since January. :-) Try it out in Windows, not quite so many tests are failing. (Some tests are not included at all though.) -- regards, Jakob

1 0

Game Testing Update Wine-20040309
by Mike Kost March 27, 2004

March 27, 2004

I took a break for 20040213, but here's the latest edition of my testing efforts. Same rules still apply in my selection efforts: All games tested are freely available as demos or F/OSS games on the Internet and they don't work right. Since my last report: - Bugzilla bug #2011 on Austerlitz was closed - 2 patches were generated by Jason Edmeades - 3 Bugs Filed - - #2056 - Dominions II Demo Does Not Do Full Screen Correctly - - #2128 - Remote Assault Demo Fails To Run - - #2129 - Austerlitz Demo Generates Unhandled Exception Austerlitz Summary ------------------ http://www.breakawaygames.com/downloads/austerlitz_demo.exe With Jason's patches for bug #2011, Austerlitz runs but has revealed more bugs. There's a screen drawing/refresh error and it's possible to cause an unhandled exception. Full report here: http://www.tashcorp.net/Wine/Austerlitz/austerlitz-20040309.html Dominions II Summary -------------------- http://www.shrapnelgames.com/downloads/dominions2demo_install.exe Dominions II still has problems with full-screen mode where the KDE kicker bar is visible over the game and the mouse insistently returns to to the center of the screen when moved. Full report here: http://www.tashcorp.net/Wine/DominionsII/dominionsII-20040309.html Remote Assault Summary ---------------------- http://www.shrapnelgames.com/downloads/rad50.exe Remote Assault fails to run. I believe this is a downgrade of it's previous position. I owe a +loaddll,+relay log to the bug report. Full report here: http://www.tashcorp.net/Wine/RemoteAssault/remoteassault-20040309.html The War Engine Summary ---------------------- http://www.shrapnelgames.com/downloads/TWEDemo.exe It hangs on execution and I havn't figured out where to start filing bugs. Hopefully I'll figure out something better to do with when the next version of Wine is released. Mike K

3 3

Re: wine/ server/trace.c server/request.h server/p ...
by Dimitrie O. Paun March 27, 2004

March 27, 2004

On March 26, 2004 8:48 pm, Alexandre Julliard wrote: > Use futimes() instead of utime() to implement SetFileTime, so that > it can be done on the client side. + if (atime) + { + sec = ((ULONGLONG)atime->dwHighDateTime << 32) | atime->dwLowDateTime; + sec = RtlLargeIntegerDivide( sec, 10000000, &nsec ); + tv[0].tv_sec = sec - SECS_1601_TO_1970; + tv[0].tv_usec = (UINT)nsec / 10; + } + if (mtime) + { + sec = ((ULONGLONG)mtime->dwHighDateTime << 32) | mtime->dwLowDateTime; + sec = RtlLargeIntegerDivide( sec, 10000000, &nsec ); + tv[0].tv_sec = sec - SECS_1601_TO_1970; + tv[0].tv_usec = (UINT)nsec / 10; + } ^^^^^ Shouldn't these be tv[1]? -- Dimi.

1 0

test - ignore
by hatky March 27, 2004

March 27, 2004

-- Hatky, Worshiper of wine (http://www.winehq.org/) Impossible is only an opinion.

1 0

test - ignore
by hatky March 27, 2004

March 27, 2004

-- Hatky, Worshiper of wine (http://www.winehq.org/) Impossible is only an opinion.

1 0

Re: shell32 patch 26
by Alexandre Julliard March 27, 2004

March 27, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > /* process the IDList */ > - if ((sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST) /*0x0c*/ > + if (sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) /* 0x0c: includes SEE_MASK_IDLIST */ If you only care about the MASK_IDLIST flag you should check just that flag, otherwise the test is confusing since the 0x08 flag doesn't mean anything by itself. -- Alexandre Julliard julliard(a)winehq.org

2 1

Using Unix path names
by Duane Clark March 26, 2004

March 26, 2004

After yesterdays CVS commits, I can no longer execute programs using a Unix path. > wine /c/Program\ Files/WinZip/WINZIP32 wine: cannot find '/c/Program Files/WinZip/WINZIP32' It has nothing to do with the space, either. > wine /c/downloads/xlViewer.exe wine: cannot find '/c/downloads/xlViewer.exe' It seems only dos paths work now. Is this a deliberate change, or is there some configuration change I missed?

2 1

RE:lostwages/ ./winehq_styles.css templates/en/fu ...
by tony_lambregts＠telusplanet.net March 26, 2004

March 26, 2004

This cvs commit screwed up Vincent Béron's name on lostwages/templates/en/todo_lists.template ( http://www.winehq.org/site/todo_lists ) http://www.winehq.org/hypermail/wine-cvs/2004/03/0411.html I cannot submit a patch for this right now so if someone wants to fix it... -- Tony Lambregts

1 0

Call for kernel patch testing
by Mike Hearn March 26, 2004

March 26, 2004

Hi guys, As part of the ongoing efforts to work nicely with execshield/prelink, the following kernel patch was developed (not by me I hasten to add): http://www.bitwagon.com/elfdiet/elfdiet.html However it needs testing so the kernel guys can be sure it'll not break stuff. If you are the type who runs their own kernel, please apply this patch and let us know the results! Everything should be fine, it's just a bugfix for the edge cases, but the elf loader is security critical so it needs widespread usage before it can be upstreamed. This was a public service announcement. thanks -mike

1 0

Get{Full|Long}PathNameA doesn't seems to be working
by Felipe W Damasio (Elipse Software) March 26, 2004

March 26, 2004

Greetings wine hackers, Our company used wine-20030115 for a while now, to be able to run our windows product on top of the GNU/Linux OS. But since we updated to the latest wine (ie wine-20040309), our path conversion is wrong. The relevant bit of our .config looks as follows: [Drive F] "Path" = "%HOME%" "Type" = "network" Which was automatically generated by wineinstall, btw. Anyway, we used to use GetLongPathNameA to get the unix to window name conversion right (which was inspired by the winepath program). But in this latest version, GetLongPathNameA was replaced by GetFullPathNameA (in winepath)..but neither seems to work right. Please consider the attached code as an example. It retrieves the home directory of the current user, and tries to look up the windows version of it. In my case, I got: Unix format Home Directory: /home/felipewd GetFullPathNameA returned: F:\home\felipewd GetLongPathNameA returned: And the expected return was "F:\" in the windows version (GetLongPathNameA didn't even returned an entry)...am I right? So, if there's any more tests you'd like me to do, or if there's anything I can do to help fixing this, please let me know. Cheers, Felipe

2 2

Re: shell32 patch 24
by Dimitrie O. Paun March 25, 2004

March 25, 2004

On Thu, 25 Mar 2004, Martin Fuchs wrote: > OK, now the patch including the "return S_FALSE". :-) This is why small patches are better than large ones :) -- Dimi.

3 2

Re: renewed: wine/dlls/d3d8/device.c cleanup-3
by Raphael March 25, 2004

March 25, 2004

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi On Thursday 25 March 2004 21:47, hatky wrote: > Generate ERRs for implementations that exists only > with OpenGL extentions or versions that were not found > at compile time, other wise is is presnted as just > unimplemented > > > ChangeLog: > Â Â Ofir Petruska <hatky(a)users.sf.net> > Errs for implemented with an unavailable OpenGL ver > #else >- case D3DTADDRESS_MIRROR: /* Unsupported in OpenGL pre-1.4 > > */ >+ case D3DTADDRESS_MIRROR: ERR("Implemented with GL1.4 or an ARB >extention only\n"); /* Unsupported in OpenGL pre-1.4 */ > #endif Why you want to put an ERR here ? for me it should be a WARN but only for debug purpose. D3D games normally only use what we declare to support (using GetDeviceCaps) so i we say not supported ... #if defined(GL_VERSION_1_3) pCaps->TextureAddressCaps |= D3DPTADDRESSCAPS_MIRROR; #endif > +#else > + ERR("Implemented only with GL_EXT_paletted_texture defined\n"); > #endif Well, paletted textures are not supported by many cards and i don't think users will like scrolling of non-errors traces in some games (it can be a warning for devs but not an error). On windows you can call SetCurrentTexturePalette if you card don't support it (the function should return with an error) >+#else >+ ERR("Ipmlemented only for OpenGL 1.3 and up\n"); > #endi Here it should be a FIXME. It must be implemented using GLXPixmaps for olders GLX versions (see the function comment) Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAY3qOp7NA3AmQTU4RAjQ0AJwNuhHeXKxnkDQ8I/7mn+ZyKdI13wCePyGt 7sS7J/45W6nMbG3CFD5jWfE= =QazV -----END PGP SIGNATURE-----

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky March 25, 2004

March 25, 2004

>Also it would be really nice to sort the dlls >alphabetically as there >is quite many of them. Sent patch to remove non win api. It already sorts by module name. -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/) Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

WineHQ: Of </quote> and punctuations
by Francois Gouget March 25, 2004

March 25, 2004

Ok, there's a problem with </quote> and punctuations. For instance in WWN 171 we have (see the 'Wine Tech Meeting' section): --- cut here --- mentioned ReactOS had one. He went on to discuss some future plans, My goal if the ReactOS guys can get more than winhello working is to have WINEs shell32 and comctl32 running for Linux world . All in all the meeting was quite successful and a lot of people were glad to be able to converse in real time about a lot of --- cut here --- See how we have a '.' all alone on a line? Check there for the original: http://www.winehq.org/?issue=171#Wine%20Tech%20Meeting The reason why we have this unsightly sight is that on the WineHQ web site '<quote>' creates a new indented paragraph so that any punctuation that follows '</quote>' ends up being on the next line, either all alone or just before the next sentence which is just as strange (see WWN 177 for an example). It's interesting to note that this problem does not occur in the Wine Kernel Cousin. That's because in the Kernel Cousin there are both inline quotes and 'standalone' quotes. So in the Kernel Cousin the above is an inline quote which gives us: --- cut here --- dsp2make utility would be a useful addition and Steven mentioned ReactOS had one. He went on to discuss some future plans, " My goal if the ReactOS guys can get more then winhello working is to have WINEs shell32 and comctl32 running for Linux world" . --- cut here --- So there are two ways (at least) to fix the issue: systematically move punctuations to before the </quote> tag (I can send a patch for that), or change the <quote> tag to behave like in the Wine Kernel Cousin. What's the preferred solution? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

2 2

Re: To Do A.11 - Integrate API status into WineHQ
by hatky March 25, 2004

March 25, 2004

> does the script filter out the Wine-only dlls? Otherwise the global > statistics will be off. No, it dosen't currently: 1. Should we fillter them? a. Totaly b. Just from the Total c. Not at all > > Specifically, the following dlls should be ignored: > > ole2prox ? > ole2thk ? > psapi ? > twain_32 ? > wine* > x11drv > > I'm not sure anymore for the dlls marked with a question mark. I need a final list becouse I don't know what is wine only and what not... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/) Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

2 1

ALSA on i810 audio
by Mike Hearn March 25, 2004

March 25, 2004

Hi, I'd like to improve the ALSA driver to work properly on my i810 soundcard. At the moment it just gives errors about not being able to resample. Eric - did you have any plans for the driver? Do you know of any problems? I already fixed one thing, the default pcm should be "default" not "hw" thanks -mike

2 1

Re: lostwages/include config.php
by Ferenc Wagner March 25, 2004

March 25, 2004

Jeremy Newman <jnewman(a)winehq.org> writes: > Log message: > s/Forums/Mailing Lists/ Just two words: Thank You! -- Feri.

2 1

redirecting stdout with WineLib
by Ferenc Wagner March 25, 2004

March 25, 2004

Hello, Hacking away on winetest I encountered the following problem: under Windows and Wine (running cross compiled binaries) it's possible to redirect the stdout of a child process with CreateProcess using STARTF_USESTDHANDLES. However, if I CreateProcess an .exe.so from the WineLib version, the redirection is ignored. The create_process function in process.c acts on this option in both cases, but I didn't investigate further. Does anybody have an idea why this happens? -- Feri.

5 7

Re: ALSA on i810 audio
by chmorgan＠charter.net March 25, 2004

March 25, 2004

I've been working to debug one users problem with an i810 card. (n wodOpen() we try to set the format of the audio, 16 or 8bit. I believe the i810 only supports 16bit so we return MMSYS_ERR. I *think* we should be returning WAVERR_BADFORMAT instead so wine can try another format that may work. At least thats what I did with the jack driver for sample rates and formats that don't match the server as the jack server doesn't perform any of that conversion. Perhaps you want to return the same thing in your case? Chris > > From: Mike Hearn <mike(a)navi.cx> > Date: 2004/03/25 Thu PM 03:05:32 EST > To: wine-devel(a)winehq.com > Subject: ALSA on i810 audio > > Hi, > > I'd like to improve the ALSA driver to work properly on my i810 soundcard. > At the moment it just gives errors about not being able to resample. > > Eric - did you have any plans for the driver? Do you know of any problems? > I already fixed one thing, the default pcm should be "default" not "hw" > > thanks -mike > > > >

1 0

Re: Sorry. My first contribution. You can ignore this patch if u will.
by Alexandre Julliard March 25, 2004

March 25, 2004

Urbez Santana <urbez(a)linuxupc.upc.es> writes: > 1. Make possible instal.lation programs win16 bits working. (Not finished) > *I have changed the protocol to obtain the Teb & the Peb of another process > in kernel32. You don't want to do that. We don't support low-level Win9x dlls anymore. > 2. Make possible all programs of Microsoft Developer Studio works. > *Spy++: works with external windows processes. I have changed the protocol > now to access with ReadProcessMemory to another window process information. This is wrong, it must go through server calls (and it mostly does already), you can't directly access system structures in other processes. > 3. Make possible use shell32.dll.so and shlwapi.dll builtin, and no more use > of native dlls. I need more time, for this, i have great work with shlwapi, > dissassemble and debug with the native dll, and interpret the assembler code > to obtain FDSA functions and another shlwapi functions that needed by HH.EXE You can't base your implementation on disassembled Microsoft code. I'm afraid we can't use your code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Tools] API status - fix module name size
by Ferenc Wagner March 25, 2004

March 25, 2004

Seems like you forgot the patch. -- Feri.

1 0

Re: [Tools] API status - fix module name size
by Jeremy Newman March 25, 2004

March 25, 2004

Nothing was attached. Please send the patch. Thanks! On Thu, 2004-03-25 at 06:51, hatky wrote: > Changelog: > Ofir Petruska <hatky(a)users.sf.net>: > Fix the module name cut to 5 chars bug - > Get a MODULE_LENGTH constant and pad Total to it -- Jeremy Newman <jnewman(a)winehq.org>

1 0

Re: NetBios
by Juan Lang March 25, 2004

March 25, 2004

Flyker wrote: > Does wine NetBios can work with remote windows > application that use NetBios ? In limited circumstances, yes: - it supports only NetBIOS-over-TCPIP (NBT), not nbipx or netbeui - it only supports client sessions: it can't act as a NetBIOS server, nor does it support datagrams --Juan __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Re: Integrating Wine's AppDB with Bugzilla
by hatky March 25, 2004

March 25, 2004

> I have had over two years to mull this over and this using the URL field is > the easiest solution. this requires the following > > 1. A link to the App from the bug in bugzilla (bug_file_loc (URL) = > http://appdb.winehq.org/appview.php?appId=ID) > > 2. A link to the bugs for the app in the appdb > (http://bugs.winehq.org/buglist.cgi? > product=Wine&bug_file_loc_type=substring&bug_file_loc=....) > > 3. A way to put the link into the bug when it is submitted. > > 4. someone has to link the old bugs (grunt work) > > I would like help to do items 2 and 3 You mean something like this: -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/) Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

2 1

Broken documentation links
by Vincent Béron March 25, 2004

March 25, 2004

Hi, Rafael Wolf reported to me that the links on http://www.winehq.org/site/documentation for the Wine User Guide in PDF and PostScript format are broken. Vincent

2 1

Re: winetest: run with -mwindows
by Jakob Eriksson March 25, 2004

March 25, 2004

Hmm... what is the problem with GUI and command line interface. I don't think there should be any particalur problems, what happens? Ferenc Wagner wrote: >Okay, it wasn't true, actually. So, this patch solves the >immediate problem, but is not the full solution. How do you >write a program which has both GUI and CUI? Is there any >way to use standard IO in a program compiled with -mwindows >but run from a console? > >ChangeLog: > Don't expect stdout be usable after exchanging file > descriptors under it. > >Index: main.c >=================================================================== >RCS file: /home/wine/wine/programs/winetest/main.c,v >retrieving revision 1.7 >diff -u -r1.7 main.c >--- main.c 20 Mar 2004 19:21:39 -0000 1.7 >+++ main.c 24 Mar 2004 13:30:26 -0000 >@@ -337,8 +337,6 @@ > SetErrorMode (SEM_FAILCRITICALERRORS); > > if (!(wineloader = getenv("WINELOADER"))) wineloader = "wine"; >- if (setvbuf (stdout, NULL, _IONBF, 0)) >- report (R_FATAL, "Can't unbuffer output."); > > tempdir = tempnam (0, "wct"); > if (!tempdir) >Index: util.c >=================================================================== >RCS file: /home/wine/wine/programs/winetest/util.c,v >retrieving revision 1.4 >diff -u -r1.4 util.c >--- util.c 19 Mar 2004 19:15:23 -0000 1.4 >+++ util.c 24 Mar 2004 13:30:26 -0000 >@@ -19,6 +19,7 @@ > * > */ > #include <windows.h> >+#include <unistd.h> > #include <errno.h> > > #include "winetest.h" >@@ -39,26 +40,14 @@ > return p; > } > >-void xprintf (const char *fmt, ...) >-{ >- va_list ap; >- >- va_start (ap, fmt); >- if (vprintf (fmt, ap) < 0) >- report (R_FATAL, "Can't write logs: %d", errno); >- va_end (ap); >-} >- >-char *vstrmake (size_t *lenp, va_list ap) >+char *vstrfmtmake (size_t *lenp, const char *fmt, va_list ap) > { >- char *fmt; > size_t size = 1000; > char *p, *q; > int n; > > p = malloc (size); > if (!p) return NULL; >- fmt = va_arg (ap, char*); > while (1) { > n = vsnprintf (p, size, fmt, ap); > if (n < 0) size *= 2; /* Windows */ >@@ -75,6 +64,14 @@ > return p; > } > >+char *vstrmake (size_t *lenp, va_list ap) >+{ >+ const char *fmt; >+ >+ fmt = va_arg (ap, const char*); >+ return vstrfmtmake (lenp, fmt, ap); >+} >+ > char *strmake (size_t *lenp, ...) > { > va_list ap; >@@ -85,6 +82,26 @@ > if (!p) report (R_FATAL, "Out of memory."); > va_end (ap); > return p; >+} >+ >+void xprintf (const char *fmt, ...) >+{ >+ va_list ap; >+ size_t size; >+ ssize_t written; >+ char *buffer, *head; >+ >+ va_start (ap, fmt); >+ buffer = vstrfmtmake (&size, fmt, ap); >+ head = buffer; >+ va_end (ap); >+ while ((written = write (1, head, size)) != size) { >+ if (written == -1) >+ report (R_FATAL, "Can't write logs: %d", errno); >+ head += written; >+ size -= written; >+ } >+ free (buffer); > } > > char * > > >

3 5

To Do A.11 - Integrate API status into WineHQ
by hatky March 25, 2004

March 25, 2004

It looks complicated but it's all 3 mysql commands to get a complete table with whatever data you want from the winapi stats data in a nice table... Take the attached file (it just strips some text) , create user as mysql user that has a db called winapi with CREATE TEMPORARY TABLE and select rights then run: ./tools/winapi/winapi_extract --pseudo-stub-statistics --no-verbose --no-progress >winapi_stats.txt php winapi_stats.php > winapi_stats,dat mysql --execute=' CREATE TEMPORARY TABLE `winapi` ( `module` VARCHAR( 255 ) NOT NULL , `stubs` INT NOT NULL , `total_func` INT NOT NULL , `real_stub` INT NOT NULL , `psedo_stubs` INT NOT NULL , `forwards` INT NOT NULL , PRIMARY KEY ( `module` ) ); LOAD DATA LOCAL INFILE "winapi_stats,dat" REPLACE INTO TABLE winapi FIELDS TERMINATED BY "~" LINES TERMINATED BY "\n"; SELECT "Total" "Library", sum(total_func) "API Count", (sum(total_func) - sum(stubs)) / sum(total_func) *100 "% implemented", sum(stubs) "Total Stubs", sum(real_stub), sum(psedo_stubs) FROM winapi UNION ALL SELECT module "Library", total_func "API Count", ( total_func - stubs ) / total_func *100 "% implemented", stubs "Total Stubs", real_stub, psedo_stubs FROM winapi; ' -u user -D winapi -H >/lostwages/templates/en/winapi_stats.html comments? p.s. sorry for the yahoo and the linewrap mess my mail dosn't send latly... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/) Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

4 3

[PATCH] Small (visual) issue in generating html documentation
by pvriens＠xs4all.nl March 25, 2004

March 25, 2004

Hi, Just a small contribution. Hey, have to start somewhere. When doing a 'make htmlpages' the resulting index.html has no ',' between Q and R for the Index pages. Attached path should fix that. Cheers, Paul

1 0

NetBios
by flyker March 25, 2004

March 25, 2004

Does wine NetBios can work with remote windows application that use NetBios ?

1 0

Re: shell32 patch 24
by Alexandre Julliard March 24, 2004

March 24, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > + if (This->bDirty) > + return S_OK; > + > return NOERROR; S_OK and NOERROR mean the same thing, so this doesn't look quite right. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32 patch 23e
by Alexandre Julliard March 24, 2004

March 24, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > + /* Add double quotation marks unless we already have them (e.g.: "%1" %* for exefile) */ > + if (res != out && *(res - 1) == '"') > + { > + strcpyW(res, cmd); > + res += strlenW(cmd); > + } > + else > + { > + strcpyW(res, cmd); > + res += strlenW(cmd); > + } Shouldn't you be doing something different in the else branch? Otherwise that test doesn't seem very useful ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky March 24, 2004

March 24, 2004

>I'd rather there wasn't a DB. I know it saved time >and effort coding >wise to do it this way. Future changes will require >updates to the db, >and that can't be automated the way the current >scripts are. option2 crontab this: mysql -u user -D winapi -H >winapi_stats.html < test.sql now test.sql is a file that can be changed and the user is the only thing hardcoded in the crontab.... -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

2 1

lostwages: add my irc nick
by Kevin Koltzau March 24, 2004

March 24, 2004

Changelog Add my irc nick

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky March 24, 2004

March 24, 2004

On Wednesday 24 March 2004 22:19, you wrote: > On Wed, 24 Mar 2004, hatky wrote: > > It looks complicated but it's all 3 mysql commands to > > get a complete table > > with whatever data you want from the winapi stats data > > in a nice table... > > [...] > > > comments? > > Yeah, there's no need for a database. Right now Francois' > soluions works perfectly fine without a DB, please don't > use one. I say this is not acceptable, but is up to > laxdragon, he's the website maintainer. It uses DB only for creating the file as a parser becouse it's 3 lines of code instade of 30 line parsing and very very flexable, I talked to laxdragon, he has not problem with it, he is still reviewing it... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/) Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Missing WWN issues
by Francois Gouget March 24, 2004

March 24, 2004

Looking through the WINeHQ CVS I noticed that we are missing 4 WWN issues. Fortunately they seem to be available at the Wine Kernel Cousin web site... sort of. Would some kind soul volunteer for retrieving what can be retrieved? * WWN 88 and WWN 89 http://www.kerneltraffic.org/wine/wn20010314_88.html http://www.kerneltraffic.org/wine/wn20010315_89.html Unfortunately these two appear to be empty so there's not much to save. * WWN 90 http://www.kerneltraffic.org/wine/wn20010409_90.html Eric Pouech's call for a replacement. * WWN 91 http://www.kerneltraffic.org/wine/wn20010415_91.html Brian Vincent's first WWN. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

2 1

Re: winetest: add support for revision info
by Ferenc Wagner March 24, 2004

March 24, 2004

This patch goes somewhat against Dimi's. Instead of invoking cvs, it extracts the working revision info from the CVS/Entries files resulting in speedy operation. Thus I incorporated all the stuff into maketest, executing unconditionally. Hope it is still portable. ChangeLog: - Extract revision info from CVS/Entries. - #include "winetest.rc" into gui.rc. MinGW can't link in more than one resource files. - Enlarge chunk size of network transfer. Index: Makefile.in =================================================================== RCS file: /home/wine/wine/programs/winetest/Makefile.in,v retrieving revision 1.23 diff -u -r1.23 Makefile.in --- Makefile.in 20 Mar 2004 19:21:39 -0000 1.23 +++ Makefile.in 22 Mar 2004 23:03:43 -0000 @@ -1,4 +1,5 @@ TOPSRCDIR = @top_srcdir@ +export TOPSRCDIR TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ @@ -13,8 +14,7 @@ util.c RC_SRCS = \ - gui.rc \ - winetest.rc + gui.rc RC_BINSRC = gui.rc RC_BINARIES = wine.ico @@ -46,9 +46,6 @@ winetest.rc: maketest Makefile.in $(SRCDIR)/maketest $(TESTBINS) > $@ || ( $(RM) $@ && exit 1 ) - -revision.info: - (cd $(TOPSRCDIR); for file in dlls/*/tests/*.c; do rev=`cvs stat "$$file" | grep "Working" | awk '{print $$3}'`; echo "$$file:$$rev"; done) > $@ || ( $(RM) $@ && exit 1 ) winetest.res: $(TESTBINS) Index: gui.rc =================================================================== RCS file: /home/wine/wine/programs/winetest/gui.rc,v retrieving revision 1.2 diff -u -r1.2 gui.rc --- gui.rc 2 Mar 2004 20:56:35 -0000 1.2 +++ gui.rc 22 Mar 2004 23:03:43 -0000 @@ -21,6 +21,7 @@ #include <windows.h> #include <winres.h> #include "guires.h" +#include "winetest.rc" /* for the MinGW cross-compiler */ IDD_STATUS DIALOG 0, 0, 160, 140 STYLE WS_OVERLAPPEDWINDOW Index: main.c =================================================================== RCS file: /home/wine/wine/programs/winetest/main.c,v retrieving revision 1.7 diff -u -r1.7 main.c --- main.c 20 Mar 2004 19:21:39 -0000 1.7 +++ main.c 22 Mar 2004 23:03:43 -0000 @@ -140,7 +140,6 @@ } snprintf(buffer, sizeof(buffer), "dlls/%s/tests/%s.c", test, subtest); - fprintf(stderr, "file=%s\n", buffer); return buffer; } @@ -149,36 +148,35 @@ const struct rev_info* rev; for(rev = rev_infos; rev->file; rev++) { - fprintf(stderr, " ?{%s:%s)\n", rev->file, rev->rev); if (strcmp(rev->file, file) == 0) return rev->rev; } - return ""; + return "-"; } void extract_rev_infos () { char revinfo[256], *p; - int size = 0, i = 0, len; + int size = 0, i, len; HMODULE module = GetModuleHandle (NULL); for (i = 0; TRUE; i++) { if (i >= size) { size += 100; - rev_infos = xrealloc(rev_infos, size); + rev_infos = xrealloc (rev_infos, size * sizeof (*rev_infos)); } memset(rev_infos + i, 0, sizeof(rev_infos[i])); len = LoadStringA (module, i + 30000, revinfo, sizeof(revinfo)); if (len == 0) break; /* end of revision info */ - if (len >= sizeof(revinfo)) + if (len >= sizeof(revinfo) - 1) report (R_FATAL, "Revision info too long."); if(!(p = strrchr(revinfo, ':'))) report (R_FATAL, "Revision info malformed (i=%d)", i); *p = 0; rev_infos[i].file = strdup(revinfo); rev_infos[i].rev = strdup(p + 1); - } while(1); + } } void* extract_rcdata (int id, DWORD* size) @@ -196,7 +194,7 @@ return addr; } -/* Fills out the name, is_elf and exename fields */ +/* Fills in the name, is_elf and exename fields */ void extract_test (struct wine_test *test, const char *dir, int id) { @@ -459,48 +457,45 @@ cmdLine = mystrtok (cmdLine); while (cmdLine) { - if (*cmdLine == '-') - if (cmdLine[2]) { - report (R_ERROR, "Not a single letter option: %s", - cmdLine); - usage (); - exit (2); - } - cmdLine++; - switch (*cmdLine) { - case 'c': - report (R_TEXTMODE); - break; - case 'h': - usage (); - exit (0); - case 'q': - report (R_QUIET); - break; - case 's': - submit = mystrtok (NULL); - if (tag) - report (R_WARNING, "ignoring tag for submit"); - send_file (submit); - break; - case 'o': - logname = mystrtok (NULL); - run_tests (logname, tag); - break; - case 't': - tag = mystrtok (NULL); - cp = badtagchar (tag); - if (cp) { - report (R_ERROR, "invalid char in tag: %c", *cp); - usage (); - exit (2); - } - break; - default: - report (R_ERROR, "invalid option: -%c", *cmdLine); + if (cmdLine[0] != '-' || cmdLine[2]) { + report (R_ERROR, "Not a single letter option: %s", cmdLine); + usage (); + exit (2); + } + switch (cmdLine[1]) { + case 'c': + report (R_TEXTMODE); + break; + case 'h': + usage (); + exit (0); + case 'q': + report (R_QUIET); + break; + case 's': + submit = mystrtok (NULL); + if (tag) + report (R_WARNING, "ignoring tag for submit"); + send_file (submit); + break; + case 'o': + logname = mystrtok (NULL); + run_tests (logname, tag); + break; + case 't': + tag = mystrtok (NULL); + cp = badtagchar (tag); + if (cp) { + report (R_ERROR, "invalid char in tag: %c", *cp); usage (); exit (2); } + break; + default: + report (R_ERROR, "invalid option: -%c", cmdLine[1]); + usage (); + exit (2); + } cmdLine = mystrtok (NULL); } if (!logname && !submit) { Index: maketest =================================================================== RCS file: /home/wine/wine/programs/winetest/maketest,v retrieving revision 1.4 diff -u -r1.4 maketest --- maketest 20 Mar 2004 19:21:39 -0000 1.4 +++ maketest 22 Mar 2004 23:03:43 -0000 @@ -16,13 +16,15 @@ echo "$i \"$test\"" done -if [ -f revision.info ]; then - i=0 - for line in `cat revision.info`; do - i=`expr $i + 1` - echo "$i+30000 \"$line\"" - done -fi +i=30000 +cd $TOPSRCDIR +for dir in dlls/*/tests; do + sed -ne "s|^/$[^.]*.c$/$[^/]*$.*|$dir/\1:\2|p" $dir/CVS/Entries 2>/dev/null +done |\ +while read; do + echo "$i \"$REPLY\"" + i=`expr $i + 1` +done echo "}" Index: send.c =================================================================== RCS file: /home/wine/wine/programs/winetest/send.c,v retrieving revision 1.7 diff -u -r1.7 send.c --- send.c 19 Mar 2004 19:15:23 -0000 1.7 +++ send.c 22 Mar 2004 23:03:43 -0000 @@ -158,7 +158,7 @@ report (R_STATUS, "Sending %u bytes of data", filesize); report (R_PROGRESS, 2, filesize); - while ((bytes_read = fread (buffer, 1, BUFLEN / 8, f))) { + while ((bytes_read = fread (buffer, 1, BUFLEN / 2, f))) { if (send_buf (s, buffer, bytes_read)) { report (R_WARNING, "Error sending body: %d, %d", errno, WSAGetLastError ());

2 4

appdb bug
by Ivan Leo Murray-Smith March 24, 2004

March 24, 2004

On this page http://appdb.winehq.org/appview.php?appId=935&versionId=1229 there should be 6 comments, but only 2 are displayed, can someone hacking one the appdb code, or J.N. look into this? Ivan.

3 2

Appdb bug
by Ivan Leo Murray-Smith March 24, 2004

March 24, 2004

The search from the admin pages returns a 404 error: The requested URL /admin/search.php was not found on this server. Can someone please fix this? Ivan.

2 1

Re: CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.
by Uwe Bonnes March 24, 2004

March 24, 2004

>>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: C> Add minimal parameter validation to function C> CURSORICON_SimulateLoadingFromResourceW(...). We check that the icon Providing a test case for such special behaviour is a good idea... -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 4

Re: CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.
by Stefan Leichter March 24, 2004

March 24, 2004

Hello Uwe, i fear your test will only test what you like to test if it is executed in the source directory. For "out of tree builds" your test case tests how LoadImageA behaves when the specified file does not exist. Bye Stefan Am Dienstag, 23. März 2004 21:29 schrieb Uwe Bonnes: > >>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: > > C> Uwe Bonnes wrote: > >>>>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: > > C> Add minimal parameter validation to function > C> CURSORICON_SimulateLoadingFromResourceW(...). We check that the icon > > >> Providing a test case for such special behaviour is a good idea... > > C> I created this patch as a result of consulting I performed at a > C> customer's site. I no longer have access to the winedbg info I had > > It this what you meant? > > The test succeeds on NT and crashes on wine

2 2

Re: Problem with code in WWN 214
by Brian Vincent (C) March 24, 2004

March 24, 2004

> WWN 214 contains some sample code and in my browser I see: > There are two things that are wrong: > * The #include statements are incomplete. That's because the HTML looks > like this: Yeah, that's just a problem with the server side stuff. Newman - do you happen to know why? Seems like an XML parser thing. > ' ' results in two line feeds eventhough that may be a bug in There should not be a ... the real tag is which is both XML and HTML compliant. <pre> is an evil tag if you use CSS, it should never be used on WineHQ. This does bring up a good point, <code> displays weird on WineHQ, compare it to how Zack does it: http://www.kerneltraffic.org/wine/wn20040312_214.html I think the problem is for two reasons: 1) There's no CSS definition for BR. There should be and maybe it should look something like: { margin-bottom: 3px; margin-top: 3px } Likewise, I tend to use <ul> for doing indenting and it needs to have less whitespace above and below. Or, maybe <dl> could be changed and I can abuse that instead. 2) That particular instance has some markup problems, I put in a couple of extra tags in a few places. Corollary to Linus' feelings on backups: Proofreading is for wimps. Real men publish their writing to a news site and have everyone else spellcheck it. (Although, you'll notice since Newman set me up with CVS acces I do tend to do a quick once over after committing it and then fix obvious mistakes. If you have any scripts that automate this I should be able to easily automate it into the existing publishing system I have. XML doesn't lend itself to spellchecking too easily, so I've never pursued it.) --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

2 1

Re: Cards.dll improvements
by Filip Navara March 24, 2004

March 24, 2004

Sam wrote: >This patch implements card drawing mode flag >for rounding card corners. > >Sami Nopanen, xasmx(a)optonline.net > > I know it was propably suggested earlier, but why don't you use (or adapt) my cards.dll implementation for ReactOS? http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/lib/cards/ Regards, Filip

1 0

Re: Win32 packages released on sourceforge
by Ivan Leo Murray-Smith March 24, 2004

March 24, 2004

> I am kind of holding my breath for a regular build of winetest.exe - any > chance for that soon? :-) It depends on how you define regular. If you mean daily/weekly builds, I have no idea. But I can build winetest.exe when I build the win32 packages, when A.J. releases wine. Ivan.

9 30