April 2004 - Wine-Devel - list.winehq.org

Invalid curdrive and curdir
by jeffl April 22, 2004

April 22, 2004

All, I am tracking a problem where an install program with an exception trying to access 0x00000000 memory. I have tracked the problem down to files/drive.c in DRIVE_GetCurrentDirectory where dos_cwd contains 0 and is used in ret = strlenW(dos_cwd) + 3; /* length of WHOLE current directory */ It seems that DRIVE_GetCurrentDrive returns a value greater than MAX_DOS_DRIVES (25) and then return DOSDrives[drive].dos_cwd; where dos_cwd=0; pTask->curdrive and pTask->curdir appear not to be set or invalid. Now it seems that a check for null ptr in DRIVE_GetCurrentDirectory is order ie. UINT ret; LPCWSTR dos_cwd = DRIVE_GetDosCwd( DRIVE_GetCurrentDrive() ); static const WCHAR driveA_rootW[] = {'A',':','\\',0}; if (dos_cwd == 0) { ERR("dos_cwd returned 0 instead of pointer to current working directory\n"); dos_cwd = "\0"; /* make a valid string for strlenW */ } ret = strlenW(dos_cwd) + 3; /* length of WHOLE current directory */ if (ret >= buflen) return ret + 1; but what would be a good value for dos_cwd? I am interested in what causes the pTask->curdrive to be greater than 25 and curdir to be set to ???????? as shown below. Wine-dbg>p *pTask {hNext=0, ss_sp=0, nEvents=0, priority=0, unused1=0, hSelf=4143, hPrevInstance=0, unused2=0, ctrlword8087=0, flags=16, error_mode=0, version=1024, hInstance=0, hModule=0, hQueue=4199, hParent=0, signal_flags=0, sighandler=0x00000000, userhandler=0x00000000, discardhandler=0x00000000, int0=0x00000000, int2=0x00000000, int4=0x00000000, int6=0x00000000, int7=0x00000000, int3e=0x00000000, int75=0x00000000, compat_flags=0, unused4="", teb=0x4002f000, unused5="", hPDB=4151, dta=272040064, curdrive=254, curdir="????????", nCmdShow=1, hYieldTo=0, dlls_to_init=0, hCSAlias=4167, thunks={0, 21584, 0, 8, 16, 0, 0, 0, 24, 0, 0, 0, 32, 0, 0, 0, 40, 0, 0, 0, 48, 0, 0, 0, 56, 0, 0, 0, 0, 0, 0, 0}, module_name="", magic=17492, hEvent=0x0000000c, pdb={int20=8397, nextParagraph=0, reserved1=0, dispatcher="?", savedint22=0x00000000, savedint23=0x00000000, savedint24=0x00000000, parentPSP=0, fileHandles="????????????????????", environment=4159, saveStack=0, nbFiles=20, fileHandlesPtr=272039960, hFileHandles=0, reserved3={0, 0, 0, ...}, ...}...} Wine-dbg> Jeff Latimer

1 0

Anyone working on WSALookupServiceBegin() and WSALookupServiceNext?
by Robbert Xerox April 22, 2004

April 22, 2004

Simple question : is anyone working on WSALookupServiceBegin() and WSALookupServiceNext() in winsock? ____________________________________________________________ Yahoo! Messenger - Communicate instantly..."Ping" your friends today! Download Messenger Now http://uk.messenger.yahoo.com/download/index.html

1 0

richedit - anybody trying to do it ?
by Krzysztof Foltman April 22, 2004

April 22, 2004

Hi, Just out of curiosity: is anyone already actively developing a (supposedly) fully featured richedit control ? The current version looks like a plain editor combined with RTF reader... -- Chris

5 5

speed up oleaut32: vartest
by Chris Morgan April 22, 2004

April 22, 2004

*dlls/oleaut32/tests/vartest.c: Chris Morgan<cmorgan(a)alum.wpi.edu> Skip over most of the unused variant types to speed up the variant tests. This look like a reasonable way to speed up the variant tests without losing testing functionality? Chris

1 1

RE: Fix for GetFileTime API - Incorrect Modified/Last access Time .
by Krishna Murthy April 22, 2004

April 22, 2004

We have Team Developer Product for MS Windows which has its own language and in the process of verifying on Wine. Few of test cases working on Windows are failing in Wine. Hence I have submitted this patch. Yes, since Pre-1970 times are not going to work on Unix anyway we could release note this in our product. Thanks for your input on this. Krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Wednesday, April 21, 2004 6:16 PM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: Fix for GetFileTime API - Incorrect Modified/Last access Time. Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > Change of argument type DWORD to LONGLONG of function > RtlSecondsSince1970ToTime() and RtlSecondsSince1980ToTime() to accept > negative values. These are Windows APIs, you cannot simply change their arguments, we have to be compatible. Pre-1970 times are not going to work right on Unix anyway; what do you need them for? -- Alexandre Julliard julliard(a)winehq.org

1 0

winetest oddity - oleaut32: VarTest
by Chris Morgan April 22, 2004

April 22, 2004

I've been looking at vartest, specifically to speed it up since the tests I added for VarMod() are the cause of its current excessive length. Something appears to be a bit different with mingw compiled tests vs. MSVC compiled tests. Under wine these tests run just fine, three fixmes popup. I get two failures when running the oleaut32 vartest on my XP machine. This is compiled with vc6sp5+processor pack. Running the mingw compiled test from Paul Millar, http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-20040421-100…, there are thousands of failures for the same test. Anyone have a clue what might be causing this? One thing that came to mind was that there are int64's used in the ole code, the test won't compile cleanly under vc6 without the processor pack. Maybe mingw is messing up the int64's? Chris

1 0

Re: Fix for GetFileTime API - Incorrect Modified/Last access Time.
by Alexandre Julliard April 22, 2004

April 22, 2004

Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > Change of argument type DWORD to LONGLONG of function > RtlSecondsSince1970ToTime() and RtlSecondsSince1980ToTime() to accept > negative values. These are Windows APIs, you cannot simply change their arguments, we have to be compatible. Pre-1970 times are not going to work right on Unix anyway; what do you need them for? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Wine detect patch (ignore previous whitespace patch)
by Ferenc Wagner April 21, 2004

April 21, 2004

Jakob Eriksson <jakov(a)vmlinux.org> writes: > (Sorry about the linespace noise after print_version(), > emacs seems to change stuff behind my back when I save.) Hi Jakob, You'd better educate Emacs about your ways, otherwise all your patches will be full of whitespace changes making them very hard to review. The indentation isn't consistent, but if you want to fix this, do so in a separate patch, please! > + static const TCHAR wine[128] = {"Wine"}; I think we could use static const char wine[] = "Wine"; instead. No wide characters in winetest for now. But see below! > + if (running_on_wine ()) { /* Make a an obvious signature for Wine */ > + ext = 1; > + > + ver.dwMajorVersion = 1; > + ver.dwMinorVersion = 1; > + ver.dwBuildNumber = 1; > + ver.dwPlatformId = 1; > + strncpy (ver.szCSDVersion, wine, sizeof (wine)); > + } > + I think we can do better. A single line like xprintf (" bRunningUnderWine=%d\n", running_under_wine ()); as the first line of print_version() would do a perfect job without masking anything else. -- Feri.

2 1

Re: Winetest results uploaded... where?
by Ivan Leo Murray-Smith April 21, 2004

April 21, 2004

On http://test.winehq.org/data/200404192305/ the "next build" and "previous build" buttons are broken. I get a error message, saying "You don't have permission to access /site on this server." Ivan.

4 12

Re: White-space patch for programs/winetest/main.c
by Alexandre Julliard April 21, 2004

April 21, 2004

Jakob Eriksson <jakov(a)vmlinux.org> writes: > This is also an example of how the file can store its indent > preference in a comment. > > I will run this when I'm done editing the file: > FILENAME=main.c && `grep indent $FILENAME` $FILENAME I don't think that's a good idea at all. It would require everybody to do that every time they make a change to that file, otherwise there will be plenty of spurious whitespace changes and conflicts. Please don't do that. -- Alexandre Julliard julliard(a)winehq.org

2 2