May 2004 - Wine-Devel - list.winehq.org

Re: [DMUSIC] IDirectMusicSegment8 loading of Wave Segments
by Rok Mandeljc May 26, 2004

May 26, 2004

> PS: > Rok, i have you have implemented IDirectMusicSegment8 interface on > IDirectMusicWaveImpl. > Why ? > What it your "sample" who permit to check this behavior ? > For testing my patch you only have, for example, to open a .wav file using > 3DAudio.exe sdk sample Hey, I'm sorry but I cannot really remember (have experienced computer crash and it will take some time for me to organise everything again). I'm not even sure if IDirectMusicSegment should be implemented for it, but i think my test was to create native IDirectMusicWave via CoCreateInstance and then try to QueryInterface it with all possible IIDs; I can't remember result, but I think it was supported (unless I made a mistake ;=) - Rok

2 1

Assume MAX_PATH length for pszDisplayName
by Uwe Bonnes May 26, 2004

May 26, 2004

Changelog: dlls/shell32/brsfolders.c: SHBrowseForFolderA LPBROWSEINFOA->pszDisplayName is assumed to have MAX_PATH legth Fixes a crash in Xilinx ISE when vreating a new project with a long path -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/shell32/brsfolder.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/brsfolder.c,v retrieving revision 1.51 diff -u -w -5 -r1.51 brsfolder.c --- wine/dlls/shell32/brsfolder.c 19 Apr 2004 20:12:14 -0000 1.51 +++ wine/dlls/shell32/brsfolder.c 26 May 2004 13:56:29 -0000 @@ -460,11 +460,12 @@ bi.hwndOwner = lpbi->hwndOwner; bi.pidlRoot = lpbi->pidlRoot; if (lpbi->pszDisplayName) { len = MultiByteToWideChar(CP_ACP, 0, lpbi->pszDisplayName, -1, NULL, 0); - bi.pszDisplayName = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); + /*lpbi->pszDisplayName is assumed to be MAX_PATH (MSDN) */ + bi.pszDisplayName = HeapAlloc(GetProcessHeap(), 0, MAX_PATH * sizeof(WCHAR)); MultiByteToWideChar(CP_ACP, 0, lpbi->pszDisplayName, -1, bi.pszDisplayName, len); } else bi.pszDisplayName = NULL;

1 0

Type in msvcrt
by Uwe Bonnes May 26, 2004

May 26, 2004

Changelog: dlls/msvcrt/file.c: _setmode() Reset only the affected flag Make Xilinx ise not hang at startup Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/msvcrt/file.c =================================================================== RCS file: /home/wine/wine/dlls/msvcrt/file.c,v retrieving revision 1.67 diff -u -w -5 -r1.67 file.c --- wine/dlls/msvcrt/file.c 13 May 2004 00:23:25 -0000 1.67 +++ wine/dlls/msvcrt/file.c 26 May 2004 12:17:06 -0000 @@ -1437,11 +1448,11 @@ if (mode & (~(_O_TEXT|_O_BINARY))) FIXME("fd (%d) mode (0x%08x) unknown\n",fd,mode); if ((mode & _O_TEXT) == _O_TEXT) MSVCRT_fdesc[fd].xflag |= WX_TEXT; else - MSVCRT_fdesc[fd].xflag &= WX_TEXT; + MSVCRT_fdesc[fd].xflag &= ~WX_TEXT; return ret; } /********************************************************************* * _stati64 (MSVCRT.@)

1 0

Re: Re: [OLE] Better handling of References
by fenix＠club-internet.fr May 26, 2004

May 26, 2004

>On Wed, 26 May 2004 03:55:25 +0200, Raphael wrote: >> I'm trying to install Splinter Cell Demo (installshield). >> And i have seen: >> - one typelib was released while typeinfos (childs of typelib) are in use >> - the install "crash" (catched and returns an E_UNEXPECTED error) when it >> wants to call ITypeInfo_fnGetContainingTypeLib (who want to AddRef the >> freshly released TypeLib) > >Hi Raphael, Hi Mike >This has been a known problem for a long time now, with several attempts >to fix it, all of them have been incorrect. It seems your approach is a >new one and interesting, but I'm not sure this is how Windows does it. Well Soft References are used in many places in COM (for example D3D textures/surfaces use it on windows) >Does anybody know exactly what Windows does in this situation? It might be >worth writing a test case to find out. > >Objects in a semi-freed state seem like a slightly odd way to do things. > >> Now i have another crash later, but it seems a problem with an invoke method >> who failed :( >> If any ole/rpc expert can look at this problem i'll be very happy :) > >Well, if you could provide more detail (backtrace etc) on the crash it >would be good. I can't have a backtrace as i can't get winedbg working correctly on installshield programs :( But i'll send you the traces later (when i'll be back home). For what i have see it's a problem of ITypeInfo::Invoke when it should returns a Pointer to an IUnknown Variant. InstallShield complains about Objects References not set !! >A few comments on the patch: > >- --(This->ref); >+ /** escape decrement for soft_references */ >+ if (This->ref > 0) { >+ --(This->ref); >+ } else { >+ ERR("trying to Release again an ITypeLib2 in freing state waiting for ITypeInfo (%p) childs Releases\n", This); >+ } > >I don't remember whether this object is supposed to be thread safe or not, >but should this not be an InterlockedDecrement? Yes, but as the code of ITypeLib2/ITypeInfo don't seems thread safe at all ... (anyway i'll fix it) :) >I think the error could be better phrased as: > >ERR("Reference count on an ITypeLib2 object (%p) already zero: waiting for >ITypeInfo children to be released as well"); :) >or words to that effect. > >+ if (This->soft_ref > 0) { >+ ERR("trying to Release an ITypeLib2 while some ITypeInfo (%p) childs are actually with Refs > 1. So Dont free it now \n", This); >+ /** maybe scaning ITypeInfo list to dump ITypeInfos with Refs > 1 */ >+ return 1; >+ } > >Is it actually an error to do that? If you free a typelib while refs are >held on child typeinfos, is this a bug in the app or a legitimate thing to >do? If it's not a bug in the app we probably shouldn't use ERR here. Weel, we had problems like that on d3d8 (a long time ago) about ref counting. For me, seems more a wine bug (we have to found where missing AddRefs as to be done) than an app bug (new traces can help us to find what happened) >--- variant.c 30 Apr 2004 18:32:58 -0000 1.97 >+++ variant.c 26 May 2004 01:46:44 -0000 >@@ -605,6 +605,8 @@ > > hres = VARIANT_ValidateType(V_VT(pVarg)); > >+ if (V_VT(pVarg) == VT_EMPTY) return hres; >+ > if (SUCCEEDED(hres)) > { > if (!V_ISBYREF(pVarg)) > >This change looks OK though I'm not sure why it's necessary. Does the >Splinter Cell installer actually need this? No, i have only to no have a lot of debug traces (i have added on my tree) on Variant* Operations when clearing already empty Variants >thanks -mike > Regards, Raphael

2 1

Re: [OLE] Better handling of References
by Mike Hearn May 26, 2004

May 26, 2004

Oops, sending to wine-devel too (this is what I get for using a newsreader...) On Wed, 26 May 2004 03:55:25 +0200, Raphael wrote: > I'm trying to install Splinter Cell Demo (installshield). > And i have seen: > - one typelib was released while typeinfos (childs of typelib) are in use > - the install "crash" (catched and returns an E_UNEXPECTED error) when it > wants to call ITypeInfo_fnGetContainingTypeLib (who want to AddRef the > freshly released TypeLib) Hi Raphael, This has been a known problem for a long time now, with several attempts to fix it, all of them have been incorrect. It seems your approach is a new one and interesting, but I'm not sure this is how Windows does it. Does anybody know exactly what Windows does in this situation? It might be worth writing a test case to find out. Objects in a semi-freed state seem like a slightly odd way to do things. > Now i have another crash later, but it seems a problem with an invoke method > who failed :( > If any ole/rpc expert can look at this problem i'll be very happy :) Well, if you could provide more detail (backtrace etc) on the crash it would be good. A few comments on the patch: - --(This->ref); + /** escape decrement for soft_references */ + if (This->ref > 0) { + --(This->ref); + } else { + ERR("trying to Release again an ITypeLib2 in freing state waiting for ITypeInfo (%p) childs Releases\n", This); + } I don't remember whether this object is supposed to be thread safe or not, but should this not be an InterlockedDecrement? I think the error could be better phrased as: ERR("Reference count on an ITypeLib2 object (%p) already zero: waiting for ITypeInfo children to be released as well"); or words to that effect. + if (This->soft_ref > 0) { + ERR("trying to Release an ITypeLib2 while some ITypeInfo (%p) childs are actually with Refs > 1. So Dont free it now \n", This); + /** maybe scaning ITypeInfo list to dump ITypeInfos with Refs > 1 */ + return 1; + } Is it actually an error to do that? If you free a typelib while refs are held on child typeinfos, is this a bug in the app or a legitimate thing to do? If it's not a bug in the app we probably shouldn't use ERR here. ++(This->ref); + if (This->ref > 1) { + if (NULL != This->pTypeLib) ++(This->pTypeLib->soft_ref); + } + Ditto on thread safety. Please forgive me if this object is not free threaded. --- variant.c 30 Apr 2004 18:32:58 -0000 1.97 +++ variant.c 26 May 2004 01:46:44 -0000 @@ -605,6 +605,8 @@ hres = VARIANT_ValidateType(V_VT(pVarg)); + if (V_VT(pVarg) == VT_EMPTY) return hres; + if (SUCCEEDED(hres)) { if (!V_ISBYREF(pVarg)) This change looks OK though I'm not sure why it's necessary. Does the Splinter Cell installer actually need this? thanks -mike

1 0

CoRegisterMessageFilter
by Simon Harvey May 26, 2004

May 26, 2004

hello I was wondering if anybody was doing work on or was in the process of implementing CoRegisterMessageFilter in dlls/ole32/ole2.c ? I would like to take a stab at it but i wont if somebody else is going to do it. thanks simon Find local movie times and trailers on Yahoo! Movies. http://au.movies.yahoo.com

2 1

Bad wine today.
by Rein Klazes May 26, 2004

May 26, 2004

Hi, I wonder if I am the only one that sees this with any windows prog that I try: |$ wine sol |x11drv: Can't open display: |Please ensure that your X server is running and that $DISPLAY is set correctly. |$ (other X programs run fine). I did the usual things when in trouble: a make clean, fresh cvs update. That did not help. Debugmessages "+all", does not give any messages. Version win98 or win2k makes no difference. Reverting to the yesterdays cvs, makes wine work again. Any idea? Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 2

Crash and corrupted registry
by Christian Costa May 25, 2004

May 25, 2004

Hi, This is the second time I had to reboot when by box is stuck while running a windows apps. In both case the registry had been corrupted. This is very annoying. Could we have the wineserver do a backup of registry files at startup so we can retreive the previous version if a corruption occurs? That would be very usefull. Thanks, Christian

2 2

Re: Bad wine today.
by Ivan May 25, 2004

May 25, 2004

Current CVS works for me. Ivan.

1 0

Re: additional download for winehq download page
by Ivan May 25, 2004

May 25, 2004

< And if a prog doesn't provide the dll it should have at least a readme to tell people where to get it. I can tell you out of experience that this isn't always true. What about the attached patches? Ivan.

1 0