June 2004 - Wine-Devel - list.winehq.org

RE: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier
by Krishna Murthy June 22, 2004

June 22, 2004

Alexandre, Please find attached modified patch. The method DEFDLG_SetDefButton() now accepts the BOOL bSetDefID parameter to adapt for both DM_SETDEFID and WM_NEXTDLGCTL. Thanks, Krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Friday, June 18, 2004 10:30 AM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > No, it is required. The DEFDLG_SetDefButton() is also called from > message DM_SETDEFID. In this case idResult should set to the default > button ID passed. And the current logic of DEFDLG_SetDefButton() does > what is required for DM_SETDEFID. Well, of course you'd need to adapt the DM_SETDEFID handling to the change. I think that's better than sending duplicate messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: LISTBOX_Directory() returns LB_OKAY for invalid directory / f ilen ame
by Krishna Murthy June 22, 2004

June 22, 2004

Yesssss! got it, stupid mistake.... It should be... if ((le == ERROR_NO_MORE_FILES) || (le == ERROR_FILE_NOT_FOUND)) return LB_ERR; Thanks, Krishna -----Original Message----- From: Dimitrie O. Paun [mailto:dpaun(a)rogers.com] Sent: Tuesday, June 22, 2004 2:01 PM To: Krishna Murthy Cc: 'Alexandre Julliard'; wine-devel(a)winehq.org Subject: Re: LISTBOX_Directory() returns LB_OKAY for invalid directory / f ilen ame On Tue, Jun 22, 2004 at 11:08:28AM -0700, Krishna Murthy wrote: > The 'le' is an integer value and not a bitwise value. This means it > could have only one error condition at a time. Right. Because of this fact: > if ((le != ERROR_NO_MORE_FILES) || (le != ERROR_FILE_NOT_FOUND)) > return LB_ERR; Will always return LB_ERR. Proof: (le != ERROR_NO_MORE_FILES) || (le != ERROR_FILE_NOT_FOUND) ## by deMorgan's Law == !((le == ERROR_NO_MORE_FILES) && (le == ERROR_FILE_NOT_FOUND)) ## by transitivity == !(ERROR_NO_MORE_FILES == ERROR_FILE_NOT_FOUND) ## by the definition of these error codes == !(18 == 2) ## different numbers are not equal == !(FALSE) ## by negation == TRUE ;) -- Dimi. P.S. I haven't done a formal proof since I was doing my M.Sc. at UofT :)

2 1

RE: LISTBOX_Directory() returns LB_OKAY for invalid directory / f ilen ame
by Krishna Murthy June 22, 2004

June 22, 2004

The 'le' is an integer value and not a bitwise value. This means it could have only one error condition at a time. The condition: if ((le != ERROR_NO_MORE_FILES) && (le != ERROR_FILE_NOT_FOUND)) return LB_ERR; Could never return LB_ERR even if file was not found. Hence we have changed to the logical OR condition which could trigger error either if no more files or file not found: if ((le != ERROR_NO_MORE_FILES) || (le != ERROR_FILE_NOT_FOUND)) return LB_ERR; Please find attached sample executable (DIRLIST.exe.zip has the executable), which demonstrate the behavior change between windows and wine. Run the sample and enter invalid path name or file name and press enter (click on Display button). On windows it displays error message "DlgDirList Failed...". Same steps when repeated on wine, it does not display this error message because of the above logical error. Krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Friday, June 18, 2004 11:20 AM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: LISTBOX_Directory() returns LB_OKAY for invalid directory / filen ame Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > diff -u -r1.103 listbox.c > --- wine/controls/listbox.c 1 Apr 2004 04:57:12 -0000 1.103 > +++ wine/controls/listbox.c 17 Jun 2004 21:50:20 -0000 > @@ -1760,7 +1760,7 @@ > if ((handle = FindFirstFileW(filespec, &entry)) == INVALID_HANDLE_VALUE) > { > int le = GetLastError(); > - if ((le != ERROR_NO_MORE_FILES) && (le != ERROR_FILE_NOT_FOUND)) return LB_ERR; > + if ((le != ERROR_NO_MORE_FILES) || (le != > + ERROR_FILE_NOT_FOUND)) return LB_ERR; This makes the test completely useless, it can't be right. -- Alexandre Julliard julliard(a)winehq.org

2 1

Port to native x86_64?
by Sean Kormilo June 22, 2004

June 22, 2004

Greetings - I'm interested in porting Wine to run in native x86_64 mode, and was wondering if anyone had attempted to do such a thing already? I notice that there does not appear to be any support in CVS to do this, but figured that perhaps someone else is already undertaking such an effort. My main motivation for doing so has to do with video driver support, in that the 32bit "emulated" applications are unable to use the 64bit 3D accelerated drivers, and fall back to software rendering - which is less than ideal. While this may eventually be resolved by the device drivers, I'd rather not wait for them. Any comments, or hints as to what needs to be done (other than the obvious compile time fixes) would be appreciated. I've got software development experience, but none porting code from a 32bit architecture to a 64bit one. Thanks! Sean.

2 3

Re: bug in sound support?
by Ivan June 22, 2004

June 22, 2004

I haven't tested any non-directx software, anyway, both the winmm and dsound tests give quite a few errors, the logs are attached. I can hear the test tones, BTW the dsound one is much louder than the winmm one for no obvious reason. Ivan.

1 0

bug in sound support?
by Ivan June 22, 2004

June 22, 2004

Wine oss doesn't work with the via82cxxx_audio audio driver shipped in the linux kernel, no other app has any problems, so I'm wondering if it's wine related. What info is needed to debug this? Ivan.

2 1

Problem with Soundblaster Live and Wine
by Constantin Bergemann June 22, 2004

June 22, 2004

Hi, I have a problem with my Soundblaster Live and Wine. When running Windows Applications, they often set the mixer level for the PCM channel to 100%. However, the Soundblaster Live under Linux tends to sound a bit dirty at these levels, you have to use values under 80%. Is there anything I can do to tell wine to let this value unchanged? I am using ALSA and the OSS module of wine. Is anyone even aware of this problem? Thanks, Tony.

2 1

Re: Donations - RFC
by Brian Vincent June 21, 2004

June 21, 2004

> >I would say sponsoring Wineconf 2005 would be a better idea (so we could go > >somewhere exotic (not that St Paul in winter was not exotic in a kinda > >perverted way for most of us :-) )). > > > > > I have volunteered to organize it in Cyprus. I've already started > lobbying for that location. After last year's last minute "hey, it's > more comfortable in the US" change, I decided that long term preparation > for votes, like you do in any self-disrespecting parliament, is the only > way to go. I just a did a quick search and found that airfare to Cyprus is about twice that of anywhere in western Europe. That's about what I would expect too. The cheapest flights from North America are generally into London, Paris, Amsterdam, or Frankfurt. Sometimes Madrid and Rome are reasonable too. Cyprus also adds a fair amount of travel time. Don't get me wrong - Cyprus would be a cool destination and I would love to travel there. It's also wonderful someone is will to try to organize a location other than North America. However, I'm willing to bet a Cyprus location will be such an inconvenient place to get to that we'd keep a lot of people away.

2 1

Re: new shell32 icons
by Mike Hearn June 21, 2004

June 21, 2004

On Sun, 2004-06-20 at 21:55 -0400, Chris Morgan wrote: > *dlls/shell32/shres.rc: > Royce improved the 8bit versions of the icons but an unknown ReactOS author > drew these icons. > Improve shell32 icons. > > I've attached an image from my xp machine that has the old and new icons so > people can judge for themselves whether they are an improvement or not. I have to admit they are a big improvement but they seem to have been scaled badly at some point - the new icons seem rather fuzzy? Also you'll note that Crystal uses totally different icons for small sizes, maybe we should be using these as they are used in the filepicker.

1 0

Re: new shell32 icons
by Steven Edwards June 21, 2004

June 21, 2004

Hi --- Chris Morgan <cmorgan(a)alum.wpi.edu> wrote: > *dlls/shell32/shres.rc: > Royce improved the 8bit versions of the icons but an unknown ReactOS > author > drew these icons. > Improve shell32 icons. There were donated to ReactOS by Everaldo Coelho from the Crystal Icon set. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

1 0